Commit graph

3809 commits

Author SHA1 Message Date
mark_story
108a6611a8 Moving validation of sorting to a separate method. This makes it easier to test, extends and read.
Tests added.
2010-12-19 02:12:39 -05:00
mark_story
7b11eeb6e0 Updating tests to not use the deprecated Controller::$passedArgs.
Removing messy and hard to understand defaults + whitelisting from paginate() now that it has a separate method.
2010-12-19 01:57:51 -05:00
mark_story
6b3db0a3eb Pulling out parameter merging logic into a method, this allows specific typing of parameter merging (named, querystring, route). Also simplifies whitelisting of request parameters.
Tests added for merging and whitelisting.
2010-12-19 01:42:23 -05:00
mark_story
7585b2941e Adding paramType to the test cases. 2010-12-19 00:38:20 -05:00
mark_story
54c52d85fb Fixing failing tests in PaginatorComponent. 2010-12-18 17:29:47 -05:00
mark_story
6b9d9f4aea Reapplying changes in [33d2f9a6ed] as they got lost when the paginator component was extracted. 2010-12-18 17:17:43 -05:00
mark_story
7c6af5bfec Making a test actually test what its supposed to. 2010-12-18 17:01:26 -05:00
mark_story
319e622151 Added another test for querystring params. Querystring params should not be affected by greedy routes, as they are not really controlled by internal routing. 2010-12-18 16:51:54 -05:00
mark_story
eb9fe07472 Adding query string generation into CakeRoute. This removes one more task from Router. Tests added
Adding constants for the named param and querystring param sigils.
2010-12-18 16:44:21 -05:00
Juan Basso
5d2b4c758d Minor optimization in cache views. 2010-12-18 19:41:57 -02:00
Juan Basso
a7c7436d8e Passing viewVars to cache views, avoiding cake:nocache problems. 2010-12-18 19:31:10 -02:00
mark_story
b1630d4f07 Removing garbage from Paginator test cases. 2010-12-18 15:48:14 -05:00
mark_story
3b0a3d4109 Making route matching fail even faster. This gives significant performance boosts to routes not matching. 2010-12-18 14:36:11 -05:00
mark_story
756b09849f Router tests all pass now. 2010-12-18 14:26:45 -05:00
mark_story
328db0c36b Fixed a number of tests, there are still a few issues with prefix routes.
Moved removing defaults that are also keys to the compile step.  This
removes quite a few repetitive loops.
2010-12-18 14:18:21 -05:00
mark_story
8d404332a2 Fixing issue where named params equal to null/false would be part of the generated url. 2010-12-18 13:40:07 -05:00
mark_story
6ef8203d54 Adding another case that makes false/null to not cause match failure. 2010-12-18 13:32:05 -05:00
mark_story
456a14cf37 Refactored CakeRoute::match() to not use Set::diff(). This was the slowest part of reverse routing and this change should make things faster.
Added additional tests for the 0 edge case.
2010-12-18 12:34:48 -05:00
mark_story
c5bab54125 Starting to try and re-factor named params to perform better and be more
explicit with how they are used.
2010-12-18 00:15:09 -05:00
mark_story
de7b324444 Fixing more strict warnings.
Removing & on component callbacks.
Updating incorrect method signatures.
2010-12-18 00:03:03 -05:00
mark_story
f50a97bff1 Making PagesController test unskipped in all_tests. 2010-12-16 22:53:00 -05:00
mark_story
42754c63ff Making more tests no longer skip in test suites. 2010-12-16 00:01:43 -05:00
mark_story
95f58321a8 Removing a duplicate test, and extra classes. 2010-12-15 23:54:28 -05:00
mark_story
339cb41ea2 Using $_mergeParent to unskip tests in test suites. 2010-12-15 23:49:54 -05:00
mark_story
862a2bc25e Removing duplicate class definition that could cause test suite inconsistencies.
Adding skip for when AppController is defined.
Changing how mock models are constructed to better use Model::__construct parameters.
2010-12-15 23:33:00 -05:00
mark_story
9dcea304c1 making assertions run against the test case, not the subject test case. 2010-12-15 22:19:44 -05:00
mark_story
5ff376e0a0 Adding parent calls. 2010-12-15 22:12:48 -05:00
mark_story
a054695dca Fixing failing tests. 2010-12-15 22:08:24 -05:00
Jeremy Harris
9e74283b90 Merge branch '2.0-1353' into 2.0 2010-12-14 20:42:03 -08:00
Jeremy Harris
904cb8a4a6 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2010-12-14 20:30:58 -08:00
Jeremy Harris
97c82e28a1 Fixed problems where running all tests will fail due to duplicate classes 2010-12-14 20:27:12 -08:00
mark_story
1531a7226e Removing duplicated tests, and tests for methods that are not implemented in the subclasses. 2010-12-14 23:26:24 -05:00
Juan Basso
a6014cfd8d Fixed the define name to run all socket tests. 2010-12-15 02:02:51 -02:00
Jeremy Harris
29441ca880 Added ObjectCollection test to libs group 2010-12-14 20:01:31 -08:00
Juan Basso
754c9b2c3d Updated to HttpSocket, HttpResponse and CakeSocket use SocketException. 2010-12-15 02:01:00 -02:00
Jeremy Harris
b9143dc7d4 Added ControllerTestCase class for testing controllers. Fixes #1244 2010-12-14 19:58:27 -08:00
Juan Basso
c0e2f63f7d Merge with 2.0-http. 2010-12-15 01:58:21 -02:00
Juan Basso
575da672b0 Fixed basic proxy test. 2010-12-15 01:54:37 -02:00
mark_story
84414eeb07 Removing CakeSession::watch() and CakeSession::ignore(). You should use logging, or an interactive debugger instead. 2010-12-14 22:35:43 -05:00
Jeremy Harris
10bf41a4df Merge commit '42a5ebf47b73bbdf200f0238e30e6d4893695f80' into 2.0 2010-12-14 19:00:26 -08:00
mark_story
19f9caed28 Fixing tests so they initialize the session, before trying to test things. 2010-12-14 21:59:53 -05:00
Jeremy Harris
9fa1bec0cb Move Controller::paginate() into PaginatorComponent 2010-12-14 18:21:39 -08:00
Juan Basso
cf7aae7911 Removed parseHeader from HttpSocket (it was not used). Moved the tests of parseHeader to HttpResponse. 2010-12-14 11:05:37 -02:00
mark_story
daf6084ccc Converting assertions to not use compatibility wrappers. 2010-12-13 23:59:57 -05:00
mark_story
106c1185b4 Making the id() test pass. 2010-12-13 23:59:57 -05:00
mark_story
8eebdffcbb Updating session to lazy start after the first time an operation has been performed. This should make controllers that only use sessions on some actions perform better. 2010-12-13 23:59:57 -05:00
Juan Basso
37303d9c37 HttpResponse::getHeader() is more flexible to accept a custom header list. 2010-12-14 02:52:40 -02:00
Juan Basso
2f64afe44e Allowing the user change the response class. 2010-12-14 02:46:31 -02:00
mark_story
53a687049c Fixing encoding of address aliases. They are now mime-encoded like other headers. Tests added. Fixes #1360 2010-12-13 23:23:02 -05:00
Juan Basso
176da15417 Moved the response methods from HttpSocket to HttpResponse. 2010-12-14 02:22:30 -02:00
Juan Basso
60a9d34027 Updated the HttpSocket to use the new HttpResponse. 2010-12-14 01:07:25 -02:00
Juan Basso
f45027ecd8 Adjusting HttpResponse responses in array to be more compatible. 2010-12-14 01:06:57 -02:00
mark_story
e410509684 Fixing TestTask not being able to find plugin objects when baking test skeletons interactively. Test case added. Fixes #1361 2010-12-13 22:04:55 -05:00
Juan Basso
dfb76d67da Created the HttpResponse to get HttpSocket responses. 2010-12-14 00:16:45 -02:00
mark_story
2fe60142f5 Fixing more strict warnings. 2010-12-12 21:09:56 -05:00
mark_story
0ac8d04241 Fixing more strict warnings. 2010-12-12 21:02:42 -05:00
Juan Basso
c20b5d7053 Renamed setAuthConfig to configAuth, and setProxyConfig to configProxy. 2010-12-12 23:48:04 -02:00
mark_story
017385d61c Fixing most of the strict errors in the helper test suite. 2010-12-12 20:21:14 -05:00
mark_story
dc7ff8911d Fixing tests in ComponentCollection and HelperCollection as return of trigger now depends on the triggered objects.
Removing annoying test that broke anytime something changed in Model.
2010-12-12 18:02:45 -05:00
mark_story
bf22af6b7f Fixing more strict errors and usage errors in BehaviorCollection test.
Making modParams only work if the result is an array.  This is for compatibility with previous behaviour.
2010-12-12 17:42:40 -05:00
mark_story
ce2e6053e4 Adding containable to the AllBehaviors test as it now runs. 2010-12-12 17:40:41 -05:00
mark_story
48879f8264 Fixing strict errors in translate and acl behaviors.
Removing conditional definition of I18nModel.  There is no reason for it to exist anymore.
Removing duplicate class definition.
2010-12-12 17:38:49 -05:00
mark_story
df21d19c4c Making a bunch of properties public so containable can hack around. Need to refactor and fix visibility issues.
Fixing failing tests in containable.
2010-12-12 15:48:36 -05:00
mark_story
10c358742b Making modParams ignore null results.
Test added.
2010-12-12 15:33:24 -05:00
mark_story
81e009b816 Fixing additional strict warnings. 2010-12-12 15:02:38 -05:00
mark_story
33b8a35b75 Fixing strict warnings in TreeBehavior and a few other classes. 2010-12-12 14:56:48 -05:00
mark_story
96968f7194 Moving the modParams option into ObjectCollection, so it can replace the specific trigger method in BehaviorCollection.
Changed how break behaves, so it is works better with modParams and collectReturn options.
Tests updated and expanded.
2010-12-12 14:10:22 -05:00
mark_story
d14d148948 Making scaffold form view names consistent with those used in bake.
Renaming test_app files.
Fixes #501
2010-12-12 13:18:28 -05:00
mark_story
11df32148f Updating scaffold templates to use post forms for delete buttons. Updating test case. 2010-12-12 13:13:00 -05:00
mark_story
44c080d5ad Making all core classes throw CakeException subclasses, this allows developers to catch framework exceptions with one catch.
Adding package specific exceptions.
Replacing generic exceptions in the codebase with CakeException + package exceptions.
2010-12-11 19:26:10 -05:00
Jeremy Harris
b3f55bfd29 Added shorter timeout to fsockopen checks 2010-12-11 13:23:23 -08:00
Juan Basso
d332f0624f Making the cookies independent for each host. 2010-12-11 16:49:19 -02:00
mark_story
60ada4432a Making unknown errors with codes higher than 500 render as error500.
Test added.
2010-12-11 13:30:29 -05:00
mark_story
504b4d495f Adding stack traces to logged exceptions, as I forgot them last time around. 2010-12-11 12:47:16 -05:00
Juan Basso
eeafb55d31 Support to download requests. 2010-12-11 14:44:45 -02:00
mark_story
ceca179184 Fixing more tests that were failing post merge. 2010-12-10 23:17:42 -05:00
mark_story
1e108748e9 Fixing validation methods + features lost in [f51ce734] due to a bad
merge.
Fixing additional tests to reflect changes in 2.0
2010-12-10 22:52:22 -05:00
mark_story
b9f0fc0724 Merge branch '1.3' into merger
Conflicts:
	cake/dispatcher.php
	cake/libs/cake_session.php
	cake/libs/controller/components/cookie.php
	cake/libs/controller/components/email.php
	cake/libs/controller/controller.php
	cake/libs/controller/scaffold.php
	cake/libs/set.php
	cake/libs/validation.php
	cake/libs/view/view.php
	cake/tests/cases/dispatcher.test.php
	cake/tests/cases/libs/controller/components/security.test.php
	cake/tests/cases/libs/controller/controller.test.php
	cake/tests/cases/libs/validation.test.php
	cake/tests/cases/libs/view/view.test.php
2010-12-10 22:24:31 -05:00
Juan Basso
453c5364c2 Putting the auth and proxy data in request attribute after request. 2010-12-10 10:44:28 -02:00
Juan Basso
d97103d739 Making the format attribute customizable in helpers. 2010-12-10 02:42:38 -02:00
mark_story
d7e62b88bc Adding test cases for using helpers in nested elements from email
templates.  Closes #1355
2010-12-09 22:34:20 -05:00
mark_story
a830632071 Changing View::element() to not overwrite viewVars with helpers that
have the same name.
Test added.
Fixes #1354
2010-12-09 22:06:23 -05:00
Graham Weldon
33d2f9a6ed Refs #621. Provides default maxLimit for pagination to prevent url manipulation causing long queries. 2010-12-10 12:22:12 +11:00
Juan Basso
7c23d289e0 Minor optimizations. 2010-12-06 12:03:22 -02:00
Juan Basso
d656bdae3b Renamed proxy method and calling togheter from host config. 2010-12-06 11:28:40 -02:00
Juan Basso
30a70b700b HttpSocket::_configUri() always change config attribute and it is public. This function dont need return it. 2010-12-06 04:04:37 -02:00
mark_story
c096eea664 Fixing failing tests caused by constants changing. 2010-12-05 23:32:34 -05:00
mark_story
55e06ec244 Merge branch '2.0-config' into 2.0
Conflicts:
	cake/libs/configure.php
2010-12-05 23:00:05 -05:00
Jeremy Harris
8a7e2609cd Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2010-12-05 17:57:44 -08:00
Juan Basso
97fe32f87c Request return a pointer to body. It will reduce the memory usage in big responses. 2010-12-05 23:36:28 -02:00
Jeremy Harris
5eab027b84 Removed unnecessary pass by references 2010-12-05 17:28:15 -08:00
José Lorenzo Rodríguez
c559b9c22d Merge remote branch 'origin/2.0' into 2.0
Conflicts:
	cake/console/templates/skel/config/database.php.default
	cake/libs/model/datasources/dbo/dbo_sqlite.php
2010-12-05 20:51:37 -04:30
mark_story
5ad8d8af41 Adding a parameter to configured() to allow you to check if a particular config has been configured. 2010-12-04 22:57:33 -05:00
Juan Basso
c52d5320c8 Replaced the *printf with i18n aliases by i18n aliases with params. 2010-12-04 23:37:13 -02:00
mark_story
0b18fc25a6 Changing some requires so things run smoother. 2010-12-04 17:53:57 -05:00
mark_story
b49c4402e5 Implementing store and restore for Configure.
Test cases added.
2010-12-04 17:26:59 -05:00
mark_story
0cf02ec2f9 Fixing issues caused by CORE_PATH not being reliable. 2010-12-04 15:00:48 -05:00
mark_story
8031d33d33 Fixing more E_STRICT notices and adding a type check to DboSource::dropSchema(). 2010-12-04 14:37:02 -05:00
mark_story
a6c5065e9c Fixing a few more E_STRICT errors in postgres test/class. 2010-12-04 14:31:11 -05:00
mark_story
7e29859676 Fixing E_STRICT errors in test models. 2010-12-04 14:19:53 -05:00
mark_story
18fb12c95c Removing & pass by ref operators as they aren't needed any more.
Fixing a bunch of E_STRICT errors.
2010-12-04 14:15:32 -05:00
mark_story
64d1f799f8 Adding fixtures that fixed MissingTableExceptions I was getting. 2010-12-04 13:52:38 -05:00
mark_story
159f25ff0f Adding ini file and more tests for types. 2010-12-04 12:58:02 -05:00
mark_story
98704d3ecd Adding nested value support to IniReader.
Adding boolean conversions.
Adding test cases.
2010-12-04 12:56:37 -05:00
mark_story
1e569f509a Changing IniFile to be a ConfigReader for use with Configure. Test case updated. 2010-12-04 12:15:47 -05:00
mark_story
7eab3b2850 Moving load() logic out of Configure, and putting it into PhpReader.
Updating test cases.  store() still needs to be properly implemented.
2010-12-04 01:05:12 -05:00
mark_story
6618178e1b Adding more checks into PhpReader that currently exist in Configure. 2010-12-04 00:58:02 -05:00
mark_story
aef53cd23a Adding some more basic methods. 2010-12-04 00:14:55 -05:00
mark_story
da632fe191 Renaming method to match other core classes with similar features. 2010-12-04 00:10:42 -05:00
mark_story
9b8456ce6f Adding an interface to define the necessary public methods.
Adding insertion of configure readers.
Adding tests.
2010-12-04 00:09:11 -05:00
Juan Basso
c4743a2438 Changing the test with get to use version instead auth. 2010-12-04 01:41:45 -02:00
Juan Basso
123b2256c5 Formatting 2010-12-04 01:31:28 -02:00
Juan Basso
075bdebebe Moved the proxy configuration from request to class attribute. 2010-12-03 23:10:07 -02:00
Juan Basso
f004bef74f DigestAuthentication adapted to new auth in HttpSocket. 2010-12-03 21:57:15 -02:00
José Lorenzo Rodríguez
66d0986cd4 Pepending table name to index generation to avoid name clashes
Finally, all tests using a Sqlite database pass
2010-12-03 15:25:26 -04:30
José Lorenzo Rodríguez
e167271568 Making more DboSlite tests pass 2010-12-03 14:41:39 -04:30
José Lorenzo Rodríguez
7c4ab886e6 Merge remote branch 'origin/2.0' into feature/2.0/pdo 2010-12-03 14:08:03 -04:30
mark_story
7863f14d79 Adding new test cases into configure suite. 2010-12-02 23:34:13 -05:00
mark_story
bbb15c24a1 Adding more tests and better errors for PhpReader. 2010-12-02 23:30:28 -05:00
mark_story
ae328ffb3a Adding plugin support for PhpReader.
Tests added.
2010-12-02 23:14:26 -05:00
mark_story
fdb5955d6c Adding PhpReader to implement php file reading as per #1334 2010-12-02 23:06:08 -05:00
Juan Basso
4325e67163 Fixing setAuthConfig to accept false as param to remove auth config. Tests added. 2010-12-03 01:30:03 -02:00
Juan Basso
cd24aca39d Removing auth key from request and putting this as attribute. 2010-12-03 00:46:11 -02:00
José Lorenzo Rodríguez
2e04c5260e Fixing some tests to make them run on sqlite 2010-12-02 00:19:43 -04:30
mark_story
44b09171ef Adding unicode letters and numbers to url path segment regex.
Test case added.
Fixes #1284
2010-12-01 23:47:30 -05:00
Juan Basso
aa0bad9247 Ignore errorHandler if warning suppressor (@command()) is used. 2010-12-02 01:44:31 -02:00
dogmatic69
96b30f0547 adding tests for places that will leave a trailing 0 because of the way phps number_format() method works
Signed-off-by: mark_story <mark@mark-story.com>
2010-12-01 22:08:26 -05:00
Juan Basso
e1e8026392 Support to proxy authentication in basic authentication. 2010-12-01 14:00:10 -02:00
Juan Basso
b9010b05f2 Support to proxy in HttpSocket. 2010-12-01 13:46:13 -02:00
Juan Basso
634d686288 Merge branch '2.0' into 2.0-http 2010-12-01 11:49:26 -02:00
José Lorenzo Rodríguez
0d93520e0a Fixing test case for sqlite 2010-11-29 20:52:32 -04:30
Juan Basso
ffaec10a7c Fixing the result of App::import() when name of class have slash. 2010-11-29 22:37:08 -02:00
José Lorenzo Rodríguez
130fe603a7 Skipping test incompatiblw with mysql 2010-11-28 23:34:20 -04:30
José Lorenzo Rodríguez
592dda92de Fixing test to make it pass using DboSqlite 2010-11-28 22:48:34 -04:30
Mark Story
40585a34e8 Adding support for userPath in IniAcl.
Test case added.
Fixes #1291
2010-11-28 21:22:10 -05:00
Mark Story
2495b3cd4c Trimming whitespace and adding a file header. 2010-11-28 21:11:18 -05:00
Mark Story
3ddff879b1 Converting IniAcl to use IniFile, this removes one of the classes responsibilities. 2010-11-28 21:06:22 -05:00
Mark Story
35611d50c3 Fleshing out IniFile a bit more. 2010-11-28 21:05:32 -05:00
Mark Story
071cd9b477 Adding very naive implementation of an ini file parser. 2010-11-28 21:05:32 -05:00
mark_story
9d3b3a72ce Starting to extract Ini file parsing out of IniAcl as it breaks single responsibility, and ini file parsing should be generic enough to be reused.
Adding a test case.
2010-11-28 21:05:32 -05:00
Mark Story
1f72e504d5 Fixing incorrect imports that caused test case to fail in CLI when run by itself. 2010-11-28 20:49:42 -05:00
mark_story
284a8db3f4 Moving error handling classes into a separate directory.
Moving error handling test cases into a directory that matches the one in libs.
Updating imports.
2010-11-28 12:27:51 -05:00
Jeremy Harris
1411e9495e Fixed failing test due to missing CakeRequest class 2010-11-27 12:47:19 -08:00
Jeremy Harris
8492f2055b Added tests for object collection 2010-11-27 12:09:43 -08:00
José Lorenzo Rodríguez
0ff01330c4 Making dates deconstruction in model more consistent for different datasources 2010-11-27 00:13:04 -04:30
José Lorenzo Rodríguez
41ee035d28 Starting to bring sqlite dbo up to date 2010-11-26 23:46:34 -04:30
José Lorenzo Rodríguez
b6731dd9ad Merge remote branch 'origin/2.0' into feature/2.0/pdo
Conflicts:
	cake/tests/cases/libs/model/datasources/dbo/dbo_mysql.test.php
	cake/tests/cases/libs/model/datasources/dbo/dbo_mysqli.test.php
2010-11-26 20:26:41 -04:30
ADmad
70ae66edf7 Fixing test cases for EmailComponent 2010-11-27 01:21:19 +05:30
mark_story
04d3feb6c0 Unknown errors cannot be mapped as they generate another error. Having a default case doesn't make much sense here.
Adding additional coverage to ErrorHandler.
2010-11-25 22:51:30 -05:00
mark_story
f2f3f13c75 Adding exception logging configuration setting. Allows uncaught exceptions to be logged.
Implementing logging, and adding a test case.
2010-11-25 22:51:30 -05:00