adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2025-01-18 18:46:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

HttpResponse::getHeader() is more flexible to accept a custom header list.

Browse source
This commit is contained in:
Juan Basso 2010-12-14 02:52:40 -02:00
parent 2f64afe44e
commit 37303d9c37
2 changed files with 13 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
cake/libs/http_response.php
View file

@ -94,11 +94,14 @@ class HttpResponse implements ArrayAccess {
* @param string $name Header name
* @return mixed String if header exists or null
*/
public function getHeader($name) {
if (isset($this->headers[$name])) {
return $this->headers[$name];
public function getHeader($name, $headers = null) {
if (!is_array($headers)) {
$headers =& $this->headers;
}
foreach ($this->headers as $key => $value) {
if (isset($headers[$name])) {
return $headers[$name];
}
foreach ($headers as $key => $value) {
if (strcasecmp($key, $name) == 0) {
return $value;
}
@ -278,12 +281,13 @@ class HttpResponse implements ArrayAccess {
* @todo Make this 100% RFC 2965 confirm
*/
public function parseCookies($header) {
if (!isset($header['Set-Cookie'])) {
$cookieHeader = $this->getHeader('Set-Cookie', $header);
if (!$cookieHeader) {
return false;
}
$cookies = array();
foreach ((array)$header['Set-Cookie'] as $cookie) {
foreach ((array)$cookieHeader as $cookie) {
if (strpos($cookie, '";"') !== false) {
$cookie = str_replace('";"', "{__cookie_replace__}", $cookie);
$parts = str_replace("{__cookie_replace__}", '";"', explode(';', $cookie));

3
cake/tests/cases/libs/http_response.test.php
View file

@ -113,6 +113,9 @@ class HttpResponseTest extends CakeTestCase {
$this->assertEqual($this->HttpResponse->getHeader('header'), 'value');
$this->assertEqual($this->HttpResponse->getHeader('Content-Type'), 'text/plain');
$this->assertIdentical($this->HttpResponse->getHeader(0), null);
$this->assertEqual($this->HttpResponse->getHeader('foo', false), 'Bar');
$this->assertEqual($this->HttpResponse->getHeader('foo', array('foo' => 'not from class')), 'not from class');
}
/**