adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2025-01-18 18:46:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Adding another case that makes false/null to not cause match failure.

Browse source
This commit is contained in:
mark_story 2010-12-18 13:32:05 -05:00
parent 456a14cf37
commit 6ef8203d54
2 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cake/libs/route/cake_route.php
View file

@ -280,7 +280,7 @@ class CakeRoute {
continue;
}
// keys that don't exist are different.
if (!$keyExists) {
if (!$keyExists && !empty($value)) {
$diff[$key] = $value;
}

13
cake/tests/cases/libs/route/cake_route.test.php
View file

@ -289,6 +289,19 @@ class CakeRouteTestCase extends CakeTestCase {
$this->assertEqual($result, $expected);
}
/**
* test that falsey values do not interrupt a match.
*
* @return void
*/
function testMatchWithFalseyValues() {
$route = new CakeRoute('/:controller/:action/*', array('plugin' => null));
$result = $route->match(array(
'controller' => 'posts', 'action' => 'index', 'plugin' => null, 'admin' => false
));
$this->assertEqual($result, '/posts/index/');
}
/**
* test match() with greedy routes, named parameters and passed args.
*