adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2025-01-18 18:46:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixing setAuthConfig to accept false as param to remove auth config. Tests added.

Browse source
This commit is contained in:
Juan Basso 2010-12-03 01:30:03 -02:00
parent cd24aca39d
commit 4325e67163
2 changed files with 20 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cake/libs/http_socket.php
View file

@ -187,7 +187,7 @@ class HttpSocket extends CakeSocket {
* @param string $pass Password for authentication
* @return void
*/
public function setAuthConfig($method, $user, $pass = null) {
public function setAuthConfig($method, $user = null, $pass = null) {
if (empty($method)) {
$this->_auth = array();
return;

19
cake/tests/cases/libs/http_socket.test.php
View file

@ -755,6 +755,25 @@ class HttpSocketTest extends CakeTestCase {
$this->RequestSocket->get('http://www.google.com/', null, array('auth' => array('user' => 'foo', 'pass' => 'bar')));
}
/**
* Test authentication
*
* @return void
*/
public function testAuth() {
$socket = new MockHttpSocket();
$socket->get('http://mark:secret@example.com/test');
$this->assertTrue(strpos($socket->request['header'], 'Authorization: Basic bWFyazpzZWNyZXQ=') !== false);
$socket->setAuthConfig(false);
$socket->get('http://example.com/test');
$this->assertFalse(strpos($socket->request['header'], 'Authorization:'));
$socket->setAuthConfig('Test', 'mark', 'passwd');
$socket->get('http://example.com/test');
$this->assertTrue(strpos($socket->request['header'], 'Authorization: Test mark.passwd') !== false);
}
/**
* test that two consecutive get() calls reset the authentication credentials.
*