adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2024-11-15 19:38:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
9719 commits 7 branches 0 tags 44 MiB
Commit graph

5793 commits

Author SHA1 Message Date
mark_story
eb38b8b60c Fixing more boundary issues with first() and last(). When you entered a first/last range a wonky page link would be generated. Tests added. 2010-12-27 23:40:10 -05:00
mark_story
85baa180d9 Adding usage and expanding doc blocks for PaginatorHelper. 2010-12-27 23:30:10 -05:00
mark_story
5092013304 Making EmailComponent register and un-register its view object, when rendering email templates. This allows helpers to use the view to do additional processing. Fixes #442 2010-12-27 15:12:27 -05:00
mark_story
e003bd6ea9 Adding rel attributes for first and last links. These attribute values are part of the html5 spec, and fit with the intention of #370 2010-12-27 10:48:38 -05:00
mark_story
c5c638e8f5 Fixing option documentation. 2010-12-27 10:40:50 -05:00
mark_story
fd88d57513 Fixing option documentation. 2010-12-27 10:40:21 -05:00
mark_story
af608f68ef Updating test cases for the addition of rel attributes to links generated by PaginatorHelper. Also removed rel attributes for disabled elements, as they are probably not link tags. Fixes #370 2010-12-27 10:38:30 -05:00
Dieter Plaetinck
65394604a7 Give PaginatorHelper's next/prev links the correct 'rel' attribute 
It's a good idea to give links such as next/prev the 'rel' attribute.
See the following pages for more information:
http://www.w3.org/TR/html4/struct/links.html#edef-A
http://www.w3.org/TR/html4/types.html#type-links

Signed-off-by: mark_story <mark@mark-story.com>
 2010-12-27 10:25:19 -05:00
mark_story
b82ad15c5e Fixing issue in console when baking a new project, from outside the 
installation directory you would get an error because database.php could
not be found.  Fixes #1406
 2010-12-27 00:19:59 -05:00
mark_story
3d966be1e8 Fixing fatal error caused by Debugger not being loaded when viewing the default home page. 2010-12-27 00:07:47 -05:00
mark_story
5ce66d3031 Changing how PaginatorComponent::paginate()'s $whitelist param works. It now serves as the whitelist for fields ordering can be done on. It previously allowed you to whitelist things you passed into paginate(), which was kind of useless. 
Updated tests.
Fixes #430
 2010-12-26 21:30:43 -05:00
mark_story
6f1eca79ac Fixing calltime pass by reference deprecation warnings. 2010-12-26 20:11:17 -05:00
mark_story
f62a067d7c Making it possible for behaviors to define paginate and paginateCount. Updated test to ensure the component calls the correct methods. 
Fixes #1373
 2010-12-26 17:40:34 -05:00
mark_story
fd3b4b2cd5 Adding Model::hasMethod() and tests. 2010-12-26 17:35:22 -05:00
mark_story
3022e2d785 Adding documentation. 2010-12-26 17:21:49 -05:00
mark_story
ad5a1ca6b7 Making __methods and __mappedMethods protected instead of private. 2010-12-26 17:10:16 -05:00
mark_story
0c4b665ad0 Adding ability for BehaviorCollection::hasMethod() to return the callback. 
Re-factored BehaviorCollection::dispatchMethod to be simpler and faster.
Changing now BehaviorCollection stores callbacks so they look like normal php callback arrays.
 2010-12-26 17:09:20 -05:00
mark_story
769da1a7c8 Adding basic BehaviorCollection::hasMethod implementation. Tests added. 2010-12-26 16:44:50 -05:00
mark_story
edf567b9f9 Adding convertKeys to PaginatorHelper::options(). 
Added a test case.
Fixes #1390
 2010-12-26 13:24:05 -05:00
mark_story
56415f20cb Fixing issue where CakeLog would log suppressed errors even when error reporting was disabled. Fixes #1403 2010-12-26 13:02:43 -05:00
mark_story
83d12ce690 Removing deprecated $this->params in Helpers, it got missed somehow. 
Removing PaginatorHelper::$convertKeys.  Its just a regular option now.
Added some documentation.
 2010-12-26 13:01:20 -05:00
mark_story
ee3017599d Merge branch '2.0' into 2.0-pagination 
Conflicts:
	cake/libs/controller/components/paginator.php
	cake/libs/router.php
 2010-12-24 14:43:11 -05:00
mark_story
4009b6b2c7 Fixing more @package tags, and removing duplicate tags in classes. 2010-12-24 14:33:41 -05:00
mark_story
d8589323a9 Missed a package tag. 2010-12-24 14:22:40 -05:00
mark_story
ef77e60cb0 Removing @subpackage tags, moving contents of @subpackage into @package. 
Removing duplicate cake.cake in @package tags.
Renaming cake.app -> app
 2010-12-24 14:09:57 -05:00
Juan Basso
ff18fe4e3e Optimization in postLink and create methods from FormHelper. 2010-12-24 16:52:15 -02:00
mark_story
3fc8a1f8c1 Removing whitespace. 2010-12-24 12:54:18 -05:00
mark_story
e20ea8ad72 Renaming Dispatcher::__loadRoutes -> Dispatcher::_loadRoutes to match naming conventions. 
Updating method name usage, as assertType is deprecated as of PHPUnit 3.5.6
 2010-12-24 12:54:04 -05:00
mark_story
8eaba29c3f Fixing an entirely wrong condition that prevented routes from being loaded. 2010-12-22 23:19:04 -05:00
mark_story
a37b3a1598 Adding more documentation to DboSource. 2010-12-22 22:33:17 -05:00
mark_story
98c356a9c5 Adding some more documentation to ModelBehavior as well as basic usage. 2010-12-22 22:27:47 -05:00
mark_story
aff5cd7e15 Adding a doc block and code sample for MediaView. 2010-12-22 22:04:02 -05:00
mark_story
3c6fc55eed Removing strlower() calls as they are not needed in php5 land. 2010-12-21 23:45:47 -05:00
mark_story
af2a5123b5 Fixing issue where prefixes would not be correctly loaded for a request. 2010-12-21 23:14:17 -05:00
mark_story
afbc73a3b5 More documentation. 2010-12-21 22:36:37 -05:00
mark_story
d5589d26bd more doc blocks. 2010-12-21 22:27:17 -05:00
mark_story
4312a26b2f Removing View::$autoRender it wasn't used. 
Removing @access tags, which just restated the visibility keywords.
Adding documentation to a number of parameters and methods.
 2010-12-21 21:59:25 -05:00
mark_story
f85567a566 Removing @author tags that snuck in. 2010-12-21 21:58:20 -05:00
mark_story
04929ae1df Applying patch from 'Thorsten Buss'. 
Fixes issues in DboSource, where mismatching types on join columns could result in incorrect query generation.
Fixes #708
 2010-12-21 20:40:19 -05:00
mark_story
6f62c22cbc Fixing fencepost errors. 
Splitting tests up into smaller groups.
 2010-12-20 20:27:27 -05:00
mark_story
0b90195a52 Adding tests for creating next/prev links with querystrings. 
Removing code that doesn't seem to do anything, no tests fail when its removed.
 2010-12-20 13:59:09 -05:00
mark_story
e5588f746c Reversing changes that required a : sigil for named parameters. Also removing ?foo style parameters for querystring args. Having two ways to create querystring args was not sitting well with me. 
Tests updated.
 2010-12-19 23:11:02 -05:00
mark_story
b49b49a5ef Removing named parameter sigils. 2010-12-19 22:17:57 -05:00
mark_story
d3fc29c8e8 Adding more documentation to connectNamed(). 
Changing argSeparator -> separator, as it is less typing and easier to remember.
 2010-12-19 21:49:17 -05:00
mark_story
025ba23886 Removing whitespace and adding some more documentation. 2010-12-19 20:05:57 -05:00
mark_story
4c3736a68a Making more tests pass with the named parameter changes. 2010-12-19 17:38:21 -05:00
mark_story
5df2678ba9 Fixing named params that were missing the : and fixing Router::reverse() so it adds in the : 2010-12-19 17:09:34 -05:00
mark_story
c83a4703a3 Implementing ability to change pagination params to use querystring variables. 
Tests added.
 2010-12-19 16:47:22 -05:00
mark_story
cc2d8e2fec Moving limit from the options to the normal paging params. This fixes a few notice errors. 2010-12-19 13:15:04 -05:00
mark_story
8c3ceff50d Making paging.options only contain options that are not in the defaults. This replaces the many diffs that were calculated on each url generation between paging.options and paging.defaults. 2010-12-19 12:58:07 -05:00
mark_story
833bdbcc0b Reformatting paging params. 
Removing defaults from the paging params as they are no longer being used.
 2010-12-19 12:43:29 -05:00
mark_story
ef84d86cf5 Reformatting code, and removing merging of defaults key in the helper. It no longer exists. 2010-12-19 12:26:28 -05:00
mark_story
f54479e566 Adding some docblock info about pagination. 2010-12-19 12:20:12 -05:00
mark_story
e9d3fcf5cf Moving limit checking into a separate method, and adding tests. 
Removing $scope from being passed down to the options, it previously only allowed additional conditions to be set.
Updated tests.
 2010-12-19 11:58:35 -05:00
mark_story
1e741de84b Removing show alias, it was undocumented and untested. 2010-12-19 02:14:37 -05:00
mark_story
108a6611a8 Moving validation of sorting to a separate method. This makes it easier to test, extends and read. 
Tests added.
 2010-12-19 02:12:39 -05:00
mark_story
7b11eeb6e0 Updating tests to not use the deprecated Controller::$passedArgs. 
Removing messy and hard to understand defaults + whitelisting from paginate() now that it has a separate method.
 2010-12-19 01:57:51 -05:00
mark_story
6b3db0a3eb Pulling out parameter merging logic into a method, this allows specific typing of parameter merging (named, querystring, route). Also simplifies whitelisting of request parameters. 
Tests added for merging and whitelisting.
 2010-12-19 01:42:23 -05:00
mark_story
7585b2941e Adding paramType to the test cases. 2010-12-19 00:38:20 -05:00
mark_story
54c52d85fb Fixing failing tests in PaginatorComponent. 2010-12-18 17:29:47 -05:00
mark_story
6b9d9f4aea Reapplying changes in [33d2f9a6ed] as they got lost when the paginator component was extracted. 2010-12-18 17:17:43 -05:00
mark_story
a6cca7c036 Extracting a method from paginator component. 2010-12-18 17:09:30 -05:00
mark_story
eb9fe07472 Adding query string generation into CakeRoute. This removes one more task from Router. Tests added 
Adding constants for the named param and querystring param sigils.
 2010-12-18 16:44:21 -05:00
Juan Basso
5d2b4c758d Minor optimization in cache views. 2010-12-18 19:41:57 -02:00
Juan Basso
a7c7436d8e Passing viewVars to cache views, avoiding cake:nocache problems. 2010-12-18 19:31:10 -02:00
mark_story
9c1516e6a8 Fixing calltime pass by reference deprecation warnings. 2010-12-18 15:52:23 -05:00
mark_story
5255b8fc9e Updating doc block for Router::redirect() 
Updating RedirectRoute to not use defaults for where the route will redirect.
 2010-12-18 15:39:10 -05:00
mark_story
3b0a3d4109 Making route matching fail even faster. This gives significant performance boosts to routes not matching. 2010-12-18 14:36:11 -05:00
mark_story
756b09849f Router tests all pass now. 2010-12-18 14:26:45 -05:00
mark_story
328db0c36b Fixed a number of tests, there are still a few issues with prefix routes. 
Moved removing defaults that are also keys to the compile step.  This
removes quite a few repetitive loops.
 2010-12-18 14:18:21 -05:00
mark_story
8d404332a2 Fixing issue where named params equal to null/false would be part of the generated url. 2010-12-18 13:40:07 -05:00
mark_story
6ef8203d54 Adding another case that makes false/null to not cause match failure. 2010-12-18 13:32:05 -05:00
mark_story
456a14cf37 Refactored CakeRoute::match() to not use Set::diff(). This was the slowest part of reverse routing and this change should make things faster. 
Added additional tests for the 0 edge case.
 2010-12-18 12:34:48 -05:00
mark_story
c5bab54125 Starting to try and re-factor named params to perform better and be more 
explicit with how they are used.
 2010-12-18 00:15:09 -05:00
mark_story
de7b324444 Fixing more strict warnings. 
Removing & on component callbacks.
Updating incorrect method signatures.
 2010-12-18 00:03:03 -05:00
mark_story
6206fefcee Starting to switch to a _mergeParent. This will allow un skipping of many tests, and make mergeVars more flexible. 2010-12-15 23:44:43 -05:00
mark_story
a054695dca Fixing failing tests. 2010-12-15 22:08:24 -05:00
José Lorenzo Rodríguez
387281e506 Moving newly created classes to the new folders 2010-12-15 01:32:37 -04:30
José Lorenzo Rodríguez
07e43bb0f8 Merge remote branch 'origin/2.0' into 2.0-class-loading 
Conflicts:
	cake/libs/view/scaffolds/edit.ctp
	cake/libs/view/scaffolds/form.ctp
	cake/tests/test_app/plugins/test_plugin/views/tests/scaffold.edit.ctp
	cake/tests/test_app/plugins/test_plugin/views/tests/scaffold.form.ctp
	cake/tests/test_app/views/posts/scaffold.edit.ctp
	cake/tests/test_app/views/posts/scaffold.form.ctp
	lib/Cake/Error/ErrorHandler.php
	lib/Cake/Model/Behavior/TranslateBehavior.php
	lib/Cake/Model/Datasource/CakeSession.php
	lib/Cake/Routing/Router.php
	lib/Cake/TestSuite/TestManager.php
	lib/Cake/View/scaffolds/edit.ctp
	lib/Cake/tests/cases/console/shells/bake.test.php
	lib/Cake/tests/cases/libs/cake_log.test.php
	lib/Cake/tests/cases/libs/cake_request.test.php
	lib/Cake/tests/cases/libs/view/helpers/number.test.php
	lib/Cake/tests/test_app/plugins/test_plugin/views/tests/scaffold.edit.ctp
	lib/Cake/tests/test_app/views/posts/scaffold.edit.ctp
 2010-12-15 01:13:05 -04:30
Jeremy Harris
7416e58759 Allowed comma-delimited list in smtp $to var to be consistent with standard mail delivery. Fixes #1353 2010-12-14 20:55:34 -08:00
Jeremy Harris
9e74283b90 Merge branch '2.0-1353' into 2.0 2010-12-14 20:42:03 -08:00
Jeremy Harris
904cb8a4a6 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2010-12-14 20:30:58 -08:00
mark_story
7b4ffa2ee9 Fixing incorrect exception type. 2010-12-14 23:24:37 -05:00
Juan Basso
754c9b2c3d Updated to HttpSocket, HttpResponse and CakeSocket use SocketException. 2010-12-15 02:01:00 -02:00
Jeremy Harris
b9143dc7d4 Added ControllerTestCase class for testing controllers. Fixes #1244 2010-12-14 19:58:27 -08:00
Juan Basso
c0e2f63f7d Merge with 2.0-http. 2010-12-15 01:58:21 -02:00
Juan Basso
ad5e7248c5 Fixed documentation. 2010-12-15 01:54:48 -02:00
mark_story
478d158133 Removing a var_dump because I'm a muppet. 2010-12-14 22:52:31 -05:00
Juan Basso
99407282e5 Updated the config of auth in digest method. 2010-12-15 01:51:00 -02:00
mark_story
84414eeb07 Removing CakeSession::watch() and CakeSession::ignore(). You should use logging, or an interactive debugger instead. 2010-12-14 22:35:43 -05:00
Jeremy Harris
9fa1bec0cb Move Controller::paginate() into PaginatorComponent 2010-12-14 18:21:39 -08:00
Juan Basso
296aef2c11 Removed the import. It is called in request. 2010-12-14 11:13:44 -02:00
Juan Basso
2cbece6784 Removed the lineBreak attribute, this is fixed in RFC. 2010-12-14 11:11:36 -02:00
Juan Basso
cf7aae7911 Removed parseHeader from HttpSocket (it was not used). Moved the tests of parseHeader to HttpResponse. 2010-12-14 11:05:37 -02:00
mark_story
bd951791f4 Removing forced start of sessions now that they are lazily started. 2010-12-13 23:59:57 -05:00
mark_story
8eebdffcbb Updating session to lazy start after the first time an operation has been performed. This should make controllers that only use sessions on some actions perform better. 2010-12-13 23:59:57 -05:00
mark_story
9e1c85e627 Removing auto-start from CakeSession. Lazy starting will be more performant in most cases. 2010-12-13 23:59:57 -05:00
Juan Basso
37303d9c37 HttpResponse::getHeader() is more flexible to accept a custom header list. 2010-12-14 02:52:40 -02:00
Juan Basso
2f64afe44e Allowing the user change the response class. 2010-12-14 02:46:31 -02:00
mark_story
53a687049c Fixing encoding of address aliases. They are now mime-encoded like other headers. Tests added. Fixes #1360 2010-12-13 23:23:02 -05:00