mark_story
8eaba29c3f
Fixing an entirely wrong condition that prevented routes from being loaded.
2010-12-22 23:19:04 -05:00
mark_story
a37b3a1598
Adding more documentation to DboSource.
2010-12-22 22:33:17 -05:00
mark_story
98c356a9c5
Adding some more documentation to ModelBehavior as well as basic usage.
2010-12-22 22:27:47 -05:00
mark_story
aff5cd7e15
Adding a doc block and code sample for MediaView.
2010-12-22 22:04:02 -05:00
mark_story
3c6fc55eed
Removing strlower() calls as they are not needed in php5 land.
2010-12-21 23:45:47 -05:00
mark_story
af2a5123b5
Fixing issue where prefixes would not be correctly loaded for a request.
2010-12-21 23:14:17 -05:00
mark_story
afbc73a3b5
More documentation.
2010-12-21 22:36:37 -05:00
mark_story
d5589d26bd
more doc blocks.
2010-12-21 22:27:17 -05:00
mark_story
4312a26b2f
Removing View::$autoRender it wasn't used.
...
Removing @access tags, which just restated the visibility keywords.
Adding documentation to a number of parameters and methods.
2010-12-21 21:59:25 -05:00
mark_story
f85567a566
Removing @author tags that snuck in.
2010-12-21 21:58:20 -05:00
mark_story
04929ae1df
Applying patch from 'Thorsten Buss'.
...
Fixes issues in DboSource, where mismatching types on join columns could result in incorrect query generation.
Fixes #708
2010-12-21 20:40:19 -05:00
mark_story
6f62c22cbc
Fixing fencepost errors.
...
Splitting tests up into smaller groups.
2010-12-20 20:27:27 -05:00
mark_story
0b90195a52
Adding tests for creating next/prev links with querystrings.
...
Removing code that doesn't seem to do anything, no tests fail when its removed.
2010-12-20 13:59:09 -05:00
mark_story
e5588f746c
Reversing changes that required a : sigil for named parameters. Also removing ?foo style parameters for querystring args. Having two ways to create querystring args was not sitting well with me.
...
Tests updated.
2010-12-19 23:11:02 -05:00
mark_story
b49b49a5ef
Removing named parameter sigils.
2010-12-19 22:17:57 -05:00
mark_story
d3fc29c8e8
Adding more documentation to connectNamed().
...
Changing argSeparator -> separator, as it is less typing and easier to remember.
2010-12-19 21:49:17 -05:00
mark_story
025ba23886
Removing whitespace and adding some more documentation.
2010-12-19 20:05:57 -05:00
mark_story
4c3736a68a
Making more tests pass with the named parameter changes.
2010-12-19 17:38:21 -05:00
mark_story
5df2678ba9
Fixing named params that were missing the : and fixing Router::reverse() so it adds in the :
2010-12-19 17:09:34 -05:00
mark_story
c83a4703a3
Implementing ability to change pagination params to use querystring variables.
...
Tests added.
2010-12-19 16:47:22 -05:00
mark_story
cc2d8e2fec
Moving limit from the options to the normal paging params. This fixes a few notice errors.
2010-12-19 13:15:04 -05:00
mark_story
8c3ceff50d
Making paging.options only contain options that are not in the defaults. This replaces the many diffs that were calculated on each url generation between paging.options and paging.defaults.
2010-12-19 12:58:07 -05:00
mark_story
833bdbcc0b
Reformatting paging params.
...
Removing defaults from the paging params as they are no longer being used.
2010-12-19 12:43:29 -05:00
mark_story
ef84d86cf5
Reformatting code, and removing merging of defaults key in the helper. It no longer exists.
2010-12-19 12:26:28 -05:00
mark_story
f54479e566
Adding some docblock info about pagination.
2010-12-19 12:20:12 -05:00
mark_story
e9d3fcf5cf
Moving limit checking into a separate method, and adding tests.
...
Removing $scope from being passed down to the options, it previously only allowed additional conditions to be set.
Updated tests.
2010-12-19 11:58:35 -05:00
mark_story
1e741de84b
Removing show alias, it was undocumented and untested.
2010-12-19 02:14:37 -05:00
mark_story
108a6611a8
Moving validation of sorting to a separate method. This makes it easier to test, extends and read.
...
Tests added.
2010-12-19 02:12:39 -05:00
mark_story
7b11eeb6e0
Updating tests to not use the deprecated Controller::$passedArgs.
...
Removing messy and hard to understand defaults + whitelisting from paginate() now that it has a separate method.
2010-12-19 01:57:51 -05:00
mark_story
6b3db0a3eb
Pulling out parameter merging logic into a method, this allows specific typing of parameter merging (named, querystring, route). Also simplifies whitelisting of request parameters.
...
Tests added for merging and whitelisting.
2010-12-19 01:42:23 -05:00
mark_story
7585b2941e
Adding paramType to the test cases.
2010-12-19 00:38:20 -05:00
mark_story
54c52d85fb
Fixing failing tests in PaginatorComponent.
2010-12-18 17:29:47 -05:00
mark_story
6b9d9f4aea
Reapplying changes in [ 33d2f9a6ed
] as they got lost when the paginator component was extracted.
2010-12-18 17:17:43 -05:00
mark_story
a6cca7c036
Extracting a method from paginator component.
2010-12-18 17:09:30 -05:00
mark_story
eb9fe07472
Adding query string generation into CakeRoute. This removes one more task from Router. Tests added
...
Adding constants for the named param and querystring param sigils.
2010-12-18 16:44:21 -05:00
Juan Basso
5d2b4c758d
Minor optimization in cache views.
2010-12-18 19:41:57 -02:00
Juan Basso
a7c7436d8e
Passing viewVars to cache views, avoiding cake:nocache problems.
2010-12-18 19:31:10 -02:00
mark_story
9c1516e6a8
Fixing calltime pass by reference deprecation warnings.
2010-12-18 15:52:23 -05:00
mark_story
5255b8fc9e
Updating doc block for Router::redirect()
...
Updating RedirectRoute to not use defaults for where the route will redirect.
2010-12-18 15:39:10 -05:00
mark_story
3b0a3d4109
Making route matching fail even faster. This gives significant performance boosts to routes not matching.
2010-12-18 14:36:11 -05:00
mark_story
756b09849f
Router tests all pass now.
2010-12-18 14:26:45 -05:00
mark_story
328db0c36b
Fixed a number of tests, there are still a few issues with prefix routes.
...
Moved removing defaults that are also keys to the compile step. This
removes quite a few repetitive loops.
2010-12-18 14:18:21 -05:00
mark_story
8d404332a2
Fixing issue where named params equal to null/false would be part of the generated url.
2010-12-18 13:40:07 -05:00
mark_story
6ef8203d54
Adding another case that makes false/null to not cause match failure.
2010-12-18 13:32:05 -05:00
mark_story
456a14cf37
Refactored CakeRoute::match() to not use Set::diff(). This was the slowest part of reverse routing and this change should make things faster.
...
Added additional tests for the 0 edge case.
2010-12-18 12:34:48 -05:00
mark_story
c5bab54125
Starting to try and re-factor named params to perform better and be more
...
explicit with how they are used.
2010-12-18 00:15:09 -05:00
mark_story
de7b324444
Fixing more strict warnings.
...
Removing & on component callbacks.
Updating incorrect method signatures.
2010-12-18 00:03:03 -05:00
mark_story
6206fefcee
Starting to switch to a _mergeParent. This will allow un skipping of many tests, and make mergeVars more flexible.
2010-12-15 23:44:43 -05:00
mark_story
a054695dca
Fixing failing tests.
2010-12-15 22:08:24 -05:00
Jeremy Harris
7416e58759
Allowed comma-delimited list in smtp $to var to be consistent with standard mail delivery. Fixes #1353
2010-12-14 20:55:34 -08:00
Jeremy Harris
9e74283b90
Merge branch '2.0-1353' into 2.0
2010-12-14 20:42:03 -08:00
Jeremy Harris
904cb8a4a6
Merge branch '2.0' of github.com:cakephp/cakephp into 2.0
2010-12-14 20:30:58 -08:00
mark_story
7b4ffa2ee9
Fixing incorrect exception type.
2010-12-14 23:24:37 -05:00
Juan Basso
754c9b2c3d
Updated to HttpSocket, HttpResponse and CakeSocket use SocketException.
2010-12-15 02:01:00 -02:00
Jeremy Harris
b9143dc7d4
Added ControllerTestCase class for testing controllers. Fixes #1244
2010-12-14 19:58:27 -08:00
Juan Basso
c0e2f63f7d
Merge with 2.0-http.
2010-12-15 01:58:21 -02:00
Juan Basso
ad5e7248c5
Fixed documentation.
2010-12-15 01:54:48 -02:00
mark_story
478d158133
Removing a var_dump because I'm a muppet.
2010-12-14 22:52:31 -05:00
Juan Basso
99407282e5
Updated the config of auth in digest method.
2010-12-15 01:51:00 -02:00
mark_story
84414eeb07
Removing CakeSession::watch() and CakeSession::ignore(). You should use logging, or an interactive debugger instead.
2010-12-14 22:35:43 -05:00
Jeremy Harris
9fa1bec0cb
Move Controller::paginate() into PaginatorComponent
2010-12-14 18:21:39 -08:00
Juan Basso
296aef2c11
Removed the import. It is called in request.
2010-12-14 11:13:44 -02:00
Juan Basso
2cbece6784
Removed the lineBreak attribute, this is fixed in RFC.
2010-12-14 11:11:36 -02:00
Juan Basso
cf7aae7911
Removed parseHeader from HttpSocket (it was not used). Moved the tests of parseHeader to HttpResponse.
2010-12-14 11:05:37 -02:00
mark_story
bd951791f4
Removing forced start of sessions now that they are lazily started.
2010-12-13 23:59:57 -05:00
mark_story
8eebdffcbb
Updating session to lazy start after the first time an operation has been performed. This should make controllers that only use sessions on some actions perform better.
2010-12-13 23:59:57 -05:00
mark_story
9e1c85e627
Removing auto-start from CakeSession. Lazy starting will be more performant in most cases.
2010-12-13 23:59:57 -05:00
Juan Basso
37303d9c37
HttpResponse::getHeader() is more flexible to accept a custom header list.
2010-12-14 02:52:40 -02:00
Juan Basso
2f64afe44e
Allowing the user change the response class.
2010-12-14 02:46:31 -02:00
mark_story
53a687049c
Fixing encoding of address aliases. They are now mime-encoded like other headers. Tests added. Fixes #1360
2010-12-13 23:23:02 -05:00
Juan Basso
176da15417
Moved the response methods from HttpSocket to HttpResponse.
2010-12-14 02:22:30 -02:00
Juan Basso
60a9d34027
Updated the HttpSocket to use the new HttpResponse.
2010-12-14 01:07:25 -02:00
Juan Basso
f45027ecd8
Adjusting HttpResponse responses in array to be more compatible.
2010-12-14 01:06:57 -02:00
Juan Basso
dfb76d67da
Created the HttpResponse to get HttpSocket responses.
2010-12-14 00:16:45 -02:00
mark_story
5ffc84d28a
Calling parent constructors in helpers that have it omitted. Fixes #1359
2010-12-12 21:14:30 -05:00
mark_story
2fe60142f5
Fixing more strict warnings.
2010-12-12 21:09:56 -05:00
mark_story
0ac8d04241
Fixing more strict warnings.
2010-12-12 21:02:42 -05:00
mark_story
f84871ae47
Fixing strict errors that were causing shell tests to fail.
...
Fixing test case for bake test that has been getting skipped.
2010-12-12 20:55:33 -05:00
Juan Basso
c20b5d7053
Renamed setAuthConfig to configAuth, and setProxyConfig to configProxy.
2010-12-12 23:48:04 -02:00
mark_story
017385d61c
Fixing most of the strict errors in the helper test suite.
2010-12-12 20:21:14 -05:00
mark_story
f3445cd941
Making ModelBehavior::beforeFind() return true by default. Since
...
returning null causes the find to abort, behaviors should return true if
they are not going to return a query array.
2010-12-12 18:04:52 -05:00
mark_story
bf22af6b7f
Fixing more strict errors and usage errors in BehaviorCollection test.
...
Making modParams only work if the result is an array. This is for compatibility with previous behaviour.
2010-12-12 17:42:40 -05:00
mark_story
3c69d9b138
Making ModelBehavior beforeX callbacks default to returning true. Returning null or false from a Behavior::before method will abort the operation. It felt illogical to have null continue, but false stop.
2010-12-12 17:40:13 -05:00
mark_story
48879f8264
Fixing strict errors in translate and acl behaviors.
...
Removing conditional definition of I18nModel. There is no reason for it to exist anymore.
Removing duplicate class definition.
2010-12-12 17:38:49 -05:00
mark_story
cc81f6d062
Fixing strict errors in Set class.
2010-12-12 17:37:31 -05:00
mark_story
df21d19c4c
Making a bunch of properties public so containable can hack around. Need to refactor and fix visibility issues.
...
Fixing failing tests in containable.
2010-12-12 15:48:36 -05:00
mark_story
10c358742b
Making modParams ignore null results.
...
Test added.
2010-12-12 15:33:24 -05:00
mark_story
a05baaa76e
Removing BehaviorCollection::trigger() so it uses the parent method.
...
Updating model to use the new behaviorcollection trigger method signature.
2010-12-12 15:03:23 -05:00
mark_story
81e009b816
Fixing additional strict warnings.
2010-12-12 15:02:38 -05:00
mark_story
33b8a35b75
Fixing strict warnings in TreeBehavior and a few other classes.
2010-12-12 14:56:48 -05:00
mark_story
b135e38072
Adding documentation.
2010-12-12 14:12:55 -05:00
mark_story
96968f7194
Moving the modParams option into ObjectCollection, so it can replace the specific trigger method in BehaviorCollection.
...
Changed how break behaves, so it is works better with modParams and collectReturn options.
Tests updated and expanded.
2010-12-12 14:10:22 -05:00
mark_story
d14d148948
Making scaffold form view names consistent with those used in bake.
...
Renaming test_app files.
Fixes #501
2010-12-12 13:18:28 -05:00
mark_story
11df32148f
Updating scaffold templates to use post forms for delete buttons. Updating test case.
2010-12-12 13:13:00 -05:00
mark_story
495061537f
Changing Scaffold to use exceptions to indicate error states.
...
Starting to convert record deletion to POST only.
2010-12-12 12:59:25 -05:00
mark_story
661195db6c
Updating __() use in scaffold to take advantage of sprintf() being built into __() now.
2010-12-12 12:44:48 -05:00
mark_story
44c080d5ad
Making all core classes throw CakeException subclasses, this allows developers to catch framework exceptions with one catch.
...
Adding package specific exceptions.
Replacing generic exceptions in the codebase with CakeException + package exceptions.
2010-12-11 19:26:10 -05:00
Jeremy Harris
7ed19eae88
Allowed comma-delimited list in smtp $to var to be consistent with standard mail delivery. Fixes #1353
2010-12-11 15:11:54 -08:00
Juan Basso
d332f0624f
Making the cookies independent for each host.
2010-12-11 16:49:19 -02:00
mark_story
6c0efb62e7
Adding a base HttpException for all the various HttpExceptions that cake provides, this should make it easier to write concise catch blocks.
2010-12-11 13:38:09 -05:00
mark_story
60ada4432a
Making unknown errors with codes higher than 500 render as error500.
...
Test added.
2010-12-11 13:30:29 -05:00
mark_story
504b4d495f
Adding stack traces to logged exceptions, as I forgot them last time around.
2010-12-11 12:47:16 -05:00
Juan Basso
eeafb55d31
Support to download requests.
2010-12-11 14:44:45 -02:00
mark_story
ceca179184
Fixing more tests that were failing post merge.
2010-12-10 23:17:42 -05:00
mark_story
1e108748e9
Fixing validation methods + features lost in [ f51ce734
] due to a bad
...
merge.
Fixing additional tests to reflect changes in 2.0
2010-12-10 22:52:22 -05:00
mark_story
b9f0fc0724
Merge branch '1.3' into merger
...
Conflicts:
cake/dispatcher.php
cake/libs/cake_session.php
cake/libs/controller/components/cookie.php
cake/libs/controller/components/email.php
cake/libs/controller/controller.php
cake/libs/controller/scaffold.php
cake/libs/set.php
cake/libs/validation.php
cake/libs/view/view.php
cake/tests/cases/dispatcher.test.php
cake/tests/cases/libs/controller/components/security.test.php
cake/tests/cases/libs/controller/controller.test.php
cake/tests/cases/libs/validation.test.php
cake/tests/cases/libs/view/view.test.php
2010-12-10 22:24:31 -05:00
Juan Basso
453c5364c2
Putting the auth and proxy data in request attribute after request.
2010-12-10 10:44:28 -02:00
Juan Basso
d97103d739
Making the format attribute customizable in helpers.
2010-12-10 02:42:38 -02:00
mark_story
1548b7badb
Expanding and correcting the doc block for ObjectCollection.
2010-12-09 23:22:08 -05:00
mark_story
a830632071
Changing View::element() to not overwrite viewVars with helpers that
...
have the same name.
Test added.
Fixes #1354
2010-12-09 22:06:23 -05:00
Graham Weldon
33d2f9a6ed
Refs #621 . Provides default maxLimit for pagination to prevent url manipulation causing long queries.
2010-12-10 12:22:12 +11:00
jblotus
48f32a11e0
Fixed incorrect docblock. Fixes #1350
...
Signed-off-by: mark_story <mark@mark-story.com>
2010-12-08 22:08:43 -05:00
Juan Basso
bcacace061
Updating docs.
2010-12-06 12:04:00 -02:00
Juan Basso
7c23d289e0
Minor optimizations.
2010-12-06 12:03:22 -02:00
Juan Basso
d656bdae3b
Renamed proxy method and calling togheter from host config.
2010-12-06 11:28:40 -02:00
Juan Basso
30a70b700b
HttpSocket::_configUri() always change config attribute and it is public. This function dont need return it.
2010-12-06 04:04:37 -02:00
Juan Basso
33bb253dfa
Minor optimization in HttpSocket::reset().
2010-12-06 03:56:16 -02:00
Juan Basso
151ea2804f
Default value to raw key, avoiding warnings if line is false.
2010-12-06 03:23:09 -02:00
mark_story
c096eea664
Fixing failing tests caused by constants changing.
2010-12-05 23:32:34 -05:00
mark_story
55e06ec244
Merge branch '2.0-config' into 2.0
...
Conflicts:
cake/libs/configure.php
2010-12-05 23:00:05 -05:00
Juan Basso
97fe32f87c
Request return a pointer to body. It will reduce the memory usage in big responses.
2010-12-05 23:36:28 -02:00
José Lorenzo Rodríguez
c559b9c22d
Merge remote branch 'origin/2.0' into 2.0
...
Conflicts:
cake/console/templates/skel/config/database.php.default
cake/libs/model/datasources/dbo/dbo_sqlite.php
2010-12-05 20:51:37 -04:30
mark_story
7024d14c74
Removing private annotations for File::__construct() and File::__destruct() as its just not true. This also prevents them from being included in the API docs.
2010-12-05 18:41:26 -05:00
mark_story
5f47de7658
Adding @package tags.
...
Moving MissingModelException with the other exceptions.
2010-12-05 00:02:20 -05:00
mark_story
d202ea643d
Fixing issue loading plugin models when uses == false.
2010-12-04 23:49:00 -05:00
mark_story
9dd78c7dc1
Updating Multibyte class to use new Configure api.
2010-12-04 22:59:07 -05:00
mark_story
5ad8d8af41
Adding a parameter to configured() to allow you to check if a particular config has been configured.
2010-12-04 22:57:33 -05:00
Juan Basso
c52d5320c8
Replaced the *printf with i18n aliases by i18n aliases with params.
2010-12-04 23:37:13 -02:00
mark_story
b49c4402e5
Implementing store and restore for Configure.
...
Test cases added.
2010-12-04 17:26:59 -05:00
mark_story
539f2cd785
Removing a cakeError that slipped through the cracks.
2010-12-04 16:34:20 -05:00
mark_story
94258e14d7
Doing some reformatting and removing calls to read() since we are already in Configure.
2010-12-04 16:29:34 -05:00
mark_story
ae814db2dd
Changing IniAcl to use IniReader.
2010-12-04 14:47:47 -05:00
mark_story
8031d33d33
Fixing more E_STRICT notices and adding a type check to DboSource::dropSchema().
2010-12-04 14:37:02 -05:00
mark_story
a6c5065e9c
Fixing a few more E_STRICT errors in postgres test/class.
2010-12-04 14:31:11 -05:00
mark_story
7e3c98024e
Removing reference operators in ModelBehavior.
2010-12-04 14:19:36 -05:00
mark_story
18fb12c95c
Removing & pass by ref operators as they aren't needed any more.
...
Fixing a bunch of E_STRICT errors.
2010-12-04 14:15:32 -05:00
mark_story
d13759522b
Removing strtolower() calls. You must now call model magic findBy and findAllBy using camelcase forms.
2010-12-04 13:45:42 -05:00
mark_story
466137485d
Removing a duplicated property.
...
Changing is_a() to instanceof as it marginally faster.
Adding a comment to getConnection as it was missing it.
Minor optimization to a regular expression.
2010-12-04 13:28:43 -05:00
mark_story
98704d3ecd
Adding nested value support to IniReader.
...
Adding boolean conversions.
Adding test cases.
2010-12-04 12:56:37 -05:00
mark_story
1e569f509a
Changing IniFile to be a ConfigReader for use with Configure. Test case updated.
2010-12-04 12:15:47 -05:00
mark_story
9e32c13cac
Updating doc blocks.
2010-12-04 10:41:23 -05:00
Graham Weldon
dd18efbe7c
Append Controller to error class name for isAuthorized() not implemented.
2010-12-04 22:21:10 +11:00
Graham Weldon
1dbed85979
Append Controller to error class name for isAuthorized() not implemented.
2010-12-04 22:14:33 +11:00
mark_story
7eab3b2850
Moving load() logic out of Configure, and putting it into PhpReader.
...
Updating test cases. store() still needs to be properly implemented.
2010-12-04 01:05:12 -05:00
mark_story
6618178e1b
Adding more checks into PhpReader that currently exist in Configure.
2010-12-04 00:58:02 -05:00
mark_story
9b55487d4e
Removing a dead isset() and collapsing an if.
2010-12-04 00:24:09 -05:00
mark_story
aef53cd23a
Adding some more basic methods.
2010-12-04 00:14:55 -05:00
mark_story
da632fe191
Renaming method to match other core classes with similar features.
2010-12-04 00:10:42 -05:00
mark_story
9b8456ce6f
Adding an interface to define the necessary public methods.
...
Adding insertion of configure readers.
Adding tests.
2010-12-04 00:09:11 -05:00
Juan Basso
3f910dc6c1
Formatting
2010-12-04 00:58:49 -02:00