Juan Basso
b1f4c6a0c9
Changed tags attributes to protected.
2011-01-23 12:38:36 -02:00
Juan Basso
10d3dd5d2b
Moving the parseAttributes to Html helper.
2011-01-23 12:36:14 -02:00
Juan Basso
5bc0f0c2a1
Replacing sprintf using Html tags by useTag.
2011-01-23 12:26:14 -02:00
Juan Basso
8cd54776f1
Created the method useTag in html, avoiding sprintf with Html tags in others helpers.
2011-01-23 12:25:52 -02:00
Juan Basso
41e1aa7ece
Support to html5 in docType.
2011-01-23 11:05:51 -02:00
Jeremy Harris
c970770c8d
Merge remote branch 'upstream/2.0' into 2.0
2011-01-21 15:09:06 -08:00
Jeremy Harris
68799c9828
Removed unnecessary imports and ensured model import. Fixes #1453
2011-01-21 15:08:37 -08:00
mark_story
3747e395f1
Fixing notice errors caused by garbage urls being fed into Dispatcher.
...
Added a test.
Fixes #1463
2011-01-21 16:02:33 -05:00
Joe Beeson
e58e3f3132
Fix to resolve 'assign by reference' errors when using a '__get' magic method.
...
Fixes #1476
Signed-off-by: mark_story <mark@mark-story.com>
2011-01-21 15:52:03 -05:00
mark_story
ed7f8d1906
Fixing issue where DboPostgres used the wrong type for boolean columns with a default of false or true.
...
Added a test case.
Changing Model::create() so it doesn't wipe out default values === false.
Fixes #1460
2011-01-21 13:31:33 -05:00
Juan Basso
646bb936bf
Checking test to avoid fatal error when the test case dont have test actions.
2011-01-21 13:34:34 -02:00
Juan Basso
1debcb9ce6
Replacing deprecated startTest/endTest by setUp/tearDown in bake templates.
2011-01-21 13:27:53 -02:00
mark_story
1c3e1df305
Fixing Router::reverse() not correctly working with Request objects that
...
contained query string parameters.
2011-01-20 21:28:50 -05:00
Juan Basso
e64e29964d
Implemented the beforeRedirect callback in controller.
2011-01-20 21:27:40 -02:00
Juan Basso
6002f10b3b
Generating PHPDoc to baked files.
2011-01-19 22:22:50 -02:00
Juan Basso
40bdcbb44a
Removing $name from controller, model and fixtures.
2011-01-19 21:15:33 -02:00
mark_story
9f583097f0
Updating version numbers for 1.3.7
2011-01-19 15:10:53 -05:00
Juan Basso
09fbaaaab4
Removing extra param in internacionalization.
2011-01-19 10:08:35 -02:00
Juan Basso
6181db0ff2
Removing unsupported databases natively.
2011-01-19 00:06:51 -02:00
Jeremy Harris
46d14c51a0
Merge remote branch 'upstream/2.0' into 2.0
2011-01-18 17:51:09 -08:00
Jeremy Harris
c7127630f6
Added support for plugin classes in ControllerTestCase::generate(). Fixes #1453
2011-01-18 17:50:34 -08:00
Juan Basso
f73c4f38d5
Fixing the postLink url when the application is not in root path.
2011-01-18 23:40:30 -02:00
mark_story
23dce83836
Fixing test cases and code from merge with 1.3
...
Making MemcacheEngine::__Memcache protected, so mocking is possible.
2011-01-18 20:20:49 -05:00
mark_story
dca3fecfed
Merge branch '1.3' into merger
...
Conflicts:
cake/console/error.php
cake/libs/cache/memcache.php
cake/libs/cake_session.php
cake/libs/controller/components/request_handler.php
cake/libs/model/cake_schema.php
cake/libs/router.php
cake/libs/set.php
cake/libs/view/helpers/form.php
cake/libs/view/helpers/text.php
cake/libs/view/view.php
cake/tests/cases/libs/set.test.php
2011-01-18 20:04:30 -05:00
mark_story
a0a87ade5a
Adding non-zero exit codes to ErrorHandler in the console. Fixes #1468
2011-01-18 19:40:31 -05:00
mark_story
b94edefb2c
Removing the last vestiges of the enable parameter.
...
Fixing issue where isset() stupidly plods along when doing a string index of a string.
Updating DbAcl to use proper settings array.
Fixes #1467
2011-01-18 19:33:57 -05:00
mark_story
ab337e2e8a
Adding tests for TextHelper::autolinkurl(). Closes #1466
2011-01-18 18:56:35 -05:00
Miah Gregory
6071788478
Updated documentation for Router::connect.
...
Fixed a few spelling issues as well.
Signed-off-by: mark_story <mark@mark-story.com>
2011-01-18 17:54:19 -05:00
ADmad
d4e4957563
Adding test case for FormHelper::input() for generation multiple checkboxes with space in option values. Refs #1465
2011-01-19 02:25:39 +05:30
mark_story
932533c5c8
Fixing incorrect content type headers from being set, when an action contains a requestAction to an action with a different Content-Type. Also populating RequestHandler->params as it was always empty.
...
Fixes #1445
2011-01-18 08:28:16 -05:00
mark_story
cfce0e45d3
Fixing issue where empty session id's would cause duplicate key errors. Empty session id sessions are no longer saved. Fixes #1450
2011-01-18 08:14:47 -05:00
Jeremy Harris
be563e1220
Merge remote branch 'upstream/2.0' into 2.0
2011-01-17 20:07:22 -08:00
mark_story
b0d4951184
Fixing TextHelper::autoLinkEmails() not linking email addresses that contain '.
...
Test added.
Fixes #1457
2011-01-17 11:11:30 -05:00
mark_story
ca299a097c
Fixing issue where get forms created with model = false would create inputs with name = ''. Tests added. Fixes #1455
2011-01-15 14:39:24 -05:00
mark_story
b8780586ec
Fixing issue where FormHelper::checkbox() would ignore an explicit checked = false, and use the post data instead. Test case added. Fixes #1437
2011-01-14 21:48:23 -05:00
Jeremy Harris
1f0c57c4ee
Fixed aliasing so it works with plugins in the 'className' key
2011-01-14 17:44:33 -08:00
mark_story
17b5351aa3
Moving parent constructor call until after $helpers has been modified. Fixes #1443
2011-01-14 17:17:53 -05:00
mark_story
75483791f4
Small refactor for how HTTP_BASE is generated. Removing non-obvious regular expression. Fixes #1436
2011-01-14 17:14:22 -05:00
Jeremy Harris
39e06b0425
Updated documentation
2011-01-13 18:06:32 -08:00
Jeremy Harris
2b596859cb
Reversed alias and actual class to be more consistent with how Model aliases load and to make migration easier
2011-01-13 18:04:06 -08:00
mark_story
459e2ef1b0
Merge remote branch 'bar/envfix' into 1.3
2011-01-13 20:29:20 -05:00
mark_story
5f612b7833
Making memcache cache adapter, set the expiry time of any value greater than 30 days to never expire. This works around the 30 day limitation of the PHP extension. Test case added. Fixes #1451
2011-01-13 20:27:10 -05:00
mark_story
0f4c90588d
Fixing issue where elements did not get .ctp as a fallback extension unlike view and layout files.
...
Adding a protected method to get extensions, as it would be in 3 places now.
Added tests.
Fixes #1438
2011-01-12 20:43:41 -05:00
Juan Basso
d15ed329d9
Changed the trigger_error by exceptions in ConnectionManager.
2011-01-12 23:08:34 -02:00
mark_story
f893e3b63b
Applying patch from 'ryandesign' fixing incorrect datetime formats. Fixes #1441
2011-01-11 20:16:42 -05:00
mark_story
166c776099
Making Set::filter() only operate on arrays.
...
Also making Set::filter() work properly in a recursive fashion. This matches behavior with other functions in Set. Fixes #1431
2011-01-09 22:34:36 -05:00
mark_story
4f94b715ec
Revert "Fixing Set::filter() not predictably filtering in a recursive
...
fashion. While a minor change in behavior, more predictable and uniform
behavior is worth it." Refs #1431
This reverts commit 6e2ffafe54
.
2011-01-09 22:29:10 -05:00
Jeremy Harris
24d90c17d6
Allowed behaviors to be aliased by setting the 'alias' key
2011-01-09 18:28:12 -08:00
Jeremy Harris
9749dc808d
Allowed helpers to be aliased by setting the 'alias' key
2011-01-09 18:27:53 -08:00
Jeremy Harris
1f1d920ff7
Allowed components to be aliased by setting the 'alias' key
2011-01-09 18:27:44 -08:00
Jeremy Harris
65d1c0329c
Fixed typo
2011-01-09 17:16:44 -08:00
Ber Clausen
8d15ba5037
Fixing env('HTTP_BASE') for site domain names that have the form
...
xxx.yyy.zzz and use second level TLDs.
2011-01-09 17:43:41 -03:00
mark_story
f87ae5469b
Fixing a few failing tests in helper tests.
2011-01-09 00:09:01 -05:00
mark_story
122dc65427
Merge branch 'merger' into 2.0
2011-01-08 23:51:03 -05:00
mark_story
443f6d1c5b
Merge branch '1.3' into merger
...
Conflicts:
cake/console/shells/tasks/test.php
cake/libs/cake_log.php
cake/libs/controller/components/email.php
cake/libs/set.php
cake/libs/view/helpers/cache.php
cake/libs/view/helpers/paginator.php
cake/libs/view/helpers/time.php
cake/libs/view/view.php
cake/tests/cases/console/libs/tasks/fixture.test.php
cake/tests/cases/console/shells/tasks/test.test.php
cake/tests/cases/libs/controller/components/email.test.php
cake/tests/cases/libs/model/db_acl.test.php
cake/tests/cases/libs/set.test.php
2011-01-08 23:49:19 -05:00
AD7six
e024b6b43b
only check the default template path is correct
...
this prevents a misleading error if you've more than one bake template installed
2011-01-08 14:08:28 +01:00
mark_story
8754d11aed
Adding EmailComponent::_getSocket() so EmailComponent + smtp is easier to test.
...
Fixing issue where hosts with portnames could cause smtp emails to fail.
Added tests, fixed an existing test to not depend on a local mailserver.
Fixes #1433
2011-01-06 23:10:01 -05:00
mark_story
f45f2e4096
Making niceShort() compare the original dateString and userOffset. This fixes issues where timezone differences would cause the incorrect short form to be displayed. Fixes #1331
2011-01-05 22:53:56 -05:00
mark_story
6e2ffafe54
Fixing Set::filter() not predictably filtering in a recursive fashion. While a minor change in behavior, more predictable and uniform behavior is worth it.
...
Fixes #1431
2011-01-05 22:48:09 -05:00
Jeremy Harris
37b98ff1a6
Merge remote branch 'upstream/2.0' into 2.0
2011-01-05 19:07:25 -08:00
Jeremy Harris
a8ac288d1c
Added $format option to TimeHelper::nice(). Fixes #433 , #638 , #291 , #801
2011-01-05 19:06:52 -08:00
José Lorenzo Rodríguez
2b9c6b8609
optimizing sqlite driver to look for the "From" keyword in reverse order on the sql string
2011-01-04 17:44:33 -04:30
José Lorenzo Rodríguez
4948280ba8
Fixing typo in sqlite driver
2011-01-04 17:25:23 -04:30
José Lorenzo Rodríguez
665e560310
Checking for null values before converting to boolean
2011-01-04 17:00:10 -04:30
mark_story
de6eda964e
Removing silent errors in PDO dbo's when a connection exception is created.
...
Adding the host param for mysql.
Adding a test for mysql missing the host param.
Fixes #1427
2011-01-03 23:34:22 -05:00
mark_story
d3d009588d
Fixing failing tests because of incorrect types.
2011-01-03 23:06:48 -05:00
Jeremy Harris
4d2fdcd15e
Added support for using plugin syntax in App::objects(). Fixes #1366
2011-01-03 19:27:21 -08:00
mark_story
c58f835d9b
Fixing tests that were passing by accident. The mockObjects array wasn't being appended to so tests were passing when they shouldn't have.
...
Fixing more failing tests.
2011-01-03 16:07:49 -05:00
mark_story
09d357cc43
Removing empty fixtures array.
2011-01-02 22:33:49 -05:00
Jeremy Harris
733f4f395e
Reordered PaginatorHelper::sort() key and title to be more consistent.
...
Fixes #1000
2011-01-02 18:44:41 -05:00
José Lorenzo Rodríguez
5a75d1d91a
Adding boolean casts for sqlite
2011-01-02 01:26:57 -04:30
José Lorenzo Rodríguez
fe18e31b79
Changes to make sqlite recognize boolean columns declared as "boolean", so they can be casted to native php type
2011-01-01 22:11:28 -04:30
José Lorenzo Rodríguez
1d530db39b
Changing a bit how postgres driver treats booleans so it correcty casts them
2011-01-01 22:09:22 -04:30
José Lorenzo Rodríguez
da152e0e82
Changes to make mysql cast boolean vaules to the native php boolean datatype
2011-01-01 22:07:27 -04:30
mark_story
04c602e3d0
Fixing issues with isThisWeek() when the year ends midweek.
2010-12-31 16:37:16 -05:00
mark_story
1f6fba9d9e
Fixing failing test caused by missing space.
2010-12-31 16:36:14 -05:00
mark_story
5768bfe5c7
Fixing failing test caused by missing space.
2010-12-31 16:35:44 -05:00
mark_story
a7061510c1
Applying patch from 'rynop'. Fixing FixtureTask so it includes the datasource if its not the default one.
...
Updating tests.
Fixes #1419
2010-12-31 13:05:04 -05:00
mark_story
a9a1994a7e
Merge branch '2.0-pagination' into 2.0
2010-12-31 12:37:53 -05:00
mark_story
2e0f2c75f4
Fixing issue where ClassRegistry would not be loaded when using Models
...
in shells. Fixes #1417
2010-12-29 10:44:15 -05:00
mark_story
7dd1eea285
Updating documentation for paginator helper, and component.
2010-12-28 22:26:33 -05:00
mark_story
ab552c22a1
Adding a usage sample to Paginator->numbers()
2010-12-28 00:09:47 -05:00
mark_story
eb38b8b60c
Fixing more boundary issues with first() and last(). When you entered a first/last range a wonky page link would be generated. Tests added.
2010-12-27 23:40:10 -05:00
mark_story
85baa180d9
Adding usage and expanding doc blocks for PaginatorHelper.
2010-12-27 23:30:10 -05:00
mark_story
b6b4f4a3df
Fixing deprecated access to $this->data.
2010-12-27 15:34:56 -05:00
mark_story
5092013304
Making EmailComponent register and un-register its view object, when rendering email templates. This allows helpers to use the view to do additional processing. Fixes #442
2010-12-27 15:12:27 -05:00
mark_story
e003bd6ea9
Adding rel attributes for first and last links. These attribute values are part of the html5 spec, and fit with the intention of #370
2010-12-27 10:48:38 -05:00
mark_story
c5c638e8f5
Fixing option documentation.
2010-12-27 10:40:50 -05:00
mark_story
fd88d57513
Fixing option documentation.
2010-12-27 10:40:21 -05:00
mark_story
af608f68ef
Updating test cases for the addition of rel attributes to links generated by PaginatorHelper. Also removed rel attributes for disabled elements, as they are probably not link tags. Fixes #370
2010-12-27 10:38:30 -05:00
Dieter Plaetinck
65394604a7
Give PaginatorHelper's next/prev links the correct 'rel' attribute
...
It's a good idea to give links such as next/prev the 'rel' attribute.
See the following pages for more information:
http://www.w3.org/TR/html4/struct/links.html#edef-A
http://www.w3.org/TR/html4/types.html#type-links
Signed-off-by: mark_story <mark@mark-story.com>
2010-12-27 10:25:19 -05:00
mark_story
b82ad15c5e
Fixing issue in console when baking a new project, from outside the
...
installation directory you would get an error because database.php could
not be found. Fixes #1406
2010-12-27 00:19:59 -05:00
mark_story
3d966be1e8
Fixing fatal error caused by Debugger not being loaded when viewing the default home page.
2010-12-27 00:07:47 -05:00
mark_story
5ce66d3031
Changing how PaginatorComponent::paginate()'s $whitelist param works. It now serves as the whitelist for fields ordering can be done on. It previously allowed you to whitelist things you passed into paginate(), which was kind of useless.
...
Updated tests.
Fixes #430
2010-12-26 21:30:43 -05:00
mark_story
9615370b72
Merge branch '2.0' into 2.0-pagination
...
Conflicts:
cake/libs/http_socket.php
2010-12-26 21:02:04 -05:00
mark_story
be963385dc
Updating version numbers for 2.0.0-dev
2010-12-26 20:16:48 -05:00
mark_story
6f1eca79ac
Fixing calltime pass by reference deprecation warnings.
2010-12-26 20:11:17 -05:00
mark_story
f62a067d7c
Making it possible for behaviors to define paginate and paginateCount. Updated test to ensure the component calls the correct methods.
...
Fixes #1373
2010-12-26 17:40:34 -05:00
mark_story
fd3b4b2cd5
Adding Model::hasMethod() and tests.
2010-12-26 17:35:22 -05:00
mark_story
c5fa93b0fb
Removing test that is testing methods covered in ObjectCollection test case.
2010-12-26 17:26:18 -05:00
mark_story
3022e2d785
Adding documentation.
2010-12-26 17:21:49 -05:00
mark_story
ad5a1ca6b7
Making __methods and __mappedMethods protected instead of private.
2010-12-26 17:10:16 -05:00
mark_story
0c4b665ad0
Adding ability for BehaviorCollection::hasMethod() to return the callback.
...
Re-factored BehaviorCollection::dispatchMethod to be simpler and faster.
Changing now BehaviorCollection stores callbacks so they look like normal php callback arrays.
2010-12-26 17:09:20 -05:00
mark_story
769da1a7c8
Adding basic BehaviorCollection::hasMethod implementation. Tests added.
2010-12-26 16:44:50 -05:00
mark_story
edf567b9f9
Adding convertKeys to PaginatorHelper::options().
...
Added a test case.
Fixes #1390
2010-12-26 13:24:05 -05:00
mark_story
56415f20cb
Fixing issue where CakeLog would log suppressed errors even when error reporting was disabled. Fixes #1403
2010-12-26 13:02:43 -05:00
mark_story
83d12ce690
Removing deprecated $this->params in Helpers, it got missed somehow.
...
Removing PaginatorHelper::$convertKeys. Its just a regular option now.
Added some documentation.
2010-12-26 13:01:20 -05:00
mark_story
ee3017599d
Merge branch '2.0' into 2.0-pagination
...
Conflicts:
cake/libs/controller/components/paginator.php
cake/libs/router.php
2010-12-24 14:43:11 -05:00
mark_story
4009b6b2c7
Fixing more @package tags, and removing duplicate tags in classes.
2010-12-24 14:33:41 -05:00
mark_story
2385d9c79a
Updating console class @package tags.
2010-12-24 14:26:26 -05:00
mark_story
d8589323a9
Missed a package tag.
2010-12-24 14:22:40 -05:00
mark_story
ef77e60cb0
Removing @subpackage tags, moving contents of @subpackage into @package.
...
Removing duplicate cake.cake in @package tags.
Renaming cake.app -> app
2010-12-24 14:09:57 -05:00
Juan Basso
ff18fe4e3e
Optimization in postLink and create methods from FormHelper.
2010-12-24 16:52:15 -02:00
mark_story
3fc8a1f8c1
Removing whitespace.
2010-12-24 12:54:18 -05:00
mark_story
e20ea8ad72
Renaming Dispatcher::__loadRoutes -> Dispatcher::_loadRoutes to match naming conventions.
...
Updating method name usage, as assertType is deprecated as of PHPUnit 3.5.6
2010-12-24 12:54:04 -05:00
mark_story
8eaba29c3f
Fixing an entirely wrong condition that prevented routes from being loaded.
2010-12-22 23:19:04 -05:00
mark_story
a37b3a1598
Adding more documentation to DboSource.
2010-12-22 22:33:17 -05:00
mark_story
98c356a9c5
Adding some more documentation to ModelBehavior as well as basic usage.
2010-12-22 22:27:47 -05:00
mark_story
aff5cd7e15
Adding a doc block and code sample for MediaView.
2010-12-22 22:04:02 -05:00
Juan Basso
27477bbac3
Removing extra parameter.
2010-12-23 00:32:53 -02:00
mark_story
3c6fc55eed
Removing strlower() calls as they are not needed in php5 land.
2010-12-21 23:45:47 -05:00
mark_story
af2a5123b5
Fixing issue where prefixes would not be correctly loaded for a request.
2010-12-21 23:14:17 -05:00
mark_story
1c6b261ff1
Correcting and expanding documentation on console classes.
2010-12-21 23:11:23 -05:00
mark_story
afbc73a3b5
More documentation.
2010-12-21 22:36:37 -05:00
mark_story
d5589d26bd
more doc blocks.
2010-12-21 22:27:17 -05:00
mark_story
4312a26b2f
Removing View::$autoRender it wasn't used.
...
Removing @access tags, which just restated the visibility keywords.
Adding documentation to a number of parameters and methods.
2010-12-21 21:59:25 -05:00
mark_story
f85567a566
Removing @author tags that snuck in.
2010-12-21 21:58:20 -05:00
mark_story
04929ae1df
Applying patch from 'Thorsten Buss'.
...
Fixes issues in DboSource, where mismatching types on join columns could result in incorrect query generation.
Fixes #708
2010-12-21 20:40:19 -05:00
mark_story
6f62c22cbc
Fixing fencepost errors.
...
Splitting tests up into smaller groups.
2010-12-20 20:27:27 -05:00
mark_story
abc6a28eca
Increasing code coverage.
2010-12-20 14:02:12 -05:00
mark_story
0b90195a52
Adding tests for creating next/prev links with querystrings.
...
Removing code that doesn't seem to do anything, no tests fail when its removed.
2010-12-20 13:59:09 -05:00
mark_story
d7e411650f
Moving some tests around so its easier to figure out what's being tested.
...
Adding a querystring test.
2010-12-20 13:39:22 -05:00
mark_story
e5588f746c
Reversing changes that required a : sigil for named parameters. Also removing ?foo style parameters for querystring args. Having two ways to create querystring args was not sitting well with me.
...
Tests updated.
2010-12-19 23:11:02 -05:00
mark_story
b49b49a5ef
Removing named parameter sigils.
2010-12-19 22:17:57 -05:00
mark_story
d3fc29c8e8
Adding more documentation to connectNamed().
...
Changing argSeparator -> separator, as it is less typing and easier to remember.
2010-12-19 21:49:17 -05:00
mark_story
025ba23886
Removing whitespace and adding some more documentation.
2010-12-19 20:05:57 -05:00
mark_story
4c3736a68a
Making more tests pass with the named parameter changes.
2010-12-19 17:38:21 -05:00
mark_story
51e2b16d46
Removing pagination test from Containable test case, it doesn't make sense there.
2010-12-19 17:24:38 -05:00
mark_story
5df2678ba9
Fixing named params that were missing the : and fixing Router::reverse() so it adds in the :
2010-12-19 17:09:34 -05:00
mark_story
c83a4703a3
Implementing ability to change pagination params to use querystring variables.
...
Tests added.
2010-12-19 16:47:22 -05:00
mark_story
da46ad494b
Deleting duplicate tests.
...
Moving a test out into a separate method.
2010-12-19 13:53:11 -05:00
mark_story
cc2d8e2fec
Moving limit from the options to the normal paging params. This fixes a few notice errors.
2010-12-19 13:15:04 -05:00
mark_story
176d5520f6
Making paging params match those that would be generated by PaginatorComponent.
2010-12-19 13:09:52 -05:00
mark_story
8c3ceff50d
Making paging.options only contain options that are not in the defaults. This replaces the many diffs that were calculated on each url generation between paging.options and paging.defaults.
2010-12-19 12:58:07 -05:00
mark_story
833bdbcc0b
Reformatting paging params.
...
Removing defaults from the paging params as they are no longer being used.
2010-12-19 12:43:29 -05:00
mark_story
ef84d86cf5
Reformatting code, and removing merging of defaults key in the helper. It no longer exists.
2010-12-19 12:26:28 -05:00
mark_story
f54479e566
Adding some docblock info about pagination.
2010-12-19 12:20:12 -05:00
mark_story
e9d3fcf5cf
Moving limit checking into a separate method, and adding tests.
...
Removing $scope from being passed down to the options, it previously only allowed additional conditions to be set.
Updated tests.
2010-12-19 11:58:35 -05:00
mark_story
1e741de84b
Removing show alias, it was undocumented and untested.
2010-12-19 02:14:37 -05:00
mark_story
108a6611a8
Moving validation of sorting to a separate method. This makes it easier to test, extends and read.
...
Tests added.
2010-12-19 02:12:39 -05:00
mark_story
7b11eeb6e0
Updating tests to not use the deprecated Controller::$passedArgs.
...
Removing messy and hard to understand defaults + whitelisting from paginate() now that it has a separate method.
2010-12-19 01:57:51 -05:00
mark_story
6b3db0a3eb
Pulling out parameter merging logic into a method, this allows specific typing of parameter merging (named, querystring, route). Also simplifies whitelisting of request parameters.
...
Tests added for merging and whitelisting.
2010-12-19 01:42:23 -05:00
mark_story
7585b2941e
Adding paramType to the test cases.
2010-12-19 00:38:20 -05:00
mark_story
54c52d85fb
Fixing failing tests in PaginatorComponent.
2010-12-18 17:29:47 -05:00
mark_story
6b9d9f4aea
Reapplying changes in [ 33d2f9a6ed
] as they got lost when the paginator component was extracted.
2010-12-18 17:17:43 -05:00
mark_story
a6cca7c036
Extracting a method from paginator component.
2010-12-18 17:09:30 -05:00
mark_story
7c6af5bfec
Making a test actually test what its supposed to.
2010-12-18 17:01:26 -05:00
mark_story
319e622151
Added another test for querystring params. Querystring params should not be affected by greedy routes, as they are not really controlled by internal routing.
2010-12-18 16:51:54 -05:00
mark_story
eb9fe07472
Adding query string generation into CakeRoute. This removes one more task from Router. Tests added
...
Adding constants for the named param and querystring param sigils.
2010-12-18 16:44:21 -05:00
Juan Basso
5d2b4c758d
Minor optimization in cache views.
2010-12-18 19:41:57 -02:00
Juan Basso
a7c7436d8e
Passing viewVars to cache views, avoiding cake:nocache problems.
2010-12-18 19:31:10 -02:00
mark_story
9c1516e6a8
Fixing calltime pass by reference deprecation warnings.
2010-12-18 15:52:23 -05:00
mark_story
b1630d4f07
Removing garbage from Paginator test cases.
2010-12-18 15:48:14 -05:00
mark_story
5255b8fc9e
Updating doc block for Router::redirect()
...
Updating RedirectRoute to not use defaults for where the route will redirect.
2010-12-18 15:39:10 -05:00
mark_story
3b0a3d4109
Making route matching fail even faster. This gives significant performance boosts to routes not matching.
2010-12-18 14:36:11 -05:00
mark_story
756b09849f
Router tests all pass now.
2010-12-18 14:26:45 -05:00
mark_story
328db0c36b
Fixed a number of tests, there are still a few issues with prefix routes.
...
Moved removing defaults that are also keys to the compile step. This
removes quite a few repetitive loops.
2010-12-18 14:18:21 -05:00
mark_story
8d404332a2
Fixing issue where named params equal to null/false would be part of the generated url.
2010-12-18 13:40:07 -05:00
mark_story
6ef8203d54
Adding another case that makes false/null to not cause match failure.
2010-12-18 13:32:05 -05:00
mark_story
456a14cf37
Refactored CakeRoute::match() to not use Set::diff(). This was the slowest part of reverse routing and this change should make things faster.
...
Added additional tests for the 0 edge case.
2010-12-18 12:34:48 -05:00
mark_story
c5bab54125
Starting to try and re-factor named params to perform better and be more
...
explicit with how they are used.
2010-12-18 00:15:09 -05:00
mark_story
de7b324444
Fixing more strict warnings.
...
Removing & on component callbacks.
Updating incorrect method signatures.
2010-12-18 00:03:03 -05:00
mark_story
24373ae3c1
Removing uses() it was deprecated in 1.3. Use App::import() instead.
2010-12-16 23:05:39 -05:00
mark_story
f50a97bff1
Making PagesController test unskipped in all_tests.
2010-12-16 22:53:00 -05:00
mark_story
42754c63ff
Making more tests no longer skip in test suites.
2010-12-16 00:01:43 -05:00
mark_story
95f58321a8
Removing a duplicate test, and extra classes.
2010-12-15 23:54:28 -05:00
mark_story
339cb41ea2
Using $_mergeParent to unskip tests in test suites.
2010-12-15 23:49:54 -05:00
mark_story
6206fefcee
Starting to switch to a _mergeParent. This will allow un skipping of many tests, and make mergeVars more flexible.
2010-12-15 23:44:43 -05:00
mark_story
862a2bc25e
Removing duplicate class definition that could cause test suite inconsistencies.
...
Adding skip for when AppController is defined.
Changing how mock models are constructed to better use Model::__construct parameters.
2010-12-15 23:33:00 -05:00
mark_story
9dcea304c1
making assertions run against the test case, not the subject test case.
2010-12-15 22:19:44 -05:00
mark_story
5ff376e0a0
Adding parent calls.
2010-12-15 22:12:48 -05:00
mark_story
a054695dca
Fixing failing tests.
2010-12-15 22:08:24 -05:00
Jeremy Harris
7416e58759
Allowed comma-delimited list in smtp $to var to be consistent with standard mail delivery. Fixes #1353
2010-12-14 20:55:34 -08:00
Jeremy Harris
9e74283b90
Merge branch '2.0-1353' into 2.0
2010-12-14 20:42:03 -08:00
Jeremy Harris
904cb8a4a6
Merge branch '2.0' of github.com:cakephp/cakephp into 2.0
2010-12-14 20:30:58 -08:00
Jeremy Harris
97c82e28a1
Fixed problems where running all tests will fail due to duplicate classes
2010-12-14 20:27:12 -08:00
mark_story
1531a7226e
Removing duplicated tests, and tests for methods that are not implemented in the subclasses.
2010-12-14 23:26:24 -05:00
mark_story
7b4ffa2ee9
Fixing incorrect exception type.
2010-12-14 23:24:37 -05:00
Juan Basso
a6014cfd8d
Fixed the define name to run all socket tests.
2010-12-15 02:02:51 -02:00
Jeremy Harris
29441ca880
Added ObjectCollection test to libs group
2010-12-14 20:01:31 -08:00
Juan Basso
754c9b2c3d
Updated to HttpSocket, HttpResponse and CakeSocket use SocketException.
2010-12-15 02:01:00 -02:00
Jeremy Harris
b9143dc7d4
Added ControllerTestCase class for testing controllers. Fixes #1244
2010-12-14 19:58:27 -08:00
Juan Basso
c0e2f63f7d
Merge with 2.0-http.
2010-12-15 01:58:21 -02:00
Juan Basso
ad5e7248c5
Fixed documentation.
2010-12-15 01:54:48 -02:00
Juan Basso
575da672b0
Fixed basic proxy test.
2010-12-15 01:54:37 -02:00
mark_story
478d158133
Removing a var_dump because I'm a muppet.
2010-12-14 22:52:31 -05:00
Juan Basso
99407282e5
Updated the config of auth in digest method.
2010-12-15 01:51:00 -02:00
mark_story
84414eeb07
Removing CakeSession::watch() and CakeSession::ignore(). You should use logging, or an interactive debugger instead.
2010-12-14 22:35:43 -05:00
mark_story
75af48b774
Updating bake templates to let PUT methods through as well.
2010-12-14 22:09:29 -05:00
Jeremy Harris
10bf41a4df
Merge commit '42a5ebf47b73bbdf200f0238e30e6d4893695f80' into 2.0
2010-12-14 19:00:26 -08:00
mark_story
19f9caed28
Fixing tests so they initialize the session, before trying to test things.
2010-12-14 21:59:53 -05:00
Jeremy Harris
9fa1bec0cb
Move Controller::paginate() into PaginatorComponent
2010-12-14 18:21:39 -08:00
Juan Basso
296aef2c11
Removed the import. It is called in request.
2010-12-14 11:13:44 -02:00
Juan Basso
2cbece6784
Removed the lineBreak attribute, this is fixed in RFC.
2010-12-14 11:11:36 -02:00
Juan Basso
cf7aae7911
Removed parseHeader from HttpSocket (it was not used). Moved the tests of parseHeader to HttpResponse.
2010-12-14 11:05:37 -02:00
mark_story
bd951791f4
Removing forced start of sessions now that they are lazily started.
2010-12-13 23:59:57 -05:00
mark_story
daf6084ccc
Converting assertions to not use compatibility wrappers.
2010-12-13 23:59:57 -05:00
mark_story
106c1185b4
Making the id() test pass.
2010-12-13 23:59:57 -05:00
mark_story
8eebdffcbb
Updating session to lazy start after the first time an operation has been performed. This should make controllers that only use sessions on some actions perform better.
2010-12-13 23:59:57 -05:00
mark_story
9e1c85e627
Removing auto-start from CakeSession. Lazy starting will be more performant in most cases.
2010-12-13 23:59:57 -05:00
Juan Basso
37303d9c37
HttpResponse::getHeader() is more flexible to accept a custom header list.
2010-12-14 02:52:40 -02:00
Juan Basso
2f64afe44e
Allowing the user change the response class.
2010-12-14 02:46:31 -02:00
mark_story
53a687049c
Fixing encoding of address aliases. They are now mime-encoded like other headers. Tests added. Fixes #1360
2010-12-13 23:23:02 -05:00
Juan Basso
176da15417
Moved the response methods from HttpSocket to HttpResponse.
2010-12-14 02:22:30 -02:00
Juan Basso
60a9d34027
Updated the HttpSocket to use the new HttpResponse.
2010-12-14 01:07:25 -02:00
Juan Basso
f45027ecd8
Adjusting HttpResponse responses in array to be more compatible.
2010-12-14 01:06:57 -02:00
mark_story
e410509684
Fixing TestTask not being able to find plugin objects when baking test skeletons interactively. Test case added. Fixes #1361
2010-12-13 22:04:55 -05:00
Juan Basso
dfb76d67da
Created the HttpResponse to get HttpSocket responses.
2010-12-14 00:16:45 -02:00
mark_story
5ffc84d28a
Calling parent constructors in helpers that have it omitted. Fixes #1359
2010-12-12 21:14:30 -05:00
mark_story
2fe60142f5
Fixing more strict warnings.
2010-12-12 21:09:56 -05:00
mark_story
0ac8d04241
Fixing more strict warnings.
2010-12-12 21:02:42 -05:00
mark_story
f84871ae47
Fixing strict errors that were causing shell tests to fail.
...
Fixing test case for bake test that has been getting skipped.
2010-12-12 20:55:33 -05:00
Juan Basso
c20b5d7053
Renamed setAuthConfig to configAuth, and setProxyConfig to configProxy.
2010-12-12 23:48:04 -02:00
mark_story
017385d61c
Fixing most of the strict errors in the helper test suite.
2010-12-12 20:21:14 -05:00
mark_story
f3445cd941
Making ModelBehavior::beforeFind() return true by default. Since
...
returning null causes the find to abort, behaviors should return true if
they are not going to return a query array.
2010-12-12 18:04:52 -05:00
mark_story
dc7ff8911d
Fixing tests in ComponentCollection and HelperCollection as return of trigger now depends on the triggered objects.
...
Removing annoying test that broke anytime something changed in Model.
2010-12-12 18:02:45 -05:00
mark_story
bf22af6b7f
Fixing more strict errors and usage errors in BehaviorCollection test.
...
Making modParams only work if the result is an array. This is for compatibility with previous behaviour.
2010-12-12 17:42:40 -05:00
mark_story
ce2e6053e4
Adding containable to the AllBehaviors test as it now runs.
2010-12-12 17:40:41 -05:00
mark_story
3c69d9b138
Making ModelBehavior beforeX callbacks default to returning true. Returning null or false from a Behavior::before method will abort the operation. It felt illogical to have null continue, but false stop.
2010-12-12 17:40:13 -05:00
mark_story
48879f8264
Fixing strict errors in translate and acl behaviors.
...
Removing conditional definition of I18nModel. There is no reason for it to exist anymore.
Removing duplicate class definition.
2010-12-12 17:38:49 -05:00
mark_story
cc81f6d062
Fixing strict errors in Set class.
2010-12-12 17:37:31 -05:00
mark_story
df21d19c4c
Making a bunch of properties public so containable can hack around. Need to refactor and fix visibility issues.
...
Fixing failing tests in containable.
2010-12-12 15:48:36 -05:00
mark_story
10c358742b
Making modParams ignore null results.
...
Test added.
2010-12-12 15:33:24 -05:00
mark_story
a05baaa76e
Removing BehaviorCollection::trigger() so it uses the parent method.
...
Updating model to use the new behaviorcollection trigger method signature.
2010-12-12 15:03:23 -05:00
mark_story
81e009b816
Fixing additional strict warnings.
2010-12-12 15:02:38 -05:00
mark_story
33b8a35b75
Fixing strict warnings in TreeBehavior and a few other classes.
2010-12-12 14:56:48 -05:00
mark_story
b135e38072
Adding documentation.
2010-12-12 14:12:55 -05:00
mark_story
96968f7194
Moving the modParams option into ObjectCollection, so it can replace the specific trigger method in BehaviorCollection.
...
Changed how break behaves, so it is works better with modParams and collectReturn options.
Tests updated and expanded.
2010-12-12 14:10:22 -05:00
mark_story
d14d148948
Making scaffold form view names consistent with those used in bake.
...
Renaming test_app files.
Fixes #501
2010-12-12 13:18:28 -05:00
mark_story
11df32148f
Updating scaffold templates to use post forms for delete buttons. Updating test case.
2010-12-12 13:13:00 -05:00
mark_story
495061537f
Changing Scaffold to use exceptions to indicate error states.
...
Starting to convert record deletion to POST only.
2010-12-12 12:59:25 -05:00
mark_story
661195db6c
Updating __() use in scaffold to take advantage of sprintf() being built into __() now.
2010-12-12 12:44:48 -05:00
mark_story
daffe3adb2
Making baked code throw 404 errors when you try to edit, delete, or view records that do not exist. Updated tests.
2010-12-12 12:37:02 -05:00
mark_story
44c080d5ad
Making all core classes throw CakeException subclasses, this allows developers to catch framework exceptions with one catch.
...
Adding package specific exceptions.
Replacing generic exceptions in the codebase with CakeException + package exceptions.
2010-12-11 19:26:10 -05:00
Jeremy Harris
7ed19eae88
Allowed comma-delimited list in smtp $to var to be consistent with standard mail delivery. Fixes #1353
2010-12-11 15:11:54 -08:00
Jeremy Harris
b3f55bfd29
Added shorter timeout to fsockopen checks
2010-12-11 13:23:23 -08:00
Juan Basso
d332f0624f
Making the cookies independent for each host.
2010-12-11 16:49:19 -02:00
mark_story
6c0efb62e7
Adding a base HttpException for all the various HttpExceptions that cake provides, this should make it easier to write concise catch blocks.
2010-12-11 13:38:09 -05:00
mark_story
60ada4432a
Making unknown errors with codes higher than 500 render as error500.
...
Test added.
2010-12-11 13:30:29 -05:00
mark_story
504b4d495f
Adding stack traces to logged exceptions, as I forgot them last time around.
2010-12-11 12:47:16 -05:00
Juan Basso
eeafb55d31
Support to download requests.
2010-12-11 14:44:45 -02:00
mark_story
9bfd170443
Making behaviour of debug() consistent between cli and web.
2010-12-10 23:35:22 -05:00
mark_story
ceca179184
Fixing more tests that were failing post merge.
2010-12-10 23:17:42 -05:00
mark_story
1e108748e9
Fixing validation methods + features lost in [ f51ce734
] due to a bad
...
merge.
Fixing additional tests to reflect changes in 2.0
2010-12-10 22:52:22 -05:00
mark_story
b9f0fc0724
Merge branch '1.3' into merger
...
Conflicts:
cake/dispatcher.php
cake/libs/cake_session.php
cake/libs/controller/components/cookie.php
cake/libs/controller/components/email.php
cake/libs/controller/controller.php
cake/libs/controller/scaffold.php
cake/libs/set.php
cake/libs/validation.php
cake/libs/view/view.php
cake/tests/cases/dispatcher.test.php
cake/tests/cases/libs/controller/components/security.test.php
cake/tests/cases/libs/controller/controller.test.php
cake/tests/cases/libs/validation.test.php
cake/tests/cases/libs/view/view.test.php
2010-12-10 22:24:31 -05:00
Juan Basso
453c5364c2
Putting the auth and proxy data in request attribute after request.
2010-12-10 10:44:28 -02:00
Juan Basso
d97103d739
Making the format attribute customizable in helpers.
2010-12-10 02:42:38 -02:00
Graham Weldon
0deaa6eee0
Update basics test for debug() changes.
2010-12-10 15:39:50 +11:00
mark_story
1548b7badb
Expanding and correcting the doc block for ObjectCollection.
2010-12-09 23:22:08 -05:00
mark_story
d7e62b88bc
Adding test cases for using helpers in nested elements from email
...
templates. Closes #1355
2010-12-09 22:34:20 -05:00
mark_story
a830632071
Changing View::element() to not overwrite viewVars with helpers that
...
have the same name.
Test added.
Fixes #1354
2010-12-09 22:06:23 -05:00
Graham Weldon
e9907cb9da
Made debug() output html-safe strings by default.
2010-12-10 12:53:45 +11:00
Graham Weldon
33d2f9a6ed
Refs #621 . Provides default maxLimit for pagination to prevent url manipulation causing long queries.
2010-12-10 12:22:12 +11:00
jblotus
48f32a11e0
Fixed incorrect docblock. Fixes #1350
...
Signed-off-by: mark_story <mark@mark-story.com>
2010-12-08 22:08:43 -05:00
mark_story
8681399fc2
Forcing the plugin list to use a fresh directory listing in the web runner. Fixes #1338
2010-12-06 21:29:11 -05:00
Juan Basso
bcacace061
Updating docs.
2010-12-06 12:04:00 -02:00
Juan Basso
7c23d289e0
Minor optimizations.
2010-12-06 12:03:22 -02:00
Juan Basso
d656bdae3b
Renamed proxy method and calling togheter from host config.
2010-12-06 11:28:40 -02:00
Juan Basso
30a70b700b
HttpSocket::_configUri() always change config attribute and it is public. This function dont need return it.
2010-12-06 04:04:37 -02:00
Juan Basso
33bb253dfa
Minor optimization in HttpSocket::reset().
2010-12-06 03:56:16 -02:00
Juan Basso
151ea2804f
Default value to raw key, avoiding warnings if line is false.
2010-12-06 03:23:09 -02:00
mark_story
c096eea664
Fixing failing tests caused by constants changing.
2010-12-05 23:32:34 -05:00
mark_story
55e06ec244
Merge branch '2.0-config' into 2.0
...
Conflicts:
cake/libs/configure.php
2010-12-05 23:00:05 -05:00
mark_story
0ec1e65013
Removing collisions that prevent TestTask from being loaded.
2010-12-05 22:53:29 -05:00
Jeremy Harris
8a7e2609cd
Merge branch '2.0' of github.com:cakephp/cakephp into 2.0
2010-12-05 17:57:44 -08:00
Juan Basso
97fe32f87c
Request return a pointer to body. It will reduce the memory usage in big responses.
2010-12-05 23:36:28 -02:00
Jeremy Harris
5eab027b84
Removed unnecessary pass by references
2010-12-05 17:28:15 -08:00
José Lorenzo Rodríguez
c559b9c22d
Merge remote branch 'origin/2.0' into 2.0
...
Conflicts:
cake/console/templates/skel/config/database.php.default
cake/libs/model/datasources/dbo/dbo_sqlite.php
2010-12-05 20:51:37 -04:30
mark_story
7024d14c74
Removing private annotations for File::__construct() and File::__destruct() as its just not true. This also prevents them from being included in the API docs.
2010-12-05 18:41:26 -05:00
mark_story
5f47de7658
Adding @package tags.
...
Moving MissingModelException with the other exceptions.
2010-12-05 00:02:20 -05:00
mark_story
ad80609841
Merge branch '2.0' of github.com:cakephp/cakephp into 2.0
2010-12-04 23:55:49 -05:00
mark_story
d202ea643d
Fixing issue loading plugin models when uses == false.
2010-12-04 23:49:00 -05:00
mark_story
9dd78c7dc1
Updating Multibyte class to use new Configure api.
2010-12-04 22:59:07 -05:00
mark_story
5ad8d8af41
Adding a parameter to configured() to allow you to check if a particular config has been configured.
2010-12-04 22:57:33 -05:00
Juan Basso
c52d5320c8
Replaced the *printf with i18n aliases by i18n aliases with params.
2010-12-04 23:37:13 -02:00
Juan Basso
30661ed154
Support to vsprintf in i18n aliases (__*() functions).
2010-12-04 23:34:59 -02:00
mark_story
0b18fc25a6
Changing some requires so things run smoother.
2010-12-04 17:53:57 -05:00
mark_story
ba63a2948c
Fixing failing test caused by additional trailing space.
2010-12-04 17:49:09 -05:00
mark_story
b49c4402e5
Implementing store and restore for Configure.
...
Test cases added.
2010-12-04 17:26:59 -05:00
Juan Basso
f4d4811c96
Fixed wrong documentation.
2010-12-04 20:19:17 -02:00
mark_story
539f2cd785
Removing a cakeError that slipped through the cracks.
2010-12-04 16:34:20 -05:00
mark_story
94258e14d7
Doing some reformatting and removing calls to read() since we are already in Configure.
2010-12-04 16:29:34 -05:00
mark_story
af768c0b6f
Removing non-existant databases from comments.
2010-12-04 15:04:21 -05:00
mark_story
0cf02ec2f9
Fixing issues caused by CORE_PATH not being reliable.
2010-12-04 15:00:48 -05:00
mark_story
ae814db2dd
Changing IniAcl to use IniReader.
2010-12-04 14:47:47 -05:00
mark_story
8031d33d33
Fixing more E_STRICT notices and adding a type check to DboSource::dropSchema().
2010-12-04 14:37:02 -05:00
mark_story
a6c5065e9c
Fixing a few more E_STRICT errors in postgres test/class.
2010-12-04 14:31:11 -05:00
mark_story
843f5c6190
Fixing E_STRICT error in ConsoleErrorHandler.
2010-12-04 14:20:50 -05:00
mark_story
7e29859676
Fixing E_STRICT errors in test models.
2010-12-04 14:19:53 -05:00
mark_story
7e3c98024e
Removing reference operators in ModelBehavior.
2010-12-04 14:19:36 -05:00