mark_story
|
0b90195a52
|
Adding tests for creating next/prev links with querystrings.
Removing code that doesn't seem to do anything, no tests fail when its removed.
|
2010-12-20 13:59:09 -05:00 |
|
mark_story
|
d7e411650f
|
Moving some tests around so its easier to figure out what's being tested.
Adding a querystring test.
|
2010-12-20 13:39:22 -05:00 |
|
mark_story
|
e5588f746c
|
Reversing changes that required a : sigil for named parameters. Also removing ?foo style parameters for querystring args. Having two ways to create querystring args was not sitting well with me.
Tests updated.
|
2010-12-19 23:11:02 -05:00 |
|
mark_story
|
b49b49a5ef
|
Removing named parameter sigils.
|
2010-12-19 22:17:57 -05:00 |
|
mark_story
|
d3fc29c8e8
|
Adding more documentation to connectNamed().
Changing argSeparator -> separator, as it is less typing and easier to remember.
|
2010-12-19 21:49:17 -05:00 |
|
mark_story
|
025ba23886
|
Removing whitespace and adding some more documentation.
|
2010-12-19 20:05:57 -05:00 |
|
mark_story
|
4c3736a68a
|
Making more tests pass with the named parameter changes.
|
2010-12-19 17:38:21 -05:00 |
|
mark_story
|
51e2b16d46
|
Removing pagination test from Containable test case, it doesn't make sense there.
|
2010-12-19 17:24:38 -05:00 |
|
mark_story
|
5df2678ba9
|
Fixing named params that were missing the : and fixing Router::reverse() so it adds in the :
|
2010-12-19 17:09:34 -05:00 |
|
mark_story
|
c83a4703a3
|
Implementing ability to change pagination params to use querystring variables.
Tests added.
|
2010-12-19 16:47:22 -05:00 |
|
mark_story
|
da46ad494b
|
Deleting duplicate tests.
Moving a test out into a separate method.
|
2010-12-19 13:53:11 -05:00 |
|
mark_story
|
cc2d8e2fec
|
Moving limit from the options to the normal paging params. This fixes a few notice errors.
|
2010-12-19 13:15:04 -05:00 |
|
mark_story
|
176d5520f6
|
Making paging params match those that would be generated by PaginatorComponent.
|
2010-12-19 13:09:52 -05:00 |
|
mark_story
|
8c3ceff50d
|
Making paging.options only contain options that are not in the defaults. This replaces the many diffs that were calculated on each url generation between paging.options and paging.defaults.
|
2010-12-19 12:58:07 -05:00 |
|
mark_story
|
833bdbcc0b
|
Reformatting paging params.
Removing defaults from the paging params as they are no longer being used.
|
2010-12-19 12:43:29 -05:00 |
|
mark_story
|
ef84d86cf5
|
Reformatting code, and removing merging of defaults key in the helper. It no longer exists.
|
2010-12-19 12:26:28 -05:00 |
|
mark_story
|
f54479e566
|
Adding some docblock info about pagination.
|
2010-12-19 12:20:12 -05:00 |
|
mark_story
|
e9d3fcf5cf
|
Moving limit checking into a separate method, and adding tests.
Removing $scope from being passed down to the options, it previously only allowed additional conditions to be set.
Updated tests.
|
2010-12-19 11:58:35 -05:00 |
|
mark_story
|
1e741de84b
|
Removing show alias, it was undocumented and untested.
|
2010-12-19 02:14:37 -05:00 |
|
mark_story
|
108a6611a8
|
Moving validation of sorting to a separate method. This makes it easier to test, extends and read.
Tests added.
|
2010-12-19 02:12:39 -05:00 |
|
mark_story
|
7b11eeb6e0
|
Updating tests to not use the deprecated Controller::$passedArgs.
Removing messy and hard to understand defaults + whitelisting from paginate() now that it has a separate method.
|
2010-12-19 01:57:51 -05:00 |
|
mark_story
|
6b3db0a3eb
|
Pulling out parameter merging logic into a method, this allows specific typing of parameter merging (named, querystring, route). Also simplifies whitelisting of request parameters.
Tests added for merging and whitelisting.
|
2010-12-19 01:42:23 -05:00 |
|
mark_story
|
7585b2941e
|
Adding paramType to the test cases.
|
2010-12-19 00:38:20 -05:00 |
|
mark_story
|
54c52d85fb
|
Fixing failing tests in PaginatorComponent.
|
2010-12-18 17:29:47 -05:00 |
|
mark_story
|
6b9d9f4aea
|
Reapplying changes in [33d2f9a6ed] as they got lost when the paginator component was extracted.
|
2010-12-18 17:17:43 -05:00 |
|
mark_story
|
a6cca7c036
|
Extracting a method from paginator component.
|
2010-12-18 17:09:30 -05:00 |
|
mark_story
|
7c6af5bfec
|
Making a test actually test what its supposed to.
|
2010-12-18 17:01:26 -05:00 |
|
mark_story
|
319e622151
|
Added another test for querystring params. Querystring params should not be affected by greedy routes, as they are not really controlled by internal routing.
|
2010-12-18 16:51:54 -05:00 |
|
mark_story
|
eb9fe07472
|
Adding query string generation into CakeRoute. This removes one more task from Router. Tests added
Adding constants for the named param and querystring param sigils.
|
2010-12-18 16:44:21 -05:00 |
|
mark_story
|
9c1516e6a8
|
Fixing calltime pass by reference deprecation warnings.
|
2010-12-18 15:52:23 -05:00 |
|
mark_story
|
b1630d4f07
|
Removing garbage from Paginator test cases.
|
2010-12-18 15:48:14 -05:00 |
|
mark_story
|
5255b8fc9e
|
Updating doc block for Router::redirect()
Updating RedirectRoute to not use defaults for where the route will redirect.
|
2010-12-18 15:39:10 -05:00 |
|
mark_story
|
3b0a3d4109
|
Making route matching fail even faster. This gives significant performance boosts to routes not matching.
|
2010-12-18 14:36:11 -05:00 |
|
mark_story
|
756b09849f
|
Router tests all pass now.
|
2010-12-18 14:26:45 -05:00 |
|
mark_story
|
328db0c36b
|
Fixed a number of tests, there are still a few issues with prefix routes.
Moved removing defaults that are also keys to the compile step. This
removes quite a few repetitive loops.
|
2010-12-18 14:18:21 -05:00 |
|
mark_story
|
8d404332a2
|
Fixing issue where named params equal to null/false would be part of the generated url.
|
2010-12-18 13:40:07 -05:00 |
|
mark_story
|
6ef8203d54
|
Adding another case that makes false/null to not cause match failure.
|
2010-12-18 13:32:05 -05:00 |
|
mark_story
|
456a14cf37
|
Refactored CakeRoute::match() to not use Set::diff(). This was the slowest part of reverse routing and this change should make things faster.
Added additional tests for the 0 edge case.
|
2010-12-18 12:34:48 -05:00 |
|
mark_story
|
c5bab54125
|
Starting to try and re-factor named params to perform better and be more
explicit with how they are used.
|
2010-12-18 00:15:09 -05:00 |
|
mark_story
|
de7b324444
|
Fixing more strict warnings.
Removing & on component callbacks.
Updating incorrect method signatures.
|
2010-12-18 00:03:03 -05:00 |
|
mark_story
|
24373ae3c1
|
Removing uses() it was deprecated in 1.3. Use App::import() instead.
|
2010-12-16 23:05:39 -05:00 |
|
mark_story
|
f50a97bff1
|
Making PagesController test unskipped in all_tests.
|
2010-12-16 22:53:00 -05:00 |
|
mark_story
|
42754c63ff
|
Making more tests no longer skip in test suites.
|
2010-12-16 00:01:43 -05:00 |
|
mark_story
|
95f58321a8
|
Removing a duplicate test, and extra classes.
|
2010-12-15 23:54:28 -05:00 |
|
mark_story
|
339cb41ea2
|
Using $_mergeParent to unskip tests in test suites.
|
2010-12-15 23:49:54 -05:00 |
|
mark_story
|
6206fefcee
|
Starting to switch to a _mergeParent. This will allow un skipping of many tests, and make mergeVars more flexible.
|
2010-12-15 23:44:43 -05:00 |
|
mark_story
|
862a2bc25e
|
Removing duplicate class definition that could cause test suite inconsistencies.
Adding skip for when AppController is defined.
Changing how mock models are constructed to better use Model::__construct parameters.
|
2010-12-15 23:33:00 -05:00 |
|
mark_story
|
9dcea304c1
|
making assertions run against the test case, not the subject test case.
|
2010-12-15 22:19:44 -05:00 |
|
mark_story
|
5ff376e0a0
|
Adding parent calls.
|
2010-12-15 22:12:48 -05:00 |
|
mark_story
|
a054695dca
|
Fixing failing tests.
|
2010-12-15 22:08:24 -05:00 |
|