Mark Story
6add43a4bc
Fixing issue where id = null could cause SQL errors when saving more than one record with a null id. Fixes #675
2010-05-11 22:40:56 -04:00
ADmad
3539660cd0
Space is now properly added inbetween when 'asc'/'desc' class is appended to user defined css class in PaginatorHelper::sort. Fixes #710
2010-05-12 00:42:02 +05:30
Richard Sbresny
05beaab272
Removed unnecessary unset
...
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:14:38 -04:00
Richard Sbresny
b04a3f8514
Switched over to using the previously unused Security::inactiveMins() method for getting timeout modifiers
...
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:14:20 -04:00
Richard Sbresny
a4950f6940
Updated session timeout calculations to use the security level from core.php as the multiplier.
...
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:11:20 -04:00
predominant
1ec220dac2
Removing closing PHP tags.
2010-05-11 08:07:49 +10:00
Mark Story
1a7dce3af6
Updating DboMysql to fix an issue where virtualFields that were simple
...
aliases to fields on other tables would end up in the wrong place.
Tests added. Fixes #655
2010-05-07 23:26:13 -04:00
Mark Story
745afe888b
Adding more tests for saving records with nulls. Closes #675
2010-05-07 22:23:18 -04:00
Mark Story
f152181c03
Adding tests for saving models with id == null. Closes #675
2010-05-06 22:24:11 -04:00
Mark Story
ce10c85367
Making Sanitize::stripScripts() to remove multi-line script and style blocks. Fixes #657
2010-05-03 22:33:20 -04:00
Mark Story
95dbae8acf
Making RequestHandler component carry along a passed status code. This fixes issues where RequestHandler hijacks an redirect(). Fixes #658
2010-05-03 22:07:13 -04:00
Mark Story
c48f6d6536
Fixing safe parameter from leaking into request() calls in JsHelper::submit() and JsHelper::link(). Fixes #656
2010-05-02 21:17:10 -04:00
ADmad
f386dca6d8
Controller::loadModel() now returns true when model is succesfully instantiated as stated in docblock. Added test case.
2010-05-02 05:34:38 +05:30
José Lorenzo Rodríguez
ad51115e12
Fixing bug where required class would be added to form fields when using single rule syntax in $validate even if allowEmpty is set to true
...
Closes #654
2010-04-30 16:42:59 -04:30
José Lorenzo Rodríguez
9b040a5ed3
Fixing code formating
2010-04-30 16:07:59 -04:30
ADmad
0471ea046f
Adding test case for 'required' class adding to wrapping div based on model validations. Refs #654
2010-05-01 01:19:52 +05:30
Mark Story
328c58635b
Fixing inflection of words ending in analysis. Fixes #619
2010-04-27 23:03:37 -04:00
ADmad
c2bd87144e
Adding test case for HtmlHelper::url() showing use of key 'full_base' for parameter. Refs #627
2010-04-27 00:19:01 +05:30
Mark Story
af6435ece8
Fixing issue where table name was not using fully qualified table names, causing issues with models using table prefixes. Tests added. Fixes #623
2010-04-25 00:22:57 -07:00
Mark Story
46b9e76d8e
Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3
2010-04-24 17:34:45 -07:00
Mark Story
ce260debbc
Adding tests for passed arguments with dots when parseExtensions() has been called. Refs #620
2010-04-24 17:30:00 -07:00
ADmad
46df1be384
Model::deleteAll() now returns false if the 'find' to fetch records ids returns false (in case of sql error). Closes #272
2010-04-25 02:34:18 +05:30
Mark Story
5f03862f25
Adding tests that show that Router is not chopping off periods from passed arguments. Refs #620
2010-04-24 10:40:15 -07:00
Mark Story
bc6b8e5dfd
Fixing parameters from leaking into the script tag when calling JsHelper::submit(). Added test cases and refactored JsHelper::link(). Fixes #613
2010-04-23 00:04:15 -04:00
Mark Story
215333e56f
Making tests more accurate to normal use, removing extra params and adding some tests for sortKey. Refs #614
2010-04-22 22:53:36 -04:00
Mark Story
a92b9000bf
Adding tests for non .com domains. Refs #605
2010-04-22 21:37:27 -04:00
José Lorenzo Rodríguez
fca070fe9e
Merge branch '1.3' of git@github.com:cakephp/cakephp1x into 1.3
...
* '1.3' of git@github.com:cakephp/cakephp1x:
Adding tests for and fixing the behavior of `cake acl initdb` it now correctly delegates to SchemaShell. Fixes #608
Making TestTask not depend on Inflection rules for creating directory names, refs #610
Adding tests for Inflector::rules() clearing cached values. Fixes #609
Clear cache of pluralized, singularized and tableize when set rules.
2010-04-22 16:50:25 -04:30
José Lorenzo Rodríguez
65f01fa31c
Fixing model introspection in FormHelper to better take in account realted models with aliased names
2010-04-22 16:37:15 -04:30
Mark Story
1d3b653e57
Adding tests for Inflector::rules() clearing cached values. Fixes #609
2010-04-21 22:49:48 -04:00
José Lorenzo Rodríguez
5ceb19304e
Merge branch '1.3' of git@github.com:cakephp/cakephp1x into 1.3
2010-04-19 23:33:43 -04:30
José Lorenzo Rodríguez
e1c4b9696b
Adding documentation on 'attributes' key for FormHelper::error
2010-04-19 23:32:58 -04:30
José Lorenzo Rodríguez
23eea00a0b
Fixing FormHelper::error to no add error names and messages as html attributes. Fixes #585
...
This introduces the special key 'attributes' to FormHelper::error() when passed in the second parameter
The contents of said key will be converted into html attributes for the error container tag
2010-04-19 23:25:57 -04:30
Mark Story
f86d0de5ee
Adding test to show correct functioning of containable + field() + recursive = -1. Closes #409
2010-04-19 23:16:59 -04:00
Mark Story
029d2581af
Fixing autoFields causing invalid SQL when cross database joins are being done. Tests added. Fixes #476
2010-04-19 22:39:07 -04:00
Mark Story
4425743bcd
Adding tests for creating cache configs of different types in sequence. Demonstrates error explained in #596 .
2010-04-17 18:50:28 -04:00
Mark Story
9ae8b737dc
Trimming trailing whitespace.
2010-04-17 13:05:26 -04:00
Mark Story
ae8ace79fa
Adding additional tests for JavascriptHelper::object() options. Closes #588
2010-04-17 12:44:04 -04:00
Mark Story
78f14401ca
Fixing issue where using delivery = debug and not using sessions would cause a fatal error. send() will now return the contents that would get written into the session. Fixes #595
2010-04-17 12:27:50 -04:00
José Lorenzo Rodríguez
0300fc1c31
If connection is aborted, now MediaView returns false after stopping the transfer
2010-04-13 16:55:22 -04:30
José Lorenzo Rodríguez
940ce8b06e
Adding some test coverage on MediaView.
...
Now MediaView does not exit after successful render, closes #569
2010-04-13 16:44:14 -04:30
Mariano Iglesias
a6b83cdd93
Fixing issue where TextHelper::autoLinkUrls was failing on some expressions
2010-04-13 15:39:30 -03:00
José Lorenzo Rodríguez
3fc212fe28
Merge branch '1.3' of git@github.com:cakephp/cakephp1x into 1.3
2010-04-13 01:09:42 -04:30
José Lorenzo Rodríguez
9d2819970d
Fixing schema generation for postgres. Now character varying without lenght is translated to "text", to avoid sql errors. Closes #564
2010-04-13 01:08:31 -04:30
predominant
4982705d07
More time helper test jiggering. Some peope still experiencing issues.
2010-04-13 15:06:44 +10:00
predominant
df76ff47e3
Fix TimeHelper tests failing due to timezone changes.
2010-04-13 12:20:58 +10:00
Mark Story
404401b4de
Moving action modification when a prefix is detected so it affects all url arrays. Previously it was only applied to parameters in the current request. This fixes inconsistencies between request parameters and url parameters. Fixes #570
2010-04-11 23:13:18 -04:00
Mark Story
561e5fa556
Adding an additional test for plugin + prefix routing.
2010-04-10 21:15:56 -04:00
Mark Story
e1253f0bb5
Including a plugin short route for prefixes as well. There were failing Dispatcher tests relying on this.
2010-04-10 21:12:48 -04:00
Mark Story
6c357ee555
Adding tests from 'tfs' fixes inconsistencies in extracting elements with one path selector. Fixes #555
2010-04-10 16:57:50 -04:00
Mark Story
fbaabad6bb
Fixing issues where route parameters that overlapped could cause route compilation errors. Tests added. Fixes #565
2010-04-10 11:17:24 -04:00
José Lorenzo Rodríguez
ceb2a1d4ed
Removing date_default_timezone_set, as it is only available in php 5+
...
Hoping for the days were this type of commit is no longer needed
2010-04-09 09:40:27 -04:30
predominant
90a468bf9f
Removing mention of external site from test cases.
2010-04-09 22:06:06 +10:00
predominant
21f61ee34a
Merge remote branch 'origin/1.3' into 1.3
2010-04-09 21:58:25 +10:00
predominant
cb0ae6ed76
Fixed TimeHelper tests. Force setting of timezone to GMT+5 to ensure tests are passing.
2010-04-09 21:20:01 +10:00
Mark Story
30e6c57a96
Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3
2010-04-08 23:37:27 -04:00
Mark Story
c38249ac28
Updating HtmlHelper + JavascriptHelper to call assetTimestamp() after webroot(). This allows theme files in webroot/theme to be correctly timestamped.
...
Updating tests to reflect changes in behaviour. Fixes #244
2010-04-08 23:36:04 -04:00
José Lorenzo Rodríguez
05af213d59
Merge branch '1.3' of git@github.com:cakephp/cakephp1x into 1.3
2010-04-08 22:26:04 -04:30
José Lorenzo Rodríguez
03e3c3249f
Removing whitespace at the end of the file
2010-04-08 22:15:49 -04:30
Mark Story
94391d71c2
Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3
2010-04-08 22:41:55 -04:00
Mark Story
9d3a2c61d4
Removing test that is no longer relevant due to changes in Router.
2010-04-08 22:40:45 -04:00
José Lorenzo Rodríguez
7eb3055720
Merge branch '1.3' of git@github.com:cakephp/cakephp1x into 1.3
...
* '1.3' of git@github.com:cakephp/cakephp1x:
Adding PluginShortRoute into default connected routes. Fixes issues with the framework having built in 404s.
Implementing PluginShortRoute and some tests for its methods.
Fixing tests that started failing because of removal of short routes on reverse routing.
Removing plugin shortcuts entirely.
Adding additional test for plugin shortcut routes including prefixed shortcut routes.
Updating doc block for Router::__connectDefaultRoutes()
Removing Dispatcher::_restructureParams() as it is no longer used.
Moving expectations inline.
Fixing tests that should have never worked, and removing additional calls to _restructureParams. Adding in prefixed plugin shortcuts as they were missing.
Modifying Dispatcher tests to modify private variables (which is bad, but there is no way to change which plugins Router uses to create patterns). This allows the removal of two calls to _restructureParams.
Making PluginShortRoute check that the action exists before attempting to proceed. Updated tests.
Adding doc blocks to PluginShortRoute. Adding PluginShortRoute into Router.
Shrinking number of lines in dispatcher test case.
Adding PluginShortRoute, and a few test cases.
2010-04-08 18:24:24 -04:30
José Lorenzo Rodríguez
59f7cb47d3
Improving test coverage on FormHelper to show the usage of the 'secure' key for inputs.
...
Fixing issue with select inputs that does not honor the value of 'secure'
2010-04-08 18:23:07 -04:30
Mark Story
4d780ee1f3
Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3
2010-04-08 00:04:14 -04:00
Mark Story
0427fe9777
Merge branch 'no-shortcuts' into 1.3
2010-04-08 00:03:58 -04:00
Mark Story
81dc0d42b9
Adding PluginShortRoute into default connected routes. Fixes issues with the framework having built in 404s.
...
Adding tests for the default connected routes.
2010-04-08 00:03:46 -04:00
José Lorenzo Rodríguez
7668894888
Fixing error introduced by previous commit
2010-04-07 09:51:29 -04:30
Mark Story
131578cb42
Implementing PluginShortRoute and some tests for its methods.
2010-04-06 23:05:04 -04:00
Mark Story
07efd76b42
Fixing tests that started failing because of removal of short routes on reverse routing.
2010-04-06 22:44:23 -04:00
ADmad
b3f860b762
Adding test case for Validation::url(). Disproves #552
2010-04-07 02:20:05 +05:30
Mark Story
518cab91e5
Fixing discrepancy between how belongsTo and hasOne assocations are treated in relation to their fields being added into the queryData. hasOne and belongsTo associations now behave the same. Fixes #379
2010-04-05 21:50:28 -04:00
Mark Story
d990c6ed44
Adding tests for single quoted attributes to assertTags(). Because of the __array_permute works ensuring quotes match is a non-trivial problem. Fixing single quoted attributes not being matchable with assertTags(). Fixes #539
2010-04-04 21:43:29 -04:00
Mark Story
bdd8811924
Removing plugin shortcuts entirely.
2010-04-04 16:34:07 -04:00
José Lorenzo Rodríguez
45ccba5d94
Improving virtual fields fetching when the field wildcard selector * in present on the fields array, closes #524
2010-04-04 13:24:39 -04:30
Mark Story
e57e8f3962
Adding additional test for plugin shortcut routes including prefixed shortcut routes.
2010-04-04 00:21:21 -04:00
Mark Story
95802176bb
Making PluginShortRoute check that the action exists before attempting to proceed. Updated tests.
2010-04-03 17:10:39 -04:00
Mark Story
874c511fe2
Adding PluginShortRoute, and a few test cases.
2010-04-03 16:29:20 -04:00
Mark Story
558a9db642
Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3
2010-04-02 15:51:00 -04:00
Mark Story
3503872ab8
Fixing Form::dateTime() for GET forms. Tests added. Fixes #522
2010-04-02 15:50:43 -04:00
ADmad
1b8165d890
Enhancing email component to allow using alias for attachments. Closes #6
2010-04-03 00:37:02 +05:30
Mark Story
e6f9c420b6
Removing transactional property from the Set test, as it was removed from the Model in the last commit. Ref #531
2010-04-02 13:55:05 -04:00
Mark Story
d058234c1c
Adding tests to PaginatorHelper::sort() for creating sort links that point at plugin shortcuts. Refs #535 .
2010-04-02 13:43:03 -04:00
Mark Story
ffb5c36578
Adding tests for plugin shortcut route generation. Refs #535
2010-04-02 13:32:14 -04:00
ADmad
d92202c6da
Fixed controller test case which generated a property undefined notice
2010-04-02 00:01:06 +05:30
Mark Story
176c12e5fe
Adding tests for creating directories with trailing slashes. Closes #520
2010-03-30 22:35:49 -04:00
José Lorenzo Rodríguez
75900883e6
Making DboPostgres::value() return NULL when given an empty array, as DboMysql does
2010-03-30 00:01:33 -04:30
José Lorenzo Rodríguez
bbf96567eb
Using value() in default value generation with CakeSchema and DboPostgres
2010-03-29 23:50:40 -04:30
predominant
84ad35ca7a
Added test for XML Helper serialization. Refs #284
2010-03-29 12:21:14 +11:00
Mark Story
068631ebe2
Fixing AclNode::node() so that node expressions that could match deeper elements are contained to their parent elements. Test added.
2010-03-28 16:59:24 -04:00
ADmad
d365fafe4d
Changed default value for option 'validate' to 'first' in Model::saveAll(). Also fixed issue where the return array contained more keys then number of records in data array itself with options 'validate =>'first' and 'atomic'=>false
2010-03-28 05:29:42 +05:30
Mark Story
7b28fdec85
Fixing Security::cipher() not being able to correctly decrypt numeric values. Fixes #513
2010-03-27 17:19:42 -04:00
Mark Story
1210a4f598
Fixing whitespacing.
2010-03-27 16:28:59 -04:00
Mark Story
8ab5abe852
Merge remote branch 'origin/1.2' into 1.3
2010-03-27 16:28:00 -04:00
Mark Story
3040c6f586
Moving tests around in set test.
2010-03-27 16:27:23 -04:00
Mark Story
35446a42a9
Making filtering of extracted arrays remember their key. This fixes attribute selectors followed by parent selectors returning seemingly random results. Fixes #502
2010-03-27 16:23:46 -04:00
Mark Story
3075eda8b6
Merge remote branch 'origin/1.2' into 1.3
2010-03-27 14:30:27 -04:00
Mark Story
b559be5822
Moving xml_parser_free() so parser resources are freed immediately after they are used. Helps reduce memory consumption in Xml class. Refs #505
2010-03-27 12:48:31 -04:00
Mark Story
0c29fd0094
Merge remote branch 'origin/1.2' into 1.3
...
Conflicts:
cake/libs/cake_session.php
cake/libs/controller/components/session.php
cake/libs/model/model.php
cake/libs/router.php
2010-03-27 11:48:49 -04:00
predominant
9bd0960cf1
Merge remote branch 'origin/1.3' into 1.3
2010-03-26 20:36:04 +11:00
predominant
0dfc07ba0d
Fixes #53 , ordering of XML::toArray() operations.
2010-03-26 20:30:17 +11:00
predominant
ec3f4b8d34
Fixes #53 , ordering of XML::toArray() operations.
2010-03-26 19:59:09 +11:00