adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2024-11-15 03:18:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixing issue where id = null could cause SQL errors when saving more than one record with a null id. Fixes #675

Browse source
This commit is contained in:
Mark Story 2010-05-11 22:40:56 -04:00
parent 3539660cd0
commit 6add43a4bc
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cake/libs/model/model.php
View file

@ -1281,7 +1281,7 @@ class Model extends Overloadable {
}
}
if (isset($this->data[$this->alias][$this->primaryKey]) && empty($this->data[$this->alias][$this->primaryKey])) {
if (empty($this->data[$this->alias][$this->primaryKey])) {
unset($this->data[$this->alias][$this->primaryKey]);
}
$fields = $values = array();

3
cake/tests/cases/libs/model/model_write.test.php
View file

@ -905,13 +905,14 @@ class ModelWriteTest extends BaseModelTest {
* @return void
*/
function testSaveWithNullId() {
$this->loadFixtures('User');
$User =& new User();
$User->read(null, 1);
$User->data['User']['id'] = null;
$this->assertTrue($User->save(array('password' => 'test')));
$this->assertTrue($User->id > 0);
$User->read(null, 2);
$result = $User->read(null, 2);
$User->data['User']['id'] = null;
$this->assertTrue($User->save(array('password' => 'test')));
$this->assertTrue($User->id > 0);