Commit graph

7537 commits

Author SHA1 Message Date
Juan Basso
e02cb81a67 Reading a smtp response until EOL. Fixes #378 2010-05-29 12:04:29 -03:00
mark_story
7e6773c60c Updating ErrorHandler and CakeErrorController to use CakeRequest. Tests updated. 2010-05-29 00:21:02 -04:00
mark_story
3e3265aa7c Adding omitted echo. 2010-05-29 00:20:16 -04:00
mark_story
f4abc51062 Removing dependency on RequestHandler from Security component. 2010-05-29 00:01:11 -04:00
mark_story
8acb82f567 Updating Security component to use CakeRequest and updating its test case. 2010-05-28 23:57:43 -04:00
mark_story
5a6db36a02 Fixing PagesController test case to use CakeRequest. 2010-05-27 00:28:51 -04:00
mark_story
8b6c974cd0 Making FileEngine not greedily clear files in a directory that may belong to another cache configuration. Tests added. Fixes #754 2010-05-27 00:01:17 -04:00
José Lorenzo Rodríguez
a737b77a89 Fixing bridged method assertIdentical. The corrent interpretetion in PHPUnit was assertEquals and not assertSame, as the former is to assert references to the same object 2010-05-26 23:22:58 -04:30
mark_story
0dc627178a updating helper and component tests for controller task to use phpunit. 2010-05-26 23:01:14 -04:00
mark_story
e4ccaba3e0 Adding a filter GET parameter which allows you filter which test methods get run. It accepts preg_match() compatible patterns. 2010-05-26 22:21:34 -04:00
mark_story
8ac46c3b63 Adding return from _stop() to help testing.
Updating tests for getName()
2010-05-26 21:59:56 -04:00
mark_story
9647e359c4 First test passing for controllertask test 2010-05-25 23:54:28 -04:00
mark_story
08bcf55b8d Starting to convert controller task test to phpunit. 2010-05-25 23:51:48 -04:00
mark_story
cd255d5031 Merge branch '1.3' of github.com:cakephp/cakephp into 1.3 2010-05-25 23:08:06 -04:00
Martin Radosta
64adfacd3e Making DboSource::order() accept an expression object. Fixes issues with
sql parsing over quoting special SQL syntax. Tests added.  Fixes #747

Signed-off-by: mark_story <mark@mark-story.com>
2010-05-25 23:07:29 -04:00
Juan Basso
bc3e745673 Support to EHLO in SMTP server for EmailComponent. Fixes #54, #712, #737 2010-05-24 22:24:58 -03:00
Juan Basso
2d44929598 Optimization on dbo datasource to not repeat ids in find. Fixes #601
Signed-off-by: mark_story <mark@mark-story.com>
2010-05-23 17:22:55 -04:00
mark_story
66699df9a0 Updating Shell.test to use PHPUnit. There may still be some errors with the windows tests as I don't have access to windows at this time. 2010-05-23 14:52:46 -04:00
mark_story
265609dfc1 Moving test to work with PHPUnit.
Fixing incorrect count amount in SchemaShell.
2010-05-23 00:17:22 -04:00
mark_story
81c2169b0b Fixing BakeShell test for PHPUnit. Mock expectation numbers are off due to some oddities in PHPUnit. 2010-05-22 22:40:18 -04:00
mark_story
0436e938cd Fixing typo in class name. 2010-05-22 22:39:46 -04:00
mark_story
89a8ef3871 Updating API shell to use reflection as the regular expression was not working with visibility keywords.
Updating tests for changes in output.
Updating tests to work with PHPUnit.
2010-05-22 22:09:07 -04:00
mark_story
1955b0fb1f Updating Acl cli tool test case to use PHPUnit mock objects. 2010-05-22 20:21:27 -04:00
mark_story
b73870c33d Removing reference operators in the AclComponent. 2010-05-22 20:20:41 -04:00
ADmad
7d51952801 Removing protected var CakeSession::_started and instead session_id() is now used to check if session is started in CakeSession::started(). This fixes issue where CakeSession::started() returned incorrect value when used across multiple objects. Closes #731 2010-05-23 02:14:07 +05:30
mark_story
1c36c1f088 Updating ShellDispatcher test case to use PHPUnit mock objects. 2010-05-22 13:10:01 -04:00
mark_story
326f33f9c6 Adding wrapper for assertIsA() assertion in simpletest. 2010-05-22 13:09:17 -04:00
mark_story
cd4e63423d Exposing Object::_set() as a public method for testing and updating tests. There are still several fails caused by _persist(). 2010-05-22 11:28:22 -04:00
tarcisio
06c1b583f8 fix typo in CakeLog::config()
Signed-off-by: mark_story <mark@mark-story.com>
2010-05-22 10:49:37 -04:00
mark_story
29f2223c6d Removing hardcoded '__' for virtualField separators. Making it an instance property instead. This allows the customization of the separator if needed. Tests added for DboMysql. Refs #655, #730 2010-05-22 00:58:54 -04:00
mark_story
23d4bafd39 Fixing inflection of words ending in causes. Fixes #736 2010-05-21 23:49:49 -04:00
mark_story
78653347b2 Removing request time output from index.php. Makes non sgml requests like json easier to do. Fixes #720 2010-05-20 23:13:45 -04:00
mark_story
82250efc3e Updating doc blocks for FormHelper::input() refs #735 2010-05-20 22:58:20 -04:00
mark_story
94ac914426 Changing Router::$__validExtensions so Router::extensions() always returns an array like the doc block says.
Updating test cases for PHPUnit.
2010-05-20 22:55:25 -04:00
mark_story
df6989e3d6 Fixing Sanitize test to run under PHPUnit. 2010-05-20 22:50:06 -04:00
mark_story
0759c0b462 Removing trailing whitespace. 2010-05-20 22:49:50 -04:00
mark_story
7cef278ce2 Fixing missing boolean return in Validation::cc()
Fixing Validation test case to pass under PHPUnit.
2010-05-20 22:30:47 -04:00
predominant
6a18b2bc1d Merge remote branch 'origin/1.3' into 2.0
Conflicts:
	cake/basics.php
	cake/console/libs/shell.php
	cake/console/libs/tasks/controller.php
	cake/libs/controller/components/request_handler.php
	cake/libs/model/model.php
	cake/libs/model/model_behavior.php
	cake/libs/overloadable.php
	cake/libs/overloadable_php4.php
	cake/libs/overloadable_php5.php
	cake/libs/sanitize.php
	cake/libs/validation.php
	cake/libs/view/helpers/ajax.php
	cake/libs/view/helpers/javascript.php
	cake/libs/view/pages/home.ctp
	cake/tests/cases/console/libs/tasks/controller.test.php
	cake/tests/cases/libs/overloadable.test.php
	cake/tests/cases/libs/validation.test.php
	cake/tests/cases/libs/view/helpers/ajax.test.php
	cake/tests/cases/libs/view/helpers/javascript.test.php
	cake/tests/test_app/libs/cache/test_app_cache.php
	cake/tests/test_app/plugins/test_plugin/libs/cache/test_plugin_cache.php
	cake/tests/test_app/plugins/test_plugin/models/test_plugin_auth_user.php
	cake/tests/test_app/plugins/test_plugin/models/test_plugin_post.php
2010-05-20 12:22:04 +10:00
predominant
3a81a9e6f2 Remove unnecessary spaces. 2010-05-20 12:17:52 +10:00
José Lorenzo Rodríguez
625d120d74 Migrating MultibyteTest to phpunit 2010-05-19 00:20:21 -04:30
José Lorenzo Rodríguez
1fa430c609 Migrating SetTest to phpunit 2010-05-19 00:16:32 -04:30
José Lorenzo Rodríguez
e60cc99034 Migrating SecurityTest to phpunit 2010-05-19 00:15:35 -04:30
José Lorenzo Rodríguez
bcc3321bd3 Migrating SetTest to phpunit 2010-05-19 00:12:13 -04:30
José Lorenzo Rodríguez
f1eaec11f5 Migrating StringTest to phpunit 2010-05-19 00:05:49 -04:30
José Lorenzo Rodríguez
50021ee646 Merge branch '2.0-phpunit' of git@github.com:cakephp/cakephp into 2.0-phpunit 2010-05-18 23:57:41 -04:30
José Lorenzo Rodríguez
103d5c2505 Partially migrated JsHelperTest to phpunit 2010-05-18 23:56:50 -04:30
mark_story
07c957e827 Making PaginatorHelper test run under PHPUnit. 2010-05-19 00:14:37 -04:00
Robert Sworder
385ceb434e When using Digest Authentication the passwords do not need to be md5 hashed. Removed incorrect comment.
Fixes #733

Signed-off-by: mark_story <mark@mark-story.com>
2010-05-18 22:19:33 -04:00
Juan Basso
a94b9ee95b Update various links. Closes #392 2010-05-18 22:15:13 -03:00
José Lorenzo Rodríguez
3f881aee35 Fixing message for completed test cases 2010-05-17 23:44:08 -04:30
mark_story
c1c800865c Refactoring repeated blocks of code into a method. 2010-05-17 23:51:41 -04:00
mark_story
f6edbfa6e4 Removing unused properties from Scaffold. 2010-05-17 23:44:11 -04:00
mark_story
76f94d5c75 Fixing form attribute access and broken test. 2010-05-17 23:31:47 -04:00
mark_story
ef85fb1247 Making scaffold methods protected instead of private.
Adding visibility keywords
2010-05-17 23:30:04 -04:00
mark_story
1d884cc00f Updating Scaffold to use the CakeRequest object.
Updating Scaffold tests.
2010-05-17 23:11:47 -04:00
José Lorenzo Rodríguez
d3837ba7b0 Merge branch '2.0-phpunit' of git@github.com:cakephp/cakephp into 2.0-phpunit 2010-05-17 22:37:12 -04:30
José Lorenzo Rodríguez
327d42d6de Fixing CacheHelperTest for phpunit 2010-05-17 22:35:54 -04:30
José Lorenzo Rodríguez
d7803dc7bf Implementing skipped tests message in html reporter 2010-05-17 22:31:22 -04:30
José Lorenzo Rodríguez
f7949d6ace Fixing FormHelperTest for phpunit 2010-05-17 22:30:04 -04:30
mark_story
8b66a905b8 Fixing syntax error caused by bad merge. 2010-05-17 21:57:12 -04:00
mark_story
f114d4299d Merge branch '2.0' into 2.0-request
Conflicts:
	cake/libs/router.php
	cake/tests/cases/libs/router.test.php
2010-05-17 21:52:14 -04:00
mark_story
3a60aa07de Fixing issues where setting jQueryObject did not affect request() and its connected methods.
Tests added.
Fixes #728
2010-05-17 18:25:50 -04:00
mark_story
cd5aee1bfa Applying patch from 'franiglesias'. Fixes issues where str_replace would greedily replace too many occurences of 'libs/'. Fixes #724 2010-05-16 23:50:17 -04:00
mark_story
4915645fb1 Applying patch from 'Daren Thomas' fixes issues where sorting on virtualFields did not work properly when using aliased sort link keys. Tests added. Fixes #680 2010-05-16 23:42:14 -04:00
mark_story
6c2fe39bc0 Changing how the cursor appears. 2010-05-16 12:34:39 -04:00
José Lorenzo Rodríguez
32a46e9eda Converting HtmlHelperTest to phpunit 2010-05-15 21:05:22 -04:30
mark_story
b2d8536b3b Fixing Authcomponent tests. Updating the component + tests to use the new request object.
Deprecating a number of Authcomponent properties.
2010-05-15 00:55:15 -04:00
mark_story
36a71582fc Fixing issues with Controller::referer() and CakeRequest::referer(). Tests updated. 2010-05-15 00:53:15 -04:00
mark_story
4520ff7c82 Making View pass request onto helpers and extract it from a Controller. 2010-05-15 00:52:06 -04:00
mark_story
e6a743b163 Making JsHelper use its request object methods. 2010-05-15 00:51:26 -04:00
mark_story
4453c9122d Fixing JsHelper test cases to use the request object. 2010-05-14 23:29:16 -04:00
mark_story
322cceb8c1 Updating Text and Time test cases. 2010-05-14 23:13:31 -04:00
mark_story
0eebda9ee1 Updating HtmlHelper test to use request object.
Removing reference operators.
2010-05-14 23:11:38 -04:00
Mark Story
3983bf318d Updating PaginatorHelper and its test cases to use the request object. 2010-05-14 00:32:56 -04:00
Mark Story
c5dfd128fb Updating FormHelper and its tests to use the request object. 2010-05-14 00:21:22 -04:00
Mark Story
0d3011d2c3 Updating CacheHelper to use CakeRequest. 2010-05-14 00:12:29 -04:00
Mark Story
657073aa42 Marking a number of Helper properties as deprecated as they are contained within the CakeRequest object.
Adding a new property for the new request object.
Updating the internals of Helper to use the request object.
Updating the tests to use the request object.
2010-05-14 00:05:45 -04:00
Mark Story
353c600cd7 Removing unreachable code. Fixes #614 2010-05-13 23:38:26 -04:00
Mark Story
a29866b7fb Updating test for 1.3 2010-05-13 23:09:23 -04:00
Mark Story
3d98cc6f53 Adding tests for welsh added in previous commit. 2010-05-13 23:08:32 -04:00
Mark Story
046c233a34 Adding Welsh to the supported lists of locales in l10n. Thanks to 'DanAbel' for the 'patch'. Fixes #714 2010-05-13 22:13:59 -04:00
Mark Story
67e32e292d Additional refactoring in the coverage classes. 2010-05-13 21:51:59 -04:00
Mark Story
9303de936e Fixing fatal error trying to run coverage on the coverage reporter.
Removing old CodeCoverageManager implementation.
2010-05-13 21:44:30 -04:00
Mark Story
e76c05b2b9 Merge branch '2.0-coverage' into 2.0-phpunit 2010-05-13 21:39:23 -04:00
Mark Story
5e29cfc21e Adding TextCoverageReport and extracting a base class.
Updating the coverage classes to use the new class structure.
2010-05-13 21:36:23 -04:00
Juan Basso
db4f7a2625 Fixing search of test cases and groups for PHP 5.2. 2010-05-13 18:48:34 -03:00
José Lorenzo Rodríguez
689e46be4f Converting ConfigureTest to phpunit 2010-05-13 00:52:38 -04:30
José Lorenzo Rodríguez
f3f37a126f Converting CakeSocketTest to phpunit 2010-05-13 00:50:30 -04:30
José Lorenzo Rodríguez
01e36ce2c4 Improving compatobility method detection in paintError, so the failing line and method is correctly pointed out in the reporter 2010-05-13 00:48:03 -04:30
José Lorenzo Rodríguez
72959e7872 Converting CAkeSessionTest to phpunit 2010-05-13 00:21:16 -04:30
José Lorenzo Rodríguez
6613cfb662 Migrating CacheTest to phpunit 2010-05-13 00:13:40 -04:30
José Lorenzo Rodríguez
c1dc753be5 Replacing call of static:: for self as it is php 5.3 specific 2010-05-13 00:08:35 -04:30
José Lorenzo Rodríguez
3e3817f113 Merge commit 'mark/2.0-coverage' into 2.0-phpunit
Conflicts:
	cake/tests/lib/reporter/cake_html_reporter.php
2010-05-13 00:05:30 -04:30
José Lorenzo Rodríguez
8c3df122eb Merge commit 'lorenzo/2.0-phpunit' into 2.0-phpunit
Conflicts:
	cake/tests/lib/reporter/cake_html_reporter.php
	cake/tests/lib/test_manager.php
2010-05-12 23:58:56 -04:30
Mark Story
17f338a9b2 Moving methods up into CakeBaseReporter.
Starting to make CakeTextReporter work well with PHPUnit so the Text code coverage reporting can be implemented.
2010-05-13 00:18:22 -04:00
Mark Story
d349551dd7 Adding tests for generating method coverage with the reporter.
Adding method visibility
2010-05-12 22:43:44 -04:00
Mark Story
cb9d6f478d Making coverage reports show what tests covered the line being hovered over. Updating CSS to help facilitate hover effects. 2010-05-12 22:13:12 -04:00
Mark Story
79839c07d2 Fixing issues where ModelBehavior::detach() would not detach behaviors when a plugin.name was provided. This change makes detach() work like attach(). Tests added. Fixes #711 2010-05-11 23:08:14 -04:00
Mark Story
0648c6604b Adding some additional tests for possible php4 compatibility issues. 2010-05-11 23:01:40 -04:00
Mark Story
6add43a4bc Fixing issue where id = null could cause SQL errors when saving more than one record with a null id. Fixes #675 2010-05-11 22:40:56 -04:00
ADmad
3539660cd0 Space is now properly added inbetween when 'asc'/'desc' class is appended to user defined css class in PaginatorHelper::sort. Fixes #710 2010-05-12 00:42:02 +05:30
Mark Story
6e355312bb Fixing issue where Config.timeout wouldn't correctly countdown when many quick requests were sent. 2010-05-11 00:39:10 -04:00
Richard Sbresny
05beaab272 Removed unnecessary unset
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:14:38 -04:00
Richard Sbresny
b04a3f8514 Switched over to using the previously unused Security::inactiveMins() method for getting timeout modifiers
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:14:20 -04:00
Richard Sbresny
5cf08cbe92 Updated default values to reflect the static values previously set
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:12:15 -04:00
Richard Sbresny
c62ae5e48a Included timeout multiplier factor to be used not just inside a session start
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:11:44 -04:00
Richard Sbresny
a4950f6940 Updated session timeout calculations to use the security level from core.php as the multiplier.
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:11:20 -04:00
Mark Story
96d0119abc Applying patches from 'wals' to fix uses where incorrect parameters were being passed into methods, and making methods match their documentation blocks. Fixes #668 2010-05-10 23:58:22 -04:00
Robert Sworder
ec10a01504 Changing home.ctp to remove references to 1.2. Fixes #705
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-10 23:48:12 -04:00
Mark Story
91a40a0104 Making null check explicit so falsey default values can be used. Fixes #695 2010-05-10 23:46:47 -04:00
predominant
8f880731c6 Removing closing PHP tags. 2010-05-11 08:27:28 +10:00
predominant
1ec220dac2 Removing closing PHP tags. 2010-05-11 08:07:49 +10:00
Mark Story
687eab9528 Adding a toggle all button to the coverage report. Makes it easier to see the test subject at a glance.
Adding ability to only show files that match the extension-less basename of the test case file.  This hides much of the noise the new reports have.
2010-05-09 23:20:28 -04:00
Mark Story
e8e2235cfa Updating coverage report and tests to include hiding javascript. 2010-05-09 22:15:20 -04:00
José Lorenzo Rodríguez
765de657e6 Fixing PaginatorHelperTest to be compatible with PHPUnit 2010-05-09 18:49:04 -04:30
José Lorenzo Rodríguez
1e01e21bf9 Impriving the default for expectExpection 2010-05-09 18:48:39 -04:30
José Lorenzo Rodríguez
bc9479efcf Fixing XmlTest to be compatible with PHPUnit 2010-05-09 18:18:40 -04:30
José Lorenzo Rodríguez
508d707a7a Adding another compatibility test method: assertWithinMargin 2010-05-09 18:16:42 -04:30
José Lorenzo Rodríguez
88d21fbea4 Experimental change: restoring the error handler to steps back in the stack to let PHPUnit take over when running tests 2010-05-09 18:15:51 -04:30
José Lorenzo Rodríguez
809550087c Finxing ThemeTest to be compatible with PHPUnit 2010-05-09 16:27:09 -04:30
José Lorenzo Rodríguez
c96b14541d Adding new compatibility method for CakeTestCase 2010-05-09 16:09:57 -04:30
José Lorenzo Rodríguez
d252fdeb52 Fixing View test case to be compatible with PHPUnit 2010-05-09 16:09:02 -04:30
Mark Story
f084a82dfc Refactoring how coverage diffs are generated to better use data from phpunit. Removing methods made redundant by data changes. 2010-05-09 12:30:55 -04:00
Mark Story
ac318faf5a Switching back to using non raw code coverage data as it has been filtered by phpunit's filters. combining the data from phpunit into a singular cohesive report. 2010-05-09 02:08:32 -04:00
Mark Story
3c3655aefd Fixing failing tests. 2010-05-09 01:16:44 -04:00
Mark Story
75d7146bd0 Updating code coverage tools to use raw data which includes dead and uncovered line data. 2010-05-09 01:15:57 -04:00
Mark Story
9a20a2344b Continuing work on updated code coverage reports. 2010-05-09 00:40:05 -04:00
Mark Story
955c6bea9f Verbose coverage generation has been added and tests added. 2010-05-09 00:04:03 -04:00
José Lorenzo Rodríguez
b8e83e6a49 Adding documentation for CakeFixtureManager 2010-05-08 17:50:55 -04:30
Mark Story
f6b49cd865 Updating file headers. 2010-05-08 18:12:20 -04:00
Mark Story
ccf5601a69 Updating coverage report initialization. 2010-05-08 18:12:03 -04:00
Mark Story
fad99ad1f4 Adding tests for merging of report data. 2010-05-08 18:08:02 -04:00
José Lorenzo Rodríguez
f5cfc325f8 Adding some missing doc blocks 2010-05-08 17:29:33 -04:30
Mark Story
ac5f731940 Starting work on HtmlCoverageReport and adding a test case. 2010-05-08 17:59:14 -04:00
José Lorenzo Rodríguez
79c001197d Merge commit 'mark/2.0-phpunit' into 2.0-phpunit
Conflicts:
	cake/tests/lib/test_manager.php
2010-05-08 17:18:43 -04:30
José Lorenzo Rodríguez
72f162f52a Adding docs to CakeTestSuite 2010-05-08 16:52:29 -04:30
Mark Story
fd073809d0 Removing references to non phpunit code coverage parsing.
Adding stub of new code coverage report generator.
Updating related files.
2010-05-08 17:14:47 -04:00
José Lorenzo Rodríguez
fb09adca68 Adding tests for skipIf 2010-05-08 16:36:11 -04:30
José Lorenzo Rodríguez
4d3a6e8ca6 Fixing and testing for CakeTestCase::loadFixtures() 2010-05-08 16:14:22 -04:30
José Lorenzo Rodríguez
2b5cd26fc6 Adding tests for CakeTestCase fixtures 2010-05-08 15:56:21 -04:30
José Lorenzo Rodríguez
5d041c58b7 Using the CakeTesSuite in TestManager and calling accordingly the load and unload of fixtures using the variable
$sharedFixture
2010-05-08 15:55:16 -04:30
José Lorenzo Rodríguez
ec9c8b4d49 Adding the new class CakeTestSuite to setup some utility stuff like fixtures outside of CakeTestCase 2010-05-08 15:53:29 -04:30
José Lorenzo Rodríguez
acb9733d0e Convertint CakeFixtureManager into a non-static class to be able to replace it with custom implementations
and to test it more easily
2010-05-08 15:52:11 -04:30
Mark Story
507c3b2d94 Adding the CakePHP testing classes to the coverage ignore filter for PHPUnit. Starting to refactor how coverage is generated, to use more features of PHPUnit. 2010-05-08 16:18:45 -04:00
Mark Story
933378223b Updating CakeLog tests to use @expectedException annotation. 2010-05-08 16:17:20 -04:00
Mark Story
e7ff0bdf66 Adding missing parameters to assertEqual() wrapper.
Adding assertNotEqual() wrapper.
Adding expectError() but it doesn't work because of Debugger's error handler being set.
Fixing fatal error where getDescription would not be defined.
2010-05-08 11:42:04 -04:00
Mark Story
4b637a0f70 Updating more methods to use request object method instead of deprecated methods. 2010-05-08 10:36:20 -04:00
José Lorenzo Rodríguez
82a1bd6f80 Cleaning up CakeTestCase and adding some tests for it 2010-05-08 01:19:45 -04:30
Mark Story
5040eb7227 Updating RequestHandler and its tests to use the features moved to CakeRequest. Marking a number of methods as deprecated. 2010-05-08 00:59:40 -04:00
Mark Story
78bd7300a2 Moving features from RequestHandler into CakeRequest. 2010-05-08 00:36:03 -04:00
Mark Story
df910026ee Updating Controller::referer() to use the request object if available. Tests updated. 2010-05-08 00:06:13 -04:00
Mark Story
77264da34a Updating Controller tests to always pass in a CakeRequest. Fixing some notice errors that come up in the test cases. 2010-05-08 00:00:19 -04:00
Mark Story
22161874cb Deprecating a number of Controller properties and adding $request. 2010-05-07 23:46:02 -04:00
Mark Story
1a7dce3af6 Updating DboMysql to fix an issue where virtualFields that were simple
aliases to fields on other tables would end up in the wrong place.
Tests added.  Fixes #655
2010-05-07 23:26:13 -04:00
Mark Story
745afe888b Adding more tests for saving records with nulls. Closes #675 2010-05-07 22:23:18 -04:00
Mark Story
0930b5c63c Adding more documentation for JsHelper::submit(). Closes #681 2010-05-07 21:26:44 -04:00
José Lorenzo Rodríguez
e81cc684ef Merge branch '2.0-phpunit' of git@github.com:lorenzo/cakephp1x into 2.0-phpunit
Conflicts:
	cake/tests/lib/cake_test_case.php
2010-05-07 19:48:50 -04:30
José Lorenzo Rodríguez
7124e6db3e Refactoring CakeTestCase to remove fixture specific code and use the new class CakeFixtureManager.
It lacks support to auto-drop tables after test case end, but it is already usable for testing
2010-05-07 18:07:02 -04:30
José Lorenzo Rodríguez
ef142b1659 Adding the class CakeFixtureManager to delegate the task of creating and droping the fixtures
Tests and docs still pending
2010-05-07 18:06:17 -04:30
Mark Story
26f7fcef3c Updating Controller and its tests to use CakeRequest. 2010-05-06 23:23:13 -04:00
Mark Story
2b7723fd12 Removing reference operators and making Controller::__construct take a CakeRequest. If one is passed all the necessary properties will be populated. This lightens the Dispatcher, and gives more control to the end developer. 2010-05-06 23:18:50 -04:00
Mark Story
1a460e47f1 Removing reference operators in Controller and its tests. 2010-05-06 22:48:48 -04:00
Mark Story
04df4a91dd Merge branch '2.0' into 2.0-request 2010-05-06 22:30:37 -04:00
Mark Story
f152181c03 Adding tests for saving models with id == null. Closes #675 2010-05-06 22:24:11 -04:00
Mark Story
1c3415759a Fixing 'Only variables should be assigned by reference' errors in php4 in form helper. Fixes #643 2010-05-06 22:11:31 -04:00
Mark Story
1c1c511853 Changing how email validation methods are applied, to fix issues where getmxrr() exists but the domain being validated does not have MX records correctly configured. Fixes #634 2010-05-06 21:43:58 -04:00
Mark Story
45d052b55a Fixing failing tests in ViewTask test case, caused by changes in core templates.
Fixing incorrect variable usage where models would be double singularized causing incorrect names.  Fixes #668
2010-05-06 21:38:14 -04:00
Mark Story
5ea4f027db Fixing TestTask so that if you give an invalid class type you get an error. 2010-05-06 07:31:52 -04:00
José Lorenzo Rodríguez
bed87b87c6 Removing code from CakeTestCase around the method "testAction" which was a bad way of testing controllers, often making it more difficult.
This also removes class contamination in newly created test cases
2010-05-05 22:42:56 -04:30
José Lorenzo Rodríguez
b53d21ff52 Fixing a group test case to show how to create one, and to make pass TestManager test case 2010-05-04 23:58:17 -04:30
José Lorenzo Rodríguez
fd4a82d6e9 Adding test for TestManager::runGroupTest() 2010-05-04 23:56:40 -04:30
José Lorenzo Rodríguez
856a52a378 Changing runGrouptTest to find for conventional class names. This commit removes the support for loading more than one groupt test class per file 2010-05-04 23:13:07 -04:30
Mark Story
918e961f7d Fixing typo in testtask. Fixes #659 2010-05-04 23:29:54 -04:00
Mark Story
fcad9b464c Fixing tests broken by changes in default bake templates.
Fixing issue where admin methods wouldn't be correctly generated.
Fixes #664
2010-05-04 23:27:41 -04:00
Mark Story
62157679c4 Fixing failing test in Dispatcher caused by removed method. 2010-05-04 23:08:03 -04:00
Mark Story
b9a00ccfa5 Updating test case to use new Router constants. 2010-05-04 23:05:45 -04:00
José Lorenzo Rodríguez
41683723f7 Making more methods static in TestManager 2010-05-04 21:04:18 -04:30
José Lorenzo Rodríguez
c23f66e35c Removing "extends" from TestManager as it wasn't used anyway.
Making some methods static as they were called statically
More testing on TestManager
2010-05-04 20:51:58 -04:30
predominant
719836c41d Updated doc block for added HTTP Status. 2010-05-05 10:09:47 +10:00
José Lorenzo Rodríguez
cdf4006f16 Refactoring TestManager::runAllTests() and improving the TestManager test case 2010-05-04 18:25:15 -04:30
José Lorenzo Rodríguez
4a152d3d55 Adding number of assertion runned in html reporter
enabling "show passes" (that in contrast of simpletest only reports the passed test method instead of the assertion)
cleaning up a bit
2010-05-04 16:31:03 -04:30
José Lorenzo Rodríguez
10434c35b6 Improving PHPUnit path detection when it is installed via pear 2010-05-04 16:30:06 -04:30
José Lorenzo Rodríguez
9afbeaa217 Converting CakeHtmlReporter in a TestCase listener.
this apparently shows that it is easy to make the transition to PHPUnit.
2010-05-04 13:51:25 -04:30
José Lorenzo Rodríguez
ce7f892d6a Removing simpletest dependency in CakeBaseReporter 2010-05-04 13:50:07 -04:30
José Lorenzo Rodríguez
15dd798e30 Some experimental movements inside TEstManager to make it work with PHPUnit 2010-05-04 13:49:10 -04:30
José Lorenzo Rodríguez
14559aabd9 Adding compatibility assert methods for CakeTestCase to ease the transition to PHPUnit 2010-05-04 13:47:08 -04:30
José Lorenzo Rodríguez
7417a00de7 Initial step to replace simpletest for PHPUnit
This is probably temporary, still needed to see if PHPUnit is already in path (installed with pear or something)
2010-05-04 13:40:50 -04:30
Mark Story
e9a7d6d3b9 Splitting CakeRoute and PluginShortRoute into their own files. Also splitting out the test cases. 2010-05-04 00:35:22 -04:00
Mark Story
f76d320688 Making Router a fully static class. Tests updated. 2010-05-04 00:26:02 -04:00
Mark Story
c91d74a9af Making CakeRequest toss an exception when it can't handle a method call. 2010-05-03 23:41:13 -04:00
Mark Story
c5fdeec7a1 Updating FormHelper tests to use CakeRequest. 2010-05-03 23:39:43 -04:00
Mark Story
69275c8996 Adding a parameter to CakeRequest to allow it to skip parsing the environment. 2010-05-03 22:50:38 -04:00
Mark Story
ce10c85367 Making Sanitize::stripScripts() to remove multi-line script and style blocks. Fixes #657 2010-05-03 22:33:20 -04:00
Mark Story
95dbae8acf Making RequestHandler component carry along a passed status code. This fixes issues where RequestHandler hijacks an redirect(). Fixes #658 2010-05-03 22:07:13 -04:00
predominant
87db966383 Remove PHP5 conditional statements. 2010-05-03 13:36:32 +10:00
predominant
c1eaa4b24c Fixed access and removed @access tags. 2010-05-03 13:28:09 +10:00
Mark Story
c48f6d6536 Fixing safe parameter from leaking into request() calls in JsHelper::submit() and JsHelper::link(). Fixes #656 2010-05-02 21:17:10 -04:00
Jose Diaz-Gonzalez
1180f66cc0 Setting $actions to null so that the controller methods are not always based upon the first controller in an app/plugin.
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-02 20:35:19 -04:00
Mark Story
8c7cfb2a1e Changing string offset access. 2010-05-02 18:04:13 -04:00
Mark Story
d94ff92a9d Merge branch '2.0' into 2.0-request
Conflicts:
	cake/libs/view/pages/home.ctp
	cake/tests/cases/dispatcher.test.php
	cake/tests/lib/reporter/cake_html_reporter.php
2010-05-02 18:03:23 -04:00
Mark Story
dc08aedb44 Fixing constructors for reporter classes. 2010-05-02 17:54:49 -04:00
Mark Story
adf604a966 Merge branch '1.3' into 2.0
Conflicts:
	cake/console/templates/default/actions/controller_actions.ctp
	cake/console/templates/default/views/form.ctp
	cake/console/templates/default/views/index.ctp
	cake/console/templates/default/views/view.ctp
	cake/libs/controller/controller.php
	cake/libs/controller/scaffold.php
	cake/libs/view/pages/home.ctp
	cake/tests/cases/dispatcher.test.php
	cake/tests/cases/libs/model/cake_schema.test.php
2010-05-02 17:53:42 -04:00
Mark Story
b5a0dccc3a Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3 2010-05-02 17:03:20 -04:00
Mark Story
4a0ead8a62 Fixing asset filtering for assets in themes and plugins. These assets should now correctly enter the configured asset filters. Fixes #650. Fixes #160 2010-05-02 16:48:35 -04:00
Mark Story
e11f7da896 Adding support for Router::reverse() to operate on CakeRequest objects. 2010-05-02 02:19:32 -04:00
Mark Story
7e25d94258 Renaming internals of Router.
Adding tests for legacy setRequestInfo() support.
2010-05-02 02:16:16 -04:00
Mark Story
26279851e1 Making Router::setRequestInfo() able to accept arrays. It will convert older style arrays into a CakeRequest object for later use.
Updating uses of Router::setRequestInfo() to just pass the object where possible.
2010-05-02 01:59:56 -04:00
Mark Story
e336df6de8 Updating some uses of Router::setRequestInfo(). 2010-05-02 01:43:37 -04:00
Mark Story
9a1858367f Removing unused and untested feature. 2010-05-02 01:24:44 -04:00
Mark Story
982437595e Fixing errors caused by API changes. 2010-05-02 01:22:59 -04:00
Mark Story
4eef2c19f0 Making CakeRequest::addParams() chainable. Adding CakeRequest::addPaths() to allow easy settings of path variables, its also chainable. Tests added. 2010-05-02 01:22:34 -04:00
Mark Story
bd1365f8ae Changing interactions inside Router so it doesn't need a CakeRequest object, makes changes to Router test not necessary. 2010-05-02 00:29:35 -04:00
Mark Story
12cbf3198a Removing addslashes/stripslashes in cache file generation as they were creating corrupted serialized objects. Replacing with a simple str_replace() on ' instead. 2010-05-02 00:12:53 -04:00
Mark Story
13cc8e746d Moving tests into CakeRequest from dispatcher test.
Dispatcher tests are all working again.
2010-05-01 23:49:22 -04:00
Mark Story
e4cf8a6937 Fixing issue where 'data' could not be accessed with array access, there were tests in Dispatchers tests that expected this. 2010-05-01 23:46:10 -04:00
Mark Story
d2ea077b81 Moving parameter parsing below asset dispatching, should speed up asset dispatching.
Updating + fixing tests to reflect API changes and fixing some issues where router was breaking assets.
2010-05-01 23:19:47 -04:00
Mark Story
aa234bc861 Making CakeRequest keep [url][url] for compatibility issues. 2010-05-01 22:45:31 -04:00
ADmad
f386dca6d8 Controller::loadModel() now returns true when model is succesfully instantiated as stated in docblock. Added test case. 2010-05-02 05:34:38 +05:30
Mark Story
257665eb5b Updating doc blocks for bindModel and unbindModel, explaining that associations are only reset when find() is called. Refs #652 2010-05-01 17:37:23 -04:00
Mark Story
0eb4849803 Renaming a method. 2010-05-01 11:08:58 -04:00
Mark Story
2b08ad6012 Updating fatal tests in Dispatcher tests. Updating Router to use a method instead of a raw array_merge. 2010-05-01 11:07:32 -04:00
Mark Story
0a7ba707b6 Adding tests for CakeRequest::addParams() 2010-05-01 11:06:51 -04:00
Mark Story
40bca71985 Adding tests and features for CakeRequest to parse querystring args from the url parameter in the constructor. Added tests. 2010-05-01 11:04:41 -04:00
Mark Story
fbd70bf23c Making Dispatcher::parseParams require a CakeRequest object instead of as string url. Updating tests in the Dispatcher, and fixing an issue where POST params would be wiped out by Router. 2010-05-01 10:48:30 -04:00
Mark Story
ffd05ffc3e Removing methods from Dispatcher that have been moved to CakeRequest.
Removing test cases for features that don't exist anymore.
Updating Router and Dispatcher to use the request object.
2010-05-01 01:43:06 -04:00
Mark Story
558aea0221 Moving tests and helper methods from Dispatcher into CakeRequest 2010-05-01 01:06:09 -04:00
Mark Story
1b5c0cca4d Removing duplicated code and moving methods to protected. 2010-05-01 00:32:43 -04:00
Mark Story
4deacf0b06 Existing tests are now all passing. 2010-05-01 00:18:17 -04:00
Mark Story
c7f4334bff Moving test code around and starting to refactor things in tests. 2010-04-30 23:37:16 -04:00
José Lorenzo Rodríguez
ad51115e12 Fixing bug where required class would be added to form fields when using single rule syntax in $validate even if allowEmpty is set to true
Closes #654
2010-04-30 16:42:59 -04:30
José Lorenzo Rodríguez
9b040a5ed3 Fixing code formating 2010-04-30 16:07:59 -04:30
ADmad
0471ea046f Adding test case for 'required' class adding to wrapping div based on model validations. Refs #654 2010-05-01 01:19:52 +05:30
Mark Story
85b86164e3 Starting to move additional methods from Dispatcher into CakeRequest. Tests have been moved, and updated. 2010-04-30 00:13:24 -04:00
Mark Story
51db3c80ef Moving query string params around. Updating test cases. 2010-04-29 23:20:31 -04:00
Mark Story
0bbd7fae2c Adding more tests to CakeRequest::addDetector() for callback type. 2010-04-29 23:11:15 -04:00
Mark Story
6dcc680c1a implementing CakeRequest::addDetector() and adding test cases. 2010-04-29 23:08:01 -04:00
Mark Story
4fbed678cf Fixing bad method call again. 2010-04-29 22:34:01 -04:00
Mark Story
734e4fa87a Removing the conditional check around including custom session configuration files. This fixes issues where requestAction could cause loss of session settings, and improves the end developers ability to customize the session. Custom session files should ensure that classes/functions are conditionally declared. Fixes #374, #541 2010-04-29 21:40:12 -04:00
ADmad
afd67e534b Fixing parse error created in commit [6d092552e5]. Closes #647 2010-04-30 03:52:39 +05:30
Mark Story
0daf6e4dba Adding skeleton for addDetector. 2010-04-29 00:33:41 -04:00
Mark Story
a6ee9e352d Expanding doc blocks for methods.
Adding ArrayAccess implementation and test cases.
2010-04-29 00:22:33 -04:00
Mark Story
476a76b7a4 Adding __get() and test cases. 2010-04-29 00:22:33 -04:00
Mark Story
c11095bc54 Adding __call() for undefined method handling. Tests added. 2010-04-29 00:22:33 -04:00
Mark Story
3a0ad6f1a8 Starting CakeRequest::is() and adding tests for various core is() types. 2010-04-29 00:22:32 -04:00
Mark Story
aab4a9413a Adding CakeRequest::referer() and test cases. 2010-04-29 00:22:32 -04:00
Mark Story
64aafd36bb Expanding coverage for CakeRequest. Expanding doc blocks in CakeRequest. 2010-04-29 00:22:32 -04:00
Mark Story
93f4c66035 Adding tests for CakeRequest's ability to munge through the FILES array. Fixing issue where files would be in the wrong place. 2010-04-29 00:22:32 -04:00
Mark Story
8f207a5f69 Moving getClientIp into CakeRequest. Moving relevant tests as well. 2010-04-29 00:22:32 -04:00
Mark Story
15a4607061 Fixing some issues with parameter handling. Adding test cases. 2010-04-29 00:22:32 -04:00
Mark Story
f17eebecf2 Adding CakeRequest and its test case. Moving features from Dispatcher into CakeRequest. 2010-04-29 00:22:32 -04:00