Commit graph

5739 commits

Author SHA1 Message Date
mark_story
d83c51cde9 Fixing expiration conditions on CSRF tokens. 2010-10-02 18:27:39 -04:00
mark_story
7f7c202f35 Removing old CSRF token validation checks.
Removing failing test because the feature moved.
Adding tests for expired and wrong keys.
2010-10-02 17:16:40 -04:00
mark_story
ac90916b84 Adding some documentation about token consumption. 2010-10-02 00:22:44 -04:00
mark_story
a10f1478ee Adding support for nonce expiry.
Adding simple time based nonce expiration. This does a simple cleanup on
each request, to remove stale tokens.  Tests added.
2010-10-02 00:20:58 -04:00
mark_story
5c27abd35f Applying patch from 'hashmich' to make jQueryEngine not override the success callback. This allows you to provide a success callback and still get the html insertion when used with the update key.
Tests updated.
Fixes #1158
2010-10-01 22:43:46 -04:00
mark_story
711e736cd3 Adding very minimal and incomplete implementation of csrf consumption.
Tests added for consuming csrf tokens on each request.
2010-10-01 00:13:34 -04:00
mark_story
5e26d282a1 Fixing connection specific schema generation
Fixing missing table errors when reading schema for specific connections.
Tests updated to check that tables not on a connection are never touched.  Fixes #1106
2010-09-30 23:22:57 -04:00
mark_story
d83907a77d Changing order of conditions, to put cheaper ones first.
Also fixes issues on safe_mode servers.
Fixes #1164
2010-09-30 23:03:23 -04:00
mark_story
dc6b33f80e Making tokens persist across 'requests'.
Removing more serialize/unserialize calls.
2010-09-30 00:26:44 -04:00
mark_story
f5ed91137a Adding csrfCheck related properties.
nonces are now being populated into the session.
2010-09-30 00:18:25 -04:00
mark_story
b088daf045 Adding tests for csrf feature separation.
Removing serialize() calls as they didn't really add anything.
2010-09-30 00:06:38 -04:00
mark_story
c573fd0432 Fixing issue where a beforeDelete() could trigger a table truncation.
Moving the exists check below beforeDelete() and behavior->beforeDelete() so any records deleted in the callbacks will not exist when db->delete() is called.  Test updated. Fixes #250
2010-09-29 23:31:41 -04:00
mark_story
72a1c959a1 Adding CakeSession::clear() which is primarily useful when testing, and offers an alternative to using CakeSession::destroy() 2010-09-29 23:01:23 -04:00
mark_story
b08aba8e86 Adding a missing rollback when validation on an associated record fails, and validate = first. Fixes #1147 2010-09-28 23:37:28 -04:00
mark_story
0761edecfb Making the cake:nocache stripping more relaxed so that if either condition to enable caching is on, tags will be stripped. Tests added. Fixes #1148 2010-09-28 23:03:56 -04:00
mark_story
995a14c140 Making MemcacheEngine understand IPv6 addresses. Fixes #1143 2010-09-26 01:11:19 -04:00
mark_story
6d7f2d37ab Fixing issue where fields with the exact same name as the model would result in incorrect name attributes. Tests added. Fixes #1123 2010-09-26 00:46:51 -04:00
mark_story
237b66d193 Adding support for httpOnly cookies to CookieComponent. Fixes #1127 2010-09-25 23:24:37 -04:00
mark_story
3395f4221e Adding Inflector::reset(). This makes non-isolated test runs possible. Adding inflector to the libs suite. 2010-09-25 23:04:49 -04:00
mark_story
d64bd2a82c Making cookie component not send gobs of headers when being tested.
Making test case pass in cli.
2010-09-24 23:30:01 -04:00
mark_story
b59033687d Making private properties and methods protected so they can be manipulated with mocks. 2010-09-24 23:30:00 -04:00
mark_story
cdda1bfb17 Correcting comment. 2010-09-24 23:28:48 -04:00
mark_story
f21161ef46 Merge branch '1.3' into 2.0. Had to fix a number of 1.3 -> 2.0
differences upon merging.

Conflicts:
	app/config/core.php
	cake/console/templates/skel/config/core.php
	cake/libs/cache/file.php
	cake/libs/cake_session.php
	cake/libs/controller/components/email.php
	cake/libs/i18n.php
	cake/libs/view/pages/home.ctp
	cake/tests/cases/libs/cache/memcache.test.php
	cake/tests/cases/libs/model/model_write.test.php
2010-09-24 23:27:22 -04:00
mark_story
a4746c7227 Applying patch from 'kworr' to reorder the switch in DboPostgres::value() to fix issues with pgsql 9.0. Fixes #1139 2010-09-24 22:47:18 -04:00
mark_story
8cd266c77f Correcting example in doc block. Fixes #1132 2010-09-24 22:23:24 -04:00
ADmad
e161b41e3c CakeSession::__write() now correctly uses the Session model's primaryKey instead of hardcoded fieldname "id". Fixed #1129 2010-09-23 14:00:59 +05:30
mark_story
7e4f9c4953 Merge branch '1.3' of github.com:cakephp/cakephp into 1.3 2010-09-21 21:14:23 -04:00
mark_story
ce1115b0b4 Adding I18n::clear() to remove most of the private variable access from the i18n test case.
Changing casing of classname in test case.
2010-09-21 21:13:45 -04:00
0x20h
2eac24c31a removed destructor, caching is done on file loading (fixes and improves #1085)
Signed-off-by: mark_story <mark@mark-story.com>
2010-09-21 21:03:36 -04:00
0x20h
ba8280423d * changed indexing order of the i18n __domains array to allow caching by domain+language (fixes #1085)
* adapted testcase

Signed-off-by: mark_story <mark@mark-story.com>
2010-09-21 21:03:29 -04:00
mark_story
729a45703b Fixing issue where table names with spaces would not be quoted by name(). Fixes #1121 2010-09-21 20:34:27 -04:00
ADmad
b9a7b27ba1 Fixing regression cased by commit d5ffdc288d causing ajax layout to be not auto set for ajax request for html pages. Refs #1099 2010-09-21 00:25:17 +05:30
mark_story
b648b61422 Merge branch '1.3' of github.com:cakephp/cakephp into 1.3 2010-09-19 18:32:07 -04:00
mark_story
c3d5c3fd00 Fixing issue in Cache where duration = 0 would not read/write from cache. This prevented the creation of non expiring cache entries in APC and memcache.
Adding a return false to FileEngine as it was omitted in the past.
Fixes #1120
2010-09-19 12:20:07 -04:00
ADmad
e10d634f91 Mails sent using php's "mail()" function now have header fields terminated by CRLF and body too contains CR and LF only as combination CRLF in compliannce with RFC 2822. Closes #1071 2010-09-19 03:54:32 +05:30
mark_story
7518d0e804 Removing dead code in Cache.
Adding tests for ApcEngine::clear().
2010-09-18 12:52:08 -04:00
mark_story
b6d845adc4 Updating calls of Cache::set() inside Cache. Updating the documentation for set() so it better explains how the temporary settings work.
Updating APC and Memcache engine tests to reflect the lack of state being stored inside Cache.
2010-09-18 12:32:43 -04:00
mark_story
5e725e62ca Making MemcacheEngine match the interface. 2010-09-18 11:11:51 -04:00
mark_story
b432e60971 Making Cache::set() work with 2 or 3 parameters. Test cases added. 2010-09-18 11:11:28 -04:00
ADmad
d5ffdc288d Including RequestHandler in controller now automatically sends proper content-type and encoding headers for html pages too like it does for other known file types. Closes #1099 2010-09-18 20:20:52 +05:30
mark_story
9ccbe5e269 Removing unnecessary call to config(). 2010-09-18 00:46:26 -04:00
mark_story
dc65f2306b Making Cache methods always need a config name. This allows the removal of hidden and often confusing state that gets remembered by Cache each time config() is called. Removing the hidden state makes Cache more predictable. 2010-09-18 00:45:29 -04:00
Joe Beeson
b9163b95fe Added a warning that will appear on the homepage to alert users that
their PCRE installation doesn't have Unicode support which can cause a
whole mess of trouble if gone unnoticed. The warning will only display
if their system doesn't have support, not if it does. Fixes #1113

Signed-off-by: mark_story <mark@mark-story.com>
2010-09-18 00:17:51 -04:00
mark_story
e91fa68f8e Making the set() functions use + instead of array_merge() so that numeric indices are properly preserved across multiple method calls. Fixes #1105 2010-09-18 00:13:03 -04:00
mark_story
d113d7d612 Removing dead code from DboSource::fields()
Updating fields() to use implode, so complex virtual fields are better handled.  Fixes #1079
2010-09-18 00:04:36 -04:00
mark_story
5a8648cca0 Fixing issue in DboSource::_matchRecords() where unqualified conditions would result in 1=1 conditions. Fixing incorrect test case. Fixes #930 2010-09-16 00:17:09 -04:00
mark_story
1707c92aa1 Removing duplicated code. 2010-09-14 23:15:10 -04:00
mark_story
c255539980 Removing assignment of reference to theme view.
Removing cruft in ThemeView test.
2010-09-14 23:13:00 -04:00
mark_story
f34cfd1f1e Updating EmailComponent to use new methods on the ComponentCollection to ensure it always has a controller reference.
Removing triggerDisabled key as its no longer needed or wanted.
2010-09-14 23:02:38 -04:00
mark_story
273a189e98 Adding some documentation about component callbacks. 2010-09-14 23:01:39 -04:00
mark_story
30589e2cdf Removing dead method. 2010-09-14 22:56:33 -04:00
mark_story
0ef76eb69a Adding a reference of the controller to the component collection, so components can easily access the controller in their constructor. 2010-09-14 22:52:51 -04:00
mark_story
7a14d3a8f2 Fixing issue where mockObject expectations were not counted hiding fails. Fixing all objects not actually being iterated. 2010-09-14 22:40:46 -04:00
mark_story
0baaf6801b Removing call to RequestHandler as its just a pass through to the request object which is available in that scope. Updating the test cases to not use deprecated and non-existent things. 2010-09-14 22:12:14 -04:00
mark_story
97dd7c7644 Adding support to ObjectCollection and its subclasses to trigger callbacks on all objects instead of just the enabled ones. Fixes issues where inner components would not get access to the controller as the initialize callback wasn't fired. This fixes some backwards compatibility issues. Tests updated. 2010-09-14 21:57:40 -04:00
mark_story
2906927a16 Adding BC wrappers for helpers.
Updating paginator test case to use non deprecated properties.
2010-09-13 23:12:00 -04:00
mark_story
e4b2fb173b Removing the deprecated properties.
Removing property copying to helpers.
Making the view test cases pass again.
2010-09-13 23:11:59 -04:00
mark_story
634cea24eb Adding 'action' into View::__get() to make an integration test pass. 2010-09-13 23:11:59 -04:00
mark_story
a521291afd Adding a __set() method to make some tests pass.
Updating internal usage to not use deprecated attributes.
Updating test cases to not use deprecated attributes.
2010-09-13 23:11:59 -04:00
mark_story
84565151de Removing all the deprecated properties from Controller.
Adding a __get() method to provide the properties that were moved to CakeRequest.
Tests added.
2010-09-13 23:11:59 -04:00
mark_story
c7fb20d13a Reformatting doc block indentation. 2010-09-13 23:09:00 -04:00
mark_story
834c44b303 Fixing return value tag. 2010-09-13 23:06:15 -04:00
mark_story
d7bb7699e2 Applying patch from '0x20h' to fix issue where domain translation files would be mixed together causing duplicate data in the various cache files. There should now be one cache per domain + language. Fixes #1085 2010-09-13 22:17:05 -04:00
mark_story
6519de3a2e Adding CakeRequest::data() to make reading/writing data similar to CakeSession.
Tests added.
2010-09-12 14:05:57 -04:00
mark_story
730e373afe Merge branch '1.3' into 2.0
Conflicts:
	cake/libs/cake_session.php
	cake/libs/view/pages/home.ctp
	cake/tests/cases/libs/cache/memcache.test.php
	cake/tests/cases/libs/cake_session.test.php
	cake/tests/cases/libs/model/datasources/dbo_source.test.php
	cake/tests/fixtures/data_test_fixture.php
2010-09-12 13:35:46 -04:00
mark_story
e9d194822d Adding more tests for SMTP address formatting. Fixes #1100 2010-09-12 11:48:09 -04:00
Juan Basso
46f784f956 Support to DOMDocument/DOMNode in Xml::toArray(). 2010-09-12 11:25:37 -03:00
predominant
703344cbae Updated version number to 1.3.4 2010-09-12 17:57:55 +10:00
Juan Basso
a006ee0019 Updating docs. 2010-09-11 22:20:21 -03:00
Juan Basso
7237713a30 Added test to dont use encoding in XML. 2010-09-11 22:12:54 -03:00
Juan Basso
2e7851c2be Support to namespaces in Xml::fromArray(). 2010-09-11 21:51:49 -03:00
mark_story
e4d34b640b Merge branch '2.0-exceptions' into 2.0
Conflicts:
	cake/libs/error.php
	cake/tests/cases/libs/controller/scaffold.test.php
	cake/tests/cases/libs/error.test.php
2010-09-10 20:31:16 -04:00
Scott Reeves
9ac8d1af1b Cleaning up link to 1.3 docs, fixing link to blog tutorial. Fixes #1097
Signed-off-by: mark_story <mark@mark-story.com>
2010-09-10 19:42:06 -04:00
mark_story
f8dbeb2b70 Adding documentation for a new feature. 2010-09-09 22:02:36 -04:00
mark_story
4a0e34a0d6 Applying patch from 'jeremyharris' to make RequestHandler::renderAs() accept an array of options that can be used to send a file as a download. Fixes #950 2010-09-09 21:31:34 -04:00
mark_story
d5e906f086 Adding deprecation flags. 2010-09-08 22:49:00 -04:00
mark_story
12338a0c16 Updating instance method calls in AclComponent. 2010-09-08 22:48:21 -04:00
mark_story
b60f65f420 Adding a tiny bit of documentation to App::import(). 2010-09-08 22:29:47 -04:00
mark_story
d5bde3fe7a Adding a call to session_destroy() to remove the session data. This fixes the issue where data would not be totally destroyed. Fixes #1089 2010-09-08 22:05:53 -04:00
Juan Basso
c8c20eafdc Xml::build now supports options and can return DOMDocument. 2010-09-08 21:47:55 -03:00
Juan Basso
071ff04556 Xml::fromArray now receives a list of options unless simple format. 2010-09-08 19:40:33 -03:00
Juan Basso
a8b6182d43 Changing Xml::fromArray to use DOMDocument unless SimpleXMLElement. The return continue as SimpleXMLElement. 2010-09-08 19:18:58 -03:00
mark_story
5d703c4f50 Fixing + adding imports for Scaffold. 2010-09-08 00:11:37 -04:00
mark_story
fa9eb94fb0 Adding base class import for view classes. 2010-09-08 00:10:36 -04:00
mark_story
4ff52da57e Making import() ing a component ensure that the Component base class is loaded. 2010-09-07 23:39:31 -04:00
Juan Basso
ca7e327af1 Fixing the documentation. 2010-09-07 18:19:14 -03:00
Mark Story
2b3099fa70 Removing duplicate method call. 2010-09-07 00:42:49 -04:00
Mark Story
e15069769d Adding tests for #1079 and fixing some formatting. 2010-09-07 00:09:06 -04:00
Juan Basso
c1a75cbc47 Support to namespaces in Xml::toArray(). 2010-09-07 00:31:50 -03:00
Juan Basso
5f902d42e0 Changing the default format of fromArray from attributes to tags. 2010-09-06 23:11:45 -03:00
Mark Story
0f23634382 Adding stack traces to error400 and error500 when debug > 0.
Adding the stack trace element.
2010-09-06 18:09:11 -04:00
Mark Story
09fd8ba463 Adding stack trace output to the framework errors. 2010-09-06 17:54:48 -04:00
Mark Story
d88da3d579 Merge branch '1.3' into 2.0
Conflicts:
	cake/libs/configure.php
	cake/libs/model/connection_manager.php
	cake/libs/model/model.php
	cake/tests/cases/libs/model/datasources/dbo/dbo_postgres.test.php
	cake/tests/cases/libs/view/helpers/text.test.php
2010-09-06 16:53:04 -04:00
Mark Story
c60edfae6d Fixing issue where errors containing code = 500, were not actually converted to error500 when debug = 0. Making missingConnection, and missingTable into error500 errors. 2010-09-06 16:46:41 -04:00
Mark Story
464d2217e6 Renaming model_behavior test to behavior_collection test as that's the class that contains the tested methods. 2010-09-06 13:51:42 -04:00
Mark Story
73057b8853 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2010-09-06 13:39:37 -04:00
Mark Story
5789aaf24d Applying patch from 'tkykmw'. Behavior mapped methods are no longer run through strtolower(). Mapped methods are now case sensitive. Fixes #318 2010-09-06 13:38:01 -04:00
predominant
a6b08c94d0 Merge remote branch 'origin/2.0' into 2.0
Conflicts:
	cake/libs/session/database_session.php
2010-09-06 23:57:36 +10:00
Mark Story
d54c901f5d Moving _setupDatabase() into the Database session class, as that's the only place its used. 2010-09-06 01:12:23 -04:00
Mark Story
474ace09c1 Adding CakeResponse to the list of included files for Controller. 2010-09-06 01:11:26 -04:00
Mark Story
d62ae2900a Fixing issue where ConnectionManager wasn't triggering session close, causing issues with database sessions. 2010-09-06 01:10:45 -04:00
Mark Story
27ae7f1f44 Making session storage classes not static, there was no real reason they were static before, and removing the static methods allows them to have constructors. This will allow moving database specific features from CakeSession to DatabaseSession. 2010-09-06 00:43:58 -04:00
ADmad
bfaaa6b8ba Fixing unnecessary extra calls to 'afterFind' callback of 'hasMany' associated models. Closes #995 2010-09-05 23:53:24 +05:30
Mark Story
01eb0bf07d Making messages optional for HTTP exceptions. 2010-09-05 11:32:35 -04:00
Mark Story
e5b4dd94d7 Renaming exceptions to not use Error400, Error500. Instead HTTP status words are used.
Adding more common HTTP status errors.
Updating tests for ErrorHandler.
2010-09-05 02:05:31 -04:00
Mark Story
b7791dd94f Removing variable that wasn't provided by the exception. 2010-09-05 02:04:08 -04:00
Mark Story
82fffe6914 Fixing issue where FormHelper::select() with multiple = checkbox and a custom name attribute would not work correctly. Fixes #1078 2010-09-05 01:28:13 -04:00
Mark Story
cc17e1a85a Adding more doc blocks to error classes. 2010-09-04 19:18:14 -04:00
Mark Story
954676c9f6 Adding doc blocks to the new exception classes. 2010-09-04 19:16:06 -04:00
Mark Story
d198230e61 Fixing issue where errors that did not have a 500+ code would use the incorrect status code. 2010-09-04 19:06:10 -04:00
Mark Story
4d863618f5 Refactoring exception handling so codes are much more flexible and easy to change.
Made error404 and error500 more generic.
Removed error() as it didn't really make that much sense.
2010-09-04 15:38:10 -04:00
Mark Story
4980f42dc5 Renaming file. 2010-09-04 15:35:01 -04:00
Mark Story
fa7549dc4c Fixing comments and removing cakeError(). Instead you should be throwing exceptions. 2010-09-04 01:34:45 -04:00
Mark Story
8c428ff8a8 Moving where AppError is used, as infinite recursion is no fun. 2010-09-03 15:03:33 -04:00
Mark Story
f2db19767d Adding in support for AppError. 2010-09-03 10:30:35 -04:00
Mark Story
3940b059a3 Adding a big docblock to explain how to setup application exception handling. 2010-09-02 16:39:09 -04:00
Mark Story
2e8a60f932 Removing some mentions of cakeError as its been removed. Also adding information about exceptions that can be raised. 2010-09-02 16:38:19 -04:00
Mark Story
dbdd17f51a Adding test cases from 'euromark' and updating how email addresses are parsed so they are slightly more conformant to RFC 5322. Fixes #1066 2010-09-02 11:16:10 -04:00
Mark Story
3e5e52d52e Fixing doc block for Form::create(). Fixes #1058 2010-09-02 00:29:04 -04:00
Mark Story
063fcf557d Moving error handler inclusion to before Configure::bootstrap() so app error handlers can be created.
Fixing issue where unknown exception types would not be handled spewing out errors.  Unknown exception types are interpreted as 500 errors.
2010-09-01 20:29:55 -04:00
mark_story
a8d4015f47 Updating bootstrap process in CLI to match the one in web.
Updating all_libs to use new file.
Updating error_handler test to run in cli.
Updating Controller so it imports required classes.
2010-08-30 22:59:10 -04:00
mark_story
1f30c06695 Fixing method coercion in error404 so it only coerces CakeExceptions.
Test Added.
2010-08-29 23:39:28 -04:00
mark_story
534f6006f8 Adding omitted parent call. 2010-08-29 23:38:46 -04:00
mark_story
612c52bb8b Adding a beforeRender() that automatically escapes all the content sent to errors handled by CakeErrorController. 2010-08-29 23:31:20 -04:00
mark_story
f1164c93d6 Updating the various CakeExceptions to take arrays in their constructors. This allows for the existing templates to continue working, as well as generalize the way in which errors are handled. This change also makes the messages coming out of exceptions more readable and removes string hackery. 2010-08-29 21:37:25 -04:00
mark_story
741f2972f9 Removing non required attribute from missing controller error page. 2010-08-29 15:12:50 -04:00
mark_story
99cde14432 No more skipped tests for ErrorHandler.
Removing missing_model as it was never called.
2010-08-29 13:49:10 -04:00
predominant
465b15c64e Removing reference assignments. 2010-08-29 23:09:33 +10:00
mark_story
7fb62e9b7e Updating more error messages to use exceptions. 2010-08-29 01:26:21 -04:00
mark_story
041aeecce4 Renaming test case file to match class file.
Updating tests and methods for missing_action, missing_view, private_action.
2010-08-29 01:01:36 -04:00
mark_story
88c66c057d Renaming error.php to error_handler.php to better match its class name. 2010-08-29 01:00:36 -04:00
mark_story
756baeafdb Making CakeErrorController get the most recent request, this will help when using requestAction.
Updating test cases for error404.
Updating ErrorHandler
2010-08-28 23:32:14 -04:00
mark_story
8712a90c8b Adding some tests for construction. 2010-08-28 22:50:29 -04:00
mark_story
a30721b46b Moving exception classes around and making all the core exceptions extend one class that overrides the code to 500. The code value will be used as the HTTP status code for the error page. 2010-08-28 22:49:52 -04:00
mark_story
5d942ee609 Extracting a few methods to make testing easier, and subclasses easier to create. 2010-08-28 19:53:21 -04:00
mark_story
5257a66fe5 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2010-08-28 11:26:28 -04:00
mark_story
26f4ad4da1 Modifying bootstrap so it sets a default exception handler.
Making a ghetto implementation of exception handling.
Adding a crude test case, adding incomplete markers to all other tests.
2010-08-28 01:39:02 -04:00
predominant
04d3353ee4 Adding access specifiers to methods 2010-08-28 15:38:48 +10:00
mark_story
9b3e91089a Adding omitted types of exceptions. 2010-08-28 01:38:03 -04:00
mark_story
5de88c0f02 Moving CakeErrorController to its own file. 2010-08-28 01:37:39 -04:00
predominant
f7addabcf2 Whitespace removal 2010-08-28 15:27:12 +10:00
mark_story
a2186c412a Updating doc blocks for CakeRequest and CakeResponse. 2010-08-28 00:59:07 -04:00
mark_story
d8b2bcdf06 Making view + helpers groups pass. 2010-08-28 00:40:12 -04:00
mark_story
9485f0a993 Merge branch 'request-response' into 2.0
Conflicts:
	cake/tests/cases/libs/controller/controller.test.php
2010-08-28 00:24:07 -04:00
mark_story
e4545dbe5e Fixing failing tests in Dispatcher.test. 2010-08-28 00:19:09 -04:00
mark_story
c76f205bcb Adding exceptions file. 2010-08-28 00:18:46 -04:00
mark_story
2cdb10812d Merge branch '2.0-exceptions' into 2.0
Conflicts:
	cake/dispatcher.php
	cake/libs/controller/scaffold.php
	cake/tests/cases/dispatcher.test.php
2010-08-28 00:14:34 -04:00
mark_story
dc67b9cacc Moving all the exceptions into one file for the short term. 2010-08-28 00:08:35 -04:00
José Lorenzo Rodríguez
f63b093d24 Merge branch '2.0-request' into 2.0
Still tons of tests failing
Conflicts:
	cake/dispatcher.php
	cake/libs/controller/components/auth.php
	cake/libs/controller/components/request_handler.php
	cake/libs/controller/components/security.php
	cake/libs/controller/controller.php
	cake/libs/router.php
	cake/libs/view/helper.php
	cake/libs/view/helpers/html.php
	cake/libs/view/view.php
	cake/tests/cases/dispatcher.test.php
	cake/tests/cases/libs/controller/components/auth.test.php
	cake/tests/cases/libs/controller/components/request_handler.test.php
	cake/tests/cases/libs/controller/components/security.test.php
	cake/tests/cases/libs/controller/controller.test.php
	cake/tests/cases/libs/router.test.php
	cake/tests/cases/libs/view/helper.test.php
	cake/tests/cases/libs/view/helpers/cache.test.php
	cake/tests/cases/libs/view/helpers/form.test.php
	cake/tests/cases/libs/view/helpers/html.test.php
	cake/tests/cases/libs/view/helpers/js.test.php
	cake/tests/cases/libs/view/helpers/paginator.test.php
2010-08-27 23:31:41 -04:30
mark_story
0683dc43ff Replacing cakeError calls with exceptions in ConnectionManager and Model. 2010-08-27 23:54:22 -04:00
mark_story
c4cb629d80 Replacing cakeError with exceptions in Scaffold. 2010-08-27 23:54:00 -04:00
mark_story
b301b0d86e Adding MissingModelException. 2010-08-27 23:04:35 -04:00
mark_story
4cc2229641 Updating CacheHelper to use correct View API.
Updating View to make CacheHelper tests pass.
2010-08-26 23:24:09 -04:00
mark_story
b02e213958 Adding test case from '0x20h'. Fixing issue where atomic = false, validate = first and saveAll() saving many rows could return an incorrect value. Fixes #1050 2010-08-26 22:21:39 -04:00
mark_story
ea9e30890f Adding a workaround to DboSource::showLog() to work around fix added in [da9c0da626].
Also adding explanation message when logs are not generated.
2010-08-26 21:24:09 -04:00
dogmatic69
95168cee6e casting the find as an array to avoid errors with array_values() fixes #1041 and 4 failing tests (3 previous)
Signed-off-by: mark_story <mark@mark-story.com>
2010-08-26 20:32:48 -04:00
mark_story
ece055eefe Adding object type check to prevent fatal errors caused by view being used like a model object. Tests added. Fixes #1039 2010-08-23 21:39:23 -04:00
Juan Basso
65726841cd Merge branch 2.0-xml of github.com:cakephp/cakephp into 2.0-xml 2010-08-23 01:49:42 -03:00
Juan Basso
f8b4d92a34 Arrays with @ as key now is the value of tag in Xml. 2010-08-23 01:33:06 -03:00
mark_story
ac36bc5894 Adding some docblocks to Xml. 2010-08-23 00:01:55 -04:00
Juan Basso
f777bd983f Making Xml::fromArray() parse @ in attibutes keys. 2010-08-23 00:48:34 -03:00
Juan Basso
9611ab1027 Changing to Xml::toArray() return @ after attributes to dont conflict with tags with same name. 2010-08-23 00:24:56 -03:00
mark_story
b5b7595bc0 Fixing issue in scaffold where it accessed $output, which no longer exists. 2010-08-22 12:41:04 -04:00
mark_story
7221f9c3b9 Moving response construction into Controller, this will let controller classes more easily modify the response subclass they want to use.
Test case updated.
2010-08-22 12:31:55 -04:00
mark_story
efc1a2033f Adding spaces infront of comment blocks. 2010-08-22 00:48:24 -04:00
mark_story
ec22db597f Adding methods to get host, domain and subdomains for a request.
Tests added.
2010-08-22 00:44:05 -04:00
mark_story
0ec0962932 Adding CakeRequest::method() to find the name of the HTTP method name used for the request. Test case added. 2010-08-22 00:15:13 -04:00
mark_story
5446a062ee Fixing issue where whitelist would not be used for validation. Test case added. Fixes #1037 2010-08-21 22:48:59 -04:00
mark_story
12d4b52f10 Fixing failing tests in DboMysql and DboPostgres related to localized floats. Refs #1029 2010-08-21 00:49:40 -04:00
mark_story
e23fe25787 Fixing code formatting. 2010-08-21 00:17:40 -04:00
zimakm
b22f2f746b Configure fix problem 3-dimensional arrays to be handled as 4+ arrays.
This saves a lot of execution time when configure holds many values.
Fixes #1028

Signed-off-by: mark_story <mark@mark-story.com>
2010-08-18 22:29:23 -04:00
mark_story
6d8c761f2f Adding a missing s. 2010-08-17 22:25:45 -04:00
mark_story
750fe3aa05 Removing text() and password() as the new __call method handles them.
Updating test cases and adding a test for allowing a magic method to override the type.
2010-08-17 00:13:22 -04:00
mark_story
4efc170ce4 Adding some documentation. 2010-08-17 00:08:41 -04:00
mark_story
e79df23491 Adding a magic __call method to handle html5 inputs and simplify input generation logic. 2010-08-17 00:06:23 -04:00
mark_story
f46241a6e7 Merge branch '2.0' into 2.0-helpers 2010-08-16 23:02:44 -04:00
mark_story
fc9340213e Applying patch from 'thatcode', makes the 'us' rule case insensitive. Fixes #1020 2010-08-16 22:26:48 -04:00
mark_story
c4a978d386 Adding changes missed in the merge. 2010-08-15 23:10:29 -04:00
mark_story
705e90bef7 Merge branch '1.3' into 2.0-merge
Conflicts:
	cake/libs/cache/memcache.php
	cake/libs/cake_session.php
	cake/libs/model/behaviors/acl.php
	cake/tests/cases/dispatcher.test.php
	cake/tests/cases/libs/cake_test_fixture.test.php
	cake/tests/cases/libs/model/behaviors/acl.test.php
	cake/tests/cases/libs/model/datasources/dbo/dbo_postgres.test.php
2010-08-15 23:09:02 -04:00
mark_story
2a50c3a1fb Removing time manipulation so its possible to create memcache entries that do not expire. Updating documentation about the peculiarities of memcache. Refs #871 2010-08-15 22:40:55 -04:00
mark_story
0865679684 Removing _expires keys made with Memcache cache engine. These did not add any value as Memcache already handles expiration of keys. Fixes #871 2010-08-15 22:32:52 -04:00
mark_story
686b9c2c8b Fixing issues in alterSchema in DboMysql and DboPostgres, where fields would be appended to each table being altered.
Also fixed an issue in DboPostgres where the generated alter statements would contain too many ;.
Test cases added.  Fixes #1023
2010-08-15 22:17:02 -04:00
mark_story
1b41a987fa Adding test cases and fixing inflection issues with bases. Tests added. Fixes #1012 2010-08-12 20:26:11 -04:00
mark_story
45064315d4 Fixing a comment. 2010-08-11 22:47:20 -04:00
mark_story
bd89ef533b Updating session helper constructor to fix failing tests in Controller::render() integration tests. 2010-08-11 00:01:24 -04:00
mark_story
74a12940cb Removing incorrect method implementation.
Adding documentation to Component::beforeRedirect()
Adding documentation to ObjectCollection::trigger().
2010-08-10 23:45:28 -04:00
mark_story
2494156e9a Removing reference operators that caused tests to fail.
Adding an alias as several tests relied on a User object being in the registry to autodetect fields.
2010-08-10 23:18:43 -04:00
mark_story
f5bebc9306 Adding an Acl property to AuthComponent and updating tests to use new API's 2010-08-10 23:18:42 -04:00
mark_story
c6a63bae82 Fixing incorrect method call from merge with 1.3 2010-08-10 23:18:42 -04:00
mark_story
db1acb461a Making SessionComponent extend Component. Updating test case. 2010-08-10 23:18:42 -04:00
mark_story
6dbe5b09f8 Fixing failing test caused by undefined variable. 2010-08-10 23:18:42 -04:00
mark_story
5068d62473 Fixing issue that came up in rebasing. 2010-08-10 23:18:42 -04:00
mark_story
d01708b1ef Adding temporary $View property to controller until I figure out a better way to provide access for it. Test case updated to reflect View not being in the registry anymore. 2010-08-10 23:18:42 -04:00
mark_story
07a7e18dc7 Removing ClassRegistry access in RssHelper. 2010-08-10 23:18:41 -04:00
mark_story
65c235023d Removing ability to register View and ThemeView into ClassRegistry. 2010-08-10 23:18:41 -04:00
mark_story
dfa5273b22 Making SessionHelper not use ClassRegistry to access View. SessionHelper still needs to not inherit from CakeSession. 2010-08-10 23:18:41 -04:00
mark_story
576eba3ef9 Removing ClassRegistry use from FormHelper and its test case. 2010-08-10 23:18:41 -04:00
mark_story
90b0ac7258 Removing remaining ClassRegistry::getObject() in HtmlHelper. 2010-08-10 23:18:41 -04:00
mark_story
7b3f2f7e6e Updating methods in Helper to use $this->_View. 2010-08-10 23:18:41 -04:00
mark_story
7efe1636aa Making HtmlHelper not use ClassRegistry to access the View instance. Updating test cases. 2010-08-10 23:18:41 -04:00
mark_story
19f008b1a4 Fixing broken tests in HelperCollectionTest
Moving unload into ObjectCollection as its common between 2 child classes, and possibly a 3rd.
2010-08-10 23:18:40 -04:00
mark_story
426d35d66e Fixing string that got changed in a rebase. 2010-08-10 23:18:40 -04:00
mark_story
0f5e881f26 Fixing typo. 2010-08-10 23:18:40 -04:00
mark_story
7b4916e16a Updating AclComponent to new Component API. 2010-08-10 23:18:40 -04:00
mark_story
a4e2f7c55f Updating intialiize() callbacks. Moving $this->_set() int Component::__construct as all the core components did it. Updating constructors and including parent calls. 2010-08-10 23:18:40 -04:00
mark_story
052c81774c Removing some code duplication. 2010-08-10 23:18:40 -04:00
mark_story
22fbc24560 Adding 'collectReturn' option to ObjectCollection::trigger. lets a callback collect the return of each object and return that.
Adding tests.
2010-08-10 23:18:40 -04:00
mark_story
fac97738ce Making Controller use ComponentCollection. 2010-08-10 23:18:39 -04:00
mark_story
256532b8e4 Updating Components to use Component as the parent class. 2010-08-10 23:18:39 -04:00
mark_story
bf75ab5737 Starting to update Component into a base class instead of a loader class. 2010-08-10 23:18:39 -04:00
mark_story
3666643b84 Adding ComponentCollection and a test case. 2010-08-10 23:18:39 -04:00
mark_story
337ab19145 Updating ObjectCollection::trigger() so it doesn't call __get().
Updating HelperCollection test which was passing by coincidence.
2010-08-10 23:18:39 -04:00
mark_story
62019888ba Changing file headers to reflect accurate licences and versions created. 2010-08-10 23:18:39 -04:00
mark_story
c44c276fa3 Removing ModelBehavior::dispatchMethod(), replacing with call_user_func_array() as its faster and the php4 workaround is no longer needed. 2010-08-10 23:18:39 -04:00
mark_story
409b12954b Simplifying logic and data structures used to store enabled-ness of objects in an object collection. 2010-08-10 23:18:39 -04:00
mark_story
b2250852e4 Moving BehaviorCollection into its own file.
Changing how behaviors are stored in the collection object.  Makes it work the same as HelperCollection.
2010-08-10 23:18:39 -04:00
mark_story
fcbfb556c5 Moving loaded helpers into a protected array.
Adding magic methods to access the object array.
2010-08-10 23:18:39 -04:00
mark_story
c78e869be6 Removing PHP4 workarounds in BehaviorCollection.
Making BehaviorCollection throw exceptions instead of use cakeError.
2010-08-10 23:18:39 -04:00
mark_story
d048813af8 Adding in property copying until this branch gets merged with 2.0-request. 2010-08-10 23:18:39 -04:00
mark_story
6a88452072 Updating TextHelper to not use create_function(). The create_function calls leaked memory and didn't work with the new helper constructors. 2010-08-10 23:18:38 -04:00
mark_story
4672cee5d3 Removing dispatchMethod from JsHelper, its not really that useful, and is good at hiding bugs in mock tests.
Updating test cases.
2010-08-10 23:18:38 -04:00
mark_story
0e933e8893 Updating most helper test cases to use View in their constructors. 2010-08-10 23:18:38 -04:00
mark_story
68ff2e5ce5 Adding additional tests for Helper lazy loading. 2010-08-10 23:18:38 -04:00
mark_story
fc3379767d Moving methods around. ObjectCollection now normalizes helpers arrays. Plugin helpers now lazy load.
Tests updated.
2010-08-10 23:18:38 -04:00
mark_story
98982a6f7a First attempt at lazy loading helpers done. Plugin support not complete. 2010-08-10 23:18:38 -04:00
mark_story
ab815a53ba Helper test case is passing again. 2010-08-10 23:18:37 -04:00
mark_story
087ccabffe Starting to modify Helper constructors. 2010-08-10 23:18:37 -04:00
mark_story
1d983e1cd4 Making MissingView and MissingLayout cake errors into exceptions. 2010-08-10 23:18:37 -04:00
mark_story
a23207791a Modifying View to accept HelperCollection. Removing methods that are no longer needed. 2010-08-10 23:18:37 -04:00
mark_story
f8ecb10407 Adding stub callbacks so errors aren't generated. 2010-08-10 23:18:37 -04:00
mark_story
c15d228515 Initial integration of HelperCollection into View. 2010-08-10 23:18:37 -04:00
mark_story
16d5b2655c Adding a way to load helpers in a disabled state. Updating tests and subclasses. 2010-08-10 23:18:37 -04:00
mark_story
d0de468ce0 Removing options that were not used in the generic application. 2010-08-10 23:18:37 -04:00
mark_story
aa61a251dc Deprecating BehaviorCollection::attach() and BehaviorCollection::detach(). load() and unload() are more generic and make sense in other contexts.
Adding base trigger implementation.
Adding tests for helper triggering.
2010-08-10 23:18:37 -04:00
mark_story
9fd881cb00 Moving methods down and adding some tests. 2010-08-10 23:18:36 -04:00
mark_story
6db3dbc680 Starting to create HelperCollection which will be responsible for loading and constructing helpers.
Making an abstract class that will be the base of all object collections.
Adding test cases.
2010-08-10 23:18:36 -04:00
mark_story
da9c0da626 Changing sql_dump element so it only shows if there is no $logs variable set in the view. Overwriting it could adversely effect helper references. Fixes #998 2010-08-10 23:09:27 -04:00
mark_story
1371cefc3d Applying patch from 'thatcode' to fix an issue where FormHelper::datetime() would not use 'default' or 'value' keys like other inputs would. This corrects an unintentional inconsistency in the methods. Test cases added. Fixes #988 2010-08-09 23:49:18 -04:00
mark_story
29ddffa2d3 Fixing regression in DboMysqlBase where describe() was no longer pulling out fieldParameters. A test case has been added to catch any future regressions. Fixes #991 2010-08-09 23:25:32 -04:00
mark_story
ccfb1d179a Expanding test and fixing issue where the return of Folder::create() would be incorrect even though the directory was properly created. Fixes #996 2010-08-09 22:56:41 -04:00
mark_story
d6e3c318cd Merge branch '1.3' of github.com:cakephp/cakephp into 1.3 2010-08-04 23:59:17 -04:00
mark_story
a04fe5f81d Making Router::reverse() strip out additional framework internal parameters that are specific to requestAction. Refs #977 2010-08-04 23:35:49 -04:00
xbuzz
f2f2987743 Fixed 'convertEntities' to links in RSS. Fixes #959 2010-08-04 22:03:44 -03:00
Dirk Brünsicke
712ca6d5b5 Fixing bug in String::insert that produces unexpected results with
multiple keys that start with the same substring. Fixes #984

Signed-off-by: mark_story <mark@mark-story.com>
2010-08-03 22:38:45 -04:00
José Lorenzo Rodríguez
7e1426e743 Fixing doc block 2010-08-02 19:25:04 -04:30
José Lorenzo Rodríguez
e7c7008781 Changing behavior of RequestHandlerComponent::responseType(), it will return the current content type set int the response object
It will not return null as default as it did prior 2.0
2010-08-02 19:21:52 -04:30
José Lorenzo Rodríguez
1acbf15c00 Removing RequestHandlerComponent::_header() method 2010-08-02 19:17:43 -04:30
José Lorenzo Rodríguez
cb63cd171c Fixing typo 2010-08-02 19:12:58 -04:30
José Lorenzo Rodríguez
bbbb81e10a Adding CakeResponse::download() method 2010-08-02 19:10:38 -04:30
José Lorenzo Rodríguez
5fb320f31d Refactoring RequestHandler methods to use the response object 2010-08-02 19:10:01 -04:30
José Lorenzo Rodríguez
4fd032bc10 Refactoring RequestHandlerComponent::mapType() and added response object property to the component 2010-08-02 19:07:26 -04:30
José Lorenzo Rodríguez
040740c05d Changing the order for comparisson checking on some types, when looking for a mime type 2010-08-02 19:04:53 -04:30
Juan Basso
ae2fa908c5 Dont use private attributes as tables in CakeSchema. Fixes #7 2010-08-02 00:22:46 -03:00
mark_story
3099a15f17 Removing old check for view == 'Theme'. This allows Scaffold to work well with Themed controllers. Test case added. Fixes #255 2010-08-01 22:25:29 -04:00
José Lorenzo Rodríguez
87eb1ec697 Adding the ability to add custom content types to CakeResponse 2010-08-01 14:22:02 -04:30
José Lorenzo Rodríguez
077f71aaa1 Refactoring controller rendering to use the CakeResponse object 2010-08-01 01:38:45 -04:30
Juan Basso
7e7a2c57e2 Fixing changes made in commit 522446e to works with PHP 5.2-. Refs #974 2010-08-01 02:55:30 -03:00
José Lorenzo Rodríguez
0824348db1 Removing Controller::output property and refactoring methods to not use it. CakeResponse::body() should be used instead 2010-08-01 01:13:41 -04:30
José Lorenzo Rodríguez
f9c97383e9 Refactored Controller::disableCache() to use the CakeResponse object, method was also deprecated 2010-08-01 00:16:50 -04:30
José Lorenzo Rodríguez
60f504a470 Refactored Controller::header() to use the CakeResponse object, deprecated Controller::header() and Controller::httpCodes() 2010-08-01 00:13:00 -04:30
José Lorenzo Rodríguez
9d104fee73 Refactoring Controller::redirect() to use the CakeResponse object 2010-08-01 00:10:46 -04:30
José Lorenzo Rodríguez
3ab4e09e11 Moving Controller::httpCodes() to CakeResponse 2010-08-01 00:09:09 -04:30
José Lorenzo Rodríguez
abafdb037b Implementing the CakeResponse::compress() method 2010-07-31 19:30:25 -04:30
José Lorenzo Rodríguez
8780f0b33d Implementing CakeResponse::cache() 2010-07-31 18:31:50 -04:30
José Lorenzo Rodríguez
5ba0e43aa3 Implementing CakeResponse::disableCache() 2010-07-31 17:40:49 -04:30
José Lorenzo Rodríguez
20d1e483cc Implementing and tesing CakeResponse::send() 2010-07-31 16:58:13 -04:30
José Lorenzo Rodríguez
d1808db0df Changing the encoding method for "charset" 2010-07-31 14:40:58 -04:30
José Lorenzo Rodríguez
2a4b30dba9 Implementing CakeResponse::header() method 2010-07-31 14:13:21 -04:30
mark_story
509a9e14e2 Fixing condition missing a model name in the TreeBehavior. Fixes #961 2010-07-31 14:29:00 -04:00
José Lorenzo Rodríguez
a2eac24ec0 Removing second parameter from CakeResponse, the response should not be magical 2010-07-31 13:10:37 -04:30
José Lorenzo Rodríguez
159ac2038e Testing remaining implemented methods 2010-07-31 13:04:53 -04:30
mark_story
9f718de0b6 Reverting changes made in [60ab9800e2]. Restoring use of isset() and $_SESSION = null. Fixes #971 2010-07-31 13:09:40 -04:00
mark_story
522446e0c2 Fixing issues where route elements could not have '-' in the parameter name because of limitations in pcre named capturing subpatterns. Tests added. Fixes #974 2010-07-31 13:03:45 -04:00
José Lorenzo Rodríguez
2c7b21b977 Completinng mime types array 2010-07-31 12:33:39 -04:30
José Lorenzo Rodríguez
f432de830c Implementing some function in the response object, adding test case 2010-07-31 12:33:02 -04:30
mark_story
2b1efafe65 Applying optimization from 'michaelc' to reduce number of strtolower() calls in AclBehavior. Fixes #972 2010-07-29 22:04:22 -04:00
José Lorenzo Rodríguez Urdaneta
ffd7066fa4 Adding the CakeREquest object with initial function signatures and parameters 2010-07-29 00:54:16 -04:30
Juan Basso
527446a3d1 Changing the RequestHandler to use new Xml class. 2010-07-28 21:29:12 -03:00
Juan Basso
53f8353f92 Updating Set to use new Xml class. 2010-07-28 19:53:52 -03:00
Juan Basso
b862d68016 Support to namespaces in Xml::toArray. 2010-07-28 19:46:35 -03:00
Juan Basso
f4d5230dfa Fixing the read for toArray of content when have child or attribute in xml. 2010-07-28 18:53:36 -03:00
Juan Basso
8f1bdd5378 Change to RssHelper use Xml class instead XmlHelper. 2010-07-28 17:47:02 -03:00
ADmad
6527e9269a Fixing detection and automatic appending of extension '.js' to urls in call to HtmlHelper::script(). Closes #965 2010-07-29 02:11:00 +05:30
José Lorenzo Rodríguez Urdaneta
69ee014a60 Merge branch '2.0' into 2.0-session 2010-07-27 22:27:17 -04:30
José Lorenzo Rodríguez Urdaneta
1c8ad1d1cc Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2010-07-27 22:26:06 -04:30
José Lorenzo Rodríguez Urdaneta
4c71dd845e Merge remote branch 'origin/2.0' into 2.0-request
Conflicts:
	cake/libs/controller/components/auth.php
	cake/tests/cases/libs/controller/components/auth.test.php
2010-07-27 22:02:08 -04:30
mark_story
272b327dc3 Fixing issue where $error would be set to an array. 2010-07-27 22:27:44 -04:00
mark_story
19d8c9e6bb Removing a call to __setError() that isn't an error. 2010-07-27 22:27:44 -04:00
mark_story
8db0a19585 Refactoring duplicated logic into a method. 2010-07-27 22:27:44 -04:00
mark_story
ef586d9917 Updating test case to use autoRegenerate. 2010-07-27 22:27:43 -04:00
mark_story
6ff7ad68c9 Fixing some infinite loop issues in the test cases for CakeSession. 2010-07-27 22:27:43 -04:00
mark_story
b3febb483e Fixing incorrect use of Cache::gc(). It has no parameters for now. 2010-07-27 22:27:43 -04:00
mark_story
81f6f43193 Moving a few things around to better replicate how CakeSession behaved in 1.3. Also fixes the countdown & session id regeneration feature. Still need to write a test case for it though. 2010-07-27 22:27:43 -04:00
mark_story
d2097c514f Fixing issue where infinite loops would occur when a session was first created. 2010-07-27 22:27:43 -04:00
mark_story
977ffa96be Removing dead properties and methods from SessionComponent.
Sessions should be started as soon as the component is constructed. So there is no reason to have an active()/activate() method.
2010-07-27 22:27:43 -04:00
mark_story
574bfe6b67 Changing clear of $_SESSION to null instead of array(), makes checks later easier. Removing _checkValid call from destroy and making it run in start(), as destroy() calls start(). 2010-07-27 22:27:43 -04:00
mark_story
db5c44e386 Adding support + test cases for plugin and app/libs session handlers. 2010-07-27 22:27:42 -04:00
mark_story
18b6668a34 Moving tests from SessionComponent to CakeSession, as that is where the features actually are. Removing Security.level/Security::inactiveMins() calculations. 2010-07-27 22:27:42 -04:00
mark_story
28b9ed7264 Adding test cases for DatabaseSession and fixing a test case in CacheSession. 2010-07-27 22:27:13 -04:00
mark_story
951eeae817 Extracting handler location into a method.
Moving DatabaseSession and CacheSession into separate files.  Tests to come soon.
2010-07-27 22:27:13 -04:00
mark_story
49397c74af Making cache config used for cache session storage configurable. 2010-07-27 22:27:13 -04:00
mark_story
f5d81e53fc Refactoring Cache and Database session handlers into a separate class, and adding an interface for custom session handlers. Tests updated. 2010-07-27 22:27:13 -04:00
mark_story
a8b05c2fbc Adding a check for '' and failure. When trying to Cache '', FileEngine will return false. This shouldn't trigger an error inside Cache. 2010-07-27 22:27:12 -04:00
mark_story
339fa29502 Updating CakeSession test case and fixing a few issues in the default settings. 2010-07-27 22:27:12 -04:00
mark_story
b247559e9e Starting to implement new session configuration setup. Test case updated. 2010-07-27 22:27:12 -04:00
predominant
7501fcf46d Add test for empty read() calls on CakeSession 2010-07-27 22:27:12 -04:00
predominant
ca65689dd9 Change _setHost() on CakeSession to accept parameter to ease testing, add test cases for host setting, and port stripping. 2010-07-27 22:27:12 -04:00
predominant
a63474a54d Add test for path containing question, and fix assignment of CakeSession::path 2010-07-27 22:27:12 -04:00
predominant
f5565895e9 Removing __regenerateId method, and moving code to renew(). 2010-07-27 22:27:11 -04:00
predominant
afede663c0 Reducing redundant code for CakeSession. 2010-07-27 22:27:11 -04:00
predominant
725bfc3e12 Create _setPath() and _setHost to simplify startup. 2010-07-27 22:27:11 -04:00
mark_story
4b65ebd64f Making SessionComponent mostly a wrapper for CakeSession.
Adding CakeSession::begin() to replace SessionComponent::__start().
Tests updated.  Tests related to autoStart were removed/skipped as that feature isn't really around right now.
2010-07-27 22:27:11 -04:00
mark_story
e660416545 Making CakeSession::write() able to write hashes of data. 2010-07-27 22:26:03 -04:00
predominant
4e9d76e806 Fixing session write use issue. 2010-07-27 22:26:03 -04:00
predominant
dd3e0facd2 Trim down CakeSession::started() 2010-07-27 22:26:03 -04:00
predominant
db97df31cd Adding static to regen 2010-07-27 22:26:03 -04:00
predominant
1dd02b77b2 Adding static to destroy() 2010-07-27 22:26:03 -04:00
mark_story
f47ee0d29a Making CakeSession destory() make started() not return true. Fixing tests that tried to modify session config while a session was active. 2010-07-27 22:26:03 -04:00
mark_story
daab018777 Removing code for PHP < 5.1 which is not supported by 2.0 2010-07-27 22:26:03 -04:00
mark_story
1938e57cbc Making userAgent check test pass.
Reformatting code inside valid().
2010-07-27 22:26:02 -04:00
predominant
b60b077056 Fix __startSession being called after method rename to _startSession. 2010-07-27 22:26:02 -04:00
predominant
34a6808d5d Move CakeSession database configuration to separate method, cutting down init(). 2010-07-27 22:26:02 -04:00
predominant
632d1f13ae Minor refactor for CakeSession. 2010-07-27 22:26:02 -04:00
predominant
9bddd9a861 Minor refactor of if()'s 2010-07-27 22:26:02 -04:00
predominant
06f9d748e2 Fix session path/base for init() 2010-07-27 22:25:37 -04:00
predominant
16f4899821 Fix destroy() calling old constructor on CakeSession 2010-07-27 22:25:37 -04:00
predominant
ea7d45cb11 Remove unset() 2010-07-27 22:25:37 -04:00
predominant
b0e4a09d38 Rename constructor to init() and add init() call at bottom of CakeSession. 2010-07-27 22:25:37 -04:00
predominant
86a7263ab5 Fix cookielifetime variable declaration for CakeSession. 2010-07-27 22:25:37 -04:00
predominant
913d54caa0 Remove __start from SessionHelper 2010-07-27 22:25:37 -04:00
predominant
04b67e59fc Fix tests to remove checking of session ID directly on Session Helper. 2010-07-27 22:25:37 -04:00
predominant
17688a6002 Chaned CakeSessn o use static approache. 2010-07-27 22:25:37 -04:00
predominant
0a72de6438 Removing @access doc block lines from CakeSession. 2010-07-27 22:25:05 -04:00
predominant
58c94b8578 Add access to started() on CakeSession. 2010-07-27 22:25:05 -04:00
predominant
c8c677ae9e Change SessionHelper to extend AppHelper instead of CakeSession. 2010-07-27 22:25:05 -04:00
predominant
390274f807 Remove function exists check on session_write_close() 2010-07-27 22:25:05 -04:00
mark_story
d81d33ffe6 Adding some additional documentation for Model::find(). Fixes #952 2010-07-27 21:25:31 -04:00
Juan Basso
df12e5b4ab Removing @static and @access from Xml class. 2010-07-26 23:44:31 -03:00
Juan Basso
5de7fa5930 Adding PHP Doc to XML class. 2010-07-26 23:42:05 -03:00
Juan Basso
43d49095ae Removing xml helper. Use SimpleXML instead. 2010-07-26 21:39:45 -03:00
Juan Basso
294bef6c46 Refactory of Xml class. Now uses SimpleXMLElement to manipulate XML data. 2010-07-26 21:31:39 -03:00
mark_story
d38857095a Merge branch '1.3' into 2.0
Conflicts:
	cake/libs/model/model.php
	cake/libs/validation.php
	cake/libs/view/helpers/ajax.php
	cake/tests/cases/libs/controller/components/session.test.php
2010-07-24 22:34:42 -04:00
José Lorenzo Rodríguez Urdaneta
e47a464d63 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2010-07-24 15:22:12 -04:30
José Lorenzo Rodríguez Urdaneta
1cfcec9a1a Removin use of File class in favor of SplFileObject 2010-07-24 15:21:14 -04:30
ADmad
91b0a4ba4f Changing Tree behavior's function names to be camel cased as per convention 2010-07-24 23:32:49 +05:30
mark_story
43127caad2 Making Cache::write() trigger warnings when a cache engine returns false from a write. Tests added. Fixes #877 2010-07-23 21:40:57 -04:00
José Lorenzo Rodríguez Urdaneta
88ea68af96 Using keyword self instead of Configure, removing use of File class in favor of SplFileObject 2010-07-23 18:42:30 -04:30
Juan Basso
5b7b2d074e Putting the port in header Host, following RFC 2616 item 14.23. Fixes #947. 2010-07-23 00:13:19 -03:00
mark_story
572f79be67 Fixing failing tests caused by strtolower() in AuthComponent. 2010-07-20 23:44:25 -04:00
mark_story
f6c7be9d22 Adding omitted import for Multibyte to i18n. Fixes #929 2010-07-19 23:18:42 -04:00
Scott Reeves
f44911f6dc Fixing typo in parameter description.
Signed-off-by: mark_story <mark@mark-story.com>
2010-07-19 23:15:20 -04:00
Scott Reeves
ba9fc94977 Fix typo in variable description.
Signed-off-by: mark_story <mark@mark-story.com>
2010-07-19 23:15:12 -04:00
Scott Reeves
b717abe1aa Fixing typo in Constructor description.
Signed-off-by: mark_story <mark@mark-story.com>
2010-07-19 23:15:00 -04:00
Scott Reeves
ba59c93187 Fixing typo in method description.
Signed-off-by: mark_story <mark@mark-story.com>
2010-07-19 23:14:51 -04:00
Scott Reeves
037a7628c4 Fixing typo in parameter description.
Signed-off-by: mark_story <mark@mark-story.com>
2010-07-19 23:14:43 -04:00
Scott Reeves
742bb29118 Fixing typo in variable description for logoutRedirect.
Signed-off-by: mark_story <mark@mark-story.com>
2010-07-19 23:14:06 -04:00
mark_story
f01b4ae13b Updating version numbers to 1.3.3 2010-07-18 23:00:24 -04:00
mark_story
41997b06e1 Fixing issues where mb_internal_encoding() might not be correctly set, causing email subjects to be incorrectly encoded. Tests added. Fixes #904 2010-07-18 20:48:15 -04:00
José Lorenzo Rodríguez Urdaneta
bc27d1eae4 Returning only booleans in Model::__isset() and removing return by reference in Model::getDataSource() 2010-07-15 23:17:13 -04:30
José Lorenzo Rodríguez Urdaneta
b8b4647355 Removing use of cakeError in Model and replacing it with an Exception 2010-07-15 23:11:30 -04:30
mark_story
4c27c24a72 Fixing issue in DboSource where COUNT() was hardcoded, omitting any other aggregate functions. Replaced with a regexp that accepts only letters. Test case added. Fixes #878 2010-07-15 23:17:38 -04:00
José Lorenzo Rodríguez Urdaneta
6fb930c73b Removing assignments by reference in model class 2010-07-15 22:16:19 -04:30
Ceeram
32ea6d24cf Moving Component::beforeRender triggering to allow components to modify
the view class to use for the render() call.  Fixes #917

Signed-off-by: mark_story <mark@mark-story.com>
2010-07-15 21:54:18 -04:00
José Lorenzo Rodríguez Urdaneta
a57e5e8c68 Replacing direct reads to schema cache and routing them to the correct method 2010-07-15 21:19:23 -04:30
José Lorenzo Rodríguez Urdaneta
5d1e6f9e4f Fixing errors with displayField 2010-07-15 21:18:16 -04:30
José Lorenzo Rodríguez Urdaneta
a13be623b5 Making the model require database connection only wen needed or requested 2010-07-15 21:16:52 -04:30
José Lorenzo Rodríguez Urdaneta
e165f7d559 Changing how dynamic "with" models are loaded
Changing all calls to get model's datasourse to use Model::getDatasource()
2010-07-14 23:19:38 -04:30
mark_story
21f359bff9 Removing additional call to camelize(). Fixes #913 2010-07-14 22:07:41 -04:00
Scott Reeves
15435e9d6f FormHelper::create should use domId to determine the default ID of the form tag.
Signed-off-by: mark_story <mark@mark-story.com>
2010-07-14 21:59:16 -04:00
José Lorenzo Rodríguez Urdaneta
c1a9a2e263 Correctly registering plugin models in CR, initial test case onmodel associations lazy loading 2010-07-14 19:23:41 -04:30
José Lorenzo Rodríguez Urdaneta
96f834a7ea Various bugfixes in model associations lazy loafing for "with" associations 2010-07-14 17:54:19 -04:30
José Lorenzo Rodríguez Urdaneta
fdf91194a6 Initial approach for model associations lazy loading, all model tests passing 2010-07-14 16:58:12 -04:30
José Lorenzo Rodríguez Urdaneta
91c3cd8905 Refactoring Model::__createLinks to not loose the plugin name when creating the association 2010-07-13 23:28:48 -04:30
José Lorenzo Rodríguez Urdaneta
4759b7adac Merge branch '2.0-phpunit' into 2.0 2010-07-13 22:29:43 -04:30
mark_story
c9079c8048 Removing magical un-removable plugin concatenation in Controller::loadModel(). Adding test case from 'real34'. Fixes #858 2010-07-13 20:19:31 -04:00
Thomas Ploch
fb9faf10f7 Added missing option arrays to abstract function definitions in JsBaseEngineHelper. Fixed test cases accordingly. Fixes #704 . 2010-07-13 20:04:11 -04:00
mark_story
5c076d44db Adding import to Helper so its tests run in CLI. 2010-07-11 20:01:24 -04:00
mark_story
6d8724097e Changing check in AjaxHelper::link() so lazy users don't get type errors. Fixes #902 2010-07-11 13:47:40 -04:00
mark_story
65efd675c1 Fixing fatal error caused by associated models using a datasource that is not a subclass of dbo_source. Test added. Fixes #873 2010-07-11 13:06:33 -04:00
mark_story
eda79aefb2 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2010-07-10 18:39:55 -04:00
Juan Basso
9fe5f360eb Adding a default value to options param in JsEngine effect to avoid error in some php versions. 2010-07-10 18:15:09 -03:00
mark_story
5d2c48fd9c Fixing failing tests caused by strtolower() in AuthComponent. 2010-07-10 12:00:09 -04:00
mark_story
413b875eef Merge branch '2.0' into 2.0-request
Conflicts:
	cake/libs/controller/controller.php
2010-07-10 11:49:58 -04:00
mark_story
5c4d46abda Removing reference operators. 2010-07-10 11:45:10 -04:00
mark_story
a04c87c42a Adding App::init() to bootstrap App now that its static. 2010-07-10 11:40:06 -04:00
mark_story
d28f7f4144 Fixing failing test. 2010-07-10 11:32:12 -04:00
mark_story
f202f89974 Initial port of App to a static class, one test is failing. 2010-07-10 00:48:45 -04:00
mark_story
0e2a313145 Removing reference operators from controller.
Removing cakeDebug as its no longer used.
2010-07-10 00:32:35 -04:00
mark_story
3ae1501fd0 Removing more strtolower loops. 2010-07-09 23:58:48 -04:00
mark_story
b7310afddf Removing strtolower() loops on method names, as casing is preserved in php5. 2010-07-09 23:49:48 -04:00
Juan Basso
7dae4a7fd8 Avoiding error to unlink files in Windows. Fixed lock in file cache. 2010-07-07 23:36:13 -03:00
mark_story
103346155f Fixing HttpSocket losing auth credentials when multiple requests are made with the same object. Fixes #893 2010-07-06 22:30:48 -04:00
mark_story
cbccd16c46 Adding visibility and static keywords to connection manager. 2010-07-05 23:08:25 -04:00
mark_story
5d8e27d97b Removing @access and @static where they are not needed anymore. 2010-07-05 22:57:23 -04:00
mark_story
fdafa6b3bd Adding visibility and static keywords to ClassRegistry. 2010-07-05 22:44:20 -04:00
mark_story
a0647e5a8f Making static methods static. 2010-07-05 22:39:09 -04:00
mark_story
a2c1ca92b4 Converting Multibyte class to use static methods and properties. 2010-07-05 22:35:13 -04:00
mark_story
b8085cddce Removing PHP5 and all its uses. 2010-07-05 22:19:22 -04:00
mark_story
4a32a39c22 Updating doc blocks. 2010-07-05 21:57:39 -04:00
mark_story
02e25f7557 Changing Configure::read() to not have a default value, and instead return all values in configure when no param is supplied. Test cases updated. Fixes #503 2010-07-05 21:50:36 -04:00
mark_story
2fee0b5b63 Updating console bootstrap process. 2010-07-04 22:03:25 -04:00
mark_story
b2351ef3c9 Updating Configure to be a fully static class. 2010-07-04 22:00:49 -04:00
mark_story
90b2123656 Updating Inflector to use static methods and properties.
Reducing the number of cache properties to one.
Deleting PHP4 specific tests.
2010-07-04 21:46:48 -04:00
mark_story
60ab9800e2 Fixes issue where CakeSession::destroy() would fail to properly restart the session. Tests added. Fixes #787 2010-07-03 18:34:02 -04:00
mark_story
4cd43553b4 Fixing issues where multiple reset bindModel() calls would cause incorrect associations to be restored.
Also fixing issues where multiple calls to unbindModel() would cause incorrect associations to be restored.
Tests added.
Fixes #889
2010-07-03 18:05:14 -04:00
mark_story
57e59ecca4 Merge branch '2.0' into 2.0-request 2010-07-01 18:21:44 -04:00
mark_story
62e16c7058 Fixing issues where permissions would not be set to world writable on file caches. 2010-07-01 18:18:12 -04:00
mark_story
17a7a96ba2 Fixing issue where non-reset associations would get reset by resetAssociations if __backAssociations existed. Test cases from 'real34' added. Fixes #868 2010-07-01 12:39:50 -04:00
mark_story
a8e5e587c6 Making RequestHandler able to use the accept header to detect and switch layout/view paths. Fixes #729 2010-07-01 12:01:46 -04:00
mark_story
81d03857d7 Updating doc block and exception in CakeRequest. 2010-07-01 12:00:53 -04:00
mark_story
a7a4285a80 Renaming __requestContent to _contentTypeMap 2010-07-01 00:50:53 -04:00
mark_story
427e859b52 Refactoring how prefers() works. Tests updated.
Removing support for array args in setContent().
2010-07-01 00:46:28 -04:00
mark_story
ba287ec99e Updating accepts() and doing some refactoring. 2010-07-01 00:26:15 -04:00
mark_story
8d32ad2821 Starting to update RequestHandler methods to use CakeRequest. RequestHandler will provide alias/mapped access to features in CakeRequest. Tests updated and expanded. 2010-07-01 00:13:13 -04:00
mark_story
6e516cae73 Expanding doc blocks for CakeRequest. 2010-07-01 00:12:28 -04:00
mark_story
ea0f9cffea Moving accepts() into CakeRequest.
Adding test cases.
2010-06-30 23:25:45 -04:00
mark_story
8b847cffef Merge branch '2.0' into 2.0-request
Conflicts:
	cake/libs/view/helper.php
	cake/tests/cases/libs/controller/components/request_handler.test.php
2010-06-30 22:54:28 -04:00
mark_story
ef6e01f21f Making themePath work with E_STRICT. 2010-06-30 22:48:30 -04:00
mark_story
2020675078 Merge branch '1.3' into 2.0
Conflicts:
	cake/dispatcher.php
	cake/tests/cases/libs/controller/components/request_handler.test.php
2010-06-30 22:47:27 -04:00
mark_story
991d035806 Fixing respondAs() so it can be called multiple times. Test cases added for respondAs. Fixes #842 2010-06-30 22:34:33 -04:00
mark_story
dc72529648 Implementing assettimestamps for themes and plugins. Tests added. Fixes #804, #879 2010-06-30 20:47:54 -04:00
mark_story
91f8e220e4 Adding App::themePath(). Will be used to reduce code duplication in a variety of places. 2010-06-30 20:17:17 -04:00
mark_story
e023350af5 Updating API docs related to DboSource::$cacheMethods. Fixes #870 2010-06-30 08:52:39 -04:00
mark_story
735ac17b85 Updating documentation on App::objects() so it more reflects what the method does. Fixes #874 2010-06-30 08:45:06 -04:00
mark_story
dedc85390c Adding header() to get header/server vars.
Adding OPTIONS to the detector list.
2010-06-29 00:24:29 -04:00
mark_story
ea322b8f78 Fixing issue where getCrumbList() was overwriting attributes. 2010-06-28 23:45:36 -04:00
mark_story
7c0cda7ce5 Merge branch '2.0' into 2.0-request
Conflicts:
	cake/libs/router.php
	cake/tests/cases/dispatcher.test.php
	cake/tests/cases/libs/controller/components/auth.test.php
	cake/tests/cases/libs/controller/components/request_handler.test.php
	cake/tests/cases/libs/controller/controller.test.php
	cake/tests/cases/libs/router.test.php
	cake/tests/cases/libs/view/helpers/html.test.php
	cake/tests/cases/libs/view/helpers/js.test.php
2010-06-28 23:41:48 -04:00
mark_story
1c47702cb9 Updating formatting to match coding standards. 2010-06-28 22:53:33 -04:00
Leszek Stachowski
68a9c9c5ab Added HtmlHelper::getCrumbList() to generate semantically correct
(x)html breadcrumb navigation path and a test to it. Fixes #856

Signed-off-by: mark_story <mark@mark-story.com>
2010-06-28 22:36:28 -04:00
mark_story
cd8dff362d Merge branch '2.0-phpunit' into 2.0
Conflicts:
	cake/libs/controller/components/email.php
	cake/tests/cases/libs/cake_test_fixture.test.php
	cake/tests/cases/libs/controller/components/email.test.php
2010-06-28 22:31:35 -04:00
mark_story
94965f0f6c Adding an additional test for View::entity().
Fixing issue where nulls would be shifted onto the entity array causing incorrect name attributes.  Fixes #867
2010-06-28 21:38:17 -04:00
mark_story
ecf7811b7a Merge branch '2.0' into 2.0-request
Conflicts:
	cake/dispatcher.php
	cake/libs/controller/components/request_handler.php
	cake/libs/view/helpers/form.php
	cake/tests/cases/libs/controller/components/request_handler.test.php
	cake/tests/cases/libs/controller/controller.test.php
	cake/tests/cases/libs/view/helpers/js.test.php
	cake/tests/cases/libs/view/helpers/paginator.test.php
2010-06-27 23:21:11 -04:00
mark_story
4b93e61ed3 Adding cookieLifeTime var declaration as it was omitted.
Updating session timeout values so they reflect their values in the past.
Making cookieLifeTime configurable in the medium/low security levels.
Fixing Config.timeout setting to go back to 10.
Fixes #798
2010-06-27 12:52:18 -04:00
mark_story
c119ec4d23 Merging in changes from Voidet to correct session times. Minutes were
being used instead of seconds, for a value that expected seconds.

Conflicts:
	cake/libs/cake_session.php
	cake/tests/cases/libs/controller/components/session.test.php
2010-06-27 12:17:37 -04:00
mark_story
b9383f13dc Adding some additional documentation for FormHelper::inputs(). 2010-06-27 00:39:31 -04:00
mark_story
929bb5769e Merge branch '1.3' into 2.0
Conflicts:
	app/webroot/index.php
	cake/console/templates/skel/webroot/index.php
	cake/libs/cake_session.php
	cake/libs/controller/components/email.php
	cake/libs/controller/scaffold.php
	cake/libs/model/datasources/dbo/dbo_oracle.php
	cake/libs/model/model_behavior.php
	cake/libs/view/pages/home.ctp
	cake/tests/cases/libs/controller/components/acl.test.php
	cake/tests/cases/libs/file.test.php
2010-06-26 12:29:20 -04:00
José Lorenzo Rodríguez Urdaneta
4689be643b Migrating EmailTest to phpunit 2010-06-25 00:02:20 -04:30
predominant
83651091ce Refactor session timeouts. 2010-06-24 10:30:12 +10:00
Juan Basso
9bbaf153f7 Setting cookies in a single line. Fixes #48 2010-06-23 00:10:21 -03:00
mark_story
5945edd983 Removing strtolower call that was breaking autolinks for URL shorteners. Tests added. Fixes #838 2010-06-21 21:17:37 -04:00
Juan Basso
26d20b6d62 Fixing wrap for html mode in e-mails. Fixes #663 2010-06-21 00:37:25 -03:00
Juan Basso
2a4489cdf2 Naming conventions to datasources with plugins. Fixes #819 2010-06-20 23:53:54 -03:00
Thomas Ploch
2d20215e53 Converted JsBaseEngineHelper to an abstract class. Fixes #703 .
Signed-off-by: mark_story <mark@mark-story.com>
2010-06-20 22:21:21 -04:00
mark_story
0c8088c77d Fixing parse error. 2010-06-20 22:17:47 -04:00
mark_story
2db510d1c1 Modifying Controller::validateErrors so it can accept and validate arbitrary model objects, not just those attached to the controller. Test cases updated, fixes #832 2010-06-20 21:47:34 -04:00
mark_story
50144d6b5b Making FormHelper clear fields on create() as well as end() this ensures that GET forms don't leak fields. Fixes #571 2010-06-12 22:50:09 -04:00
mark_story
d1651db9a8 Fixing typo in Scaffold that caused error messages to display incorrectly. Fixes #813 2010-06-11 10:01:02 -04:00
mark_story
df3432aa86 Updating doc blocks in ModelBehavior. Refs #810 2010-06-11 09:55:39 -04:00
José Lorenzo Rodríguez Urdaneta
0f33560515 Migrating Xcache test to phpunit 2010-06-10 23:11:29 -04:30
mark_story
f0d755bd8e Adding additional tests for Helper::_parseAttributes() and fixing issue where '1' would not be interpreted as a truthy value for compact attributes. Fixes #806 2010-06-10 19:11:26 -04:00
mark_story
e5df32e9d9 Adding omitted documentation information. 2010-06-10 14:23:49 -04:00
mark_story
ec5ad93a68 Updating doc blocks for ModelBehavior so they better reflect the actual behaviour of the methods.
Removing unused variable assignment.
Fixes #810
2010-06-10 13:54:04 -04:00
José Lorenzo Rodríguez
fa8df12fa0 Converting AuthTest to phpunit. Adding setter and getter method loggedIn() 2010-06-10 00:03:49 -04:30
José Lorenzo Rodríguez
f4cf945e30 Migrating DboSqliteTest to phpunit 2010-06-09 23:33:41 -04:30
José Lorenzo Rodríguez
bc71e14041 Merge branch '2.0-phpunit' of github.com:cakephp/cakephp into 2.0-phpunit
Conflicts:
	cake/tests/cases/libs/controller/components/session.test.php
2010-06-09 21:01:56 -04:30
Juan Basso
d5ddd8ee5f Fixing check of EHLO/HELO in EmailComponent. Fixes #794 2010-06-09 19:22:06 -03:00
mark_story
2c6bf51bd2 Converting SessionComponent over to PHPUnit.
Adding a few getter/setter methods to fix visibility issues in the test cases.
2010-06-09 17:15:34 -04:00
mark_story
ad8b70cec2 Removing continue statement that did nothing.
Adding a rollback for when validation fails and atomic has been set.
Tests added. Fixes #797
2010-06-09 13:48:54 -04:00
José Lorenzo Rodríguez
fa1ae280ca Migrating SessionComponentTest to PHPUnit and adding public accessor method for varible in SessionComponent 2010-06-09 09:30:00 -04:30
mark_story
c5e4ab2366 Adding return to RequestHandlerComponent::accepts() as it was missing.
Updating RequestHandlerComponent tests to work with PHPUnit.
2010-06-09 00:02:49 -04:00
mark_story
a88b8dd5b9 Making requestAction() calls that requesthandler creates not remove autoLayout. This fixes issues where ajax layout files would not be rendered.
Tests added.  Fixes #722
2010-06-07 23:43:35 -04:00
Kyle Robinson Young
a9fa7ac240 Fix for auth component userModel with plugins. Fixes #799 2010-06-07 23:19:13 -04:00
José Lorenzo Rodríguez
bd7ce3804e Migrating CakeSchemaTest to PHPUnit 2010-06-07 00:05:40 -04:30
predominant
0eea0ce0f8 Updating version numbers to 1.3.2 2010-06-07 02:21:51 +10:00
José Lorenzo Rodríguez
fd4db4184a Migrated ConnectionManager to phpunit 2010-06-04 23:47:38 -04:30
José Lorenzo Rodríguez
c23fe5d72e Migrating ModelReadTest to PHPUnit 2010-06-04 23:07:29 -04:30
mark_story
e41e89cd2a Making magic select not override magic hidden. Tests added.
Fixes #782
2010-06-04 00:20:14 -04:00
mark_story
bd6e16be26 Fixing issue where join tables would be filed under 'missing' and found. Test added. Fixes #789 2010-06-03 23:20:37 -04:00
Juan Basso
3c27c4c41e Ajusting smtpOption in EmailComponent. Fixes #779 2010-06-03 14:46:20 -03:00
Juan Basso
b480d80c82 Avoid undefined index if not define timeout in EmailComponent. Fixes #779 2010-06-02 18:14:58 -03:00
mark_story
7682c5896e Changing how merged rules are cleared so it doesn't generated notice errors in PHP4. Test added. Fixes #762 2010-06-01 23:41:51 -04:00
José Lorenzo Rodríguez
7d6ac7585a Migrating ModelValidationTest to phpunit 2010-06-01 00:19:11 -04:30
mark_story
02a04abf6b Fixing return values of methods, and updating tests to run properly in Phpunit which uses exceptions instead of errors. 2010-05-30 22:57:28 -04:00
mark_story
ea2f0327f5 Reverting change made in [7cde309]. Readding trim() to fix issues on windows. Updating tests so they continue to pass on macos. Fixes #769 2010-05-30 22:46:46 -04:00
mark_story
713e6e6287 Fixing parse error that caused scaffold test to not run and not pass. 2010-05-30 22:41:52 -04:00
Juan Basso
74dad04323 Fixing read from SMTP by EmailComponent. Closes #772 2010-05-30 23:29:21 -03:00
mark_story
fc79dc6232 Merge branch '2.0' into 2.0-phpunit
Conflicts:
	cake/tests/cases/console/libs/tasks/controller.test.php
	cake/tests/cases/libs/code_coverage_manager.test.php
	cake/tests/cases/libs/view/helpers/js.test.php
	cake/tests/lib/code_coverage_manager.php
2010-05-30 22:13:09 -04:00
mark_story
7ed67e5959 Fixing virtualFields used in order clauses where virtualField was supplied with model alias. Tests added. Refs #768 2010-05-30 20:30:58 -04:00
mark_story
07948a733d Reverting change made in [7cde309]. Readding trim() to fix issues on windows. Updating tests so they continue to pass on macos. Fixes #769 2010-05-30 11:16:40 -04:00
mark_story
0180daaad3 Updating version numbers to 1.3.1 2010-05-29 13:26:34 -04:00
mark_story
dea33f6452 Fixing pass by reference errors in php5.3. Fixes #451 2010-05-29 13:19:12 -04:00
mark_story
7cde3094f0 Removing trim() that was performed when reading a file with a lock() enabled. This was causing a failure in php5. 2010-05-29 12:50:42 -04:00
renan.saddam
c96d074722 Merge branch '1.3' of github.com:cakephp/cakephp into 1.3 2010-05-29 12:23:04 -03:00
renan.saddam
8f5112b8d7 Changing break; to continue; so it will process the next tables on the array, tests added. 2010-05-29 12:22:16 -03:00
predominant
8decc683ac Numerous 'shoer description' documentation entries updated to contain useful comments. 2010-05-30 01:20:28 +10:00
predominant
f63f15812e Merge remote branch 'origin/1.3' into 1.3 2010-05-30 01:13:40 +10:00
predominant
f06f0dae8b Numerous "Enter description here" block comments updated to have meaningful descriptions. 2010-05-30 01:10:48 +10:00
Juan Basso
e02cb81a67 Reading a smtp response until EOL. Fixes #378 2010-05-29 12:04:29 -03:00
mark_story
7e6773c60c Updating ErrorHandler and CakeErrorController to use CakeRequest. Tests updated. 2010-05-29 00:21:02 -04:00
mark_story
3e3265aa7c Adding omitted echo. 2010-05-29 00:20:16 -04:00
mark_story
f4abc51062 Removing dependency on RequestHandler from Security component. 2010-05-29 00:01:11 -04:00
mark_story
8acb82f567 Updating Security component to use CakeRequest and updating its test case. 2010-05-28 23:57:43 -04:00
mark_story
8b6c974cd0 Making FileEngine not greedily clear files in a directory that may belong to another cache configuration. Tests added. Fixes #754 2010-05-27 00:01:17 -04:00
mark_story
cd255d5031 Merge branch '1.3' of github.com:cakephp/cakephp into 1.3 2010-05-25 23:08:06 -04:00
Martin Radosta
64adfacd3e Making DboSource::order() accept an expression object. Fixes issues with
sql parsing over quoting special SQL syntax. Tests added.  Fixes #747

Signed-off-by: mark_story <mark@mark-story.com>
2010-05-25 23:07:29 -04:00
Juan Basso
bc3e745673 Support to EHLO in SMTP server for EmailComponent. Fixes #54, #712, #737 2010-05-24 22:24:58 -03:00
Juan Basso
2d44929598 Optimization on dbo datasource to not repeat ids in find. Fixes #601
Signed-off-by: mark_story <mark@mark-story.com>
2010-05-23 17:22:55 -04:00
mark_story
b73870c33d Removing reference operators in the AclComponent. 2010-05-22 20:20:41 -04:00
ADmad
7d51952801 Removing protected var CakeSession::_started and instead session_id() is now used to check if session is started in CakeSession::started(). This fixes issue where CakeSession::started() returned incorrect value when used across multiple objects. Closes #731 2010-05-23 02:14:07 +05:30
tarcisio
06c1b583f8 fix typo in CakeLog::config()
Signed-off-by: mark_story <mark@mark-story.com>
2010-05-22 10:49:37 -04:00
mark_story
29f2223c6d Removing hardcoded '__' for virtualField separators. Making it an instance property instead. This allows the customization of the separator if needed. Tests added for DboMysql. Refs #655, #730 2010-05-22 00:58:54 -04:00
mark_story
23d4bafd39 Fixing inflection of words ending in causes. Fixes #736 2010-05-21 23:49:49 -04:00
mark_story
82250efc3e Updating doc blocks for FormHelper::input() refs #735 2010-05-20 22:58:20 -04:00
mark_story
94ac914426 Changing Router::$__validExtensions so Router::extensions() always returns an array like the doc block says.
Updating test cases for PHPUnit.
2010-05-20 22:55:25 -04:00
mark_story
7cef278ce2 Fixing missing boolean return in Validation::cc()
Fixing Validation test case to pass under PHPUnit.
2010-05-20 22:30:47 -04:00
predominant
6a18b2bc1d Merge remote branch 'origin/1.3' into 2.0
Conflicts:
	cake/basics.php
	cake/console/libs/shell.php
	cake/console/libs/tasks/controller.php
	cake/libs/controller/components/request_handler.php
	cake/libs/model/model.php
	cake/libs/model/model_behavior.php
	cake/libs/overloadable.php
	cake/libs/overloadable_php4.php
	cake/libs/overloadable_php5.php
	cake/libs/sanitize.php
	cake/libs/validation.php
	cake/libs/view/helpers/ajax.php
	cake/libs/view/helpers/javascript.php
	cake/libs/view/pages/home.ctp
	cake/tests/cases/console/libs/tasks/controller.test.php
	cake/tests/cases/libs/overloadable.test.php
	cake/tests/cases/libs/validation.test.php
	cake/tests/cases/libs/view/helpers/ajax.test.php
	cake/tests/cases/libs/view/helpers/javascript.test.php
	cake/tests/test_app/libs/cache/test_app_cache.php
	cake/tests/test_app/plugins/test_plugin/libs/cache/test_plugin_cache.php
	cake/tests/test_app/plugins/test_plugin/models/test_plugin_auth_user.php
	cake/tests/test_app/plugins/test_plugin/models/test_plugin_post.php
2010-05-20 12:22:04 +10:00
predominant
3a81a9e6f2 Remove unnecessary spaces. 2010-05-20 12:17:52 +10:00
Robert Sworder
385ceb434e When using Digest Authentication the passwords do not need to be md5 hashed. Removed incorrect comment.
Fixes #733

Signed-off-by: mark_story <mark@mark-story.com>
2010-05-18 22:19:33 -04:00
Juan Basso
a94b9ee95b Update various links. Closes #392 2010-05-18 22:15:13 -03:00
mark_story
c1c800865c Refactoring repeated blocks of code into a method. 2010-05-17 23:51:41 -04:00
mark_story
f6edbfa6e4 Removing unused properties from Scaffold. 2010-05-17 23:44:11 -04:00
mark_story
76f94d5c75 Fixing form attribute access and broken test. 2010-05-17 23:31:47 -04:00
mark_story
ef85fb1247 Making scaffold methods protected instead of private.
Adding visibility keywords
2010-05-17 23:30:04 -04:00
mark_story
1d884cc00f Updating Scaffold to use the CakeRequest object.
Updating Scaffold tests.
2010-05-17 23:11:47 -04:00
mark_story
8b66a905b8 Fixing syntax error caused by bad merge. 2010-05-17 21:57:12 -04:00
mark_story
f114d4299d Merge branch '2.0' into 2.0-request
Conflicts:
	cake/libs/router.php
	cake/tests/cases/libs/router.test.php
2010-05-17 21:52:14 -04:00
mark_story
3a60aa07de Fixing issues where setting jQueryObject did not affect request() and its connected methods.
Tests added.
Fixes #728
2010-05-17 18:25:50 -04:00
mark_story
4915645fb1 Applying patch from 'Daren Thomas' fixes issues where sorting on virtualFields did not work properly when using aliased sort link keys. Tests added. Fixes #680 2010-05-16 23:42:14 -04:00
mark_story
b2d8536b3b Fixing Authcomponent tests. Updating the component + tests to use the new request object.
Deprecating a number of Authcomponent properties.
2010-05-15 00:55:15 -04:00
mark_story
36a71582fc Fixing issues with Controller::referer() and CakeRequest::referer(). Tests updated. 2010-05-15 00:53:15 -04:00
mark_story
4520ff7c82 Making View pass request onto helpers and extract it from a Controller. 2010-05-15 00:52:06 -04:00
mark_story
e6a743b163 Making JsHelper use its request object methods. 2010-05-15 00:51:26 -04:00
mark_story
0eebda9ee1 Updating HtmlHelper test to use request object.
Removing reference operators.
2010-05-14 23:11:38 -04:00
Mark Story
3983bf318d Updating PaginatorHelper and its test cases to use the request object. 2010-05-14 00:32:56 -04:00
Mark Story
c5dfd128fb Updating FormHelper and its tests to use the request object. 2010-05-14 00:21:22 -04:00
Mark Story
0d3011d2c3 Updating CacheHelper to use CakeRequest. 2010-05-14 00:12:29 -04:00
Mark Story
657073aa42 Marking a number of Helper properties as deprecated as they are contained within the CakeRequest object.
Adding a new property for the new request object.
Updating the internals of Helper to use the request object.
Updating the tests to use the request object.
2010-05-14 00:05:45 -04:00
Mark Story
353c600cd7 Removing unreachable code. Fixes #614 2010-05-13 23:38:26 -04:00
Mark Story
046c233a34 Adding Welsh to the supported lists of locales in l10n. Thanks to 'DanAbel' for the 'patch'. Fixes #714 2010-05-13 22:13:59 -04:00
José Lorenzo Rodríguez
8c3df122eb Merge commit 'lorenzo/2.0-phpunit' into 2.0-phpunit
Conflicts:
	cake/tests/lib/reporter/cake_html_reporter.php
	cake/tests/lib/test_manager.php
2010-05-12 23:58:56 -04:30
Mark Story
79839c07d2 Fixing issues where ModelBehavior::detach() would not detach behaviors when a plugin.name was provided. This change makes detach() work like attach(). Tests added. Fixes #711 2010-05-11 23:08:14 -04:00
Mark Story
6add43a4bc Fixing issue where id = null could cause SQL errors when saving more than one record with a null id. Fixes #675 2010-05-11 22:40:56 -04:00
ADmad
3539660cd0 Space is now properly added inbetween when 'asc'/'desc' class is appended to user defined css class in PaginatorHelper::sort. Fixes #710 2010-05-12 00:42:02 +05:30
Mark Story
6e355312bb Fixing issue where Config.timeout wouldn't correctly countdown when many quick requests were sent. 2010-05-11 00:39:10 -04:00
Richard Sbresny
b04a3f8514 Switched over to using the previously unused Security::inactiveMins() method for getting timeout modifiers
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:14:20 -04:00
Richard Sbresny
5cf08cbe92 Updated default values to reflect the static values previously set
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:12:15 -04:00
Richard Sbresny
c62ae5e48a Included timeout multiplier factor to be used not just inside a session start
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:11:44 -04:00
Richard Sbresny
a4950f6940 Updated session timeout calculations to use the security level from core.php as the multiplier.
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:11:20 -04:00
Robert Sworder
ec10a01504 Changing home.ctp to remove references to 1.2. Fixes #705
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-10 23:48:12 -04:00
predominant
8f880731c6 Removing closing PHP tags. 2010-05-11 08:27:28 +10:00
predominant
1ec220dac2 Removing closing PHP tags. 2010-05-11 08:07:49 +10:00
José Lorenzo Rodríguez
765de657e6 Fixing PaginatorHelperTest to be compatible with PHPUnit 2010-05-09 18:49:04 -04:30
Mark Story
4b637a0f70 Updating more methods to use request object method instead of deprecated methods. 2010-05-08 10:36:20 -04:00
Mark Story
5040eb7227 Updating RequestHandler and its tests to use the features moved to CakeRequest. Marking a number of methods as deprecated. 2010-05-08 00:59:40 -04:00
Mark Story
78bd7300a2 Moving features from RequestHandler into CakeRequest. 2010-05-08 00:36:03 -04:00
Mark Story
df910026ee Updating Controller::referer() to use the request object if available. Tests updated. 2010-05-08 00:06:13 -04:00
Mark Story
77264da34a Updating Controller tests to always pass in a CakeRequest. Fixing some notice errors that come up in the test cases. 2010-05-08 00:00:19 -04:00
Mark Story
22161874cb Deprecating a number of Controller properties and adding $request. 2010-05-07 23:46:02 -04:00
Mark Story
1a7dce3af6 Updating DboMysql to fix an issue where virtualFields that were simple
aliases to fields on other tables would end up in the wrong place.
Tests added.  Fixes #655
2010-05-07 23:26:13 -04:00
Mark Story
0930b5c63c Adding more documentation for JsHelper::submit(). Closes #681 2010-05-07 21:26:44 -04:00
Mark Story
26f7fcef3c Updating Controller and its tests to use CakeRequest. 2010-05-06 23:23:13 -04:00
Mark Story
2b7723fd12 Removing reference operators and making Controller::__construct take a CakeRequest. If one is passed all the necessary properties will be populated. This lightens the Dispatcher, and gives more control to the end developer. 2010-05-06 23:18:50 -04:00
Mark Story
1a460e47f1 Removing reference operators in Controller and its tests. 2010-05-06 22:48:48 -04:00
Mark Story
04df4a91dd Merge branch '2.0' into 2.0-request 2010-05-06 22:30:37 -04:00
Mark Story
1c3415759a Fixing 'Only variables should be assigned by reference' errors in php4 in form helper. Fixes #643 2010-05-06 22:11:31 -04:00
Mark Story
1c1c511853 Changing how email validation methods are applied, to fix issues where getmxrr() exists but the domain being validated does not have MX records correctly configured. Fixes #634 2010-05-06 21:43:58 -04:00
predominant
719836c41d Updated doc block for added HTTP Status. 2010-05-05 10:09:47 +10:00
Mark Story
e9a7d6d3b9 Splitting CakeRoute and PluginShortRoute into their own files. Also splitting out the test cases. 2010-05-04 00:35:22 -04:00
Mark Story
f76d320688 Making Router a fully static class. Tests updated. 2010-05-04 00:26:02 -04:00
Mark Story
c91d74a9af Making CakeRequest toss an exception when it can't handle a method call. 2010-05-03 23:41:13 -04:00
Mark Story
69275c8996 Adding a parameter to CakeRequest to allow it to skip parsing the environment. 2010-05-03 22:50:38 -04:00
Mark Story
ce10c85367 Making Sanitize::stripScripts() to remove multi-line script and style blocks. Fixes #657 2010-05-03 22:33:20 -04:00
Mark Story
95dbae8acf Making RequestHandler component carry along a passed status code. This fixes issues where RequestHandler hijacks an redirect(). Fixes #658 2010-05-03 22:07:13 -04:00
predominant
87db966383 Remove PHP5 conditional statements. 2010-05-03 13:36:32 +10:00
predominant
c1eaa4b24c Fixed access and removed @access tags. 2010-05-03 13:28:09 +10:00
Mark Story
c48f6d6536 Fixing safe parameter from leaking into request() calls in JsHelper::submit() and JsHelper::link(). Fixes #656 2010-05-02 21:17:10 -04:00
Mark Story
8c7cfb2a1e Changing string offset access. 2010-05-02 18:04:13 -04:00
Mark Story
d94ff92a9d Merge branch '2.0' into 2.0-request
Conflicts:
	cake/libs/view/pages/home.ctp
	cake/tests/cases/dispatcher.test.php
	cake/tests/lib/reporter/cake_html_reporter.php
2010-05-02 18:03:23 -04:00
Mark Story
adf604a966 Merge branch '1.3' into 2.0
Conflicts:
	cake/console/templates/default/actions/controller_actions.ctp
	cake/console/templates/default/views/form.ctp
	cake/console/templates/default/views/index.ctp
	cake/console/templates/default/views/view.ctp
	cake/libs/controller/controller.php
	cake/libs/controller/scaffold.php
	cake/libs/view/pages/home.ctp
	cake/tests/cases/dispatcher.test.php
	cake/tests/cases/libs/model/cake_schema.test.php
2010-05-02 17:53:42 -04:00
Mark Story
e11f7da896 Adding support for Router::reverse() to operate on CakeRequest objects. 2010-05-02 02:19:32 -04:00
Mark Story
7e25d94258 Renaming internals of Router.
Adding tests for legacy setRequestInfo() support.
2010-05-02 02:16:16 -04:00
Mark Story
26279851e1 Making Router::setRequestInfo() able to accept arrays. It will convert older style arrays into a CakeRequest object for later use.
Updating uses of Router::setRequestInfo() to just pass the object where possible.
2010-05-02 01:59:56 -04:00
Mark Story
e336df6de8 Updating some uses of Router::setRequestInfo(). 2010-05-02 01:43:37 -04:00
Mark Story
9a1858367f Removing unused and untested feature. 2010-05-02 01:24:44 -04:00
Mark Story
4eef2c19f0 Making CakeRequest::addParams() chainable. Adding CakeRequest::addPaths() to allow easy settings of path variables, its also chainable. Tests added. 2010-05-02 01:22:34 -04:00
Mark Story
bd1365f8ae Changing interactions inside Router so it doesn't need a CakeRequest object, makes changes to Router test not necessary. 2010-05-02 00:29:35 -04:00
Mark Story
12cbf3198a Removing addslashes/stripslashes in cache file generation as they were creating corrupted serialized objects. Replacing with a simple str_replace() on ' instead. 2010-05-02 00:12:53 -04:00
Mark Story
e4cf8a6937 Fixing issue where 'data' could not be accessed with array access, there were tests in Dispatchers tests that expected this. 2010-05-01 23:46:10 -04:00
Mark Story
d2ea077b81 Moving parameter parsing below asset dispatching, should speed up asset dispatching.
Updating + fixing tests to reflect API changes and fixing some issues where router was breaking assets.
2010-05-01 23:19:47 -04:00
Mark Story
aa234bc861 Making CakeRequest keep [url][url] for compatibility issues. 2010-05-01 22:45:31 -04:00
ADmad
f386dca6d8 Controller::loadModel() now returns true when model is succesfully instantiated as stated in docblock. Added test case. 2010-05-02 05:34:38 +05:30
Mark Story
257665eb5b Updating doc blocks for bindModel and unbindModel, explaining that associations are only reset when find() is called. Refs #652 2010-05-01 17:37:23 -04:00
Mark Story
0eb4849803 Renaming a method. 2010-05-01 11:08:58 -04:00
Mark Story
2b08ad6012 Updating fatal tests in Dispatcher tests. Updating Router to use a method instead of a raw array_merge. 2010-05-01 11:07:32 -04:00
Mark Story
40bca71985 Adding tests and features for CakeRequest to parse querystring args from the url parameter in the constructor. Added tests. 2010-05-01 11:04:41 -04:00
Mark Story
fbd70bf23c Making Dispatcher::parseParams require a CakeRequest object instead of as string url. Updating tests in the Dispatcher, and fixing an issue where POST params would be wiped out by Router. 2010-05-01 10:48:30 -04:00
Mark Story
ffd05ffc3e Removing methods from Dispatcher that have been moved to CakeRequest.
Removing test cases for features that don't exist anymore.
Updating Router and Dispatcher to use the request object.
2010-05-01 01:43:06 -04:00
Mark Story
1b5c0cca4d Removing duplicated code and moving methods to protected. 2010-05-01 00:32:43 -04:00
Mark Story
4deacf0b06 Existing tests are now all passing. 2010-05-01 00:18:17 -04:00
Mark Story
c7f4334bff Moving test code around and starting to refactor things in tests. 2010-04-30 23:37:16 -04:00
José Lorenzo Rodríguez
ad51115e12 Fixing bug where required class would be added to form fields when using single rule syntax in $validate even if allowEmpty is set to true
Closes #654
2010-04-30 16:42:59 -04:30
Mark Story
85b86164e3 Starting to move additional methods from Dispatcher into CakeRequest. Tests have been moved, and updated. 2010-04-30 00:13:24 -04:00
Mark Story
51db3c80ef Moving query string params around. Updating test cases. 2010-04-29 23:20:31 -04:00
Mark Story
6dcc680c1a implementing CakeRequest::addDetector() and adding test cases. 2010-04-29 23:08:01 -04:00
Mark Story
734e4fa87a Removing the conditional check around including custom session configuration files. This fixes issues where requestAction could cause loss of session settings, and improves the end developers ability to customize the session. Custom session files should ensure that classes/functions are conditionally declared. Fixes #374, #541 2010-04-29 21:40:12 -04:00
ADmad
afd67e534b Fixing parse error created in commit [6d092552e5]. Closes #647 2010-04-30 03:52:39 +05:30
Mark Story
0daf6e4dba Adding skeleton for addDetector. 2010-04-29 00:33:41 -04:00
Mark Story
a6ee9e352d Expanding doc blocks for methods.
Adding ArrayAccess implementation and test cases.
2010-04-29 00:22:33 -04:00
Mark Story
476a76b7a4 Adding __get() and test cases. 2010-04-29 00:22:33 -04:00
Mark Story
c11095bc54 Adding __call() for undefined method handling. Tests added. 2010-04-29 00:22:33 -04:00