mark_story
07948a733d
Reverting change made in [ 7cde309
]. Readding trim() to fix issues on windows. Updating tests so they continue to pass on macos. Fixes #769
2010-05-30 11:16:40 -04:00
mark_story
0180daaad3
Updating version numbers to 1.3.1
2010-05-29 13:26:34 -04:00
mark_story
dea33f6452
Fixing pass by reference errors in php5.3. Fixes #451
2010-05-29 13:19:12 -04:00
mark_story
7cde3094f0
Removing trim() that was performed when reading a file with a lock() enabled. This was causing a failure in php5.
2010-05-29 12:50:42 -04:00
renan.saddam
c96d074722
Merge branch '1.3' of github.com:cakephp/cakephp into 1.3
2010-05-29 12:23:04 -03:00
renan.saddam
8f5112b8d7
Changing break; to continue; so it will process the next tables on the array, tests added.
2010-05-29 12:22:16 -03:00
predominant
8decc683ac
Numerous 'shoer description' documentation entries updated to contain useful comments.
2010-05-30 01:20:28 +10:00
predominant
f63f15812e
Merge remote branch 'origin/1.3' into 1.3
2010-05-30 01:13:40 +10:00
predominant
f06f0dae8b
Numerous "Enter description here" block comments updated to have meaningful descriptions.
2010-05-30 01:10:48 +10:00
Juan Basso
e02cb81a67
Reading a smtp response until EOL. Fixes #378
2010-05-29 12:04:29 -03:00
mark_story
8b6c974cd0
Making FileEngine not greedily clear files in a directory that may belong to another cache configuration. Tests added. Fixes #754
2010-05-27 00:01:17 -04:00
mark_story
cd255d5031
Merge branch '1.3' of github.com:cakephp/cakephp into 1.3
2010-05-25 23:08:06 -04:00
Martin Radosta
64adfacd3e
Making DboSource::order() accept an expression object. Fixes issues with
...
sql parsing over quoting special SQL syntax. Tests added. Fixes #747
Signed-off-by: mark_story <mark@mark-story.com>
2010-05-25 23:07:29 -04:00
Juan Basso
bc3e745673
Support to EHLO in SMTP server for EmailComponent. Fixes #54 , #712 , #737
2010-05-24 22:24:58 -03:00
Juan Basso
2d44929598
Optimization on dbo datasource to not repeat ids in find. Fixes #601
...
Signed-off-by: mark_story <mark@mark-story.com>
2010-05-23 17:22:55 -04:00
ADmad
7d51952801
Removing protected var CakeSession::_started and instead session_id() is now used to check if session is started in CakeSession::started(). This fixes issue where CakeSession::started() returned incorrect value when used across multiple objects. Closes #731
2010-05-23 02:14:07 +05:30
tarcisio
06c1b583f8
fix typo in CakeLog::config()
...
Signed-off-by: mark_story <mark@mark-story.com>
2010-05-22 10:49:37 -04:00
mark_story
29f2223c6d
Removing hardcoded '__' for virtualField separators. Making it an instance property instead. This allows the customization of the separator if needed. Tests added for DboMysql. Refs #655 , #730
2010-05-22 00:58:54 -04:00
mark_story
23d4bafd39
Fixing inflection of words ending in causes. Fixes #736
2010-05-21 23:49:49 -04:00
mark_story
82250efc3e
Updating doc blocks for FormHelper::input() refs #735
2010-05-20 22:58:20 -04:00
predominant
3a81a9e6f2
Remove unnecessary spaces.
2010-05-20 12:17:52 +10:00
Robert Sworder
385ceb434e
When using Digest Authentication the passwords do not need to be md5 hashed. Removed incorrect comment.
...
Fixes #733
Signed-off-by: mark_story <mark@mark-story.com>
2010-05-18 22:19:33 -04:00
Juan Basso
a94b9ee95b
Update various links. Closes #392
2010-05-18 22:15:13 -03:00
mark_story
3a60aa07de
Fixing issues where setting jQueryObject did not affect request() and its connected methods.
...
Tests added.
Fixes #728
2010-05-17 18:25:50 -04:00
mark_story
4915645fb1
Applying patch from 'Daren Thomas' fixes issues where sorting on virtualFields did not work properly when using aliased sort link keys. Tests added. Fixes #680
2010-05-16 23:42:14 -04:00
Mark Story
353c600cd7
Removing unreachable code. Fixes #614
2010-05-13 23:38:26 -04:00
Mark Story
046c233a34
Adding Welsh to the supported lists of locales in l10n. Thanks to 'DanAbel' for the 'patch'. Fixes #714
2010-05-13 22:13:59 -04:00
Mark Story
79839c07d2
Fixing issues where ModelBehavior::detach() would not detach behaviors when a plugin.name was provided. This change makes detach() work like attach(). Tests added. Fixes #711
2010-05-11 23:08:14 -04:00
Mark Story
6add43a4bc
Fixing issue where id = null could cause SQL errors when saving more than one record with a null id. Fixes #675
2010-05-11 22:40:56 -04:00
ADmad
3539660cd0
Space is now properly added inbetween when 'asc'/'desc' class is appended to user defined css class in PaginatorHelper::sort. Fixes #710
2010-05-12 00:42:02 +05:30
Mark Story
6e355312bb
Fixing issue where Config.timeout wouldn't correctly countdown when many quick requests were sent.
2010-05-11 00:39:10 -04:00
Richard Sbresny
b04a3f8514
Switched over to using the previously unused Security::inactiveMins() method for getting timeout modifiers
...
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:14:20 -04:00
Richard Sbresny
5cf08cbe92
Updated default values to reflect the static values previously set
...
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:12:15 -04:00
Richard Sbresny
c62ae5e48a
Included timeout multiplier factor to be used not just inside a session start
...
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:11:44 -04:00
Richard Sbresny
a4950f6940
Updated session timeout calculations to use the security level from core.php as the multiplier.
...
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:11:20 -04:00
Robert Sworder
ec10a01504
Changing home.ctp to remove references to 1.2. Fixes #705
...
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-10 23:48:12 -04:00
predominant
1ec220dac2
Removing closing PHP tags.
2010-05-11 08:07:49 +10:00
Mark Story
1a7dce3af6
Updating DboMysql to fix an issue where virtualFields that were simple
...
aliases to fields on other tables would end up in the wrong place.
Tests added. Fixes #655
2010-05-07 23:26:13 -04:00
Mark Story
0930b5c63c
Adding more documentation for JsHelper::submit(). Closes #681
2010-05-07 21:26:44 -04:00
Mark Story
1c3415759a
Fixing 'Only variables should be assigned by reference' errors in php4 in form helper. Fixes #643
2010-05-06 22:11:31 -04:00
Mark Story
1c1c511853
Changing how email validation methods are applied, to fix issues where getmxrr() exists but the domain being validated does not have MX records correctly configured. Fixes #634
2010-05-06 21:43:58 -04:00
predominant
719836c41d
Updated doc block for added HTTP Status.
2010-05-05 10:09:47 +10:00
Mark Story
ce10c85367
Making Sanitize::stripScripts() to remove multi-line script and style blocks. Fixes #657
2010-05-03 22:33:20 -04:00
Mark Story
95dbae8acf
Making RequestHandler component carry along a passed status code. This fixes issues where RequestHandler hijacks an redirect(). Fixes #658
2010-05-03 22:07:13 -04:00
Mark Story
c48f6d6536
Fixing safe parameter from leaking into request() calls in JsHelper::submit() and JsHelper::link(). Fixes #656
2010-05-02 21:17:10 -04:00
ADmad
f386dca6d8
Controller::loadModel() now returns true when model is succesfully instantiated as stated in docblock. Added test case.
2010-05-02 05:34:38 +05:30
Mark Story
257665eb5b
Updating doc blocks for bindModel and unbindModel, explaining that associations are only reset when find() is called. Refs #652
2010-05-01 17:37:23 -04:00
José Lorenzo Rodríguez
ad51115e12
Fixing bug where required class would be added to form fields when using single rule syntax in $validate even if allowEmpty is set to true
...
Closes #654
2010-04-30 16:42:59 -04:30
Mark Story
734e4fa87a
Removing the conditional check around including custom session configuration files. This fixes issues where requestAction could cause loss of session settings, and improves the end developers ability to customize the session. Custom session files should ensure that classes/functions are conditionally declared. Fixes #374 , #541
2010-04-29 21:40:12 -04:00
ADmad
afd67e534b
Fixing parse error created in commit [ 6d092552e5
]. Closes #647
2010-04-30 03:52:39 +05:30
Mark Story
6d092552e5
Updating bake templates and Scaffold to use less sprintf() and more complete sentences in i18n strings. This should make translations easier to do in a gender correct way. Fixes #210
2010-04-28 23:56:07 -04:00
Mark Story
328c58635b
Fixing inflection of words ending in analysis. Fixes #619
2010-04-27 23:03:37 -04:00
Mark Story
2fab47e740
Updating doc block for EmailComponent::send(). Fixes #633
2010-04-27 22:50:34 -04:00
Mark Story
bd485c77d3
Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3
2010-04-27 22:42:54 -04:00
Mark Story
bb239e3816
Fixing parse error in php4 for MediaView. Also fixing undefined variable error in Dispatcher. Fixes #628
2010-04-27 22:42:33 -04:00
Mark Story
af6435ece8
Fixing issue where table name was not using fully qualified table names, causing issues with models using table prefixes. Tests added. Fixes #623
2010-04-25 00:22:57 -07:00
predominant
1c064788c5
Updated vesion numbers to 1.3.0
2010-04-25 14:27:29 +10:00
ADmad
46df1be384
Model::deleteAll() now returns false if the 'find' to fetch records ids returns false (in case of sql error). Closes #272
2010-04-25 02:34:18 +05:30
Mark Story
bc6b8e5dfd
Fixing parameters from leaking into the script tag when calling JsHelper::submit(). Added test cases and refactored JsHelper::link(). Fixes #613
2010-04-23 00:04:15 -04:00
kleingeist
6033fc70fa
Documentation fix for XmlHelper::serialize
...
Signed-off-by: Mark Story <mark@mark-story.com>
2010-04-22 21:27:17 -04:00
José Lorenzo Rodríguez
fca070fe9e
Merge branch '1.3' of git@github.com:cakephp/cakephp1x into 1.3
...
* '1.3' of git@github.com:cakephp/cakephp1x:
Adding tests for and fixing the behavior of `cake acl initdb` it now correctly delegates to SchemaShell. Fixes #608
Making TestTask not depend on Inflection rules for creating directory names, refs #610
Adding tests for Inflector::rules() clearing cached values. Fixes #609
Clear cache of pluralized, singularized and tableize when set rules.
2010-04-22 16:50:25 -04:30
José Lorenzo Rodríguez
65f01fa31c
Fixing model introspection in FormHelper to better take in account realted models with aliased names
2010-04-22 16:37:15 -04:30
Juan Basso
bb0ff192f7
Clear cache of pluralized, singularized and tableize when set rules.
...
Signed-off-by: Mark Story <mark@mark-story.com>
2010-04-21 22:48:56 -04:00
José Lorenzo Rodríguez
5ceb19304e
Merge branch '1.3' of git@github.com:cakephp/cakephp1x into 1.3
2010-04-19 23:33:43 -04:30
José Lorenzo Rodríguez
e1c4b9696b
Adding documentation on 'attributes' key for FormHelper::error
2010-04-19 23:32:58 -04:30
José Lorenzo Rodríguez
23eea00a0b
Fixing FormHelper::error to no add error names and messages as html attributes. Fixes #585
...
This introduces the special key 'attributes' to FormHelper::error() when passed in the second parameter
The contents of said key will be converted into html attributes for the error container tag
2010-04-19 23:25:57 -04:30
Mark Story
029d2581af
Fixing autoFields causing invalid SQL when cross database joins are being done. Tests added. Fixes #476
2010-04-19 22:39:07 -04:00
Mark Story
9ae8b737dc
Trimming trailing whitespace.
2010-04-17 13:05:26 -04:00
Mark Story
78f14401ca
Fixing issue where using delivery = debug and not using sessions would cause a fatal error. send() will now return the contents that would get written into the session. Fixes #595
2010-04-17 12:27:50 -04:00
Mark Story
bb7cc60d3f
Fixing parse error added in last commit :(
2010-04-17 02:13:22 -04:00
Mark Story
0f6e87cab8
Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3
2010-04-17 02:10:58 -04:00
predominant
23a22c73b7
Remove "not being used" comment from Model docblock. Fixes #590
2010-04-16 21:45:44 +10:00
Mark Story
8ef2a82a89
minor optimization to save one call to Helper::model() when creating forms.
2010-04-14 21:00:00 -04:00
ADmad
99e5f4a49f
Removing ampersand (&) from default transliteration map
2010-04-15 01:56:38 +05:30
José Lorenzo Rodríguez
0300fc1c31
If connection is aborted, now MediaView returns false after stopping the transfer
2010-04-13 16:55:22 -04:30
José Lorenzo Rodríguez
940ce8b06e
Adding some test coverage on MediaView.
...
Now MediaView does not exit after successful render, closes #569
2010-04-13 16:44:14 -04:30
Mariano Iglesias
388bca4acd
Fixing syntax error generated by last merge conflict
2010-04-13 15:46:12 -03:00
Mariano Iglesias
a6b83cdd93
Fixing issue where TextHelper::autoLinkUrls was failing on some expressions
2010-04-13 15:39:30 -03:00
José Lorenzo Rodríguez
9d2819970d
Fixing schema generation for postgres. Now character varying without lenght is translated to "text", to avoid sql errors. Closes #564
2010-04-13 01:08:31 -04:30
Mark Story
e2b5470d19
Updating version numbers to 1.3.0-RC4
2010-04-12 22:27:18 -04:00
ADmad
baaae6cdb7
Minor optimization in TreeBehavior::getparentnode() to avoid fetching unneeded associated records. Closes #572
2010-04-12 22:57:31 +05:30
Mark Story
404401b4de
Moving action modification when a prefix is detected so it affects all url arrays. Previously it was only applied to parameters in the current request. This fixes inconsistencies between request parameters and url parameters. Fixes #570
2010-04-11 23:13:18 -04:00
Mark Story
42bc252460
Fixing return value of CakeSession::__startSession(). Once headers were sent any further session objects would think that the session was not successfully started. Fixes issues in Helper group test. Also fixes #568
2010-04-11 11:41:10 -04:00
Mark Story
e1253f0bb5
Including a plugin short route for prefixes as well. There were failing Dispatcher tests relying on this.
2010-04-10 21:12:48 -04:00
ADmad
f6525e054f
Updating transliteration map used by Inflector::slug to preserve some of the older mappings as previous commit broke test cases
2010-04-11 04:42:58 +05:30
Hilton Gonçalves
c082ee6b9b
Update Default transliteration map used for Inflector::slug
...
Makes slugging of uppercase characters more consistent with lower case
ones.
Fixes #560
2010-04-10 18:09:54 -04:00
Mark Story
6c357ee555
Adding tests from 'tfs' fixes inconsistencies in extracting elements with one path selector. Fixes #555
2010-04-10 16:57:50 -04:00
Mark Story
fbaabad6bb
Fixing issues where route parameters that overlapped could cause route compilation errors. Tests added. Fixes #565
2010-04-10 11:17:24 -04:00
Matt Curry
1c5898d94b
Don't get User model if not needed. Fixes #563
...
Signed-off-by: Mark Story <mark@mark-story.com>
2010-04-10 10:40:56 -04:00
predominant
60bb9a9b56
Spacing doc blocks.
2010-04-09 22:06:44 +10:00
Mark Story
30e6c57a96
Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3
2010-04-08 23:37:27 -04:00
Mark Story
c38249ac28
Updating HtmlHelper + JavascriptHelper to call assetTimestamp() after webroot(). This allows theme files in webroot/theme to be correctly timestamped.
...
Updating tests to reflect changes in behaviour. Fixes #244
2010-04-08 23:36:04 -04:00
José Lorenzo Rodríguez
05af213d59
Merge branch '1.3' of git@github.com:cakephp/cakephp1x into 1.3
2010-04-08 22:26:04 -04:30
sdoney
9f601ea334
Adding/Updating @link tags pointing to cookbook sections
...
Signed-off-by: Mark Story <mark@mark-story.com>
2010-04-08 22:46:05 -04:00
José Lorenzo Rodríguez
03e3c3249f
Removing whitespace at the end of the file
2010-04-08 22:15:49 -04:30
José Lorenzo Rodríguez
7eb3055720
Merge branch '1.3' of git@github.com:cakephp/cakephp1x into 1.3
...
* '1.3' of git@github.com:cakephp/cakephp1x:
Adding PluginShortRoute into default connected routes. Fixes issues with the framework having built in 404s.
Implementing PluginShortRoute and some tests for its methods.
Fixing tests that started failing because of removal of short routes on reverse routing.
Removing plugin shortcuts entirely.
Adding additional test for plugin shortcut routes including prefixed shortcut routes.
Updating doc block for Router::__connectDefaultRoutes()
Removing Dispatcher::_restructureParams() as it is no longer used.
Moving expectations inline.
Fixing tests that should have never worked, and removing additional calls to _restructureParams. Adding in prefixed plugin shortcuts as they were missing.
Modifying Dispatcher tests to modify private variables (which is bad, but there is no way to change which plugins Router uses to create patterns). This allows the removal of two calls to _restructureParams.
Making PluginShortRoute check that the action exists before attempting to proceed. Updated tests.
Adding doc blocks to PluginShortRoute. Adding PluginShortRoute into Router.
Shrinking number of lines in dispatcher test case.
Adding PluginShortRoute, and a few test cases.
2010-04-08 18:24:24 -04:30
José Lorenzo Rodríguez
59f7cb47d3
Improving test coverage on FormHelper to show the usage of the 'secure' key for inputs.
...
Fixing issue with select inputs that does not honor the value of 'secure'
2010-04-08 18:23:07 -04:30
Mark Story
4d780ee1f3
Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3
2010-04-08 00:04:14 -04:00
Mark Story
0427fe9777
Merge branch 'no-shortcuts' into 1.3
2010-04-08 00:03:58 -04:00
Mark Story
81dc0d42b9
Adding PluginShortRoute into default connected routes. Fixes issues with the framework having built in 404s.
...
Adding tests for the default connected routes.
2010-04-08 00:03:46 -04:00