Commit graph

3596 commits

Author SHA1 Message Date
José Lorenzo Rodríguez
b2f7afca11 Migrating SetTest to phpunit 2010-05-31 22:10:24 -04:30
José Lorenzo Rodríguez
499b8cf28e migrating HttpSocketTest to phpunit 2010-05-31 22:04:10 -04:30
mark_story
02a04abf6b Fixing return values of methods, and updating tests to run properly in Phpunit which uses exceptions instead of errors. 2010-05-30 22:57:28 -04:00
mark_story
ea2f0327f5 Reverting change made in [7cde309]. Readding trim() to fix issues on windows. Updating tests so they continue to pass on macos. Fixes #769 2010-05-30 22:46:46 -04:00
mark_story
22e942c2a3 Fixing most of the File test case issues with phpunit. 2010-05-30 22:46:42 -04:00
mark_story
75d7b46a35 Updating memcacheEngine test case so it passes under phpunit. 2010-05-30 22:39:45 -04:00
mark_story
fc79dc6232 Merge branch '2.0' into 2.0-phpunit
Conflicts:
	cake/tests/cases/console/libs/tasks/controller.test.php
	cake/tests/cases/libs/code_coverage_manager.test.php
	cake/tests/cases/libs/view/helpers/js.test.php
	cake/tests/lib/code_coverage_manager.php
2010-05-30 22:13:09 -04:00
mark_story
7ed67e5959 Fixing virtualFields used in order clauses where virtualField was supplied with model alias. Tests added. Refs #768 2010-05-30 20:30:58 -04:00
mark_story
c98a82c61c Fixing whitespace. 2010-05-30 20:28:00 -04:00
mark_story
66a8890f4f Fixing code formatting in test cases. 2010-05-30 12:51:48 -04:00
mark_story
07948a733d Reverting change made in [7cde309]. Readding trim() to fix issues on windows. Updating tests so they continue to pass on macos. Fixes #769 2010-05-30 11:16:40 -04:00
mark_story
5ef9103a52 Updating the rest of the controller task test case to use phpunit. 2010-05-30 00:59:36 -04:00
Mark Story
ca5fb9fb93 Fixing tests broken by changes in default bake templates.
Fixing issue where admin methods wouldn't be correctly generated.
Fixes #664
2010-05-30 00:11:37 -04:00
mark_story
62ec25857f Making more tests work in phpunit. 2010-05-30 00:07:43 -04:00
mark_story
25a6a3cac8 Correcting spacing in file test.
Correctly constructing a File object, so testRead does not rely on the previous test to leave the object in the correct state.
2010-05-29 12:47:31 -04:00
renan.saddam
c96d074722 Merge branch '1.3' of github.com:cakephp/cakephp into 1.3 2010-05-29 12:23:04 -03:00
renan.saddam
8f5112b8d7 Changing break; to continue; so it will process the next tables on the array, tests added. 2010-05-29 12:22:16 -03:00
predominant
8decc683ac Numerous 'shoer description' documentation entries updated to contain useful comments. 2010-05-30 01:20:28 +10:00
mark_story
7e6773c60c Updating ErrorHandler and CakeErrorController to use CakeRequest. Tests updated. 2010-05-29 00:21:02 -04:00
mark_story
8acb82f567 Updating Security component to use CakeRequest and updating its test case. 2010-05-28 23:57:43 -04:00
mark_story
5a6db36a02 Fixing PagesController test case to use CakeRequest. 2010-05-27 00:28:51 -04:00
mark_story
8b6c974cd0 Making FileEngine not greedily clear files in a directory that may belong to another cache configuration. Tests added. Fixes #754 2010-05-27 00:01:17 -04:00
mark_story
0dc627178a updating helper and component tests for controller task to use phpunit. 2010-05-26 23:01:14 -04:00
mark_story
8ac46c3b63 Adding return from _stop() to help testing.
Updating tests for getName()
2010-05-26 21:59:56 -04:00
mark_story
9647e359c4 First test passing for controllertask test 2010-05-25 23:54:28 -04:00
mark_story
08bcf55b8d Starting to convert controller task test to phpunit. 2010-05-25 23:51:48 -04:00
mark_story
cd255d5031 Merge branch '1.3' of github.com:cakephp/cakephp into 1.3 2010-05-25 23:08:06 -04:00
Martin Radosta
64adfacd3e Making DboSource::order() accept an expression object. Fixes issues with
sql parsing over quoting special SQL syntax. Tests added.  Fixes #747

Signed-off-by: mark_story <mark@mark-story.com>
2010-05-25 23:07:29 -04:00
Juan Basso
bc3e745673 Support to EHLO in SMTP server for EmailComponent. Fixes #54, #712, #737 2010-05-24 22:24:58 -03:00
mark_story
66699df9a0 Updating Shell.test to use PHPUnit. There may still be some errors with the windows tests as I don't have access to windows at this time. 2010-05-23 14:52:46 -04:00
mark_story
265609dfc1 Moving test to work with PHPUnit.
Fixing incorrect count amount in SchemaShell.
2010-05-23 00:17:22 -04:00
mark_story
81c2169b0b Fixing BakeShell test for PHPUnit. Mock expectation numbers are off due to some oddities in PHPUnit. 2010-05-22 22:40:18 -04:00
mark_story
0436e938cd Fixing typo in class name. 2010-05-22 22:39:46 -04:00
mark_story
89a8ef3871 Updating API shell to use reflection as the regular expression was not working with visibility keywords.
Updating tests for changes in output.
Updating tests to work with PHPUnit.
2010-05-22 22:09:07 -04:00
mark_story
1955b0fb1f Updating Acl cli tool test case to use PHPUnit mock objects. 2010-05-22 20:21:27 -04:00
ADmad
7d51952801 Removing protected var CakeSession::_started and instead session_id() is now used to check if session is started in CakeSession::started(). This fixes issue where CakeSession::started() returned incorrect value when used across multiple objects. Closes #731 2010-05-23 02:14:07 +05:30
mark_story
1c36c1f088 Updating ShellDispatcher test case to use PHPUnit mock objects. 2010-05-22 13:10:01 -04:00
mark_story
cd4e63423d Exposing Object::_set() as a public method for testing and updating tests. There are still several fails caused by _persist(). 2010-05-22 11:28:22 -04:00
mark_story
29f2223c6d Removing hardcoded '__' for virtualField separators. Making it an instance property instead. This allows the customization of the separator if needed. Tests added for DboMysql. Refs #655, #730 2010-05-22 00:58:54 -04:00
mark_story
23d4bafd39 Fixing inflection of words ending in causes. Fixes #736 2010-05-21 23:49:49 -04:00
mark_story
94ac914426 Changing Router::$__validExtensions so Router::extensions() always returns an array like the doc block says.
Updating test cases for PHPUnit.
2010-05-20 22:55:25 -04:00
mark_story
df6989e3d6 Fixing Sanitize test to run under PHPUnit. 2010-05-20 22:50:06 -04:00
mark_story
7cef278ce2 Fixing missing boolean return in Validation::cc()
Fixing Validation test case to pass under PHPUnit.
2010-05-20 22:30:47 -04:00
predominant
6a18b2bc1d Merge remote branch 'origin/1.3' into 2.0
Conflicts:
	cake/basics.php
	cake/console/libs/shell.php
	cake/console/libs/tasks/controller.php
	cake/libs/controller/components/request_handler.php
	cake/libs/model/model.php
	cake/libs/model/model_behavior.php
	cake/libs/overloadable.php
	cake/libs/overloadable_php4.php
	cake/libs/overloadable_php5.php
	cake/libs/sanitize.php
	cake/libs/validation.php
	cake/libs/view/helpers/ajax.php
	cake/libs/view/helpers/javascript.php
	cake/libs/view/pages/home.ctp
	cake/tests/cases/console/libs/tasks/controller.test.php
	cake/tests/cases/libs/overloadable.test.php
	cake/tests/cases/libs/validation.test.php
	cake/tests/cases/libs/view/helpers/ajax.test.php
	cake/tests/cases/libs/view/helpers/javascript.test.php
	cake/tests/test_app/libs/cache/test_app_cache.php
	cake/tests/test_app/plugins/test_plugin/libs/cache/test_plugin_cache.php
	cake/tests/test_app/plugins/test_plugin/models/test_plugin_auth_user.php
	cake/tests/test_app/plugins/test_plugin/models/test_plugin_post.php
2010-05-20 12:22:04 +10:00
José Lorenzo Rodríguez
625d120d74 Migrating MultibyteTest to phpunit 2010-05-19 00:20:21 -04:30
José Lorenzo Rodríguez
1fa430c609 Migrating SetTest to phpunit 2010-05-19 00:16:32 -04:30
José Lorenzo Rodríguez
e60cc99034 Migrating SecurityTest to phpunit 2010-05-19 00:15:35 -04:30
José Lorenzo Rodríguez
bcc3321bd3 Migrating SetTest to phpunit 2010-05-19 00:12:13 -04:30
José Lorenzo Rodríguez
f1eaec11f5 Migrating StringTest to phpunit 2010-05-19 00:05:49 -04:30
José Lorenzo Rodríguez
50021ee646 Merge branch '2.0-phpunit' of git@github.com:cakephp/cakephp into 2.0-phpunit 2010-05-18 23:57:41 -04:30
José Lorenzo Rodríguez
103d5c2505 Partially migrated JsHelperTest to phpunit 2010-05-18 23:56:50 -04:30
mark_story
07c957e827 Making PaginatorHelper test run under PHPUnit. 2010-05-19 00:14:37 -04:00
Juan Basso
a94b9ee95b Update various links. Closes #392 2010-05-18 22:15:13 -03:00
mark_story
76f94d5c75 Fixing form attribute access and broken test. 2010-05-17 23:31:47 -04:00
mark_story
ef85fb1247 Making scaffold methods protected instead of private.
Adding visibility keywords
2010-05-17 23:30:04 -04:00
mark_story
1d884cc00f Updating Scaffold to use the CakeRequest object.
Updating Scaffold tests.
2010-05-17 23:11:47 -04:00
José Lorenzo Rodríguez
327d42d6de Fixing CacheHelperTest for phpunit 2010-05-17 22:35:54 -04:30
José Lorenzo Rodríguez
f7949d6ace Fixing FormHelperTest for phpunit 2010-05-17 22:30:04 -04:30
mark_story
f114d4299d Merge branch '2.0' into 2.0-request
Conflicts:
	cake/libs/router.php
	cake/tests/cases/libs/router.test.php
2010-05-17 21:52:14 -04:00
mark_story
3a60aa07de Fixing issues where setting jQueryObject did not affect request() and its connected methods.
Tests added.
Fixes #728
2010-05-17 18:25:50 -04:00
mark_story
4915645fb1 Applying patch from 'Daren Thomas' fixes issues where sorting on virtualFields did not work properly when using aliased sort link keys. Tests added. Fixes #680 2010-05-16 23:42:14 -04:00
José Lorenzo Rodríguez
32a46e9eda Converting HtmlHelperTest to phpunit 2010-05-15 21:05:22 -04:30
mark_story
b2d8536b3b Fixing Authcomponent tests. Updating the component + tests to use the new request object.
Deprecating a number of Authcomponent properties.
2010-05-15 00:55:15 -04:00
mark_story
36a71582fc Fixing issues with Controller::referer() and CakeRequest::referer(). Tests updated. 2010-05-15 00:53:15 -04:00
mark_story
4453c9122d Fixing JsHelper test cases to use the request object. 2010-05-14 23:29:16 -04:00
mark_story
322cceb8c1 Updating Text and Time test cases. 2010-05-14 23:13:31 -04:00
mark_story
0eebda9ee1 Updating HtmlHelper test to use request object.
Removing reference operators.
2010-05-14 23:11:38 -04:00
Mark Story
3983bf318d Updating PaginatorHelper and its test cases to use the request object. 2010-05-14 00:32:56 -04:00
Mark Story
c5dfd128fb Updating FormHelper and its tests to use the request object. 2010-05-14 00:21:22 -04:00
Mark Story
0d3011d2c3 Updating CacheHelper to use CakeRequest. 2010-05-14 00:12:29 -04:00
Mark Story
657073aa42 Marking a number of Helper properties as deprecated as they are contained within the CakeRequest object.
Adding a new property for the new request object.
Updating the internals of Helper to use the request object.
Updating the tests to use the request object.
2010-05-14 00:05:45 -04:00
Mark Story
a29866b7fb Updating test for 1.3 2010-05-13 23:09:23 -04:00
Mark Story
3d98cc6f53 Adding tests for welsh added in previous commit. 2010-05-13 23:08:32 -04:00
Mark Story
9303de936e Fixing fatal error trying to run coverage on the coverage reporter.
Removing old CodeCoverageManager implementation.
2010-05-13 21:44:30 -04:00
José Lorenzo Rodríguez
689e46be4f Converting ConfigureTest to phpunit 2010-05-13 00:52:38 -04:30
José Lorenzo Rodríguez
f3f37a126f Converting CakeSocketTest to phpunit 2010-05-13 00:50:30 -04:30
José Lorenzo Rodríguez
72959e7872 Converting CAkeSessionTest to phpunit 2010-05-13 00:21:16 -04:30
José Lorenzo Rodríguez
6613cfb662 Migrating CacheTest to phpunit 2010-05-13 00:13:40 -04:30
José Lorenzo Rodríguez
3e3817f113 Merge commit 'mark/2.0-coverage' into 2.0-phpunit
Conflicts:
	cake/tests/lib/reporter/cake_html_reporter.php
2010-05-13 00:05:30 -04:30
José Lorenzo Rodríguez
8c3df122eb Merge commit 'lorenzo/2.0-phpunit' into 2.0-phpunit
Conflicts:
	cake/tests/lib/reporter/cake_html_reporter.php
	cake/tests/lib/test_manager.php
2010-05-12 23:58:56 -04:30
Mark Story
d349551dd7 Adding tests for generating method coverage with the reporter.
Adding method visibility
2010-05-12 22:43:44 -04:00
Mark Story
79839c07d2 Fixing issues where ModelBehavior::detach() would not detach behaviors when a plugin.name was provided. This change makes detach() work like attach(). Tests added. Fixes #711 2010-05-11 23:08:14 -04:00
Mark Story
0648c6604b Adding some additional tests for possible php4 compatibility issues. 2010-05-11 23:01:40 -04:00
Mark Story
6add43a4bc Fixing issue where id = null could cause SQL errors when saving more than one record with a null id. Fixes #675 2010-05-11 22:40:56 -04:00
ADmad
3539660cd0 Space is now properly added inbetween when 'asc'/'desc' class is appended to user defined css class in PaginatorHelper::sort. Fixes #710 2010-05-12 00:42:02 +05:30
Richard Sbresny
05beaab272 Removed unnecessary unset
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:14:38 -04:00
Richard Sbresny
b04a3f8514 Switched over to using the previously unused Security::inactiveMins() method for getting timeout modifiers
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:14:20 -04:00
Richard Sbresny
a4950f6940 Updated session timeout calculations to use the security level from core.php as the multiplier.
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:11:20 -04:00
predominant
8f880731c6 Removing closing PHP tags. 2010-05-11 08:27:28 +10:00
predominant
1ec220dac2 Removing closing PHP tags. 2010-05-11 08:07:49 +10:00
Mark Story
e8e2235cfa Updating coverage report and tests to include hiding javascript. 2010-05-09 22:15:20 -04:00
José Lorenzo Rodríguez
bc9479efcf Fixing XmlTest to be compatible with PHPUnit 2010-05-09 18:18:40 -04:30
José Lorenzo Rodríguez
809550087c Finxing ThemeTest to be compatible with PHPUnit 2010-05-09 16:27:09 -04:30
José Lorenzo Rodríguez
d252fdeb52 Fixing View test case to be compatible with PHPUnit 2010-05-09 16:09:02 -04:30
Mark Story
f084a82dfc Refactoring how coverage diffs are generated to better use data from phpunit. Removing methods made redundant by data changes. 2010-05-09 12:30:55 -04:00
Mark Story
ac318faf5a Switching back to using non raw code coverage data as it has been filtered by phpunit's filters. combining the data from phpunit into a singular cohesive report. 2010-05-09 02:08:32 -04:00
Mark Story
3c3655aefd Fixing failing tests. 2010-05-09 01:16:44 -04:00
Mark Story
9a20a2344b Continuing work on updated code coverage reports. 2010-05-09 00:40:05 -04:00
Mark Story
955c6bea9f Verbose coverage generation has been added and tests added. 2010-05-09 00:04:03 -04:00
Mark Story
f6b49cd865 Updating file headers. 2010-05-08 18:12:20 -04:00
Mark Story
fad99ad1f4 Adding tests for merging of report data. 2010-05-08 18:08:02 -04:00
Mark Story
ac5f731940 Starting work on HtmlCoverageReport and adding a test case. 2010-05-08 17:59:14 -04:00
José Lorenzo Rodríguez
79c001197d Merge commit 'mark/2.0-phpunit' into 2.0-phpunit
Conflicts:
	cake/tests/lib/test_manager.php
2010-05-08 17:18:43 -04:30
José Lorenzo Rodríguez
fb09adca68 Adding tests for skipIf 2010-05-08 16:36:11 -04:30
José Lorenzo Rodríguez
4d3a6e8ca6 Fixing and testing for CakeTestCase::loadFixtures() 2010-05-08 16:14:22 -04:30
José Lorenzo Rodríguez
2b5cd26fc6 Adding tests for CakeTestCase fixtures 2010-05-08 15:56:21 -04:30
Mark Story
933378223b Updating CakeLog tests to use @expectedException annotation. 2010-05-08 16:17:20 -04:00
José Lorenzo Rodríguez
82a1bd6f80 Cleaning up CakeTestCase and adding some tests for it 2010-05-08 01:19:45 -04:30
Mark Story
5040eb7227 Updating RequestHandler and its tests to use the features moved to CakeRequest. Marking a number of methods as deprecated. 2010-05-08 00:59:40 -04:00
Mark Story
78bd7300a2 Moving features from RequestHandler into CakeRequest. 2010-05-08 00:36:03 -04:00
Mark Story
df910026ee Updating Controller::referer() to use the request object if available. Tests updated. 2010-05-08 00:06:13 -04:00
Mark Story
77264da34a Updating Controller tests to always pass in a CakeRequest. Fixing some notice errors that come up in the test cases. 2010-05-08 00:00:19 -04:00
Mark Story
1a7dce3af6 Updating DboMysql to fix an issue where virtualFields that were simple
aliases to fields on other tables would end up in the wrong place.
Tests added.  Fixes #655
2010-05-07 23:26:13 -04:00
Mark Story
745afe888b Adding more tests for saving records with nulls. Closes #675 2010-05-07 22:23:18 -04:00
Mark Story
26f7fcef3c Updating Controller and its tests to use CakeRequest. 2010-05-06 23:23:13 -04:00
Mark Story
2b7723fd12 Removing reference operators and making Controller::__construct take a CakeRequest. If one is passed all the necessary properties will be populated. This lightens the Dispatcher, and gives more control to the end developer. 2010-05-06 23:18:50 -04:00
Mark Story
1a460e47f1 Removing reference operators in Controller and its tests. 2010-05-06 22:48:48 -04:00
Mark Story
f152181c03 Adding tests for saving models with id == null. Closes #675 2010-05-06 22:24:11 -04:00
Mark Story
45d052b55a Fixing failing tests in ViewTask test case, caused by changes in core templates.
Fixing incorrect variable usage where models would be double singularized causing incorrect names.  Fixes #668
2010-05-06 21:38:14 -04:00
José Lorenzo Rodríguez
bed87b87c6 Removing code from CakeTestCase around the method "testAction" which was a bad way of testing controllers, often making it more difficult.
This also removes class contamination in newly created test cases
2010-05-05 22:42:56 -04:30
José Lorenzo Rodríguez
b53d21ff52 Fixing a group test case to show how to create one, and to make pass TestManager test case 2010-05-04 23:58:17 -04:30
José Lorenzo Rodríguez
fd4a82d6e9 Adding test for TestManager::runGroupTest() 2010-05-04 23:56:40 -04:30
Mark Story
fcad9b464c Fixing tests broken by changes in default bake templates.
Fixing issue where admin methods wouldn't be correctly generated.
Fixes #664
2010-05-04 23:27:41 -04:00
Mark Story
62157679c4 Fixing failing test in Dispatcher caused by removed method. 2010-05-04 23:08:03 -04:00
Mark Story
b9a00ccfa5 Updating test case to use new Router constants. 2010-05-04 23:05:45 -04:00
José Lorenzo Rodríguez
c23f66e35c Removing "extends" from TestManager as it wasn't used anyway.
Making some methods static as they were called statically
More testing on TestManager
2010-05-04 20:51:58 -04:30
José Lorenzo Rodríguez
cdf4006f16 Refactoring TestManager::runAllTests() and improving the TestManager test case 2010-05-04 18:25:15 -04:30
Mark Story
e9a7d6d3b9 Splitting CakeRoute and PluginShortRoute into their own files. Also splitting out the test cases. 2010-05-04 00:35:22 -04:00
Mark Story
f76d320688 Making Router a fully static class. Tests updated. 2010-05-04 00:26:02 -04:00
Mark Story
c91d74a9af Making CakeRequest toss an exception when it can't handle a method call. 2010-05-03 23:41:13 -04:00
Mark Story
c5fdeec7a1 Updating FormHelper tests to use CakeRequest. 2010-05-03 23:39:43 -04:00
Mark Story
69275c8996 Adding a parameter to CakeRequest to allow it to skip parsing the environment. 2010-05-03 22:50:38 -04:00
Mark Story
ce10c85367 Making Sanitize::stripScripts() to remove multi-line script and style blocks. Fixes #657 2010-05-03 22:33:20 -04:00
Mark Story
95dbae8acf Making RequestHandler component carry along a passed status code. This fixes issues where RequestHandler hijacks an redirect(). Fixes #658 2010-05-03 22:07:13 -04:00
Mark Story
c48f6d6536 Fixing safe parameter from leaking into request() calls in JsHelper::submit() and JsHelper::link(). Fixes #656 2010-05-02 21:17:10 -04:00
Mark Story
d94ff92a9d Merge branch '2.0' into 2.0-request
Conflicts:
	cake/libs/view/pages/home.ctp
	cake/tests/cases/dispatcher.test.php
	cake/tests/lib/reporter/cake_html_reporter.php
2010-05-02 18:03:23 -04:00
Mark Story
adf604a966 Merge branch '1.3' into 2.0
Conflicts:
	cake/console/templates/default/actions/controller_actions.ctp
	cake/console/templates/default/views/form.ctp
	cake/console/templates/default/views/index.ctp
	cake/console/templates/default/views/view.ctp
	cake/libs/controller/controller.php
	cake/libs/controller/scaffold.php
	cake/libs/view/pages/home.ctp
	cake/tests/cases/dispatcher.test.php
	cake/tests/cases/libs/model/cake_schema.test.php
2010-05-02 17:53:42 -04:00
Mark Story
b5a0dccc3a Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3 2010-05-02 17:03:20 -04:00
Mark Story
4a0ead8a62 Fixing asset filtering for assets in themes and plugins. These assets should now correctly enter the configured asset filters. Fixes #650. Fixes #160 2010-05-02 16:48:35 -04:00
Mark Story
e11f7da896 Adding support for Router::reverse() to operate on CakeRequest objects. 2010-05-02 02:19:32 -04:00
Mark Story
7e25d94258 Renaming internals of Router.
Adding tests for legacy setRequestInfo() support.
2010-05-02 02:16:16 -04:00
Mark Story
26279851e1 Making Router::setRequestInfo() able to accept arrays. It will convert older style arrays into a CakeRequest object for later use.
Updating uses of Router::setRequestInfo() to just pass the object where possible.
2010-05-02 01:59:56 -04:00
Mark Story
e336df6de8 Updating some uses of Router::setRequestInfo(). 2010-05-02 01:43:37 -04:00
Mark Story
982437595e Fixing errors caused by API changes. 2010-05-02 01:22:59 -04:00
Mark Story
4eef2c19f0 Making CakeRequest::addParams() chainable. Adding CakeRequest::addPaths() to allow easy settings of path variables, its also chainable. Tests added. 2010-05-02 01:22:34 -04:00
Mark Story
12cbf3198a Removing addslashes/stripslashes in cache file generation as they were creating corrupted serialized objects. Replacing with a simple str_replace() on ' instead. 2010-05-02 00:12:53 -04:00
Mark Story
13cc8e746d Moving tests into CakeRequest from dispatcher test.
Dispatcher tests are all working again.
2010-05-01 23:49:22 -04:00
Mark Story
e4cf8a6937 Fixing issue where 'data' could not be accessed with array access, there were tests in Dispatchers tests that expected this. 2010-05-01 23:46:10 -04:00
Mark Story
d2ea077b81 Moving parameter parsing below asset dispatching, should speed up asset dispatching.
Updating + fixing tests to reflect API changes and fixing some issues where router was breaking assets.
2010-05-01 23:19:47 -04:00
Mark Story
aa234bc861 Making CakeRequest keep [url][url] for compatibility issues. 2010-05-01 22:45:31 -04:00
ADmad
f386dca6d8 Controller::loadModel() now returns true when model is succesfully instantiated as stated in docblock. Added test case. 2010-05-02 05:34:38 +05:30
Mark Story
0eb4849803 Renaming a method. 2010-05-01 11:08:58 -04:00
Mark Story
2b08ad6012 Updating fatal tests in Dispatcher tests. Updating Router to use a method instead of a raw array_merge. 2010-05-01 11:07:32 -04:00
Mark Story
0a7ba707b6 Adding tests for CakeRequest::addParams() 2010-05-01 11:06:51 -04:00
Mark Story
40bca71985 Adding tests and features for CakeRequest to parse querystring args from the url parameter in the constructor. Added tests. 2010-05-01 11:04:41 -04:00
Mark Story
fbd70bf23c Making Dispatcher::parseParams require a CakeRequest object instead of as string url. Updating tests in the Dispatcher, and fixing an issue where POST params would be wiped out by Router. 2010-05-01 10:48:30 -04:00
Mark Story
ffd05ffc3e Removing methods from Dispatcher that have been moved to CakeRequest.
Removing test cases for features that don't exist anymore.
Updating Router and Dispatcher to use the request object.
2010-05-01 01:43:06 -04:00
Mark Story
558aea0221 Moving tests and helper methods from Dispatcher into CakeRequest 2010-05-01 01:06:09 -04:00
Mark Story
4deacf0b06 Existing tests are now all passing. 2010-05-01 00:18:17 -04:00
Mark Story
c7f4334bff Moving test code around and starting to refactor things in tests. 2010-04-30 23:37:16 -04:00
José Lorenzo Rodríguez
ad51115e12 Fixing bug where required class would be added to form fields when using single rule syntax in $validate even if allowEmpty is set to true
Closes #654
2010-04-30 16:42:59 -04:30
José Lorenzo Rodríguez
9b040a5ed3 Fixing code formating 2010-04-30 16:07:59 -04:30
ADmad
0471ea046f Adding test case for 'required' class adding to wrapping div based on model validations. Refs #654 2010-05-01 01:19:52 +05:30
Mark Story
85b86164e3 Starting to move additional methods from Dispatcher into CakeRequest. Tests have been moved, and updated. 2010-04-30 00:13:24 -04:00
Mark Story
51db3c80ef Moving query string params around. Updating test cases. 2010-04-29 23:20:31 -04:00
Mark Story
0bbd7fae2c Adding more tests to CakeRequest::addDetector() for callback type. 2010-04-29 23:11:15 -04:00
Mark Story
6dcc680c1a implementing CakeRequest::addDetector() and adding test cases. 2010-04-29 23:08:01 -04:00
Mark Story
a6ee9e352d Expanding doc blocks for methods.
Adding ArrayAccess implementation and test cases.
2010-04-29 00:22:33 -04:00
Mark Story
476a76b7a4 Adding __get() and test cases. 2010-04-29 00:22:33 -04:00
Mark Story
c11095bc54 Adding __call() for undefined method handling. Tests added. 2010-04-29 00:22:33 -04:00
Mark Story
3a0ad6f1a8 Starting CakeRequest::is() and adding tests for various core is() types. 2010-04-29 00:22:32 -04:00
Mark Story
aab4a9413a Adding CakeRequest::referer() and test cases. 2010-04-29 00:22:32 -04:00
Mark Story
64aafd36bb Expanding coverage for CakeRequest. Expanding doc blocks in CakeRequest. 2010-04-29 00:22:32 -04:00
Mark Story
93f4c66035 Adding tests for CakeRequest's ability to munge through the FILES array. Fixing issue where files would be in the wrong place. 2010-04-29 00:22:32 -04:00
Mark Story
8f207a5f69 Moving getClientIp into CakeRequest. Moving relevant tests as well. 2010-04-29 00:22:32 -04:00
Mark Story
15a4607061 Fixing some issues with parameter handling. Adding test cases. 2010-04-29 00:22:32 -04:00
Mark Story
f17eebecf2 Adding CakeRequest and its test case. Moving features from Dispatcher into CakeRequest. 2010-04-29 00:22:32 -04:00
Mark Story
7ea8640b76 Fixing issue where table name was not using fully qualified table names, causing issues with models using table prefixes. Tests added. Fixes #623 2010-04-29 00:22:30 -04:00
ADmad
4efb07b15a Model::deleteAll() now returns false if the 'find' to fetch records ids returns false (in case of sql error). Closes #272 2010-04-29 00:20:35 -04:00
Mark Story
a691edbcff Adding tests for passed arguments with dots when parseExtensions() has been called. Refs #620 2010-04-29 00:20:35 -04:00
Mark Story
e725ae10fa Adding tests for dispatcher to show periods not being removed. Refs #620 2010-04-29 00:20:35 -04:00
Mark Story
0800483407 Adding tests that show that Router is not chopping off periods from passed arguments. Refs #620 2010-04-29 00:20:35 -04:00
Mark Story
57648c5492 Fixing parameters from leaking into the script tag when calling JsHelper::submit(). Added test cases and refactored JsHelper::link(). Fixes #613 2010-04-29 00:20:35 -04:00
Mark Story
33a38118b6 Making tests more accurate to normal use, removing extra params and adding some tests for sortKey. Refs #614 2010-04-29 00:20:35 -04:00
Mark Story
328c58635b Fixing inflection of words ending in analysis. Fixes #619 2010-04-27 23:03:37 -04:00
ADmad
c2bd87144e Adding test case for HtmlHelper::url() showing use of key 'full_base' for parameter. Refs #627 2010-04-27 00:19:01 +05:30
predominant
9243f6601a Merge remote branch 'markstory/2.0' into 2.0 2010-04-26 14:11:07 +10:00
predominant
d5073d7bcf Fixed failing Set tests from Model class visibility. 2010-04-26 12:53:02 +10:00
Mark Story
af6435ece8 Fixing issue where table name was not using fully qualified table names, causing issues with models using table prefixes. Tests added. Fixes #623 2010-04-25 00:22:57 -07:00
Mark Story
46b9e76d8e Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3 2010-04-24 17:34:45 -07:00
Mark Story
ce260debbc Adding tests for passed arguments with dots when parseExtensions() has been called. Refs #620 2010-04-24 17:30:00 -07:00
ADmad
46df1be384 Model::deleteAll() now returns false if the 'find' to fetch records ids returns false (in case of sql error). Closes #272 2010-04-25 02:34:18 +05:30
Mark Story
3e85577c1f Adding tests for dispatcher to show periods not being removed. Refs #620 2010-04-24 10:42:19 -07:00
Mark Story
5f03862f25 Adding tests that show that Router is not chopping off periods from passed arguments. Refs #620 2010-04-24 10:40:15 -07:00
Mark Story
9ddbd6f686 Removing dependancy on Object from CakeSocket. Making tests less dependant on having a network connection. 2010-04-23 21:41:20 -07:00
Mark Story
e8b6d45850 Fixing fatal errors in HttpSocket test case. 2010-04-24 00:31:10 -04:00
Mark Story
a17a38ddf4 Fixing fatal errors in View test.
Removing =& and making tests use instanceof instead of is_object()
2010-04-24 00:22:21 -04:00
Mark Story
35ec5ce2fc Updating test method names and moving parameter modification around. 2010-04-23 23:59:57 -04:00
Mark Story
e111735905 Changing AclBase into AclInterface as it is now an interface.
Splitting the test case into separate test cases for each class.
2010-04-23 23:52:36 -04:00
Mark Story
523eda018e Deprecating AclComponent::revoke() and AclComponent::grant() they were simply aliases that create a larger API with no real benefit. 2010-04-23 23:14:55 -04:00
Mark Story
62982c57b4 Making AclComponent throw exceptions when it encounters an error.
Making AclBase an abstract class.
Adding AclComponent::adapter() for runtime modification of the Acl implementation.
Tests added, updated and fixed.
2010-04-23 23:03:51 -04:00
Mark Story
33a2907202 Adding CakeLogInterface and implementing it in core and test suite classes. The new interface is used for method detection instead of a hard method check. Making CakeLog throw exceptions instead of trigger errors when things go wrong. 2010-04-23 22:31:21 -04:00
Mark Story
4d4d9e78f8 Adding App::setObjects() as a temporary way to modify App's cache of plugins. This allows the DispatcherTest to successfully run. 2010-04-23 22:04:16 -04:00
Mark Story
0a8aafe3c8 Fixing reference to method name. 2010-04-23 22:03:11 -04:00
Mark Story
d926a379b4 Removing params() it was a pretty much useless function, and was deprecated. 2010-04-23 21:32:23 -04:00
Mark Story
84002687c8 Making Security a static class.
Fixing static access issues in test case.
2010-04-23 21:28:54 -04:00
Mark Story
33bfe0e5e2 Making Helper extend Object, this fixes issues where Helpers would not have dispatchMethod or requestAction available.
Correcting JsHelper::call__ into JsHelper::__call
Updating test cases to remove reference operators
2010-04-23 21:21:31 -04:00
Mark Story
9e08196c76 More tests for ajax link delegation. 2010-04-23 21:14:23 -04:00
Mark Story
bf566e1aad Fixing failing tests in PaginatorHelper and moving tests related to JsHelper interaction into a separate test method. 2010-04-23 21:10:23 -04:00
Mark Story
999eb4be7b Fixing illegal access in HtmlHelper tests, replacing with mock object. 2010-04-23 20:51:24 -04:00
Mark Story
8cce38692a Simplifying route configuration failure test case. 2010-04-23 20:42:53 -04:00
Mark Story
0fc106428a Adding exception tossing for invalid cacheengine configuration. 2010-04-23 20:41:29 -04:00
Mark Story
797fa0009a Making Router throw exceptions when invalid route classes are used for routes. 2010-04-23 20:22:02 -04:00
Mark Story
bc6b8e5dfd Fixing parameters from leaking into the script tag when calling JsHelper::submit(). Added test cases and refactored JsHelper::link(). Fixes #613 2010-04-23 00:04:15 -04:00
predominant
f51ce734bf Import Validation from old 2.0 branch. 2010-04-23 12:53:47 +10:00
Mark Story
215333e56f Making tests more accurate to normal use, removing extra params and adding some tests for sortKey. Refs #614 2010-04-22 22:53:36 -04:00
predominant
015872445b Merge remote branch 'origin/1.3' into 2.0
Conflicts:
	cake/console/libs/acl.php
	cake/tests/cases/libs/view/helpers/form.test.php
	cake/tests/cases/libs/view/helpers/javascript.test.php
2010-04-23 12:52:56 +10:00
Mark Story
a92b9000bf Adding tests for non .com domains. Refs #605 2010-04-22 21:37:27 -04:00
José Lorenzo Rodríguez
fca070fe9e Merge branch '1.3' of git@github.com:cakephp/cakephp1x into 1.3
* '1.3' of git@github.com:cakephp/cakephp1x:
  Adding tests for and fixing the behavior of `cake acl initdb` it now correctly delegates to SchemaShell.  Fixes #608
  Making TestTask not depend on Inflection rules for creating directory names,  refs #610
  Adding tests for Inflector::rules() clearing cached values.  Fixes #609
  Clear cache of pluralized, singularized and tableize when set rules.
2010-04-22 16:50:25 -04:30
José Lorenzo Rodríguez
65f01fa31c Fixing model introspection in FormHelper to better take in account realted models with aliased names 2010-04-22 16:37:15 -04:30
Mark Story
568e9d3a89 Adding tests for and fixing the behavior of cake acl initdb it now correctly delegates to SchemaShell. Fixes #608 2010-04-21 23:28:40 -04:00
Mark Story
1d3b653e57 Adding tests for Inflector::rules() clearing cached values. Fixes #609 2010-04-21 22:49:48 -04:00
Mark Story
120fdd9045 Removing other uses of Routing.admin as it has been removed from Router. 2010-04-20 23:43:51 -04:00
Mark Story
a71a8a89b2 Removing support for Routing.admin. Use Routing.prefixes instead. 2010-04-20 23:40:13 -04:00
José Lorenzo Rodríguez
5ceb19304e Merge branch '1.3' of git@github.com:cakephp/cakephp1x into 1.3 2010-04-19 23:33:43 -04:30
José Lorenzo Rodríguez
e1c4b9696b Adding documentation on 'attributes' key for FormHelper::error 2010-04-19 23:32:58 -04:30
José Lorenzo Rodríguez
23eea00a0b Fixing FormHelper::error to no add error names and messages as html attributes. Fixes #585
This introduces the special key 'attributes' to FormHelper::error() when passed in the second parameter
The contents of said key will be converted into html attributes for the error container tag
2010-04-19 23:25:57 -04:30
Mark Story
7bf594ff17 Removing private method access, and removing tests for features that will be removed. 2010-04-19 23:54:09 -04:00
Mark Story
e92e212b8d Fixing Router's constructor.
Adding static visibility to Router methods.
Adding a method for testing Router extensions.
Router::mapResources() now returns the mapped resources
Fixing visibility issues in test cases.
2010-04-19 23:44:45 -04:00
Mark Story
f86d0de5ee Adding test to show correct functioning of containable + field() + recursive = -1. Closes #409 2010-04-19 23:16:59 -04:00
Mark Story
029d2581af Fixing autoFields causing invalid SQL when cross database joins are being done. Tests added. Fixes #476 2010-04-19 22:39:07 -04:00
Mark Story
2bf9504cfb Removing inheritance from Object.
Adding missing visibility keywords, and adding static keywords.
Removing @tags.
2010-04-19 00:10:22 -04:00
Mark Story
9046083dc8 Removing Overloadable and Overloadable2 they are not needed in PHP5.
Removing inheritance and test cases related to Overloadable.
2010-04-18 01:02:39 -04:00
Mark Story
4425743bcd Adding tests for creating cache configs of different types in sequence. Demonstrates error explained in #596. 2010-04-17 18:50:28 -04:00
Mark Story
9ae8b737dc Trimming trailing whitespace. 2010-04-17 13:05:26 -04:00
Mark Story
ae8ace79fa Adding additional tests for JavascriptHelper::object() options. Closes #588 2010-04-17 12:44:04 -04:00
Mark Story
78f14401ca Fixing issue where using delivery = debug and not using sessions would cause a fatal error. send() will now return the contents that would get written into the session. Fixes #595 2010-04-17 12:27:50 -04:00
predominant
92215e1795 Merge remote branch 'origin/1.3' into 2.0
Conflicts:
	cake/libs/inflector.php
	cake/libs/view/helpers/text.php
	cake/libs/view/pages/home.ctp
	cake/tests/cases/libs/view/helpers/time.test.php
2010-04-16 23:43:28 +10:00
predominant
0384ecad30 Removed remaining @filesource lines. 2010-04-16 02:48:47 +10:00
predominant
74d7682707 Fix translation shortcut usage through testing console for updates 2010-04-16 02:38:12 +10:00
Mark Story
17949ff9fc Adding accessor to fix issues in test cases.
Removing check for php4 method name.
2010-04-14 23:36:47 -04:00
Mark Story
50243f3b84 Fixing tests failing because of visibility. 2010-04-14 23:00:22 -04:00
Mark Story
c4d57bd6e7 Removing AjaxHelper and JavascriptHelper as they were deprecated in 1.3 and are replaced by JsHelper + HtmlHelper. 2010-04-14 00:13:33 -04:00
Mark Story
508e0a2d9a Removing all the deprecated PHP4 compatibility functions, and the shortform aliases. Removing associated tests. 2010-04-14 00:01:40 -04:00
José Lorenzo Rodríguez
0300fc1c31 If connection is aborted, now MediaView returns false after stopping the transfer 2010-04-13 16:55:22 -04:30
José Lorenzo Rodríguez
940ce8b06e Adding some test coverage on MediaView.
Now MediaView does not exit after successful render, closes #569
2010-04-13 16:44:14 -04:30
Mariano Iglesias
a6b83cdd93 Fixing issue where TextHelper::autoLinkUrls was failing on some expressions 2010-04-13 15:39:30 -03:00
José Lorenzo Rodríguez
3fc212fe28 Merge branch '1.3' of git@github.com:cakephp/cakephp1x into 1.3 2010-04-13 01:09:42 -04:30
José Lorenzo Rodríguez
9d2819970d Fixing schema generation for postgres. Now character varying without lenght is translated to "text", to avoid sql errors. Closes #564 2010-04-13 01:08:31 -04:30
predominant
4982705d07 More time helper test jiggering. Some peope still experiencing issues. 2010-04-13 15:06:44 +10:00
predominant
df76ff47e3 Fix TimeHelper tests failing due to timezone changes. 2010-04-13 12:20:58 +10:00
Mark Story
404401b4de Moving action modification when a prefix is detected so it affects all url arrays. Previously it was only applied to parameters in the current request. This fixes inconsistencies between request parameters and url parameters. Fixes #570 2010-04-11 23:13:18 -04:00
predominant
4cb06d83ea Fix CakeSession tests so they dont call protected methods. 2010-04-11 15:18:55 +10:00
Mark Story
561e5fa556 Adding an additional test for plugin + prefix routing. 2010-04-10 21:15:56 -04:00
Mark Story
955192a4ca Updating dispatcher tests to reflect changes in default plugin routes.
Removing tests for routes that have been removed.
2010-04-10 21:14:18 -04:00
Mark Story
e1253f0bb5 Including a plugin short route for prefixes as well. There were failing Dispatcher tests relying on this. 2010-04-10 21:12:48 -04:00
predominant
ed02b0f54b Fixing access modifier test on Test task. 2010-04-11 09:40:54 +10:00
predominant
4b919382bb Fix Console Model test to correct index changes for validation. 2010-04-11 09:19:30 +10:00
Mark Story
6c357ee555 Adding tests from 'tfs' fixes inconsistencies in extracting elements with one path selector. Fixes #555 2010-04-10 16:57:50 -04:00
Mark Story
fbaabad6bb Fixing issues where route parameters that overlapped could cause route compilation errors. Tests added. Fixes #565 2010-04-10 11:17:24 -04:00
José Lorenzo Rodríguez
ceb2a1d4ed Removing date_default_timezone_set, as it is only available in php 5+
Hoping for the days were this type of commit is no longer needed
2010-04-09 09:40:27 -04:30
predominant
b22b3b1f41 Fix a bunch of fixture tests testing for access modifiers. 2010-04-09 22:58:06 +10:00
predominant
75c741f5a6 Fix scaffold test on console, replaced 'var' with 'public'. 2010-04-09 22:55:43 +10:00
predominant
14280d6b5f Merge remote branch 'origin/1.3' into 2.0 2010-04-09 22:07:16 +10:00
predominant
90a468bf9f Removing mention of external site from test cases. 2010-04-09 22:06:06 +10:00
predominant
52cdef900b Merge remote branch 'origin/1.3' into 2.0
Conflicts:
	cake/dispatcher.php
	cake/libs/model/behaviors/acl.php
	cake/libs/model/behaviors/containable.php
	cake/libs/model/behaviors/tree.php
	cake/libs/router.php
	cake/tests/cases/libs/validation.test.php
2010-04-09 22:05:00 +10:00
predominant
21f61ee34a Merge remote branch 'origin/1.3' into 1.3 2010-04-09 21:58:25 +10:00
predominant
cb0ae6ed76 Fixed TimeHelper tests. Force setting of timezone to GMT+5 to ensure tests are passing. 2010-04-09 21:20:01 +10:00
predominant
ac81ba75cb Added timezone setting to allow tests to pass in all timezones. 2010-04-09 21:17:55 +10:00
Mark Story
30e6c57a96 Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3 2010-04-08 23:37:27 -04:00
Mark Story
c38249ac28 Updating HtmlHelper + JavascriptHelper to call assetTimestamp() after webroot(). This allows theme files in webroot/theme to be correctly timestamped.
Updating tests to reflect changes in behaviour. Fixes #244
2010-04-08 23:36:04 -04:00
predominant
19b66b8617 Change luhn validation to public. 2010-04-09 13:30:58 +10:00
José Lorenzo Rodríguez
05af213d59 Merge branch '1.3' of git@github.com:cakephp/cakephp1x into 1.3 2010-04-08 22:26:04 -04:30
José Lorenzo Rodríguez
03e3c3249f Removing whitespace at the end of the file 2010-04-08 22:15:49 -04:30
Mark Story
94391d71c2 Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3 2010-04-08 22:41:55 -04:00
Mark Story
9d3a2c61d4 Removing test that is no longer relevant due to changes in Router. 2010-04-08 22:40:45 -04:00
José Lorenzo Rodríguez
7eb3055720 Merge branch '1.3' of git@github.com:cakephp/cakephp1x into 1.3
* '1.3' of git@github.com:cakephp/cakephp1x:
  Adding PluginShortRoute into default connected routes.  Fixes issues with the framework having built in 404s.
  Implementing PluginShortRoute and some tests for its methods.
  Fixing tests that started failing because of removal of short routes on reverse routing.
  Removing plugin shortcuts entirely.
  Adding additional test for plugin shortcut routes including prefixed shortcut routes.
  Updating doc block for Router::__connectDefaultRoutes()
  Removing Dispatcher::_restructureParams() as it is no longer used.
  Moving expectations inline.
  Fixing tests that should have never worked, and removing additional calls to _restructureParams.  Adding in prefixed plugin shortcuts as they were missing.
  Modifying Dispatcher tests to modify private variables (which is bad, but there is no way to change which plugins Router uses to create patterns).  This allows the removal of two calls to _restructureParams.
  Making PluginShortRoute check that the action exists before attempting to proceed. Updated tests.
  Adding doc blocks to PluginShortRoute.  Adding PluginShortRoute into Router.
  Shrinking number of lines in dispatcher test case.
  Adding PluginShortRoute, and a few test cases.
2010-04-08 18:24:24 -04:30
José Lorenzo Rodríguez
59f7cb47d3 Improving test coverage on FormHelper to show the usage of the 'secure' key for inputs.
Fixing issue with select inputs that does not honor the value of 'secure'
2010-04-08 18:23:07 -04:30
Mark Story
4d780ee1f3 Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3 2010-04-08 00:04:14 -04:00
Mark Story
0427fe9777 Merge branch 'no-shortcuts' into 1.3 2010-04-08 00:03:58 -04:00
Mark Story
81dc0d42b9 Adding PluginShortRoute into default connected routes. Fixes issues with the framework having built in 404s.
Adding tests for the default connected routes.
2010-04-08 00:03:46 -04:00
José Lorenzo Rodríguez
7668894888 Fixing error introduced by previous commit 2010-04-07 09:51:29 -04:30
Mark Story
131578cb42 Implementing PluginShortRoute and some tests for its methods. 2010-04-06 23:05:04 -04:00
Mark Story
07efd76b42 Fixing tests that started failing because of removal of short routes on reverse routing. 2010-04-06 22:44:23 -04:00
ADmad
b3f860b762 Adding test case for Validation::url(). Disproves #552 2010-04-07 02:20:05 +05:30
predominant
e4d292bfa4 Merge remote branch 'origin/1.3' into 2.0
Conflicts:
	cake/console/libs/shell.php
	cake/libs/controller/components/acl.php
	cake/libs/controller/components/auth.php
	cake/libs/controller/components/email.php
	cake/libs/controller/components/security.php
	cake/libs/controller/components/session.php
	cake/libs/view/helper.php
	cake/libs/view/helpers/form.php
	cake/libs/view/helpers/html.php
	cake/libs/view/helpers/number.php
	cake/libs/view/helpers/session.php
	cake/libs/view/helpers/text.php
	cake/libs/view/helpers/time.php
	cake/libs/view/helpers/xml.php
2010-04-06 12:19:34 +10:00
Mark Story
518cab91e5 Fixing discrepancy between how belongsTo and hasOne assocations are treated in relation to their fields being added into the queryData. hasOne and belongsTo associations now behave the same. Fixes #379 2010-04-05 21:50:28 -04:00
predominant
51d71b4541 Adjust view __scripts to be a protected instance variable, and add test methods for View addScript tests. 2010-04-05 21:15:17 +10:00
predominant
50a547167b Changing protected methods to specify protected access. 2010-04-05 13:21:28 +10:00
predominant
1497ec3910 Changed all public methods to specify public access. 2010-04-05 13:19:38 +10:00
Mark Story
d990c6ed44 Adding tests for single quoted attributes to assertTags(). Because of the __array_permute works ensuring quotes match is a non-trivial problem. Fixing single quoted attributes not being matchable with assertTags(). Fixes #539 2010-04-04 21:43:29 -04:00
predominant
14b6a7ac5e Fixing access to private and protected variables in Xml class. 2010-04-05 08:57:40 +10:00
Mark Story
bdd8811924 Removing plugin shortcuts entirely. 2010-04-04 16:34:07 -04:00
José Lorenzo Rodríguez
45ccba5d94 Improving virtual fields fetching when the field wildcard selector * in present on the fields array, closes #524 2010-04-04 13:24:39 -04:30
predominant
3039645a17 Fix testing of protected baseConfig in CakeSocket. 2010-04-04 18:34:49 +10:00
predominant
3c2e7a091d Changed access to private __associations on Model to associations() calls. 2010-04-04 18:17:43 +10:00
predominant
97388d2e61 Fixed access to protected property in CakeSession tests. 2010-04-04 17:21:01 +10:00
predominant
850ca02bb6 Changed all public 'var' declarations to be 'public $var' 2010-04-04 17:14:00 +10:00
predominant
329a13fe5f Changed all $_ declared variables to protected. 2010-04-04 16:36:12 +10:00
Mark Story
e57e8f3962 Adding additional test for plugin shortcut routes including prefixed shortcut routes. 2010-04-04 00:21:21 -04:00
Mark Story
87f1972f75 Moving expectations inline. 2010-04-03 23:37:31 -04:00
Mark Story
ed60939292 Fixing tests that should have never worked, and removing additional calls to _restructureParams. Adding in prefixed plugin shortcuts as they were missing. 2010-04-03 23:32:14 -04:00
Mark Story
2814ddc2d5 Modifying Dispatcher tests to modify private variables (which is bad, but there is no way to change which plugins Router uses to create patterns). This allows the removal of two calls to _restructureParams. 2010-04-03 22:24:31 -04:00
Mark Story
95802176bb Making PluginShortRoute check that the action exists before attempting to proceed. Updated tests. 2010-04-03 17:10:39 -04:00
Mark Story
f605454aca Shrinking number of lines in dispatcher test case. 2010-04-03 16:29:36 -04:00
Mark Story
874c511fe2 Adding PluginShortRoute, and a few test cases. 2010-04-03 16:29:20 -04:00
Mark Story
558a9db642 Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3 2010-04-02 15:51:00 -04:00
Mark Story
3503872ab8 Fixing Form::dateTime() for GET forms. Tests added. Fixes #522 2010-04-02 15:50:43 -04:00
ADmad
1b8165d890 Enhancing email component to allow using alias for attachments. Closes #6 2010-04-03 00:37:02 +05:30
Mark Story
e6f9c420b6 Removing transactional property from the Set test, as it was removed from the Model in the last commit. Ref #531 2010-04-02 13:55:05 -04:00
Mark Story
d058234c1c Adding tests to PaginatorHelper::sort() for creating sort links that point at plugin shortcuts. Refs #535. 2010-04-02 13:43:03 -04:00
Mark Story
ffb5c36578 Adding tests for plugin shortcut route generation. Refs #535 2010-04-02 13:32:14 -04:00
ADmad
d92202c6da Fixed controller test case which generated a property undefined notice 2010-04-02 00:01:06 +05:30
Mark Story
176c12e5fe Adding tests for creating directories with trailing slashes. Closes #520 2010-03-30 22:35:49 -04:00
José Lorenzo Rodríguez
75900883e6 Making DboPostgres::value() return NULL when given an empty array, as DboMysql does 2010-03-30 00:01:33 -04:30
José Lorenzo Rodríguez
bbf96567eb Using value() in default value generation with CakeSchema and DboPostgres 2010-03-29 23:50:40 -04:30
predominant
84ad35ca7a Added test for XML Helper serialization. Refs #284 2010-03-29 12:21:14 +11:00
Mark Story
068631ebe2 Fixing AclNode::node() so that node expressions that could match deeper elements are contained to their parent elements. Test added. 2010-03-28 16:59:24 -04:00
ADmad
d365fafe4d Changed default value for option 'validate' to 'first' in Model::saveAll(). Also fixed issue where the return array contained more keys then number of records in data array itself with options 'validate =>'first' and 'atomic'=>false 2010-03-28 05:29:42 +05:30
Mark Story
7b28fdec85 Fixing Security::cipher() not being able to correctly decrypt numeric values. Fixes #513 2010-03-27 17:19:42 -04:00
Mark Story
1210a4f598 Fixing whitespacing. 2010-03-27 16:28:59 -04:00
Mark Story
8ab5abe852 Merge remote branch 'origin/1.2' into 1.3 2010-03-27 16:28:00 -04:00
Mark Story
3040c6f586 Moving tests around in set test. 2010-03-27 16:27:23 -04:00
Mark Story
35446a42a9 Making filtering of extracted arrays remember their key. This fixes attribute selectors followed by parent selectors returning seemingly random results. Fixes #502 2010-03-27 16:23:46 -04:00
Mark Story
3075eda8b6 Merge remote branch 'origin/1.2' into 1.3 2010-03-27 14:30:27 -04:00
Mark Story
b559be5822 Moving xml_parser_free() so parser resources are freed immediately after they are used. Helps reduce memory consumption in Xml class. Refs #505 2010-03-27 12:48:31 -04:00
Mark Story
0c29fd0094 Merge remote branch 'origin/1.2' into 1.3
Conflicts:
	cake/libs/cake_session.php
	cake/libs/controller/components/session.php
	cake/libs/model/model.php
	cake/libs/router.php
2010-03-27 11:48:49 -04:00
predominant
9bd0960cf1 Merge remote branch 'origin/1.3' into 1.3 2010-03-26 20:36:04 +11:00
predominant
0dfc07ba0d Fixes #53, ordering of XML::toArray() operations. 2010-03-26 20:30:17 +11:00
predominant
ec3f4b8d34 Fixes #53, ordering of XML::toArray() operations. 2010-03-26 19:59:09 +11:00
Mark Story
888fdd3dd5 Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3 2010-03-25 23:44:53 -04:00
Mark Story
d20aa23711 Fixing issues where paths added to build() would be appended into the search paths after the default paths.
Fixed issue where paths added with build() would be lost when calling build() again to change a different path type.
Tests updated.
Fixes #410
2010-03-25 23:44:40 -04:00
predominant
5d3f0d7fe0 Fix for Session Component to use CakeSession started() checks. Refs #332. 2010-03-26 14:36:40 +11:00
predominant
9f5949ab52 Fix for Session Component to use CakeSession started() checks. Refs #332. 2010-03-26 14:29:27 +11:00
José Lorenzo Rodríguez
41734503a6 Merge branch '1.3' of git@github.com:cakephp/cakephp1x into 1.3
* '1.3' of git@github.com:cakephp/cakephp1x:
  Supporting Model.* syntax on postgres.
  Changing variable $title to $title_for_layout. Closes #511

Conflicts:
	cake/tests/cases/libs/model/datasources/dbo/dbo_postgres.test.php
2010-03-25 16:08:58 -04:30
José Lorenzo Rodríguez
1f1324f500 Qouting fields inside postgres functions when prepended a DISTINCT, closes #512 2010-03-25 16:05:45 -04:30
renan.saddam
dd4ad2f83d Supporting Model.* syntax on postgres. 2010-03-25 17:33:34 -03:00
Mark Story
4f4d3f9ffe Fixing extraction of non-zero arrays with only one element and attribute selectors. Fixes #475 2010-03-24 23:25:02 -04:00
Mark Story
cbb65ca85f Moving failing test into new method for non-zero array extraction. 2010-03-24 22:36:38 -04:00
Jimmy Bourassa
e8e520d6f2 Added test case for a bug in Set::extract
Signed-off-by: Mark Story <mark@mark-story.com>
2010-03-24 22:34:41 -04:00
Mark Story
9d3f2fb4a7 Moving Non-Zero tests for Set::extract() into a separate method. 2010-03-24 22:33:51 -04:00
Mark Story
9334aeabc2 Adding tests for loading helpers off of additional paths. Closes #410 2010-03-24 22:11:53 -04:00
Mark Story
3883f728fb Adding tests for Fixture importing. Fixing importing fixtures for databases that require custom fields handling like postgresql. Fixes #481 2010-03-22 23:28:58 -04:00
Mark Story
817ebf5ec8 Merge remote branch 'ceeram/1.3-467' into 1.3 2010-03-21 20:41:54 -04:00
Juan Basso
5e8665cd8d Allowing routes to set an extension when Router::parseExtension() is
being used.  Fixes #492

Signed-off-by: Mark Story <mark@mark-story.com>
2010-03-20 19:23:48 -04:00
Ceeram
6d13f0d3d1 added test for ticket #469
Signed-off-by: Mark Story <mark@mark-story.com>
2010-03-20 18:22:42 -04:00
Ceeram
7337c12f4f test for ticket #467 2010-03-19 01:48:28 +01:00
ADmad
6a723bb515 Type casting conditions array to avoid warning during array merge in Model::_deleteDependent(). Fixes #477 2010-03-18 02:51:55 +05:30
José Lorenzo Rodríguez
0f876e1a1b Merge branch 'saveAll' into 1.3
* saveAll:
  Making saveAll() behave like plain save() when suplied empty data array, closes #277
2010-03-17 16:40:26 -04:30
José Lorenzo Rodríguez
5c186d4430 Making saveAll() behave like plain save() when suplied empty data array, closes #277 2010-03-17 15:19:30 -04:30
José Lorenzo Rodríguez
28cb57a92c Fixing bug in Model::escapeField() where it would return the wrong string id the datasource's name method returs the unmodified string.
Tests added. Closes #473
2010-03-17 10:32:36 -04:30
AD7six
bc990f41e3 Prevent sql error for uuids if id is specified as null
if the primary key is present in the data to be saved as null - prevent
passing the same key (id) twice and therefore triggering an sql error.

Signed-off-by: Mark Story <mark@mark-story.com>
2010-03-16 22:57:37 -04:00
José Lorenzo Rodríguez
cceb568520 Skiping some test in model_write test when using postgres as there is no way yet to do joins inside an update statement.
Possible enhancement would be transforming the join conditions into subquerys
2010-03-16 18:46:04 -04:30
José Lorenzo Rodríguez
c51f4076f7 Forcing order on find('all') in test. It is not safe to asume returned row order in postgres 2010-03-16 17:00:20 -04:30
José Lorenzo Rodríguez
201a952218 Fixing test for postgresql, it is no safe to asume the order of the returned results of a joined table 2010-03-16 15:12:27 -04:30
AD7six
0c951b7248 Prevent sql error for uuids if id is specified as null
if the primary key is present in the data to be saved as null - prevent
passing the same key (id) twice and therefore triggering an sql error.

Signed-off-by: Mark Story <mark@mark-story.com>
2010-03-15 23:32:46 -04:00
Mark Story
4861da66ed Merge remote branch 'origin/1.2' into 1.2-merger
Conflicts:
	cake/tests/cases/libs/model/datasources/dbo/dbo_postgres.test.php
2010-03-15 23:26:24 -04:00
Mark Story
661fcd32ab Fixing failing tests in PostgreSQL cause by invalid datatype comparisons and missing id fields. 2010-03-15 23:07:18 -04:00
Mark Story
ea64588a81 Adding tests from 'Stephen Cuppert' to test incorrectly generate DELETE queries for habtm join tables that do not have a primary key when using PostgreSQL. Updating DboSource::_matchRecords() to only query the table if the supplied conditions are actually multi-table conditions. Fixes #459 2010-03-15 22:55:14 -04:00
Mark Story
3ab687043e Updating DboPostgres test to reflect changes in test suite. 2010-03-14 19:27:36 -04:00
ADmad
70d0c64283 Removing constant REQUEST_MOBILE_UA, and added variable $mobileUA instead for mobile browser detection. Also added new user agent string 'webOS', closes #457 2010-03-15 01:58:38 +05:30
Mariano Iglesias
1120d0daff Fixing issue in Containable where if bindModel was used to add / change a binding not permanently, Containable was making the change permanent 2010-03-14 16:37:50 -03:00
Mariano Iglesias
8d58b40642 Fixing issue in Containable where if bindModel was used to add / change a binding not permanently, Containable was making the change permanent 2010-03-14 16:34:57 -03:00
Mark Story
a51cceab18 Merge branch 'dbo-source-cache' into 1.3 2010-03-14 15:11:48 -04:00
Mark Story
5ec965830c Fixing issues caused by daylight savings time switch. 2010-03-14 13:20:52 -04:00
Mark Story
78f347afd7 Fixing SchemaShell test, was failing due to a model in the test_app changing. 2010-03-14 13:06:22 -04:00
Mark Story
c059cf5175 Implementing cacheMethod(). Helps to solve #458, as it provides features to control and clear method caches. 2010-03-13 22:55:18 -05:00
Mark Story
49c60658b9 Fixing the ability to use regular expressions for validation rules. Fixes #453 2010-03-13 19:44:20 -05:00
ADmad
688daf2c35 Allowing the default transliteration map used in Inflector::slug to be customized using Inflector::rules. Closes #321, #334, #439. 2010-03-14 02:22:46 +05:30
Mark Story
178099d15b Adding test that closes #455 2010-03-13 00:26:23 -05:00
Mark Story
028668b7a6 Adding condition for counterCache update keys. Fixes issues where counter cache wouldn't be updated. Fixes #450 2010-03-13 00:18:51 -05:00
Mark Story
e304c48ec4 Adding test to show that select() doesn't always auto select options named 'Array'. Disproves #412 2010-03-12 23:17:11 -05:00
Mark Story
677ff2d8b7 Removing outcommented code. 2010-03-12 23:03:06 -05:00
Mark Story
8e8acfaccd Fixing notice errors when bogus validation options are selected. Refs #453 2010-03-12 22:58:14 -05:00
Mark Story
239e34f032 Merge branch '1.2' of github.com:cakephp/cakephp1x into 1.2 2010-03-10 21:49:55 -05:00
Mark Story
64c627a352 Adding checks to force limit to always be a positive integer. Fixes potential out of bounds type queries with paginate(). Fixes #418 2010-03-10 21:49:22 -05:00
Mark Story
4c668c036c Adding checks to force limit to always be a positive integer. Fixes potential out of bounds type queries with paginate(). Fixes #418 2010-03-10 21:46:28 -05:00
José Lorenzo Rodríguez
d8a757ce75 Fixing empty value check to avoid a mistaken default value selection in Helper::value. closes #290 2010-03-10 15:16:02 -04:30
Dieter Plaetinck
9a9bc3643b fix typo in DboPostgresTestDb::testOrderAdditionalParams() 2010-03-10 14:34:17 -04:30
José Lorenzo Rodríguez
cbcd394d0b Fixing alter schema queries generated for Postgres, which dos not support altering column type, nullable and default value at the same time 2010-03-09 16:09:16 -04:30
José Lorenzo Rodríguez
acccf964a5 Fixing some tests for Postgres Dbo and adding test cverage for extra params in order function, closes #353 2010-03-09 15:24:03 -04:30
Mark Story
af317a107b Fixing issues in Set::combine() when data or paths used result in empty datasets. Tests added. Fixes #414 2010-03-08 23:07:36 -05:00
Mark Story
bed4027d37 Making JsHelper::writeBuffer() use the isAjax param to hint the domReady() event. Disabling domready events when the request isAjax fixes issues in prototype and makes output code simpler. Fixes #429 2010-03-08 22:51:46 -05:00
predominant
2218d186c8 Revert "Fixing escaping of forward slash for JS Engines."
This reverts commit 7334fdfbdf.
2010-03-09 14:30:28 +11:00
predominant
7d81d81176 Merge remote branch 'origin/1.3' into 1.3 2010-03-09 12:28:06 +11:00
predominant
7334fdfbdf Fixing escaping of forward slash for JS Engines. 2010-03-09 12:26:25 +11:00
Mark Story
e6664f0ea4 Fixing SQL errors when running model_behavior tests with postgresql. Fixes #406 2010-03-07 19:02:19 -05:00
Mark Story
1ae922cea1 Fixing missing reference operators in test cases. 2010-03-05 22:06:20 -05:00
Mark Story
af92276ba9 Adding missing reference operators to getInstance methods. 2010-03-05 21:41:48 -05:00
Mark Story
7b83c45168 Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3 2010-03-05 21:31:10 -05:00
Mark Story
220fba9bba Fixing inflection of parameters when using bake. Model, View, Controller, and Fixture tasks all accept either singular or plural forms of the table name. Fixes #425 2010-03-05 21:30:58 -05:00
José Lorenzo Rodríguez
e4a5ca528c Fixing virutal fields fetching for postgresql, closes #417 2010-03-05 16:07:59 -04:30
Mark Story
1d449e3847 Refactoring label generation into a method.
Fixing issues with labels having a for attribute = Array when an array of id's is provided.
Fixing issues where a date input would require you to provide id keys for hour, minute, and meridian even if you were not using them.
Fixes #411
2010-03-04 22:46:43 -05:00
Mark Story
f8cb20e994 Passing interactive property to inner tasks. Inner tasks now share the parent interactive setting making things more consistent. Fixes #423 2010-03-04 22:02:49 -05:00
Mark Story
d4393e9058 Fixing path generation in BakeTask.
Removing name properties as they were causing troubles.
All BakeTasks are now interactive = false by default.  This makes interfaces more consistent when working with bake.  Refs #423
Tests updated.
2010-03-04 21:57:48 -05:00
predominant
382e11ccde Changed Configure::write to return true on success. Maked testing result simpler. 2010-03-04 10:20:15 +11:00
hiromi2424
256ce41b1f LC_TIME support multi-byte value. 2010-03-02 23:51:22 -04:30
Mark Story
3b3987de7f Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3 2010-02-28 13:52:02 -05:00
Mark Story
65169971d4 Making memory leak test work with margins present in php5.3.1 2010-02-28 13:51:47 -05:00
Mark Story
428ee1998a Updating paths so app layout doesn't break tests. 2010-02-28 13:44:04 -05:00