Commit graph

7504 commits

Author SHA1 Message Date
mark_story
0180daaad3 Updating version numbers to 1.3.1 2010-05-29 13:26:34 -04:00
mark_story
dea33f6452 Fixing pass by reference errors in php5.3. Fixes #451 2010-05-29 13:19:12 -04:00
mark_story
7cde3094f0 Removing trim() that was performed when reading a file with a lock() enabled. This was causing a failure in php5. 2010-05-29 12:50:42 -04:00
mark_story
25a6a3cac8 Correcting spacing in file test.
Correctly constructing a File object, so testRead does not rely on the previous test to leave the object in the correct state.
2010-05-29 12:47:31 -04:00
renan.saddam
c96d074722 Merge branch '1.3' of github.com:cakephp/cakephp into 1.3 2010-05-29 12:23:04 -03:00
renan.saddam
8f5112b8d7 Changing break; to continue; so it will process the next tables on the array, tests added. 2010-05-29 12:22:16 -03:00
predominant
8decc683ac Numerous 'shoer description' documentation entries updated to contain useful comments. 2010-05-30 01:20:28 +10:00
predominant
f63f15812e Merge remote branch 'origin/1.3' into 1.3 2010-05-30 01:13:40 +10:00
predominant
f06f0dae8b Numerous "Enter description here" block comments updated to have meaningful descriptions. 2010-05-30 01:10:48 +10:00
Juan Basso
e02cb81a67 Reading a smtp response until EOL. Fixes #378 2010-05-29 12:04:29 -03:00
mark_story
8b6c974cd0 Making FileEngine not greedily clear files in a directory that may belong to another cache configuration. Tests added. Fixes #754 2010-05-27 00:01:17 -04:00
José Lorenzo Rodríguez
a737b77a89 Fixing bridged method assertIdentical. The corrent interpretetion in PHPUnit was assertEquals and not assertSame, as the former is to assert references to the same object 2010-05-26 23:22:58 -04:30
mark_story
0dc627178a updating helper and component tests for controller task to use phpunit. 2010-05-26 23:01:14 -04:00
mark_story
e4ccaba3e0 Adding a filter GET parameter which allows you filter which test methods get run. It accepts preg_match() compatible patterns. 2010-05-26 22:21:34 -04:00
mark_story
8ac46c3b63 Adding return from _stop() to help testing.
Updating tests for getName()
2010-05-26 21:59:56 -04:00
mark_story
9647e359c4 First test passing for controllertask test 2010-05-25 23:54:28 -04:00
mark_story
08bcf55b8d Starting to convert controller task test to phpunit. 2010-05-25 23:51:48 -04:00
mark_story
cd255d5031 Merge branch '1.3' of github.com:cakephp/cakephp into 1.3 2010-05-25 23:08:06 -04:00
Martin Radosta
64adfacd3e Making DboSource::order() accept an expression object. Fixes issues with
sql parsing over quoting special SQL syntax. Tests added.  Fixes #747

Signed-off-by: mark_story <mark@mark-story.com>
2010-05-25 23:07:29 -04:00
Juan Basso
bc3e745673 Support to EHLO in SMTP server for EmailComponent. Fixes #54, #712, #737 2010-05-24 22:24:58 -03:00
Juan Basso
2d44929598 Optimization on dbo datasource to not repeat ids in find. Fixes #601
Signed-off-by: mark_story <mark@mark-story.com>
2010-05-23 17:22:55 -04:00
mark_story
66699df9a0 Updating Shell.test to use PHPUnit. There may still be some errors with the windows tests as I don't have access to windows at this time. 2010-05-23 14:52:46 -04:00
mark_story
265609dfc1 Moving test to work with PHPUnit.
Fixing incorrect count amount in SchemaShell.
2010-05-23 00:17:22 -04:00
mark_story
81c2169b0b Fixing BakeShell test for PHPUnit. Mock expectation numbers are off due to some oddities in PHPUnit. 2010-05-22 22:40:18 -04:00
mark_story
0436e938cd Fixing typo in class name. 2010-05-22 22:39:46 -04:00
mark_story
89a8ef3871 Updating API shell to use reflection as the regular expression was not working with visibility keywords.
Updating tests for changes in output.
Updating tests to work with PHPUnit.
2010-05-22 22:09:07 -04:00
mark_story
1955b0fb1f Updating Acl cli tool test case to use PHPUnit mock objects. 2010-05-22 20:21:27 -04:00
mark_story
b73870c33d Removing reference operators in the AclComponent. 2010-05-22 20:20:41 -04:00
ADmad
7d51952801 Removing protected var CakeSession::_started and instead session_id() is now used to check if session is started in CakeSession::started(). This fixes issue where CakeSession::started() returned incorrect value when used across multiple objects. Closes #731 2010-05-23 02:14:07 +05:30
mark_story
1c36c1f088 Updating ShellDispatcher test case to use PHPUnit mock objects. 2010-05-22 13:10:01 -04:00
mark_story
326f33f9c6 Adding wrapper for assertIsA() assertion in simpletest. 2010-05-22 13:09:17 -04:00
mark_story
cd4e63423d Exposing Object::_set() as a public method for testing and updating tests. There are still several fails caused by _persist(). 2010-05-22 11:28:22 -04:00
tarcisio
06c1b583f8 fix typo in CakeLog::config()
Signed-off-by: mark_story <mark@mark-story.com>
2010-05-22 10:49:37 -04:00
mark_story
29f2223c6d Removing hardcoded '__' for virtualField separators. Making it an instance property instead. This allows the customization of the separator if needed. Tests added for DboMysql. Refs #655, #730 2010-05-22 00:58:54 -04:00
mark_story
23d4bafd39 Fixing inflection of words ending in causes. Fixes #736 2010-05-21 23:49:49 -04:00
mark_story
78653347b2 Removing request time output from index.php. Makes non sgml requests like json easier to do. Fixes #720 2010-05-20 23:13:45 -04:00
mark_story
82250efc3e Updating doc blocks for FormHelper::input() refs #735 2010-05-20 22:58:20 -04:00
mark_story
94ac914426 Changing Router::$__validExtensions so Router::extensions() always returns an array like the doc block says.
Updating test cases for PHPUnit.
2010-05-20 22:55:25 -04:00
mark_story
df6989e3d6 Fixing Sanitize test to run under PHPUnit. 2010-05-20 22:50:06 -04:00
mark_story
0759c0b462 Removing trailing whitespace. 2010-05-20 22:49:50 -04:00
mark_story
7cef278ce2 Fixing missing boolean return in Validation::cc()
Fixing Validation test case to pass under PHPUnit.
2010-05-20 22:30:47 -04:00
predominant
6a18b2bc1d Merge remote branch 'origin/1.3' into 2.0
Conflicts:
	cake/basics.php
	cake/console/libs/shell.php
	cake/console/libs/tasks/controller.php
	cake/libs/controller/components/request_handler.php
	cake/libs/model/model.php
	cake/libs/model/model_behavior.php
	cake/libs/overloadable.php
	cake/libs/overloadable_php4.php
	cake/libs/overloadable_php5.php
	cake/libs/sanitize.php
	cake/libs/validation.php
	cake/libs/view/helpers/ajax.php
	cake/libs/view/helpers/javascript.php
	cake/libs/view/pages/home.ctp
	cake/tests/cases/console/libs/tasks/controller.test.php
	cake/tests/cases/libs/overloadable.test.php
	cake/tests/cases/libs/validation.test.php
	cake/tests/cases/libs/view/helpers/ajax.test.php
	cake/tests/cases/libs/view/helpers/javascript.test.php
	cake/tests/test_app/libs/cache/test_app_cache.php
	cake/tests/test_app/plugins/test_plugin/libs/cache/test_plugin_cache.php
	cake/tests/test_app/plugins/test_plugin/models/test_plugin_auth_user.php
	cake/tests/test_app/plugins/test_plugin/models/test_plugin_post.php
2010-05-20 12:22:04 +10:00
predominant
3a81a9e6f2 Remove unnecessary spaces. 2010-05-20 12:17:52 +10:00
José Lorenzo Rodríguez
625d120d74 Migrating MultibyteTest to phpunit 2010-05-19 00:20:21 -04:30
José Lorenzo Rodríguez
1fa430c609 Migrating SetTest to phpunit 2010-05-19 00:16:32 -04:30
José Lorenzo Rodríguez
e60cc99034 Migrating SecurityTest to phpunit 2010-05-19 00:15:35 -04:30
José Lorenzo Rodríguez
bcc3321bd3 Migrating SetTest to phpunit 2010-05-19 00:12:13 -04:30
José Lorenzo Rodríguez
f1eaec11f5 Migrating StringTest to phpunit 2010-05-19 00:05:49 -04:30
José Lorenzo Rodríguez
50021ee646 Merge branch '2.0-phpunit' of git@github.com:cakephp/cakephp into 2.0-phpunit 2010-05-18 23:57:41 -04:30
José Lorenzo Rodríguez
103d5c2505 Partially migrated JsHelperTest to phpunit 2010-05-18 23:56:50 -04:30
mark_story
07c957e827 Making PaginatorHelper test run under PHPUnit. 2010-05-19 00:14:37 -04:00
Robert Sworder
385ceb434e When using Digest Authentication the passwords do not need to be md5 hashed. Removed incorrect comment.
Fixes #733

Signed-off-by: mark_story <mark@mark-story.com>
2010-05-18 22:19:33 -04:00
Juan Basso
a94b9ee95b Update various links. Closes #392 2010-05-18 22:15:13 -03:00
José Lorenzo Rodríguez
3f881aee35 Fixing message for completed test cases 2010-05-17 23:44:08 -04:30
José Lorenzo Rodríguez
d3837ba7b0 Merge branch '2.0-phpunit' of git@github.com:cakephp/cakephp into 2.0-phpunit 2010-05-17 22:37:12 -04:30
José Lorenzo Rodríguez
327d42d6de Fixing CacheHelperTest for phpunit 2010-05-17 22:35:54 -04:30
José Lorenzo Rodríguez
d7803dc7bf Implementing skipped tests message in html reporter 2010-05-17 22:31:22 -04:30
José Lorenzo Rodríguez
f7949d6ace Fixing FormHelperTest for phpunit 2010-05-17 22:30:04 -04:30
mark_story
3a60aa07de Fixing issues where setting jQueryObject did not affect request() and its connected methods.
Tests added.
Fixes #728
2010-05-17 18:25:50 -04:00
mark_story
cd5aee1bfa Applying patch from 'franiglesias'. Fixes issues where str_replace would greedily replace too many occurences of 'libs/'. Fixes #724 2010-05-16 23:50:17 -04:00
mark_story
4915645fb1 Applying patch from 'Daren Thomas' fixes issues where sorting on virtualFields did not work properly when using aliased sort link keys. Tests added. Fixes #680 2010-05-16 23:42:14 -04:00
mark_story
6c2fe39bc0 Changing how the cursor appears. 2010-05-16 12:34:39 -04:00
José Lorenzo Rodríguez
32a46e9eda Converting HtmlHelperTest to phpunit 2010-05-15 21:05:22 -04:30
Mark Story
353c600cd7 Removing unreachable code. Fixes #614 2010-05-13 23:38:26 -04:00
Mark Story
a29866b7fb Updating test for 1.3 2010-05-13 23:09:23 -04:00
Mark Story
3d98cc6f53 Adding tests for welsh added in previous commit. 2010-05-13 23:08:32 -04:00
Mark Story
046c233a34 Adding Welsh to the supported lists of locales in l10n. Thanks to 'DanAbel' for the 'patch'. Fixes #714 2010-05-13 22:13:59 -04:00
Mark Story
67e32e292d Additional refactoring in the coverage classes. 2010-05-13 21:51:59 -04:00
Mark Story
9303de936e Fixing fatal error trying to run coverage on the coverage reporter.
Removing old CodeCoverageManager implementation.
2010-05-13 21:44:30 -04:00
Mark Story
e76c05b2b9 Merge branch '2.0-coverage' into 2.0-phpunit 2010-05-13 21:39:23 -04:00
Mark Story
5e29cfc21e Adding TextCoverageReport and extracting a base class.
Updating the coverage classes to use the new class structure.
2010-05-13 21:36:23 -04:00
Juan Basso
db4f7a2625 Fixing search of test cases and groups for PHP 5.2. 2010-05-13 18:48:34 -03:00
José Lorenzo Rodríguez
689e46be4f Converting ConfigureTest to phpunit 2010-05-13 00:52:38 -04:30
José Lorenzo Rodríguez
f3f37a126f Converting CakeSocketTest to phpunit 2010-05-13 00:50:30 -04:30
José Lorenzo Rodríguez
01e36ce2c4 Improving compatobility method detection in paintError, so the failing line and method is correctly pointed out in the reporter 2010-05-13 00:48:03 -04:30
José Lorenzo Rodríguez
72959e7872 Converting CAkeSessionTest to phpunit 2010-05-13 00:21:16 -04:30
José Lorenzo Rodríguez
6613cfb662 Migrating CacheTest to phpunit 2010-05-13 00:13:40 -04:30
José Lorenzo Rodríguez
c1dc753be5 Replacing call of static:: for self as it is php 5.3 specific 2010-05-13 00:08:35 -04:30
José Lorenzo Rodríguez
3e3817f113 Merge commit 'mark/2.0-coverage' into 2.0-phpunit
Conflicts:
	cake/tests/lib/reporter/cake_html_reporter.php
2010-05-13 00:05:30 -04:30
José Lorenzo Rodríguez
8c3df122eb Merge commit 'lorenzo/2.0-phpunit' into 2.0-phpunit
Conflicts:
	cake/tests/lib/reporter/cake_html_reporter.php
	cake/tests/lib/test_manager.php
2010-05-12 23:58:56 -04:30
Mark Story
17f338a9b2 Moving methods up into CakeBaseReporter.
Starting to make CakeTextReporter work well with PHPUnit so the Text code coverage reporting can be implemented.
2010-05-13 00:18:22 -04:00
Mark Story
d349551dd7 Adding tests for generating method coverage with the reporter.
Adding method visibility
2010-05-12 22:43:44 -04:00
Mark Story
cb9d6f478d Making coverage reports show what tests covered the line being hovered over. Updating CSS to help facilitate hover effects. 2010-05-12 22:13:12 -04:00
Mark Story
79839c07d2 Fixing issues where ModelBehavior::detach() would not detach behaviors when a plugin.name was provided. This change makes detach() work like attach(). Tests added. Fixes #711 2010-05-11 23:08:14 -04:00
Mark Story
0648c6604b Adding some additional tests for possible php4 compatibility issues. 2010-05-11 23:01:40 -04:00
Mark Story
6add43a4bc Fixing issue where id = null could cause SQL errors when saving more than one record with a null id. Fixes #675 2010-05-11 22:40:56 -04:00
ADmad
3539660cd0 Space is now properly added inbetween when 'asc'/'desc' class is appended to user defined css class in PaginatorHelper::sort. Fixes #710 2010-05-12 00:42:02 +05:30
Mark Story
6e355312bb Fixing issue where Config.timeout wouldn't correctly countdown when many quick requests were sent. 2010-05-11 00:39:10 -04:00
Richard Sbresny
05beaab272 Removed unnecessary unset
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:14:38 -04:00
Richard Sbresny
b04a3f8514 Switched over to using the previously unused Security::inactiveMins() method for getting timeout modifiers
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:14:20 -04:00
Richard Sbresny
5cf08cbe92 Updated default values to reflect the static values previously set
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:12:15 -04:00
Richard Sbresny
c62ae5e48a Included timeout multiplier factor to be used not just inside a session start
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:11:44 -04:00
Richard Sbresny
a4950f6940 Updated session timeout calculations to use the security level from core.php as the multiplier.
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:11:20 -04:00
Mark Story
96d0119abc Applying patches from 'wals' to fix uses where incorrect parameters were being passed into methods, and making methods match their documentation blocks. Fixes #668 2010-05-10 23:58:22 -04:00
Robert Sworder
ec10a01504 Changing home.ctp to remove references to 1.2. Fixes #705
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-10 23:48:12 -04:00
Mark Story
91a40a0104 Making null check explicit so falsey default values can be used. Fixes #695 2010-05-10 23:46:47 -04:00
predominant
8f880731c6 Removing closing PHP tags. 2010-05-11 08:27:28 +10:00
predominant
1ec220dac2 Removing closing PHP tags. 2010-05-11 08:07:49 +10:00
Mark Story
687eab9528 Adding a toggle all button to the coverage report. Makes it easier to see the test subject at a glance.
Adding ability to only show files that match the extension-less basename of the test case file.  This hides much of the noise the new reports have.
2010-05-09 23:20:28 -04:00
Mark Story
e8e2235cfa Updating coverage report and tests to include hiding javascript. 2010-05-09 22:15:20 -04:00
José Lorenzo Rodríguez
765de657e6 Fixing PaginatorHelperTest to be compatible with PHPUnit 2010-05-09 18:49:04 -04:30
José Lorenzo Rodríguez
1e01e21bf9 Impriving the default for expectExpection 2010-05-09 18:48:39 -04:30
José Lorenzo Rodríguez
bc9479efcf Fixing XmlTest to be compatible with PHPUnit 2010-05-09 18:18:40 -04:30
José Lorenzo Rodríguez
508d707a7a Adding another compatibility test method: assertWithinMargin 2010-05-09 18:16:42 -04:30
José Lorenzo Rodríguez
88d21fbea4 Experimental change: restoring the error handler to steps back in the stack to let PHPUnit take over when running tests 2010-05-09 18:15:51 -04:30
José Lorenzo Rodríguez
809550087c Finxing ThemeTest to be compatible with PHPUnit 2010-05-09 16:27:09 -04:30
José Lorenzo Rodríguez
c96b14541d Adding new compatibility method for CakeTestCase 2010-05-09 16:09:57 -04:30
José Lorenzo Rodríguez
d252fdeb52 Fixing View test case to be compatible with PHPUnit 2010-05-09 16:09:02 -04:30
Mark Story
f084a82dfc Refactoring how coverage diffs are generated to better use data from phpunit. Removing methods made redundant by data changes. 2010-05-09 12:30:55 -04:00
Mark Story
ac318faf5a Switching back to using non raw code coverage data as it has been filtered by phpunit's filters. combining the data from phpunit into a singular cohesive report. 2010-05-09 02:08:32 -04:00
Mark Story
3c3655aefd Fixing failing tests. 2010-05-09 01:16:44 -04:00
Mark Story
75d7146bd0 Updating code coverage tools to use raw data which includes dead and uncovered line data. 2010-05-09 01:15:57 -04:00
Mark Story
9a20a2344b Continuing work on updated code coverage reports. 2010-05-09 00:40:05 -04:00
Mark Story
955c6bea9f Verbose coverage generation has been added and tests added. 2010-05-09 00:04:03 -04:00
José Lorenzo Rodríguez
b8e83e6a49 Adding documentation for CakeFixtureManager 2010-05-08 17:50:55 -04:30
Mark Story
f6b49cd865 Updating file headers. 2010-05-08 18:12:20 -04:00
Mark Story
ccf5601a69 Updating coverage report initialization. 2010-05-08 18:12:03 -04:00
Mark Story
fad99ad1f4 Adding tests for merging of report data. 2010-05-08 18:08:02 -04:00
José Lorenzo Rodríguez
f5cfc325f8 Adding some missing doc blocks 2010-05-08 17:29:33 -04:30
Mark Story
ac5f731940 Starting work on HtmlCoverageReport and adding a test case. 2010-05-08 17:59:14 -04:00
José Lorenzo Rodríguez
79c001197d Merge commit 'mark/2.0-phpunit' into 2.0-phpunit
Conflicts:
	cake/tests/lib/test_manager.php
2010-05-08 17:18:43 -04:30
José Lorenzo Rodríguez
72f162f52a Adding docs to CakeTestSuite 2010-05-08 16:52:29 -04:30
Mark Story
fd073809d0 Removing references to non phpunit code coverage parsing.
Adding stub of new code coverage report generator.
Updating related files.
2010-05-08 17:14:47 -04:00
José Lorenzo Rodríguez
fb09adca68 Adding tests for skipIf 2010-05-08 16:36:11 -04:30
José Lorenzo Rodríguez
4d3a6e8ca6 Fixing and testing for CakeTestCase::loadFixtures() 2010-05-08 16:14:22 -04:30
José Lorenzo Rodríguez
2b5cd26fc6 Adding tests for CakeTestCase fixtures 2010-05-08 15:56:21 -04:30
José Lorenzo Rodríguez
5d041c58b7 Using the CakeTesSuite in TestManager and calling accordingly the load and unload of fixtures using the variable
$sharedFixture
2010-05-08 15:55:16 -04:30
José Lorenzo Rodríguez
ec9c8b4d49 Adding the new class CakeTestSuite to setup some utility stuff like fixtures outside of CakeTestCase 2010-05-08 15:53:29 -04:30
José Lorenzo Rodríguez
acb9733d0e Convertint CakeFixtureManager into a non-static class to be able to replace it with custom implementations
and to test it more easily
2010-05-08 15:52:11 -04:30
Mark Story
507c3b2d94 Adding the CakePHP testing classes to the coverage ignore filter for PHPUnit. Starting to refactor how coverage is generated, to use more features of PHPUnit. 2010-05-08 16:18:45 -04:00
Mark Story
933378223b Updating CakeLog tests to use @expectedException annotation. 2010-05-08 16:17:20 -04:00
Mark Story
e7ff0bdf66 Adding missing parameters to assertEqual() wrapper.
Adding assertNotEqual() wrapper.
Adding expectError() but it doesn't work because of Debugger's error handler being set.
Fixing fatal error where getDescription would not be defined.
2010-05-08 11:42:04 -04:00
José Lorenzo Rodríguez
82a1bd6f80 Cleaning up CakeTestCase and adding some tests for it 2010-05-08 01:19:45 -04:30
Mark Story
1a7dce3af6 Updating DboMysql to fix an issue where virtualFields that were simple
aliases to fields on other tables would end up in the wrong place.
Tests added.  Fixes #655
2010-05-07 23:26:13 -04:00
Mark Story
745afe888b Adding more tests for saving records with nulls. Closes #675 2010-05-07 22:23:18 -04:00
Mark Story
0930b5c63c Adding more documentation for JsHelper::submit(). Closes #681 2010-05-07 21:26:44 -04:00
José Lorenzo Rodríguez
e81cc684ef Merge branch '2.0-phpunit' of git@github.com:lorenzo/cakephp1x into 2.0-phpunit
Conflicts:
	cake/tests/lib/cake_test_case.php
2010-05-07 19:48:50 -04:30
José Lorenzo Rodríguez
7124e6db3e Refactoring CakeTestCase to remove fixture specific code and use the new class CakeFixtureManager.
It lacks support to auto-drop tables after test case end, but it is already usable for testing
2010-05-07 18:07:02 -04:30
José Lorenzo Rodríguez
ef142b1659 Adding the class CakeFixtureManager to delegate the task of creating and droping the fixtures
Tests and docs still pending
2010-05-07 18:06:17 -04:30
Mark Story
f152181c03 Adding tests for saving models with id == null. Closes #675 2010-05-06 22:24:11 -04:00
Mark Story
1c3415759a Fixing 'Only variables should be assigned by reference' errors in php4 in form helper. Fixes #643 2010-05-06 22:11:31 -04:00
Mark Story
1c1c511853 Changing how email validation methods are applied, to fix issues where getmxrr() exists but the domain being validated does not have MX records correctly configured. Fixes #634 2010-05-06 21:43:58 -04:00
Mark Story
45d052b55a Fixing failing tests in ViewTask test case, caused by changes in core templates.
Fixing incorrect variable usage where models would be double singularized causing incorrect names.  Fixes #668
2010-05-06 21:38:14 -04:00
Mark Story
5ea4f027db Fixing TestTask so that if you give an invalid class type you get an error. 2010-05-06 07:31:52 -04:00
José Lorenzo Rodríguez
bed87b87c6 Removing code from CakeTestCase around the method "testAction" which was a bad way of testing controllers, often making it more difficult.
This also removes class contamination in newly created test cases
2010-05-05 22:42:56 -04:30
José Lorenzo Rodríguez
b53d21ff52 Fixing a group test case to show how to create one, and to make pass TestManager test case 2010-05-04 23:58:17 -04:30
José Lorenzo Rodríguez
fd4a82d6e9 Adding test for TestManager::runGroupTest() 2010-05-04 23:56:40 -04:30
José Lorenzo Rodríguez
856a52a378 Changing runGrouptTest to find for conventional class names. This commit removes the support for loading more than one groupt test class per file 2010-05-04 23:13:07 -04:30
Mark Story
918e961f7d Fixing typo in testtask. Fixes #659 2010-05-04 23:29:54 -04:00
Mark Story
fcad9b464c Fixing tests broken by changes in default bake templates.
Fixing issue where admin methods wouldn't be correctly generated.
Fixes #664
2010-05-04 23:27:41 -04:00
José Lorenzo Rodríguez
41683723f7 Making more methods static in TestManager 2010-05-04 21:04:18 -04:30
José Lorenzo Rodríguez
c23f66e35c Removing "extends" from TestManager as it wasn't used anyway.
Making some methods static as they were called statically
More testing on TestManager
2010-05-04 20:51:58 -04:30
predominant
719836c41d Updated doc block for added HTTP Status. 2010-05-05 10:09:47 +10:00
José Lorenzo Rodríguez
cdf4006f16 Refactoring TestManager::runAllTests() and improving the TestManager test case 2010-05-04 18:25:15 -04:30
José Lorenzo Rodríguez
4a152d3d55 Adding number of assertion runned in html reporter
enabling "show passes" (that in contrast of simpletest only reports the passed test method instead of the assertion)
cleaning up a bit
2010-05-04 16:31:03 -04:30
José Lorenzo Rodríguez
10434c35b6 Improving PHPUnit path detection when it is installed via pear 2010-05-04 16:30:06 -04:30
José Lorenzo Rodríguez
9afbeaa217 Converting CakeHtmlReporter in a TestCase listener.
this apparently shows that it is easy to make the transition to PHPUnit.
2010-05-04 13:51:25 -04:30
José Lorenzo Rodríguez
ce7f892d6a Removing simpletest dependency in CakeBaseReporter 2010-05-04 13:50:07 -04:30
José Lorenzo Rodríguez
15dd798e30 Some experimental movements inside TEstManager to make it work with PHPUnit 2010-05-04 13:49:10 -04:30
José Lorenzo Rodríguez
14559aabd9 Adding compatibility assert methods for CakeTestCase to ease the transition to PHPUnit 2010-05-04 13:47:08 -04:30
José Lorenzo Rodríguez
7417a00de7 Initial step to replace simpletest for PHPUnit
This is probably temporary, still needed to see if PHPUnit is already in path (installed with pear or something)
2010-05-04 13:40:50 -04:30
Mark Story
ce10c85367 Making Sanitize::stripScripts() to remove multi-line script and style blocks. Fixes #657 2010-05-03 22:33:20 -04:00
Mark Story
95dbae8acf Making RequestHandler component carry along a passed status code. This fixes issues where RequestHandler hijacks an redirect(). Fixes #658 2010-05-03 22:07:13 -04:00
predominant
87db966383 Remove PHP5 conditional statements. 2010-05-03 13:36:32 +10:00
predominant
c1eaa4b24c Fixed access and removed @access tags. 2010-05-03 13:28:09 +10:00
Mark Story
c48f6d6536 Fixing safe parameter from leaking into request() calls in JsHelper::submit() and JsHelper::link(). Fixes #656 2010-05-02 21:17:10 -04:00
Jose Diaz-Gonzalez
1180f66cc0 Setting $actions to null so that the controller methods are not always based upon the first controller in an app/plugin.
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-02 20:35:19 -04:00
Mark Story
dc08aedb44 Fixing constructors for reporter classes. 2010-05-02 17:54:49 -04:00
Mark Story
adf604a966 Merge branch '1.3' into 2.0
Conflicts:
	cake/console/templates/default/actions/controller_actions.ctp
	cake/console/templates/default/views/form.ctp
	cake/console/templates/default/views/index.ctp
	cake/console/templates/default/views/view.ctp
	cake/libs/controller/controller.php
	cake/libs/controller/scaffold.php
	cake/libs/view/pages/home.ctp
	cake/tests/cases/dispatcher.test.php
	cake/tests/cases/libs/model/cake_schema.test.php
2010-05-02 17:53:42 -04:00
Mark Story
b5a0dccc3a Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3 2010-05-02 17:03:20 -04:00
Mark Story
4a0ead8a62 Fixing asset filtering for assets in themes and plugins. These assets should now correctly enter the configured asset filters. Fixes #650. Fixes #160 2010-05-02 16:48:35 -04:00
ADmad
f386dca6d8 Controller::loadModel() now returns true when model is succesfully instantiated as stated in docblock. Added test case. 2010-05-02 05:34:38 +05:30
Mark Story
257665eb5b Updating doc blocks for bindModel and unbindModel, explaining that associations are only reset when find() is called. Refs #652 2010-05-01 17:37:23 -04:00
José Lorenzo Rodríguez
ad51115e12 Fixing bug where required class would be added to form fields when using single rule syntax in $validate even if allowEmpty is set to true
Closes #654
2010-04-30 16:42:59 -04:30
José Lorenzo Rodríguez
9b040a5ed3 Fixing code formating 2010-04-30 16:07:59 -04:30
ADmad
0471ea046f Adding test case for 'required' class adding to wrapping div based on model validations. Refs #654 2010-05-01 01:19:52 +05:30
Mark Story
734e4fa87a Removing the conditional check around including custom session configuration files. This fixes issues where requestAction could cause loss of session settings, and improves the end developers ability to customize the session. Custom session files should ensure that classes/functions are conditionally declared. Fixes #374, #541 2010-04-29 21:40:12 -04:00
ADmad
afd67e534b Fixing parse error created in commit [6d092552e5]. Closes #647 2010-04-30 03:52:39 +05:30
Mark Story
6d092552e5 Updating bake templates and Scaffold to use less sprintf() and more complete sentences in i18n strings. This should make translations easier to do in a gender correct way. Fixes #210 2010-04-28 23:56:07 -04:00
José Lorenzo Rodríguez
a6f60c1abb Implementing cache lockig in FileEngine using SplFileObject 2010-04-29 00:44:17 +10:00
José Lorenzo Rodríguez
5dce79e424 First steps into removing internal usage of File and Folder class in favor of SPL equivalents 2010-04-29 00:44:04 +10:00
Mark Story
afa0e6b8f9 Adding cake.icon.png to the skel dir. Fixes the wrong asset being included when new projects are generated. Fixes. #637 2010-04-27 23:19:55 -04:00
Mark Story
328c58635b Fixing inflection of words ending in analysis. Fixes #619 2010-04-27 23:03:37 -04:00
Mark Story
2fab47e740 Updating doc block for EmailComponent::send(). Fixes #633 2010-04-27 22:50:34 -04:00
Mark Story
bd485c77d3 Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3 2010-04-27 22:42:54 -04:00
Mark Story
bb239e3816 Fixing parse error in php4 for MediaView. Also fixing undefined variable error in Dispatcher. Fixes #628 2010-04-27 22:42:33 -04:00
ADmad
c2bd87144e Adding test case for HtmlHelper::url() showing use of key 'full_base' for parameter. Refs #627 2010-04-27 00:19:01 +05:30
predominant
9243f6601a Merge remote branch 'markstory/2.0' into 2.0 2010-04-26 14:11:07 +10:00
predominant
d5073d7bcf Fixed failing Set tests from Model class visibility. 2010-04-26 12:53:02 +10:00
predominant
b13a5c2862 Added access modifiers and static delcarations on Set class. 2010-04-26 12:45:56 +10:00
Mark Story
af6435ece8 Fixing issue where table name was not using fully qualified table names, causing issues with models using table prefixes. Tests added. Fixes #623 2010-04-25 00:22:57 -07:00
predominant
1c064788c5 Updated vesion numbers to 1.3.0 2010-04-25 14:27:29 +10:00
Mark Story
46b9e76d8e Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3 2010-04-24 17:34:45 -07:00
Mark Story
ce260debbc Adding tests for passed arguments with dots when parseExtensions() has been called. Refs #620 2010-04-24 17:30:00 -07:00
ADmad
46df1be384 Model::deleteAll() now returns false if the 'find' to fetch records ids returns false (in case of sql error). Closes #272 2010-04-25 02:34:18 +05:30
Mark Story
3e85577c1f Adding tests for dispatcher to show periods not being removed. Refs #620 2010-04-24 10:42:19 -07:00
Mark Story
5f03862f25 Adding tests that show that Router is not chopping off periods from passed arguments. Refs #620 2010-04-24 10:40:15 -07:00
Mark Story
e0b4e3dd96 Merge branch '2.0' of git://github.com/predominant/cakephp1x into 2.0 2010-04-24 01:45:58 -07:00
Mark Story
9ddbd6f686 Removing dependancy on Object from CakeSocket. Making tests less dependant on having a network connection. 2010-04-23 21:41:20 -07:00
Mark Story
e8b6d45850 Fixing fatal errors in HttpSocket test case. 2010-04-24 00:31:10 -04:00
Mark Story
a17a38ddf4 Fixing fatal errors in View test.
Removing =& and making tests use instanceof instead of is_object()
2010-04-24 00:22:21 -04:00
Mark Story
c03974ebb2 Expanding documentation for Router::queryString(). 2010-04-24 00:21:17 -04:00
Mark Story
35ec5ce2fc Updating test method names and moving parameter modification around. 2010-04-23 23:59:57 -04:00
Mark Story
e111735905 Changing AclBase into AclInterface as it is now an interface.
Splitting the test case into separate test cases for each class.
2010-04-23 23:52:36 -04:00
Mark Story
523eda018e Deprecating AclComponent::revoke() and AclComponent::grant() they were simply aliases that create a larger API with no real benefit. 2010-04-23 23:14:55 -04:00
Mark Story
62982c57b4 Making AclComponent throw exceptions when it encounters an error.
Making AclBase an abstract class.
Adding AclComponent::adapter() for runtime modification of the Acl implementation.
Tests added, updated and fixed.
2010-04-23 23:03:51 -04:00
Mark Story
33a2907202 Adding CakeLogInterface and implementing it in core and test suite classes. The new interface is used for method detection instead of a hard method check. Making CakeLog throw exceptions instead of trigger errors when things go wrong. 2010-04-23 22:31:21 -04:00
Mark Story
35c8f9963a Adding @throws to methods that could throw exceptions. 2010-04-23 22:29:57 -04:00
Mark Story
50c04332cb Moving methods that do not need to be private into protected. 2010-04-23 22:08:11 -04:00
Mark Story
4d4d9e78f8 Adding App::setObjects() as a temporary way to modify App's cache of plugins. This allows the DispatcherTest to successfully run. 2010-04-23 22:04:16 -04:00
Mark Story
0a8aafe3c8 Fixing reference to method name. 2010-04-23 22:03:11 -04:00
Mark Story
02c56ba8c1 Updating visibility in the various bake tasks. 2010-04-23 21:57:59 -04:00
Mark Story
854583f0d7 Fixing visibility on ModelTask and making a private method protected. 2010-04-23 21:49:35 -04:00
Mark Story
d000a11e9b Removing params() from Sanitize. 2010-04-23 21:32:39 -04:00
Mark Story
d926a379b4 Removing params() it was a pretty much useless function, and was deprecated. 2010-04-23 21:32:23 -04:00
Mark Story
84002687c8 Making Security a static class.
Fixing static access issues in test case.
2010-04-23 21:28:54 -04:00
Mark Story
33bfe0e5e2 Making Helper extend Object, this fixes issues where Helpers would not have dispatchMethod or requestAction available.
Correcting JsHelper::call__ into JsHelper::__call
Updating test cases to remove reference operators
2010-04-23 21:21:31 -04:00
Mark Story
9e08196c76 More tests for ajax link delegation. 2010-04-23 21:14:23 -04:00
Mark Story
bf566e1aad Fixing failing tests in PaginatorHelper and moving tests related to JsHelper interaction into a separate test method. 2010-04-23 21:10:23 -04:00
predominant
da3103379e Revert "Change URL Validation to use filter_var"
This reverts commit 4e53916021.
2010-04-24 11:01:07 +10:00
predominant
4e53916021 Change URL Validation to use filter_var 2010-04-24 10:56:14 +10:00
predominant
557a6343f9 Minor adjustment to ip validation variables. 2010-04-24 10:51:56 +10:00
Mark Story
999eb4be7b Fixing illegal access in HtmlHelper tests, replacing with mock object. 2010-04-23 20:51:24 -04:00
Mark Story
c9f103432c Updating Model to use call_user_func_array instead of methods that were previously inherited from Object. 2010-04-23 20:47:40 -04:00
Mark Story
65ddc2b040 Fixing fatal errors caused by calling methods that no longer exist. 2010-04-23 20:45:13 -04:00
Mark Story
8cce38692a Simplifying route configuration failure test case. 2010-04-23 20:42:53 -04:00
Mark Story
0fc106428a Adding exception tossing for invalid cacheengine configuration. 2010-04-23 20:41:29 -04:00
Mark Story
6f0b43f156 Fixing fatal error in Cache stub classes. 2010-04-23 20:31:08 -04:00
Mark Story
797fa0009a Making Router throw exceptions when invalid route classes are used for routes. 2010-04-23 20:22:02 -04:00
predominant
f65e481ebf Consoloidate duplicate regex strings in money() validation. 2010-04-23 17:04:25 +10:00
predominant
396c025529 Converted validation to use filter_var with ipv4/ipv6 separation matching 1.3 operation. 2010-04-23 16:55:04 +10:00
Mark Story
56967e71c1 Fixing group path checking in test manager.
Conflicts:

	cake/tests/lib/test_manager.php
2010-04-23 00:46:13 -04:00
Mark Story
bc6b8e5dfd Fixing parameters from leaking into the script tag when calling JsHelper::submit(). Added test cases and refactored JsHelper::link(). Fixes #613 2010-04-23 00:04:15 -04:00
Mark Story
c404ae5400 Adding htmlentities() to all parameters passed into the HtmlReporter. 2010-04-22 23:36:20 -04:00
Mark Story
813a3af19c Fixing security vulnerabilities in the test suite runner. 2010-04-22 23:36:02 -04:00
predominant
298b44a550 Removing Object extension on Validation. 2010-04-23 13:10:56 +10:00
predominant
4c769ea585 Typo fix in doc block. 2010-04-23 12:58:58 +10:00
predominant
f51ce734bf Import Validation from old 2.0 branch. 2010-04-23 12:53:47 +10:00
Mark Story
215333e56f Making tests more accurate to normal use, removing extra params and adding some tests for sortKey. Refs #614 2010-04-22 22:53:36 -04:00
predominant
015872445b Merge remote branch 'origin/1.3' into 2.0
Conflicts:
	cake/console/libs/acl.php
	cake/tests/cases/libs/view/helpers/form.test.php
	cake/tests/cases/libs/view/helpers/javascript.test.php
2010-04-23 12:52:56 +10:00
Mark Story
a92b9000bf Adding tests for non .com domains. Refs #605 2010-04-22 21:37:27 -04:00
kleingeist
6033fc70fa Documentation fix for XmlHelper::serialize
Signed-off-by: Mark Story <mark@mark-story.com>
2010-04-22 21:27:17 -04:00
José Lorenzo Rodríguez
fca070fe9e Merge branch '1.3' of git@github.com:cakephp/cakephp1x into 1.3
* '1.3' of git@github.com:cakephp/cakephp1x:
  Adding tests for and fixing the behavior of `cake acl initdb` it now correctly delegates to SchemaShell.  Fixes #608
  Making TestTask not depend on Inflection rules for creating directory names,  refs #610
  Adding tests for Inflector::rules() clearing cached values.  Fixes #609
  Clear cache of pluralized, singularized and tableize when set rules.
2010-04-22 16:50:25 -04:30
José Lorenzo Rodríguez
65f01fa31c Fixing model introspection in FormHelper to better take in account realted models with aliased names 2010-04-22 16:37:15 -04:30
Mark Story
568e9d3a89 Adding tests for and fixing the behavior of cake acl initdb it now correctly delegates to SchemaShell. Fixes #608 2010-04-21 23:28:40 -04:00
Mark Story
81edcdf431 Making TestTask not depend on Inflection rules for creating directory names, refs #610 2010-04-21 23:21:25 -04:00
Mark Story
1d3b653e57 Adding tests for Inflector::rules() clearing cached values. Fixes #609 2010-04-21 22:49:48 -04:00
Juan Basso
bb0ff192f7 Clear cache of pluralized, singularized and tableize when set rules.
Signed-off-by: Mark Story <mark@mark-story.com>
2010-04-21 22:48:56 -04:00
Mark Story
120fdd9045 Removing other uses of Routing.admin as it has been removed from Router. 2010-04-20 23:43:51 -04:00
Mark Story
a71a8a89b2 Removing support for Routing.admin. Use Routing.prefixes instead. 2010-04-20 23:40:13 -04:00
Mark Story
9053291fe4 Fixing incorrectly named variable. Refs #567 2010-04-20 22:18:17 -04:00
José Lorenzo Rodríguez
5ceb19304e Merge branch '1.3' of git@github.com:cakephp/cakephp1x into 1.3 2010-04-19 23:33:43 -04:30
José Lorenzo Rodríguez
e1c4b9696b Adding documentation on 'attributes' key for FormHelper::error 2010-04-19 23:32:58 -04:30
Mark Story
661c76802c Making singleton access use a class property. 2010-04-19 23:56:36 -04:00
José Lorenzo Rodríguez
23eea00a0b Fixing FormHelper::error to no add error names and messages as html attributes. Fixes #585
This introduces the special key 'attributes' to FormHelper::error() when passed in the second parameter
The contents of said key will be converted into html attributes for the error container tag
2010-04-19 23:25:57 -04:30
Mark Story
7bf594ff17 Removing private method access, and removing tests for features that will be removed. 2010-04-19 23:54:09 -04:00
Mark Story
e92e212b8d Fixing Router's constructor.
Adding static visibility to Router methods.
Adding a method for testing Router extensions.
Router::mapResources() now returns the mapped resources
Fixing visibility issues in test cases.
2010-04-19 23:44:45 -04:00
Mark Story
f86d0de5ee Adding test to show correct functioning of containable + field() + recursive = -1. Closes #409 2010-04-19 23:16:59 -04:00
Mark Story
029d2581af Fixing autoFields causing invalid SQL when cross database joins are being done. Tests added. Fixes #476 2010-04-19 22:39:07 -04:00
Mark Story
ea7b32347d Removing some of the singleton access in Debugger. 2010-04-19 00:15:56 -04:00
Mark Story
2bf9504cfb Removing inheritance from Object.
Adding missing visibility keywords, and adding static keywords.
Removing @tags.
2010-04-19 00:10:22 -04:00
Mark Story
c05c9857ac Removing exception throwing from CacheEngine::gc() and subclasses as it randomly caused errors when using one of the affected engines. 2010-04-19 00:04:34 -04:00
Mark Story
2f0255ec1a Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3 2010-04-18 22:19:57 -04:00
Juan Basso
4654c85937 Fixing name of cake icon on skel. Fixes #600
Signed-off-by: Mark Story <mark@mark-story.com>
2010-04-18 22:19:17 -04:00
predominant
a121e0b628 Fix missing quotation mark. 2010-04-19 12:08:04 +10:00
Mark Story
b7e4e46251 Removing lonely comment. 2010-04-18 01:17:01 -04:00
Mark Story
40e310c79b Adding a no-op constructor for Object. Fixes issues where numerous sub-classes break because of a missing constructor in Object. 2010-04-18 01:12:44 -04:00
Mark Story
146ec004eb Removing inheritance from Object. Constructor workarounds are no longer needed and Object methods are not used on these classes. 2010-04-18 01:12:00 -04:00
Mark Story
c9f3fa5faa Updating constructor. 2010-04-18 01:04:56 -04:00
Mark Story
4f0a9c4dc1 Removing PHP4 constructor and __destruct workarounds. 2010-04-18 01:03:57 -04:00
Mark Story
9046083dc8 Removing Overloadable and Overloadable2 they are not needed in PHP5.
Removing inheritance and test cases related to Overloadable.
2010-04-18 01:02:39 -04:00
Mark Story
92289e59f7 Updating ApcEngine so it implements the missing method in the abstract class.. 2010-04-18 00:57:52 -04:00
Mark Story
8ea4475ac3 Removing extra call to unset(). 2010-04-18 00:53:52 -04:00
Mark Story
ca8110ad32 Updating MemcacheEngine to use exceptions and implement missing CacheEngine methods. 2010-04-18 00:46:19 -04:00
Mark Story
d7f16816e6 Adding translation to exceptions in FileEngine. 2010-04-18 00:45:45 -04:00
Mark Story
a886e13666 Making CacheEngine an abstract class, and updating FileEngine to include the not implemented methods. 2010-04-18 00:38:36 -04:00
Mark Story
100a0180a2 Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3 2010-04-17 18:50:47 -04:00
Mark Story
4425743bcd Adding tests for creating cache configs of different types in sequence. Demonstrates error explained in #596. 2010-04-17 18:50:28 -04:00
ADmad
9495aa2348 Fixing incorrect function name in comments in bootstap.php of console's template 'skel'. Closes #593 2010-04-18 00:12:34 +05:30
Mark Story
9ae8b737dc Trimming trailing whitespace. 2010-04-17 13:05:26 -04:00
Mark Story
ae8ace79fa Adding additional tests for JavascriptHelper::object() options. Closes #588 2010-04-17 12:44:04 -04:00
Mark Story
78f14401ca Fixing issue where using delivery = debug and not using sessions would cause a fatal error. send() will now return the contents that would get written into the session. Fixes #595 2010-04-17 12:27:50 -04:00
Mark Story
bb7cc60d3f Fixing parse error added in last commit :( 2010-04-17 02:13:22 -04:00
Mark Story
0f6e87cab8 Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3 2010-04-17 02:10:58 -04:00
predominant
92215e1795 Merge remote branch 'origin/1.3' into 2.0
Conflicts:
	cake/libs/inflector.php
	cake/libs/view/helpers/text.php
	cake/libs/view/pages/home.ctp
	cake/tests/cases/libs/view/helpers/time.test.php
2010-04-16 23:43:28 +10:00
predominant
23a22c73b7 Remove "not being used" comment from Model docblock. Fixes #590 2010-04-16 21:45:44 +10:00
predominant
c7fcaf995f Convert getMictime() php4 hack to microtime(true) 2010-04-16 02:58:28 +10:00
predominant
0384ecad30 Removed remaining @filesource lines. 2010-04-16 02:48:47 +10:00
predominant
591eb43b26 Finalise shortcut translation function application. 2010-04-16 02:43:43 +10:00
predominant
74d7682707 Fix translation shortcut usage through testing console for updates 2010-04-16 02:38:12 +10:00
predominant
c98021dcd8 Converted views, router and security classes to new translation shotcut function use. 2010-04-16 02:20:15 +10:00
predominant
6bd9f0f05b Convert models, datasources and file/folders to new version of translation shortcut function. 2010-04-16 02:00:25 +10:00
predominant
2f8d30d2c0 Convert controllers and sockets to new formate for shorthand translation functions. 2010-04-16 01:52:49 +10:00
predominant
41fe51d4b9 Cache classes converted to new shortcut translation usage. 2010-04-16 01:45:34 +10:00
predominant
1e425907b2 Change Cake Console files to new use of shortcut for translations. 2010-04-16 01:43:39 +10:00
predominant
c87d97b4c2 Removed echo default from translation shortcut functions. 2010-04-16 00:34:30 +10:00
Mark Story
1fef9e4a78 Making Configure/App methods static, removing reference operators.
Removing deprecated methods.
2010-04-15 00:06:17 -04:00
Mark Story
23b75f4ed2 Moving private members/methods to protected.
Changing Cache methods/members to static.
Removing singleton access to Cache.
2010-04-14 23:56:44 -04:00
Mark Story
17949ff9fc Adding accessor to fix issues in test cases.
Removing check for php4 method name.
2010-04-14 23:36:47 -04:00
Mark Story
286e96624b Removing reference operators and removing DS in TestManager and CakeTestCase. 2010-04-14 23:31:15 -04:00