Larry E. Masters
a02fb9e771
Fixing code sniffer errors
2015-12-28 18:40:14 -05:00
Larry E. Masters
34b4261e6d
Fixes: A non well formed numeric value encountered - php 7
2015-12-28 17:42:56 -05:00
Larry E. Masters
a59ea13712
Fixes SessionComponentTest::testSessionValid. Refactored _hasSession and other erros on php 7
...
init would always set CakeSession::$_userAgent.
2015-12-28 17:26:35 -05:00
Larry E. Masters
027e32ce00
Reverted change setting $_SESSION to an array. Commenting out a test that is invalid.
...
This test creates a numeric key of 0 in $_SESSION which is not a valid session key. This causes error - session_write_close(): Skipping numeric key 0 error.
2015-12-28 17:19:31 -05:00
Larry E. Masters
c2449c9d16
Fixing Code Sniffer errors
2015-12-28 17:15:23 -05:00
Larry E. Masters
33f2f46868
Refactoring and emoving one isset check
2015-12-28 11:52:19 -05:00
Larry E. Masters
5c3bc44ef5
Initial fixes for failing session tests
2015-12-28 11:41:23 -05:00
Larry E. Masters
1fd329311b
Fixes tests to expect changes made to read and write methods - This could be a possible BC change
...
Since php 7 expects write to return true or false this needed to change, previous implementation would return the values sent to write on success and false on failure. Similar change to read method test CakeSession::read() now returns results or ''.
2015-12-28 11:29:17 -05:00
Larry E. Masters
3c21f4a8af
Fixes session_write_close(): Skipping numeric key 0 error
2015-12-28 11:18:03 -05:00
Larry E. Masters
46d385ac73
Should be able to write a file with no data in it.
2015-12-27 22:25:23 -05:00
Larry E. Masters
9abb4e19f2
Removing forced return true
2015-12-22 16:22:34 -05:00
Larry E. Masters
1c593eea63
Adding return types to Session test classes.
2015-12-22 16:20:24 -05:00
Larry E. Masters
dd11c63069
Changing return types
...
read now returns empty string instead of false when read method returns an empty value.
write, destroy and gc will return boolean type
2015-12-22 16:19:51 -05:00
Larry E. Masters
776c128fe0
Adding boolean return in Cache::gc
2015-12-22 16:15:53 -05:00
Larry E. Masters
577e1b089f
Revert "Forcing bool return"
...
This reverts commit fac95baee7
2015-12-14 19:31:08 -06:00
Larry E. Masters
572ca1458b
Revert "Forcing bool"
...
This reverts commit 26ea74cbcf
2015-12-14 19:30:52 -06:00
Larry E. Masters
dd211e9158
Revert "Changing where bool is returned"
...
This reverts commit 8f52cefdcc
2015-12-14 19:30:42 -06:00
Larry E. Masters
464a266fc7
Revert "Using better way to check for active session"
...
This reverts commit 439a33c708
2015-12-14 19:30:24 -06:00
Larry E. Masters
975262b03e
Revert "Correcting return"
...
This reverts commit 6e09e64432
2015-12-14 19:30:16 -06:00
Larry E. Masters
1a3598c3f4
Revert "session_status() not available until 5.4"
...
This reverts commit da9b6453ce
2015-12-14 19:29:08 -06:00
Larry E. Masters
5790d49f5b
Revert "Revert "Adding missing @return tag in function comment""
...
This reverts commit 1cc5c8cf7f
2015-12-14 19:28:25 -06:00
Larry E. Masters
1cc5c8cf7f
Revert "Adding missing @return tag in function comment"
...
This reverts commit 130e854c30
2015-12-14 19:25:36 -06:00
Larry E. Masters
da9b6453ce
session_status() not available until 5.4
...
Adding check for php version
2015-12-14 10:56:55 -06:00
Larry E. Masters
6e09e64432
Correcting return
2015-12-14 10:46:16 -06:00
Larry E. Masters
439a33c708
Using better way to check for active session
2015-12-14 10:42:46 -06:00
Larry E. Masters
8f52cefdcc
Changing where bool is returned
2015-12-14 09:17:29 -06:00
Larry E. Masters
26ea74cbcf
Forcing bool
2015-12-13 20:06:05 -06:00
Larry E. Masters
fac95baee7
Forcing bool return
2015-12-13 20:05:54 -06:00
Larry E. Masters
130e854c30
Adding missing @return tag in function comment
2015-12-13 15:38:39 -06:00
Larry E. Masters
894d233fd6
add @throws anotation to fix travis PHP_CODESNIFFER warnings
2015-12-13 15:16:49 -06:00
Larry E. Masters
6a68032e0b
FIxing srand() expects parameter 1 to be integer, string given
...
Type casting to integer
2015-12-13 14:18:59 -06:00
Larry E. Masters
48e018e707
Allowing tests to run on PHP 7
2015-12-13 14:12:31 -06:00
Mark S
dcac9c4a0c
Merge pull request #7807 from m1nd53t/2.8-PHP7
...
Removed last typehint Exception
2015-12-07 16:38:14 +01:00
Kars Frijters
2fdd3030e2
Removed last typehint Exception
...
#7671 Removed last typehint Exception as it was still giving an uncaught typeError message in PHP7
2015-12-07 16:25:14 +01:00
Mark Scherer
f662b2f5aa
Skip error for now.
2015-12-06 12:50:09 +01:00
Mark Scherer
8c5f78bc58
Remove another type hint
2015-11-10 00:32:48 +01:00
Mark Scherer
7982b6b078
Allow ParseError as exception and remove typehint.
2015-11-10 00:14:04 +01:00
Mark Scherer
ddfb7d649e
Enable PHP7.0 in travis
2015-11-10 00:11:48 +01:00
Mark Story
aa66293310
Merge pull request #7624 from rchavik/2.8-redis-cache-fix
...
Workaround for Cache::write() call from DboSource::__destruct()
2015-10-30 21:58:05 -04:00
ADmad
90c9ead8cd
Fix CS error
2015-10-30 09:28:03 +05:30
Rachman Chavik
c1b6f89b23
Workaround for Cache::write() call from DboSource::__destruct()
...
Closes #7559
2015-10-30 10:14:16 +07:00
mark_story
bc977544c5
Use a more stable timezone.
...
Regina does not observe DST meaning this test won't fail twice a year.
2015-10-26 22:28:00 -04:00
Mark Story
b583a59264
Merge pull request #7610 from cakephp/2.8-pagination
...
Make sure direction values are lowercased to be consistent.
2015-10-26 20:23:10 -04:00
Mark Scherer
8287981855
Make sure direction values are lowercased to be consistent.
2015-10-26 23:20:30 +01:00
mark_story
a99766c897
Merge pull request #7577 into 2.8
...
Backport Validation::uploadedFile() to 2.x.
2015-10-20 21:09:20 -04:00
mark_story
c26b7bbffe
Fix PHPCS errors and failing test.
...
Refs #7577
2015-10-20 21:08:57 -04:00
vanquang9387
0cdfed0aee
Add more test on UploadedFileSize validation
2015-10-20 09:00:32 +07:00
vanquang9387
13132cd113
Fix using php 5.4 array [ ]
2015-10-19 15:52:10 +07:00
vanquang9387
8b3bba3341
Reformat Validation class
2015-10-19 15:47:33 +07:00
vanquang9387
af8c992655
2.x uploadedFile validation (backported from #4524 )
2015-10-19 15:15:28 +07:00
