jalbertocr
8b2e1ab9e5
Don't do assignments inside conditionals.
2014-02-19 22:41:33 -03:00
jalbertocr
cdeb51167b
Fix types in docblocks.
2014-02-19 20:54:00 -03:00
jalbertocr
35f152b333
Make sure a datetime instance is valid to avoid fatal errors.
2014-02-19 20:50:30 -03:00
Mark Story
4497bab131
Merge pull request #2864 from AD7six/2.4-better-float-validation
...
account for localized floats more robustly.
2014-02-19 12:08:30 -05:00
AD7six
4e0627232c
account for localized floats more robustly.
...
Normalize floats, strings too, so that they are validated as
dddddddddd.dd
ref #2853
2014-02-19 15:04:25 +00:00
mark_story
0a51458ffd
Fix Validation::decimal() not working with localized floats.
...
Use similar workarounds as DboSource::value() for accepting localized
floats.
Fixes #2853
2014-02-18 22:18:56 -05:00
Mark Story
3d00ca9643
Merge pull request #2861 from ujwaltrivedi/master
...
Get unlimited number of slabs when clearing cache keys in memcache.
2014-02-18 20:46:50 -05:00
Ujwal Trivedi
1045a5e0a5
Update MemcacheEngine.php
...
removed 0 from getExtendedStats('slabs') in my last commit, someone point that out in the comment. Adding it back.
2014-02-18 18:40:17 -05:00
Mark Story
4353507ebb
Merge pull request #2852 from ujwaltrivedi/master
...
Update MemcacheEngine.php
2014-02-17 16:44:13 -05:00
Ujwal Trivedi
cb0580a91a
Update MemcacheEngine.php
...
removing variable assignment
2014-02-17 15:29:49 -05:00
mark_story
070b165527
Mark compatibility shims as deprecated.
...
Fixes #2845
2014-02-17 10:29:03 -05:00
Ujwal Trivedi
91ef655854
Update MemcacheEngine.php
...
adding $limit=0 to clear function so it deletes all the keys for real
2014-02-17 02:51:00 -05:00
José Lorenzo Rodríguez
4f424007fa
Merge pull request #2822 from dereuromark/master-validation
...
Fix uploadError validation rule
2014-02-13 19:58:40 +01:00
ADmad
54a395cc3e
Updated docblock.
...
BlowfishAuthenticate is deprecated.
2014-02-13 17:54:53 +05:30
euromark
1725386c16
Fix uploadError validation rule to work with OS Win. Here the error is string, not integer.
2014-02-12 21:52:18 +01:00
mark_story
827dc77a11
Fix incorrect assertion.
2014-02-11 22:00:24 -05:00
mark_story
96a37d5917
Fix temporary associations that replace fields not being restored.
...
When binding temporary associations, fields should be restored
in the afterFind as the association will have become unbound.
Fixes #2816
2014-02-11 21:56:05 -05:00
mark_story
a5d50da040
Remove dead and unused code.
2014-02-11 16:38:24 -05:00
Mark Story
7a72431442
Merge pull request #2770 from ukk1337/master
...
Added missing 'Session'-Component in bake
2014-02-09 16:04:25 -05:00
mark_story
91349c306e
Remove trailing whitespace.
...
Refs #2799
2014-02-09 16:03:37 -05:00
Mark Story
6b3a062927
Merge pull request #2799 from sam-at-github/master
...
Fixed prefixed action prefix reverse routing match. One liner.
2014-02-09 16:02:44 -05:00
Sam
f3cd0fc808
Test added for previous fix in CakeRoute.php. Refs #2797 .
2014-02-10 02:20:00 +11:00
Sam
a9059d4a4f
Fix formatting - one space too much. Refs #2799 .
2014-02-10 02:02:41 +11:00
Sam
7fd13d406c
Fixed prefixed action prefix reverse routing match. One liner.
2014-02-10 01:38:32 +11:00
ADmad
ac1a5c58f5
Merge pull request #2792 from rockingeric/fixer
...
Fix ApiGen errors
2014-02-08 02:26:51 +05:30
Eric Martins
2793dca671
Fix ApiGen errors
2014-02-07 18:29:54 -02:00
Mark Story
96048f401a
Merge pull request #2786 from sam-at-github/master
...
Router::comment() documentation
2014-02-06 07:15:34 -05:00
Sam
9691e54248
Minor comments only. Added more explanation of $defaults parameter to Router::connect(). Trying to clarify how it relates to the routing destination and the template string tokens.
2014-02-06 20:34:02 +11:00
Sam
ae3c791b6c
Minor documentation corrections about Router::connect().
2014-02-06 18:41:37 +11:00
Mark Story
278349aff9
Merge pull request #2782 from jimmymadon/feature-clarify-acl-errors
...
Clarified ACL node lookup failed error.
2014-02-05 17:55:11 -05:00
Mark Story
8cddd354d9
Merge pull request #2785 from ADmad/2.4-view-return-value
...
Don't return `true` from view classes' render() method.
2014-02-05 17:37:15 -05:00
ADmad
d9489257d3
Don't return true from view classes' render() method.
...
It cause's Controller:render() to set the response body as `true`.
Refs #2780
2014-02-06 03:06:00 +05:30
Jimmy Madon
fcd41e45a7
Clarified ACL node lookup failed error.
...
Original error was ambiguous in stating whether the ARO node lookup failed or the ACO node lookup failed.
2014-02-05 18:25:14 +00:00
ukk1337
3cd6bb39bd
fixed coding standard errors
2014-02-04 15:37:23 +01:00
ukk1337
60c289fd68
removed indentation
2014-02-04 13:47:50 +01:00
ukk1337
9670a5af88
Added missing 'Session'-Compomnent in bake
...
If a Controller was baked interactively and one want to use Session flash messages, the required 'Session'-Component wasn't added to the $components-Array
2014-02-04 13:35:48 +01:00
José Lorenzo Rodríguez
2cd72126fe
Merge pull request #2766 from AD7six/2.4.x-bc-form-fix
...
BC fix for checkbox ids
2014-02-03 23:55:52 -08:00
AD7six
adc0bf3ded
BC fix for checkbox ids
...
Revert to previous behavior for id generation of checkboxes, This commit
can be reverted for 2.5+ is desired
Fixes #2733
2014-02-03 17:57:26 +00:00
mark_story
ecf5aec1ae
Add '@' to the list of characters removed from radio/checkbox ID.
...
This character can easily show up in email addresses and can cause
invalid HTML.
Refs #2733
2014-02-02 21:20:31 -05:00
Mark Story
405f3a1cb9
Merge pull request #2752 from rchavik/2.4-postgres-alterschema
...
Fix: Changing boolean to integer for Postgres
2014-01-31 06:46:52 -08:00
Rachman Chavik
59549b7ebe
Fix: Changing boolean to integer for Postgres
...
Closes #2751 , CakeDC/migrations#149
2014-01-31 15:14:20 +07:00
mark_story
4d57d3ce5b
Fix plugin path filtering when directories do not exist.
...
When paths do not exist we should correctly remove them from the output
paths.
Fixes #2748
2014-01-30 21:40:08 -05:00
mark_story
605351d0c9
Allow empty values in checkboxes.
...
Allow the checkbox value attribute to be empty. This is required to make
checkboxes with a value of 0.
Fixes #2717
2014-01-30 21:12:06 -05:00
José Lorenzo Rodríguez
b73cbf4a12
Merge pull request #2743 from mattalexx/fix-comment
...
Fix link in comment
2014-01-30 08:10:02 -08:00
Matt Alexander
dedefee87e
Fix link in comment
2014-01-30 10:07:45 -06:00
mark_story
e5b36f696d
Actually exclude core test cases from pear packages.
...
Refs #2620
2014-01-29 20:40:04 -05:00
ADmad
c349fd12c6
Merge pull request #2734 from walker/patch-1
...
Grammatical fix in API docs only
2014-01-29 09:59:10 -08:00
Walker Hamilton
df2fc07940
Grammatical fix in API docs only
...
Grammatical fix in API docs only
reset
2014-01-29 11:51:29 -06:00
Mark Story
8db034cbf1
Merge pull request #2731 from joostdekeijzer/console-extract-not-handling-validation-quotes
...
Console Extract task doesn't handle validation messages with qoutes correctly
2014-01-29 06:43:23 -08:00
Mark Story
5629dfdcc3
Merge pull request #2728 from joostdekeijzer/2721-fix-in-translatebehavior
...
Fix Model::field() and TranslateBehavior::beforeFind() not working together.
Fixes #2721
2014-01-29 06:40:27 -08:00
