José Lorenzo Rodríguez
28cb57a92c
Fixing bug in Model::escapeField() where it would return the wrong string id the datasource's name method returs the unmodified string.
...
Tests added. Closes #473
2010-03-17 10:32:36 -04:30
AD7six
bc990f41e3
Prevent sql error for uuids if id is specified as null
...
if the primary key is present in the data to be saved as null - prevent
passing the same key (id) twice and therefore triggering an sql error.
Signed-off-by: Mark Story <mark@mark-story.com>
2010-03-16 22:57:37 -04:00
José Lorenzo Rodríguez
cceb568520
Skiping some test in model_write test when using postgres as there is no way yet to do joins inside an update statement.
...
Possible enhancement would be transforming the join conditions into subquerys
2010-03-16 18:46:04 -04:30
José Lorenzo Rodríguez
c51f4076f7
Forcing order on find('all') in test. It is not safe to asume returned row order in postgres
2010-03-16 17:00:20 -04:30
José Lorenzo Rodríguez
201a952218
Fixing test for postgresql, it is no safe to asume the order of the returned results of a joined table
2010-03-16 15:12:27 -04:30
AD7six
0c951b7248
Prevent sql error for uuids if id is specified as null
...
if the primary key is present in the data to be saved as null - prevent
passing the same key (id) twice and therefore triggering an sql error.
Signed-off-by: Mark Story <mark@mark-story.com>
2010-03-15 23:32:46 -04:00
Mark Story
4861da66ed
Merge remote branch 'origin/1.2' into 1.2-merger
...
Conflicts:
cake/tests/cases/libs/model/datasources/dbo/dbo_postgres.test.php
2010-03-15 23:26:24 -04:00
Mark Story
661fcd32ab
Fixing failing tests in PostgreSQL cause by invalid datatype comparisons and missing id fields.
2010-03-15 23:07:18 -04:00
Mark Story
ea64588a81
Adding tests from 'Stephen Cuppert' to test incorrectly generate DELETE queries for habtm join tables that do not have a primary key when using PostgreSQL. Updating DboSource::_matchRecords() to only query the table if the supplied conditions are actually multi-table conditions. Fixes #459
2010-03-15 22:55:14 -04:00
Mark Story
3ab687043e
Updating DboPostgres test to reflect changes in test suite.
2010-03-14 19:27:36 -04:00
ADmad
70d0c64283
Removing constant REQUEST_MOBILE_UA, and added variable $mobileUA instead for mobile browser detection. Also added new user agent string 'webOS', closes #457
2010-03-15 01:58:38 +05:30
Mariano Iglesias
1120d0daff
Fixing issue in Containable where if bindModel was used to add / change a binding not permanently, Containable was making the change permanent
2010-03-14 16:37:50 -03:00
Mariano Iglesias
8d58b40642
Fixing issue in Containable where if bindModel was used to add / change a binding not permanently, Containable was making the change permanent
2010-03-14 16:34:57 -03:00
Mark Story
a51cceab18
Merge branch 'dbo-source-cache' into 1.3
2010-03-14 15:11:48 -04:00
Mark Story
5ec965830c
Fixing issues caused by daylight savings time switch.
2010-03-14 13:20:52 -04:00
Mark Story
c059cf5175
Implementing cacheMethod(). Helps to solve #458 , as it provides features to control and clear method caches.
2010-03-13 22:55:18 -05:00
ADmad
688daf2c35
Allowing the default transliteration map used in Inflector::slug to be customized using Inflector::rules. Closes #321 , #334 , #439 .
2010-03-14 02:22:46 +05:30
Mark Story
178099d15b
Adding test that closes #455
2010-03-13 00:26:23 -05:00
Mark Story
028668b7a6
Adding condition for counterCache update keys. Fixes issues where counter cache wouldn't be updated. Fixes #450
2010-03-13 00:18:51 -05:00
Mark Story
e304c48ec4
Adding test to show that select() doesn't always auto select options named 'Array'. Disproves #412
2010-03-12 23:17:11 -05:00
Mark Story
677ff2d8b7
Removing outcommented code.
2010-03-12 23:03:06 -05:00
Mark Story
239e34f032
Merge branch '1.2' of github.com:cakephp/cakephp1x into 1.2
2010-03-10 21:49:55 -05:00
Mark Story
64c627a352
Adding checks to force limit to always be a positive integer. Fixes potential out of bounds type queries with paginate(). Fixes #418
2010-03-10 21:49:22 -05:00
Mark Story
4c668c036c
Adding checks to force limit to always be a positive integer. Fixes potential out of bounds type queries with paginate(). Fixes #418
2010-03-10 21:46:28 -05:00
José Lorenzo Rodríguez
d8a757ce75
Fixing empty value check to avoid a mistaken default value selection in Helper::value. closes #290
2010-03-10 15:16:02 -04:30
Dieter Plaetinck
9a9bc3643b
fix typo in DboPostgresTestDb::testOrderAdditionalParams()
2010-03-10 14:34:17 -04:30
José Lorenzo Rodríguez
cbcd394d0b
Fixing alter schema queries generated for Postgres, which dos not support altering column type, nullable and default value at the same time
2010-03-09 16:09:16 -04:30
José Lorenzo Rodríguez
acccf964a5
Fixing some tests for Postgres Dbo and adding test cverage for extra params in order function, closes #353
2010-03-09 15:24:03 -04:30
Mark Story
af317a107b
Fixing issues in Set::combine() when data or paths used result in empty datasets. Tests added. Fixes #414
2010-03-08 23:07:36 -05:00
Mark Story
bed4027d37
Making JsHelper::writeBuffer() use the isAjax param to hint the domReady() event. Disabling domready events when the request isAjax fixes issues in prototype and makes output code simpler. Fixes #429
2010-03-08 22:51:46 -05:00
predominant
2218d186c8
Revert "Fixing escaping of forward slash for JS Engines."
...
This reverts commit 7334fdfbdf
.
2010-03-09 14:30:28 +11:00
predominant
7d81d81176
Merge remote branch 'origin/1.3' into 1.3
2010-03-09 12:28:06 +11:00
predominant
7334fdfbdf
Fixing escaping of forward slash for JS Engines.
2010-03-09 12:26:25 +11:00
Mark Story
e6664f0ea4
Fixing SQL errors when running model_behavior tests with postgresql. Fixes #406
2010-03-07 19:02:19 -05:00
Mark Story
1ae922cea1
Fixing missing reference operators in test cases.
2010-03-05 22:06:20 -05:00
Mark Story
af92276ba9
Adding missing reference operators to getInstance methods.
2010-03-05 21:41:48 -05:00
José Lorenzo Rodríguez
e4a5ca528c
Fixing virutal fields fetching for postgresql, closes #417
2010-03-05 16:07:59 -04:30
Mark Story
1d449e3847
Refactoring label generation into a method.
...
Fixing issues with labels having a for attribute = Array when an array of id's is provided.
Fixing issues where a date input would require you to provide id keys for hour, minute, and meridian even if you were not using them.
Fixes #411
2010-03-04 22:46:43 -05:00
predominant
382e11ccde
Changed Configure::write to return true on success. Maked testing result simpler.
2010-03-04 10:20:15 +11:00
hiromi2424
256ce41b1f
LC_TIME support multi-byte value.
2010-03-02 23:51:22 -04:30
Mark Story
3b3987de7f
Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3
2010-02-28 13:52:02 -05:00
Mark Story
65169971d4
Making memory leak test work with margins present in php5.3.1
2010-02-28 13:51:47 -05:00
Mark Story
428ee1998a
Updating paths so app layout doesn't break tests.
2010-02-28 13:44:04 -05:00
Mark Story
dbe35a495c
Updating Object test to include fixtures for both comment fixtures.
2010-02-28 13:34:37 -05:00
Mark Story
2a19a8d5e4
Updating CakeSchema test so it runs in both solo and group contexts. Changing table used on TestPluginComment to match its name.
2010-02-28 13:31:23 -05:00
Mark Story
27ffd43214
Fixing issue in component test where AppController will cause failing tests due to bleed through.
2010-02-28 12:48:34 -05:00
José Lorenzo Rodríguez
29eed5f5e8
Merge branch '1.3' of git@github.com:cakephp/cakephp1x into 1.3
2010-02-28 13:09:15 -04:30
José Lorenzo Rodríguez
f0e73e1158
Changing order of expectations to get more correct results
2010-02-28 13:08:36 -04:30
Mark Story
6360d8d306
Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3
2010-02-28 12:26:54 -05:00
Mark Story
322d8e667c
Removing duplicate method.
2010-02-28 12:26:15 -05:00
José Lorenzo Rodríguez
d5fa897681
Adding tests for startupProcess and shutDownProcess in controller
...
Fixing variable reference
2010-02-28 12:55:35 -04:30
Mark Story
e0eb48d250
Adding expectError to catch errors coming from FileEngine.
...
Fixing incorrect tests in ApcTest.
2010-02-28 12:15:25 -05:00
Mark Story
e0abe99d7d
Merge remote branch 'origin/1.2' into 1.2-merger
...
Conflicts:
cake/libs/view/helpers/html.php
cake/tests/cases/libs/folder.test.php
2010-02-28 01:58:29 -05:00
Mark Story
37cf55470f
Adding tests for Component::triggerCallback(). Deprecating other Component methods, as they are just wrappers for triggerCallback().
2010-02-28 01:49:19 -05:00
José Lorenzo Rodríguez
1f1e0f4ff7
Merge commit 'origin/1.3' into 1.3-form
2010-02-27 23:23:43 -04:30
José Lorenzo Rodríguez
b782563daf
Adding test for form input templates
2010-02-27 23:18:21 -04:30
José Lorenzo Rodríguez
0ca5c11e6c
Making the form helper put the "required" class on all imputs that have a validation rule and does not explicitly sets allowEmpty => true in validation array
2010-02-27 22:58:27 -04:30
Mark Story
ec5d9729b0
Model::find(first) no longer uses the id set in a model as the default conditions. Fixes #266
2010-02-27 11:32:29 -05:00
Mark Story
0960abcfb9
Removing workaround code for PHP 5.3.0. Error is no longer being generated in PHP 5.3.1
2010-02-27 11:26:16 -05:00
Mark Story
3192e130af
Fixing magic select creation for fields that have plural variables added to the view.
2010-02-27 11:01:28 -05:00
José Lorenzo Rodríguez
9a4de854d6
Improving the guessing process of required fields in the form helper.
...
Now it does not rely on the "required" property of the validation array anymore, which was misleading
2010-02-23 09:55:01 -04:30
Mark Story
fbf054b22b
Making FileEngine emit errors when a path does not exist but is used for caching. Should make cryptic errors coming from Cache easier to figure out. Removed useless private property.
...
Tests added.
Fixes #384
2010-02-22 23:21:30 -05:00
Mark Story
7075aa5e86
Fixing DboSource not quoting table/field names with - in them. Tests expanded . Fixes #323
2010-02-20 11:42:17 -05:00
Juan Basso
416abed211
Test of ticket #323 .
...
Signed-off-by: Mark Story <mark@mark-story.com>
2010-02-20 11:35:54 -05:00
Mark Story
763aa524b9
Fixing recursive directory creation when nested create() calls fail. Fixes #347
2010-02-20 11:25:46 -05:00
Mark Story
06fc87fc2d
Fixing lack of space in meta tags lacking a link attribute.
...
Fixes #371
2010-02-20 01:41:56 -05:00
Mark Story
f4c670e5be
Fixing lack of space in meta tags lacking a link attribute.
...
Fixes #371
2010-02-20 01:39:15 -05:00
Mark Story
6a3347ef7c
Merge remote branch 'origin/1.2' into 1.2-merger
...
Conflicts:
cake/VERSION.txt
cake/config/config.php
cake/console/libs/tasks/model.php
cake/dispatcher.php
cake/libs/l10n.php
cake/libs/model/datasources/dbo_source.php
cake/libs/view/pages/home.ctp
cake/tests/cases/console/libs/tasks/model.test.php
cake/tests/cases/libs/view/helpers/ajax.test.php
cake/tests/cases/libs/view/helpers/text.test.php
2010-02-20 01:32:04 -05:00
Mark Story
96bbbb2d72
Applying fixes made to JavascriptHelper to JsBaseEngine.
2010-02-17 22:27:52 -05:00
Mark Story
c7de42033c
Merge branch '1.2' of github.com:cakephp/cakephp1x into 1.2
2010-02-17 22:23:16 -05:00
Mark Story
ab688b88f4
Adding test to check that postfix and prefix options don't go into inner objects. Tests added, fixes #348
2010-02-17 22:22:53 -05:00
Mark Story
2209f198f8
Adding test to check that postfix and prefix options don't go into inner objects. Tests added, fixes #348
2010-02-17 22:21:48 -05:00
renan.saddam
63f7900ba1
Checking if the last query returned a error, tests added. Fixes #72 .
2010-02-17 22:31:00 -03:00
Mark Story
2279b1a736
Adding patches, and tests from tkykmw. Add support for plugin datasource drivers. Fixes #297
2010-02-16 22:35:16 -05:00
renan.saddam
d7b49e3494
Not forcing the use of ds, so will use $useDbConfig instead, tests added. Fixes #324 .
2010-02-15 14:46:18 -03:00
Mark Story
f04add4f79
Fixing querystring parameters being chopped off of absolute webroot asset paths.
2010-02-13 20:43:02 -05:00
Mark Story
6ccc43d776
Adding tests for Cache not generating errors when Cache.disable = true. Refs #286
2010-02-13 18:51:39 -05:00
Mark Story
7a655f7fde
Fixing broken skipIf commited in 46948dd2c0
2010-02-12 23:51:02 -05:00
Mark Story
46948dd2c0
Fixing memory leak in ThemeView where __paths would grow each time _paths() was called. Fixes #329
2010-02-11 22:57:24 -05:00
Mark Story
0ce14ceb7e
Adding return statement, preventing infinite loops when no default fields are bound, and unbindTranslation() is called with no fields. Fixes #307
2010-02-11 22:03:43 -05:00
Mark Story
0fda18d11c
Fixing entity encoding of url strings inside remoteFunctions contained in safe CDATA blocks. Fixes #127
2010-02-08 23:07:13 -05:00
Mark Story
9edf2d1d80
Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3
2010-02-07 16:45:55 -05:00
Mark Story
7384f56144
Fixing issues with old method names being used in EmailComponent.
2010-02-07 16:45:36 -05:00
ADmad
8c1c0e63c0
Allowing a html tag's attribute to be omitted from ouput by setting its value to null or false. Closes #316
2010-02-08 03:00:43 +05:30
Mark Story
6c3c5e9012
Merge remote branch 'rchavik/ticket_293' into 1.3
...
Conflicts:
cake/libs/controller/components/email.php
2010-02-07 16:26:37 -05:00
ADmad
6f08d86c8e
Links generated by PaginatorHelper::prev and PaginatorHelper::next are now wrapped in 'span' or the tag specified in options. Fixes #311
2010-02-07 23:56:50 +05:30
Mark Story
104da15a73
Making built-in Canadian postal code validation accept postal codes with no spaces. Fixes #289
2010-02-06 14:20:56 -05:00
Mark Story
e6404f2d06
Making built-in Canadian postal code validation accept postal codes with no spaces. Fixes #289
2010-02-06 14:20:28 -05:00
Mark Story
f389591085
Merge remote branch 'phally/1.3-email_component' into email-integration
2010-02-04 21:36:26 -05:00
rchavik
f585630286
Test case: EmailComponent $to accepts array (closes 293)
2010-02-04 09:35:33 +07:00
Mark Story
4b269e3170
Fixing RequestHandler::beforeRedirect() and issues with array urls, where incompatibilities between standard url arrays and requestAction url arrays caused incorrect results. Tests added. Fixes #276
2010-02-02 20:39:33 -05:00
Mark Story
7daad4acaf
Merge branch '1.2' of github.com:cakephp/cakephp1x into 1.2
2010-02-02 20:39:25 -05:00
Mark Story
2adac05dad
Fixing RequestHandler::beforeRedirect() and issues with array urls, where incompatibilities between standard url arrays and requestAction url arrays caused incorrect results. Tests added. Fixes #276
2010-02-02 20:39:05 -05:00
predominant
8d382d9168
Fixes #288 . TextHelper truncation not playing nice with html in ending.
2010-02-02 09:13:52 +11:00
José Lorenzo Rodríguez
aadf62de6e
Improving tests for Set::diff
2010-01-31 20:26:57 -04:30
ADmad
59a4732eb8
Fixing issue where value of '$and' was appended to output string even when list array contained only one element. Fixed #285
2010-01-31 23:43:58 +05:30
Mark Story
7fb7c5ebf6
Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3
2010-01-29 11:56:09 -05:00
Mark Story
887ddb9575
Adding tests for deletion of multiple habtm associations. Reverting changes made in [ 15518b8c9a
] that caused incorrect removal of links when deleting records. Fixes #247
2010-01-29 11:55:18 -05:00
Mark Story
832b15ba3e
Fixing issues in JqueryEngineHelper where eval()'ed responses wouldn't run code contained inside $js->domReady() due to implementation differences between $(document).ready() and $(document).bind('ready'). Tests updated.
2010-01-29 10:06:47 -05:00
Mark Story
30cb38eb93
Refactoring extensions in ScaffoldView to reflect removal of magic .thtml extension.
...
Adding test for interaction of Themed views and Scaffolded views. Fixes #255
2010-01-28 11:11:19 -05:00