adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2024-11-15 03:18:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixing issues in JqueryEngineHelper where eval()'ed responses wouldn't run code contained inside $js->domReady() due to implementation differences between $(document).ready() and $(document).bind('ready'). Tests updated.

Browse source
This commit is contained in:
Mark Story 2010-01-29 10:06:47 -05:00
parent 38365924eb
commit 832b15ba3e
2 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
cake/libs/view/helpers/jquery_engine.php
View file

@ -178,15 +178,19 @@ class JqueryEngineHelper extends JsBaseEngineHelper {
}
/**
* Create a domReady event. For jQuery
* Create a domReady event. For jQuery. This method does not
* bind a 'traditional event' as `$(document).bind('ready', fn)`
* Works in an entirely different fashion than `$(document).ready()`
* The first will not run the function when eval()'d as part of a response
* The second will. Because of the way that ajax pagination is done
* `$().ready()` is used.
*
* @param string $functionBody The code to run on domReady
* @return string completed domReady method
* @access public
*/
function domReady($functionBody) {
$this->get('document');
return $this->event('ready', $functionBody, array('stop' => false));
return $this->jQueryObject . '(document).ready(function () {' . $functionBody . '});';
}
/**

2
cake/tests/cases/libs/view/helpers/jquery_engine.test.php
View file

@ -89,7 +89,7 @@ class JqueryEngineHelperTestCase extends CakeTestCase {
*/
function testDomReady() {
$result = $this->Jquery->domReady('foo.name = "bar";');
$expected = '$(document).bind("ready", function (event) {foo.name = "bar";});';
$expected = '$(document).ready(function () {foo.name = "bar";});';
$this->assertEqual($result, $expected);
}