adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2024-11-16 03:48:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
9472 commits 7 branches 0 tags 44 MiB
Commit graph

4321 commits

Author SHA1 Message Date
mark_story
769da1a7c8 Adding basic BehaviorCollection::hasMethod implementation. Tests added. 2010-12-26 16:44:50 -05:00
mark_story
edf567b9f9 Adding convertKeys to PaginatorHelper::options(). 
Added a test case.
Fixes #1390
 2010-12-26 13:24:05 -05:00
mark_story
ee3017599d Merge branch '2.0' into 2.0-pagination 
Conflicts:
	cake/libs/controller/components/paginator.php
	cake/libs/router.php
 2010-12-24 14:43:11 -05:00
mark_story
ef77e60cb0 Removing @subpackage tags, moving contents of @subpackage into @package. 
Removing duplicate cake.cake in @package tags.
Renaming cake.app -> app
 2010-12-24 14:09:57 -05:00
mark_story
e20ea8ad72 Renaming Dispatcher::__loadRoutes -> Dispatcher::_loadRoutes to match naming conventions. 
Updating method name usage, as assertType is deprecated as of PHPUnit 3.5.6
 2010-12-24 12:54:04 -05:00
mark_story
f85567a566 Removing @author tags that snuck in. 2010-12-21 21:58:20 -05:00
mark_story
6f62c22cbc Fixing fencepost errors. 
Splitting tests up into smaller groups.
 2010-12-20 20:27:27 -05:00
mark_story
abc6a28eca Increasing code coverage. 2010-12-20 14:02:12 -05:00
mark_story
0b90195a52 Adding tests for creating next/prev links with querystrings. 
Removing code that doesn't seem to do anything, no tests fail when its removed.
 2010-12-20 13:59:09 -05:00
mark_story
d7e411650f Moving some tests around so its easier to figure out what's being tested. 
Adding a querystring test.
 2010-12-20 13:39:22 -05:00
mark_story
e5588f746c Reversing changes that required a : sigil for named parameters. Also removing ?foo style parameters for querystring args. Having two ways to create querystring args was not sitting well with me. 
Tests updated.
 2010-12-19 23:11:02 -05:00
mark_story
b49b49a5ef Removing named parameter sigils. 2010-12-19 22:17:57 -05:00
mark_story
d3fc29c8e8 Adding more documentation to connectNamed(). 
Changing argSeparator -> separator, as it is less typing and easier to remember.
 2010-12-19 21:49:17 -05:00
mark_story
4c3736a68a Making more tests pass with the named parameter changes. 2010-12-19 17:38:21 -05:00
mark_story
51e2b16d46 Removing pagination test from Containable test case, it doesn't make sense there. 2010-12-19 17:24:38 -05:00
mark_story
5df2678ba9 Fixing named params that were missing the : and fixing Router::reverse() so it adds in the : 2010-12-19 17:09:34 -05:00
mark_story
c83a4703a3 Implementing ability to change pagination params to use querystring variables. 
Tests added.
 2010-12-19 16:47:22 -05:00
mark_story
da46ad494b Deleting duplicate tests. 
Moving a test out into a separate method.
 2010-12-19 13:53:11 -05:00
mark_story
cc2d8e2fec Moving limit from the options to the normal paging params. This fixes a few notice errors. 2010-12-19 13:15:04 -05:00
mark_story
176d5520f6 Making paging params match those that would be generated by PaginatorComponent. 2010-12-19 13:09:52 -05:00
mark_story
8c3ceff50d Making paging.options only contain options that are not in the defaults. This replaces the many diffs that were calculated on each url generation between paging.options and paging.defaults. 2010-12-19 12:58:07 -05:00
mark_story
833bdbcc0b Reformatting paging params. 
Removing defaults from the paging params as they are no longer being used.
 2010-12-19 12:43:29 -05:00
mark_story
e9d3fcf5cf Moving limit checking into a separate method, and adding tests. 
Removing $scope from being passed down to the options, it previously only allowed additional conditions to be set.
Updated tests.
 2010-12-19 11:58:35 -05:00
mark_story
108a6611a8 Moving validation of sorting to a separate method. This makes it easier to test, extends and read. 
Tests added.
 2010-12-19 02:12:39 -05:00
mark_story
7b11eeb6e0 Updating tests to not use the deprecated Controller::$passedArgs. 
Removing messy and hard to understand defaults + whitelisting from paginate() now that it has a separate method.
 2010-12-19 01:57:51 -05:00
mark_story
6b3db0a3eb Pulling out parameter merging logic into a method, this allows specific typing of parameter merging (named, querystring, route). Also simplifies whitelisting of request parameters. 
Tests added for merging and whitelisting.
 2010-12-19 01:42:23 -05:00
mark_story
7585b2941e Adding paramType to the test cases. 2010-12-19 00:38:20 -05:00
mark_story
54c52d85fb Fixing failing tests in PaginatorComponent. 2010-12-18 17:29:47 -05:00
mark_story
6b9d9f4aea Reapplying changes in [33d2f9a6ed] as they got lost when the paginator component was extracted. 2010-12-18 17:17:43 -05:00
mark_story
7c6af5bfec Making a test actually test what its supposed to. 2010-12-18 17:01:26 -05:00
mark_story
319e622151 Added another test for querystring params. Querystring params should not be affected by greedy routes, as they are not really controlled by internal routing. 2010-12-18 16:51:54 -05:00
mark_story
eb9fe07472 Adding query string generation into CakeRoute. This removes one more task from Router. Tests added 
Adding constants for the named param and querystring param sigils.
 2010-12-18 16:44:21 -05:00
mark_story
b1630d4f07 Removing garbage from Paginator test cases. 2010-12-18 15:48:14 -05:00
mark_story
3b0a3d4109 Making route matching fail even faster. This gives significant performance boosts to routes not matching. 2010-12-18 14:36:11 -05:00
mark_story
756b09849f Router tests all pass now. 2010-12-18 14:26:45 -05:00
mark_story
328db0c36b Fixed a number of tests, there are still a few issues with prefix routes. 
Moved removing defaults that are also keys to the compile step.  This
removes quite a few repetitive loops.
 2010-12-18 14:18:21 -05:00
mark_story
8d404332a2 Fixing issue where named params equal to null/false would be part of the generated url. 2010-12-18 13:40:07 -05:00
mark_story
6ef8203d54 Adding another case that makes false/null to not cause match failure. 2010-12-18 13:32:05 -05:00
mark_story
456a14cf37 Refactored CakeRoute::match() to not use Set::diff(). This was the slowest part of reverse routing and this change should make things faster. 
Added additional tests for the 0 edge case.
 2010-12-18 12:34:48 -05:00
mark_story
c5bab54125 Starting to try and re-factor named params to perform better and be more 
explicit with how they are used.
 2010-12-18 00:15:09 -05:00
mark_story
de7b324444 Fixing more strict warnings. 
Removing & on component callbacks.
Updating incorrect method signatures.
 2010-12-18 00:03:03 -05:00
mark_story
24373ae3c1 Removing uses() it was deprecated in 1.3. Use App::import() instead. 2010-12-16 23:05:39 -05:00
mark_story
f50a97bff1 Making PagesController test unskipped in all_tests. 2010-12-16 22:53:00 -05:00
mark_story
42754c63ff Making more tests no longer skip in test suites. 2010-12-16 00:01:43 -05:00
mark_story
95f58321a8 Removing a duplicate test, and extra classes. 2010-12-15 23:54:28 -05:00
mark_story
339cb41ea2 Using $_mergeParent to unskip tests in test suites. 2010-12-15 23:49:54 -05:00
mark_story
862a2bc25e Removing duplicate class definition that could cause test suite inconsistencies. 
Adding skip for when AppController is defined.
Changing how mock models are constructed to better use Model::__construct parameters.
 2010-12-15 23:33:00 -05:00
mark_story
9dcea304c1 making assertions run against the test case, not the subject test case. 2010-12-15 22:19:44 -05:00
mark_story
5ff376e0a0 Adding parent calls. 2010-12-15 22:12:48 -05:00
mark_story
a054695dca Fixing failing tests. 2010-12-15 22:08:24 -05:00