Commit graph

7236 commits

Author SHA1 Message Date
Mark Story
9303de936e Fixing fatal error trying to run coverage on the coverage reporter.
Removing old CodeCoverageManager implementation.
2010-05-13 21:44:30 -04:00
Mark Story
e76c05b2b9 Merge branch '2.0-coverage' into 2.0-phpunit 2010-05-13 21:39:23 -04:00
Mark Story
5e29cfc21e Adding TextCoverageReport and extracting a base class.
Updating the coverage classes to use the new class structure.
2010-05-13 21:36:23 -04:00
Juan Basso
db4f7a2625 Fixing search of test cases and groups for PHP 5.2. 2010-05-13 18:48:34 -03:00
José Lorenzo Rodríguez
689e46be4f Converting ConfigureTest to phpunit 2010-05-13 00:52:38 -04:30
José Lorenzo Rodríguez
f3f37a126f Converting CakeSocketTest to phpunit 2010-05-13 00:50:30 -04:30
José Lorenzo Rodríguez
01e36ce2c4 Improving compatobility method detection in paintError, so the failing line and method is correctly pointed out in the reporter 2010-05-13 00:48:03 -04:30
José Lorenzo Rodríguez
72959e7872 Converting CAkeSessionTest to phpunit 2010-05-13 00:21:16 -04:30
José Lorenzo Rodríguez
6613cfb662 Migrating CacheTest to phpunit 2010-05-13 00:13:40 -04:30
José Lorenzo Rodríguez
c1dc753be5 Replacing call of static:: for self as it is php 5.3 specific 2010-05-13 00:08:35 -04:30
José Lorenzo Rodríguez
3e3817f113 Merge commit 'mark/2.0-coverage' into 2.0-phpunit
Conflicts:
	cake/tests/lib/reporter/cake_html_reporter.php
2010-05-13 00:05:30 -04:30
José Lorenzo Rodríguez
8c3df122eb Merge commit 'lorenzo/2.0-phpunit' into 2.0-phpunit
Conflicts:
	cake/tests/lib/reporter/cake_html_reporter.php
	cake/tests/lib/test_manager.php
2010-05-12 23:58:56 -04:30
Mark Story
17f338a9b2 Moving methods up into CakeBaseReporter.
Starting to make CakeTextReporter work well with PHPUnit so the Text code coverage reporting can be implemented.
2010-05-13 00:18:22 -04:00
Mark Story
d349551dd7 Adding tests for generating method coverage with the reporter.
Adding method visibility
2010-05-12 22:43:44 -04:00
Mark Story
cb9d6f478d Making coverage reports show what tests covered the line being hovered over. Updating CSS to help facilitate hover effects. 2010-05-12 22:13:12 -04:00
Mark Story
79839c07d2 Fixing issues where ModelBehavior::detach() would not detach behaviors when a plugin.name was provided. This change makes detach() work like attach(). Tests added. Fixes #711 2010-05-11 23:08:14 -04:00
Mark Story
0648c6604b Adding some additional tests for possible php4 compatibility issues. 2010-05-11 23:01:40 -04:00
Mark Story
6add43a4bc Fixing issue where id = null could cause SQL errors when saving more than one record with a null id. Fixes #675 2010-05-11 22:40:56 -04:00
ADmad
3539660cd0 Space is now properly added inbetween when 'asc'/'desc' class is appended to user defined css class in PaginatorHelper::sort. Fixes #710 2010-05-12 00:42:02 +05:30
Mark Story
6e355312bb Fixing issue where Config.timeout wouldn't correctly countdown when many quick requests were sent. 2010-05-11 00:39:10 -04:00
Richard Sbresny
05beaab272 Removed unnecessary unset
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:14:38 -04:00
Richard Sbresny
b04a3f8514 Switched over to using the previously unused Security::inactiveMins() method for getting timeout modifiers
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:14:20 -04:00
Richard Sbresny
5cf08cbe92 Updated default values to reflect the static values previously set
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:12:15 -04:00
Richard Sbresny
c62ae5e48a Included timeout multiplier factor to be used not just inside a session start
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:11:44 -04:00
Richard Sbresny
a4950f6940 Updated session timeout calculations to use the security level from core.php as the multiplier.
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:11:20 -04:00
Mark Story
96d0119abc Applying patches from 'wals' to fix uses where incorrect parameters were being passed into methods, and making methods match their documentation blocks. Fixes #668 2010-05-10 23:58:22 -04:00
Robert Sworder
ec10a01504 Changing home.ctp to remove references to 1.2. Fixes #705
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-10 23:48:12 -04:00
Mark Story
91a40a0104 Making null check explicit so falsey default values can be used. Fixes #695 2010-05-10 23:46:47 -04:00
predominant
8f880731c6 Removing closing PHP tags. 2010-05-11 08:27:28 +10:00
predominant
1ec220dac2 Removing closing PHP tags. 2010-05-11 08:07:49 +10:00
Mark Story
687eab9528 Adding a toggle all button to the coverage report. Makes it easier to see the test subject at a glance.
Adding ability to only show files that match the extension-less basename of the test case file.  This hides much of the noise the new reports have.
2010-05-09 23:20:28 -04:00
Mark Story
e8e2235cfa Updating coverage report and tests to include hiding javascript. 2010-05-09 22:15:20 -04:00
José Lorenzo Rodríguez
765de657e6 Fixing PaginatorHelperTest to be compatible with PHPUnit 2010-05-09 18:49:04 -04:30
José Lorenzo Rodríguez
1e01e21bf9 Impriving the default for expectExpection 2010-05-09 18:48:39 -04:30
José Lorenzo Rodríguez
bc9479efcf Fixing XmlTest to be compatible with PHPUnit 2010-05-09 18:18:40 -04:30
José Lorenzo Rodríguez
508d707a7a Adding another compatibility test method: assertWithinMargin 2010-05-09 18:16:42 -04:30
José Lorenzo Rodríguez
88d21fbea4 Experimental change: restoring the error handler to steps back in the stack to let PHPUnit take over when running tests 2010-05-09 18:15:51 -04:30
José Lorenzo Rodríguez
809550087c Finxing ThemeTest to be compatible with PHPUnit 2010-05-09 16:27:09 -04:30
José Lorenzo Rodríguez
c96b14541d Adding new compatibility method for CakeTestCase 2010-05-09 16:09:57 -04:30
José Lorenzo Rodríguez
d252fdeb52 Fixing View test case to be compatible with PHPUnit 2010-05-09 16:09:02 -04:30
Mark Story
f084a82dfc Refactoring how coverage diffs are generated to better use data from phpunit. Removing methods made redundant by data changes. 2010-05-09 12:30:55 -04:00
Mark Story
ac318faf5a Switching back to using non raw code coverage data as it has been filtered by phpunit's filters. combining the data from phpunit into a singular cohesive report. 2010-05-09 02:08:32 -04:00
Mark Story
3c3655aefd Fixing failing tests. 2010-05-09 01:16:44 -04:00
Mark Story
75d7146bd0 Updating code coverage tools to use raw data which includes dead and uncovered line data. 2010-05-09 01:15:57 -04:00
Mark Story
9a20a2344b Continuing work on updated code coverage reports. 2010-05-09 00:40:05 -04:00
Mark Story
955c6bea9f Verbose coverage generation has been added and tests added. 2010-05-09 00:04:03 -04:00
José Lorenzo Rodríguez
b8e83e6a49 Adding documentation for CakeFixtureManager 2010-05-08 17:50:55 -04:30
Mark Story
f6b49cd865 Updating file headers. 2010-05-08 18:12:20 -04:00
Mark Story
ccf5601a69 Updating coverage report initialization. 2010-05-08 18:12:03 -04:00
Mark Story
fad99ad1f4 Adding tests for merging of report data. 2010-05-08 18:08:02 -04:00
José Lorenzo Rodríguez
f5cfc325f8 Adding some missing doc blocks 2010-05-08 17:29:33 -04:30
Mark Story
ac5f731940 Starting work on HtmlCoverageReport and adding a test case. 2010-05-08 17:59:14 -04:00
José Lorenzo Rodríguez
79c001197d Merge commit 'mark/2.0-phpunit' into 2.0-phpunit
Conflicts:
	cake/tests/lib/test_manager.php
2010-05-08 17:18:43 -04:30
José Lorenzo Rodríguez
72f162f52a Adding docs to CakeTestSuite 2010-05-08 16:52:29 -04:30
Mark Story
fd073809d0 Removing references to non phpunit code coverage parsing.
Adding stub of new code coverage report generator.
Updating related files.
2010-05-08 17:14:47 -04:00
José Lorenzo Rodríguez
fb09adca68 Adding tests for skipIf 2010-05-08 16:36:11 -04:30
José Lorenzo Rodríguez
4d3a6e8ca6 Fixing and testing for CakeTestCase::loadFixtures() 2010-05-08 16:14:22 -04:30
José Lorenzo Rodríguez
2b5cd26fc6 Adding tests for CakeTestCase fixtures 2010-05-08 15:56:21 -04:30
José Lorenzo Rodríguez
5d041c58b7 Using the CakeTesSuite in TestManager and calling accordingly the load and unload of fixtures using the variable
$sharedFixture
2010-05-08 15:55:16 -04:30
José Lorenzo Rodríguez
ec9c8b4d49 Adding the new class CakeTestSuite to setup some utility stuff like fixtures outside of CakeTestCase 2010-05-08 15:53:29 -04:30
José Lorenzo Rodríguez
acb9733d0e Convertint CakeFixtureManager into a non-static class to be able to replace it with custom implementations
and to test it more easily
2010-05-08 15:52:11 -04:30
Mark Story
507c3b2d94 Adding the CakePHP testing classes to the coverage ignore filter for PHPUnit. Starting to refactor how coverage is generated, to use more features of PHPUnit. 2010-05-08 16:18:45 -04:00
Mark Story
933378223b Updating CakeLog tests to use @expectedException annotation. 2010-05-08 16:17:20 -04:00
Mark Story
e7ff0bdf66 Adding missing parameters to assertEqual() wrapper.
Adding assertNotEqual() wrapper.
Adding expectError() but it doesn't work because of Debugger's error handler being set.
Fixing fatal error where getDescription would not be defined.
2010-05-08 11:42:04 -04:00
José Lorenzo Rodríguez
82a1bd6f80 Cleaning up CakeTestCase and adding some tests for it 2010-05-08 01:19:45 -04:30
Mark Story
1a7dce3af6 Updating DboMysql to fix an issue where virtualFields that were simple
aliases to fields on other tables would end up in the wrong place.
Tests added.  Fixes #655
2010-05-07 23:26:13 -04:00
Mark Story
745afe888b Adding more tests for saving records with nulls. Closes #675 2010-05-07 22:23:18 -04:00
Mark Story
0930b5c63c Adding more documentation for JsHelper::submit(). Closes #681 2010-05-07 21:26:44 -04:00
José Lorenzo Rodríguez
e81cc684ef Merge branch '2.0-phpunit' of git@github.com:lorenzo/cakephp1x into 2.0-phpunit
Conflicts:
	cake/tests/lib/cake_test_case.php
2010-05-07 19:48:50 -04:30
José Lorenzo Rodríguez
7124e6db3e Refactoring CakeTestCase to remove fixture specific code and use the new class CakeFixtureManager.
It lacks support to auto-drop tables after test case end, but it is already usable for testing
2010-05-07 18:07:02 -04:30
José Lorenzo Rodríguez
ef142b1659 Adding the class CakeFixtureManager to delegate the task of creating and droping the fixtures
Tests and docs still pending
2010-05-07 18:06:17 -04:30
Mark Story
f152181c03 Adding tests for saving models with id == null. Closes #675 2010-05-06 22:24:11 -04:00
Mark Story
1c3415759a Fixing 'Only variables should be assigned by reference' errors in php4 in form helper. Fixes #643 2010-05-06 22:11:31 -04:00
Mark Story
1c1c511853 Changing how email validation methods are applied, to fix issues where getmxrr() exists but the domain being validated does not have MX records correctly configured. Fixes #634 2010-05-06 21:43:58 -04:00
Mark Story
45d052b55a Fixing failing tests in ViewTask test case, caused by changes in core templates.
Fixing incorrect variable usage where models would be double singularized causing incorrect names.  Fixes #668
2010-05-06 21:38:14 -04:00
Mark Story
5ea4f027db Fixing TestTask so that if you give an invalid class type you get an error. 2010-05-06 07:31:52 -04:00
José Lorenzo Rodríguez
bed87b87c6 Removing code from CakeTestCase around the method "testAction" which was a bad way of testing controllers, often making it more difficult.
This also removes class contamination in newly created test cases
2010-05-05 22:42:56 -04:30
José Lorenzo Rodríguez
b53d21ff52 Fixing a group test case to show how to create one, and to make pass TestManager test case 2010-05-04 23:58:17 -04:30
José Lorenzo Rodríguez
fd4a82d6e9 Adding test for TestManager::runGroupTest() 2010-05-04 23:56:40 -04:30
José Lorenzo Rodríguez
856a52a378 Changing runGrouptTest to find for conventional class names. This commit removes the support for loading more than one groupt test class per file 2010-05-04 23:13:07 -04:30
Mark Story
918e961f7d Fixing typo in testtask. Fixes #659 2010-05-04 23:29:54 -04:00
Mark Story
fcad9b464c Fixing tests broken by changes in default bake templates.
Fixing issue where admin methods wouldn't be correctly generated.
Fixes #664
2010-05-04 23:27:41 -04:00
José Lorenzo Rodríguez
41683723f7 Making more methods static in TestManager 2010-05-04 21:04:18 -04:30
José Lorenzo Rodríguez
c23f66e35c Removing "extends" from TestManager as it wasn't used anyway.
Making some methods static as they were called statically
More testing on TestManager
2010-05-04 20:51:58 -04:30
predominant
719836c41d Updated doc block for added HTTP Status. 2010-05-05 10:09:47 +10:00
José Lorenzo Rodríguez
cdf4006f16 Refactoring TestManager::runAllTests() and improving the TestManager test case 2010-05-04 18:25:15 -04:30
José Lorenzo Rodríguez
4a152d3d55 Adding number of assertion runned in html reporter
enabling "show passes" (that in contrast of simpletest only reports the passed test method instead of the assertion)
cleaning up a bit
2010-05-04 16:31:03 -04:30
José Lorenzo Rodríguez
10434c35b6 Improving PHPUnit path detection when it is installed via pear 2010-05-04 16:30:06 -04:30
José Lorenzo Rodríguez
9afbeaa217 Converting CakeHtmlReporter in a TestCase listener.
this apparently shows that it is easy to make the transition to PHPUnit.
2010-05-04 13:51:25 -04:30
José Lorenzo Rodríguez
ce7f892d6a Removing simpletest dependency in CakeBaseReporter 2010-05-04 13:50:07 -04:30
José Lorenzo Rodríguez
15dd798e30 Some experimental movements inside TEstManager to make it work with PHPUnit 2010-05-04 13:49:10 -04:30
José Lorenzo Rodríguez
14559aabd9 Adding compatibility assert methods for CakeTestCase to ease the transition to PHPUnit 2010-05-04 13:47:08 -04:30
José Lorenzo Rodríguez
7417a00de7 Initial step to replace simpletest for PHPUnit
This is probably temporary, still needed to see if PHPUnit is already in path (installed with pear or something)
2010-05-04 13:40:50 -04:30
Mark Story
ce10c85367 Making Sanitize::stripScripts() to remove multi-line script and style blocks. Fixes #657 2010-05-03 22:33:20 -04:00
Mark Story
95dbae8acf Making RequestHandler component carry along a passed status code. This fixes issues where RequestHandler hijacks an redirect(). Fixes #658 2010-05-03 22:07:13 -04:00
predominant
87db966383 Remove PHP5 conditional statements. 2010-05-03 13:36:32 +10:00
predominant
c1eaa4b24c Fixed access and removed @access tags. 2010-05-03 13:28:09 +10:00
Mark Story
c48f6d6536 Fixing safe parameter from leaking into request() calls in JsHelper::submit() and JsHelper::link(). Fixes #656 2010-05-02 21:17:10 -04:00
Jose Diaz-Gonzalez
1180f66cc0 Setting $actions to null so that the controller methods are not always based upon the first controller in an app/plugin.
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-02 20:35:19 -04:00
Mark Story
dc08aedb44 Fixing constructors for reporter classes. 2010-05-02 17:54:49 -04:00