mark_story
d6e3c318cd
Merge branch '1.3' of github.com:cakephp/cakephp into 1.3
2010-08-04 23:59:17 -04:00
mark_story
a04fe5f81d
Making Router::reverse() strip out additional framework internal parameters that are specific to requestAction. Refs #977
2010-08-04 23:35:49 -04:00
mark_story
8119f77659
Reformatting long lines.
2010-08-04 23:18:33 -04:00
mark_story
43bf1c539a
Separating the various requestAction tests into separate test methods.
2010-08-04 23:16:26 -04:00
mark_story
22673a5348
Adding a test case for CacheHelper correctly generating filenames when $this->here includes all the named and passed args. Refs #977
2010-08-04 23:08:43 -04:00
Juan Basso
72bb229a9c
Added tests to ticket #959
2010-08-04 22:10:44 -03:00
Dirk Brünsicke
712ca6d5b5
Fixing bug in String::insert that produces unexpected results with
...
multiple keys that start with the same substring. Fixes #984
Signed-off-by: mark_story <mark@mark-story.com>
2010-08-03 22:38:45 -04:00
mark_story
3099a15f17
Removing old check for view == 'Theme'. This allows Scaffold to work well with Themed controllers. Test case added. Fixes #255
2010-08-01 22:25:29 -04:00
mark_story
522446e0c2
Fixing issues where route elements could not have '-' in the parameter name because of limitations in pcre named capturing subpatterns. Tests added. Fixes #974
2010-07-31 13:03:45 -04:00
mark_story
86cae09d79
Merge branch '1.3' of github.com:cakephp/cakephp into 1.3
2010-07-31 11:59:21 -04:00
ADmad
d04b327469
Fixing test case as it was error prone. Assuming the first value of $plugins array to be 'plugin_js' was incorrect.
2010-07-31 21:08:10 +05:30
mark_story
5efddf9a41
Adding a test case for route params with hyphens. Refs #974
2010-07-31 11:23:02 -04:00
mark_story
373bebb128
Updating test suite to properly handle parent_id situations. Fixes #881
2010-07-29 22:26:30 -04:00
mark_story
ac9721d582
Wrapping long lines.
2010-07-29 22:07:45 -04:00
mark_story
2b1efafe65
Applying optimization from 'michaelc' to reduce number of strtolower() calls in AclBehavior. Fixes #972
2010-07-29 22:04:22 -04:00
mark_story
3bda2ce100
Adding tests for database imports causing duplicated db prefix. Adding a workaround for the duplicated prefix name.
...
Fixes #962
2010-07-29 22:01:12 -04:00
mark_story
a9bb4eefae
Fixing failing test caused by registry pollution.
...
Adding a test case to prove that unqualified column names work with postgresql. Closes #930
2010-07-29 00:06:11 -04:00
mark_story
596c751ea3
Converting spaces to tabs.
2010-07-28 23:42:36 -04:00
ADmad
6527e9269a
Fixing detection and automatic appending of extension '.js' to urls in call to HtmlHelper::script(). Closes #965
2010-07-29 02:11:00 +05:30
mark_story
a965056af7
Merge remote branch 'origin/1.3' into 1.3
2010-07-23 21:12:44 -04:00
Juan Basso
5b7b2d074e
Putting the port in header Host, following RFC 2616 item 14.23. Fixes #947 .
2010-07-23 00:13:19 -03:00
mark_story
fbb54e6a45
Adding a test case for nested array data and clean().
2010-07-21 23:37:14 -04:00
Scott Reeves
88e32b3cee
Fixing typo
...
Signed-off-by: mark_story <mark@mark-story.com>
2010-07-19 23:15:28 -04:00
mark_story
0c312e3d77
Adding some destroy() calls to cause the timestamps to refresh.
2010-07-18 22:56:57 -04:00
predominant
ca1c8f1f80
Remvoed session destruction from tests.
2010-07-19 12:14:44 +10:00
mark_story
a78bb20bda
Fixing failing test in ControllerTest caused by ThemeView not being correctly found if it was not in the mapped files.
2010-07-18 21:28:52 -04:00
mark_story
41997b06e1
Fixing issues where mb_internal_encoding() might not be correctly set, causing email subjects to be incorrectly encoded. Tests added. Fixes #904
2010-07-18 20:48:15 -04:00
mark_story
4c27c24a72
Fixing issue in DboSource where COUNT() was hardcoded, omitting any other aggregate functions. Replaced with a regexp that accepts only letters. Test case added. Fixes #878
2010-07-15 23:17:38 -04:00
mark_story
0e184c66f4
Adding failing test for #917
2010-07-15 21:52:24 -04:00
mark_story
e382a1c63c
Adding test case for find(list) with recursive.
2010-07-11 18:38:27 -04:00
mark_story
65efd675c1
Fixing fatal error caused by associated models using a datasource that is not a subclass of dbo_source. Test added. Fixes #873
2010-07-11 13:06:33 -04:00
mark_story
103346155f
Fixing HttpSocket losing auth credentials when multiple requests are made with the same object. Fixes #893
2010-07-06 22:30:48 -04:00
mark_story
60ab9800e2
Fixes issue where CakeSession::destroy() would fail to properly restart the session. Tests added. Fixes #787
2010-07-03 18:34:02 -04:00
mark_story
4cd43553b4
Fixing issues where multiple reset bindModel() calls would cause incorrect associations to be restored.
...
Also fixing issues where multiple calls to unbindModel() would cause incorrect associations to be restored.
Tests added.
Fixes #889
2010-07-03 18:05:14 -04:00
mark_story
17a7a96ba2
Fixing issue where non-reset associations would get reset by resetAssociations if __backAssociations existed. Test cases from 'real34' added. Fixes #868
2010-07-01 12:39:50 -04:00
mark_story
8581350d24
Fixing failing tests.
2010-06-30 22:51:21 -04:00
mark_story
991d035806
Fixing respondAs() so it can be called multiple times. Test cases added for respondAs. Fixes #842
2010-06-30 22:34:33 -04:00
mark_story
dc72529648
Implementing assettimestamps for themes and plugins. Tests added. Fixes #804 , #879
2010-06-30 20:47:54 -04:00
mark_story
91f8e220e4
Adding App::themePath(). Will be used to reduce code duplication in a variety of places.
2010-06-30 20:17:17 -04:00
mark_story
94965f0f6c
Adding an additional test for View::entity().
...
Fixing issue where nulls would be shifted onto the entity array causing incorrect name attributes. Fixes #867
2010-06-28 21:38:17 -04:00
mark_story
f11f9ebc68
Adding test case for #867 .
2010-06-28 21:32:49 -04:00
mark_story
4b93e61ed3
Adding cookieLifeTime var declaration as it was omitted.
...
Updating session timeout values so they reflect their values in the past.
Making cookieLifeTime configurable in the medium/low security levels.
Fixing Config.timeout setting to go back to 10.
Fixes #798
2010-06-27 12:52:18 -04:00
mark_story
c119ec4d23
Merging in changes from Voidet to correct session times. Minutes were
...
being used instead of seconds, for a value that expected seconds.
Conflicts:
cake/libs/cake_session.php
cake/tests/cases/libs/controller/components/session.test.php
2010-06-27 12:17:37 -04:00
Juan Basso
9bbaf153f7
Setting cookies in a single line. Fixes #48
2010-06-23 00:10:21 -03:00
mark_story
5945edd983
Removing strtolower call that was breaking autolinks for URL shorteners. Tests added. Fixes #838
2010-06-21 21:17:37 -04:00
Juan Basso
26d20b6d62
Fixing wrap for html mode in e-mails. Fixes #663
2010-06-21 00:37:25 -03:00
Juan Basso
2a4489cdf2
Naming conventions to datasources with plugins. Fixes #819
2010-06-20 23:53:54 -03:00
mark_story
2db510d1c1
Modifying Controller::validateErrors so it can accept and validate arbitrary model objects, not just those attached to the controller. Test cases updated, fixes #832
2010-06-20 21:47:34 -04:00
mark_story
50144d6b5b
Making FormHelper clear fields on create() as well as end() this ensures that GET forms don't leak fields. Fixes #571
2010-06-12 22:50:09 -04:00
mark_story
f0d755bd8e
Adding additional tests for Helper::_parseAttributes() and fixing issue where '1' would not be interpreted as a truthy value for compact attributes. Fixes #806
2010-06-10 19:11:26 -04:00
mark_story
9ee4a12a9d
Adding additional tests for FormHelper::input() and checkbox generation and checked attribute being set for truthy values. Close #806
2010-06-10 12:48:55 -04:00
mark_story
ad8b70cec2
Removing continue statement that did nothing.
...
Adding a rollback for when validation fails and atomic has been set.
Tests added. Fixes #797
2010-06-09 13:48:54 -04:00
mark_story
bca3c4ab38
Moving init() tests into separate test methods.
...
Adding tests for table prefixes on models being used as imports.
Fixing issue where tablePrefix was not accurately used when importing model information. Fixes #765
2010-06-08 23:30:57 -04:00
mark_story
2f527cc5af
Adding a few tests for DboSource::fullTableName();
2010-06-08 23:29:40 -04:00
mark_story
a88b8dd5b9
Making requestAction() calls that requesthandler creates not remove autoLayout. This fixes issues where ajax layout files would not be rendered.
...
Tests added. Fixes #722
2010-06-07 23:43:35 -04:00
Kyle Robinson Young
a9fa7ac240
Fix for auth component userModel with plugins. Fixes #799
2010-06-07 23:19:13 -04:00
mark_story
ccd036eed0
Adding additional test cases for nld, dut, and nl. Closes #795
2010-06-07 23:10:53 -04:00
predominant
26d526f624
Fix AuthComponent tests for windows newlines.
2010-06-07 01:22:08 +10:00
mark_story
e41e89cd2a
Making magic select not override magic hidden. Tests added.
...
Fixes #782
2010-06-04 00:20:14 -04:00
mark_story
bd6e16be26
Fixing issue where join tables would be filed under 'missing' and found. Test added. Fixes #789
2010-06-03 23:20:37 -04:00
Juan Basso
3c27c4c41e
Ajusting smtpOption in EmailComponent. Fixes #779
2010-06-03 14:46:20 -03:00
mark_story
7682c5896e
Changing how merged rules are cleared so it doesn't generated notice errors in PHP4. Test added. Fixes #762
2010-06-01 23:41:51 -04:00
mark_story
7ed67e5959
Fixing virtualFields used in order clauses where virtualField was supplied with model alias. Tests added. Refs #768
2010-05-30 20:30:58 -04:00
mark_story
c98a82c61c
Fixing whitespace.
2010-05-30 20:28:00 -04:00
mark_story
66a8890f4f
Fixing code formatting in test cases.
2010-05-30 12:51:48 -04:00
mark_story
07948a733d
Reverting change made in [ 7cde309
]. Readding trim() to fix issues on windows. Updating tests so they continue to pass on macos. Fixes #769
2010-05-30 11:16:40 -04:00
mark_story
25a6a3cac8
Correcting spacing in file test.
...
Correctly constructing a File object, so testRead does not rely on the previous test to leave the object in the correct state.
2010-05-29 12:47:31 -04:00
renan.saddam
c96d074722
Merge branch '1.3' of github.com:cakephp/cakephp into 1.3
2010-05-29 12:23:04 -03:00
renan.saddam
8f5112b8d7
Changing break; to continue; so it will process the next tables on the array, tests added.
2010-05-29 12:22:16 -03:00
predominant
8decc683ac
Numerous 'shoer description' documentation entries updated to contain useful comments.
2010-05-30 01:20:28 +10:00
mark_story
8b6c974cd0
Making FileEngine not greedily clear files in a directory that may belong to another cache configuration. Tests added. Fixes #754
2010-05-27 00:01:17 -04:00
mark_story
cd255d5031
Merge branch '1.3' of github.com:cakephp/cakephp into 1.3
2010-05-25 23:08:06 -04:00
Martin Radosta
64adfacd3e
Making DboSource::order() accept an expression object. Fixes issues with
...
sql parsing over quoting special SQL syntax. Tests added. Fixes #747
Signed-off-by: mark_story <mark@mark-story.com>
2010-05-25 23:07:29 -04:00
Juan Basso
bc3e745673
Support to EHLO in SMTP server for EmailComponent. Fixes #54 , #712 , #737
2010-05-24 22:24:58 -03:00
ADmad
7d51952801
Removing protected var CakeSession::_started and instead session_id() is now used to check if session is started in CakeSession::started(). This fixes issue where CakeSession::started() returned incorrect value when used across multiple objects. Closes #731
2010-05-23 02:14:07 +05:30
mark_story
29f2223c6d
Removing hardcoded '__' for virtualField separators. Making it an instance property instead. This allows the customization of the separator if needed. Tests added for DboMysql. Refs #655 , #730
2010-05-22 00:58:54 -04:00
mark_story
23d4bafd39
Fixing inflection of words ending in causes. Fixes #736
2010-05-21 23:49:49 -04:00
Juan Basso
a94b9ee95b
Update various links. Closes #392
2010-05-18 22:15:13 -03:00
mark_story
3a60aa07de
Fixing issues where setting jQueryObject did not affect request() and its connected methods.
...
Tests added.
Fixes #728
2010-05-17 18:25:50 -04:00
mark_story
4915645fb1
Applying patch from 'Daren Thomas' fixes issues where sorting on virtualFields did not work properly when using aliased sort link keys. Tests added. Fixes #680
2010-05-16 23:42:14 -04:00
Mark Story
a29866b7fb
Updating test for 1.3
2010-05-13 23:09:23 -04:00
Mark Story
3d98cc6f53
Adding tests for welsh added in previous commit.
2010-05-13 23:08:32 -04:00
Mark Story
79839c07d2
Fixing issues where ModelBehavior::detach() would not detach behaviors when a plugin.name was provided. This change makes detach() work like attach(). Tests added. Fixes #711
2010-05-11 23:08:14 -04:00
Mark Story
0648c6604b
Adding some additional tests for possible php4 compatibility issues.
2010-05-11 23:01:40 -04:00
Mark Story
6add43a4bc
Fixing issue where id = null could cause SQL errors when saving more than one record with a null id. Fixes #675
2010-05-11 22:40:56 -04:00
ADmad
3539660cd0
Space is now properly added inbetween when 'asc'/'desc' class is appended to user defined css class in PaginatorHelper::sort. Fixes #710
2010-05-12 00:42:02 +05:30
Richard Sbresny
05beaab272
Removed unnecessary unset
...
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:14:38 -04:00
Richard Sbresny
b04a3f8514
Switched over to using the previously unused Security::inactiveMins() method for getting timeout modifiers
...
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:14:20 -04:00
Richard Sbresny
a4950f6940
Updated session timeout calculations to use the security level from core.php as the multiplier.
...
Signed-off-by: Mark Story <mark@mark-story.com>
2010-05-11 00:11:20 -04:00
predominant
1ec220dac2
Removing closing PHP tags.
2010-05-11 08:07:49 +10:00
Mark Story
1a7dce3af6
Updating DboMysql to fix an issue where virtualFields that were simple
...
aliases to fields on other tables would end up in the wrong place.
Tests added. Fixes #655
2010-05-07 23:26:13 -04:00
Mark Story
745afe888b
Adding more tests for saving records with nulls. Closes #675
2010-05-07 22:23:18 -04:00
Mark Story
f152181c03
Adding tests for saving models with id == null. Closes #675
2010-05-06 22:24:11 -04:00
Mark Story
ce10c85367
Making Sanitize::stripScripts() to remove multi-line script and style blocks. Fixes #657
2010-05-03 22:33:20 -04:00
Mark Story
95dbae8acf
Making RequestHandler component carry along a passed status code. This fixes issues where RequestHandler hijacks an redirect(). Fixes #658
2010-05-03 22:07:13 -04:00
Mark Story
c48f6d6536
Fixing safe parameter from leaking into request() calls in JsHelper::submit() and JsHelper::link(). Fixes #656
2010-05-02 21:17:10 -04:00
ADmad
f386dca6d8
Controller::loadModel() now returns true when model is succesfully instantiated as stated in docblock. Added test case.
2010-05-02 05:34:38 +05:30
José Lorenzo Rodríguez
ad51115e12
Fixing bug where required class would be added to form fields when using single rule syntax in $validate even if allowEmpty is set to true
...
Closes #654
2010-04-30 16:42:59 -04:30
José Lorenzo Rodríguez
9b040a5ed3
Fixing code formating
2010-04-30 16:07:59 -04:30
ADmad
0471ea046f
Adding test case for 'required' class adding to wrapping div based on model validations. Refs #654
2010-05-01 01:19:52 +05:30