Commit graph

4343 commits

Author SHA1 Message Date
DarkAngelBGE
4ce3f21608 adding missing options array in Model::beforeValidate(0 and Model::beforeSave() as they are called with them out of the model and it is good practice, although they are meant to be overriden; closes #5470
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7650 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-23 18:50:27 +00:00
DarkAngelBGE
e245d18ed8 fixes #5469
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7648 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-23 12:04:02 +00:00
DarkAngelBGE
c8ab1ec092 small readability refactorings for Set::filter() and Set::matches()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7647 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-23 11:33:36 +00:00
mark_story
676459224c Adding patches from andy__ to dbo_odbc
Schema related functions will not work due to the way odbc works.
Closes #5398

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7646 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-23 02:59:05 +00:00
DarkAngelBGE
caa4e321f2 Fixing unneeded conditions in child queries when conditions are present in the model declaration; fixes #5323
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7645 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-22 20:08:31 +00:00
nate
24b444ca55 Fixing behavior initialization in model construction, adding Set::flatten() utility method for future refactoring, updating Set test
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7644 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-22 16:32:41 +00:00
gwoo
ea7981023b updating doc block for Cache::set() refs #5460
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7643 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-22 13:06:26 +00:00
phpnut
8b45eeed8b Fixing MediaView so it will stop reading file when connection is aborted.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7642 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-22 05:35:36 +00:00
mark_story
fafb01b09d Fixing modelClass when using plugin models.
Added TestPluginPost to test_app/test_plugin
Test case added.
Closes #5459

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7641 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-22 04:10:49 +00:00
nate
d9b357d05c Making Model::$_findMethods protected, and fixing fatal error when table calls are attempted on a model with a missing table
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7640 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-21 04:09:16 +00:00
nate
80c1950530 Refactoring FormHelper security token generation, fixing code formatting
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7639 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-21 04:06:37 +00:00
nate
42911f5bc3 Adding example Ajax layout for Auth test
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7638 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-20 21:48:43 +00:00
nate
fc5b128d68 Refactoring Auth test, adding coverage, and enabling custom Ajax layouts (as specified by RequestHandler), fixes #5446
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7637 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-20 20:18:16 +00:00
mark_story
9482105abe Applying patch from renan_saddam. Fixes session checkAgent logic. Closes #5450
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7636 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-20 13:51:49 +00:00
nate
f695170365 Fixing console routing commands and implementing route loading so commands work with lazy route compiling
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7635 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-19 21:33:59 +00:00
nate
91838d6d5d Fixing bug in RequestHandler::prefers() not respecting accept order for single items, test case updated
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7634 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-19 19:48:22 +00:00
the_undefined
740bd4e769 Partial fix for #5225
Corrected expected behavior for 2nd issue

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7633 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-19 18:08:27 +00:00
gwoo
931d996d90 fixes #5438, multiple binding with alias
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7632 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-19 15:27:43 +00:00
renan.saddam
4f5a51d79d Proving bad condition structure when Session.checkAgent equal to false. Refs #5450
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7631 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-19 02:57:58 +00:00
renan.saddam
5cedddb9d2 Fixing since tag from file added on last commit
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7630 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-19 02:40:07 +00:00
renan.saddam
597f7642fa Added tests to disprove strange App::import behavior. Closes #5395
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7629 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-19 02:37:20 +00:00
renan.saddam
f080163e8a Added test to disprove multiple calls to session start. Closes #5328
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7628 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-19 00:55:42 +00:00
mark_story
768e25c4fd Updating Controller::paginate(). Custom paginate() and paginateCount() methods now receive $extra params similar to find('all') and find('count') do. Allows the use of things like 'contain' with custom paginate() methods.
Test case added. Closes #5433 refs #5123.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7627 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-19 00:46:20 +00:00
renan.saddam
8fadcbafea Added test to show parent transversal bug. Merged patch from 'sneeka2'. Refs #5225
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7626 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-19 00:01:48 +00:00
phpnut
953db61447 Adding ability to cache content rendered with MediaView.
Fixed header()

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7625 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-18 06:37:35 +00:00
mark_story
0f9a4e0470 Optimizing in_array() checks to isset().
No more in_array($a, array_keys($b)) patterns exist.
Closes #5161

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7624 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-18 03:40:28 +00:00
phpnut
8ae5866a1c Additional optimization refactoring
Removed ability to use deprecated / with plugin, helper, etc combinations. The dot notation is only allowed from this point forward.
Corrected tests for the above changes.
Corrected formating in basics.php

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7623 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-18 03:09:19 +00:00
nate
e3788dd6fa Updating XmlHelper test case for consistency with recent quoting fix
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7622 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-18 02:33:33 +00:00
renan.saddam
3e8261b465 Proving error when try to overwrite association name with bindModel. Refs #5438
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7621 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-18 01:54:31 +00:00
nate
66240f0c5d Refactoring DboPostgres and adding '.' to sequence name detection, fixes #5424, fixing code formatting
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7620 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-18 00:23:17 +00:00
gwoo
fd73cf738a adding umask back to Folder class, see #27 for some amusement
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7619 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-17 21:54:36 +00:00
mark_story
f65de0b28d Adding test to dispatcher.test.php showing paths with named params. Tested on windows XP with apache 2.x and php 5.x Disproves #5445.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7618 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-17 21:08:50 +00:00
nate
e3d7aee9da Adding option to disable POST data validation in Security component, fixes #5412
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7617 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-17 15:27:41 +00:00
nate
85646b1908 Small refactor of Router
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7616 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-17 15:26:31 +00:00
nate
906dbcccbf Ensuring Dispatcher does not return an empty action, fixes #5434
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7615 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-17 15:17:23 +00:00
mark_story
05a5eda3d1 Adding CSS for skipped test icon to test suite.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7614 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-17 12:35:39 +00:00
mark_story
26a6a0e36f CakeSchema no longer takes tables that are not properly prefixed. Tests added to show prefixed db config and schema read. Closes #5413
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7613 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-17 01:47:19 +00:00
mark_story
616fac0f99 Applied patch from 'grigri' updating Model test to clear possible mis-interpretation of test cases. Closes #5439
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7612 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-16 17:17:24 +00:00
nate
14b17fed39 Changing private methods in Security component to protected
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7611 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-16 01:39:20 +00:00
mark_story
65cbbcf019 Changing '.id' to primaryKey reference. Closes #5437
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7610 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-16 00:42:01 +00:00
the_undefined
3ff9c49f82 Performance improvements by removing array_merge
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7609 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-15 18:05:31 +00:00
the_undefined
0e621885ab Fixed docblock error
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7608 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-15 18:05:26 +00:00
gwoo
06ee84a128 fixes #5429, Xml::toString() quotes
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7607 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-15 11:50:51 +00:00
mark_story
44cf61b240 Updating doc blocks for ajax helper. Closes #5426
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7606 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-15 04:03:15 +00:00
mark_story
593871d58f Removing redundant html escaping from ErrorHandler
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7605 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-14 23:24:01 +00:00
phpnut
5658e26e07 Changing comparison operators to === (identical) which is faster than == (equal)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7604 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-14 17:17:49 +00:00
DarkAngelBGE
35a2b466de performance improvements for code coverage analysis
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7603 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-14 12:14:39 +00:00
AD7six
93c5b68a93 fixes #5427 missing brackets for connection_aborted call
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7602 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-14 09:14:59 +00:00
mark_story
2b984bed94 changing array_key_exists to isset. Refs #5161
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7601 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-14 05:00:05 +00:00
phpnut
869cd1fe36 Small fix for MediaView randomly outputting 1 and corrupting output.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7600 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-14 03:02:57 +00:00