Commit graph

3755 commits

Author SHA1 Message Date
mark_story
2fe60142f5 Fixing more strict warnings. 2010-12-12 21:09:56 -05:00
mark_story
0ac8d04241 Fixing more strict warnings. 2010-12-12 21:02:42 -05:00
Juan Basso
c20b5d7053 Renamed setAuthConfig to configAuth, and setProxyConfig to configProxy. 2010-12-12 23:48:04 -02:00
mark_story
017385d61c Fixing most of the strict errors in the helper test suite. 2010-12-12 20:21:14 -05:00
mark_story
dc7ff8911d Fixing tests in ComponentCollection and HelperCollection as return of trigger now depends on the triggered objects.
Removing annoying test that broke anytime something changed in Model.
2010-12-12 18:02:45 -05:00
mark_story
bf22af6b7f Fixing more strict errors and usage errors in BehaviorCollection test.
Making modParams only work if the result is an array.  This is for compatibility with previous behaviour.
2010-12-12 17:42:40 -05:00
mark_story
ce2e6053e4 Adding containable to the AllBehaviors test as it now runs. 2010-12-12 17:40:41 -05:00
mark_story
48879f8264 Fixing strict errors in translate and acl behaviors.
Removing conditional definition of I18nModel.  There is no reason for it to exist anymore.
Removing duplicate class definition.
2010-12-12 17:38:49 -05:00
mark_story
df21d19c4c Making a bunch of properties public so containable can hack around. Need to refactor and fix visibility issues.
Fixing failing tests in containable.
2010-12-12 15:48:36 -05:00
mark_story
10c358742b Making modParams ignore null results.
Test added.
2010-12-12 15:33:24 -05:00
mark_story
81e009b816 Fixing additional strict warnings. 2010-12-12 15:02:38 -05:00
mark_story
33b8a35b75 Fixing strict warnings in TreeBehavior and a few other classes. 2010-12-12 14:56:48 -05:00
mark_story
96968f7194 Moving the modParams option into ObjectCollection, so it can replace the specific trigger method in BehaviorCollection.
Changed how break behaves, so it is works better with modParams and collectReturn options.
Tests updated and expanded.
2010-12-12 14:10:22 -05:00
mark_story
d14d148948 Making scaffold form view names consistent with those used in bake.
Renaming test_app files.
Fixes #501
2010-12-12 13:18:28 -05:00
mark_story
11df32148f Updating scaffold templates to use post forms for delete buttons. Updating test case. 2010-12-12 13:13:00 -05:00
mark_story
44c080d5ad Making all core classes throw CakeException subclasses, this allows developers to catch framework exceptions with one catch.
Adding package specific exceptions.
Replacing generic exceptions in the codebase with CakeException + package exceptions.
2010-12-11 19:26:10 -05:00
Jeremy Harris
b3f55bfd29 Added shorter timeout to fsockopen checks 2010-12-11 13:23:23 -08:00
Juan Basso
d332f0624f Making the cookies independent for each host. 2010-12-11 16:49:19 -02:00
mark_story
60ada4432a Making unknown errors with codes higher than 500 render as error500.
Test added.
2010-12-11 13:30:29 -05:00
mark_story
504b4d495f Adding stack traces to logged exceptions, as I forgot them last time around. 2010-12-11 12:47:16 -05:00
Juan Basso
eeafb55d31 Support to download requests. 2010-12-11 14:44:45 -02:00
mark_story
ceca179184 Fixing more tests that were failing post merge. 2010-12-10 23:17:42 -05:00
mark_story
1e108748e9 Fixing validation methods + features lost in [f51ce734] due to a bad
merge.
Fixing additional tests to reflect changes in 2.0
2010-12-10 22:52:22 -05:00
mark_story
b9f0fc0724 Merge branch '1.3' into merger
Conflicts:
	cake/dispatcher.php
	cake/libs/cake_session.php
	cake/libs/controller/components/cookie.php
	cake/libs/controller/components/email.php
	cake/libs/controller/controller.php
	cake/libs/controller/scaffold.php
	cake/libs/set.php
	cake/libs/validation.php
	cake/libs/view/view.php
	cake/tests/cases/dispatcher.test.php
	cake/tests/cases/libs/controller/components/security.test.php
	cake/tests/cases/libs/controller/controller.test.php
	cake/tests/cases/libs/validation.test.php
	cake/tests/cases/libs/view/view.test.php
2010-12-10 22:24:31 -05:00
Juan Basso
453c5364c2 Putting the auth and proxy data in request attribute after request. 2010-12-10 10:44:28 -02:00
Juan Basso
d97103d739 Making the format attribute customizable in helpers. 2010-12-10 02:42:38 -02:00
mark_story
d7e62b88bc Adding test cases for using helpers in nested elements from email
templates.  Closes #1355
2010-12-09 22:34:20 -05:00
mark_story
a830632071 Changing View::element() to not overwrite viewVars with helpers that
have the same name.
Test added.
Fixes #1354
2010-12-09 22:06:23 -05:00
Graham Weldon
33d2f9a6ed Refs #621. Provides default maxLimit for pagination to prevent url manipulation causing long queries. 2010-12-10 12:22:12 +11:00
Juan Basso
7c23d289e0 Minor optimizations. 2010-12-06 12:03:22 -02:00
Juan Basso
d656bdae3b Renamed proxy method and calling togheter from host config. 2010-12-06 11:28:40 -02:00
Juan Basso
30a70b700b HttpSocket::_configUri() always change config attribute and it is public. This function dont need return it. 2010-12-06 04:04:37 -02:00
mark_story
c096eea664 Fixing failing tests caused by constants changing. 2010-12-05 23:32:34 -05:00
mark_story
55e06ec244 Merge branch '2.0-config' into 2.0
Conflicts:
	cake/libs/configure.php
2010-12-05 23:00:05 -05:00
Jeremy Harris
8a7e2609cd Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2010-12-05 17:57:44 -08:00
Juan Basso
97fe32f87c Request return a pointer to body. It will reduce the memory usage in big responses. 2010-12-05 23:36:28 -02:00
Jeremy Harris
5eab027b84 Removed unnecessary pass by references 2010-12-05 17:28:15 -08:00
José Lorenzo Rodríguez
c559b9c22d Merge remote branch 'origin/2.0' into 2.0
Conflicts:
	cake/console/templates/skel/config/database.php.default
	cake/libs/model/datasources/dbo/dbo_sqlite.php
2010-12-05 20:51:37 -04:30
mark_story
5ad8d8af41 Adding a parameter to configured() to allow you to check if a particular config has been configured. 2010-12-04 22:57:33 -05:00
Juan Basso
c52d5320c8 Replaced the *printf with i18n aliases by i18n aliases with params. 2010-12-04 23:37:13 -02:00
mark_story
0b18fc25a6 Changing some requires so things run smoother. 2010-12-04 17:53:57 -05:00
mark_story
b49c4402e5 Implementing store and restore for Configure.
Test cases added.
2010-12-04 17:26:59 -05:00
mark_story
0cf02ec2f9 Fixing issues caused by CORE_PATH not being reliable. 2010-12-04 15:00:48 -05:00
mark_story
8031d33d33 Fixing more E_STRICT notices and adding a type check to DboSource::dropSchema(). 2010-12-04 14:37:02 -05:00
mark_story
a6c5065e9c Fixing a few more E_STRICT errors in postgres test/class. 2010-12-04 14:31:11 -05:00
mark_story
7e29859676 Fixing E_STRICT errors in test models. 2010-12-04 14:19:53 -05:00
mark_story
18fb12c95c Removing & pass by ref operators as they aren't needed any more.
Fixing a bunch of E_STRICT errors.
2010-12-04 14:15:32 -05:00
mark_story
64d1f799f8 Adding fixtures that fixed MissingTableExceptions I was getting. 2010-12-04 13:52:38 -05:00
mark_story
159f25ff0f Adding ini file and more tests for types. 2010-12-04 12:58:02 -05:00
mark_story
98704d3ecd Adding nested value support to IniReader.
Adding boolean conversions.
Adding test cases.
2010-12-04 12:56:37 -05:00
mark_story
1e569f509a Changing IniFile to be a ConfigReader for use with Configure. Test case updated. 2010-12-04 12:15:47 -05:00
mark_story
7eab3b2850 Moving load() logic out of Configure, and putting it into PhpReader.
Updating test cases.  store() still needs to be properly implemented.
2010-12-04 01:05:12 -05:00
mark_story
6618178e1b Adding more checks into PhpReader that currently exist in Configure. 2010-12-04 00:58:02 -05:00
mark_story
aef53cd23a Adding some more basic methods. 2010-12-04 00:14:55 -05:00
mark_story
da632fe191 Renaming method to match other core classes with similar features. 2010-12-04 00:10:42 -05:00
mark_story
9b8456ce6f Adding an interface to define the necessary public methods.
Adding insertion of configure readers.
Adding tests.
2010-12-04 00:09:11 -05:00
Juan Basso
c4743a2438 Changing the test with get to use version instead auth. 2010-12-04 01:41:45 -02:00
Juan Basso
123b2256c5 Formatting 2010-12-04 01:31:28 -02:00
Juan Basso
075bdebebe Moved the proxy configuration from request to class attribute. 2010-12-03 23:10:07 -02:00
Juan Basso
f004bef74f DigestAuthentication adapted to new auth in HttpSocket. 2010-12-03 21:57:15 -02:00
José Lorenzo Rodríguez
66d0986cd4 Pepending table name to index generation to avoid name clashes
Finally, all tests using a Sqlite database pass
2010-12-03 15:25:26 -04:30
José Lorenzo Rodríguez
e167271568 Making more DboSlite tests pass 2010-12-03 14:41:39 -04:30
José Lorenzo Rodríguez
7c4ab886e6 Merge remote branch 'origin/2.0' into feature/2.0/pdo 2010-12-03 14:08:03 -04:30
mark_story
7863f14d79 Adding new test cases into configure suite. 2010-12-02 23:34:13 -05:00
mark_story
bbb15c24a1 Adding more tests and better errors for PhpReader. 2010-12-02 23:30:28 -05:00
mark_story
ae328ffb3a Adding plugin support for PhpReader.
Tests added.
2010-12-02 23:14:26 -05:00
mark_story
fdb5955d6c Adding PhpReader to implement php file reading as per #1334 2010-12-02 23:06:08 -05:00
Juan Basso
4325e67163 Fixing setAuthConfig to accept false as param to remove auth config. Tests added. 2010-12-03 01:30:03 -02:00
Juan Basso
cd24aca39d Removing auth key from request and putting this as attribute. 2010-12-03 00:46:11 -02:00
José Lorenzo Rodríguez
2e04c5260e Fixing some tests to make them run on sqlite 2010-12-02 00:19:43 -04:30
mark_story
44b09171ef Adding unicode letters and numbers to url path segment regex.
Test case added.
Fixes #1284
2010-12-01 23:47:30 -05:00
Juan Basso
aa0bad9247 Ignore errorHandler if warning suppressor (@command()) is used. 2010-12-02 01:44:31 -02:00
dogmatic69
96b30f0547 adding tests for places that will leave a trailing 0 because of the way phps number_format() method works
Signed-off-by: mark_story <mark@mark-story.com>
2010-12-01 22:08:26 -05:00
Juan Basso
e1e8026392 Support to proxy authentication in basic authentication. 2010-12-01 14:00:10 -02:00
Juan Basso
b9010b05f2 Support to proxy in HttpSocket. 2010-12-01 13:46:13 -02:00
Juan Basso
634d686288 Merge branch '2.0' into 2.0-http 2010-12-01 11:49:26 -02:00
José Lorenzo Rodríguez
0d93520e0a Fixing test case for sqlite 2010-11-29 20:52:32 -04:30
Juan Basso
ffaec10a7c Fixing the result of App::import() when name of class have slash. 2010-11-29 22:37:08 -02:00
José Lorenzo Rodríguez
130fe603a7 Skipping test incompatiblw with mysql 2010-11-28 23:34:20 -04:30
José Lorenzo Rodríguez
592dda92de Fixing test to make it pass using DboSqlite 2010-11-28 22:48:34 -04:30
Mark Story
40585a34e8 Adding support for userPath in IniAcl.
Test case added.
Fixes #1291
2010-11-28 21:22:10 -05:00
Mark Story
2495b3cd4c Trimming whitespace and adding a file header. 2010-11-28 21:11:18 -05:00
Mark Story
3ddff879b1 Converting IniAcl to use IniFile, this removes one of the classes responsibilities. 2010-11-28 21:06:22 -05:00
Mark Story
35611d50c3 Fleshing out IniFile a bit more. 2010-11-28 21:05:32 -05:00
Mark Story
071cd9b477 Adding very naive implementation of an ini file parser. 2010-11-28 21:05:32 -05:00
mark_story
9d3b3a72ce Starting to extract Ini file parsing out of IniAcl as it breaks single responsibility, and ini file parsing should be generic enough to be reused.
Adding a test case.
2010-11-28 21:05:32 -05:00
Mark Story
1f72e504d5 Fixing incorrect imports that caused test case to fail in CLI when run by itself. 2010-11-28 20:49:42 -05:00
mark_story
284a8db3f4 Moving error handling classes into a separate directory.
Moving error handling test cases into a directory that matches the one in libs.
Updating imports.
2010-11-28 12:27:51 -05:00
Jeremy Harris
1411e9495e Fixed failing test due to missing CakeRequest class 2010-11-27 12:47:19 -08:00
Jeremy Harris
8492f2055b Added tests for object collection 2010-11-27 12:09:43 -08:00
José Lorenzo Rodríguez
0ff01330c4 Making dates deconstruction in model more consistent for different datasources 2010-11-27 00:13:04 -04:30
José Lorenzo Rodríguez
41ee035d28 Starting to bring sqlite dbo up to date 2010-11-26 23:46:34 -04:30
José Lorenzo Rodríguez
b6731dd9ad Merge remote branch 'origin/2.0' into feature/2.0/pdo
Conflicts:
	cake/tests/cases/libs/model/datasources/dbo/dbo_mysql.test.php
	cake/tests/cases/libs/model/datasources/dbo/dbo_mysqli.test.php
2010-11-26 20:26:41 -04:30
ADmad
70ae66edf7 Fixing test cases for EmailComponent 2010-11-27 01:21:19 +05:30
mark_story
04d3feb6c0 Unknown errors cannot be mapped as they generate another error. Having a default case doesn't make much sense here.
Adding additional coverage to ErrorHandler.
2010-11-25 22:51:30 -05:00
mark_story
f2f3f13c75 Adding exception logging configuration setting. Allows uncaught exceptions to be logged.
Implementing logging, and adding a test case.
2010-11-25 22:51:30 -05:00
mark_story
3bc708ba19 Adding the new group to AllTests.
Removing ErrorHandler test from AllLibs.
2010-11-25 22:51:30 -05:00
mark_story
fac222e2cd Removing classes that were not used in the ErrorHandler test case. Adding a new test suite for error classes. 2010-11-25 22:51:29 -05:00
mark_story
e2c8e20afa Pulling exception page rendering out into a separate class, ErrorHandler felt very large and confusing, as it had a few too many jobs. 2010-11-25 22:51:29 -05:00
mark_story
722b1a02ba Adding Debugger output to ErrorHandler::handleError, and adding tracing for log writes.
Renaming Debugger::_output() -> Debugger::outputError() and making it public instead of protected.
2010-11-25 22:51:29 -05:00
mark_story
f373fc19d1 Removing logError from CakeLog, it will be moved into ErrorHandler::handleError() 2010-11-25 22:51:29 -05:00
mark_story
6c2c4f91df Removing dead tests and updating ones to reflect changes in how Configure works. 2010-11-25 22:51:29 -05:00
mark_story
4960b6e7bf Changing method names on CakeLog and Debugger to better reflect what they do. Updating test cases. 2010-11-25 22:51:28 -05:00
mark_story
da3bf1c747 Adding ErrorHandler::handleError for consolidating core error handling out of CakeLog and Debugger. 2010-11-25 22:51:28 -05:00
mark_story
15ca2400bc Fixing issue in DboSource::name() where special characters in column names would not be correctly quoted.
Tests added.
Fixes #1264
2010-11-25 06:52:23 -05:00
mark_story
7d158e8d1f Fixing Set::sort() for arrays with out of sequence, or missing keys.
Tests added.
Fixes #1312
2010-11-25 06:39:08 -05:00
mark_story
4214242efd Adding test for correct merge order for $uses.
Fixing incorrect merge ordering for $uses, so it matches historical behaviour.
Fixes #1309
2010-11-24 22:44:12 -05:00
mark_story
0e29567f8d Adding an array cast to fix issues where users could modify cookie
values causing iteration errors.  Fixes #1309
2010-11-24 22:09:08 -05:00
Juan Basso
af06b8f179 Added test to a request that server dont response WWW-Authenticate. 2010-11-24 21:14:52 -02:00
mark_story
d5fb0b25cb Fixing issue where Date header would be missing from Emails sent by
EmailComponent.
Adding user configurable field for date.
Test cases added.  Fixes #1304
2010-11-22 22:08:46 -05:00
mark_story
4c0e69b8fc Removing constant checks, they aren't used anymore. 2010-11-21 15:13:33 -05:00
mark_story
8aabf3689e Making BehaviorCollection more consistent with other object collections.
Fixing failing tests caused by not being updated when behavior changed.
2010-11-21 14:42:13 -05:00
mark_story
cb657b158b Fixing failing test and adding skip for test that will fail in a non-isolated case. 2010-11-21 14:39:07 -05:00
mark_story
8a129ec3a0 Adding a normalize parameter to Object::_mergeVars(). This allows existing behavior to be maintained.
Updating Controller and Shell usage to match new parameters.
2010-11-21 00:47:42 -05:00
mark_story
8f82156a51 Adding _mergeVars to Controller (this duplicated method will be re-factored away).
Updating tests in ControllerMergeVarsTest to use PHPUnit assertions.
2010-11-21 00:14:29 -05:00
mark_story
79aafda698 Removing use of serialize() for locked fields. This removes any
possible exploit related to serialize()/unserialize().  Instead values
are passed as | delimited.
2010-11-21 00:09:45 -05:00
mark_story
ae7855692d Removing unserialize() as its dangerous. Instead using | delimited fields for locked fields. This totally avoids issues with serialize(). Removing str_rot13, as its only child proof.
Tests updated.
2010-11-20 23:42:54 -05:00
mark_story
3237402fb8 Merge branch '1.3' into merger
Conflicts:
	cake/libs/configure.php
2010-11-20 23:14:33 -05:00
mark_story
ef3cb0e50c Adding tests for Set::normalize() 2010-11-20 22:46:55 -05:00
mark_story
6d9b000aee Changing how mergeVars are handled, so the difference of app/current is used as a base.
Also fixing issues where passing settings to helpers in AppController could result in them not being correctly merged.
Thanks to hashmich for the partial patch.
Fixes #1183
2010-11-20 22:34:24 -05:00
Juan Basso
3056fbf680 Changing authentication classes to use suffix Authentication instead of Method. 2010-11-20 17:47:35 -02:00
mark_story
e0a8ffe8a3 Applying patch from 'jmccaffrey' to fix issues on windows where virtual
machine paths would not be correctly handled.  Fixes #1254
2010-11-20 13:26:30 -05:00
José Lorenzo Rodríguez
40418de218 Freeing up some memory in dbos after the result set has been completly fetched.
Adding dbo_mysql and dbo_postgres to the AllDAtabase testsuite
2010-11-16 23:59:24 -04:30
mark_story
ba10003ef2 Fixing failing tests when HtmlHelper test was run by itself. 2010-11-16 22:52:49 -05:00
mark_story
d12c232d8a Merge branch '1.3' into merger
Conflicts:
	app/config/core.php
	cake/console/templates/skel/config/core.php
	cake/dispatcher.php
	cake/libs/controller/components/auth.php
	cake/libs/view/helpers/form.php
	cake/tests/cases/libs/cake_test_case.test.php
	cake/tests/cases/libs/controller/components/security.test.php
	cake/tests/cases/libs/model/models.php
	cake/tests/cases/libs/router.test.php
	cake/tests/cases/libs/view/helpers/paginator.test.php
	cake/tests/lib/cake_test_case.php
2010-11-16 21:48:13 -05:00
José Lorenzo Rodríguez
f2b707ac0b Merge remote branch 'origin/2.0' into feature/2.0/pdo
Conflicts:
	cake/tests/cases/libs/model/datasources/dbo/dbo_mysql.test.php
	cake/tests/cases/libs/model/datasources/dbo/dbo_mysqli.test.php
	cake/tests/cases/libs/model/datasources/dbo_source.test.php
2010-11-16 21:54:42 -04:30
mark_story
f0ac462775 Updating test cases with failing tests. 2010-11-15 22:53:49 -05:00
mark_story
66e6ec763e Merge branch 'dispatcher-request' into 2.0
Conflicts:
	cake/libs/configure.php
	cake/tests/cases/libs/all_routing.test.php
	cake/tests/cases/libs/controller/controller.test.php
2010-11-15 22:42:54 -05:00
Juan Basso
7bea5d9410 Added the http directory to AllSocket tests. 2010-11-14 23:56:12 -02:00
mark_story
27287e4b9f Moving AppTest into a separate file.
Updating test suite.
2010-11-14 13:06:25 -05:00
mark_story
f02e0483ee Reworking parameter munging specific to requestAction into requestAction. Updating tests cases for Object. As request->data is an array() not null. And leading / is trimmed off of [url][url]. 2010-11-14 01:01:11 -05:00
mark_story
55cc3296ab Making the Debugger tests pass when you have debug = 0 in your config file. Tests are runnable while debug = 0 from CLI. 2010-11-14 00:59:45 -05:00
mark_story
557d797297 Making Dispatcher test cases pass when Dispatcher expects a CakeRequest instead of a string. 2010-11-14 00:29:56 -05:00
mark_story
dad7963ea4 Moving Dispatcher inside libs directory, as it is part of CakePHP's libs. 2010-11-14 00:00:23 -05:00
mark_story
6073ac5dfa Fixing errors caused by accessing things that don't exist. 2010-11-13 23:57:01 -05:00
mark_story
9b08b725fe Merge branch '2.0' into 2.0-view
Conflicts:
	cake/libs/controller/controller.php
	cake/libs/view/helpers/cache.php
2010-11-13 21:03:54 -05:00
Juan Basso
974161cf3a Changed the name of header to use in Digest method. 2010-11-13 21:47:25 -02:00
Juan Basso
85607a9963 Removed interference in the name of the headers. 2010-11-13 21:44:11 -02:00
Juan Basso
44629bd673 Support to digest method in HttpSocket. Thanks to jmcneese and Adrien Gibrat. 2010-11-13 20:51:09 -02:00
mark_story
76a80c262e Fixing failing test caused by name() being able to quote things better now. 2010-11-13 12:04:22 -05:00
mark_story
e63f81c12a Fixing test case that was missing request access. 2010-11-12 23:23:08 -05:00
mark_story
01894b315f Fixing issues caused by not accessing the request object correctly. 2010-11-12 23:14:34 -05:00
mark_story
18bb5f6b8b Removing =& operators for construction of objects. 2010-11-12 23:05:44 -05:00
mark_story
d044cdd02f Fixing test case that was missing request access. 2010-11-12 22:50:15 -05:00
José Lorenzo Rodríguez
91e2d88900 Moving method back to DboSourceTest, as it was very difficult to adapt it to use mock objects 2010-11-11 00:22:08 -04:30
mark_story
ec2884f17c Making routing suite include RedirectRoute. 2010-11-10 23:50:01 -05:00
mark_story
6c2b088706 Merge branch '2.0' into 2.0-view 2010-11-10 23:41:44 -05:00
mark_story
f4b0ec1d20 Updating E_STRICT issues in view test.
Removing dead methods and classes.
2010-11-10 23:40:56 -05:00
José Lorenzo Rodríguez
106379b7ef Removing all methods with mysql syntax or dependent on anyway of this Dbo out form DboSourceTest. 2010-11-10 23:31:54 -04:30
José Lorenzo Rodríguez
d46f953357 Changing test case to reflect that stats option was removed from DboSource::execute and merged into "log" option 2010-11-10 23:10:13 -04:30