adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2024-11-15 11:28:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixing issue where named params equal to null/false would be part of the generated url.

Browse source
This commit is contained in:
mark_story 2010-12-18 13:40:07 -05:00
parent 6ef8203d54
commit 8d404332a2
2 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cake/libs/route/cake_route.php
View file

@ -267,7 +267,7 @@ class CakeRoute {
$named = $pass = $diff = array(); $named = $pass = $diff = array();
foreach ($url as $key => $value) { foreach ($url as $key => $value) {
// pull out named params so comparisons later on are faster. // pull out named params so comparisons later on are faster.
if ($key[0] === ':') { if ($key[0] === ':' && ($value !== false && $value !== null)) {
$named[substr($key, 1)] = $value; $named[substr($key, 1)] = $value;
unset($url[$key]); unset($url[$key]);
continue; continue;

11
cake/tests/cases/libs/route/cake_route.test.php
View file

@ -338,6 +338,17 @@ class CakeRouteTestCase extends CakeTestCase {
$this->assertFalse($result); $this->assertFalse($result);
} }
/**
* test that named params with null/false are excluded
*
* @return void
*/
function testNamedParamsWithNullFalse() {
$route = new CakeRoute('/:controller/:action/*', array('plugin' => null));
$result = $route->match(array('controller' => 'posts', 'action' => 'index', ':page' => null, 'sort' => false));
$this->assertEquals('/posts/index/', $result);
}
/** /**
* test that match with patterns works. * test that match with patterns works.
* *