Commit graph

14090 commits

Author SHA1 Message Date
mark_story
5d830d7adb Fix multiple selects always failing post validation.
Fixes #3218
2012-09-18 14:41:51 -04:00
ADmad
88f5a7ad0f Merge pull request #855 from daVinciWanaB/patch-7
Update docblock
2012-09-18 06:58:29 -07:00
Dave
46035cfd73 Update lib/Cake/View/Helper/FormHelper.php 2012-09-18 10:56:36 -03:00
ADmad
82a1194ea0 Merge pull request #854 from daVinciWanaB/patch-6
Update lib/Cake/View/Helper/FormHelper.php
2012-09-18 06:56:08 -07:00
Dave
990d5f89f0 Update lib/Cake/View/Helper/FormHelper.php 2012-09-18 10:51:24 -03:00
mark_story
d6e2b6f83e Re-format long lines. 2012-09-14 22:08:52 -04:00
mark_story
0282194c20 Make permission denied redirects host relative.
This helps fix infinite redirect loops when HTTP_X_FORWARDED_HOST is
set, and fixes redirects back to external domains on authentication
errors.

Fixes #3207
2012-09-14 09:39:45 -04:00
Renan Gonçalves
d33f676ddd Handling a fatal error on console should call Shell::_stop(1).
Just like we do on web, any exception or fatal error will result into a InternalErrorException/FatalErrorException.
2012-09-14 14:17:07 +02:00
mark_story
7d2cbec79d Revert "Fix null not stopping model callbacks."
This reverts commit 82a8400def.

The previous change broke a number of tests as existing tests expect
that a return value of null will not stop events.
2012-09-13 22:49:17 -04:00
mark_story
82a8400def Fix null not stopping model callbacks.
Add a compatibility shim into CakeEventManager to fix `null` not
breaking model callbacks.  This was a regression created when model
callbacks were re-factored to use the event manager. This code should be
removed in 3.x as its inconsistent with events used everywhere else in
the framework.

Fixes #3123
2012-09-13 22:11:46 -04:00
mark_story
cf4a9f420f Tidy doc block. 2012-09-12 22:56:46 -04:00
mark_story
fb9360767e Make connection exceptions more helpful.
Fixes #3204
2012-09-12 22:31:07 -04:00
mark_story
99a9cc9669 Fix required field detection.
Fix required field detection to match documentation and behavior when
validating. Having `allowEmpty` in the first validation rule, makes the
field not 'required' as the field is allowed to be empty.

Fixes #3194
2012-09-11 21:59:46 -04:00
mark_story
2bbf6bd568 Forward model option to PaginatorHelper::link().
Fixes #3193
2012-09-11 21:47:41 -04:00
Ceeram
ce1b387de2 fix incorrect docblock 2012-09-10 09:17:29 +02:00
mark_story
4f637ed4c4 Revert "Fix failing tests in PHPUnit 3.7.0-RC2"
This reverts commit d26040e3aa.
This change causes tests to fail in PHPUnit 3.6, this will have to wait
until 3.7.0 stable.
2012-09-09 21:36:33 -04:00
mark_story
d26040e3aa Fix failing tests in PHPUnit 3.7.0-RC2 2012-09-09 21:25:53 -04:00
mark_story
e8c1140fc8 Fix notice error. 2012-09-09 21:08:21 -04:00
mark_story
a934f700f1 Fix parsing '0' as a url.
Fixes #3198
2012-09-09 20:56:40 -04:00
Jose Lorenzo Rodriguez
9ac5cbed36 Added MailTransport test class refs #2824 2012-09-09 15:48:14 +02:00
Mark Story
261b6b01e8 Merge pull request #819 from ceeram/2.2-cookie
remove cookie reading in startup
2012-09-06 18:50:57 -07:00
Ceeram
0b0d83f261 remove cookie reading in startup 2012-09-07 00:04:03 +02:00
Mark Story
93004fcf2f Merge pull request #818 from shama/patch-unused-vars
Remove unused variables and code
2012-09-05 17:50:06 -07:00
Mark Story
c8cb3ae75f Merge pull request #810 from schrolli/patch-2
Update lib/Cake/Configure/IniReader.php
2012-09-05 17:45:43 -07:00
Kyle Robinson Young
bc40ac7d3f Remove unused variables and code 2012-09-05 17:19:13 -07:00
Mark Story
878f18419c Merge pull request #817 from shama/patch-trimpath
Remove never reached code in Debugger::trimPath and test more results
2012-09-05 17:12:23 -07:00
Kyle Robinson Young
a214fcd992 Remove never reached code in Debugger::trimPath and test more results 2012-09-05 15:57:53 -07:00
Mark Story
f1c2b1fba8 Merge pull request #816 from shama/patch-email-component
Fix $readReceipt variable in EmailComponent::send
2012-09-05 14:59:19 -07:00
Kyle Robinson Young
602240c08e Fix $readReceipt variable in EmailComponent::send 2012-09-05 12:49:09 -07:00
mark_story
c7647b775f Attempt to fix build error in travis. 2012-09-04 17:25:02 -04:00
Mark Story
f6b1d08f02 Merge pull request #814 from shama/patch-cs
Code standards fixes: removing unneeded break statements
2012-09-04 14:12:22 -07:00
Kyle Robinson Young
200dd2dc9b Code standards fixes, unneeded break statements 2012-09-04 11:30:52 -07:00
mark_story
5b641287e9 Make schema errors clearer.
When a schema fails because of the name, the error should display
the name & file name that it attempted to load. This gives people
a slightly better chance of figuring things out.
2012-09-03 21:06:48 -04:00
mark_story
0d826528e1 Supress fewer errors.
PHPUnit raises exceptions on errors, there isn't much point in
supressing all these errors.
2012-09-03 20:13:30 -04:00
mark_story
bacd8afde3 Remove duplicated header. 2012-09-03 19:55:29 -04:00
mark_story
3cb501f1c5 Fix issue created in [e8b5d81fd7]
Query conditions with `-` and no surrounding spaces were quoted
incorrectly.

Fixes #3178
2012-09-03 13:24:38 -04:00
mark_story
583bb37df0 Fix typo. 2012-09-03 13:10:27 -04:00
schrolli
83c05c24b3 Update lib/Cake/Configure/IniReader.php
Updated docblock and set NULL as the default value of $path
2012-09-02 14:23:26 +03:00
schrolli
a4c382b23a Update lib/Cake/Configure/IniReader.php
Copied standard path from PhpReader
2012-09-02 06:02:30 +03:00
mark_story
f155687cfa Update version number to 2.2.2 2012-09-01 18:28:03 +01:00
mark_story
474e42cc08 Switch File::info() tests to use a different file.
text/php files are not detected reliably across platforms. Use a plain
text file instead.  This should fix builds on travis.ci
2012-09-01 12:40:05 +01:00
mark_story
d3105332dc Fix coding standards errors. 2012-09-01 12:14:15 +01:00
mark_story
e8b5d81fd7 Fix quoting of field names containing -.
Fixes #3165
2012-08-31 14:25:02 +01:00
ADmad
3e17c7aef9 Merge pull request #807 from kamui545/master
Fix typo
2012-08-30 23:59:10 -07:00
Maggion Emmanuel
03f6f041b2 Fix typo 2012-08-31 09:50:22 +03:00
mark_story
894fc1256a Add test cases for strings containing quotes.
Show that both double and single quoted strings are
handled correctly by ExtractTask.

Closes #3155
2012-08-30 23:48:32 +01:00
Mark Story
1239d39b16 Merge pull request #805 from shama/doc-viewblock
Correct docblock see tags from View to ViewBlock
2012-08-30 02:14:31 -07:00
Mark Story
876d5ee168 Merge pull request #804 from Ivoz/master
Update readme
2012-08-30 01:58:52 -07:00
Kyle Robinson Young
ee9a545c7d Correct docblock see tags to ViewBlock
Fixes http://cakephp.lighthouseapp.com/projects/43067/tickets/97-about-api-description-of-viewassign
2012-08-29 21:53:29 -07:00
Ivoz
027c464e2d Travis status going in... 2012-08-30 12:01:24 +10:00