Commit graph

720 commits

Author SHA1 Message Date
DarkAngelBGE
fefbe77208 Minor refactorings for DboMysql, DboSource and TextHelper
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8241 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-21 20:57:39 +00:00
gwoo
56bee6e1fc fixes #6507 paginator sort directions
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8239 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-21 01:53:14 +00:00
gwoo
4cfdd311a9 fixes #6476, crash on missing layout in session flash
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8238 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-21 01:33:12 +00:00
mark_story
76d5855d72 Applying patch from 'Phally' Fixes multiple issues in PaginatorHelper related to first and last option in numbers(). Fixes #6516
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8234 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-17 19:46:33 +00:00
mark_story
baea319122 Applying patch from 'Dremora' fixes JavascriptHelper::codeBlock() and blockEnd() bugs where content vanished due to incorrectly structured buffers. Minor behavior change in that codeBlock(null) no longer returns an opening script tag. The entire script tag is returned when blockEnd() is called.
Test cases updated and refactored.
Fixes #6504


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8231 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-14 17:11:46 +00:00
davidpersson
68d333d088 Applying patches by ADMad updating HtmlHelper and adding test. Adding missing properties in test case. Preventing bleed through in test case. Fixes #6490
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8220 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-04 22:04:40 +00:00
gwoo
9e143bc335 fixes #6473, dot notation for sort in next/prev
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8213 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-02 23:48:10 +00:00
mark_story
1ea5f94c29 Updating JavascriptHelper::escapeString to properly encode utf8 characters as per the JSON spec.
Test cases added, with comparisons to json_encode()
Fixes #6400

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8198 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-06-17 01:59:41 +00:00
gwoo
e54dbd430f fixes #6419, redirect with cached view page
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8193 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-06-10 17:11:17 +00:00
mark_story
1910e5482b Updating doc block for HtmlHelper::css(). Fixes #6059
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8175 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-05-22 01:25:13 +00:00
jperras
4f2d65943f Fixing form helper checkbox hidden input generation for disabled fields. Thanks to 'trevorsg' for the patch & test case.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8173 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-05-14 03:26:53 +00:00
mark_story
7eaf331213 Updating doc block for FormHelper::input(). Fixes #6328
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8160 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-29 12:40:15 +00:00
mark_story
8db4fe682b Allowing name attribute to pass on to hidden field in FormHelper::radio().
Fixes inconsistency with checkbox().  Test case added.
Fixes #6260

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8145 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-15 17:18:01 +00:00
mark_story
5f4cdf91ac Fixing AjaxHelper::dragOptions to match scriptaculous docs.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8136 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-06 00:57:46 +00:00
mark_story
5c4f838f5a Adding buffer flush to ajax helper test. Test suite menus now properly display.
Fixing Drag options.  Adding test coverage. Fixes #6266

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8135 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-06 00:45:53 +00:00
mark_story
d74e2d1a73 Fixing newline escaping for single quote strings, output now matches json_encode().
Test added, and old test fixed.
Fixing buffering issues, causing test suite menu to disappear when running JavascriptHelper Test case.
Fixes #6167

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8134 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-04 02:42:46 +00:00
mark_story
0516fb2090 Enabling disabled attribute to be passed to hidden input when making checkboxes.
Test case added. 
Fixes #6226

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8128 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-25 16:58:29 +00:00
jperras
4439bc4f70 Fixing regression in PaginatorHelper. Adding tests for PaginatorHelper::sortDir, as well as fixing incorrect test for sorting with Model.field dot notation. Fixes #6218.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8125 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-22 18:59:53 +00:00
renan.saddam
76e0f17dbc Updating documentation to improve code completion
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8114 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-17 21:10:28 +00:00
nate
36d3540c19 Adding native-type-generation fixes for JavascriptHelper::object()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8095 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-13 14:49:00 +00:00
mark_story
bf4fa09b8f Removing whitespace introduced in [8014]
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8093 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-12 17:33:47 +00:00
gwoo
de6541f658 fixes #6189, paginator sort direction for associated fields of the same name
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8092 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-12 17:11:08 +00:00
mariano.iglesias
fdbf102228 Fixing issue where disallowing plugin was not possible in PaginatorHelper, fixes #6159
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8090 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-11 19:24:06 +00:00
nate
92cc331341 Updating docblocks and code formatting in XML classes, adding test change to previous commit.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8089 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-11 04:09:35 +00:00
renan.saddam
b0a0f2ad30 Refactoring last change to cover issues like [7636]
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8079 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-06 13:29:56 +00:00
mark_story
c164be8c03 Enabling Asset.timestamp for HtmlHelper::image() making it consistent with Javascript::link().
Tests added.
Fixes #6170

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8078 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-06 04:40:50 +00:00
jperras
571f57822d Refactoring NumberHelper::toReadableSize to properly use I18n functionality.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8071 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-03 23:39:48 +00:00
jperras
79cba70758 Updating number helper to allow output of main currency symbol in the 'after' slot. Also added some basic i18n for NumberHelper::toReadableSize Fixes #6150.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8069 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-03 15:32:12 +00:00
mark_story
259ecbe9a7 Updating doc blocks on formhelper
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8067 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-28 22:17:56 +00:00
the_undefined
74bf622866 Fixes #6071
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8053 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-23 15:19:33 +00:00
mark_story
01340e8014 Fixing docblocks in HtmlHelper
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8048 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-18 19:07:15 +00:00
mark_story
42ef8bfbcf Updating doc strings in Javascript helper for better api generation.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8047 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-18 18:26:22 +00:00
mark_story
0beda262d1 Updating doc blocks in FormHelper.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8045 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-18 01:39:01 +00:00
mark_story
e7c71b4125 Updating doc blocks in helpers. Helps generate cleaner API.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8014 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-03 18:48:28 +00:00
TommyO
de1d1ae3bd Fixed asset.timestamp inconsistency for css files.
Added tests to confirm css linking.
Closes #5990. Fixes #5991

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7990 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-14 22:19:11 +00:00
mark_story
287968934f Fixing next()/prev() when paginating multiple models. Added tests from 'hummer'. Fixes #5970
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7989 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-14 22:08:11 +00:00
mark_story
79c791548f Fixing formHelper::hour when specifying a strtotime compatible string for the selected value. Tests added Fixes #5941
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7967 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-30 16:20:38 +00:00
nate
ad208ff8c3 Refactoring previous fix to revert markup changes in HtmlHelper, updating FormHelper tests to comply with coding standard, correcting bad assertions, fixing issue with field types being mis-identified if duplicate names are used, fixes #5919
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7959 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-25 22:13:06 +00:00
nate
61850b1be1 Cleaning up test code formatting, adding fix for POST hash validation of checkbox lists, fixes #5903, test cases added.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7951 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-23 08:13:00 +00:00
nate
e2c087f34b Fixing failing tests in JavascriptHelper.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7944 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-19 01:30:02 +00:00
john
a1046de895 Couple of syntax fixes - missing semicolon and usage of empty() inside a conditional.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7933 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-17 18:09:32 +00:00
nate
870c4e87ca Fixing code formatting in JavascriptHelper to wrap at 100 characters, small return-home-early refactoring.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7931 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-17 16:08:31 +00:00
mark_story
9071d8165f Correcting generation of id attributes for radio buttons. Tests added, fixes #5891
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7924 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-17 01:49:58 +00:00
mark_story
b2b4c4be47 Adding App::import() to app_helper files. Fixes issues with Missing Helper Class, and allows you to use helpers in shell classes. Fixes #5458
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7904 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-05 16:49:43 +00:00
gwoo
4dd105d415 fixes #5829, form helper using proper method reference for parseAttributes. A patch would have been nice, but some ticket submitters prefer not to make much effort.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7902 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-01 19:39:40 +00:00
mark_story
c49f213fcf Adding spaces before self close of meta link elements. W3C recommends a space before />. Fixes #5821
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7899 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-30 05:25:37 +00:00
mark_story
090028403b Fixing FormHelper dateTime creation when using custom empty strings and null values. Tests added. Fixes #5769
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7898 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-29 00:28:31 +00:00
mariano.iglesias
f9557c7611 Fixing issue where radio elements would produce wrong hash when Security component enabled in FormHelper, fixes #5791
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7891 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-25 16:32:54 +00:00
phpnut
69f883a89f Adding $data['attrib'] back to RssHelper::channel(); after more research use cases for this were found.
Related test case added

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7889 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-25 05:54:31 +00:00
mark_story
cfa2229689 Fixing incorrect implementation of RssHelper::channel(). Test cases added.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7887 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-24 23:10:29 +00:00