Mark Story
b7791dd94f
Removing variable that wasn't provided by the exception.
2010-09-05 02:04:08 -04:00
Mark Story
82fffe6914
Fixing issue where FormHelper::select() with multiple = checkbox and a custom name attribute would not work correctly. Fixes #1078
2010-09-05 01:28:13 -04:00
Mark Story
cc17e1a85a
Adding more doc blocks to error classes.
2010-09-04 19:18:14 -04:00
Mark Story
954676c9f6
Adding doc blocks to the new exception classes.
2010-09-04 19:16:06 -04:00
Mark Story
d198230e61
Fixing issue where errors that did not have a 500+ code would use the incorrect status code.
2010-09-04 19:06:10 -04:00
Mark Story
4d863618f5
Refactoring exception handling so codes are much more flexible and easy to change.
...
Made error404 and error500 more generic.
Removed error() as it didn't really make that much sense.
2010-09-04 15:38:10 -04:00
Mark Story
dbd34c75c7
Removing newlines and trailing space.
2010-09-04 15:36:57 -04:00
Mark Story
4980f42dc5
Renaming file.
2010-09-04 15:35:01 -04:00
Mark Story
42d998ca3b
Fixing up the include for the console error handler, and adding a test for stderr handle.
2010-09-04 10:46:04 -04:00
Mark Story
fa7549dc4c
Fixing comments and removing cakeError(). Instead you should be throwing exceptions.
2010-09-04 01:34:45 -04:00
Mark Story
af87e5d5bc
Adding a skip when AppError is present, as its behaviour is unknown.
2010-09-03 15:35:11 -04:00
Mark Story
8c428ff8a8
Moving where AppError is used, as infinite recursion is no fun.
2010-09-03 15:03:33 -04:00
Mark Story
5c0fe1b16e
Applying patch from 'majna'. Adding plugin to the list of template variables exposed in the controller task. Test added Fixes #1077
2010-09-03 12:33:59 -04:00
Mark Story
f2db19767d
Adding in support for AppError.
2010-09-03 10:30:35 -04:00
Mark Story
2c7ef67e97
Fixing stupid output buffering error.
2010-09-03 10:22:58 -04:00
Mark Story
29ade860b1
Adding cases for Error404 and Error500 exceptions.
2010-09-02 18:04:50 -04:00
Mark Story
a1e01e414b
Adding a tests for CakeExceptions and non CakeExceptions
2010-09-02 18:02:58 -04:00
Mark Story
a44b35311d
Integrating the ConsoleErrorHandler into the console environment.
2010-09-02 17:49:43 -04:00
Mark Story
60e44660c3
Moving ErrorHandler to ConsoleErrorHandler so it doesn't have classname conflicts.
...
Making the console use a subclass of ErrorHandler.
2010-09-02 17:49:00 -04:00
Mark Story
034aaa7462
Creating optional boot variable that informs Configure if it should bootstrap the app. Changing how ShellDispatcher checks for app existence it sets the $boot var now and reuses the framework bootstrap file instead of a second custom one.
2010-09-02 17:16:57 -04:00
Mark Story
81e6ca2249
Moving dispatcher include so that cake/bootstrap.php is only bootstrapping the framework. This should allow reusing the bootstrap file for console and web once console error handler is fixed.
2010-09-02 17:00:52 -04:00
Mark Story
d6b43c0e29
Removing TIME_START global, use $_SERVER['REQUEST_TIME'] instead.
2010-09-02 16:55:42 -04:00
Mark Story
ffa8b959e4
Changing classname and importing base class.
2010-09-02 16:47:06 -04:00
Mark Story
3940b059a3
Adding a big docblock to explain how to setup application exception handling.
2010-09-02 16:39:09 -04:00
Mark Story
2e8a60f932
Removing some mentions of cakeError as its been removed. Also adding information about exceptions that can be raised.
2010-09-02 16:38:19 -04:00
Mark Story
dbdd17f51a
Adding test cases from 'euromark' and updating how email addresses are parsed so they are slightly more conformant to RFC 5322. Fixes #1066
2010-09-02 11:16:10 -04:00
Mark Story
3e5e52d52e
Fixing doc block for Form::create(). Fixes #1058
2010-09-02 00:29:04 -04:00
Juan Basso
9239caa589
Added tests to use Xml with SOAP.
2010-09-01 21:37:32 -03:00
Mark Story
063fcf557d
Moving error handler inclusion to before Configure::bootstrap() so app error handlers can be created.
...
Fixing issue where unknown exception types would not be handled spewing out errors. Unknown exception types are interpreted as 500 errors.
2010-09-01 20:29:55 -04:00
Juan Basso
a1eeb03e36
Added tests to use Xml with XML-RPC.
2010-09-01 21:14:21 -03:00
Juan Basso
ff29897bad
Moving the rss content to a file.
2010-09-01 20:22:39 -03:00
Juan Basso
26b514e2cd
Chaning tests of Xml to public.
2010-09-01 20:09:03 -03:00
Juan Basso
edcb5e4370
Added tests to use Xml with RSS.
2010-09-01 20:06:56 -03:00
mark_story
08d6c19ab6
Adding test for themes in app/webroot dir. Closes #1061
2010-08-31 21:21:05 -04:00
mark_story
a8d4015f47
Updating bootstrap process in CLI to match the one in web.
...
Updating all_libs to use new file.
Updating error_handler test to run in cli.
Updating Controller so it imports required classes.
2010-08-30 22:59:10 -04:00
mark_story
1f30c06695
Fixing method coercion in error404 so it only coerces CakeExceptions.
...
Test Added.
2010-08-29 23:39:28 -04:00
mark_story
534f6006f8
Adding omitted parent call.
2010-08-29 23:38:46 -04:00
mark_story
612c52bb8b
Adding a beforeRender() that automatically escapes all the content sent to errors handled by CakeErrorController.
2010-08-29 23:31:20 -04:00
mark_story
78ac5bd20f
Removing sprintf() placeholders that don't work.
2010-08-29 23:28:54 -04:00
mark_story
efaa2e1177
Refactoring test case to use a dataprovider for the uniform/copy paste test cases.
2010-08-29 21:53:44 -04:00
mark_story
f1164c93d6
Updating the various CakeExceptions to take arrays in their constructors. This allows for the existing templates to continue working, as well as generalize the way in which errors are handled. This change also makes the messages coming out of exceptions more readable and removes string hackery.
2010-08-29 21:37:25 -04:00
mark_story
741f2972f9
Removing non required attribute from missing controller error page.
2010-08-29 15:12:50 -04:00
mark_story
99cde14432
No more skipped tests for ErrorHandler.
...
Removing missing_model as it was never called.
2010-08-29 13:49:10 -04:00
predominant
465b15c64e
Removing reference assignments.
2010-08-29 23:09:33 +10:00
mark_story
7fb62e9b7e
Updating more error messages to use exceptions.
2010-08-29 01:26:21 -04:00
mark_story
041aeecce4
Renaming test case file to match class file.
...
Updating tests and methods for missing_action, missing_view, private_action.
2010-08-29 01:01:36 -04:00
mark_story
88c66c057d
Renaming error.php to error_handler.php to better match its class name.
2010-08-29 01:00:36 -04:00
mark_story
756baeafdb
Making CakeErrorController get the most recent request, this will help when using requestAction.
...
Updating test cases for error404.
Updating ErrorHandler
2010-08-28 23:32:14 -04:00
mark_story
8712a90c8b
Adding some tests for construction.
2010-08-28 22:50:29 -04:00
mark_story
a30721b46b
Moving exception classes around and making all the core exceptions extend one class that overrides the code to 500. The code value will be used as the HTTP status code for the error page.
2010-08-28 22:49:52 -04:00
mark_story
5d942ee609
Extracting a few methods to make testing easier, and subclasses easier to create.
2010-08-28 19:53:21 -04:00
mark_story
5257a66fe5
Merge branch '2.0' of github.com:cakephp/cakephp into 2.0
2010-08-28 11:26:28 -04:00
mark_story
26f4ad4da1
Modifying bootstrap so it sets a default exception handler.
...
Making a ghetto implementation of exception handling.
Adding a crude test case, adding incomplete markers to all other tests.
2010-08-28 01:39:02 -04:00
predominant
04d3353ee4
Adding access specifiers to methods
2010-08-28 15:38:48 +10:00
mark_story
9b3e91089a
Adding omitted types of exceptions.
2010-08-28 01:38:03 -04:00
mark_story
5de88c0f02
Moving CakeErrorController to its own file.
2010-08-28 01:37:39 -04:00
predominant
f7addabcf2
Whitespace removal
2010-08-28 15:27:12 +10:00
predominant
c1209a1a7a
Added RequestObject output in place of Controller:$output whicch no longer exists.
2010-08-28 15:15:23 +10:00
predominant
93b80042f8
Fix failing scaffold tests.
2010-08-28 15:01:43 +10:00
mark_story
a2186c412a
Updating doc blocks for CakeRequest and CakeResponse.
2010-08-28 00:59:07 -04:00
mark_story
d8b2bcdf06
Making view + helpers groups pass.
2010-08-28 00:40:12 -04:00
mark_story
dcb7a167b4
Fixing controller test cases.
2010-08-28 00:29:50 -04:00
mark_story
9485f0a993
Merge branch 'request-response' into 2.0
...
Conflicts:
cake/tests/cases/libs/controller/controller.test.php
2010-08-28 00:24:07 -04:00
mark_story
e4545dbe5e
Fixing failing tests in Dispatcher.test.
2010-08-28 00:19:09 -04:00
mark_story
c76f205bcb
Adding exceptions file.
2010-08-28 00:18:46 -04:00
mark_story
2cdb10812d
Merge branch '2.0-exceptions' into 2.0
...
Conflicts:
cake/dispatcher.php
cake/libs/controller/scaffold.php
cake/tests/cases/dispatcher.test.php
2010-08-28 00:14:34 -04:00
mark_story
dc67b9cacc
Moving all the exceptions into one file for the short term.
2010-08-28 00:08:35 -04:00
José Lorenzo Rodríguez
f63b093d24
Merge branch '2.0-request' into 2.0
...
Still tons of tests failing
Conflicts:
cake/dispatcher.php
cake/libs/controller/components/auth.php
cake/libs/controller/components/request_handler.php
cake/libs/controller/components/security.php
cake/libs/controller/controller.php
cake/libs/router.php
cake/libs/view/helper.php
cake/libs/view/helpers/html.php
cake/libs/view/view.php
cake/tests/cases/dispatcher.test.php
cake/tests/cases/libs/controller/components/auth.test.php
cake/tests/cases/libs/controller/components/request_handler.test.php
cake/tests/cases/libs/controller/components/security.test.php
cake/tests/cases/libs/controller/controller.test.php
cake/tests/cases/libs/router.test.php
cake/tests/cases/libs/view/helper.test.php
cake/tests/cases/libs/view/helpers/cache.test.php
cake/tests/cases/libs/view/helpers/form.test.php
cake/tests/cases/libs/view/helpers/html.test.php
cake/tests/cases/libs/view/helpers/js.test.php
cake/tests/cases/libs/view/helpers/paginator.test.php
2010-08-27 23:31:41 -04:30
mark_story
f0d938c1cb
Fixing failing tests in scaffold.
2010-08-27 23:59:29 -04:00
mark_story
0683dc43ff
Replacing cakeError calls with exceptions in ConnectionManager and Model.
2010-08-27 23:54:22 -04:00
mark_story
c4cb629d80
Replacing cakeError with exceptions in Scaffold.
2010-08-27 23:54:00 -04:00
mark_story
e600f86abd
Updating Dispatcher test to test for exceptions instead of cake error returns.
...
Removing a test that is no longer valid.
2010-08-27 23:40:22 -04:00
mark_story
b301b0d86e
Adding MissingModelException.
2010-08-27 23:04:35 -04:00
mark_story
caf7668de5
Adding documentation for Dispatcher::dispatch throwing exceptions.
2010-08-27 23:04:09 -04:00
mark_story
a15c4f89b4
Moving calls of cakeError() to using exceptions.
2010-08-27 22:59:48 -04:00
mark_story
1980c924b9
Adding RuntimeException classes for Dispatcher.
2010-08-27 22:48:02 -04:00
mark_story
1e6064ceae
Removing the last exclusion from the AllHelper group.
2010-08-26 23:31:25 -04:00
mark_story
1a52442057
Removing class_exists() check as the class is now lazy loaded.
2010-08-26 23:26:18 -04:00
mark_story
6c87a026b6
Updating base class.
2010-08-26 23:24:32 -04:00
mark_story
4cc2229641
Updating CacheHelper to use correct View API.
...
Updating View to make CacheHelper tests pass.
2010-08-26 23:24:09 -04:00
mark_story
19e301c867
Updating test view to use correct helper syntax.
2010-08-26 23:19:20 -04:00
mark_story
b02e213958
Adding test case from '0x20h'. Fixing issue where atomic = false, validate = first and saveAll() saving many rows could return an incorrect value. Fixes #1050
2010-08-26 22:21:39 -04:00
mark_story
ea9e30890f
Adding a workaround to DboSource::showLog() to work around fix added in [ da9c0da626
].
...
Also adding explanation message when logs are not generated.
2010-08-26 21:24:09 -04:00
mark_story
123873b4d8
Updating DboSource test to account for formatting of floats done in mysql/postgresql.
2010-08-26 21:20:13 -04:00
dogmatic69
95168cee6e
casting the find as an array to avoid errors with array_values() fixes #1041 and 4 failing tests (3 previous)
...
Signed-off-by: mark_story <mark@mark-story.com>
2010-08-26 20:32:48 -04:00
mark_story
465c24f903
Adding a test case for TextHelper::toList(). Closes #1043
2010-08-26 20:30:30 -04:00
mark_story
903b260638
Changing spaces to tabs.
2010-08-26 20:29:03 -04:00
mark_story
c48c0d6295
Fixing issue where ViewTask would make empty view files for actions that did not have templates. Test case added. Fixes #1040
2010-08-23 21:49:30 -04:00
mark_story
ece055eefe
Adding object type check to prevent fatal errors caused by view being used like a model object. Tests added. Fixes #1039
2010-08-23 21:39:23 -04:00
Juan Basso
52b09188f7
Adding fail tests to Xml::toArray().
2010-08-23 18:33:24 -03:00
Juan Basso
84cf5d599c
Changing to use array in tests.
2010-08-23 18:23:53 -03:00
Juan Basso
65726841cd
Merge branch 2.0-xml of github.com:cakephp/cakephp into 2.0-xml
2010-08-23 01:49:42 -03:00
Juan Basso
f8b4d92a34
Arrays with @ as key now is the value of tag in Xml.
2010-08-23 01:33:06 -03:00
mark_story
ac36bc5894
Adding some docblocks to Xml.
2010-08-23 00:01:55 -04:00
Juan Basso
f777bd983f
Making Xml::fromArray() parse @ in attibutes keys.
2010-08-23 00:48:34 -03:00
Juan Basso
9611ab1027
Changing to Xml::toArray() return @ after attributes to dont conflict with tags with same name.
2010-08-23 00:24:56 -03:00
mark_story
b1c41e5e18
Making tests use dataProviders instead of repeated test methods.
2010-08-22 23:19:54 -04:00
mark_story
b5b7595bc0
Fixing issue in scaffold where it accessed $output, which no longer exists.
2010-08-22 12:41:04 -04:00
mark_story
91c9c74274
Removing response injection into controller from dispatcher.
...
Modifying Dispatcher to use accessor method.
2010-08-22 12:40:06 -04:00
mark_story
7221f9c3b9
Moving response construction into Controller, this will let controller classes more easily modify the response subclass they want to use.
...
Test case updated.
2010-08-22 12:31:55 -04:00
mark_story
44f1687f5b
Adding another test.
2010-08-22 00:54:55 -04:00
mark_story
efc1a2033f
Adding spaces infront of comment blocks.
2010-08-22 00:48:24 -04:00
mark_story
ec22db597f
Adding methods to get host, domain and subdomains for a request.
...
Tests added.
2010-08-22 00:44:05 -04:00
mark_story
0ec0962932
Adding CakeRequest::method() to find the name of the HTTP method name used for the request. Test case added.
2010-08-22 00:15:13 -04:00
mark_story
5446a062ee
Fixing issue where whitelist would not be used for validation. Test case added. Fixes #1037
2010-08-21 22:48:59 -04:00
mark_story
12d4b52f10
Fixing failing tests in DboMysql and DboPostgres related to localized floats. Refs #1029
2010-08-21 00:49:40 -04:00
mark_story
eb96d8acfb
Adding tests to dbo_postgres for localized floats. Refs #1029
2010-08-21 00:39:45 -04:00
mark_story
afc05c1e05
Adding test cases for using localized floats with mysql. Also added a generic model test case. Refs #1029
2010-08-21 00:19:30 -04:00
mark_story
e23fe25787
Fixing code formatting.
2010-08-21 00:17:40 -04:00
zimakm
b22f2f746b
Configure fix problem 3-dimensional arrays to be handled as 4+ arrays.
...
This saves a lot of execution time when configure holds many values.
Fixes #1028
Signed-off-by: mark_story <mark@mark-story.com>
2010-08-18 22:29:23 -04:00
mark_story
6d8c761f2f
Adding a missing s.
2010-08-17 22:25:45 -04:00
mark_story
750fe3aa05
Removing text() and password() as the new __call method handles them.
...
Updating test cases and adding a test for allowing a magic method to override the type.
2010-08-17 00:13:22 -04:00
mark_story
4efc170ce4
Adding some documentation.
2010-08-17 00:08:41 -04:00
mark_story
e79df23491
Adding a magic __call method to handle html5 inputs and simplify input generation logic.
2010-08-17 00:06:23 -04:00
mark_story
e2fee17173
Adding an ob_end_flush() to clean up an unclosed buffer.
2010-08-16 23:34:43 -04:00
mark_story
4622ec44c2
Updating the skel and app test.php's to not make a global variable for the dispatcher. This dramatically improves the performance of the web test runner.
2010-08-16 23:33:07 -04:00
mark_story
f46241a6e7
Merge branch '2.0' into 2.0-helpers
2010-08-16 23:02:44 -04:00
mark_story
fc9340213e
Applying patch from 'thatcode', makes the 'us' rule case insensitive. Fixes #1020
2010-08-16 22:26:48 -04:00
mark_story
2abf34d93e
Fixing issue where an app that was in a directory that had the same name
...
as a controller would end up failing to find view cache files.
Adding test for app name in controller name failure to create cache
Fixes #1025
Conflicts:
cake/libs/view/helpers/cache.php
2010-08-16 22:11:25 -04:00
mark_story
c4a978d386
Adding changes missed in the merge.
2010-08-15 23:10:29 -04:00
mark_story
705e90bef7
Merge branch '1.3' into 2.0-merge
...
Conflicts:
cake/libs/cache/memcache.php
cake/libs/cake_session.php
cake/libs/model/behaviors/acl.php
cake/tests/cases/dispatcher.test.php
cake/tests/cases/libs/cake_test_fixture.test.php
cake/tests/cases/libs/model/behaviors/acl.test.php
cake/tests/cases/libs/model/datasources/dbo/dbo_postgres.test.php
2010-08-15 23:09:02 -04:00
mark_story
2a50c3a1fb
Removing time manipulation so its possible to create memcache entries that do not expire. Updating documentation about the peculiarities of memcache. Refs #871
2010-08-15 22:40:55 -04:00
mark_story
0865679684
Removing _expires keys made with Memcache cache engine. These did not add any value as Memcache already handles expiration of keys. Fixes #871
2010-08-15 22:32:52 -04:00
mark_story
686b9c2c8b
Fixing issues in alterSchema in DboMysql and DboPostgres, where fields would be appended to each table being altered.
...
Also fixed an issue in DboPostgres where the generated alter statements would contain too many ;.
Test cases added. Fixes #1023
2010-08-15 22:17:02 -04:00
mark_story
aba97d0ab2
Applying patch from 'Mark Mitchell' to fix auto exiting of cake.bat. Fixes #992
2010-08-14 18:54:12 -04:00
mark_story
1b41a987fa
Adding test cases and fixing inflection issues with bases. Tests added. Fixes #1012
2010-08-12 20:26:11 -04:00
mark_story
36e585bb23
Starting to update a test that was previously marked incomplete.
2010-08-11 23:08:46 -04:00
mark_story
238c734f70
Moving a test case that should be implemented in controller, as that is where the code that needs to be tested is located.
2010-08-11 22:47:54 -04:00
mark_story
45064315d4
Fixing a comment.
2010-08-11 22:47:20 -04:00
mark_story
bd89ef533b
Updating session helper constructor to fix failing tests in Controller::render() integration tests.
2010-08-11 00:01:24 -04:00
mark_story
62d646d168
Removing tests that have been implemented elsewhere.
2010-08-10 23:56:39 -04:00
mark_story
74a12940cb
Removing incorrect method implementation.
...
Adding documentation to Component::beforeRedirect()
Adding documentation to ObjectCollection::trigger().
2010-08-10 23:45:28 -04:00
mark_story
4463ff7476
Moving all components suite.
2010-08-10 23:34:20 -04:00
mark_story
2494156e9a
Removing reference operators that caused tests to fail.
...
Adding an alias as several tests relied on a User object being in the registry to autodetect fields.
2010-08-10 23:18:43 -04:00
mark_story
3d5d6f6ebc
Removing two helpers from the exclusions as they don't cause issues anymore.
2010-08-10 23:18:43 -04:00
mark_story
fdfe8060c6
Adding collection tests to test suites.
2010-08-10 23:18:42 -04:00
mark_story
6d9cee57ba
Fixing failing tests from merge with 1.3
2010-08-10 23:18:42 -04:00
mark_story
59c692dbae
Fixing incorrect/failing test in Security component.
2010-08-10 23:18:42 -04:00
mark_story
f5bebc9306
Adding an Acl property to AuthComponent and updating tests to use new API's
2010-08-10 23:18:42 -04:00
mark_story
c6a63bae82
Fixing incorrect method call from merge with 1.3
2010-08-10 23:18:42 -04:00
mark_story
db1acb461a
Making SessionComponent extend Component. Updating test case.
2010-08-10 23:18:42 -04:00
mark_story
6dbe5b09f8
Fixing failing test caused by undefined variable.
2010-08-10 23:18:42 -04:00
mark_story
5068d62473
Fixing issue that came up in rebasing.
2010-08-10 23:18:42 -04:00
mark_story
cd48ee4a49
Removing comment about a feature that no longer exists.
2010-08-10 23:18:42 -04:00
mark_story
d01708b1ef
Adding temporary $View property to controller until I figure out a better way to provide access for it. Test case updated to reflect View not being in the registry anymore.
2010-08-10 23:18:42 -04:00
mark_story
07a7e18dc7
Removing ClassRegistry access in RssHelper.
2010-08-10 23:18:41 -04:00
mark_story
ab0f21f939
Fixing tests failing in ThemeView test as they were not expecting exceptions that should be expected.
2010-08-10 23:18:41 -04:00
mark_story
65c235023d
Removing ability to register View and ThemeView into ClassRegistry.
2010-08-10 23:18:41 -04:00
mark_story
dfa5273b22
Making SessionHelper not use ClassRegistry to access View. SessionHelper still needs to not inherit from CakeSession.
2010-08-10 23:18:41 -04:00
mark_story
576eba3ef9
Removing ClassRegistry use from FormHelper and its test case.
2010-08-10 23:18:41 -04:00
mark_story
90b0ac7258
Removing remaining ClassRegistry::getObject() in HtmlHelper.
2010-08-10 23:18:41 -04:00
mark_story
7b3f2f7e6e
Updating methods in Helper to use $this->_View.
2010-08-10 23:18:41 -04:00
mark_story
7efe1636aa
Making HtmlHelper not use ClassRegistry to access the View instance. Updating test cases.
2010-08-10 23:18:41 -04:00
mark_story
e0acd2131f
Fixing ShellDispatcher tests and making ShellDispatcher/Shell use TaskCollection to loadTasks.
2010-08-10 23:18:41 -04:00
mark_story
cb3c7feb5c
Adding test file to test loading.
2010-08-10 23:18:41 -04:00
mark_story
9804ed0cb3
Adding tests for loading plugin files.
2010-08-10 23:18:41 -04:00
mark_story
457f24d882
Adding TaskCollection, much like Helper and Component collection TaskCollection will be used to reduce global space pollution.
2010-08-10 23:18:41 -04:00
mark_story
19f008b1a4
Fixing broken tests in HelperCollectionTest
...
Moving unload into ObjectCollection as its common between 2 child classes, and possibly a 3rd.
2010-08-10 23:18:40 -04:00
mark_story
426d35d66e
Fixing string that got changed in a rebase.
2010-08-10 23:18:40 -04:00
mark_story
55d71dc4b5
Updating Controller test case to use new ComponentCollection.
2010-08-10 23:18:40 -04:00
mark_story
ca65faef36
Starting to fix SecurityComponent test case. SessionComponent still causing lots of trouble.
2010-08-10 23:18:40 -04:00
mark_story
fa8a43f038
Updating tests to use new Component api. There are still a pile of tests failing because of SessionComponent.
2010-08-10 23:18:40 -04:00
mark_story
0f5e881f26
Fixing typo.
2010-08-10 23:18:40 -04:00
mark_story
7b4916e16a
Updating AclComponent to new Component API.
2010-08-10 23:18:40 -04:00
mark_story
efc5054b65
Updating CookieComponent Test case to new Component api.
2010-08-10 23:18:40 -04:00
mark_story
a4e2f7c55f
Updating intialiize() callbacks. Moving $this->_set() int Component::__construct as all the core components did it. Updating constructors and including parent calls.
2010-08-10 23:18:40 -04:00
mark_story
052c81774c
Removing some code duplication.
2010-08-10 23:18:40 -04:00
mark_story
22fbc24560
Adding 'collectReturn' option to ObjectCollection::trigger. lets a callback collect the return of each object and return that.
...
Adding tests.
2010-08-10 23:18:40 -04:00
mark_story
54132cba79
Adding return checks, and changing mock creation.
2010-08-10 23:18:40 -04:00
mark_story
fac97738ce
Making Controller use ComponentCollection.
2010-08-10 23:18:39 -04:00
mark_story
256532b8e4
Updating Components to use Component as the parent class.
2010-08-10 23:18:39 -04:00
mark_story
bf75ab5737
Starting to update Component into a base class instead of a loader class.
2010-08-10 23:18:39 -04:00
mark_story
3666643b84
Adding ComponentCollection and a test case.
2010-08-10 23:18:39 -04:00
mark_story
337ab19145
Updating ObjectCollection::trigger() so it doesn't call __get().
...
Updating HelperCollection test which was passing by coincidence.
2010-08-10 23:18:39 -04:00
mark_story
62019888ba
Changing file headers to reflect accurate licences and versions created.
2010-08-10 23:18:39 -04:00
mark_story
c44c276fa3
Removing ModelBehavior::dispatchMethod(), replacing with call_user_func_array() as its faster and the php4 workaround is no longer needed.
2010-08-10 23:18:39 -04:00
mark_story
409b12954b
Simplifying logic and data structures used to store enabled-ness of objects in an object collection.
2010-08-10 23:18:39 -04:00
mark_story
b2250852e4
Moving BehaviorCollection into its own file.
...
Changing how behaviors are stored in the collection object. Makes it work the same as HelperCollection.
2010-08-10 23:18:39 -04:00
mark_story
fcbfb556c5
Moving loaded helpers into a protected array.
...
Adding magic methods to access the object array.
2010-08-10 23:18:39 -04:00
mark_story
c78e869be6
Removing PHP4 workarounds in BehaviorCollection.
...
Making BehaviorCollection throw exceptions instead of use cakeError.
2010-08-10 23:18:39 -04:00
mark_story
d048813af8
Adding in property copying until this branch gets merged with 2.0-request.
2010-08-10 23:18:39 -04:00
mark_story
d6362f1857
Converting spaces to tabs.
2010-08-10 23:18:38 -04:00
mark_story
6a88452072
Updating TextHelper to not use create_function(). The create_function calls leaked memory and didn't work with the new helper constructors.
2010-08-10 23:18:38 -04:00
mark_story
2d791e1ed0
TextHelper test case constructor issues fixed. There are still fails caused by create_function in the helper.
2010-08-10 23:18:38 -04:00
mark_story
3379e53be0
Updating test case to use correct methods.
...
Updating test case to run in CLI.
2010-08-10 23:18:38 -04:00
mark_story
ba8058500f
Adding test for attachedness of Helper helpers.
2010-08-10 23:18:38 -04:00
mark_story
4672cee5d3
Removing dispatchMethod from JsHelper, its not really that useful, and is good at hiding bugs in mock tests.
...
Updating test cases.
2010-08-10 23:18:38 -04:00
mark_story
0e933e8893
Updating most helper test cases to use View in their constructors.
2010-08-10 23:18:38 -04:00
mark_story
68ff2e5ce5
Adding additional tests for Helper lazy loading.
2010-08-10 23:18:38 -04:00
mark_story
fc3379767d
Moving methods around. ObjectCollection now normalizes helpers arrays. Plugin helpers now lazy load.
...
Tests updated.
2010-08-10 23:18:38 -04:00
mark_story
98982a6f7a
First attempt at lazy loading helpers done. Plugin support not complete.
2010-08-10 23:18:38 -04:00
mark_story
ab815a53ba
Helper test case is passing again.
2010-08-10 23:18:37 -04:00
mark_story
087ccabffe
Starting to modify Helper constructors.
2010-08-10 23:18:37 -04:00
mark_story
1d983e1cd4
Making MissingView and MissingLayout cake errors into exceptions.
2010-08-10 23:18:37 -04:00
mark_story
a23207791a
Modifying View to accept HelperCollection. Removing methods that are no longer needed.
2010-08-10 23:18:37 -04:00
mark_story
f8ecb10407
Adding stub callbacks so errors aren't generated.
2010-08-10 23:18:37 -04:00
mark_story
1c1c4bef80
Fixing errors that would occur when call_user_func_array() triggered failures.
2010-08-10 23:18:37 -04:00
mark_story
c15d228515
Initial integration of HelperCollection into View.
2010-08-10 23:18:37 -04:00
mark_story
16d5b2655c
Adding a way to load helpers in a disabled state. Updating tests and subclasses.
2010-08-10 23:18:37 -04:00
mark_story
d0de468ce0
Removing options that were not used in the generic application.
2010-08-10 23:18:37 -04:00
mark_story
aa61a251dc
Deprecating BehaviorCollection::attach() and BehaviorCollection::detach(). load() and unload() are more generic and make sense in other contexts.
...
Adding base trigger implementation.
Adding tests for helper triggering.
2010-08-10 23:18:37 -04:00
mark_story
9fd881cb00
Moving methods down and adding some tests.
2010-08-10 23:18:36 -04:00
mark_story
6db3dbc680
Starting to create HelperCollection which will be responsible for loading and constructing helpers.
...
Making an abstract class that will be the base of all object collections.
Adding test cases.
2010-08-10 23:18:36 -04:00
mark_story
d1028a7434
Applying patch from 'Mark Mitchell' to make cake.bat return the exit code of the called cake shell. Fixes #992
2010-08-10 23:12:55 -04:00
mark_story
da9c0da626
Changing sql_dump element so it only shows if there is no $logs variable set in the view. Overwriting it could adversely effect helper references. Fixes #998
2010-08-10 23:09:27 -04:00
mark_story
1371cefc3d
Applying patch from 'thatcode' to fix an issue where FormHelper::datetime() would not use 'default' or 'value' keys like other inputs would. This corrects an unintentional inconsistency in the methods. Test cases added. Fixes #988
2010-08-09 23:49:18 -04:00
mark_story
29ddffa2d3
Fixing regression in DboMysqlBase where describe() was no longer pulling out fieldParameters. A test case has been added to catch any future regressions. Fixes #991
2010-08-09 23:25:32 -04:00
mark_story
ccfb1d179a
Expanding test and fixing issue where the return of Folder::create() would be incorrect even though the directory was properly created. Fixes #996
2010-08-09 22:56:41 -04:00
mark_story
d6e3c318cd
Merge branch '1.3' of github.com:cakephp/cakephp into 1.3
2010-08-04 23:59:17 -04:00
mark_story
c28ecff862
Adding a test to ensure that $here contains the correct value when supplying additionalParams (like through a requestAction). Changing how Dispatcher::__extractParams converts url params into a string, so the result is the same as a string url.
...
Removing the call to _stop() as it halts the script when a requestAction hits a cached file. Fixes #977
2010-08-04 23:44:48 -04:00
mark_story
a04fe5f81d
Making Router::reverse() strip out additional framework internal parameters that are specific to requestAction. Refs #977
2010-08-04 23:35:49 -04:00
mark_story
8119f77659
Reformatting long lines.
2010-08-04 23:18:33 -04:00
mark_story
43bf1c539a
Separating the various requestAction tests into separate test methods.
2010-08-04 23:16:26 -04:00
mark_story
22673a5348
Adding a test case for CacheHelper correctly generating filenames when $this->here includes all the named and passed args. Refs #977
2010-08-04 23:08:43 -04:00
Juan Basso
72bb229a9c
Added tests to ticket #959
2010-08-04 22:10:44 -03:00
xbuzz
f2f2987743
Fixed 'convertEntities' to links in RSS. Fixes #959
2010-08-04 22:03:44 -03:00
Dirk Brünsicke
712ca6d5b5
Fixing bug in String::insert that produces unexpected results with
...
multiple keys that start with the same substring. Fixes #984
Signed-off-by: mark_story <mark@mark-story.com>
2010-08-03 22:38:45 -04:00
José Lorenzo Rodríguez
4a8e44b419
Adding test case for CakeResponse::mapType()
2010-08-02 19:33:09 -04:30
José Lorenzo Rodríguez
7e1426e743
Fixing doc block
2010-08-02 19:25:04 -04:30
José Lorenzo Rodríguez
e7c7008781
Changing behavior of RequestHandlerComponent::responseType(), it will return the current content type set int the response object
...
It will not return null as default as it did prior 2.0
2010-08-02 19:21:52 -04:30
José Lorenzo Rodríguez
1acbf15c00
Removing RequestHandlerComponent::_header() method
2010-08-02 19:17:43 -04:30
José Lorenzo Rodríguez
8968204cb5
Adding test method for CakeResponse::download()
2010-08-02 19:16:19 -04:30
José Lorenzo Rodríguez
cb63cd171c
Fixing typo
2010-08-02 19:12:58 -04:30
José Lorenzo Rodríguez
bbbb81e10a
Adding CakeResponse::download() method
2010-08-02 19:10:38 -04:30
José Lorenzo Rodríguez
5fb320f31d
Refactoring RequestHandler methods to use the response object
2010-08-02 19:10:01 -04:30
José Lorenzo Rodríguez
4fd032bc10
Refactoring RequestHandlerComponent::mapType() and added response object property to the component
2010-08-02 19:07:26 -04:30
José Lorenzo Rodríguez
040740c05d
Changing the order for comparisson checking on some types, when looking for a mime type
2010-08-02 19:04:53 -04:30
Juan Basso
ae2fa908c5
Dont use private attributes as tables in CakeSchema. Fixes #7
2010-08-02 00:22:46 -03:00
mark_story
3099a15f17
Removing old check for view == 'Theme'. This allows Scaffold to work well with Themed controllers. Test case added. Fixes #255
2010-08-01 22:25:29 -04:00
José Lorenzo Rodríguez
87eb1ec697
Adding the ability to add custom content types to CakeResponse
2010-08-01 14:22:02 -04:30
José Lorenzo Rodríguez
077f71aaa1
Refactoring controller rendering to use the CakeResponse object
2010-08-01 01:38:45 -04:30
Juan Basso
7e7a2c57e2
Fixing changes made in commit 522446e
to works with PHP 5.2-. Refs #974
2010-08-01 02:55:30 -03:00
José Lorenzo Rodríguez
0824348db1
Removing Controller::output property and refactoring methods to not use it. CakeResponse::body() should be used instead
2010-08-01 01:13:41 -04:30
José Lorenzo Rodríguez
1b5808420f
Removing Dispatcher::header() as it is now longer used
2010-08-01 00:49:16 -04:30
José Lorenzo Rodríguez
f9c97383e9
Refactored Controller::disableCache() to use the CakeResponse object, method was also deprecated
2010-08-01 00:16:50 -04:30
José Lorenzo Rodríguez
60f504a470
Refactored Controller::header() to use the CakeResponse object, deprecated Controller::header() and Controller::httpCodes()
2010-08-01 00:13:00 -04:30
José Lorenzo Rodríguez
9d104fee73
Refactoring Controller::redirect() to use the CakeResponse object
2010-08-01 00:10:46 -04:30
José Lorenzo Rodríguez
3ab4e09e11
Moving Controller::httpCodes() to CakeResponse
2010-08-01 00:09:09 -04:30
José Lorenzo Rodríguez
754c0776f8
Skipping response compression test when running in web tester
2010-07-31 20:59:04 -04:30
José Lorenzo Rodríguez
95bc6a7bba
Refactoring Dispatcher to use the response class when delivering assets
2010-07-31 20:50:57 -04:30
José Lorenzo Rodríguez
abafdb037b
Implementing the CakeResponse::compress() method
2010-07-31 19:30:25 -04:30
José Lorenzo Rodríguez
8780f0b33d
Implementing CakeResponse::cache()
2010-07-31 18:31:50 -04:30
José Lorenzo Rodríguez
5ba0e43aa3
Implementing CakeResponse::disableCache()
2010-07-31 17:40:49 -04:30
José Lorenzo Rodríguez
20d1e483cc
Implementing and tesing CakeResponse::send()
2010-07-31 16:58:13 -04:30
José Lorenzo Rodríguez
d1808db0df
Changing the encoding method for "charset"
2010-07-31 14:40:58 -04:30
José Lorenzo Rodríguez
2a4b30dba9
Implementing CakeResponse::header() method
2010-07-31 14:13:21 -04:30
mark_story
509a9e14e2
Fixing condition missing a model name in the TreeBehavior. Fixes #961
2010-07-31 14:29:00 -04:00
José Lorenzo Rodríguez
a2eac24ec0
Removing second parameter from CakeResponse, the response should not be magical
2010-07-31 13:10:37 -04:30
José Lorenzo Rodríguez
159ac2038e
Testing remaining implemented methods
2010-07-31 13:04:53 -04:30
mark_story
9f718de0b6
Reverting changes made in [ 60ab9800e2
]. Restoring use of isset() and $_SESSION = null. Fixes #971
2010-07-31 13:09:40 -04:00
mark_story
522446e0c2
Fixing issues where route elements could not have '-' in the parameter name because of limitations in pcre named capturing subpatterns. Tests added. Fixes #974
2010-07-31 13:03:45 -04:00
José Lorenzo Rodríguez
2c7b21b977
Completinng mime types array
2010-07-31 12:33:39 -04:30
José Lorenzo Rodríguez
f432de830c
Implementing some function in the response object, adding test case
2010-07-31 12:33:02 -04:30
mark_story
86cae09d79
Merge branch '1.3' of github.com:cakephp/cakephp into 1.3
2010-07-31 11:59:21 -04:00
ADmad
d04b327469
Fixing test case as it was error prone. Assuming the first value of $plugins array to be 'plugin_js' was incorrect.
2010-07-31 21:08:10 +05:30
mark_story
5efddf9a41
Adding a test case for route params with hyphens. Refs #974
2010-07-31 11:23:02 -04:00
mark_story
373bebb128
Updating test suite to properly handle parent_id situations. Fixes #881
2010-07-29 22:26:30 -04:00
mark_story
ac9721d582
Wrapping long lines.
2010-07-29 22:07:45 -04:00
mark_story
2b1efafe65
Applying optimization from 'michaelc' to reduce number of strtolower() calls in AclBehavior. Fixes #972
2010-07-29 22:04:22 -04:00
mark_story
3bda2ce100
Adding tests for database imports causing duplicated db prefix. Adding a workaround for the duplicated prefix name.
...
Fixes #962
2010-07-29 22:01:12 -04:00
José Lorenzo Rodríguez Urdaneta
ffd7066fa4
Adding the CakeREquest object with initial function signatures and parameters
2010-07-29 00:54:16 -04:30
mark_story
a9bb4eefae
Fixing failing test caused by registry pollution.
...
Adding a test case to prove that unqualified column names work with postgresql. Closes #930
2010-07-29 00:06:11 -04:00
mark_story
596c751ea3
Converting spaces to tabs.
2010-07-28 23:42:36 -04:00
Juan Basso
527446a3d1
Changing the RequestHandler to use new Xml class.
2010-07-28 21:29:12 -03:00
Juan Basso
53f8353f92
Updating Set to use new Xml class.
2010-07-28 19:53:52 -03:00
Juan Basso
b862d68016
Support to namespaces in Xml::toArray.
2010-07-28 19:46:35 -03:00
Juan Basso
f4d5230dfa
Fixing the read for toArray of content when have child or attribute in xml.
2010-07-28 18:53:36 -03:00
Juan Basso
8f1bdd5378
Change to RssHelper use Xml class instead XmlHelper.
2010-07-28 17:47:02 -03:00
ADmad
6527e9269a
Fixing detection and automatic appending of extension '.js' to urls in call to HtmlHelper::script(). Closes #965
2010-07-29 02:11:00 +05:30
José Lorenzo Rodríguez Urdaneta
69ee014a60
Merge branch '2.0' into 2.0-session
2010-07-27 22:27:17 -04:30
José Lorenzo Rodríguez Urdaneta
1c8ad1d1cc
Merge branch '2.0' of github.com:cakephp/cakephp into 2.0
2010-07-27 22:26:06 -04:30
José Lorenzo Rodríguez Urdaneta
4c71dd845e
Merge remote branch 'origin/2.0' into 2.0-request
...
Conflicts:
cake/libs/controller/components/auth.php
cake/tests/cases/libs/controller/components/auth.test.php
2010-07-27 22:02:08 -04:30
mark_story
272b327dc3
Fixing issue where $error would be set to an array.
2010-07-27 22:27:44 -04:00
mark_story
19d8c9e6bb
Removing a call to __setError() that isn't an error.
2010-07-27 22:27:44 -04:00
mark_story
8db0a19585
Refactoring duplicated logic into a method.
2010-07-27 22:27:44 -04:00
mark_story
ef586d9917
Updating test case to use autoRegenerate.
2010-07-27 22:27:43 -04:00
mark_story
f5bf4c5552
Changing config value name to more accurately represent what it does.
2010-07-27 22:27:43 -04:00
mark_story
6ff7ad68c9
Fixing some infinite loop issues in the test cases for CakeSession.
2010-07-27 22:27:43 -04:00
mark_story
b3febb483e
Fixing incorrect use of Cache::gc(). It has no parameters for now.
2010-07-27 22:27:43 -04:00
mark_story
2f1aa0a97f
Making CakeHtmlReporter dump a stack trace when an exception is caught.
2010-07-27 22:27:43 -04:00
mark_story
81f6f43193
Moving a few things around to better replicate how CakeSession behaved in 1.3. Also fixes the countdown & session id regeneration feature. Still need to write a test case for it though.
2010-07-27 22:27:43 -04:00
mark_story
d2097c514f
Fixing issue where infinite loops would occur when a session was first created.
2010-07-27 22:27:43 -04:00
mark_story
977ffa96be
Removing dead properties and methods from SessionComponent.
...
Sessions should be started as soon as the component is constructed. So there is no reason to have an active()/activate() method.
2010-07-27 22:27:43 -04:00
mark_story
574bfe6b67
Changing clear of $_SESSION to null instead of array(), makes checks later easier. Removing _checkValid call from destroy and making it run in start(), as destroy() calls start().
2010-07-27 22:27:43 -04:00
mark_story
a857e4505c
Adding files from previous commit.
2010-07-27 22:27:43 -04:00
mark_story
db5c44e386
Adding support + test cases for plugin and app/libs session handlers.
2010-07-27 22:27:42 -04:00
mark_story
5673ceb816
Updating core.php files with new session configuration.
2010-07-27 22:27:42 -04:00
mark_story
18b6668a34
Moving tests from SessionComponent to CakeSession, as that is where the features actually are. Removing Security.level/Security::inactiveMins() calculations.
2010-07-27 22:27:42 -04:00
mark_story
eb30c12560
Adding a test case for DatabaseSession::gc();
2010-07-27 22:27:13 -04:00
mark_story
28b9ed7264
Adding test cases for DatabaseSession and fixing a test case in CacheSession.
2010-07-27 22:27:13 -04:00
mark_story
7d2d2aaa4d
Adding test case stub for DatabaseSession and test case for CacheSession.
2010-07-27 22:27:13 -04:00
mark_story
951eeae817
Extracting handler location into a method.
...
Moving DatabaseSession and CacheSession into separate files. Tests to come soon.
2010-07-27 22:27:13 -04:00
mark_story
736d33647e
Adding tests for using a custom session config with CacheSession.
2010-07-27 22:27:13 -04:00
mark_story
49397c74af
Making cache config used for cache session storage configurable.
2010-07-27 22:27:13 -04:00
mark_story
f5d81e53fc
Refactoring Cache and Database session handlers into a separate class, and adding an interface for custom session handlers. Tests updated.
2010-07-27 22:27:13 -04:00
mark_story
a8b05c2fbc
Adding a check for '' and failure. When trying to Cache '', FileEngine will return false. This shouldn't trigger an error inside Cache.
2010-07-27 22:27:12 -04:00
mark_story
339fa29502
Updating CakeSession test case and fixing a few issues in the default settings.
2010-07-27 22:27:12 -04:00
mark_story
b247559e9e
Starting to implement new session configuration setup. Test case updated.
2010-07-27 22:27:12 -04:00
predominant
f05a13a451
Added test for empty key write on CakeSession
2010-07-27 22:27:12 -04:00
predominant
7501fcf46d
Add test for empty read() calls on CakeSession
2010-07-27 22:27:12 -04:00