Ber Clausen
8d15ba5037
Fixing env('HTTP_BASE') for site domain names that have the form
...
xxx.yyy.zzz and use second level TLDs.
2011-01-09 17:43:41 -03:00
mark_story
8754d11aed
Adding EmailComponent::_getSocket() so EmailComponent + smtp is easier to test.
...
Fixing issue where hosts with portnames could cause smtp emails to fail.
Added tests, fixed an existing test to not depend on a local mailserver.
Fixes #1433
2011-01-06 23:10:01 -05:00
mark_story
f45f2e4096
Making niceShort() compare the original dateString and userOffset. This fixes issues where timezone differences would cause the incorrect short form to be displayed. Fixes #1331
2011-01-05 22:53:56 -05:00
mark_story
6e2ffafe54
Fixing Set::filter() not predictably filtering in a recursive fashion. While a minor change in behavior, more predictable and uniform behavior is worth it.
...
Fixes #1431
2011-01-05 22:48:09 -05:00
mark_story
5768bfe5c7
Fixing failing test caused by missing space.
2010-12-31 16:35:44 -05:00
mark_story
a7061510c1
Applying patch from 'rynop'. Fixing FixtureTask so it includes the datasource if its not the default one.
...
Updating tests.
Fixes #1419
2010-12-31 13:05:04 -05:00
mark_story
5092013304
Making EmailComponent register and un-register its view object, when rendering email templates. This allows helpers to use the view to do additional processing. Fixes #442
2010-12-27 15:12:27 -05:00
mark_story
c5c638e8f5
Fixing option documentation.
2010-12-27 10:40:50 -05:00
mark_story
56415f20cb
Fixing issue where CakeLog would log suppressed errors even when error reporting was disabled. Fixes #1403
2010-12-26 13:02:43 -05:00
mark_story
04929ae1df
Applying patch from 'Thorsten Buss'.
...
Fixes issues in DboSource, where mismatching types on join columns could result in incorrect query generation.
Fixes #708
2010-12-21 20:40:19 -05:00
Juan Basso
5d2b4c758d
Minor optimization in cache views.
2010-12-18 19:41:57 -02:00
Juan Basso
a7c7436d8e
Passing viewVars to cache views, avoiding cake:nocache problems.
2010-12-18 19:31:10 -02:00
Jeremy Harris
7416e58759
Allowed comma-delimited list in smtp $to var to be consistent with standard mail delivery. Fixes #1353
2010-12-14 20:55:34 -08:00
mark_story
53a687049c
Fixing encoding of address aliases. They are now mime-encoded like other headers. Tests added. Fixes #1360
2010-12-13 23:23:02 -05:00
mark_story
e410509684
Fixing TestTask not being able to find plugin objects when baking test skeletons interactively. Test case added. Fixes #1361
2010-12-13 22:04:55 -05:00
mark_story
5ffc84d28a
Calling parent constructors in helpers that have it omitted. Fixes #1359
2010-12-12 21:14:30 -05:00
mark_story
d7e62b88bc
Adding test cases for using helpers in nested elements from email
...
templates. Closes #1355
2010-12-09 22:34:20 -05:00
mark_story
a830632071
Changing View::element() to not overwrite viewVars with helpers that
...
have the same name.
Test added.
Fixes #1354
2010-12-09 22:06:23 -05:00
jblotus
48f32a11e0
Fixed incorrect docblock. Fixes #1350
...
Signed-off-by: mark_story <mark@mark-story.com>
2010-12-08 22:08:43 -05:00
mark_story
8681399fc2
Forcing the plugin list to use a fresh directory listing in the web runner. Fixes #1338
2010-12-06 21:29:11 -05:00
mark_story
7024d14c74
Removing private annotations for File::__construct() and File::__destruct() as its just not true. This also prevents them from being included in the API docs.
2010-12-05 18:41:26 -05:00
Graham Weldon
1dbed85979
Append Controller to error class name for isAuthorized() not implemented.
2010-12-04 22:14:33 +11:00
mark_story
44b09171ef
Adding unicode letters and numbers to url path segment regex.
...
Test case added.
Fixes #1284
2010-12-01 23:47:30 -05:00
dogmatic69
96b30f0547
adding tests for places that will leave a trailing 0 because of the way phps number_format() method works
...
Signed-off-by: mark_story <mark@mark-story.com>
2010-12-01 22:08:26 -05:00
Marko Marković
c55a57927c
Typos in documentation: reguired -> required
2010-12-01 08:12:25 +11:00
ADmad
1186bc56f1
Adding EmailCompnent::lineFeed property toallow overriding the default line feed string when using mail() function to send mail. Closes #1320
2010-11-27 02:11:43 +05:30
ADmad
70ae66edf7
Fixing test cases for EmailComponent
2010-11-27 01:21:19 +05:30
mark_story
15ca2400bc
Fixing issue in DboSource::name() where special characters in column names would not be correctly quoted.
...
Tests added.
Fixes #1264
2010-11-25 06:52:23 -05:00
mark_story
7d158e8d1f
Fixing Set::sort() for arrays with out of sequence, or missing keys.
...
Tests added.
Fixes #1312
2010-11-25 06:39:08 -05:00
mark_story
4214242efd
Adding test for correct merge order for $uses.
...
Fixing incorrect merge ordering for $uses, so it matches historical behaviour.
Fixes #1309
2010-11-24 22:44:12 -05:00
mark_story
0e29567f8d
Adding an array cast to fix issues where users could modify cookie
...
values causing iteration errors. Fixes #1309
2010-11-24 22:09:08 -05:00
ADmad
b567de977e
Fixed bug where Dispatcher::getUrl() returned incorrect URL if $base appeared in a $uri besides at start of $uri.
2010-11-24 02:15:44 +05:30
mark_story
d5fb0b25cb
Fixing issue where Date header would be missing from Emails sent by
...
EmailComponent.
Adding user configurable field for date.
Test cases added. Fixes #1304
2010-11-22 22:08:46 -05:00
mark_story
d9484c109f
Merge branch '1.3' of github.com:cakephp/cakephp into 1.3
2010-11-22 21:29:33 -05:00
mark_story
d0d16a7eda
Fixing i18n extraction errors in Scaffold. Fixes #1305
2010-11-22 21:29:11 -05:00
mark_story
bf10723f89
Applying patch from 'michealc' to fix duplicated comments. Fixes #1306
2010-11-22 21:21:55 -05:00
mark_story
f48811a2ff
Moving include up so its not buried deep inside the class.
2010-11-22 21:15:02 -05:00
mark_story
244de1df85
Adding a comment about the messageId property and shells. Refs #1303
2010-11-22 13:01:14 -05:00
mark_story
79aafda698
Removing use of serialize() for locked fields. This removes any
...
possible exploit related to serialize()/unserialize(). Instead values
are passed as | delimited.
2010-11-21 00:09:45 -05:00
mark_story
ae7855692d
Removing unserialize() as its dangerous. Instead using | delimited fields for locked fields. This totally avoids issues with serialize(). Removing str_rot13, as its only child proof.
...
Tests updated.
2010-11-20 23:42:54 -05:00
mark_story
ef3cb0e50c
Adding tests for Set::normalize()
2010-11-20 22:46:55 -05:00
mark_story
6d9b000aee
Changing how mergeVars are handled, so the difference of app/current is used as a base.
...
Also fixing issues where passing settings to helpers in AppController could result in them not being correctly merged.
Thanks to hashmich for the partial patch.
Fixes #1183
2010-11-20 22:34:24 -05:00
mark_story
e0a8ffe8a3
Applying patch from 'jmccaffrey' to fix issues on windows where virtual
...
machine paths would not be correctly handled. Fixes #1254
2010-11-20 13:26:30 -05:00
PhpNut
82d46067ab
Corrected doc comment.
2010-11-17 15:00:27 -06:00
PhpNut
bed7767258
Removing __cache property that can be altered outside of the class definition.
...
Adding __resetCache() as a replacement for checking if cache should be reset and written.
2010-11-17 14:02:35 -06:00
mark_story
5349257bbd
Changing empty() to !isset() to avoid additional cache hits when po files are missing or empty.
2010-11-16 07:32:14 -05:00
mark_story
4c3337598e
Updating version numbers for 1.3.6
2010-11-13 20:01:20 -05:00
mark_story
76a80c262e
Fixing failing test caused by name() being able to quote things better now.
2010-11-13 12:04:22 -05:00
Mariano Iglesias
a1467822fb
Fixing wrong assertion in test for CakeTestCase::testAction. Fixing testAction issue that would always include layout
2010-11-10 23:03:38 -04:30
mark_story
e8678b38ac
Adding specific conditions to model->delete's call to dbo->delete. This
...
helps fix a race condition where dbo->defaultConditions could cause
additional data loss. Fixes #250
2010-11-08 21:50:45 -05:00
Ceeram
bc7770aa83
removing useless calls to mapActions()
...
Signed-off-by: mark_story <mark@mark-story.com>
2010-11-07 23:16:41 -05:00
mark_story
e431e86aa4
Fixing issue found by Felix Wilhelm(flxm) where users could send potentially dangerous or corrupted serialized objects to SecurityComponent, potentially allowing manipulation of file map caches. Test case added.
2010-11-07 20:53:04 -05:00
ADmad
eb76ab95f2
Fixed issue where Model::saveAll() would incorrectly commit a transaction which was not started in that function call itself.
2010-11-06 09:33:50 +05:30
mark_story
268dae722e
Reverting change from [ 16387f1961
]. Using
...
the constant caused a number of issues for several other people. Refs #1231
2010-11-05 22:31:41 -04:00
mark_story
d56b812181
Fixing issue where an array to string conversion error could occur if you had multiple values for a model's primary key and you created a matching form. Tests added.
...
Fixes #1257
2010-11-04 21:08:40 -04:00
ADmad
81ce6f40b9
Added test cases showing usage of 'full_base' key for url generation. Refs #1256
2010-11-04 17:59:23 +05:30
mark_story
d1403b0da8
Changing NumberHelper::currency() to format < 1euro based on the suggestions from 'Joel Haasnoot'. Instead of 99c you will get €0,99.
...
Test cases updated. Fixes #1253
2010-11-02 21:56:24 -04:00
mark_story
2403d7fedc
Applying updates to skel/core.php. Fixes #1255
2010-11-02 21:43:33 -04:00
Mark Story
e6aeae8935
Fixing issue where value in difference array was always the string value instead of the original value.
2010-10-31 22:44:45 -04:00
Mark Story
b86bec14b5
Removing dead code in EmailComponent.
...
Fixes #1248
2010-10-31 00:00:54 -04:00
Mark Story
d5f582beee
Merge branch 'master' of http://github.com/kwiky/cakephp into kwicky
2010-10-30 00:29:21 -04:00
mark_story
18bffe8600
Applying doc block changes from 'teknoid'. Fixes #1239
2010-10-29 00:15:48 -04:00
mark_story
f29bb562cb
Adding a test for saving blank fields on a model. Closes #1243 .
2010-10-29 00:13:09 -04:00
mark_story
f5fd069583
Applying patch from 'Justas Butkus' to fix CakeSchema::compare()
...
Fixes issues with comparing null == '' and adds a new protected method to handle null aware array difference generation.
Tests added.
Fixes #1206
2010-10-27 23:03:31 -04:00
mark_story
16387f1961
Applying patch from 'Utoxin' that removes hardcoded 'app' string from Dispatcher. Fixes #1231
2010-10-27 22:42:12 -04:00
mark_story
3639f52117
Adding a test for containable modifying return. Refs #1219
2010-10-26 21:39:48 -04:00
Steve Grosbois
bc3a9e8a3a
Removing a dot at the end of a message in mission_action.ctp because there is no dot in the same message in all other errors view, this can help for traductors
2010-10-25 11:43:03 +02:00
SKAhack
9f2d33aa88
meta characters don't match on regex string
...
Signed-off-by: mark_story <mark@mark-story.com>
2010-10-24 21:42:11 -04:00
SKAhack
23f1c8e1c7
Fix regex match when regex included meta characters
...
Signed-off-by: mark_story <mark@mark-story.com>
2010-10-24 21:42:04 -04:00
mark_story
4496a0a0bb
Reformatting code to use tabs.
...
Fixing issue with float comparison.
Fixes #219
2010-10-24 19:43:41 -04:00
C. James Callaway
b8f0dda964
Updating to match ticket, using radians() SQL function.
2010-10-24 19:39:18 -04:00
C. James Callaway
a429287c19
Adding testcase for ticket #219
2010-10-24 19:38:23 -04:00
Graham Weldon
d3e0ddbb0e
Update copyright years.
2010-10-25 07:58:22 +11:00
Victor Castell
141b05e588
Updated copyright years in skel aplication template
2010-10-25 07:57:15 +11:00
mark_story
a16f4c5248
Updating version numbers for 1.3.5
2010-10-24 13:56:45 -04:00
mark_story
54854c493b
Changing output buffering, as ajaxtest was making output and breaking tests in group contexts.
2010-10-24 00:39:46 -04:00
mark_story
155bfe6293
Fixing failing test caused by setting an expiry value outside of the PECL extensions limits.
2010-10-24 00:05:27 -04:00
Juan Basso
deb20d4cf2
Fixed the PHPDoc.
2010-10-21 14:56:05 -02:00
Toni Uebernickel
b04f87f62d
fixed E_NOTICE undefined variable in CakeCliReporter::paintException
2010-10-21 14:56:04 -02:00
mark_story
7c296211ef
Making generating schema for connections with prefixes work correctly. The prefix needs to be removed so that when tables are created or updated they do not get the prefix added twice.
...
Moving tests around. Fixes #1180
2010-10-20 23:17:04 -04:00
mark_story
498417203b
Making DboSource::fields() use cacheMethod() so it respects $cacheMethods.
...
Test added.
Fixes #1211
2010-10-20 22:28:31 -04:00
mark_story
077d1c5ad5
Applying patch from 'hashmich' to fix issues with slideUp and slideDown effects in prototype engine.
...
Tests updated.
Fixes #1213
2010-10-20 22:07:53 -04:00
ADmad
ffc77aa588
Adding "function_exists" check before using "ini_set" in Debugger::__construct(). Fixes #1209
2010-10-20 02:16:17 +05:30
mark_story
1c25e627ad
Applying patch from 'Mark Mitchell' fixes issues with sending Email via smtp. Which were incorrect based on previous patches given for ticket #1100 .
...
Fixes #1205 , Fixes #1204
2010-10-18 22:06:12 -04:00
mark_story
61864a3b76
Adding some missing documentation and cleaning up code inside FormHelper::select().
2010-10-16 13:40:27 -04:00
mark_story
c35ef7dbab
Making class attribute bubble down into FormHelper::__selectOption().
...
Fixes issue where you couldn't change the classname of checkbox options.
Fixes #1202
2010-10-16 13:32:04 -04:00
mark_story
67874bd906
Fixing issue where defining a pattern for :action would create an optional route parameter that wouldn't respect its pattern.
...
Added the default action value only when a pattern isn't defined.
Added tests to CakeRoute and Router to cover this case.
Fixes #1197
2010-10-14 21:54:44 -04:00
mark_story
025090fbe9
Applying patch from 'dragonfly' to improve help output for AclShell.
...
Fixes #1198
2010-10-14 21:25:15 -04:00
mark_story
6529e0e2b4
Making optiongroup elements follow the escape parameter.
...
Tests added.
Fixes #1191
2010-10-13 21:59:53 -04:00
mark_story
3f2109f3c3
Applying patch from 'dragonfly' to fix issue where FormHelper would always append an argument even if one was supplied.
...
Test Added
Fixes #1155
2010-10-13 21:36:05 -04:00
mark_story
a0a84d1a8d
Changing pattern used to read digest auth data. Allows emails to be used as usernames.
...
This also adds the realm to the return value of SecurityComponent::parseDigestAuth(). Fixes #1181
2010-10-11 22:35:47 -04:00
mark_story
d56416456c
Applying patch from 'Justas Butkus' to DboSource
...
Fixes issues where reconnect could issue warnings related to
array_merge. Fixes #1182
2010-10-11 21:52:10 -04:00
ADmad
62161203f2
Fixed issue where FormHelper::radio() and FormHelper::select() with option "multiple"=>"checkbox" would generate tag with invalid "id" attribute if a value was non alphanumeric
2010-10-10 23:16:48 +05:30
Phally
0d86302404
Fixed issue with Set::extract() where conditions containing a space and a slash would fail. Fixes #1185
...
Signed-off-by: mark_story <mark@mark-story.com>
2010-10-08 23:28:23 -04:00
Phally
0e5613f63d
Fixed Set::extract() where single numeric keys (everything not 0) were skipped. Fixes #1175
...
Signed-off-by: mark_story <mark@mark-story.com>
2010-10-07 20:33:31 -04:00
mark_story
36737e6419
Adding documentation for new xml options. Adding a default setting to fix all the E_NOTICE errors triggered in [ 503b7cf5d7
]
...
Fixes #284
2010-10-02 19:20:43 -04:00
teknoid
503b7cf5d7
Adding slug option to avoid auto-slug of tags. Test included. Addresses #284
...
Signed-off-by: mark_story <mark@mark-story.com>
2010-10-02 19:16:07 -04:00
mark_story
5c27abd35f
Applying patch from 'hashmich' to make jQueryEngine not override the success callback. This allows you to provide a success callback and still get the html insertion when used with the update key.
...
Tests updated.
Fixes #1158
2010-10-01 22:43:46 -04:00
mark_story
5e26d282a1
Fixing connection specific schema generation
...
Fixing missing table errors when reading schema for specific connections.
Tests updated to check that tables not on a connection are never touched. Fixes #1106
2010-09-30 23:22:57 -04:00
mark_story
d83907a77d
Changing order of conditions, to put cheaper ones first.
...
Also fixes issues on safe_mode servers.
Fixes #1164
2010-09-30 23:03:23 -04:00