Commit graph

13998 commits

Author SHA1 Message Date
Jose Lorenzo Rodriguez
03dac31930 Using the static property instead 2011-07-17 22:41:12 -04:30
Jose Lorenzo Rodriguez
a786f4b1c6 Making DboSource::$methodCache a static variable to be able to share the cache between multiple instances of the same class 2011-07-17 22:26:21 -04:30
Jose Lorenzo Rodriguez
58282c3934 Micro optimization on Mysql source 2011-07-17 19:23:15 -04:30
Jose Lorenzo Rodriguez
762ebd4b93 Implementing a persitent method cache for DboSource, using a stronger hashing algorithm to ensure unique keys 2011-07-17 19:08:23 -04:30
Jose Lorenzo Rodriguez
ca0a7e4271 Removing method cache from DboSource::conditions() this was consuming too much memory and bringing little to no performance increase 2011-07-17 17:44:12 -04:30
Jose Lorenzo Rodriguez
b603232aee Removing redundant call to DboSource::fields(), the fields come already quoted from DboSource::read() 2011-07-17 17:42:47 -04:30
mark_story
ff5ac73988 Removing redundant/always true conditions in Controller::__mergeVars.
Fixes #1830
2011-07-16 22:44:57 -04:00
Jose Lorenzo Rodriguez
ad28228495 Removing unused parameters of tagIsInvalid() 2011-07-16 17:36:47 -04:30
Jose Lorenzo Rodriguez
108505a6a0 Merge branch '2.0-form-helper' into 2.0 2011-07-16 17:32:07 -04:30
Jose Lorenzo Rodriguez
c6c1bf110d Fixing caching of class loading in App class, this was broken after a recent refactoring
Additionally a new property $bootstrapping is added to App, this is set during the bootstrap process to indicate that classes loaded before the caching is initialized should not trigger the cache write routine.
Performance++
2011-07-15 20:44:39 -04:30
Jose Lorenzo Rodriguez
ca0dccb1e7 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2011-07-15 18:30:55 -04:30
Jose Lorenzo Rodriguez
a02db65fd1 Removing persist object feature, it was problematic an incomplete 2011-07-15 18:30:03 -04:30
Jose Lorenzo Rodriguez
d5ce09cd96 Restoring the validationErrors property in FormHelper, it will be checked first before the validation errors in the model 2011-07-15 18:24:27 -04:30
José Lorenzo Rodríguez
11f4d1c0e9 Fixing whitespace in CakeSchema 2011-07-15 14:49:33 -07:00
José Lorenzo Rodríguez
7596fcf45a Merge pull request #153 from ajibarra/e4c1f28d849c6a60c369265a502315260babe80b
Preventing AppModel to be inspected inside CakeSchema
2011-07-15 14:48:01 -07:00
José Lorenzo Rodríguez
57a8c108a6 Merge pull request #147 from burzum/feature/2.0-return-query
Feature/2.0 return query
2011-07-15 14:10:08 -07:00
Alejandro Ibarra
e4c1f28d84 Included validation to skip AppModel on CakeSchema->readSchema because it tries to find 'app_models' table. Added testSchemaReadWithAppModel test 2011-07-15 15:18:38 -04:30
Jose Lorenzo Rodriguez
fb264d9671 Adding a datetime validation method to the Validation class, closes #1021 2011-07-15 01:20:37 -04:30
Jose Lorenzo Rodriguez
8a6d97dfa7 Fixing loading of default options in CakePlugin::loadAll(), fixes #1737 2011-07-15 01:05:53 -04:30
Jose Lorenzo Rodriguez
84aba009e7 Documentation and code cleaning, this commit means that the FormHelper is now fully able to locate models even though lazy loading is used in the controller, closes #1690 2011-07-14 20:35:44 -04:30
Jose Lorenzo Rodriguez
b16a5f24db Making sure the default model for controller is added to the request models parameter in render() 2011-07-14 18:06:16 -04:30
Jose Lorenzo Rodriguez
37231b4ce6 Updating Controller test case 2011-07-14 17:38:02 -04:30
Jose Lorenzo Rodriguez
ac2538b108 REmoving call to deprecated method in PHPUnit 2011-07-14 17:28:53 -04:30
Jose Lorenzo Rodriguez
0c79ad88a3 Cleaning up the code and adding tests for new features 2011-07-14 17:26:55 -04:30
Jose Lorenzo Rodriguez
dcd8811771 Fixing typo 2011-07-14 16:05:23 -04:30
Jose Lorenzo Rodriguez
0228611969 Fixing remaining failing tests on FormHelperTest case 2011-07-14 13:56:31 -04:30
Jose Lorenzo Rodriguez
a5851e9597 Updating test to reflect that models passed as a request parameter are now in an associative array 2011-07-14 13:53:27 -04:30
Jose Lorenzo Rodriguez
4ed46cf330 Updating more tests on FormHelperTest case 2011-07-14 13:53:10 -04:30
Jose Lorenzo Rodriguez
ba012ed950 Adding a special case for not trying to instantiate a Model called Model in FormHelper 2011-07-14 11:13:51 -04:30
Jose Lorenzo Rodriguez
9304f3420b Currently the FormHelper fails if the Model supplied is 'Model', perhaps we need to add a special case for this 2011-07-14 11:05:41 -04:30
Jose Lorenzo Rodriguez
ef5650c034 Fixing ClassRegistry that was incorrectly checking class inheritance
Fixing Model class that was incorrectly sending model names to be instantiated
Fixing more FormHelper tests
2011-07-14 01:30:52 -04:30
Jose Lorenzo Rodriguez
1941be6a76 Updating FormHelper tests 2011-07-14 01:03:29 -04:30
Jose Lorenzo Rodriguez
e8efc67d3d Ensuring that classes returned by ClassRegistry::init() are model instances 2011-07-14 01:02:50 -04:30
Jose Lorenzo Rodriguez
60b44e074a Cleaning up the ClassRegistry::init() method, removing the use of the second parameter as it always accepted but one value
The second parameter is now $strict, meaning that if the model class is not found it will not try to create an AppModel instance
2011-07-14 00:06:01 -04:30
Jose Lorenzo Rodriguez
d54e8cd82f Starting to update tests after removing the validationErrors property in Helper 2011-07-13 23:51:23 -04:30
Jose Lorenzo Rodriguez
39dadf58db Refactoring how model information is extracted in the FormHelper, it is done now in a lazy manner and hopefully using less memory 2011-07-13 23:49:50 -04:30
Jose Lorenzo Rodriguez
22f02373c9 Moving tagIsInvalid from Helper back to FormHelper, as it is a better home for it 2011-07-13 23:49:01 -04:30
Jose Lorenzo Rodriguez
567ac0209c Refactoring how models are passed as a request parameter to the view, now the full plugin and model name will be passed on 2011-07-13 23:47:45 -04:30
Ceeram
a025cb2e01 Adding option to ProjectTask, for setting CAKE_CORE_INCLUDE_PATH. Tests added. 2011-07-13 23:54:24 +02:00
José Lorenzo Rodríguez
7d1c99a2b0 Fixed typo 2011-07-13 13:12:44 -07:00
Ceeram
e3dfec98c7 fixing regex for setting constant in test.php 2011-07-13 18:23:07 +02:00
Florian Krmer
adb943b7fd Refactoring the code to build the query array as suggested here https://github.com/cakephp/cakephp/pull/147#issuecomment-1553663 2011-07-12 23:31:07 +02:00
Ceeram
6047024546 removing unneeded parameter 2011-07-12 17:00:25 +02:00
Jose Lorenzo Rodriguez
e45b35cffe Removing the Controller::modelNames property and loading it's contents in the uses variable.
Simplifying code in Controller::render()
Setting all models loaded into the request parameters so it can be used later on the Form helper
2011-07-12 01:19:14 -04:30
Jose Lorenzo Rodriguez
f8ab1d3c73 Adding App::location() method to be able to obtain the defined path for a class 2011-07-12 00:38:50 -04:30
José Lorenzo Rodríguez
273125d2f5 Merge pull request #146 from majna/2.0-database-session
Refactored DatabaseSession to use only 'Session.handler.model' config
2011-07-11 16:28:25 -07:00
Florian Krmer
9d7c97c296 Adding the "returnQuery" key to the 2nd argument of the find() method to be able to get the query array back from the before state of findMethod() calls. This was required in the past for some more complex queries and is in 2.0 no longer possible because the find methods became protected. 2011-07-12 01:04:22 +02:00
Ceeram
4d702ee97f removing unused parameter for value() 2011-07-11 22:13:03 +02:00
Ceeram
00dd1ccc96 removing unneeded parameter, describe() only takes one parameter 2011-07-11 21:07:44 +02:00
Juan Basso
028065e5db Closing forgotten tag. 2011-07-11 09:45:22 -04:00