Commit graph

31 commits

Author SHA1 Message Date
brego
ec53963d40 Some PHP5 notices.
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@310 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 01:23:27 +00:00
phpnut
8a806d7fc5 going thru trunk and cleaning up the file headers so API docs can be created properly
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@309 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 01:07:14 +00:00
phpnut
a558a1e922 Form validation working now.
Be sure to review the changes made to the blog tutorial.
Some specific changes to note we pass model names in inputTag().
was: $html->inputTag('title', 40)
now: $html->inputTag('post/title', 40)

Also in the tagErrorMsg() we pass the model name.
was: $html->tagErrorMsg('body', 'Body is required.')
now: $html->tagErrorMsg('post/body', 'Body is required.') 
https://trac.cakephp.org/wiki/Cake/Tutorials/BlogPosts


git-svn-id: https://svn.cakephp.org/repo/trunk/cake@306 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-03 23:54:50 +00:00
phpnut
1178a63db4 Added flash method back to the controller for now
Will work on moving this out again at a later time


git-svn-id: https://svn.cakephp.org/repo/trunk/cake@305 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-03 19:09:39 +00:00
phpnut
301731fb1a Corrected the use of View class instance.
It looks like the way you where coding it was to be used as a Singleton.
In Controller::render() I am setting all View() attributed by pass reference.
I do not think it will effect other parts of the system.

You can see why I did this by uncommenting the print_r function in View::render().
Reload url in browser.
Then in Controller::render() remove the & from:
$view->autoRender =& $this->autoRender;
This is the only one that seems to cause array to print.

This may also caused in the Router::connect().
Look at this if you get time.
I noticed that each setting in the conf/routes.php file calls outer::connect();
Tee profiler show this happening 6 times on current install from trunk
Router::parse() is called 2 times.


We really need to get some good unit test in place.

Also speeded things up a little.

Profiler test:

Before changes on default install from trunk

Between:
Total Request Time: 13013.4 Milliseconds
Total Request Time: 13065.84 Milliseconds
28 files

After changes
Between:
Total Request Time: 10230.99 Milliseconds
Total Request Time: 10511.59 Milliseconds
27 files



git-svn-id: https://svn.cakephp.org/repo/trunk/cake@304 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-03 07:07:47 +00:00
phpnut
75cce3f107 Merging changes from Kamil's sandbox.
Beginning refactoring to bring current trunk to a usable release.


git-svn-id: https://svn.cakephp.org/repo/trunk/cake@301 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-02 22:49:04 +00:00
brego
975e0b3755 Changed error methods, and a typo in one error file.
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@277 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-23 20:45:22 +00:00
brego
d9a7885d0f DboFactory comes back, no more global variables. To get actual instance of db, call DboFactory::getInstance(). You can also change the running object with DboFactory::setConfig('configname').
Data validation is still dead, gonna spend a night on that one.



git-svn-id: https://svn.cakephp.org/repo/trunk/cake@276 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-23 20:41:10 +00:00
brego
ba139f10bb Database should work now. I have introduced some semi-singelton magic in dbo. DboFactory is no longer needed. This is not tested properly, and tests will most likely fail! Follow up soon.
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@274 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-23 13:59:02 +00:00
brego
9206b074d3 I do not want any uppercase letters in filenames. I want CamelCase actions that link to under_scored files.
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@273 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-23 08:32:04 +00:00
pies
27d16ff9b9 I'm sorry, I've reversed two changes. I've changed the error views names to underscored, and I've changed the default DEBUG to 1.
The first one is for consistency (no UppperCase filenames, please), the second is because while I'm no enemy of application security, the application has to be safe _after_ it's written, not before. And to easily write an application, the developer should have the DEBUG mode set to 1 or 2.

Other than that, I think it's a very good idea to put the tag generators in helpers :)

git-svn-id: https://svn.cakephp.org/repo/trunk/cake@271 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-22 23:16:26 +00:00
brego
dd5f22418e Tests run properly now - need to add more of them into /libs/helpers/html.php!
Data validation should work - not tested (will do it tomorrow).



git-svn-id: https://svn.cakephp.org/repo/trunk/cake@265 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-22 01:20:19 +00:00
brego
38ddea527e Ok, this one is very big. Firstly, I've outsourced (:]) helper methods like linkTo etc into separate files, located in /libs/helpers/*.
I am not finished with copying methods out of template.php, but it will come - also data validation would not be a problem helpers inclusion happens in the Template::_render().

Also, there was a bug with error functions (as Controller::missingView) - on linux, calling $this->render('../errors/missingController'); rsulted in an error - beacouse apparently is_file() cannot work with '..'. I added a simple fix in Template::_getViewFn.

I've also made some cleanups. Will continue to work tonight.



git-svn-id: https://svn.cakephp.org/repo/trunk/cake@264 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-21 23:44:49 +00:00
pies
b717167c4f - changed NeatArray to Narray, it's shorter, easier to use,
- Time::daysAsSql returns SQL limits for a set of days, perhaps should be in DBO,
- cleanups

git-svn-id: https://svn.cakephp.org/repo/trunk/cake@259 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-20 23:08:59 +00:00
brego
847d6df3a3 PHP5 bugs:
- "public" cannot be defined as constant (PHP5 keyword)
- Cannot re-assign $this in libs/template.php on line 217...

Other:
- Started on refactoring as described in #27 - but this feels like fooled aproach. We need to modularize HTML and AJAX stuff to be included only on-call.



git-svn-id: https://svn.cakephp.org/repo/trunk/cake@256 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-19 23:30:36 +00:00
pies
37e42105c6 I've merged in the changes by scharfie@gmail.com. For more information please see http://www.bluemargin.com/cake_custom_errors.zip. Olle, can you extract some information from the app/views/pages/home.thtml of that file?
The point is to provide custom error messages for Cake. As you will see, the quality of documentation is astounding.

git-svn-id: https://svn.cakephp.org/repo/trunk/cake@255 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-19 06:45:55 +00:00
pies
a8eed860b2 - added the csspp library that automatically reduces the size of CSS files; it is activated by prefixing an CSS file URL with /ccss/ instead of /css/ and there's a switch in the /config/core.php to activate it in Controller::cssTag()
- added a new class, File, currently only used by the Log class and Compressed CSS (CCSS) caching; aims to support easy reading and writing of files

git-svn-id: https://svn.cakephp.org/repo/trunk/cake@252 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-19 03:35:19 +00:00
pies
da79dff7d7 - merged in Brego's SimpleTest implementation, fixed some of the tests (the Folder test fails to delete one of the test directories on my system, so it's not perfectly clean yet)
- Dispatcher sets a Controller::here variable with the real URL used to access the page, so that tag generators can that use an url (linkTo and formTag for example) use the real url, not guess it from the controller and action names which often fails
- Log class works more reliably and a LogError() shortcut function was added
- Nstring class added, to store string-related functions (there are just four yet, including a random password generator and an string-to-array splitter
- SimpleTest library (with Rephlux) included in /vendors; I've tweaked SimpleScorer::inCli() function, because it didn't work on my setup, it should work everywhere now (it checks for empty REQUEST_METHOD, which should only be empty in CLI)

git-svn-id: https://svn.cakephp.org/repo/trunk/cake@248 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-18 23:26:35 +00:00
pies
27faaea8ea - Controller::imageTag() uses a path set in /config/paths.php
- new Controller::linkEmail() tag generator, with binary encoding (not UTF-8 compatibile)
- Controller::parseHtmlOptions() accepts a new second parameter -- options to exclude
- fixed DBO::farr() (ticked #23)
- fixed and cleaned up DBO layers NEEDS TESTING!
- fixed Template::renderElement(), it didn't use the controller's view vars
- models are loaded only if a database configuration is present

git-svn-id: https://svn.cakephp.org/repo/trunk/cake@247 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-14 19:57:01 +00:00
pies
39132f9bcf - I've rebuilt the startup a bit, more libraries are explicitly loaded at startup. They were loaded anyway (Object, Inflector), but implicitly thru uses() calls. I did it to untangle the relationships between files.
- Link tag generator fixed for compatibility with XHTML (& => &)
- prepare() and tables() methods renamed to prepareField() and tablesList() in database layers, prepare() and tables() meta-methods created in Model. The first one so that prepare() can accept both strings and arrays, the second one to fix Ticket #26 (case-sensitive table names didn't work for DB2).
- Few minor changes of includes() to requires() and the other way, to prevent unnecessary program terminations, and potential crashes.
- Time::toAtom() and Time::toRss() to format dates for XML feeds.
- Some code cleanups (unnecessary __construct()'s), also, I'm changing the parentheses into:

if (true)
{
}

I hope that's ok with everybody? I find it easier to understand code with that formatting. Does anyone know a highly configurable tool that would format PHP code automatically?

git-svn-id: https://svn.cakephp.org/repo/trunk/cake@241 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-11 03:45:31 +00:00
pies
3f10d747b7 - Cake didn't work without mod_rewrite, fixed (/index.php, /libs/router.php).
- Controller accepts $params as a constructor parameter (for Larry).
- DBO::prepare() returned an array even when a string was passed to it, fixed.
- Flay and Folder tests fixed, DBO_Factory test disabled (no database config by default, so do database access to test).
- 

git-svn-id: https://svn.cakephp.org/repo/trunk/cake@238 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-05 19:42:54 +00:00
pies
443a702376 I've merged in Olle's changes.
Larry, I've merged in _some_ of your changes, I'll merge in the scaffolding and joins code when you tell me it's ready. But I don't want to break how the Controller class works, can't we really do without the constructClasses() method call? Which reminds me, with your joins code, will we be able to use constructs like $user->post->findAll() and $user->post->save()?

Also, what are your changes to the DBO_MySQL class? I mean the mysqlResultSet(), and fetchResult() methods. I didn't see any MySQL-specific code inside them, perhaps they belong to the DBO class itself? 

- I've changed the headers on user-editable files in /app and /config. I hope they will constitute a compromise between readability and legality. I've left file Id, copyright, and licence notices.

- /libs/basic.php::uses() function logs included files in global $loaded. Please, consider it a note to myself. Also, I've moved the NeatArray class out of the /libs/basics.php (into /libs/neat_array.php).
- Some cleanups in the Controller and Dispatcher classes.
- DBO::Prepare() accepts strings _and_ arrays now. It's a step towards a unified params theory.
- I think I've added some comments to DBO sub-classes, but it might have been Olle.
- A fix in Model class (findAll didn't work properly)
- Object's constructor sets $this->db to &DBO, which means all Object-descendand classes have default access to the database if it's connected. We need to clean up the code accordingly (some classes set their own $this->db references).

git-svn-id: https://svn.cakephp.org/repo/trunk/cake@236 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-05 11:05:24 +00:00
pies
9bbe275903 (I don't know what's happening:/ )
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@207 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-05-31 23:18:22 +00:00
pies
4234bc9488 I've added some fixes and new methods, hope this gets to be in the today's release. If not, at least the fixes should get in as soon as possible.
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@192 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-05-29 19:43:59 +00:00
pies
4a87a75332 - Two standard controllers -- PageController and TestsController
- Helpers for controllers -- each controller has it's own helper in the /app/helpers directory
- /logs and /modules directories
- The application runs just fine without /config/database.php if controllers don't ask for db access
- Changed the name of /public/dispatch.php to /public/index.php, it's nicer and more standard, won't you agree? Kamil's fix for no-mod_rewrite needs to be re-implemented
- Cleanups, fixes, and even one or two comments ;)

git-svn-id: https://svn.cakephp.org/repo/trunk/cake@158 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-05-22 23:24:09 +00:00
pies
b5f6dba58e git-svn-id: https://svn.cakephp.org/repo/trunk/cake@148 3807eeeb-6ff5-0310-8944-8be069107fe0 2005-05-21 22:40:51 +00:00
phpnut
ce08562f5d modifying file headers
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@131 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-05-17 21:39:28 +00:00
pies
ae6c6d0a36 Bugfixes, cleanups and a new DbFactory class to generate DBO objects according to the db configuration.
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@129 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-05-17 20:55:27 +00:00
pies
a778f3c3c3 Merging my changes into trunk. This should give us a nice clean trunk to continue with. It's strongly recommended that you merge this version with your sandboxes -- I've added all the phpdoc fields and changed a lot.
I've removed the author/licence information from some files -- such as app/app_controller.php and config/database.php -- as they are not our code and those files need to remain as clean as possible for people not to get lost in them.

I've run the tests on this one, but the tests are not as extensive as they should be. If you want to get the test controller etc. check out the version in my sandbox. But we'll probably be moving to SimpleTest  soon anyway.

git-svn-id: https://svn.cakephp.org/repo/trunk/cake@114 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-05-16 23:14:37 +00:00
phpnut
bb71238ec1 change license to The MIT License
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@109 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-05-16 00:52:42 +00:00
phpnut
cd86555549 moving cake to a sub directory
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@106 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-05-15 21:41:38 +00:00