Commit graph

12227 commits

Author SHA1 Message Date
Jose Lorenzo Rodriguez
df2ef0e4f1 Bringing the SQlserver datasource up to date, fixing a doc block 2011-09-28 21:23:06 -04:30
José Lorenzo Rodríguez
aa6d6a9918 Merge pull request #221 from majna/2.0-doc-comments
Fixed doc block comments.
2011-09-28 14:07:46 -07:00
Majna
681207e327 Fixed doc block comments. 2011-09-28 22:33:46 +02:00
Ber Clausen
ae8dd1c969 Form input elements can now have 'error' class appended with empty error messages.
Allow setting empty error messages inside Model->validate. This
complements Ceeram's commit which allows overriding error messages by
empty strings from Form->input().
2011-09-28 12:14:01 -03:00
Ceeram
9f23f65755 Passing empty string in [\'error\'] behaved like false, now will behave like any other string 2011-09-28 12:14:01 -03:00
Jose Lorenzo Rodriguez
7f2a4e5137 Merge branch '1.3' of github.com:cakephp/cakephp into 1.3 2011-09-28 10:42:13 -04:30
Jeff Loiselle
932f07ca77 Fixes baking of custom views. Was not setting path correctly or
capturing content
2011-09-28 10:32:00 -04:00
mark_story
d489d490a6 Moving 'joins' key conversion into DboSource::buildJoinStatement()
Having this in Model felt like the wrong layer for it to reside.
This also simplifies a few things internally.
Refs #1517
2011-09-27 22:43:06 -04:00
Ceeram
6afa21cb18 find with joins option now respects prefix set in database configuration, fixes #1517
test to prove validity of ticket #1517
2011-09-27 22:43:06 -04:00
mark_story
08b974d64b Adding the _x and _y fields to the unlocked fields
for image submits.
Fixes #2032
2011-09-27 21:14:36 -04:00
mark_story
6e22f1d0a8 Excluding hidden files from test directory adding.
Fixes #2031
2011-09-27 20:43:47 -04:00
mark_story
421a2116be Adding error code checking around CakeException handling
SocketExceptions can have error codes outside of the HTTP values.
2011-09-27 20:39:32 -04:00
Mark Story
b3e57e0feb Merge pull request #215 from bar/1.3-fix-extract
Minor updates to Helper.
2011-09-27 17:01:06 -07:00
Renan Gonçalves aka renan.saddam
2bce6149e9 Merge pull request #217 from majna/2.0-test-suite
Fixing failing test.
2011-09-27 14:54:56 -07:00
Majna
8d6fc84135 Fixing failing test for Router. Debugger test fails on windows due to different directory separator. 2011-09-27 23:47:44 +02:00
ADmad
33030a4502 Fixing my previous attempt in ef4826e to make Model::_findCount() behave nicely with 'group' option. Refs #1677, #573 2011-09-28 02:58:48 +05:30
Ber Clausen
b5ddd4e5b7 Update Helper->tagIsInvalid() documentation. 2011-09-27 13:55:32 -03:00
Ber Clausen
a4fc424b40 Update Set::extract() calls inside Helper. 2011-09-27 13:24:24 -03:00
mark_story
7e44836837 Fixing failing test. 2011-09-26 21:46:25 -04:00
mark_story
6008e0e8a0 Adding quoting around SET NAMES.
Fixes #2028
2011-09-26 21:46:16 -04:00
mark_story
a5fe702624 Updating CrudAuthorize to work like ActionsAuthorize.
Updating tests.
Fixes #1749
2011-09-26 20:38:38 -04:00
ADmad
2a554237f4 Improving error view. Closes #2027 2011-09-26 11:49:49 +05:30
mark_story
79687a2dcf Making locking file caching the default.
Locking files prevents many issues with unserialize() warnings
caused by partially written files.
Fix a locking issue where files would be left locked.
Fixes #1988
2011-09-25 09:26:32 -04:00
mark_story
b1dad6e5bd Adding session renewal upon login/logout.
This helps improve session security, as it reduces the opportunity
of replaying a session id successfully.
Fixes #836
2011-09-24 22:35:21 -04:00
mark_story
50a0a51f53 Renaming method to better match what it does. 2011-09-24 21:56:37 -04:00
mark_story
dffcf048d9 Fix incorrect documentation. 2011-09-24 12:06:44 -04:00
mark_story
8272758eb9 Adding block to home page for PHP version.
Fixes #2010
2011-09-24 10:41:22 -04:00
mark_story
c2104a3613 Stripping - from default Message-ID header.
This fixes issues where certiain spamassassin rules would
flag EmailComponent messages as spam due to too many - in the messageID.
Fixes #2019
2011-09-23 22:41:19 -04:00
José Lorenzo Rodríguez
f57f7305f5 Merge pull request #212 from j15e/1.3
Fix to defect model virtualfields with mysqli
2011-09-23 07:17:07 -07:00
Jean-Philippe Doyle
af36429342 Fix to defect model virtualfields with mysqli
Refs #2017
2011-09-23 09:59:45 -04:00
ADmad
1d56afca11 Merge pull request #211 from basuke/2.0
Added tests for saveAll() to ensure it did not set foreignkey fields to null for associated models during validation (bug existed in 1.3)
2011-09-23 06:37:45 -07:00
Yosuke Basuke Suzuki
5612d411f3 Added unittest for saveAll() validation with the data no id assigned. 2011-09-23 22:23:26 +09:00
Bob Fanger
9f7126898b Added the "locale = $locale" condition to the ON part of the query.
Added "locale = $locale" to the ON part and changed the join type to an INNER join.
Because adding it to the WHERE part caused the translation to be mandatory anyway.
This cleans up the code and "INNER" joins are generally faster than LEFT joins.
2011-09-23 15:07:11 +02:00
ADmad
9220837908 Merge pull request #210 from basuke/1.3
1.3 saveAll() with validation option "only" or "first" works well with associated data.
2011-09-23 04:36:45 -07:00
Yosuke Basuke Suzuki
d9c48b0d34 Added unittest for eef87ee74c. 2011-09-23 18:23:50 +09:00
Yosuke Basuke Suzuki
eef87ee74c Bug fixed. saveAll with validation option "only" or "first" works wll.
saveAll() did set null foreign key when it just validates. I've
assigned numeric validation on the hasMany side model and validation
did fail with this behavior. I've changed this not to set foreign key
when it just validation.
2011-09-23 16:27:15 +09:00
mark_story
a65a5eb506 Apply patch from 'Eärendil' to fix FormHelper.
Fixes Model.field.1 style fields when used with SecurityComponent.
Fixes #2011
2011-09-22 22:30:04 -04:00
mark_story
36928d35f9 Redoing fix done in 155968349f
Adding more test cleanup to try and solve build issues.
2011-09-22 22:05:36 -04:00
mark_story
eccc05d8b1 Revert previous commit. Trying to fix jenkins build. 2011-09-22 21:39:00 -04:00
mark_story
155968349f Skip . and .. when generating trees.
Fixes #2012
2011-09-22 21:14:27 -04:00
mark_story
6a05cad69f Fix Validation::time so it accepts spaces.
Fixes #2015
2011-09-22 20:53:56 -04:00
ADmad
07f6803540 Additional inflection rules provided through Inflector::rules() now take precedence over the core ones as expected. Fixes #2016 2011-09-23 01:14:52 +05:30
Renan Gonçalves
0bcb8d0dfa Improving the regex and moving more files around.
- Making the regex case insensitive so it can also matches capital C in class (ie. Class).
- Adding a new protected method to move view files, the directory will be camelized.
2011-09-22 15:03:42 +02:00
mark_story
ceed424770 Updating doc blocks. 2011-09-21 22:30:02 -04:00
Jose Lorenzo Rodriguez
90d86678fa Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2011-09-21 13:32:03 -04:30
Jose Lorenzo Rodriguez
c45538ab08 Making CakePlugin::loadAll() static as its fellow class methods 2011-09-21 13:31:11 -04:30
José Lorenzo Rodríguez
b1f8d21434 Fixing doc block in core AppController file 2011-09-21 07:52:17 -05:30
mark_story
7cabb4e4d5 Extracting password hashing into as separate method.
This makes is much easier for a subclass to only change how passwords
are hashed.
2011-09-21 07:38:22 -04:00
mark_story
0267a048f3 Removing Mime type notice.
It causes message delivery failures on some SMTP servers.
Amazon SES suffers from this issue.
Fixing failing tests caused by additional spaces in email address
formatting.
Fixes #2005
2011-09-20 22:35:23 -04:00
Jelle Henkens
957a75c45e Removing PHP4 compatibility code
Signed-off-by: mark_story <mark@mark-story.com>
2011-09-20 21:10:32 -04:00