Commit graph

798 commits

Author SHA1 Message Date
Edgaras Janušauskas
49bbc21e1d Fix failures on PHP 7.4. Run phpcs on PHP 7.0 2019-12-05 15:11:35 +02:00
Pascal Woerde
2affcdfb00
Fix duplicate session_set_save_handler call from handler instantiation. 2019-11-26 13:39:22 +01:00
bancer
928f586599 Improved doc block 2019-04-29 10:40:10 +02:00
andrew.keiper
38074f72e9 adding support for PHP 5.3 by adding function_exists for session_status 2019-01-16 15:28:35 -05:00
andrew.keiper
06269b3fba resolving session issues for php 7.2 2019-01-16 10:43:04 -05:00
bancer
cf6c8d511f Improve support of enum data type 2018-12-12 12:40:20 +01:00
Yaser Naderi
3d224639d9 Add the functionality to accept enum MySQL datatype storing the Integer values as String (#12715)
Fix a bug in enum MySQL datatype storing Integers when enum contains
integer string values. Now strings will always be used for enum values.
2018-11-30 21:27:58 -05:00
bancer
3ea39d96b4 Add model id to all exists() method calls,
Related issue - https://github.com/dereuromark/cakephp-shim/issues/25
2018-10-30 10:39:16 +01:00
Humberto Pereira
23e38aeaf0 limiting the regex to consume only words in default value in PostgreSQL after ::
added tests showing the old behavior was broken.
2018-10-18 17:16:29 -04:00
Val Bancer
1a62c147fe
Improve handling of CURRENT_TIMESTAMP default value
Resolves https://github.com/cakephp/cakephp/issues/12553.
2018-09-12 16:45:01 +02:00
Mark Story
2bea29d07c
Merge pull request #12487 from josephzidell/php_7.3_issues
Fixes: a few issues found when running PHP 7.3
2018-09-09 12:50:23 -04:00
Mark Story
c2df84c701
Merge pull request #12503 from bancer/code-style
Improve documentation
2018-08-29 13:49:00 -07:00
Val Bancer
e13d44be87 Initialize $map to empty array 2018-08-26 14:20:38 +02:00
Val Bancer
df1c25f4cf Fix documentation of resultSet method 2018-08-26 02:23:29 +02:00
Val Bancer
2aa8fac574 Fix resultSet() method signature 2018-08-26 01:58:56 +02:00
Val Bancer
290bccedb4 Add missing method definitions 2018-08-25 23:19:26 +02:00
Val Bancer
957b4e566a Move declaration of $map to DboSource 2018-08-25 22:39:26 +02:00
Val Bancer
f768689bd0 Improve documentation 2018-08-25 19:34:29 +02:00
Joe
a4e71b3b40 Fixes:
* Issue with preg_match()
* Undefined variables
2018-08-21 14:46:58 -04:00
Jan Ptacek
d292a83407
Avoid undefined index: null (update action)
Avoid Notice (8): Undefined index: null [APP/Vendor/cakephp/cakephp/lib/Cake/Model/Datasource/DboSource.php, line 2180]
also discussed here: 22b0275#diff-b8a4043bec5d20830b77d240ae8fdef5R2087
fix for previous instance if same bug already merged here: cakephp#12411
(sorry for overlooking this second use-case :( )
2018-08-06 12:15:41 +02:00
Jan Ptacek
ca59191d5c
Avoid undefined index: null
Avoid Notice (8): Undefined index: null [APP/Vendor/cakephp/cakephp/lib/Cake/Model/Datasource/DboSource.php, line 1013]
also discussed here: 22b0275a58 (diff-b8a4043bec5d20830b77d240ae8fdef5R2087)
2018-07-30 11:17:24 +02:00
Mark Story
a1203409aa
Merge pull request #12218 from WrDX/WrDX-session-write-doc
2.x Updated docs for CakeSession
2018-06-12 10:54:22 -04:00
Wouter
9ef47b49cc
Update CakeSession.php 2018-06-12 10:21:37 +02:00
Mark Story
b5c9d1f860
Merge pull request #12212 from bancer/2.x-documentation
Improved property documentation
2018-06-11 14:36:16 -04:00
Val Bancer
3de5913cda
Improved property documentation 2018-06-11 10:20:40 +02:00
mark_story
99d63752d0 Fix failing tests. 2018-06-06 22:29:49 -04:00
Mark Story
cc9d2fcaa3
Fix phpcs issue. 2018-05-31 20:14:12 +00:00
Trent Renshaw
adefb973aa Replaced is_array() check and set of $keys in array with cast to array of $keys in array_filter()
Replaced assignment of $key and $dir through list() with each() with simply key() and current() per tenkoma's suggestion. Resolves # 11827

each() advances the pointer similar to next() but is being negated this particular case by array_shift() which resets the pointer
2018-05-31 15:46:28 +10:00
Philippe Gibert
98bc995623 fixes #11870 Add DboSource::expression support for Dbo VirtualFields 2018-03-23 17:19:41 +01:00
Mark Sch
b68f1cbb1f
Fix notice when passing false. 2018-03-14 17:07:08 +01:00
Mark Sch
df9c7fd96e
Merge pull request #11616 from cakephp/issue-11186
Fix missing field identifier quoting for COUNT(DISTINCT in SQLServer.
2018-02-05 14:48:22 +01:00
mark_story
5816143493 Fix usage of non-existant property.
Use the declared `_result` property instead. I would normally add
a test, but getting to this path requires a query to fail which is not
simple to simulate in the test harness.

Fixes #11615
2018-02-04 11:48:31 -05:00
Koji Tanaka
f4315d8ba4 When the PHP version is 7.2 or higher ini_set('session.save_handler', 'user') can't be executed, so delete. 2018-01-17 02:30:04 +09:00
mark_story
45695b6b5c Fix missing field identifier quoting for COUNT(DISTINCT in SQLServer.
Refs #11186
2018-01-09 17:01:00 -05:00
Mischa ter Smitten
d7b9e55e98 Fix indent 2017-11-23 14:12:13 +01:00
Mischa ter Smitten
05954ff405 Consistency changes 2017-11-23 10:09:25 +01:00
Mischa ter Smitten
4faac8e09a Improved readability 2017-11-23 10:06:14 +01:00
Mischa ter Smitten
bc1678cf2a Add option to make _validAgentAndTime 3.x compatible 2017-11-23 10:02:38 +01:00
Mark Story
d3a4ce1216 Merge pull request #11284 from kolorafa/patch-1
msSQL - also handle offset as string
2017-10-13 21:55:21 -04:00
Clemens Weiß
61eddc6bde Fixed formatting 2017-10-07 11:11:45 +02:00
Clemens Weiß
7f64ea37f9 Restored formatting 2017-10-06 17:11:09 +02:00
Clemens Weiß
5d5e791a31 Check for session.use_trans_sid and session ID in URL in case cookies are disabled (backport of cakephp/cakephp#10828 for 2.x) 2017-10-06 17:04:53 +02:00
kolorafa
22d2564de9 msSQL - also handle offset as string
When doing pagination you could get offset not as a int(eg. 10) but string(eg. "10") and it will not paginate at all.

For example DataTables plugin pass offset from params and all params from http request are strings wrapped in numbers.
Adding ctype_digit($offset) will also check the case.
2017-10-05 11:45:33 +02:00
LustyRain
31b13edf8a Fix: phpdoc miss
## did
- void unReturn
- miss return void
- add return type
- type miss typing
- add param type and return type
  - string → string|array
- change ClassName
2017-10-04 00:22:42 +09:00
Mike Fellows
0b658697f2 Sqlserver DboSource does not allow the persistent option to be true.
This is backported from CakePHP 3.  The SQL Server PHP PDO driver does not
support the PDO::ATTR_PERSISTENT attribute.  So throw an exception if the
'persistent' option is set in the database config.  Also removes that
option from the Sqlserver base config.
2017-08-16 11:23:42 -07:00
mark_story
aa6770fa45 Merge branch '2.x' into 2.next 2017-07-22 14:59:41 -04:00
mark_story
32f6b96060 Fix formatting. 2017-07-02 11:06:39 -04:00
Kurre Ståhlberg
4ec195f9c8 Fix error when default value is reported as CURRENT_TIMESTAMP() with parenthesis 2017-06-27 11:46:51 +03:00
mark_story
2032fef772 Merge branch '2.x' into 2.next 2017-06-26 21:51:41 -04:00
Marc Würth
da8414e13b Use HTTPS for the opensource.org MIT license URL 2017-06-11 00:23:22 +02:00