Commit graph

247 commits

Author SHA1 Message Date
gwoo
e26b7e7a63 refactor dispatcher, fixes #5033
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7365 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-26 20:09:20 +00:00
mark_story
cc098629a6 Added direction check to Controller::paginate(). paginate() now forces 'asc' when wrong. Added tests. Closes #5120
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7357 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-24 02:46:39 +00:00
phpnut
022ffa3f4f Adding fixes for pagination on associated models.
Corrected dot notation use in Controller::paginate();

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7286 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-27 06:25:08 +00:00
gwoo
b8714ede74 fix to paginate sort order for self associated models
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7278 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-27 03:12:45 +00:00
gwoo
1576a83505 fixing issue with sort in pagination and adding tests, removes previously deprecated controller methods and adds trigger_error to recent ones
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7276 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-27 00:43:31 +00:00
nate
df75a06756 Fixing coding standards violations in core, and adding misc tests
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7222 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-20 20:17:23 +00:00
gwoo
97a57a0f05 fixing bug in error handler when callbacks were moved to construct classes, moved callbacks back to dispatcher for now until we find a better place in the controller, fixed caching for the "home" page by adding check for "/', original test case was incorrect.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7177 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-12 18:36:08 +00:00
phpnut
6807d4c333 Starting initial refactoring of current code base.
Made changes to test suite to allow running test without headers already sent errors.
Moved Component::initialize(), Controller::beforeFilter(); and Component::startup(); from Dipatcher::start() to Controller::constructClasses();
Removed Dispatcher::start();
Fixing model instances not being created
Adding additional test to CookieComponent to increase coverage to 95%
Optimizing Set::diff();
Fixing SessionComponent test and RequestHandlerComponent test
Fixing CakeSession tests, removed deprecated code from CakeSession

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7162 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-10 22:38:05 +00:00
the_undefined
2d8e63ae7b Refactored and updated postConditions to new operator syntax, fixes #4860
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7145 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-09 08:29:56 +00:00
gwoo
b3f605c1d8 fixes #4836 components initialize for error pages, also changing Object::stop() to Object::_stop()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7116 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-04 19:04:58 +00:00
mark_story
55bcf1e25e Components can have settings assigned in the components declaration, tests added. Closes #4055
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7112 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-04 02:39:05 +00:00
gwoo
cf896eaa9b refactoring component handling, closes #4795, tests added. deprecated Controller::_initComponents();
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7070 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-31 03:54:22 +00:00
nate
42da5aba81 Moving Cake folder to correct location
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7063 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-30 11:40:08 +00:00
DarkAngelBGE
e6e0d852a2 deleting cake folder from svn
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7061 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-30 10:59:16 +00:00
mariano.iglesias
9c722b6999 Improving field detection in Containable. paginate() now avoids sending recursive to find calls when it is not explicitly set. Adding more tests to Containable to show how to paginate, fixes #4746
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7030 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-23 16:12:14 +00:00
mariano.iglesias
62bf371aec Allowing paginate to override the default find type for fetching records.
Set the find type as the first string parameter in your paginate settings:
var $paginate = array('popular', ...);
Check the test case for an example.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7013 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-22 17:07:42 +00:00
mariano.iglesias
8f92952d46 Allowing paginate() to send any extra parameters to the find call, and updating it to use new find notation.
Updating test in Containable to reflect how to properly use pagination: just set your 'contain' setting as you do with other pagination parameters, for example:
var $paginate = array('Article' => array('conditions' => ..., 'contain' => array( ... ));
and then do your normal paginate(), without having to set reset to false nor call resetBindings(). Check the test case for an actual example.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7010 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-22 16:25:10 +00:00
DarkAngelBGE
45bccc5215 optimization refs #3415
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6970 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-19 20:36:39 +00:00
the_undefined
8f4eda68fc Fixed issues with Controller::persistModel and behaviors, closes #4647
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6959 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-19 08:03:00 +00:00
the_undefined
065b8f4281 Made Controller::redirect use Object::stop, fixes #4154
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6947 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-19 05:21:43 +00:00
DarkAngelBGE
d04101a95a refactoring Controller::referer
adding Controller::header() for testability
bring Controller up in code coverage

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6844 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-13 14:22:57 +00:00
phpnut
06d06c85d9 "Fixes #4339, Providing null for variable with underscores leads to camelcased variable in view"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6626 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-02 20:14:06 +00:00
phpnut
57918f4199 "Fixing Controller::output; to allow access to the content in Contorller::afterFilter();"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6554 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-10 13:24:36 +00:00
the_undefined
885b41808f Fixed return value for Controller::setAction
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6508 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-04 23:44:50 +00:00
nate
f3355bd74b Removing all references to deprecated 'webservices' and 'bare' routes and route parameters, removing deprecated constants, updating core tests
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6453 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-02-11 06:18:41 +00:00
nate
377643cf2b Adding deprecation warning to Controller::cleanUpFields()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6413 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-28 01:14:05 +00:00
nate
d9691a19c8 Refactoring Router::mapResources(), adding tests for REST routing and HTTP method overrides
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6409 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-26 08:50:06 +00:00
phpnut
7098c5558c "Fixes #3887, Controller::modelClass incorrect when using AppController::uses"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6384 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-16 18:09:25 +00:00
phpnut
c47700d8c4 "Removing call to Controller::_initComponents(); and Controller::__mergeVars(); out of Dispatcher"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6322 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-05 01:31:15 +00:00
phpnut
cb53dc61b0 "Closes #2897, Built-in file validation.
Implemented Validation::extension(); and Vaidation::range();
Updated copyright notices in all files"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6296 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-01 22:18:17 +00:00
phpnut
1aa2324e8e "Fixes #3786, Missing keys when Model merges actsAs.
Added additional test for Set::merge();
Refactored Controller::_mergeVars."

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6292 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-01 01:07:24 +00:00
phpnut
013133457c "Fixes #3768, Controller loads wrong model when plugins controller has the controller name of a main model.
moved merging of components, helpers, and uses vars to Controller::_mergeVars(); fixes bug with PluginAppController vars not being merged before components are loaded.
  Added call to Controller::_mergeVars(); in Dispatcher::dispatch();"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6291 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-12-31 23:27:14 +00:00
phpnut
6fe54aa1d0 "Reverting 5254, this change is only for 1.2 branch"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6255 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-12-25 09:55:59 +00:00
phpnut
877cf930ad "Fixes #3748, Auto loading model classes fail in plugins when using $uses in the AppController"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6211 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-12-23 06:45:26 +00:00
gwoo
17610a5287 closes #3302, Render is to meant to output and allow the program to continue executing. Redirect generally serves to stop the program and start fresh with something new. This changeset makes exit the default behavior on redirect.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6208 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-12-23 01:17:48 +00:00
gwoo
60f4dd360d updating View and Controller::flash, fixes #3749, tests added
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6177 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-12-20 01:19:19 +00:00
nate
e56b92255f Adding lower bound for page numbers in Controller::paginate() (Ticket #3683)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6133 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-12-08 08:54:27 +00:00
phpnut
8a2b51c3ec "Removing all shortcut function usage from the core"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6128 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-12-08 06:08:03 +00:00
phpnut
13530f42dc "Correcting typo"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6106 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-12-02 23:03:13 +00:00
phpnut
61eebea0f4 "Refactoring Controller::paginate()"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6105 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-12-02 22:58:23 +00:00
nate
00dc6dedb5 Adding fix for Controller::paginate() when default model is loaded from a plugin (Ticket #3660)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6098 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-11-30 22:27:43 +00:00
phpnut
de8e7d8b01 "Closes #1854, Core.po not loaded when using /app/locale/..../default.po
Closes #3539
Fixes #3611, Cannot redeclare loadmodels
Fixes #3622, loadControllers() and loadModels() look in wrong folders for AppController resp. AppModel
Added trigger_error to all deprecated functions in basics.php
Refactored I18n class to remove debug_backtrace() usage in basics.php, all translations should be placed in a default.po or .mo file from this point forward.
_ _d() function should be used if domain specific translations are used.
Core translations can be placed in app/locales/{lang}/LC_MESSAGES/core.po or .mo these will now be merged with the specified language strings from default.po will replace the core message strings
All translations are now cached to improve performance.
"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6065 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-11-23 08:16:23 +00:00
gwoo
c4c6ad1a86 adding check for max pages, fixes #3586
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6041 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-11-22 02:51:21 +00:00
gwoo
d8e206b9f9 updating controller and auth, fixes #3539
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6036 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-11-21 17:37:55 +00:00
phpnut
2c28dcf841 "Refactoring Configure::_ _buildPaths();"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6028 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-11-20 00:39:37 +00:00
phpnut
e110032089 "Updating Controller::render() to use App::import() for loading the view class
Corrected typo in basics.php loadView()"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6027 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-11-19 16:39:14 +00:00
phpnut
c000940e36 Closes #2119 Only define clone() in PHP4 when it hasn't been already defined.
Closes #2213, Support multiple plugin paths.
Closes #2234, filepaths to behavior classes should be cached in class.paths.php also
Closes #2345, ability to group components into subfolders
Closes #2645, Improvement to basic.php for class loading.
Fixes #3526, Cache::write, when using just the config name, it fails.
Fixes #3559, loading plugin model as assoc don't work.
Closes #3567 Controller Folders (Note this does not need routing to work, but controller names can not conflict with others in the same application so naming must still be unique)
Fixes #3579, email.php component: Parse error with php 4.

Adding new class and file importer.
Updated most of the core to use the importer.
Added ClassRegsitry::init() that will create and instance of an object and store it in the registry.
Deprecated most of the load functions in basics.php
Plugin model loading now forces using the dot notation, to use models within a plugin, all the model associations must be in the PluginName.Model syntax, if this is not used, the plugin will look for the models in the main app/models directory first, if not found then it will search the plugin directories recursively until it finds a model.
	var $belongsTo = array('SomeModel'); will look for some_model.php in the app/models
	var $belongsTo = array('MyPlugin.SomeModel'); will look for some_model.php in my_plugin/models
	var $belongsTo = array('MyPlugin.MyPlugin', 'SomeModel'); will used my_plugin/models/my_plugin.php and app/models/some_model.php
	
The controllers of the plugin will still look for the default models inside the plugin if var $uses is not set:
	var $uses = array('SomeModel'); will look for some_model.php in the app/models
	var $uses = array('MyPlugin.SomeModel'); will look for some_model.php in my_plugin/models
	var $uses = array('MyPlugin.MyPlugin', 'SomeModel'); will used my_plugin/models/my_plugin.php and app/models/some_model.php

All of the above will work between plugins and main app
These changes also allow placing model and controllers is sub directories
Removed old class.paths.php file generation 

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6001 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-11-16 09:35:19 +00:00
gwoo
e51455cb17 Adding merge support for PluginAppController properties
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5978 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-11-09 19:56:40 +00:00
gwoo
2edfe3dd53 updating Controller::redirect(), closes #3522, deprecated Controller::cleanUpFields, see Model::deconstruct()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5973 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-11-09 02:34:00 +00:00
mariano.iglesias
490ac83313 Adding more documentation for Controller
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5926 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-10-30 17:21:23 +00:00