Commit graph

297 commits

Author SHA1 Message Date
mark_story
31b07795b2 Fix create() and onsubmit option.
Backporting bug-fix from 2.0

Removing support for onSubmit variant.  Additional
choices are not necessary. Fixing onsubmit option
not correctly working.
Fixes #1977

Conflicts:

	cake/libs/view/helpers/form.php
2011-09-07 21:07:34 -04:00
Jelle Henkens
ae942a7f7b Added tests to test ajax settings 2011-09-07 21:03:48 -04:00
mark_story
ecccfe913b Fixing issue wher times between 12:00 and 12:59 would be incorrectly
marked as am.
Fixes #1851
2011-07-27 20:20:24 -04:00
Mark Story
f3f0363df3 Adding a test for double escaped form urls.
Refs #1748
2011-06-23 14:29:23 -07:00
Juan Basso
6aca8dc11a Updating the copyright to 2011. 2011-05-30 22:46:14 -04:00
mark_story
e53407c595 Fixing issues with tests, and adding another test. Refs GH-57 2011-05-09 22:22:35 -04:00
mark_story
877c874f49 Adding tests for GH-57 2011-05-09 22:17:51 -04:00
mark_story
922595c77a Moving time tests into a separate method. 2011-05-09 22:14:06 -04:00
Juan Basso
2c4ed9bfc2 Fixed the input name when multiple is setted to false. 2011-04-13 00:32:15 -04:00
ADmad
69e5854f0a Applying patch from 'Eärendil' to add option 'hiddenField' for FormHelper::select() for use with 'multiple'=>'checkbox'. Test cases added. Closes #1161 2011-03-21 19:18:53 +05:30
ADmad
0f341c7114 Fixed bug where default class name 'checkbox' was dropped in case of validation error for div wrapping checkbox for multiple checkboxes 2011-03-11 20:20:55 +05:30
mark_story
197c9bf912 Making empty string create empty submit buttons. This applies to both Form->submit() and Form->end(). Tests added. Fixes #1569 2011-03-02 20:27:57 -05:00
mark_story
cf50cbdd9d Fixing issue in FormHelper where CURRENT_TIMESTAMP or other invalid data could cause a notice error. Fixes #1508 2011-02-05 06:43:00 -05:00
mark_story
5464ed8455 Fixing blackholes caused by using custom name attributes with inputs. Fixes #1489 2011-01-27 21:05:30 -05:00
ADmad
d4e4957563 Adding test case for FormHelper::input() for generation multiple checkboxes with space in option values. Refs #1465 2011-01-19 02:25:39 +05:30
mark_story
ca299a097c Fixing issue where get forms created with model = false would create inputs with name = ''. Tests added. Fixes #1455 2011-01-15 14:39:24 -05:00
mark_story
b8780586ec Fixing issue where FormHelper::checkbox() would ignore an explicit checked = false, and use the post data instead. Test case added. Fixes #1437 2011-01-14 21:48:23 -05:00
mark_story
79aafda698 Removing use of serialize() for locked fields. This removes any
possible exploit related to serialize()/unserialize().  Instead values
are passed as | delimited.
2010-11-21 00:09:45 -05:00
mark_story
d56b812181 Fixing issue where an array to string conversion error could occur if you had multiple values for a model's primary key and you created a matching form. Tests added.
Fixes #1257
2010-11-04 21:08:40 -04:00
mark_story
c35ef7dbab Making class attribute bubble down into FormHelper::__selectOption().
Fixes issue where you couldn't change the classname of checkbox options.
Fixes #1202
2010-10-16 13:32:04 -04:00
mark_story
6529e0e2b4 Making optiongroup elements follow the escape parameter.
Tests added.
Fixes #1191
2010-10-13 21:59:53 -04:00
mark_story
3f2109f3c3 Applying patch from 'dragonfly' to fix issue where FormHelper would always append an argument even if one was supplied.
Test Added
Fixes #1155
2010-10-13 21:36:05 -04:00
ADmad
62161203f2 Fixed issue where FormHelper::radio() and FormHelper::select() with option "multiple"=>"checkbox" would generate tag with invalid "id" attribute if a value was non alphanumeric 2010-10-10 23:16:48 +05:30
mark_story
6d7f2d37ab Fixing issue where fields with the exact same name as the model would result in incorrect name attributes. Tests added. Fixes #1123 2010-09-26 00:46:51 -04:00
Mark Story
82fffe6914 Fixing issue where FormHelper::select() with multiple = checkbox and a custom name attribute would not work correctly. Fixes #1078 2010-09-05 01:28:13 -04:00
mark_story
1371cefc3d Applying patch from 'thatcode' to fix an issue where FormHelper::datetime() would not use 'default' or 'value' keys like other inputs would. This corrects an unintentional inconsistency in the methods. Test cases added. Fixes #988 2010-08-09 23:49:18 -04:00
mark_story
f11f9ebc68 Adding test case for #867. 2010-06-28 21:32:49 -04:00
mark_story
50144d6b5b Making FormHelper clear fields on create() as well as end() this ensures that GET forms don't leak fields. Fixes #571 2010-06-12 22:50:09 -04:00
mark_story
f0d755bd8e Adding additional tests for Helper::_parseAttributes() and fixing issue where '1' would not be interpreted as a truthy value for compact attributes. Fixes #806 2010-06-10 19:11:26 -04:00
mark_story
9ee4a12a9d Adding additional tests for FormHelper::input() and checkbox generation and checked attribute being set for truthy values. Close #806 2010-06-10 12:48:55 -04:00
mark_story
e41e89cd2a Making magic select not override magic hidden. Tests added.
Fixes #782
2010-06-04 00:20:14 -04:00
Juan Basso
a94b9ee95b Update various links. Closes #392 2010-05-18 22:15:13 -03:00
predominant
1ec220dac2 Removing closing PHP tags. 2010-05-11 08:07:49 +10:00
José Lorenzo Rodríguez
ad51115e12 Fixing bug where required class would be added to form fields when using single rule syntax in $validate even if allowEmpty is set to true
Closes #654
2010-04-30 16:42:59 -04:30
José Lorenzo Rodríguez
9b040a5ed3 Fixing code formating 2010-04-30 16:07:59 -04:30
ADmad
0471ea046f Adding test case for 'required' class adding to wrapping div based on model validations. Refs #654 2010-05-01 01:19:52 +05:30
José Lorenzo Rodríguez
65f01fa31c Fixing model introspection in FormHelper to better take in account realted models with aliased names 2010-04-22 16:37:15 -04:30
José Lorenzo Rodríguez
e1c4b9696b Adding documentation on 'attributes' key for FormHelper::error 2010-04-19 23:32:58 -04:30
José Lorenzo Rodríguez
23eea00a0b Fixing FormHelper::error to no add error names and messages as html attributes. Fixes #585
This introduces the special key 'attributes' to FormHelper::error() when passed in the second parameter
The contents of said key will be converted into html attributes for the error container tag
2010-04-19 23:25:57 -04:30
José Lorenzo Rodríguez
03e3c3249f Removing whitespace at the end of the file 2010-04-08 22:15:49 -04:30
José Lorenzo Rodríguez
59f7cb47d3 Improving test coverage on FormHelper to show the usage of the 'secure' key for inputs.
Fixing issue with select inputs that does not honor the value of 'secure'
2010-04-08 18:23:07 -04:30
Mark Story
3503872ab8 Fixing Form::dateTime() for GET forms. Tests added. Fixes #522 2010-04-02 15:50:43 -04:00
Mark Story
e304c48ec4 Adding test to show that select() doesn't always auto select options named 'Array'. Disproves #412 2010-03-12 23:17:11 -05:00
Mark Story
1d449e3847 Refactoring label generation into a method.
Fixing issues with labels having a for attribute = Array when an array of id's is provided.
Fixing issues where a date input would require you to provide id keys for hour, minute, and meridian even if you were not using them.
Fixes #411
2010-03-04 22:46:43 -05:00
José Lorenzo Rodríguez
1f1e0f4ff7 Merge commit 'origin/1.3' into 1.3-form 2010-02-27 23:23:43 -04:30
José Lorenzo Rodríguez
b782563daf Adding test for form input templates 2010-02-27 23:18:21 -04:30
José Lorenzo Rodríguez
0ca5c11e6c Making the form helper put the "required" class on all imputs that have a validation rule and does not explicitly sets allowEmpty => true in validation array 2010-02-27 22:58:27 -04:30
Mark Story
3192e130af Fixing magic select creation for fields that have plural variables added to the view. 2010-02-27 11:01:28 -05:00
José Lorenzo Rodríguez
9a4de854d6 Improving the guessing process of required fields in the form helper.
Now it does not rely on the "required" property of the validation array anymore, which was misleading
2010-02-23 09:55:01 -04:30
ADmad
8c1c0e63c0 Allowing a html tag's attribute to be omitted from ouput by setting its value to null or false. Closes #316 2010-02-08 03:00:43 +05:30