Commit graph

968 commits

Author SHA1 Message Date
mark_story
259ecbe9a7 Updating doc blocks on formhelper
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8067 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-28 22:17:56 +00:00
jperras
f2b698a965 Updating Media View to throw a 404 cakeError if the requested file does not exist; thanks 'aidan' for suggested patch. Fixes #6120.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8066 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-27 16:37:37 +00:00
mark_story
af021cb4b2 Adding Html entity conversion to all urls generated by helpers, fixing potential for merged passedArgs to create xss vectors.
Adding integer cast in paginate() to page param. 
Tests added/updated.
Fixes #6134

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8061 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-25 19:51:41 +00:00
gwoo
2849bb0a48 adding check in core home.ctp to throw a 404 when debug == 0
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8060 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-25 19:50:30 +00:00
the_undefined
74bf622866 Fixes #6071
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8053 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-23 15:19:33 +00:00
mark_story
01340e8014 Fixing docblocks in HtmlHelper
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8048 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-18 19:07:15 +00:00
mark_story
42ef8bfbcf Updating doc strings in Javascript helper for better api generation.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8047 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-18 18:26:22 +00:00
mark_story
0beda262d1 Updating doc blocks in FormHelper.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8045 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-18 01:39:01 +00:00
mariano.iglesias
5378c79758 Fixing issue where MediaView doesnt properly force download on IE, fixes #6064
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8040 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-17 18:23:44 +00:00
mark_story
e7c71b4125 Updating doc blocks in helpers. Helps generate cleaner API.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8014 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-03 18:48:28 +00:00
mark_story
2da0c208d5 Fixing Helper::value() when only a fieldname is used. Refactoring Helper::value() to reduce method calls. Added tests to Helper. Fixes #6033
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8012 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-26 19:45:55 +00:00
mark_story
b94a85e938 Altering Helper::url() to enforce escaped query strings for generated urls.
Tests added to Html::link().  Fixes #5982

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7991 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-14 22:41:47 +00:00
TommyO
de1d1ae3bd Fixed asset.timestamp inconsistency for css files.
Added tests to confirm css linking.
Closes #5990. Fixes #5991

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7990 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-14 22:19:11 +00:00
mark_story
287968934f Fixing next()/prev() when paginating multiple models. Added tests from 'hummer'. Fixes #5970
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7989 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-14 22:08:11 +00:00
mark_story
79c791548f Fixing formHelper::hour when specifying a strtotime compatible string for the selected value. Tests added Fixes #5941
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7967 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-30 16:20:38 +00:00
nate
ad208ff8c3 Refactoring previous fix to revert markup changes in HtmlHelper, updating FormHelper tests to comply with coding standard, correcting bad assertions, fixing issue with field types being mis-identified if duplicate names are used, fixes #5919
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7959 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-25 22:13:06 +00:00
gwoo
4f799a7141 closes #5121, updating home.ctp
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7955 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-25 18:02:06 +00:00
nate
61850b1be1 Cleaning up test code formatting, adding fix for POST hash validation of checkbox lists, fixes #5903, test cases added.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7951 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-23 08:13:00 +00:00
mark_story
943bb53dda Correcting callback firing of helpers in view. Tests added fixes #5906
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7948 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-21 22:14:48 +00:00
nate
e2c087f34b Fixing failing tests in JavascriptHelper.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7944 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-19 01:30:02 +00:00
john
a1046de895 Couple of syntax fixes - missing semicolon and usage of empty() inside a conditional.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7933 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-17 18:09:32 +00:00
nate
870c4e87ca Fixing code formatting in JavascriptHelper to wrap at 100 characters, small return-home-early refactoring.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7931 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-17 16:08:31 +00:00
mark_story
9071d8165f Correcting generation of id attributes for radio buttons. Tests added, fixes #5891
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7924 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-17 01:49:58 +00:00
mark_story
b2b4c4be47 Adding App::import() to app_helper files. Fixes issues with Missing Helper Class, and allows you to use helpers in shell classes. Fixes #5458
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7904 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-05 16:49:43 +00:00
gwoo
4dd105d415 fixes #5829, form helper using proper method reference for parseAttributes. A patch would have been nice, but some ticket submitters prefer not to make much effort.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7902 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-01 19:39:40 +00:00
mark_story
c49f213fcf Adding spaces before self close of meta link elements. W3C recommends a space before />. Fixes #5821
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7899 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-30 05:25:37 +00:00
mark_story
090028403b Fixing FormHelper dateTime creation when using custom empty strings and null values. Tests added. Fixes #5769
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7898 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-29 00:28:31 +00:00
phpnut
4cdbd4edd9 Removing unreachable code
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7896 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-27 04:52:45 +00:00
mariano.iglesias
f9557c7611 Fixing issue where radio elements would produce wrong hash when Security component enabled in FormHelper, fixes #5791
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7891 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-25 16:32:54 +00:00
phpnut
69f883a89f Adding $data['attrib'] back to RssHelper::channel(); after more research use cases for this were found.
Related test case added

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7889 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-25 05:54:31 +00:00
mark_story
cfa2229689 Fixing incorrect implementation of RssHelper::channel(). Test cases added.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7887 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-24 23:10:29 +00:00
mark_story
acb9e72355 Minor refactor to helper callback triggering. Moving repeated loops to _triggerHelpers(). Allows View subclasses to add additional callbacks.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7886 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-24 05:36:06 +00:00
mark_story
ace8ef4b5a Applying patch from 'tyler'. Updates Ajax helper to reflect updated scriptaculous API. See http://github.com/madrobby/scriptaculous/wikis/ajax-inplaceeditor. Fixes #5790
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7885 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-24 05:23:31 +00:00
nate
fde0d21053 Cleaning up and finishing code formatting changes in View class.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7854 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-09 03:37:24 +00:00
nate
16eebce7f7 Adding support for DboSource::expression(), plus test in Model case. Fixing code formatting in model test and View class -- wrapping lines at 100 characters.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7853 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-09 03:20:14 +00:00
nate
ab152bd291 Updating AjaxHelper docblocks and fixing code formatting -- lines wrap at 100 characters. Fixes #5701.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7852 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-08 22:15:43 +00:00
mariano.iglesias
e9953e3f93 Fixing issue where JavascriptHelper::link was generating wrong URLs when webroot is defined and appending timestapping. Fixing issue in previous commit. Fixes #5723, fixes #5045
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7851 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-08 12:45:00 +00:00
mariano.iglesias
81e2f4a044 Fixing commit in r7843 so real files are accounted for
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7850 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-08 12:34:51 +00:00
renan.saddam
6319f8ea69 Removed trailing whitespaces from core.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7847 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-08 02:54:07 +00:00
mariano.iglesias
8777b8ef96 Fixing issue where double call to webroot on HtmlHelper::css was generating wrong URLs when forcing asset timestamp, fixes #5723
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7843 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-08 00:24:51 +00:00
mariano.iglesias
8da2a5208f Adding multibyte support to TextHelper::truncate, fixes #5610
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7842 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-08 00:07:17 +00:00
AD7six
3f2fa6929b changing tabs for spaces in comment block indentation
Removing address and replacing with cakefoundation url


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7805 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-30 17:30:26 +00:00
nate
40bf675589 Refactoring DboSource to remove use of str_split, adding $read (false to calls to) DboSource::value() inside DboSource::create(), cleaning up code formatting, fixes #5598, fixes #5682
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7802 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-30 05:03:01 +00:00
renan.saddam
41d82920f5 Fixing issue with rounded values in NumberHelper::toReadableSize. Fixes #5676.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7790 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-29 01:15:59 +00:00
mark_story
97cd2c5aef Committing patch from 'fernyb' to add support for with key in AjaxHelper::autoComplete()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7785 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-26 23:47:00 +00:00
mark_story
5a2db7a5b4 Fixing interaction between Model::_clearCache() and CacheHelper. Cached view files for camelCased controller or underscored URL's were not being cleared. Fixes #5611
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7783 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-26 18:51:38 +00:00
mark_story
2d1483e1e5 Updating formHelper::dateTime() to work correctly with string timestamp values. Closes #5621
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7781 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-26 14:53:06 +00:00
renan.saddam
1c9b1d0d78 Removing unnecessary str_replace call.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7780 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-24 11:25:19 +00:00
AD7six
d8ad330bca correcting quotes which cause "undefined constant cache assumed 'cache'.." error
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7779 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-24 08:03:36 +00:00
renan.saddam
a04af731ab Allowing custom mime types and adding more default mime types. Fixes #4517.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7778 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-24 01:12:09 +00:00