Commit graph

3872 commits

Author SHA1 Message Date
Val Bancer
d5ac7aa0b2 Simplify assertions in tests 2018-11-11 17:00:55 +01:00
Val Bancer
90ddb43632 Fix some PHP 7.3 errors 2018-11-11 16:15:55 +01:00
Humberto Pereira
23e38aeaf0 limiting the regex to consume only words in default value in PostgreSQL after ::
added tests showing the old behavior was broken.
2018-10-18 17:16:29 -04:00
Val Bancer
a7a49c5f8e Fix syntax 2018-09-12 17:32:00 +02:00
mark_story
4aa0df8370 Fix tests to run when database name is not cakephp_test 2018-09-09 13:03:36 -04:00
Val Bancer
c5d78b6302 Remove duplicate connect method from the unit test stub 2018-08-26 01:24:18 +02:00
AlexAlexandru
c44113af66 code style 2018-08-01 21:50:38 +03:00
AlexAlexandru
8c3982b192 fixes #11424 Enchament to email class error message 2018-08-01 20:54:53 +03:00
AlexAlexandru
a58eb706dc added tests 2018-07-19 21:14:18 +03:00
mark_story
7a3b66b238 Fix doc block indentation. 2018-04-03 11:59:39 -04:00
Philippe Gibert
292dc17fc2 Fix #11870 Correct tests expressions for Dbo VirtualFields 2018-03-28 13:49:45 +02:00
Philippe Gibert
98bc995623 fixes #11870 Add DboSource::expression support for Dbo VirtualFields 2018-03-23 17:19:41 +01:00
Mark Sch
68de980972
Merge pull request #11809 from WrDX/WrDX-removing-non-existing-rule
Don't break on removing a non-existing rule
2018-03-14 17:01:46 +01:00
Wouter
b225443166
Test removing a rule on a previously removed field 2018-03-14 11:32:58 +01:00
Kazuki Higashiguchi
0e4a1d76ab test modified getMockForModelSecondaryDatasource 2018-03-10 12:59:10 +09:00
Koji Tanaka
61f608abc7
Fix typo 2018-02-25 16:52:34 +09:00
Mark Story
e0e4a3b0d6
Merge pull request #11643 from chinpei215/2.x-make-mcrypt-optional
[2.x] Make mcrypt optional
2018-02-25 01:57:10 +00:00
chinpei215
a6b0271560 Remove Security::engine()
We disscussed and decided to avoid auto selecting which extension to use.
Instead, call Configure::write('Security.useOpenSsl', true) manually.
2018-02-24 12:17:51 +09:00
Mark Sch
df9c7fd96e
Merge pull request #11616 from cakephp/issue-11186
Fix missing field identifier quoting for COUNT(DISTINCT in SQLServer.
2018-02-05 14:48:22 +01:00
mark_story
5d9a3cb2ba Fix phpcs error. 2018-01-24 21:17:52 -05:00
David Yell
bcae20029c Fixed the PHPCS warnings 2018-01-24 10:33:45 +00:00
David Yell
230066a14b Added a test case for the helper with no params. Relates to #11658 2018-01-24 10:13:56 +00:00
chinpei215
d7ed0339b1 Make mcrypt optional
Now Security::encrypt() and Security::decrypt() works with openssl
if the mcrypt extension is unavailable.
Note that Security::rijndael() doesn't work with openssl.
2018-01-19 23:54:53 +09:00
Koji Tanaka
e1897a8498 Pass PaginatorComponentTest::testPaginateExtraParams() 2018-01-17 23:27:20 +09:00
Koji Tanaka
aa14c68497 Fix some count() Error in PHP 7.2 2018-01-17 03:35:00 +09:00
Koji Tanaka
701519c637 Execute CakeSession::destroy() on a tearDown with implicit use session test 2018-01-16 00:47:34 +09:00
mark_story
45695b6b5c Fix missing field identifier quoting for COUNT(DISTINCT in SQLServer.
Refs #11186
2018-01-09 17:01:00 -05:00
Koji Tanaka
400d45f56c fix code style 2017-12-31 17:05:26 +09:00
Koji Tanaka
74a8611eef [2.x]Fix can't load aliased component on ControllerTestCase 2017-12-31 15:44:05 +09:00
Mark Story
3bf93b7f76
Merge pull request #11526 from cakephp/post-conditions
Make postConditions() less permissive.
2017-12-15 14:36:38 -05:00
mark_story
340059be15 Check model names for bad characters as well. 2017-12-13 00:01:09 -05:00
mark_story
a9618f67f7 Use a permitted list instead of a ban list.
This should be safer as we are more confident on what is coming in.
2017-12-13 00:01:05 -05:00
mark_story
f66dec8a96 Make postConditions() less permissive.
We were notified by `ooooooo_q` that postConditions() is vulnerable to
SQL injection if used without SecurityComponent tampering prevention.

This change attempts to make postConditions() safer by exploding in
unsafe scenarios.
2017-12-10 21:44:47 -05:00
chinpei215
9f65402d2c Fix CakeRequest::referer(true) returning scheme-relative URLs
Backport of #11503 (and #8795)
2017-12-04 21:18:27 +09:00
Mark Story
abec95d3ea
Merge pull request #11469 from db-bogdan/issue11468
fixes #11468 sending user data on basic auth in API environment
2017-11-28 21:52:59 -05:00
chinpei215
4ae9f13dfd Fix 'order' not working with a single expressions 2017-11-29 00:17:57 +09:00
db-bogdan
e824346cca extra fix 2017-11-28 11:43:55 +02:00
db-bogdan
94e06dfeb3 add unit test 2017-11-28 11:31:46 +02:00
chinpei215
19bbb7da17 Simplify CookieComponent::read()
Also, this commit fixes an issue of when the second level key is empty.
Previously, read('foo.0') returned incorrect result.
2017-10-16 21:01:19 +09:00
chinpei215
bbea91090d Fix CookieComponent::delete() not working for deep children 2017-10-16 20:55:00 +09:00
mark_story
e85f489c1f Add test for #11284 2017-10-13 21:55:56 -04:00
Mark Story
fb44035177 Merge pull request #11299 from tenkoma/2.x-fix-cc-number-jcb-pattern
[2.x]Fix Credit card number pattern(JCB) is wrong
2017-10-08 10:09:19 -04:00
Koji Tanaka
7d2d902b57 [2.x]Fix Credit card number pattern(JCB) is wrong 2017-10-08 16:15:10 +09:00
Mark Story
a71cad0420 Merge pull request #11283 from chinpei215/2.x-cookie-component-1
[2.x] Fix fatal error thrown when replacing scalar with array
2017-10-06 16:45:38 -04:00
chinpei215
deac8f9109 Backport #7080, #8233 and #11060 2017-10-06 22:02:37 +09:00
chinpei215
959f45a6c6 Fix fatal error thrown when replacing scalar with array
Refs #11280
2017-10-06 13:43:32 +09:00
Ionut-Mihai Burlacu
31ed2d5dfb Test Case 2017-09-22 11:45:38 +03:00
Ionut-Mihai Burlacu
5540569fcc Test Case 2017-09-22 11:39:39 +03:00
Jeremy Harris
f9f06e68b1
Stacking messages in SessionComponent::setFlash 2017-08-30 10:06:56 -05:00
Jeremy Harris
2e75f12a4f
Fixed SessionHelper not handling stacked messages 2017-08-22 10:06:37 -05:00