Commit graph

23 commits

Author SHA1 Message Date
phpnut
d44a364285 merging all changes done in sandbox for next release into the trunk
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@1057 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-10-03 04:48:00 +00:00
phpnut
3fb93807a9 Merging [920] [922] [929]
[920]
Small bugfix for after condition in AjaxHelper::remoteFunction

[922]
Fixed Ticket #224
Added patch from Ticket #221
Added patch from Ticket #222
Renamed renderMethod() to requestAction() the name fits better since we are really requesting another objects response.
Added a default setting to turn of autoRender for the class you are requesting the action from, 
this will allow you to request an action and use the return how you like, instead of letting the object output the content
directly to the browser if it would normally do so.

[929]
Adding fix for Itcket #225.

Moved code for beforeFilters to first section of Controller::constructClasses().
Removed current implementaion of  beforeFilters. This will be changed to pass
a reference of the object to the filters through a core filters class.
The core filter class will then load the filters and perform all request on the object in the order the
filters are arranged in var $beforeFilters, each beforeFilter needs to be a class that the core filter class will create
an instance of. If one of the filters fails, it will return the object, untouched and not try to process other filters, an 
failed var will be set on the controller.

This will be done before data base is initialized for the current object that is being filtered.

Modifed the requestAction() changes are noted below

        Using inside of a controller.
        Default
        $this->requestAction('/controller/action/argument/');
        Request Object to render output directly
        $this->requestAction('/controller/action/argument/', a('render'));

        Using a helper object to make request inside of a view:
        Default
        $helpername->requestAction('/controller/action/argument/');
        Request Object to render output directly
        $helpername->requestAction('/controller/action/argument/', a('render'));

        Using the View object "$this" in a view to make request:
        $this->requestAction('/controller/action/argument/');
        Request Object to render output directly
        $this->requestAction('/controller/action/argument/', a('render'));




git-svn-id: https://svn.cakephp.org/repo/trunk/cake@930 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-09-21 05:48:09 +00:00
phpnut
5f1d672d5e Some changes to allow calling a method from another controller in the view.
helpers can now use this like a url to get methods return value:
$helpername->renderMethod('/controller/action/param/');
Refactored dispatcher.
Adding bug fix by nate in [894] [896]
Added extra param View::renderMethod()
Fixed bug related to #72, #111, #113, #209
Some of those tickets where closed as duplicates already

git-svn-id: https://svn.cakephp.org/repo/trunk/cake@900 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-09-19 01:16:05 +00:00
phpnut
1a93ab942f merging changes made in sandboxes
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@893 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-09-18 18:58:45 +00:00
phpnut
00aa3c66d2 merging fixes into trunk from [869]
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@870 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-09-17 12:37:05 +00:00
phpnut
29a1ee9043 merging fixes into trunk from [857] [858] [859] [860] [861]
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@862 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-09-17 07:56:32 +00:00
phpnut
1dce095546 merging changes from sandboxes
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@856 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-09-17 02:22:07 +00:00
phpnut
d5ebd2f4b7 merging changes from [692] [693] [697] [699] [701] [704] [706] [707]
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@709 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-08-25 16:40:50 +00:00
phpnut
184e0d06e8 re syncing all sandboxes and updated trunk with all the latest changes
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@634 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-08-22 04:15:57 +00:00
phpnut
fbf4d9ee27 merging code from sandboxes since [430]
preparing for release .0.9.2

git-svn-id: https://svn.cakephp.org/repo/trunk/cake@606 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-08-21 06:49:02 +00:00
phpnut
9d1d0201ec merging from source:whiteboard/sandbox/phpnut/pre_0.9.2 at [404]
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@405 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-21 04:02:32 +00:00
phpnut
6460f6e83f Merging changes from revisions [337] [338] [339] [340] [341]
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@342 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-10 05:08:19 +00:00
phpnut
6ca443861d more cleanup for API docs to be generated without errors
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@323 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 04:16:20 +00:00
phpnut
3500ca272c more cleanup for API docs to be generated without errors
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@322 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 02:59:39 +00:00
phpnut
c9d9cb8287 cleaning up the file headers so API docs can be created properly
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@320 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 02:07:21 +00:00
phpnut
0dd8b55d82 remove debug code left in before commit
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@313 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 01:30:52 +00:00
brego
ec53963d40 Some PHP5 notices.
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@310 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 01:23:27 +00:00
phpnut
8a806d7fc5 going thru trunk and cleaning up the file headers so API docs can be created properly
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@309 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 01:07:14 +00:00
brego
a6e5922d71 Changes in the description of the default page.
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@308 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 00:53:17 +00:00
phpnut
a558a1e922 Form validation working now.
Be sure to review the changes made to the blog tutorial.
Some specific changes to note we pass model names in inputTag().
was: $html->inputTag('title', 40)
now: $html->inputTag('post/title', 40)

Also in the tagErrorMsg() we pass the model name.
was: $html->tagErrorMsg('body', 'Body is required.')
now: $html->tagErrorMsg('post/body', 'Body is required.') 
https://trac.cakephp.org/wiki/Cake/Tutorials/BlogPosts


git-svn-id: https://svn.cakephp.org/repo/trunk/cake@306 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-03 23:54:50 +00:00
phpnut
301731fb1a Corrected the use of View class instance.
It looks like the way you where coding it was to be used as a Singleton.
In Controller::render() I am setting all View() attributed by pass reference.
I do not think it will effect other parts of the system.

You can see why I did this by uncommenting the print_r function in View::render().
Reload url in browser.
Then in Controller::render() remove the & from:
$view->autoRender =& $this->autoRender;
This is the only one that seems to cause array to print.

This may also caused in the Router::connect().
Look at this if you get time.
I noticed that each setting in the conf/routes.php file calls outer::connect();
Tee profiler show this happening 6 times on current install from trunk
Router::parse() is called 2 times.


We really need to get some good unit test in place.

Also speeded things up a little.

Profiler test:

Before changes on default install from trunk

Between:
Total Request Time: 13013.4 Milliseconds
Total Request Time: 13065.84 Milliseconds
28 files

After changes
Between:
Total Request Time: 10230.99 Milliseconds
Total Request Time: 10511.59 Milliseconds
27 files



git-svn-id: https://svn.cakephp.org/repo/trunk/cake@304 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-03 07:07:47 +00:00
phpnut
75cce3f107 Merging changes from Kamil's sandbox.
Beginning refactoring to bring current trunk to a usable release.


git-svn-id: https://svn.cakephp.org/repo/trunk/cake@301 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-02 22:49:04 +00:00
brego
38ddea527e Ok, this one is very big. Firstly, I've outsourced (:]) helper methods like linkTo etc into separate files, located in /libs/helpers/*.
I am not finished with copying methods out of template.php, but it will come - also data validation would not be a problem helpers inclusion happens in the Template::_render().

Also, there was a bug with error functions (as Controller::missingView) - on linux, calling $this->render('../errors/missingController'); rsulted in an error - beacouse apparently is_file() cannot work with '..'. I added a simple fix in Template::_getViewFn.

I've also made some cleanups. Will continue to work tonight.



git-svn-id: https://svn.cakephp.org/repo/trunk/cake@264 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-21 23:44:49 +00:00