Commit graph

8749 commits

Author SHA1 Message Date
mark_story
56292b658c Adding option value validation to ConsoleOptionParser. 2010-10-13 23:18:24 -04:00
mark_story
8b46645f6a Making properties protected. 2010-10-13 23:18:24 -04:00
mark_story
49006b2bbb Adding accessor method. 2010-10-13 23:18:24 -04:00
mark_story
dc9a05d49c Extracting subcommand as a separate object.
This allows the internals of ConsoleOptionParser to be more uniform and consistent.
2010-10-13 23:18:24 -04:00
mark_story
8261581b3b Pulling out some duplicated code into methods. 2010-10-13 23:18:24 -04:00
mark_story
5e8222ef39 Pulling out classes into separate files. 2010-10-13 23:18:24 -04:00
mark_story
2774493577 Refactoring arguments into a separate object. 2010-10-13 23:18:24 -04:00
mark_story
12fba88528 Refactoring options into a separate object.
There are changes that need to be made for boolean and options with choices, and having a separate object will make them much easier to do.
2010-10-13 23:18:24 -04:00
mark_story
27a4f3c0d7 Adding test to make sure tags that are unknown are not removed. 2010-10-13 23:18:24 -04:00
mark_story
ad367fed9a Adding addOptions and addArguments as convience methods for adding multiple options/arguments. 2010-10-13 23:18:24 -04:00
mark_story
72e1a96a9a Renaming a Shell::_getOptionParser -> getOptionParser
Made the method public so subparser help would be easy to wire up. Moving help generation above task invocation so it always displays.
2010-10-13 23:18:23 -04:00
mark_story
ab794b300e Adding support for help generating help for subcommands.
Adding tests for subcommand help generation.
2010-10-13 23:18:23 -04:00
mark_story
3be24d0b0b Adding subcommand docs for i18n shell.
Adding execute checks to shell, this is a temporary fix that stops extra clears being done.
2010-10-13 23:18:23 -04:00
mark_story
fe7c7a1b12 Adding some colour to Shell::createFile()
Removing the now dead Shell::help().  The OptionParser approach provides much better help information than this method did.
2010-10-13 23:18:23 -04:00
mark_story
56339e05f3 Adding subcommand to help output.
Subcommands can be shell methods or tasks.  Both should support additional parsers.  Which is not complete yet.
2010-10-13 23:18:23 -04:00
mark_story
278f699fda Updating extract task. 2010-10-13 23:18:23 -04:00
mark_story
41b8affa82 Updating i18n shell to start using new OptionParser class.
Removing more dead attributes from Shell. Making Shell::$name the name used to invoke the shell, not the classname.  This makes it similar to other objects with names.
2010-10-13 23:18:23 -04:00
mark_story
2a2428a694 Updating ApiShell to use ConsoleOptionParser correctly.
Removing old help method.
2010-10-13 23:18:23 -04:00
mark_story
c0d15a420c Changing name of parser attribute. 2010-10-13 23:18:23 -04:00
mark_story
f1ee46749b Fixing failing tests in Schema shell. 2010-10-13 23:18:23 -04:00
mark_story
193721a0eb Fixing notice errors in ShellDispatcher
Removing ShellDispatcher tests that are now inside Shell.
Changing exception type to match the one used in ShellDispatcher.
2010-10-13 23:18:23 -04:00
mark_story
e70089891d Adding some more array_unshift. These fix issues where tasks would receive their name in the argv which is not correct. 2010-10-13 23:18:22 -04:00
mark_story
79d1739778 Adding tests for task methods in runCommand.
Moving startup() call to the dispatcher so nested runCommand calls don't double output the startup content.
2010-10-13 23:18:22 -04:00
mark_story
cea9dadaa2 Fixing ShellDispatcher::parseParams tests to reflect the changes in what they do.
Adding tests for Shell::runCommand().
2010-10-13 23:18:22 -04:00
mark_story
3d351e7760 Dramatically changing how ShellDispatcher and Shell interact.
Shell::runCommand is now responsible for delegating out to tasks and correctly checking methods to run.  ShellDispatcher no longer parses parameters and instead only pulls out the path information that it needs to setup the environment.
2010-10-13 23:18:22 -04:00
mark_story
cd18c8214c Adding Shell::hasMethod and tests for it. 2010-10-13 23:18:22 -04:00
mark_story
18c5a62445 Removing a dead test and adding tests for hasTask 2010-10-13 23:18:22 -04:00
mark_story
830238c2dd Removing $this->AppModel from shells.
Having a partially constructed model in the shell is not useful, and
gives the impression that it will work correctly. Which it doesn't.
2010-10-13 23:18:22 -04:00
mark_story
fbcc9c1fc1 Making Tasks lazy load.
This allows task initialization to be moved out of ShellDispatcher where it does not belong, as tasks are similar to components.  Updating parts of TaskCollection, as the Dispatcher is still required to be passed around.
2010-10-13 23:18:22 -04:00
mark_story
4d199cf8a8 Removing Shell::_loadDbConfig() and Shell::$DbConfig
They did not make sense in Shell as no other core shells even use these
properties/methods.
2010-10-13 23:18:22 -04:00
mark_story
0d522f3bd4 Changing ShellDispatcher to use --help and -h like the option parser does. 2010-10-13 23:18:22 -04:00
mark_story
7f5b5c4fbd Adding exception for unknown option usage. 2010-10-13 23:18:21 -04:00
mark_story
d3c95bc2c4 Adding epilog and description to the generate help. 2010-10-13 23:18:21 -04:00
mark_story
501e63e45d Adding argument help generation in the long help and usage string.
Fixing output of option help, formatting was calculated in 2 places.
2010-10-13 23:18:21 -04:00
mark_story
09adc38b6c Doing some fixes as the longest option + a short would cause incorrect formatting. 2010-10-13 23:18:21 -04:00
mark_story
0eb68226ce Adding ConsoleOptionParser to the AllShells test. 2010-10-13 23:18:21 -04:00
mark_story
733394d584 Adding usage generation for options. 2010-10-13 23:18:21 -04:00
mark_story
cea6cef727 Adding smart defaults for verbose, quiet, and help options.
Adding help formatting for options.
2010-10-13 23:18:21 -04:00
mark_story
a3259743f7 Making error output style have an underline.
Adding a comment style which has blue text.
2010-10-13 23:18:21 -04:00
mark_story
f5ad54e97e Adding required argument checking. 2010-10-13 23:18:21 -04:00
mark_story
505e59ac66 Adding support for boolean options. 2010-10-13 23:18:21 -04:00
mark_story
3e402e2dfb Adding support for positional arguments.
Adding tests and support for positional arguments. Renaming description
key to help as its shorter.
2010-10-13 23:18:21 -04:00
mark_story
6f1dae208c Adding method skeleton 2010-10-13 23:18:21 -04:00
mark_story
b392f300ba Adding docs about how options work. 2010-10-13 23:18:20 -04:00
mark_story
3b9921a390 Adding support for -abc style combination of short options.
Renaming shortcut to short as its shorter :)
2010-10-13 23:18:20 -04:00
mark_story
01a7fc70b7 Removing dead code. 2010-10-13 23:18:20 -04:00
mark_story
07bda824f0 Adding test for parsing multiple options. 2010-10-13 23:18:20 -04:00
mark_story
2c2c9a38d2 Removing required, and type from option flag as they didn't really make sense to include at this point. Adding support for --foo=bar type parameters. 2010-10-13 23:18:20 -04:00
mark_story
7b1b835bc1 Adding very basic implementation for parsing long and short options. 2010-10-13 23:18:20 -04:00
mark_story
d5d9adb92b Starting to implement options and option parsing. 2010-10-13 23:18:20 -04:00
mark_story
694537933e Adding description() and epilog() to ConsoleOptionParser. Starting to build out addOption. 2010-10-13 23:18:20 -04:00
mark_story
d914c0aaea Adding ConsoleOptionParser and its test. 2010-10-13 23:18:20 -04:00
mark_story
41db1485aa Updating test cases to use new objects.
Preventing ConsoleOutput and ConsoleInput constructors from being run as it causes too many files open exceptions.
2010-10-13 23:18:20 -04:00
mark_story
73ad3043a2 Fixing more console tests to use new internals.
Making TaskCollection pass the stdout, stdin, stderr to Tasks they create.  This allows for more flexible dependency injection and makes testing easier.
2010-10-13 23:18:20 -04:00
mark_story
a3023430c8 Updating test cases to use new Shell internals.
Cleaning up some mocks.
2010-10-13 23:18:19 -04:00
mark_story
7921ef1282 Fixing Shell tests to use ConsoleInput. 2010-10-13 23:18:19 -04:00
mark_story
e816a49a6f Moving ShellDispatcher::getInput() into Shell as a protected method. 2010-10-13 23:18:19 -04:00
mark_story
67f03afa02 Moving ConsoleInput to the correct directory. 2010-10-13 23:18:19 -04:00
mark_story
d64078db2d Adding ConsoleInput for reading stdin. 2010-10-13 23:18:19 -04:00
mark_story
cd8d29ef1c Removing conceal, because its a stupid option. 2010-10-13 23:18:19 -04:00
mark_story
76c6decb52 Updating tests for Shell so they pass with the changes in the Shell internals. 2010-10-13 23:18:19 -04:00
mark_story
131433739e Removing dead test stubs and test methods.
Moving clear() into Shell, it should be a shell method.
Changing shell methods to use ConsoleOutput objects, instead of methods on Dispatcher.
2010-10-13 23:18:19 -04:00
mark_story
a55098b00b Making TaskCollection require a Shell instead of a ShellDispatcher.
This will help reduce the coupling between ShellDispatcher and other objects.
Since ShellDispatcher never directly uses or interacts with TaskCollection, it doesn't make much sense for it to have one.  Instead shells will either get their own, or be passed one in.
2010-10-13 23:18:19 -04:00
mark_story
b6602f1d0d Converting more stderr() use into exceptions. 2010-10-13 23:18:19 -04:00
mark_story
749e9c19d5 Adding success style.
Adding some additional formatting to the default welcome method.
2010-10-13 23:18:19 -04:00
mark_story
b11f2bfb1f Adding ConsoleOutput to the AllShells group. 2010-10-13 23:18:18 -04:00
mark_story
9a6b04d5b3 Removing double header output and adding some pizazz to the command list. 2010-10-13 23:18:18 -04:00
mark_story
7719df72c2 Removing code from ShellDispatcher that is now in CommandList. 2010-10-13 23:18:18 -04:00
mark_story
02c4e00556 Starting to move command list out to a separate class so ShellDispatcher can stop having stderr/stdout connections. 2010-10-13 23:18:18 -04:00
mark_story
317e32f07b Making ShellDispatcher use exceptions instead of returning false and doing other goofy things.
Adding MissingShellMethodException, MissingShellClassException and MissingShellFileException for use with ShellDispatcher.
Removing duplicated tests, and refactoring them into separate tests with expected exceptions.
2010-10-13 23:18:18 -04:00
mark_story
ffbb4e6b45 Integrating ConsoleOutput with ConsoleErrorHandler.
Updating test cases to match new output.
2010-10-13 23:18:18 -04:00
mark_story
ce4fe64a61 Initial integration of ConsoleOutput into cake console tools. 2010-10-13 23:18:18 -04:00
mark_story
5c55c289f7 Adding support for uncoloured output for windows environments without
ansicon.
2010-10-13 23:18:18 -04:00
mark_story
90d5c12b3e Fixing issues with background colours, and adding tests for options. 2010-10-13 23:18:18 -04:00
mark_story
d5b5fbee3b Adding formatting methods for coloured output. 2010-10-13 23:18:18 -04:00
mark_story
aec1770abc Adding style format manipulation methods. 2010-10-13 23:18:18 -04:00
mark_story
7dea9b0dbd Starting to refactor console output into ConsoleOutput. 2010-10-13 23:18:18 -04:00
mark_story
3d65b68f1d Renaming cake.test
Updating AllShells suite.
2010-10-13 23:18:17 -04:00
mark_story
9b8ce2d7fa Updating includes for shell + task includes to point at the new file. 2010-10-13 23:18:17 -04:00
mark_story
0a86b7f208 Moving the ShellDispatcher into is own file. This makes testing easier and will make app/console easier to create. 2010-10-13 23:18:17 -04:00
mark_story
079c55656b Updating doc block for console error handler. 2010-10-13 23:18:17 -04:00
mark_story
517c8949f9 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2010-10-13 23:17:50 -04:00
mark_story
0c070f7131 Fixing tests that were failing due to SimpleTest being less sensitive to types than PHPUnit.
Fixing tests that were failing due to XmlHelper being removed in 2.0.
2010-10-13 23:09:55 -04:00
mark_story
f19e3d501c Merge branch '1.3' into integration
Conflicts:
	cake/libs/model/cake_schema.php
	cake/libs/model/datasources/dbo_source.php
	cake/libs/model/model.php
	cake/libs/view/helpers/form.php
	cake/libs/view/view.php
	cake/libs/xml.php
	cake/tests/cases/libs/model/model_delete.test.php
	cake/tests/cases/libs/view/view.test.php
	cake/tests/cases/libs/xml.test.php
2010-10-13 22:30:40 -04:00
mark_story
6529e0e2b4 Making optiongroup elements follow the escape parameter.
Tests added.
Fixes #1191
2010-10-13 21:59:53 -04:00
mark_story
3f2109f3c3 Applying patch from 'dragonfly' to fix issue where FormHelper would always append an argument even if one was supplied.
Test Added
Fixes #1155
2010-10-13 21:36:05 -04:00
Jeremy Harris
692aafbf42 Merge remote branch 'upstream/2.0' into 2.0 2010-10-11 20:12:24 -07:00
mark_story
a0a84d1a8d Changing pattern used to read digest auth data. Allows emails to be used as usernames.
This also adds the realm to the return value of SecurityComponent::parseDigestAuth().  Fixes #1181
2010-10-11 22:35:47 -04:00
Jeremy Harris
137c4f7295 Added backwards compatibility to h()'s second param 2010-10-11 19:26:41 -07:00
mark_story
d56416456c Applying patch from 'Justas Butkus' to DboSource
Fixes issues where reconnect could issue warnings related to
array_merge.  Fixes #1182
2010-10-11 21:52:10 -04:00
Jeremy Harris
b58899cf04 Added 'double' option to Santize::html() to pass double_encode parameter to htmlentities() 2010-10-11 18:25:11 -07:00
Jeremy Harris
c686362de8 Added double_encode paramater to h() 2010-10-11 18:23:05 -07:00
Juan Basso
c95c808f88 Merge with 2.0-xml 2010-10-10 23:21:56 -03:00
ADmad
62161203f2 Fixed issue where FormHelper::radio() and FormHelper::select() with option "multiple"=>"checkbox" would generate tag with invalid "id" attribute if a value was non alphanumeric 2010-10-10 23:16:48 +05:30
Phally
0d86302404 Fixed issue with Set::extract() where conditions containing a space and a slash would fail. Fixes #1185
Signed-off-by: mark_story <mark@mark-story.com>
2010-10-08 23:28:23 -04:00
Phally
0e5613f63d Fixed Set::extract() where single numeric keys (everything not 0) were skipped. Fixes #1175
Signed-off-by: mark_story <mark@mark-story.com>
2010-10-07 20:33:31 -04:00
José Lorenzo Rodríguez
5c025d0a18 More testing over the MediaView class 2010-10-03 23:30:47 -04:30
José Lorenzo Rodríguez
9daab17374 Improving test case for MediaView class 2010-10-03 23:30:02 -04:30
José Lorenzo Rodríguez
018def81f4 Cleaning up the MediaView class 2010-10-03 23:27:22 -04:30
José Lorenzo Rodríguez
a611fd0e6c Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2010-10-03 19:36:24 -04:30
José Lorenzo Rodríguez
bdade0fe08 Adding the ability to compress the response sent from the MeviaView class 2010-10-03 19:35:48 -04:30
José Lorenzo Rodríguez
cf48ee7ed5 Refactoring MediaView to fully use the response object
Improved the way cache headers are sent for delivered files, now it is possible to set cache for files marked for download
2010-10-03 19:34:37 -04:30
José Lorenzo Rodríguez
bf22928b6a Improving the CakeResponse::cache() method 2010-10-03 19:27:08 -04:30
José Lorenzo Rodríguez
d117300518 Improving feedback for developer in case media view does not find the specified file 2010-10-03 19:05:23 -04:30
José Lorenzo Rodríguez
0ba5023f3a Updating testcase and fixing small bug in last commit 2010-10-03 16:48:07 -04:30
José Lorenzo Rodríguez
6f5ce8a81d Refactoring media view to start using the response object, improving CakeResponse::cache() 2010-10-03 16:40:54 -04:30
mark_story
f847080cbf Changing more php version strings. 2010-10-03 12:46:03 -04:00
mark_story
3ab77017ae Fixing OpenTest license mentions to use MIT License
Fixing PHP versions 4 and 5 to only be PHP5.
2010-10-03 12:31:21 -04:00
mark_story
b908365f9d Changing the @license tag on test files, as tests can now be MIT like
the rest of CakePHP.
2010-10-03 12:27:27 -04:00
mark_story
6cabfcec5b Removing dead tests from SessionHelper test case. 2010-10-03 12:15:01 -04:00
mark_story
36737e6419 Adding documentation for new xml options. Adding a default setting to fix all the E_NOTICE errors triggered in [503b7cf5d7]
Fixes #284
2010-10-02 19:20:43 -04:00
teknoid
503b7cf5d7 Adding slug option to avoid auto-slug of tags. Test included. Addresses #284
Signed-off-by: mark_story <mark@mark-story.com>
2010-10-02 19:16:07 -04:00
mark_story
d83c51cde9 Fixing expiration conditions on CSRF tokens. 2010-10-02 18:27:39 -04:00
mark_story
7f7c202f35 Removing old CSRF token validation checks.
Removing failing test because the feature moved.
Adding tests for expired and wrong keys.
2010-10-02 17:16:40 -04:00
mark_story
ac90916b84 Adding some documentation about token consumption. 2010-10-02 00:22:44 -04:00
mark_story
a10f1478ee Adding support for nonce expiry.
Adding simple time based nonce expiration. This does a simple cleanup on
each request, to remove stale tokens.  Tests added.
2010-10-02 00:20:58 -04:00
mark_story
5c27abd35f Applying patch from 'hashmich' to make jQueryEngine not override the success callback. This allows you to provide a success callback and still get the html insertion when used with the update key.
Tests updated.
Fixes #1158
2010-10-01 22:43:46 -04:00
mark_story
711e736cd3 Adding very minimal and incomplete implementation of csrf consumption.
Tests added for consuming csrf tokens on each request.
2010-10-01 00:13:34 -04:00
mark_story
5e26d282a1 Fixing connection specific schema generation
Fixing missing table errors when reading schema for specific connections.
Tests updated to check that tables not on a connection are never touched.  Fixes #1106
2010-09-30 23:22:57 -04:00
mark_story
d83907a77d Changing order of conditions, to put cheaper ones first.
Also fixes issues on safe_mode servers.
Fixes #1164
2010-09-30 23:03:23 -04:00
mark_story
dc6b33f80e Making tokens persist across 'requests'.
Removing more serialize/unserialize calls.
2010-09-30 00:26:44 -04:00
mark_story
f5ed91137a Adding csrfCheck related properties.
nonces are now being populated into the session.
2010-09-30 00:18:25 -04:00
mark_story
b088daf045 Adding tests for csrf feature separation.
Removing serialize() calls as they didn't really add anything.
2010-09-30 00:06:38 -04:00
mark_story
c573fd0432 Fixing issue where a beforeDelete() could trigger a table truncation.
Moving the exists check below beforeDelete() and behavior->beforeDelete() so any records deleted in the callbacks will not exist when db->delete() is called.  Test updated. Fixes #250
2010-09-29 23:31:41 -04:00
evilbloodydemon
38e128b597 test for #250
Signed-off-by: mark_story <mark@mark-story.com>
2010-09-29 23:06:47 -04:00
mark_story
72a1c959a1 Adding CakeSession::clear() which is primarily useful when testing, and offers an alternative to using CakeSession::destroy() 2010-09-29 23:01:23 -04:00
mark_story
597058bab5 Reordering tests in AllRouting case.
Changing how output buffers are emptied, so that its only done in cli.
2010-09-29 22:42:01 -04:00
José Lorenzo Rodríguez
cff2864ba5 Fixing testcase 2010-09-29 01:14:44 -04:30
José Lorenzo Rodríguez
9d35ea0cbc Upgrading CodeCoverage repoting fo phpunit 3.5 2010-09-29 01:14:14 -04:30
mark_story
b08aba8e86 Adding a missing rollback when validation on an associated record fails, and validate = first. Fixes #1147 2010-09-28 23:37:28 -04:00
mark_story
0761edecfb Making the cake:nocache stripping more relaxed so that if either condition to enable caching is on, tags will be stripped. Tests added. Fixes #1148 2010-09-28 23:03:56 -04:00
mark_story
9992cff96c Adding another test for #250. 2010-09-28 22:26:54 -04:00
José Lorenzo Rodríguez
45a407783e Updating options help 2010-09-28 21:11:43 -04:30
José Lorenzo Rodríguez
4445c24008 Merge remote branch 'origin/2.0' into 2.0-phpunit-upgrade 2010-09-28 20:56:44 -04:30
José Lorenzo Rodríguez
f2b51d2375 Fixing parse error 2010-09-27 23:41:11 -04:30
José Lorenzo Rodríguez
87d5a791c6 Fixing helper tests 2010-09-27 23:40:57 -04:30
José Lorenzo Rodríguez
c3ccf15546 Replacing the use of removed "sharedFixture" and adding custom "fixtureManager" property to CakeTestCase 2010-09-27 23:37:56 -04:30
mark_story
3a14f780b9 Moving parent call to fix fatal errors caused by registry being empty. 2010-09-28 00:03:23 -04:00
José Lorenzo Rodríguez
0eaf437fe4 Merge remote branch 'origin/2.0' into 2.0-phpunit-upgrade 2010-09-27 23:19:47 -04:30
José Lorenzo Rodríguez
2635733aba Merge branch '2.0' into 2.0-phpunit-upgrade 2010-09-27 22:42:10 -04:30
José Lorenzo Rodríguez
ba168d1a72 Initial steps towards migrating to phpunit 3.5 2010-09-27 22:37:23 -04:30
mark_story
500550faef Adding documentation note about AclShell and issues with zend.ze1_compatibilty. Fixes #987 2010-09-26 12:33:15 -04:00
mark_story
06ed3a96a7 Moving the plugin import tests to a separate method.
Adding tests for importing a pluginAppHelper.
Closes #1111
2010-09-26 12:30:12 -04:00
mark_story
0990728385 Adding tests for non latin domains to MemcacheEngine. Closes #1143 2010-09-26 12:04:06 -04:00
mark_story
995a14c140 Making MemcacheEngine understand IPv6 addresses. Fixes #1143 2010-09-26 01:11:19 -04:00
mark_story
6d7f2d37ab Fixing issue where fields with the exact same name as the model would result in incorrect name attributes. Tests added. Fixes #1123 2010-09-26 00:46:51 -04:00
mark_story
237b66d193 Adding support for httpOnly cookies to CookieComponent. Fixes #1127 2010-09-25 23:24:37 -04:00
mark_story
3395f4221e Adding Inflector::reset(). This makes non-isolated test runs possible. Adding inflector to the libs suite. 2010-09-25 23:04:49 -04:00
mark_story
63d23df77a Merge branch 'setup-teardown' into all-tests 2010-09-25 22:34:20 -04:00
mark_story
0222717e33 Merge branch 'all-tests' of github.com:markstory/cakephp into all-tests 2010-09-25 22:34:10 -04:00
mark_story
54fa2e3742 Uncommenting model group in all tests. 2010-09-25 22:33:23 -04:00
José Lorenzo Rodríguez
27dfe2d521 Adding all_model suite to the all_tests one 2010-09-25 22:00:30 -04:30
mark_story
2b1bc99eb5 Fixing failing tests in auth and scaffold.
Fixing more tests that had stray buffers.
2010-09-25 22:27:31 -04:00
José Lorenzo Rodríguez
18b38f61e0 Fixing CakeTestFixture import feature 2010-09-25 21:53:48 -04:30
mark_story
92b57d81ee Moving common setup and teardown functionality in to CakeTestCase.
Removing repeated setup/teardown logic from test cases.
Switching tests to use setup/teardown instead of startTest/endTest.
2010-09-25 21:36:49 -04:00
José Lorenzo Rodríguez
5538529c41 Fixing some issues with tables that were not beign droppend at the end of test suite execution 2010-09-25 19:15:26 -04:30
mark_story
24dd0af601 Adding debug backup for view test. 2010-09-25 10:50:35 -04:00
mark_story
f60a7fb854 Adding all libs to the all tests. 2010-09-25 10:42:20 -04:00
mark_story
843ada240a Removing AppController from ErrorHandler test as it can make testing harder.
Removing broken buffering from tests that trigger errors / exceptions.
Adding a loadHelper() to the test_app layout so the layout always has the required helper.
2010-09-25 10:41:08 -04:00
mark_story
714d8298c4 Fixing all tasks include.
Removing drop table queries that cause other tests to fail.
2010-09-25 01:25:42 -04:00
mark_story
26057c59c4 Fixing issue in DboSource test case where buffer would eat all the output.
Removing dead tests from TestManager test.
2010-09-25 01:13:01 -04:00
mark_story
cd7bc3ff6b Removing disabling of tests from last commit.
Using assertContains instead of assertPattern as its easier to read.
2010-09-25 00:56:46 -04:00
mark_story
d8b39a3818 Changing startTest and endTest to setup and teardown.
Adding an App::build() to reset paths.
2010-09-25 00:47:32 -04:00
mark_story
d7b5e12b85 Removing methods from TestManager and putting them into CakeTestSuite. 2010-09-25 00:16:28 -04:00
mark_story
8e6277c9d1 Updating schema shell test so it doesn't fail in groups.
Updating suites to use new method.
2010-09-25 00:13:37 -04:00
mark_story
6124eb6f7a Moving All Tasks suite. 2010-09-25 00:13:06 -04:00
mark_story
d7b958f55d Starting to move test suite manipulation methods into CakeTestSuite. 2010-09-25 00:00:08 -04:00
mark_story
ca167d5da2 Changing schema test to not alter the table and break other tests. 2010-09-24 23:30:03 -04:00
mark_story
5c94bdd028 Fixing failing tests in group context caused by state being stuck in static objects. 2010-09-24 23:30:02 -04:00
mark_story
3e6b65557b removing old file. 2010-09-24 23:30:02 -04:00
mark_story
4e5ebc5c0f Renaming all bake tasks to all tasks.
Updating all tests.
2010-09-24 23:30:02 -04:00
mark_story
94d738e834 Fixing failing tests and group test situational fails in console tests. Adding console tests to all tests. 2010-09-24 23:30:02 -04:00
mark_story
0bb23095f3 Making schema shell test more robust by deleting files it makes in teardown(). 2010-09-24 23:30:02 -04:00
mark_story
309d08d4ef Mocking out clear() on all the shell tests as it wreaks havoc on the CLI runner. 2010-09-24 23:30:02 -04:00
mark_story
6974a8752f Removing a test that used eval(). It caused issues in group tests. 2010-09-24 23:30:02 -04:00
mark_story
12d0bdd2ee Adding a missing require to make tests run in cli.
Adding test_suite suite to all tests as it now runs.
2010-09-24 23:30:02 -04:00
mark_story
460a8bc4f6 test_suite suite now runs. Still has a few failing tests from the fixture test case. 2010-09-24 23:30:02 -04:00
mark_story
32dc4aac7b Fixing usage of mb_internal_encoding so it doesn't bone group tests. 2010-09-24 23:30:02 -04:00
José Lorenzo Rodríguez
d45788e14f Changing order of test run in AllShells group to avoid errors 2010-09-24 23:30:02 -04:00
José Lorenzo Rodríguez
5c3b4cfcc4 Removing all uses of the test_suite connection in the test cases 2010-09-24 23:30:01 -04:00
José Lorenzo Rodríguez
9d2e4b1b04 Start removal of magin "test_suite" connection 2010-09-24 23:30:01 -04:00
José Lorenzo Rodríguez
e89860e079 Skiping memcache test if Memcache is not installed 2010-09-24 23:30:01 -04:00
mark_story
53086635b3 Adding CakeRequest and CakeResponse to the routing group.
Making more tests not fail in cli.
2010-09-24 23:30:01 -04:00
José Lorenzo Rodríguez
0a1bc06843 Skiping ApcCache test if APC is not installed 2010-09-24 23:30:01 -04:00
mark_story
b52f78297f Removing dependencies on AppController because it can be a bit crazy.
Uncommenting more groups from the AllTests.
2010-09-24 23:30:01 -04:00
mark_story
e6824e6a41 Fixing duplicate class names. 2010-09-24 23:30:01 -04:00
mark_story
608ea6df42 Making the console define a FULL_BASE_URL so tests run properly. 2010-09-24 23:30:01 -04:00
mark_story
973841a264 Fixing issues in tests that caused group test to fail, and removing duplicate environment backup. 2010-09-24 23:30:01 -04:00
mark_story
d64bd2a82c Making cookie component not send gobs of headers when being tested.
Making test case pass in cli.
2010-09-24 23:30:01 -04:00
mark_story
b59033687d Making private properties and methods protected so they can be manipulated with mocks. 2010-09-24 23:30:00 -04:00
mark_story
c5a47d4daa Clearing referrer more thoroughly. 2010-09-24 23:30:00 -04:00
mark_story
03d99d43be Fixing unbalanced ob_start().
Removing dead code.
2010-09-24 23:30:00 -04:00
mark_story
92ed1e76da Fixing file included in all_models.
Adding skip as tests fail when classes already exist.
Fixing skip condition to use newer api.
2010-09-24 23:30:00 -04:00
mark_story
78c838bcdd Fixing failing tests caused by fixture data changes. 2010-09-24 23:30:00 -04:00
mark_story
2385747899 Some more fixes to make tests run better under all tests. 2010-09-24 23:28:49 -04:00
mark_story
76ef390d4a Updating CakeSchema test case to run in suites. It did not account for additional tables being in the database when it ran. 2010-09-24 23:28:48 -04:00
mark_story
7202a5e398 Starting something that will hopefully become a real All Tests. 2010-09-24 23:28:48 -04:00
mark_story
326ae9755f Updating debugger and error_handler tests to remove errors in CLI. 2010-09-24 23:28:48 -04:00
mark_story
98d1272374 Some fixes to make the test more reliable. 2010-09-24 23:28:48 -04:00
mark_story
d0028bf971 Fixing issue in HtmlHelper test where test files would be left behind. 2010-09-24 23:28:48 -04:00
mark_story
c9a6eba000 Fixing scaffold test so all_controllers suite runs in cli. 2010-09-24 23:28:48 -04:00
mark_story
d6b747cb25 Updating Dispatcher test to run correctly in CLI. 2010-09-24 23:28:48 -04:00
mark_story
cdda1bfb17 Correcting comment. 2010-09-24 23:28:48 -04:00
mark_story
f21161ef46 Merge branch '1.3' into 2.0. Had to fix a number of 1.3 -> 2.0
differences upon merging.

Conflicts:
	app/config/core.php
	cake/console/templates/skel/config/core.php
	cake/libs/cache/file.php
	cake/libs/cake_session.php
	cake/libs/controller/components/email.php
	cake/libs/i18n.php
	cake/libs/view/pages/home.ctp
	cake/tests/cases/libs/cache/memcache.test.php
	cake/tests/cases/libs/model/model_write.test.php
2010-09-24 23:27:22 -04:00
mark_story
a4746c7227 Applying patch from 'kworr' to reorder the switch in DboPostgres::value() to fix issues with pgsql 9.0. Fixes #1139 2010-09-24 22:47:18 -04:00
mark_story
8cd266c77f Correcting example in doc block. Fixes #1132 2010-09-24 22:23:24 -04:00
mark_story
9e4c890082 Updating the schema command in the core.php files to reflect the correct command needed for 1.3. Fixes #1031 2010-09-23 23:12:20 -04:00
ADmad
e161b41e3c CakeSession::__write() now correctly uses the Session model's primaryKey instead of hardcoded fieldname "id". Fixed #1129 2010-09-23 14:00:59 +05:30
mark_story
7e4f9c4953 Merge branch '1.3' of github.com:cakephp/cakephp into 1.3 2010-09-21 21:14:23 -04:00
mark_story
ce1115b0b4 Adding I18n::clear() to remove most of the private variable access from the i18n test case.
Changing casing of classname in test case.
2010-09-21 21:13:45 -04:00
0x20h
2eac24c31a removed destructor, caching is done on file loading (fixes and improves #1085)
Signed-off-by: mark_story <mark@mark-story.com>
2010-09-21 21:03:36 -04:00
0x20h
ba8280423d * changed indexing order of the i18n __domains array to allow caching by domain+language (fixes #1085)
* adapted testcase

Signed-off-by: mark_story <mark@mark-story.com>
2010-09-21 21:03:29 -04:00
mark_story
729a45703b Fixing issue where table names with spaces would not be quoted by name(). Fixes #1121 2010-09-21 20:34:27 -04:00
ADmad
b9a7b27ba1 Fixing regression cased by commit d5ffdc288d causing ajax layout to be not auto set for ajax request for html pages. Refs #1099 2010-09-21 00:25:17 +05:30
mark_story
b648b61422 Merge branch '1.3' of github.com:cakephp/cakephp into 1.3 2010-09-19 18:32:07 -04:00
mark_story
c3d5c3fd00 Fixing issue in Cache where duration = 0 would not read/write from cache. This prevented the creation of non expiring cache entries in APC and memcache.
Adding a return false to FileEngine as it was omitted in the past.
Fixes #1120
2010-09-19 12:20:07 -04:00
ADmad
e10d634f91 Mails sent using php's "mail()" function now have header fields terminated by CRLF and body too contains CR and LF only as combination CRLF in compliannce with RFC 2822. Closes #1071 2010-09-19 03:54:32 +05:30
mark_story
443e523313 Adding tests for clearing the cache with memcache. 2010-09-18 13:15:37 -04:00
mark_story
7518d0e804 Removing dead code in Cache.
Adding tests for ApcEngine::clear().
2010-09-18 12:52:08 -04:00
mark_story
b6d845adc4 Updating calls of Cache::set() inside Cache. Updating the documentation for set() so it better explains how the temporary settings work.
Updating APC and Memcache engine tests to reflect the lack of state being stored inside Cache.
2010-09-18 12:32:43 -04:00
mark_story
5e725e62ca Making MemcacheEngine match the interface. 2010-09-18 11:11:51 -04:00
mark_story
b432e60971 Making Cache::set() work with 2 or 3 parameters. Test cases added. 2010-09-18 11:11:28 -04:00
mark_story
1eb746bf7e Fixing fatal error caused by missing argument. 2010-09-18 11:10:35 -04:00
ADmad
d5ffdc288d Including RequestHandler in controller now automatically sends proper content-type and encoding headers for html pages too like it does for other known file types. Closes #1099 2010-09-18 20:20:52 +05:30
mark_story
9ccbe5e269 Removing unnecessary call to config(). 2010-09-18 00:46:26 -04:00
mark_story
dc65f2306b Making Cache methods always need a config name. This allows the removal of hidden and often confusing state that gets remembered by Cache each time config() is called. Removing the hidden state makes Cache more predictable. 2010-09-18 00:45:29 -04:00
Joe Beeson
b9163b95fe Added a warning that will appear on the homepage to alert users that
their PCRE installation doesn't have Unicode support which can cause a
whole mess of trouble if gone unnoticed. The warning will only display
if their system doesn't have support, not if it does. Fixes #1113

Signed-off-by: mark_story <mark@mark-story.com>
2010-09-18 00:17:51 -04:00
mark_story
e91fa68f8e Making the set() functions use + instead of array_merge() so that numeric indices are properly preserved across multiple method calls. Fixes #1105 2010-09-18 00:13:03 -04:00
mark_story
d113d7d612 Removing dead code from DboSource::fields()
Updating fields() to use implode, so complex virtual fields are better handled.  Fixes #1079
2010-09-18 00:04:36 -04:00
mark_story
738d92cc3e Fixing failing tests caused by fixture data changes. 2010-09-18 00:03:22 -04:00
mark_story
5a8648cca0 Fixing issue in DboSource::_matchRecords() where unqualified conditions would result in 1=1 conditions. Fixing incorrect test case. Fixes #930 2010-09-16 00:17:09 -04:00
mark_story
1707c92aa1 Removing duplicated code. 2010-09-14 23:15:10 -04:00
mark_story
c255539980 Removing assignment of reference to theme view.
Removing cruft in ThemeView test.
2010-09-14 23:13:00 -04:00
mark_story
f34cfd1f1e Updating EmailComponent to use new methods on the ComponentCollection to ensure it always has a controller reference.
Removing triggerDisabled key as its no longer needed or wanted.
2010-09-14 23:02:38 -04:00
mark_story
273a189e98 Adding some documentation about component callbacks. 2010-09-14 23:01:39 -04:00
mark_story
30589e2cdf Removing dead method. 2010-09-14 22:56:33 -04:00
mark_story
0ef76eb69a Adding a reference of the controller to the component collection, so components can easily access the controller in their constructor. 2010-09-14 22:52:51 -04:00
mark_story
7a14d3a8f2 Fixing issue where mockObject expectations were not counted hiding fails. Fixing all objects not actually being iterated. 2010-09-14 22:40:46 -04:00
mark_story
5d697b9d6e Fixing tests where objects were not added to the mockObjects lists, making their expects() not count. 2010-09-14 22:39:05 -04:00
mark_story
8e97a5ee2d Fixing failing tests caused by missing index in Security component testcase. 2010-09-14 22:20:30 -04:00
mark_story
0baaf6801b Removing call to RequestHandler as its just a pass through to the request object which is available in that scope. Updating the test cases to not use deprecated and non-existent things. 2010-09-14 22:12:14 -04:00
mark_story
97dd7c7644 Adding support to ObjectCollection and its subclasses to trigger callbacks on all objects instead of just the enabled ones. Fixes issues where inner components would not get access to the controller as the initialize callback wasn't fired. This fixes some backwards compatibility issues. Tests updated. 2010-09-14 21:57:40 -04:00
mark_story
285876c7e7 Adding po files omitted from previous commit. Refs #1085 2010-09-14 21:16:57 -04:00
mark_story
2906927a16 Adding BC wrappers for helpers.
Updating paginator test case to use non deprecated properties.
2010-09-13 23:12:00 -04:00
mark_story
003d02d8d9 Making view test pass by moving property assignment on mock. 2010-09-13 23:11:59 -04:00
mark_story
e4b2fb173b Removing the deprecated properties.
Removing property copying to helpers.
Making the view test cases pass again.
2010-09-13 23:11:59 -04:00
mark_story
634cea24eb Adding 'action' into View::__get() to make an integration test pass. 2010-09-13 23:11:59 -04:00
mark_story
a521291afd Adding a __set() method to make some tests pass.
Updating internal usage to not use deprecated attributes.
Updating test cases to not use deprecated attributes.
2010-09-13 23:11:59 -04:00
mark_story
84565151de Removing all the deprecated properties from Controller.
Adding a __get() method to provide the properties that were moved to CakeRequest.
Tests added.
2010-09-13 23:11:59 -04:00
mark_story
c7fb20d13a Reformatting doc block indentation. 2010-09-13 23:09:00 -04:00
mark_story
834c44b303 Fixing return value tag. 2010-09-13 23:06:15 -04:00
mark_story
d7bb7699e2 Applying patch from '0x20h' to fix issue where domain translation files would be mixed together causing duplicate data in the various cache files. There should now be one cache per domain + language. Fixes #1085 2010-09-13 22:17:05 -04:00
Juan Basso
ef147275d7 Added test to use Xml with Model. 2010-09-13 00:43:11 -03:00
mark_story
578674f0e1 Reformatting some code in Set::classicExtract test case. 2010-09-12 14:19:36 -04:00
mark_story
404e49b37d Adding tests for writing falsey values. 2010-09-12 14:08:17 -04:00
mark_story
6519de3a2e Adding CakeRequest::data() to make reading/writing data similar to CakeSession.
Tests added.
2010-09-12 14:05:57 -04:00
mark_story
730e373afe Merge branch '1.3' into 2.0
Conflicts:
	cake/libs/cake_session.php
	cake/libs/view/pages/home.ctp
	cake/tests/cases/libs/cache/memcache.test.php
	cake/tests/cases/libs/cake_session.test.php
	cake/tests/cases/libs/model/datasources/dbo_source.test.php
	cake/tests/fixtures/data_test_fixture.php
2010-09-12 13:35:46 -04:00
mark_story
85ccd1f096 Fixing skipIf calls so email test runs in a reasonable time frame when there is no local smtp server. 2010-09-12 13:06:49 -04:00
mark_story
e9d194822d Adding more tests for SMTP address formatting. Fixes #1100 2010-09-12 11:48:09 -04:00
Juan Basso
213c83401f Added test to generate Soap Request from array using namespaces. 2010-09-12 12:06:59 -03:00
Juan Basso
89be9b0986 Added test to generate Rss from array using namespaces. 2010-09-12 11:54:11 -03:00
Juan Basso
46f784f956 Support to DOMDocument/DOMNode in Xml::toArray(). 2010-09-12 11:25:37 -03:00
predominant
703344cbae Updated version number to 1.3.4 2010-09-12 17:57:55 +10:00
Juan Basso
a006ee0019 Updating docs. 2010-09-11 22:20:21 -03:00
Juan Basso
7237713a30 Added test to dont use encoding in XML. 2010-09-11 22:12:54 -03:00
Juan Basso
2e7851c2be Support to namespaces in Xml::fromArray(). 2010-09-11 21:51:49 -03:00
mark_story
55ecfe0292 Fixing stupid typo. 2010-09-11 15:48:48 -04:00
mark_story
7c79583caa Updating expiry time to be within tolerances of memcached. 2010-09-11 15:44:52 -04:00
mark_story
e4d34b640b Merge branch '2.0-exceptions' into 2.0
Conflicts:
	cake/libs/error.php
	cake/tests/cases/libs/controller/scaffold.test.php
	cake/tests/cases/libs/error.test.php
2010-09-10 20:31:16 -04:00
Scott Reeves
9ac8d1af1b Cleaning up link to 1.3 docs, fixing link to blog tutorial. Fixes #1097
Signed-off-by: mark_story <mark@mark-story.com>
2010-09-10 19:42:06 -04:00
mark_story
8625d7b374 Making debugger test case pass. 2010-09-09 22:58:34 -04:00
mark_story
fbd0741a83 Making a test more resilient when additional fixtures are loaded. 2010-09-09 22:54:22 -04:00
mark_story
f8dbeb2b70 Adding documentation for a new feature. 2010-09-09 22:02:36 -04:00
mark_story
4a0e34a0d6 Applying patch from 'jeremyharris' to make RequestHandler::renderAs() accept an array of options that can be used to send a file as a download. Fixes #950 2010-09-09 21:31:34 -04:00
mark_story
bdb3feb7fd Adding stack trace to the console error handler. Updating tests.
Changing require to require_once so the test case for ConsoleErrorHandler doesn't blow up in cli.
2010-09-08 23:38:51 -04:00
mark_story
d5e906f086 Adding deprecation flags. 2010-09-08 22:49:00 -04:00
mark_story
12338a0c16 Updating instance method calls in AclComponent. 2010-09-08 22:48:21 -04:00
mark_story
b60f65f420 Adding a tiny bit of documentation to App::import(). 2010-09-08 22:29:47 -04:00
mark_story
d5bde3fe7a Adding a call to session_destroy() to remove the session data. This fixes the issue where data would not be totally destroyed. Fixes #1089 2010-09-08 22:05:53 -04:00
Juan Basso
c8c20eafdc Xml::build now supports options and can return DOMDocument. 2010-09-08 21:47:55 -03:00
Juan Basso
071ff04556 Xml::fromArray now receives a list of options unless simple format. 2010-09-08 19:40:33 -03:00
Juan Basso
a8b6182d43 Changing Xml::fromArray to use DOMDocument unless SimpleXMLElement. The return continue as SimpleXMLElement. 2010-09-08 19:18:58 -03:00
mark_story
5d703c4f50 Fixing + adding imports for Scaffold. 2010-09-08 00:11:37 -04:00
mark_story
58d62cb369 Fixing issues with tests failing because exception messages changed. 2010-09-08 00:11:11 -04:00
mark_story
fa9eb94fb0 Adding base class import for view classes. 2010-09-08 00:10:36 -04:00
mark_story
2d86c1248f Adding view import to fix xml suite from not running. 2010-09-07 23:53:12 -04:00
mark_story
f677c4ab44 Fixing bake task tests and adding ConsoleErrorHandler to the AllShells suite. 2010-09-07 23:51:39 -04:00
mark_story
f94fcfb749 Updating Api shell test case to account for changes in controller api. 2010-09-07 23:42:18 -04:00
mark_story
b02d961d82 Adding ConsoleErrorHandler to the shell group. 2010-09-07 23:40:31 -04:00
mark_story
6e5e32bef5 Updating AclShell test to use AclComponent correctly. 2010-09-07 23:40:07 -04:00
mark_story
4ff52da57e Making import() ing a component ensure that the Component base class is loaded. 2010-09-07 23:39:31 -04:00
Juan Basso
ca7e327af1 Fixing the documentation. 2010-09-07 18:19:14 -03:00
Mark Story
2b3099fa70 Removing duplicate method call. 2010-09-07 00:42:49 -04:00
Mark Story
aad72871a0 Adding more tests for virtualFields and complex expressions. Closes #1079 2010-09-07 00:32:44 -04:00
Mark Story
e15069769d Adding tests for #1079 and fixing some formatting. 2010-09-07 00:09:06 -04:00
Juan Basso
c1a75cbc47 Support to namespaces in Xml::toArray(). 2010-09-07 00:31:50 -03:00
Juan Basso
5f902d42e0 Changing the default format of fromArray from attributes to tags. 2010-09-06 23:11:45 -03:00
Juan Basso
87604f92c7 Adding a missing assert to tests. 2010-09-06 20:17:30 -03:00
Mark Story
0f23634382 Adding stack traces to error400 and error500 when debug > 0.
Adding the stack trace element.
2010-09-06 18:09:11 -04:00
Mark Story
09fd8ba463 Adding stack trace output to the framework errors. 2010-09-06 17:54:48 -04:00
Mark Story
45dab88180 Adding a cast to fix a failing test from the merge. 2010-09-06 16:54:32 -04:00
Mark Story
d88da3d579 Merge branch '1.3' into 2.0
Conflicts:
	cake/libs/configure.php
	cake/libs/model/connection_manager.php
	cake/libs/model/model.php
	cake/tests/cases/libs/model/datasources/dbo/dbo_postgres.test.php
	cake/tests/cases/libs/view/helpers/text.test.php
2010-09-06 16:53:04 -04:00
Mark Story
c60edfae6d Fixing issue where errors containing code = 500, were not actually converted to error500 when debug = 0. Making missingConnection, and missingTable into error500 errors. 2010-09-06 16:46:41 -04:00
Mark Story
464d2217e6 Renaming model_behavior test to behavior_collection test as that's the class that contains the tested methods. 2010-09-06 13:51:42 -04:00
Mark Story
73057b8853 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2010-09-06 13:39:37 -04:00
Mark Story
5789aaf24d Applying patch from 'tkykmw'. Behavior mapped methods are no longer run through strtolower(). Mapped methods are now case sensitive. Fixes #318 2010-09-06 13:38:01 -04:00
predominant
a6b08c94d0 Merge remote branch 'origin/2.0' into 2.0
Conflicts:
	cake/libs/session/database_session.php
2010-09-06 23:57:36 +10:00
Mark Story
b491414a51 Changing gif to png, so baked apps have the correct icon. Fixes #1081 2010-09-06 01:39:39 -04:00
Mark Story
2e46d2f5ca Changing gif to png, so baked apps have the correct icon. Fixes #1081 2010-09-06 01:38:31 -04:00
Mark Story
fd50c2ae2a Adding some tests for the constructor. 2010-09-06 01:21:58 -04:00
Mark Story
d54c901f5d Moving _setupDatabase() into the Database session class, as that's the only place its used. 2010-09-06 01:12:23 -04:00
Mark Story
c8ad4f11eb Updating test session classes to not use static methods. 2010-09-06 01:11:54 -04:00
Mark Story
474ace09c1 Adding CakeResponse to the list of included files for Controller. 2010-09-06 01:11:26 -04:00
Mark Story
d62ae2900a Fixing issue where ConnectionManager wasn't triggering session close, causing issues with database sessions. 2010-09-06 01:10:45 -04:00
Mark Story
27ae7f1f44 Making session storage classes not static, there was no real reason they were static before, and removing the static methods allows them to have constructors. This will allow moving database specific features from CakeSession to DatabaseSession. 2010-09-06 00:43:58 -04:00
ADmad
bfaaa6b8ba Fixing unnecessary extra calls to 'afterFind' callback of 'hasMany' associated models. Closes #995 2010-09-05 23:53:24 +05:30
Mark Story
01eb0bf07d Making messages optional for HTTP exceptions. 2010-09-05 11:32:35 -04:00
Mark Story
8bd0f18a53 Adding a new line to the ConsoleErrorHandler
Refactoring ConsoleErrorHandler test to use dynamic mocks.
2010-09-05 11:22:39 -04:00
Mark Story
9fee81cda0 Updating ConsoleErrorHandler to use new exception names and method renames. 2010-09-05 11:10:48 -04:00
Mark Story
e5b4dd94d7 Renaming exceptions to not use Error400, Error500. Instead HTTP status words are used.
Adding more common HTTP status errors.
Updating tests for ErrorHandler.
2010-09-05 02:05:31 -04:00
Mark Story
b7791dd94f Removing variable that wasn't provided by the exception. 2010-09-05 02:04:08 -04:00
Mark Story
82fffe6914 Fixing issue where FormHelper::select() with multiple = checkbox and a custom name attribute would not work correctly. Fixes #1078 2010-09-05 01:28:13 -04:00
Mark Story
cc17e1a85a Adding more doc blocks to error classes. 2010-09-04 19:18:14 -04:00
Mark Story
954676c9f6 Adding doc blocks to the new exception classes. 2010-09-04 19:16:06 -04:00
Mark Story
d198230e61 Fixing issue where errors that did not have a 500+ code would use the incorrect status code. 2010-09-04 19:06:10 -04:00
Mark Story
4d863618f5 Refactoring exception handling so codes are much more flexible and easy to change.
Made error404 and error500 more generic.
Removed error() as it didn't really make that much sense.
2010-09-04 15:38:10 -04:00
Mark Story
dbd34c75c7 Removing newlines and trailing space. 2010-09-04 15:36:57 -04:00
Mark Story
4980f42dc5 Renaming file. 2010-09-04 15:35:01 -04:00
Mark Story
42d998ca3b Fixing up the include for the console error handler, and adding a test for stderr handle. 2010-09-04 10:46:04 -04:00
Mark Story
fa7549dc4c Fixing comments and removing cakeError(). Instead you should be throwing exceptions. 2010-09-04 01:34:45 -04:00
Mark Story
af87e5d5bc Adding a skip when AppError is present, as its behaviour is unknown. 2010-09-03 15:35:11 -04:00
Mark Story
8c428ff8a8 Moving where AppError is used, as infinite recursion is no fun. 2010-09-03 15:03:33 -04:00
Mark Story
5c0fe1b16e Applying patch from 'majna'. Adding plugin to the list of template variables exposed in the controller task. Test added Fixes #1077 2010-09-03 12:33:59 -04:00
Mark Story
f2db19767d Adding in support for AppError. 2010-09-03 10:30:35 -04:00
Mark Story
2c7ef67e97 Fixing stupid output buffering error. 2010-09-03 10:22:58 -04:00
Mark Story
29ade860b1 Adding cases for Error404 and Error500 exceptions. 2010-09-02 18:04:50 -04:00
Mark Story
a1e01e414b Adding a tests for CakeExceptions and non CakeExceptions 2010-09-02 18:02:58 -04:00
Mark Story
a44b35311d Integrating the ConsoleErrorHandler into the console environment. 2010-09-02 17:49:43 -04:00
Mark Story
60e44660c3 Moving ErrorHandler to ConsoleErrorHandler so it doesn't have classname conflicts.
Making the console use a subclass of ErrorHandler.
2010-09-02 17:49:00 -04:00
Mark Story
034aaa7462 Creating optional boot variable that informs Configure if it should bootstrap the app. Changing how ShellDispatcher checks for app existence it sets the $boot var now and reuses the framework bootstrap file instead of a second custom one. 2010-09-02 17:16:57 -04:00
Mark Story
81e6ca2249 Moving dispatcher include so that cake/bootstrap.php is only bootstrapping the framework. This should allow reusing the bootstrap file for console and web once console error handler is fixed. 2010-09-02 17:00:52 -04:00
Mark Story
d6b43c0e29 Removing TIME_START global, use $_SERVER['REQUEST_TIME'] instead. 2010-09-02 16:55:42 -04:00
Mark Story
ffa8b959e4 Changing classname and importing base class. 2010-09-02 16:47:06 -04:00
Mark Story
3940b059a3 Adding a big docblock to explain how to setup application exception handling. 2010-09-02 16:39:09 -04:00
Mark Story
2e8a60f932 Removing some mentions of cakeError as its been removed. Also adding information about exceptions that can be raised. 2010-09-02 16:38:19 -04:00
Mark Story
dbdd17f51a Adding test cases from 'euromark' and updating how email addresses are parsed so they are slightly more conformant to RFC 5322. Fixes #1066 2010-09-02 11:16:10 -04:00
Mark Story
3e5e52d52e Fixing doc block for Form::create(). Fixes #1058 2010-09-02 00:29:04 -04:00
Juan Basso
9239caa589 Added tests to use Xml with SOAP. 2010-09-01 21:37:32 -03:00
Mark Story
063fcf557d Moving error handler inclusion to before Configure::bootstrap() so app error handlers can be created.
Fixing issue where unknown exception types would not be handled spewing out errors.  Unknown exception types are interpreted as 500 errors.
2010-09-01 20:29:55 -04:00
Juan Basso
a1eeb03e36 Added tests to use Xml with XML-RPC. 2010-09-01 21:14:21 -03:00
Juan Basso
ff29897bad Moving the rss content to a file. 2010-09-01 20:22:39 -03:00
Juan Basso
26b514e2cd Chaning tests of Xml to public. 2010-09-01 20:09:03 -03:00
Juan Basso
edcb5e4370 Added tests to use Xml with RSS. 2010-09-01 20:06:56 -03:00
mark_story
08d6c19ab6 Adding test for themes in app/webroot dir. Closes #1061 2010-08-31 21:21:05 -04:00
mark_story
a8d4015f47 Updating bootstrap process in CLI to match the one in web.
Updating all_libs to use new file.
Updating error_handler test to run in cli.
Updating Controller so it imports required classes.
2010-08-30 22:59:10 -04:00
mark_story
1f30c06695 Fixing method coercion in error404 so it only coerces CakeExceptions.
Test Added.
2010-08-29 23:39:28 -04:00
mark_story
534f6006f8 Adding omitted parent call. 2010-08-29 23:38:46 -04:00
mark_story
612c52bb8b Adding a beforeRender() that automatically escapes all the content sent to errors handled by CakeErrorController. 2010-08-29 23:31:20 -04:00
mark_story
78ac5bd20f Removing sprintf() placeholders that don't work. 2010-08-29 23:28:54 -04:00
mark_story
efaa2e1177 Refactoring test case to use a dataprovider for the uniform/copy paste test cases. 2010-08-29 21:53:44 -04:00
mark_story
f1164c93d6 Updating the various CakeExceptions to take arrays in their constructors. This allows for the existing templates to continue working, as well as generalize the way in which errors are handled. This change also makes the messages coming out of exceptions more readable and removes string hackery. 2010-08-29 21:37:25 -04:00
mark_story
741f2972f9 Removing non required attribute from missing controller error page. 2010-08-29 15:12:50 -04:00
mark_story
99cde14432 No more skipped tests for ErrorHandler.
Removing missing_model as it was never called.
2010-08-29 13:49:10 -04:00
predominant
465b15c64e Removing reference assignments. 2010-08-29 23:09:33 +10:00
mark_story
7fb62e9b7e Updating more error messages to use exceptions. 2010-08-29 01:26:21 -04:00
mark_story
041aeecce4 Renaming test case file to match class file.
Updating tests and methods for missing_action, missing_view, private_action.
2010-08-29 01:01:36 -04:00
mark_story
88c66c057d Renaming error.php to error_handler.php to better match its class name. 2010-08-29 01:00:36 -04:00
mark_story
756baeafdb Making CakeErrorController get the most recent request, this will help when using requestAction.
Updating test cases for error404.
Updating ErrorHandler
2010-08-28 23:32:14 -04:00
mark_story
8712a90c8b Adding some tests for construction. 2010-08-28 22:50:29 -04:00
mark_story
a30721b46b Moving exception classes around and making all the core exceptions extend one class that overrides the code to 500. The code value will be used as the HTTP status code for the error page. 2010-08-28 22:49:52 -04:00
mark_story
5d942ee609 Extracting a few methods to make testing easier, and subclasses easier to create. 2010-08-28 19:53:21 -04:00
mark_story
5257a66fe5 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2010-08-28 11:26:28 -04:00
mark_story
26f4ad4da1 Modifying bootstrap so it sets a default exception handler.
Making a ghetto implementation of exception handling.
Adding a crude test case, adding incomplete markers to all other tests.
2010-08-28 01:39:02 -04:00
predominant
04d3353ee4 Adding access specifiers to methods 2010-08-28 15:38:48 +10:00
mark_story
9b3e91089a Adding omitted types of exceptions. 2010-08-28 01:38:03 -04:00
mark_story
5de88c0f02 Moving CakeErrorController to its own file. 2010-08-28 01:37:39 -04:00
predominant
f7addabcf2 Whitespace removal 2010-08-28 15:27:12 +10:00
predominant
c1209a1a7a Added RequestObject output in place of Controller:$output whicch no longer exists. 2010-08-28 15:15:23 +10:00
predominant
93b80042f8 Fix failing scaffold tests. 2010-08-28 15:01:43 +10:00
mark_story
a2186c412a Updating doc blocks for CakeRequest and CakeResponse. 2010-08-28 00:59:07 -04:00
mark_story
d8b2bcdf06 Making view + helpers groups pass. 2010-08-28 00:40:12 -04:00
mark_story
dcb7a167b4 Fixing controller test cases. 2010-08-28 00:29:50 -04:00
mark_story
9485f0a993 Merge branch 'request-response' into 2.0
Conflicts:
	cake/tests/cases/libs/controller/controller.test.php
2010-08-28 00:24:07 -04:00
mark_story
e4545dbe5e Fixing failing tests in Dispatcher.test. 2010-08-28 00:19:09 -04:00
mark_story
c76f205bcb Adding exceptions file. 2010-08-28 00:18:46 -04:00
mark_story
2cdb10812d Merge branch '2.0-exceptions' into 2.0
Conflicts:
	cake/dispatcher.php
	cake/libs/controller/scaffold.php
	cake/tests/cases/dispatcher.test.php
2010-08-28 00:14:34 -04:00
mark_story
dc67b9cacc Moving all the exceptions into one file for the short term. 2010-08-28 00:08:35 -04:00
José Lorenzo Rodríguez
f63b093d24 Merge branch '2.0-request' into 2.0
Still tons of tests failing
Conflicts:
	cake/dispatcher.php
	cake/libs/controller/components/auth.php
	cake/libs/controller/components/request_handler.php
	cake/libs/controller/components/security.php
	cake/libs/controller/controller.php
	cake/libs/router.php
	cake/libs/view/helper.php
	cake/libs/view/helpers/html.php
	cake/libs/view/view.php
	cake/tests/cases/dispatcher.test.php
	cake/tests/cases/libs/controller/components/auth.test.php
	cake/tests/cases/libs/controller/components/request_handler.test.php
	cake/tests/cases/libs/controller/components/security.test.php
	cake/tests/cases/libs/controller/controller.test.php
	cake/tests/cases/libs/router.test.php
	cake/tests/cases/libs/view/helper.test.php
	cake/tests/cases/libs/view/helpers/cache.test.php
	cake/tests/cases/libs/view/helpers/form.test.php
	cake/tests/cases/libs/view/helpers/html.test.php
	cake/tests/cases/libs/view/helpers/js.test.php
	cake/tests/cases/libs/view/helpers/paginator.test.php
2010-08-27 23:31:41 -04:30
mark_story
f0d938c1cb Fixing failing tests in scaffold. 2010-08-27 23:59:29 -04:00
mark_story
0683dc43ff Replacing cakeError calls with exceptions in ConnectionManager and Model. 2010-08-27 23:54:22 -04:00
mark_story
c4cb629d80 Replacing cakeError with exceptions in Scaffold. 2010-08-27 23:54:00 -04:00
mark_story
e600f86abd Updating Dispatcher test to test for exceptions instead of cake error returns.
Removing a test that is no longer valid.
2010-08-27 23:40:22 -04:00
mark_story
b301b0d86e Adding MissingModelException. 2010-08-27 23:04:35 -04:00
mark_story
caf7668de5 Adding documentation for Dispatcher::dispatch throwing exceptions. 2010-08-27 23:04:09 -04:00
mark_story
a15c4f89b4 Moving calls of cakeError() to using exceptions. 2010-08-27 22:59:48 -04:00
mark_story
1980c924b9 Adding RuntimeException classes for Dispatcher. 2010-08-27 22:48:02 -04:00
mark_story
1e6064ceae Removing the last exclusion from the AllHelper group. 2010-08-26 23:31:25 -04:00
mark_story
1a52442057 Removing class_exists() check as the class is now lazy loaded. 2010-08-26 23:26:18 -04:00
mark_story
6c87a026b6 Updating base class. 2010-08-26 23:24:32 -04:00
mark_story
4cc2229641 Updating CacheHelper to use correct View API.
Updating View to make CacheHelper tests pass.
2010-08-26 23:24:09 -04:00
mark_story
19e301c867 Updating test view to use correct helper syntax. 2010-08-26 23:19:20 -04:00
mark_story
b02e213958 Adding test case from '0x20h'. Fixing issue where atomic = false, validate = first and saveAll() saving many rows could return an incorrect value. Fixes #1050 2010-08-26 22:21:39 -04:00
mark_story
ea9e30890f Adding a workaround to DboSource::showLog() to work around fix added in [da9c0da626].
Also adding explanation message when logs are not generated.
2010-08-26 21:24:09 -04:00
mark_story
123873b4d8 Updating DboSource test to account for formatting of floats done in mysql/postgresql. 2010-08-26 21:20:13 -04:00
dogmatic69
95168cee6e casting the find as an array to avoid errors with array_values() fixes #1041 and 4 failing tests (3 previous)
Signed-off-by: mark_story <mark@mark-story.com>
2010-08-26 20:32:48 -04:00
mark_story
465c24f903 Adding a test case for TextHelper::toList(). Closes #1043 2010-08-26 20:30:30 -04:00
mark_story
903b260638 Changing spaces to tabs. 2010-08-26 20:29:03 -04:00
mark_story
c48c0d6295 Fixing issue where ViewTask would make empty view files for actions that did not have templates. Test case added. Fixes #1040 2010-08-23 21:49:30 -04:00
mark_story
ece055eefe Adding object type check to prevent fatal errors caused by view being used like a model object. Tests added. Fixes #1039 2010-08-23 21:39:23 -04:00
Juan Basso
52b09188f7 Adding fail tests to Xml::toArray(). 2010-08-23 18:33:24 -03:00
Juan Basso
84cf5d599c Changing to use array in tests. 2010-08-23 18:23:53 -03:00
Juan Basso
65726841cd Merge branch 2.0-xml of github.com:cakephp/cakephp into 2.0-xml 2010-08-23 01:49:42 -03:00
Juan Basso
f8b4d92a34 Arrays with @ as key now is the value of tag in Xml. 2010-08-23 01:33:06 -03:00
mark_story
ac36bc5894 Adding some docblocks to Xml. 2010-08-23 00:01:55 -04:00
Juan Basso
f777bd983f Making Xml::fromArray() parse @ in attibutes keys. 2010-08-23 00:48:34 -03:00
Juan Basso
9611ab1027 Changing to Xml::toArray() return @ after attributes to dont conflict with tags with same name. 2010-08-23 00:24:56 -03:00
mark_story
b1c41e5e18 Making tests use dataProviders instead of repeated test methods. 2010-08-22 23:19:54 -04:00
mark_story
b5b7595bc0 Fixing issue in scaffold where it accessed $output, which no longer exists. 2010-08-22 12:41:04 -04:00
mark_story
91c9c74274 Removing response injection into controller from dispatcher.
Modifying Dispatcher to use accessor method.
2010-08-22 12:40:06 -04:00
mark_story
7221f9c3b9 Moving response construction into Controller, this will let controller classes more easily modify the response subclass they want to use.
Test case updated.
2010-08-22 12:31:55 -04:00
mark_story
44f1687f5b Adding another test. 2010-08-22 00:54:55 -04:00
mark_story
efc1a2033f Adding spaces infront of comment blocks. 2010-08-22 00:48:24 -04:00
mark_story
ec22db597f Adding methods to get host, domain and subdomains for a request.
Tests added.
2010-08-22 00:44:05 -04:00
mark_story
0ec0962932 Adding CakeRequest::method() to find the name of the HTTP method name used for the request. Test case added. 2010-08-22 00:15:13 -04:00
mark_story
5446a062ee Fixing issue where whitelist would not be used for validation. Test case added. Fixes #1037 2010-08-21 22:48:59 -04:00
mark_story
12d4b52f10 Fixing failing tests in DboMysql and DboPostgres related to localized floats. Refs #1029 2010-08-21 00:49:40 -04:00
mark_story
eb96d8acfb Adding tests to dbo_postgres for localized floats. Refs #1029 2010-08-21 00:39:45 -04:00
mark_story
afc05c1e05 Adding test cases for using localized floats with mysql. Also added a generic model test case. Refs #1029 2010-08-21 00:19:30 -04:00
mark_story
e23fe25787 Fixing code formatting. 2010-08-21 00:17:40 -04:00
zimakm
b22f2f746b Configure fix problem 3-dimensional arrays to be handled as 4+ arrays.
This saves a lot of execution time when configure holds many values.
Fixes #1028

Signed-off-by: mark_story <mark@mark-story.com>
2010-08-18 22:29:23 -04:00
mark_story
6d8c761f2f Adding a missing s. 2010-08-17 22:25:45 -04:00
mark_story
750fe3aa05 Removing text() and password() as the new __call method handles them.
Updating test cases and adding a test for allowing a magic method to override the type.
2010-08-17 00:13:22 -04:00
mark_story
4efc170ce4 Adding some documentation. 2010-08-17 00:08:41 -04:00
mark_story
e79df23491 Adding a magic __call method to handle html5 inputs and simplify input generation logic. 2010-08-17 00:06:23 -04:00
mark_story
e2fee17173 Adding an ob_end_flush() to clean up an unclosed buffer. 2010-08-16 23:34:43 -04:00
mark_story
4622ec44c2 Updating the skel and app test.php's to not make a global variable for the dispatcher. This dramatically improves the performance of the web test runner. 2010-08-16 23:33:07 -04:00
mark_story
f46241a6e7 Merge branch '2.0' into 2.0-helpers 2010-08-16 23:02:44 -04:00
mark_story
fc9340213e Applying patch from 'thatcode', makes the 'us' rule case insensitive. Fixes #1020 2010-08-16 22:26:48 -04:00
mark_story
2abf34d93e Fixing issue where an app that was in a directory that had the same name
as a controller would end up failing to find view cache files.
Adding test for app name in controller name failure to create cache
Fixes #1025

Conflicts:

	cake/libs/view/helpers/cache.php
2010-08-16 22:11:25 -04:00
mark_story
c4a978d386 Adding changes missed in the merge. 2010-08-15 23:10:29 -04:00
mark_story
705e90bef7 Merge branch '1.3' into 2.0-merge
Conflicts:
	cake/libs/cache/memcache.php
	cake/libs/cake_session.php
	cake/libs/model/behaviors/acl.php
	cake/tests/cases/dispatcher.test.php
	cake/tests/cases/libs/cake_test_fixture.test.php
	cake/tests/cases/libs/model/behaviors/acl.test.php
	cake/tests/cases/libs/model/datasources/dbo/dbo_postgres.test.php
2010-08-15 23:09:02 -04:00
mark_story
2a50c3a1fb Removing time manipulation so its possible to create memcache entries that do not expire. Updating documentation about the peculiarities of memcache. Refs #871 2010-08-15 22:40:55 -04:00
mark_story
0865679684 Removing _expires keys made with Memcache cache engine. These did not add any value as Memcache already handles expiration of keys. Fixes #871 2010-08-15 22:32:52 -04:00
mark_story
686b9c2c8b Fixing issues in alterSchema in DboMysql and DboPostgres, where fields would be appended to each table being altered.
Also fixed an issue in DboPostgres where the generated alter statements would contain too many ;.
Test cases added.  Fixes #1023
2010-08-15 22:17:02 -04:00
mark_story
aba97d0ab2 Applying patch from 'Mark Mitchell' to fix auto exiting of cake.bat. Fixes #992 2010-08-14 18:54:12 -04:00
mark_story
1b41a987fa Adding test cases and fixing inflection issues with bases. Tests added. Fixes #1012 2010-08-12 20:26:11 -04:00
mark_story
36e585bb23 Starting to update a test that was previously marked incomplete. 2010-08-11 23:08:46 -04:00
mark_story
238c734f70 Moving a test case that should be implemented in controller, as that is where the code that needs to be tested is located. 2010-08-11 22:47:54 -04:00
mark_story
45064315d4 Fixing a comment. 2010-08-11 22:47:20 -04:00
mark_story
bd89ef533b Updating session helper constructor to fix failing tests in Controller::render() integration tests. 2010-08-11 00:01:24 -04:00