adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2024-11-15 11:28:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
19497 commits 7 branches 0 tags 44 MiB
Commit graph

19497 commits

This branch
This branch
All branches
Author SHA1 Message Date
Markus Podar
d201312a0e
php-8.0-compat: fix "Error: Unknown named parameter $subject" 
PHP 8 added support for named parameters however will throw an error when
a named parameter, which does not exist, will be called/appears.

In this case the code uses `array_filter(compact('subject))` to conveniently
prepend `$subject` to the callback, if it's non-null.

It's then combined with `$params` but mixing a hash wih a sequential array
and then end result is `['subject' => …, ]` which then triggers this
TypeError in PHP 8.

The solution applies `array_values()` on above array as to remove the keys
and then the error disappears.

With this change, our internal test suite (2k tests) is green on both PHP8
and PHP7.4, aka this change is expecte to be backwards compatible.
 2020-11-12 17:30:04 +01:00
Mark Story
b07bba4d4f Set max PHP version. 
We won't be supporting PHP8 in 2.x. Several of our dependencies are not
compatible and upgrading them would also require breaking change in
CakePHP. Folks needing PHP8 support will need to upgrade to 4.x
 2020-10-24 20:48:23 -04:00
Mark Story
89e23927cd
Merge pull request #15087 from martinstuecklschwaiger/2.x 
Make TestShell compatible with PHP 7.4
 2020-10-21 17:23:14 -04:00
Martin Stuecklschwaiger
bb58933691 Make TestShell compatible with PHP 7.4 2020-10-21 17:48:23 +00:00
Mark Story
af9089cbfe
Merge pull request #14949 from gemal/2.x 
add fo-fo
 2020-09-01 21:30:57 -04:00
Henrik Gemal
3f0d42502d add fo-fo 2020-09-01 13:28:14 +02:00
Mark Story
5bc68fc9ec
Merge pull request #14725 from cakephp/issue-14720 
Fix SchemaShell configuration change.
 2020-06-19 16:20:12 -04:00
mark_story
931d3a8626 Fix SchemaShell configuration change. 
Comparisons are done with === true. This fixes the set operation.

Fixes #14720
 2020-06-18 21:13:41 -04:00
Mark Story
a9b8c6b60f
Merge pull request #14718 from yjerem/fix-implode-argument-order 
[2.x] Fix deprecated argument order in calls to implode()
 2020-06-17 16:26:37 -04:00
Jeremy Ruten
e90e4716ec Fix deprecated argument order in calls to implode() 2020-06-17 11:44:23 -06:00
mark_story
d0c51b3742 Update version number to 2.10.22 2020-06-06 22:16:36 -04:00
andrii-pukhalevych
8addcf1fa3
Microoptimization for ServerRequest::is() and ServerRequest::isAll() (#14654) 2020-05-31 22:43:58 +05:30
Mark Story
9a7c94bad0
Merge pull request #14624 from cakephp/othercorey-patch-1 
Use random_int with PHP 7
 2020-05-23 21:21:57 -04:00
othercorey
01d5d039f3
Use random_int with PHP 7 2020-05-23 11:12:46 -05:00
Mark Story
59e12788fc
Merge pull request #14622 from RichieB2B/ncsc-nl/uuid 
Generate truly random uuid() for Cake 2.x
 2020-05-23 12:06:06 -04:00
Richard van den Berg
63c01dfbab Generate truly random uuid() 2020-05-23 15:38:41 +02:00
Mark Sch
a4bd6c40cc
Merge pull request #14619 from bancer/patch-19 
Improve php doc block in HtmlHelper.php
 2020-05-22 15:21:41 +02:00
Val Bancer
2d4f80bf66
Improve php doc block in HtmlHelper.php 2020-05-22 13:48:26 +02:00
mark_story
ab7eb46f20 Update version number to 2.10.21 2020-05-17 20:31:14 -04:00
ADmad
1ceb2107b1
Merge pull request #14507 from JakubOnderka/patch-1 
2.x: Fix argument order for implode method
 2020-04-27 22:07:23 +05:30
Jakub Onderka
fc3b50c523
Fix argument order for implode method 
Different order is deprecated and will cause fatal error in PHP8
 2020-04-27 16:08:52 +02:00
Mark Sch
785734e052
Merge pull request #14483 from bancer/patch-14 
Fix invalid data type
 2020-04-21 11:55:58 +02:00
Val Bancer
b957faa39c
Fix invalid data type 2020-04-21 11:32:16 +02:00
Mark Story
5ccb12354d
Merge pull request #14425 from cakephp/tls-13 
Add TLS 1.3 support to CakeSocket
 2020-04-06 10:23:04 -04:00
Mark Story
50e0ca7f9d Add TLS 1.3 support to CakeSocket 
Fixes #14422
 2020-04-05 00:25:09 -04:00
othercorey
d65ad7bd92
Merge pull request #14379 from mfn/mfn-curly-braces 
[2.x] php-7.4-compact: replace deprecated curly brace offset access
 2020-03-20 17:27:05 -05:00
Markus Podar
459ee900fe
php-7.4-compact: replace deprecated curly brace offset access 
Per https://wiki.php.net/rfc/deprecate_curly_braces_array_access and https://www.php.net/manual/en/migration74.deprecated.php
>  The array and string offset access syntax using curly braces is deprecated. Use $var[$idx] instead of $var{$idx}.
 2020-03-20 21:10:58 +01:00
mark_story
1ea6732e40 Update version number to 2.10.20 2020-01-16 20:56:03 -05:00
Mark Story
13fba738f7
Merge pull request #13984 from othercorey/2.x-phpunit-warnings 
2.x - Updated CakeTestSuiteCommand::run() exit logic to match phpunit's
 2019-12-06 10:14:14 -05:00
Mark Sch
16e8adce30
Merge pull request #13985 from bancer/patch-13 
Improve doc block
 2019-12-06 11:51:25 +01:00
Val Bancer
c59f021c4e
Improve doc block 2019-12-06 10:41:45 +01:00
Corey Taylor
eda72a6f3b Updated CakeTestSuiteCommand::run() exit logic to match phpunit's behavior now that doRun() is called with =false. 2019-12-06 01:15:11 -06:00
Mark Story
0992fa1c41
Merge pull request #13969 from cakephp/2.x-php74 
2.x - PHP 7.4
 2019-12-05 13:08:11 -05:00
Edgaras Janušauskas
49bbc21e1d Fix failures on PHP 7.4. Run phpcs on PHP 7.0 2019-12-05 15:11:35 +02:00
Edgaras Janušauskas
b56ea15eba
Update .travis.yml 2019-12-03 14:58:52 +02:00
Edgaras Janušauskas
d46fadddf8
Add Travis service config 2019-12-03 13:17:39 +02:00
Mark Sch
02bcdec391
Drop long EOL versions in favor of PHP5.6+ 2019-12-02 18:02:22 +01:00
Mark Sch
ed14b42274
php74 2019-12-02 17:56:38 +01:00
Mark Story
5eed56b6e4
Merge pull request #13947 from pascalwoerde/2.cannot-change-save-handler-when-session-is-active 
Fix duplicate session_set_save_handler call from handler instantiation.
 2019-11-28 16:56:04 -05:00
Pascal Woerde
2affcdfb00
Fix duplicate session_set_save_handler call from handler instantiation. 2019-11-26 13:39:22 +01:00
Mark Story
d2e1681eb8
Merge pull request #13683 from gersonfs/2.x 
Solving headers already sent bug on sessions whit phpunit.phar
 2019-09-26 15:10:03 -04:00
Gerson Felipe Schwinn
cf49efdf0e Solving headers already sent bug on sessions whit phpunit.phar 2019-09-26 09:00:11 -03:00
Mark Story
46068ac65b
Merge pull request #13606 from milan-corpoflow/patch-1 
Fix loading ShellHelpers from plugins
 2019-09-04 21:07:20 -04:00
Milan van As
64700e9a08
Fix loading ShellHelpers from plugins 
Previously the Shell::helper() function would call a `class_exists` on a variable that contained the `Plugin.ClassName` notation which will always result be false, e.g. `class_exists('YourPlugin.TestShellHelper')` will always be false. Loading ShellHelpers from a plugin will never work because of this. (This notation is described in the ShellHelper 2.x documentation).
After the pluginSplit and the loading of the actual ShellHelper class file (through `App::uses`), the `class_exists` should be called on the real class name, not on `Plugin.ClassName`.

Through this fix, plugins with an ExampleShellHelper in placed in MyPlugin/Console/Helper/ExampleShellHelper.php can be called in Shells by `$this->helper('MyPlugin.ExampleShellHelper')` and plugins within your app can still be loaded through the regular `$this->helper('MyShellHelper')`.
 2019-09-04 14:56:12 +02:00
Mark Story
ec8022baf5
Merge pull request #13539 from mvdriel/empty-post-body-for-json-will-put-null-value-in-request-data 
Empty post body for json will put null value in request->data
 2019-08-19 22:06:47 -04:00
Mark van Driel
142c19c557 Fix for: Empty post body for json will put null value in request->data 2019-08-19 15:00:19 +02:00
Mark van Driel
d4c351563e Test to prove issue with empty body for json 2019-08-19 14:52:46 +02:00
Mark Story
31dbda0a71
Merge pull request #13446 from garethellis36/ControllerTestCase/create-dispatcher 
2.x - Moves creation of ControllerTestDispatcher to its own protected method
 2019-07-29 21:58:27 -04:00
Gareth Ellis
dba84d65d7 Corrects style error from PHPCS by prefixing method name with an underscore 2019-07-29 15:27:45 +01:00
Gareth Ellis
f198ffdb9c Moves creation of ControllerTestDispatcher to its own protected method 2019-07-29 10:35:43 +01:00