Commit graph

12038 commits

Author SHA1 Message Date
mark_story
17ffcde505 Update test.
Add fixtures so app tables aren't touched.
Replace construction with method calls.
2011-11-12 21:42:20 -05:00
mark_story
2c7854cc2f Replace complicated $$foo with simple variable. 2011-11-12 21:42:20 -05:00
mark_story
42f9f8e2c3 Fixing strict errors.
While this is a minor API change, its required to
make CakePHP pass E_STRICT in testing.
2011-11-12 21:42:20 -05:00
mark_story
0a0a09920b Updating for PHP5.4
- Fixing strict errors.
- Fixing call time pass by reference as its been removed in PHP5.4
- Fix assign new as a reference, which has been removed.
2011-11-12 21:42:19 -05:00
Ceeram
0c0bb60486 avoid MissingPluginExceptions 2011-11-13 03:29:54 +01:00
Ceeram
d8194a5818 Merge commit '2890e6659ecb6f315c82253e6985ece0e6dc489d' into 2.0 2011-11-12 18:09:58 +01:00
mark_story
92688e2a49 Fix keying in SessionHelper::flash()
It shouldb e looking for the plugin in the params key.  This
makes SessionHelper compatible with SessionComponent.
2011-11-12 11:54:57 -05:00
mark_story
3ad50a2591 Fix session flash with plugins.
Fix using plugin elements for SessionHelper::flash()
Fixes #2246
2011-11-12 11:03:17 -05:00
mark_story
5934a7a324 Fix html coverage reporting.
HTML coverage reports now work with PHPUnit 3.6
Fixes #2235
2011-11-11 22:13:20 -05:00
mark_story
ee6d1cfdf0 Adding changes to test controller.
Refs #2198
2011-11-11 21:39:30 -05:00
mark_story
99caa98df3 Update message for PHPUnit3.6 2011-11-11 21:28:34 -05:00
mark_story
493ce3a442 Fix issue where REST actions were not easily testable.
Fixes #2198
2011-11-11 21:28:33 -05:00
José Lorenzo Rodríguez
a5d497068b Merge pull request #313 from shama/patch-timehelper
Add missing @link to TimeHelper docblocks and correct @return
2011-11-11 11:15:42 -08:00
Kyle Robinson Young
7df3252d6b Add missing @link to TimeHelper docblocks and correct @return 2011-11-11 10:51:14 -08:00
mark_story
7d756fda81 Fix Helper::field() for Model.min
This field would be treated as a field suffix even though
it is not. Expand existing tests, and reformat some code.

Fixes #2240
2011-11-10 22:22:11 -05:00
mark_story
0b0d180aad Changing how insertMulti handles boolean values.
Binding values individually allows boolean to work correctly.
2011-11-09 22:31:06 -05:00
mark_story
1487357ba6 Convert another long test to use a dataprovider. 2011-11-09 21:25:12 -05:00
mark_story
bc40a55f20 Re-factor dispatcher asset test to use a data provider. 2011-11-09 21:25:11 -05:00
Ceeram
767d1afcd8 fixing helptext for AclShell 2011-11-09 21:07:01 +01:00
José Lorenzo Rodríguez
5d8aeacde5 Merge pull request #312 from teddyzeenny/patch-cakesession
Patch for CakeSession php default
2011-11-09 09:44:31 -08:00
teddyzeenny
bdbc34bbed Remove session.save_handler from php ini array 2011-11-09 16:40:32 +02:00
mark_story
89ced25fad Making HttpResponse more tolerant of line endings. 2011-11-08 19:23:36 -05:00
Ceeram
cfbc6d4989 adding extra test, disproves ticket [#2233 state:works-for-me] 2011-11-08 20:29:33 +01:00
Mark Story
e8e2bbc4d7 Merge pull request #304 from jamiemill/2.0-upgradefix2
Add exception migration to the upgrade shell.
2011-11-08 06:47:52 -08:00
Renan Gonçalves aka renan.saddam
354b7a0ad4 Merge pull request #308 from shama/patch-3
Fix docblock formatting with Time Helper Test
2011-11-08 05:10:28 -08:00
Kyle Robinson Young
1b95b01265 Fix docblock formatting with Time Helper Test 2011-11-07 22:16:55 -08:00
mark_story
2c91f119cb Remove redundant check. 2011-11-07 23:17:08 -05:00
Mark Story
946753acde Merge pull request #306 from shama/patch-2
Fix incorrect toQuarter docblock return tag
2011-11-07 06:18:44 -08:00
Renan Gonçalves aka renan.saddam
2a33bc862a Merge pull request #296 from majna/2.0-dbconfig-task
Fix for 'datasource' key when baking another db config.
2011-11-07 01:58:54 -08:00
Renan Gonçalves
f09904ca91 Merge branch 'patch-time-gmt' of https://github.com/shama/cakephp into shama-patch-time-gmt 2011-11-07 10:44:28 +01:00
Ceeram
7224de962e removing unused variable, fixes #2227 2011-11-07 09:19:01 +01:00
Kyle Robinson Young
72502e8fec Remove extra fromString in TimeHelper::gmt and update docblock 2011-11-06 22:54:52 -08:00
Kyle Robinson Young
09300433f5 Fix incorrect toQuarter docblock return tag 2011-11-06 22:26:58 -08:00
José Lorenzo Rodríguez
bab613652a Merge pull request #305 from majna/2.0-prefixed-actions
Make View task use prefixed template before falling back to generic one
2011-11-06 19:41:57 -08:00
Majna
57afa1873e Make View task use prefixed template before falling back to generic one. It is possible now to create view templates for different prefixes. 2011-11-07 01:01:56 +01:00
jamiemill
e16890225c Fixed mistake in UpgradeShell::exceptions()
My fault ;)
2011-11-06 23:19:30 +00:00
jamiemill
c966a35beb Fixed bug in UpgradeShell::findFiles().
$this->_files was reset on each loop through paths, which means, for
example, if you still had the old 'views' directory kicking around
the results from 'View' would be overwritten.
2011-11-06 21:53:20 +00:00
jamiemill
4368b62dfb Added an 'exceptions' method to the UpgradeShell.
This just replaces some of the basic cakeError() calls with
equivalent exceptions.
2011-11-06 21:53:11 +00:00
jamiemill
1d52dc05e1 Fix for UpgradeShell::helpers() not discovering core helpers. 2011-11-06 21:53:03 +00:00
Mark Story
6fd69b022d Merge pull request #303 from shama/patch-1
Remove 5.3 notice from Config/core timezone comment
2011-11-06 13:47:31 -08:00
mark_story
d87f9f060b Make parent method check explicit to Shell.
This makes only methods on Shell inaccessible on the command line.
Parent methods in AppShell or other parent classes can now be called directly.
Fixes #2193
2011-11-06 16:32:51 -05:00
Kyle Robinson Young
b2414a777f Remove 5.3 notice from lib/Cake/Console/Templates/skel/Config/core timezone comment 2011-11-06 13:17:07 -08:00
Mark Story
db41a7dd16 Merge pull request #302 from majna/2.0-viewtask-methods
Fix View task generating only 'admin' methods views in non-interactive mode.
2011-11-06 12:59:38 -08:00
ADmad
01aa91b3cf Fixing bug where content length was not set for clients which don't accept compressed response. Closes #2225 2011-11-07 02:04:57 +05:30
Kyle Robinson Young
60718c3b9f Remove 5.3 notice from Config/core timezone comment 2011-11-06 11:04:19 -08:00
mark_story
aae8a89623 Change var -> public in controllertask.
Makes the confirmation message and generated code the same.
Fixes #2216
2011-11-06 11:50:16 -05:00
mark_story
3fa0bdb60f Revert "Fix missing objects in App::objects()"
This change caused non controller objects to show in the
controller list.  Reverting until a better implementation
can be done.

This reverts commit ba6f3c17fa.
2011-11-06 11:24:33 -05:00
mark_story
cfe38985cf Fix failing tests caused by changes in App::objects() 2011-11-06 11:23:11 -05:00
Majna
d84b66e744 Fix View task generating only 'admin' methods views in non-interactive mode. 2011-11-06 16:14:55 +01:00
ADmad
a7d08a6b39 Removed unused option triggerDisabled from ObjectCollection::trigger().
Fixed docblock for ObjectCollection::load();
2011-11-06 20:29:46 +05:30