Commit graph

452 commits

Author SHA1 Message Date
mark_story
0fc6d7a98d Making test more generic so it passes on Jenkins. 2011-09-30 22:44:04 -04:00
mark_story
4810518c7d Fix issue where abstract or interface controllers
would be constructed by Dispatcher.
Tests added.
Fixes #2048
2011-09-30 22:40:30 -04:00
mark_story
115c656dcc Update expectation to account for umask()
Updating a number of simple assertEqual -> assertEquals.
Fixes #2045
2011-09-30 22:10:16 -04:00
mark_story
af4b0c9c1b Make DboSource::lastError() fallback to the connection.
If there is no argument the connection error should be checked
for an error.
Add a test for most of lastError().  Mocking PDO is a pain.
Fixes #2046
2011-09-30 21:56:39 -04:00
mark_story
a3f25ee5e3 Fixing issue with integer columns and NULL values.
Fixes #2037
2011-09-29 20:28:52 -04:00
Jose Lorenzo Rodriguez
8acd980895 Converting more pattern assertions into simple string contains 2011-09-29 00:42:24 -04:30
Jose Lorenzo Rodriguez
fbdb058441 Converting regular expression assertions to simple string contains, those perform faster and consume less memory 2011-09-29 00:05:15 -04:30
Jose Lorenzo Rodriguez
27ab12dd2a Simplifying assertions in FixtureTask test 2011-09-28 23:39:07 -04:30
Jose Lorenzo Rodriguez
7b3ceb5a29 Fixing a few failing test cases and attempting to work around php segmentation fault when running the complete test suite 2011-09-28 22:57:50 -04:30
mark_story
08b974d64b Adding the _x and _y fields to the unlocked fields
for image submits.
Fixes #2032
2011-09-27 21:14:36 -04:00
Majna
8d6fc84135 Fixing failing test for Router. Debugger test fails on windows due to different directory separator. 2011-09-27 23:47:44 +02:00
ADmad
33030a4502 Fixing my previous attempt in ef4826e to make Model::_findCount() behave nicely with 'group' option. Refs #1677, #573 2011-09-28 02:58:48 +05:30
mark_story
7e44836837 Fixing failing test. 2011-09-26 21:46:25 -04:00
mark_story
a5fe702624 Updating CrudAuthorize to work like ActionsAuthorize.
Updating tests.
Fixes #1749
2011-09-26 20:38:38 -04:00
mark_story
79687a2dcf Making locking file caching the default.
Locking files prevents many issues with unserialize() warnings
caused by partially written files.
Fix a locking issue where files would be left locked.
Fixes #1988
2011-09-25 09:26:32 -04:00
mark_story
b1dad6e5bd Adding session renewal upon login/logout.
This helps improve session security, as it reduces the opportunity
of replaying a session id successfully.
Fixes #836
2011-09-24 22:35:21 -04:00
mark_story
50a0a51f53 Renaming method to better match what it does. 2011-09-24 21:56:37 -04:00
Yosuke Basuke Suzuki
5612d411f3 Added unittest for saveAll() validation with the data no id assigned. 2011-09-23 22:23:26 +09:00
mark_story
36928d35f9 Redoing fix done in 155968349f
Adding more test cleanup to try and solve build issues.
2011-09-22 22:05:36 -04:00
Jelle Henkens
957a75c45e Removing PHP4 compatibility code
Signed-off-by: mark_story <mark@mark-story.com>
2011-09-20 21:10:32 -04:00
Jose Lorenzo Rodriguez
8ccf90437a Typo in last commit. Making flexible the range for memory usage in theme view after changing internal templates 2011-09-18 16:43:00 -04:30
Jose Lorenzo Rodriguez
a2daa39a98 Making theme test more flexible so it passes after recent changes in templates 2011-09-18 16:37:17 -04:30
mark_story
8d43764801 Fix issue with duplicate associations when using string form.
Fixes #2002
2011-09-18 12:26:59 -04:00
mark_story
6a4e7558fc Merge branch '1.3' into merger
Conflicts:
	cake/basics.php
	cake/console/libs/tasks/extract.php
	cake/libs/view/helpers/js.php
	cake/tests/cases/console/libs/tasks/extract.test.php
	cake/tests/cases/libs/model/datasources/dbo/dbo_mysql.test.php
	cake/tests/cases/libs/model/datasources/dbo_source.test.php
	cake/tests/test_app/views/pages/extract.ctp
	lib/Cake/Cache/Engine/MemcacheEngine.php
	lib/Cake/Model/Behavior/ContainableBehavior.php
	lib/Cake/Model/Datasource/Database/Mysql.php
	lib/Cake/Model/Datasource/DboSource.php
	lib/Cake/Model/Model.php
	lib/Cake/Test/Case/Model/Behavior/ContainableBehaviorTest.php
	lib/Cake/Test/Case/Model/CakeSchemaTest.php
	lib/Cake/Test/Case/Model/Datasource/Database/PostgresTest.php
	lib/Cake/Test/Case/View/Helper/FormHelperTest.php
	lib/Cake/Test/Case/View/Helper/TimeHelperTest.php
2011-09-18 12:09:04 -04:00
ADmad
08026e5828 The 'default' config for Configure class is now auto created on first use if not already created. 2011-09-18 00:06:37 +05:30
mark_story
0e5797d69d Make full page caching + Themes work.
Dispatcher now uses ThemeView for rendering cache files.
This enables nocache blocks to reference theme elements.
Fixes #1858
2011-09-17 13:19:43 -04:00
mark_story
85b86cb282 Fix entity names for associated model date fields.
Fixes #1993
2011-09-17 12:29:21 -04:00
mark_story
09e7f1d491 Splitting apart the Scaffold and ScaffoldView tests.
Fixes #1985
2011-09-16 22:08:19 -04:00
Renan Gonçalves
4378bb6dc4 Fixed bug in CakeSchema where it determines the field position.
- Respective tests were added.
- Schema files will now have 'after' => 'previous_field' on it.
2011-09-16 15:28:28 +02:00
mark_story
42dccac8da Splitting AclTest into multiple test case files.
Fixes #1985
2011-09-13 21:25:50 -04:00
mark_story
4fda085928 Trying to fix occasional error during FixtureTaskTest. 2011-09-13 20:45:45 -04:00
Jelle Henkens
7ba2f90b2a Refactoring expectError() calls to PHPUnit annotations 2011-09-13 19:56:37 +01:00
mark_story
8272705fee Fixing failing test from previous commit. 2011-09-12 23:25:13 -04:00
mark_story
59e306526f Adding 'vendors' alias to App
- Vendor is the new directory name, and a legacy mapping should exist.
  This makes App::path() match App::import() and all other packages.
- Add an alias for plugins -> Plugin.  It also was missing the alias,
  that matches the new style package names.

Fixes #1972
2011-09-12 23:20:29 -04:00
mark_story
d74f442608 Making test case class names match file names.
Refs #1985
2011-09-12 23:01:04 -04:00
Mark Story
0e9b3dd613 Merge pull request #198 from jellehenkens/2.0-rss-helper-tests
Added tests for the RssHelper for code that was not covered
2011-09-12 19:59:09 -07:00
ADmad
97a975c6c4 Refactoring Model::invalidFields() a bit. 2011-09-12 05:10:34 +05:30
Jelle Henkens
236200ca56 Improved error handling for writing the test file to disk 2011-09-10 17:02:22 +01:00
Jelle Henkens
38196bda3f Adding missing test scenarios in the rss helper 2011-09-10 11:49:49 +01:00
Jelle Henkens
653163c891 Adding missing test scenarios in the paginator helper 2011-09-09 21:47:26 -04:00
mark_story
608e5ee04b Refactoring test.
Removing expectError() replacing it with PHPUnit annotation.
2011-09-09 21:43:57 -04:00
Jelle Henkens
aa4545217e Fixing test by splitting them up, testing the expected error ignored the next asserts 2011-09-09 21:40:05 -04:00
mark_story
3cb3424b4f Add App::uses to baked controllers.
Controllers should load their dependencies.
Bake should help with the best practice.
Fixes #1971
2011-09-09 20:43:04 -04:00
mark_story
7c08c966b0 Adding App::uses() call to model baking.
Models should always include their parent classes to be safe.
Bake should reflect the best practice.
Refs #1971
2011-09-09 20:43:04 -04:00
mark_story
1743eaa776 Fix issue with HABTM fields
habtm fields were not being correctly being detected.
2011-09-08 22:18:44 -04:00
mark_story
fa8bdfd0dd Add fix and test for CamelBack input names.
Refs #1974
2011-09-08 20:34:41 -04:00
Mark Story
8880e0c668 Merge pull request #192 from jellehenkens/2.0-html-helper-tests
Added tests for the HtmlHelper for code that was not covered
2011-09-07 18:03:02 -07:00
mark_story
6ab59a447c Fix create() and onsubmit option.
Removing support for onSubmit variant.  Additional
choices are not necessary. Fixing onsubmit option
not correctly working.
Fixes #1977
2011-09-07 20:59:04 -04:00
Jelle Henkens
3c8c2936b3 Added tests to test ajax settings 2011-09-07 20:59:04 -04:00
Jelle Henkens
e6826fea21 Adding tests for HtmlHelper 2011-09-08 00:59:39 +01:00
mark_story
39c270fd84 Attempting to fix build failure in Jenkins. 2011-09-05 21:53:29 -04:00
mark_story
684c154777 Removing more flaky tests. 2011-09-04 10:50:15 +01:00
mark_story
2218923782 Removing a failing test. I think the encoding of the file has changed over time,
and I don't have a typeface with lowercase Georgian text.
2011-09-04 10:22:35 +01:00
Jose Lorenzo Rodriguez
3d0af8b690 Adding a new exception renderer method to show useful error for failed queries 2011-09-04 04:50:19 -04:30
Jose Lorenzo Rodriguez
843f7e3eef Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2011-09-03 21:08:50 -04:30
Jose Lorenzo Rodriguez
12c73806f4 Skipping tests on Sqlite that involve creating a duplicate connection/ It is not possible to open multiple connections to it 2011-09-03 21:07:40 -04:30
mark_story
8630f4cdcb Fixing mistake in last commit. 2011-09-04 02:15:45 +01:00
mark_story
8c8dc6cebb Fixing the one failing Multibyte test. 2011-09-04 01:55:26 +01:00
mark_story
dbf801b9d4 Fixing failing test. 2011-09-04 01:06:00 +01:00
Jose Lorenzo Rodriguez
149deba416 Fixing Mysql test case after making the DboSource throw exceptions 2011-09-03 19:12:06 -04:30
Jose Lorenzo Rodriguez
8897335af4 All tests passing on postgres 2011-09-03 18:58:53 -04:30
Jose Lorenzo Rodriguez
74ba030e7c More postgres tests passing again 2011-09-03 18:34:11 -04:30
Jose Lorenzo Rodriguez
93d6cd4ad6 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2011-09-03 18:08:16 -04:30
Jose Lorenzo Rodriguez
61ff8d6154 Making DboSource tests more portable 2011-09-03 18:07:26 -04:30
mark_story
d597186274 Fixing a few more failing tests.
Adding some parent calls to tests, removing duplicated junk.
2011-09-03 23:23:24 +01:00
Jose Lorenzo Rodriguez
d06d5f8738 Not checking length on databases that won't return it for floats 2011-09-03 17:21:48 -04:30
Jose Lorenzo Rodriguez
fcf58371fd Fixing a failing postgres test 2011-09-03 17:09:41 -04:30
Jose Lorenzo Rodriguez
7003edeb8f Adding missing expectedException annotations 2011-09-03 17:05:09 -04:30
Jose Lorenzo Rodriguez
0ca8af2c22 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2011-09-03 17:01:49 -04:30
Jose Lorenzo Rodriguez
f0ef0aab62 Making postgres tests pass 2011-09-03 17:00:16 -04:30
mark_story
2c21fc90fb Fixing failing tests and issues with Sqlite. 2011-09-03 22:07:45 +01:00
Jose Lorenzo Rodriguez
49b8b24ac2 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2011-09-03 13:09:04 -04:30
mark_story
2ceea79862 Fixing errors and failing tests with SQLite.
Seems that MySQL is extremely permissive with NOT NULL fields.
SQLite is more strict it seems.
2011-09-03 18:37:29 +01:00
Jose Lorenzo Rodriguez
36470f4a86 Removing $error property from DboSource, errors in queries will throw exceptions now 2011-09-03 12:17:00 -04:30
Jose Lorenzo Rodriguez
df303f9e09 Fixing remaining failing tests 2011-09-03 09:43:50 -04:30
Jose Lorenzo Rodriguez
2bca1435ab Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2011-09-03 07:05:48 -04:30
Jose Lorenzo Rodriguez
01f26995b6 Fixing failing test in fixture test case 2011-09-03 07:04:51 -04:30
Jose Lorenzo Rodriguez
89b1e54071 Removing Oracle driver, it will not make it to stable release. Revert this commit to bring it back for next version 2011-09-03 06:50:19 -04:30
mark_story
ca078d9a25 Converging on 4px for border-radius.
Updating debug() to output a tiny bit more HTML so it can be made sexy.
2011-09-03 10:06:01 +01:00
mark_story
f1f4afacbd Fixing duplication of classes. cake-debug was used for debug and error messages. 2011-09-03 10:06:01 +01:00
mark_story
85d9b1af8d Fixing failing tests caused by path/object cache issues. 2011-09-03 01:14:51 +01:00
mark_story
efbeab6199 Merge branch '1.3' into merger
Conflicts:
	cake/libs/controller/components/email.php
	cake/tests/cases/console/libs/tasks/fixture.test.php
	lib/Cake/Console/Command/Task/DbConfigTask.php
2011-09-03 00:48:09 +01:00
Renan Gonçalves
7ae89c3679 Checking if short options exist, fixed an warning caused by not checking it. 2011-09-01 22:10:42 +02:00
Mark Story mark@mark-story.com
957a8d5c00 Fixing log files to directories a webserver doesn't always have write access too. 2011-09-01 20:24:39 +01:00
Mark Story mark@mark-story.com
41b22c5521 Fixing Router::mapResources() so it works with plugins.
Fixes #1956
2011-09-01 18:49:01 +01:00
Mark Story mark@mark-story.com
4d1f41dddc Fixing failing tests cased by App::object() cache being warm.
Removing code duplicated in CakeTestCase methods.
Adding missing parent calls.
2011-09-01 00:38:08 +01:00
Mark Story mark@mark-story.com
572412ec6b Removing bad integration test that wasn't required anymore. 2011-09-01 00:23:59 +01:00
Mark Story mark@mark-story.com
bb3a1d546b Fixing RequesHandler::prefers(). It was previously entirely wrong.
It took the ordered list of accept types, and blindly assumed
the first in the list was the most preferred.  This is an incorrect
assumption to make, as all types with the same q value are equal.

- Using CakeRequest::parseAccept() to access only the most preferred
content types.
- Using in_array() to check for the desired type.
- Updating tests for RequestHandler.
2011-09-01 00:20:54 +01:00
Mark Story mark@mark-story.com
e2f48b4a95 Refactoring how q values are parsed, as content types were
reversed for similar q value types.  This causes issues in
RequestHandlerComponent.
2011-09-01 00:20:54 +01:00
Jose Lorenzo Rodriguez
b9b7516945 Merge remote-tracking branch 'ceeram/2.0-email' into 2.0
Conflicts:
	lib/Cake/Network/Email/AbstractTransport.php
	lib/Cake/Network/Email/CakeEmail.php
	lib/Cake/Network/Email/DebugTransport.php
	lib/Cake/Network/Email/MailTransport.php
	lib/Cake/Network/Email/SmtpTransport.php
2011-08-31 17:39:41 -04:30
Juan Basso
840d27bbb9 Fixed the allow method to parameters not be required. 2011-08-30 21:12:57 -04:00
Jose Lorenzo Rodriguez
6612cb3421 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2011-08-30 00:08:54 -04:30
Jose Lorenzo Rodriguez
a8b38beb9d Fixing bug in SchemaShell where it would always force a read on all tables 2011-08-30 00:07:57 -04:30
Mark Story mark@mark-story.com
3a8b344208 Fixing issue where CakeTestCase would erase custom bootstrapped paths in tearDown().
Adding App::paths() to simplify getting all the paths App knows about.
Fixes #1934
2011-08-29 22:14:18 -04:00
Jose Lorenzo Rodriguez
0e85170f28 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2011-08-29 16:55:27 -04:30
Jose Lorenzo Rodriguez
40ba4005bd Affecting the REQUEST_METHOD env variable in order to ease controller testing with different http verbs 2011-08-29 16:54:22 -04:30
Ceeram
0b00fb4fe0 fixing bug in deliver(), and adding more tests 2011-08-29 17:13:41 +02:00
Ceeram
4b093a858c adding more testcases for CakeEmail 2011-08-29 16:02:00 +02:00
Ceeram
c5d0955cd0 adding back blank line 2011-08-29 11:39:08 +02:00
Ceeram
87ffd92c2b Fixing transport test, as transport class now returns as stated in RFC 2822 2011-08-29 11:38:01 +02:00