Commit graph

5290 commits

Author SHA1 Message Date
Mark Story
474ace09c1 Adding CakeResponse to the list of included files for Controller. 2010-09-06 01:11:26 -04:00
Mark Story
d62ae2900a Fixing issue where ConnectionManager wasn't triggering session close, causing issues with database sessions. 2010-09-06 01:10:45 -04:00
Mark Story
27ae7f1f44 Making session storage classes not static, there was no real reason they were static before, and removing the static methods allows them to have constructors. This will allow moving database specific features from CakeSession to DatabaseSession. 2010-09-06 00:43:58 -04:00
ADmad
bfaaa6b8ba Fixing unnecessary extra calls to 'afterFind' callback of 'hasMany' associated models. Closes #995 2010-09-05 23:53:24 +05:30
Mark Story
01eb0bf07d Making messages optional for HTTP exceptions. 2010-09-05 11:32:35 -04:00
Mark Story
e5b4dd94d7 Renaming exceptions to not use Error400, Error500. Instead HTTP status words are used.
Adding more common HTTP status errors.
Updating tests for ErrorHandler.
2010-09-05 02:05:31 -04:00
Mark Story
b7791dd94f Removing variable that wasn't provided by the exception. 2010-09-05 02:04:08 -04:00
Mark Story
82fffe6914 Fixing issue where FormHelper::select() with multiple = checkbox and a custom name attribute would not work correctly. Fixes #1078 2010-09-05 01:28:13 -04:00
Mark Story
cc17e1a85a Adding more doc blocks to error classes. 2010-09-04 19:18:14 -04:00
Mark Story
954676c9f6 Adding doc blocks to the new exception classes. 2010-09-04 19:16:06 -04:00
Mark Story
d198230e61 Fixing issue where errors that did not have a 500+ code would use the incorrect status code. 2010-09-04 19:06:10 -04:00
Mark Story
4d863618f5 Refactoring exception handling so codes are much more flexible and easy to change.
Made error404 and error500 more generic.
Removed error() as it didn't really make that much sense.
2010-09-04 15:38:10 -04:00
Mark Story
4980f42dc5 Renaming file. 2010-09-04 15:35:01 -04:00
Mark Story
fa7549dc4c Fixing comments and removing cakeError(). Instead you should be throwing exceptions. 2010-09-04 01:34:45 -04:00
Mark Story
8c428ff8a8 Moving where AppError is used, as infinite recursion is no fun. 2010-09-03 15:03:33 -04:00
Mark Story
f2db19767d Adding in support for AppError. 2010-09-03 10:30:35 -04:00
Mark Story
3940b059a3 Adding a big docblock to explain how to setup application exception handling. 2010-09-02 16:39:09 -04:00
Mark Story
2e8a60f932 Removing some mentions of cakeError as its been removed. Also adding information about exceptions that can be raised. 2010-09-02 16:38:19 -04:00
Mark Story
dbdd17f51a Adding test cases from 'euromark' and updating how email addresses are parsed so they are slightly more conformant to RFC 5322. Fixes #1066 2010-09-02 11:16:10 -04:00
Mark Story
3e5e52d52e Fixing doc block for Form::create(). Fixes #1058 2010-09-02 00:29:04 -04:00
Mark Story
063fcf557d Moving error handler inclusion to before Configure::bootstrap() so app error handlers can be created.
Fixing issue where unknown exception types would not be handled spewing out errors.  Unknown exception types are interpreted as 500 errors.
2010-09-01 20:29:55 -04:00
mark_story
a8d4015f47 Updating bootstrap process in CLI to match the one in web.
Updating all_libs to use new file.
Updating error_handler test to run in cli.
Updating Controller so it imports required classes.
2010-08-30 22:59:10 -04:00
mark_story
1f30c06695 Fixing method coercion in error404 so it only coerces CakeExceptions.
Test Added.
2010-08-29 23:39:28 -04:00
mark_story
534f6006f8 Adding omitted parent call. 2010-08-29 23:38:46 -04:00
mark_story
612c52bb8b Adding a beforeRender() that automatically escapes all the content sent to errors handled by CakeErrorController. 2010-08-29 23:31:20 -04:00
mark_story
f1164c93d6 Updating the various CakeExceptions to take arrays in their constructors. This allows for the existing templates to continue working, as well as generalize the way in which errors are handled. This change also makes the messages coming out of exceptions more readable and removes string hackery. 2010-08-29 21:37:25 -04:00
mark_story
741f2972f9 Removing non required attribute from missing controller error page. 2010-08-29 15:12:50 -04:00
mark_story
99cde14432 No more skipped tests for ErrorHandler.
Removing missing_model as it was never called.
2010-08-29 13:49:10 -04:00
predominant
465b15c64e Removing reference assignments. 2010-08-29 23:09:33 +10:00
mark_story
7fb62e9b7e Updating more error messages to use exceptions. 2010-08-29 01:26:21 -04:00
mark_story
041aeecce4 Renaming test case file to match class file.
Updating tests and methods for missing_action, missing_view, private_action.
2010-08-29 01:01:36 -04:00
mark_story
88c66c057d Renaming error.php to error_handler.php to better match its class name. 2010-08-29 01:00:36 -04:00
mark_story
756baeafdb Making CakeErrorController get the most recent request, this will help when using requestAction.
Updating test cases for error404.
Updating ErrorHandler
2010-08-28 23:32:14 -04:00
mark_story
8712a90c8b Adding some tests for construction. 2010-08-28 22:50:29 -04:00
mark_story
a30721b46b Moving exception classes around and making all the core exceptions extend one class that overrides the code to 500. The code value will be used as the HTTP status code for the error page. 2010-08-28 22:49:52 -04:00
mark_story
5d942ee609 Extracting a few methods to make testing easier, and subclasses easier to create. 2010-08-28 19:53:21 -04:00
mark_story
5257a66fe5 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2010-08-28 11:26:28 -04:00
mark_story
26f4ad4da1 Modifying bootstrap so it sets a default exception handler.
Making a ghetto implementation of exception handling.
Adding a crude test case, adding incomplete markers to all other tests.
2010-08-28 01:39:02 -04:00
predominant
04d3353ee4 Adding access specifiers to methods 2010-08-28 15:38:48 +10:00
mark_story
9b3e91089a Adding omitted types of exceptions. 2010-08-28 01:38:03 -04:00
mark_story
5de88c0f02 Moving CakeErrorController to its own file. 2010-08-28 01:37:39 -04:00
predominant
f7addabcf2 Whitespace removal 2010-08-28 15:27:12 +10:00
mark_story
a2186c412a Updating doc blocks for CakeRequest and CakeResponse. 2010-08-28 00:59:07 -04:00
mark_story
d8b2bcdf06 Making view + helpers groups pass. 2010-08-28 00:40:12 -04:00
mark_story
9485f0a993 Merge branch 'request-response' into 2.0
Conflicts:
	cake/tests/cases/libs/controller/controller.test.php
2010-08-28 00:24:07 -04:00
mark_story
e4545dbe5e Fixing failing tests in Dispatcher.test. 2010-08-28 00:19:09 -04:00
mark_story
c76f205bcb Adding exceptions file. 2010-08-28 00:18:46 -04:00
mark_story
2cdb10812d Merge branch '2.0-exceptions' into 2.0
Conflicts:
	cake/dispatcher.php
	cake/libs/controller/scaffold.php
	cake/tests/cases/dispatcher.test.php
2010-08-28 00:14:34 -04:00
mark_story
dc67b9cacc Moving all the exceptions into one file for the short term. 2010-08-28 00:08:35 -04:00
José Lorenzo Rodríguez
f63b093d24 Merge branch '2.0-request' into 2.0
Still tons of tests failing
Conflicts:
	cake/dispatcher.php
	cake/libs/controller/components/auth.php
	cake/libs/controller/components/request_handler.php
	cake/libs/controller/components/security.php
	cake/libs/controller/controller.php
	cake/libs/router.php
	cake/libs/view/helper.php
	cake/libs/view/helpers/html.php
	cake/libs/view/view.php
	cake/tests/cases/dispatcher.test.php
	cake/tests/cases/libs/controller/components/auth.test.php
	cake/tests/cases/libs/controller/components/request_handler.test.php
	cake/tests/cases/libs/controller/components/security.test.php
	cake/tests/cases/libs/controller/controller.test.php
	cake/tests/cases/libs/router.test.php
	cake/tests/cases/libs/view/helper.test.php
	cake/tests/cases/libs/view/helpers/cache.test.php
	cake/tests/cases/libs/view/helpers/form.test.php
	cake/tests/cases/libs/view/helpers/html.test.php
	cake/tests/cases/libs/view/helpers/js.test.php
	cake/tests/cases/libs/view/helpers/paginator.test.php
2010-08-27 23:31:41 -04:30
mark_story
0683dc43ff Replacing cakeError calls with exceptions in ConnectionManager and Model. 2010-08-27 23:54:22 -04:00
mark_story
c4cb629d80 Replacing cakeError with exceptions in Scaffold. 2010-08-27 23:54:00 -04:00
mark_story
b301b0d86e Adding MissingModelException. 2010-08-27 23:04:35 -04:00
mark_story
4cc2229641 Updating CacheHelper to use correct View API.
Updating View to make CacheHelper tests pass.
2010-08-26 23:24:09 -04:00
mark_story
b02e213958 Adding test case from '0x20h'. Fixing issue where atomic = false, validate = first and saveAll() saving many rows could return an incorrect value. Fixes #1050 2010-08-26 22:21:39 -04:00
mark_story
ea9e30890f Adding a workaround to DboSource::showLog() to work around fix added in [da9c0da626].
Also adding explanation message when logs are not generated.
2010-08-26 21:24:09 -04:00
dogmatic69
95168cee6e casting the find as an array to avoid errors with array_values() fixes #1041 and 4 failing tests (3 previous)
Signed-off-by: mark_story <mark@mark-story.com>
2010-08-26 20:32:48 -04:00
mark_story
ece055eefe Adding object type check to prevent fatal errors caused by view being used like a model object. Tests added. Fixes #1039 2010-08-23 21:39:23 -04:00
Juan Basso
65726841cd Merge branch 2.0-xml of github.com:cakephp/cakephp into 2.0-xml 2010-08-23 01:49:42 -03:00
Juan Basso
f8b4d92a34 Arrays with @ as key now is the value of tag in Xml. 2010-08-23 01:33:06 -03:00
mark_story
ac36bc5894 Adding some docblocks to Xml. 2010-08-23 00:01:55 -04:00
Juan Basso
f777bd983f Making Xml::fromArray() parse @ in attibutes keys. 2010-08-23 00:48:34 -03:00
Juan Basso
9611ab1027 Changing to Xml::toArray() return @ after attributes to dont conflict with tags with same name. 2010-08-23 00:24:56 -03:00
mark_story
b5b7595bc0 Fixing issue in scaffold where it accessed $output, which no longer exists. 2010-08-22 12:41:04 -04:00
mark_story
7221f9c3b9 Moving response construction into Controller, this will let controller classes more easily modify the response subclass they want to use.
Test case updated.
2010-08-22 12:31:55 -04:00
mark_story
efc1a2033f Adding spaces infront of comment blocks. 2010-08-22 00:48:24 -04:00
mark_story
ec22db597f Adding methods to get host, domain and subdomains for a request.
Tests added.
2010-08-22 00:44:05 -04:00
mark_story
0ec0962932 Adding CakeRequest::method() to find the name of the HTTP method name used for the request. Test case added. 2010-08-22 00:15:13 -04:00
mark_story
5446a062ee Fixing issue where whitelist would not be used for validation. Test case added. Fixes #1037 2010-08-21 22:48:59 -04:00
mark_story
12d4b52f10 Fixing failing tests in DboMysql and DboPostgres related to localized floats. Refs #1029 2010-08-21 00:49:40 -04:00
mark_story
e23fe25787 Fixing code formatting. 2010-08-21 00:17:40 -04:00
zimakm
b22f2f746b Configure fix problem 3-dimensional arrays to be handled as 4+ arrays.
This saves a lot of execution time when configure holds many values.
Fixes #1028

Signed-off-by: mark_story <mark@mark-story.com>
2010-08-18 22:29:23 -04:00
mark_story
6d8c761f2f Adding a missing s. 2010-08-17 22:25:45 -04:00
mark_story
750fe3aa05 Removing text() and password() as the new __call method handles them.
Updating test cases and adding a test for allowing a magic method to override the type.
2010-08-17 00:13:22 -04:00
mark_story
4efc170ce4 Adding some documentation. 2010-08-17 00:08:41 -04:00
mark_story
e79df23491 Adding a magic __call method to handle html5 inputs and simplify input generation logic. 2010-08-17 00:06:23 -04:00
mark_story
f46241a6e7 Merge branch '2.0' into 2.0-helpers 2010-08-16 23:02:44 -04:00
mark_story
fc9340213e Applying patch from 'thatcode', makes the 'us' rule case insensitive. Fixes #1020 2010-08-16 22:26:48 -04:00
mark_story
c4a978d386 Adding changes missed in the merge. 2010-08-15 23:10:29 -04:00
mark_story
705e90bef7 Merge branch '1.3' into 2.0-merge
Conflicts:
	cake/libs/cache/memcache.php
	cake/libs/cake_session.php
	cake/libs/model/behaviors/acl.php
	cake/tests/cases/dispatcher.test.php
	cake/tests/cases/libs/cake_test_fixture.test.php
	cake/tests/cases/libs/model/behaviors/acl.test.php
	cake/tests/cases/libs/model/datasources/dbo/dbo_postgres.test.php
2010-08-15 23:09:02 -04:00
mark_story
2a50c3a1fb Removing time manipulation so its possible to create memcache entries that do not expire. Updating documentation about the peculiarities of memcache. Refs #871 2010-08-15 22:40:55 -04:00
mark_story
0865679684 Removing _expires keys made with Memcache cache engine. These did not add any value as Memcache already handles expiration of keys. Fixes #871 2010-08-15 22:32:52 -04:00
mark_story
686b9c2c8b Fixing issues in alterSchema in DboMysql and DboPostgres, where fields would be appended to each table being altered.
Also fixed an issue in DboPostgres where the generated alter statements would contain too many ;.
Test cases added.  Fixes #1023
2010-08-15 22:17:02 -04:00
mark_story
1b41a987fa Adding test cases and fixing inflection issues with bases. Tests added. Fixes #1012 2010-08-12 20:26:11 -04:00
mark_story
45064315d4 Fixing a comment. 2010-08-11 22:47:20 -04:00
mark_story
bd89ef533b Updating session helper constructor to fix failing tests in Controller::render() integration tests. 2010-08-11 00:01:24 -04:00
mark_story
74a12940cb Removing incorrect method implementation.
Adding documentation to Component::beforeRedirect()
Adding documentation to ObjectCollection::trigger().
2010-08-10 23:45:28 -04:00
mark_story
2494156e9a Removing reference operators that caused tests to fail.
Adding an alias as several tests relied on a User object being in the registry to autodetect fields.
2010-08-10 23:18:43 -04:00
mark_story
f5bebc9306 Adding an Acl property to AuthComponent and updating tests to use new API's 2010-08-10 23:18:42 -04:00
mark_story
c6a63bae82 Fixing incorrect method call from merge with 1.3 2010-08-10 23:18:42 -04:00
mark_story
db1acb461a Making SessionComponent extend Component. Updating test case. 2010-08-10 23:18:42 -04:00
mark_story
6dbe5b09f8 Fixing failing test caused by undefined variable. 2010-08-10 23:18:42 -04:00
mark_story
5068d62473 Fixing issue that came up in rebasing. 2010-08-10 23:18:42 -04:00
mark_story
d01708b1ef Adding temporary $View property to controller until I figure out a better way to provide access for it. Test case updated to reflect View not being in the registry anymore. 2010-08-10 23:18:42 -04:00
mark_story
07a7e18dc7 Removing ClassRegistry access in RssHelper. 2010-08-10 23:18:41 -04:00
mark_story
65c235023d Removing ability to register View and ThemeView into ClassRegistry. 2010-08-10 23:18:41 -04:00
mark_story
dfa5273b22 Making SessionHelper not use ClassRegistry to access View. SessionHelper still needs to not inherit from CakeSession. 2010-08-10 23:18:41 -04:00
mark_story
576eba3ef9 Removing ClassRegistry use from FormHelper and its test case. 2010-08-10 23:18:41 -04:00
mark_story
90b0ac7258 Removing remaining ClassRegistry::getObject() in HtmlHelper. 2010-08-10 23:18:41 -04:00
mark_story
7b3f2f7e6e Updating methods in Helper to use $this->_View. 2010-08-10 23:18:41 -04:00
mark_story
7efe1636aa Making HtmlHelper not use ClassRegistry to access the View instance. Updating test cases. 2010-08-10 23:18:41 -04:00
mark_story
19f008b1a4 Fixing broken tests in HelperCollectionTest
Moving unload into ObjectCollection as its common between 2 child classes, and possibly a 3rd.
2010-08-10 23:18:40 -04:00
mark_story
426d35d66e Fixing string that got changed in a rebase. 2010-08-10 23:18:40 -04:00
mark_story
0f5e881f26 Fixing typo. 2010-08-10 23:18:40 -04:00
mark_story
7b4916e16a Updating AclComponent to new Component API. 2010-08-10 23:18:40 -04:00
mark_story
a4e2f7c55f Updating intialiize() callbacks. Moving $this->_set() int Component::__construct as all the core components did it. Updating constructors and including parent calls. 2010-08-10 23:18:40 -04:00
mark_story
052c81774c Removing some code duplication. 2010-08-10 23:18:40 -04:00
mark_story
22fbc24560 Adding 'collectReturn' option to ObjectCollection::trigger. lets a callback collect the return of each object and return that.
Adding tests.
2010-08-10 23:18:40 -04:00
mark_story
fac97738ce Making Controller use ComponentCollection. 2010-08-10 23:18:39 -04:00
mark_story
256532b8e4 Updating Components to use Component as the parent class. 2010-08-10 23:18:39 -04:00
mark_story
bf75ab5737 Starting to update Component into a base class instead of a loader class. 2010-08-10 23:18:39 -04:00
mark_story
3666643b84 Adding ComponentCollection and a test case. 2010-08-10 23:18:39 -04:00
mark_story
337ab19145 Updating ObjectCollection::trigger() so it doesn't call __get().
Updating HelperCollection test which was passing by coincidence.
2010-08-10 23:18:39 -04:00
mark_story
62019888ba Changing file headers to reflect accurate licences and versions created. 2010-08-10 23:18:39 -04:00
mark_story
c44c276fa3 Removing ModelBehavior::dispatchMethod(), replacing with call_user_func_array() as its faster and the php4 workaround is no longer needed. 2010-08-10 23:18:39 -04:00
mark_story
409b12954b Simplifying logic and data structures used to store enabled-ness of objects in an object collection. 2010-08-10 23:18:39 -04:00
mark_story
b2250852e4 Moving BehaviorCollection into its own file.
Changing how behaviors are stored in the collection object.  Makes it work the same as HelperCollection.
2010-08-10 23:18:39 -04:00
mark_story
fcbfb556c5 Moving loaded helpers into a protected array.
Adding magic methods to access the object array.
2010-08-10 23:18:39 -04:00
mark_story
c78e869be6 Removing PHP4 workarounds in BehaviorCollection.
Making BehaviorCollection throw exceptions instead of use cakeError.
2010-08-10 23:18:39 -04:00
mark_story
d048813af8 Adding in property copying until this branch gets merged with 2.0-request. 2010-08-10 23:18:39 -04:00
mark_story
6a88452072 Updating TextHelper to not use create_function(). The create_function calls leaked memory and didn't work with the new helper constructors. 2010-08-10 23:18:38 -04:00
mark_story
4672cee5d3 Removing dispatchMethod from JsHelper, its not really that useful, and is good at hiding bugs in mock tests.
Updating test cases.
2010-08-10 23:18:38 -04:00
mark_story
0e933e8893 Updating most helper test cases to use View in their constructors. 2010-08-10 23:18:38 -04:00
mark_story
68ff2e5ce5 Adding additional tests for Helper lazy loading. 2010-08-10 23:18:38 -04:00
mark_story
fc3379767d Moving methods around. ObjectCollection now normalizes helpers arrays. Plugin helpers now lazy load.
Tests updated.
2010-08-10 23:18:38 -04:00
mark_story
98982a6f7a First attempt at lazy loading helpers done. Plugin support not complete. 2010-08-10 23:18:38 -04:00
mark_story
ab815a53ba Helper test case is passing again. 2010-08-10 23:18:37 -04:00
mark_story
087ccabffe Starting to modify Helper constructors. 2010-08-10 23:18:37 -04:00
mark_story
1d983e1cd4 Making MissingView and MissingLayout cake errors into exceptions. 2010-08-10 23:18:37 -04:00
mark_story
a23207791a Modifying View to accept HelperCollection. Removing methods that are no longer needed. 2010-08-10 23:18:37 -04:00
mark_story
f8ecb10407 Adding stub callbacks so errors aren't generated. 2010-08-10 23:18:37 -04:00
mark_story
c15d228515 Initial integration of HelperCollection into View. 2010-08-10 23:18:37 -04:00
mark_story
16d5b2655c Adding a way to load helpers in a disabled state. Updating tests and subclasses. 2010-08-10 23:18:37 -04:00
mark_story
d0de468ce0 Removing options that were not used in the generic application. 2010-08-10 23:18:37 -04:00
mark_story
aa61a251dc Deprecating BehaviorCollection::attach() and BehaviorCollection::detach(). load() and unload() are more generic and make sense in other contexts.
Adding base trigger implementation.
Adding tests for helper triggering.
2010-08-10 23:18:37 -04:00
mark_story
9fd881cb00 Moving methods down and adding some tests. 2010-08-10 23:18:36 -04:00
mark_story
6db3dbc680 Starting to create HelperCollection which will be responsible for loading and constructing helpers.
Making an abstract class that will be the base of all object collections.
Adding test cases.
2010-08-10 23:18:36 -04:00
mark_story
da9c0da626 Changing sql_dump element so it only shows if there is no $logs variable set in the view. Overwriting it could adversely effect helper references. Fixes #998 2010-08-10 23:09:27 -04:00
mark_story
1371cefc3d Applying patch from 'thatcode' to fix an issue where FormHelper::datetime() would not use 'default' or 'value' keys like other inputs would. This corrects an unintentional inconsistency in the methods. Test cases added. Fixes #988 2010-08-09 23:49:18 -04:00
mark_story
29ddffa2d3 Fixing regression in DboMysqlBase where describe() was no longer pulling out fieldParameters. A test case has been added to catch any future regressions. Fixes #991 2010-08-09 23:25:32 -04:00
mark_story
ccfb1d179a Expanding test and fixing issue where the return of Folder::create() would be incorrect even though the directory was properly created. Fixes #996 2010-08-09 22:56:41 -04:00
mark_story
d6e3c318cd Merge branch '1.3' of github.com:cakephp/cakephp into 1.3 2010-08-04 23:59:17 -04:00
mark_story
a04fe5f81d Making Router::reverse() strip out additional framework internal parameters that are specific to requestAction. Refs #977 2010-08-04 23:35:49 -04:00
xbuzz
f2f2987743 Fixed 'convertEntities' to links in RSS. Fixes #959 2010-08-04 22:03:44 -03:00
Dirk Brünsicke
712ca6d5b5 Fixing bug in String::insert that produces unexpected results with
multiple keys that start with the same substring. Fixes #984

Signed-off-by: mark_story <mark@mark-story.com>
2010-08-03 22:38:45 -04:00
José Lorenzo Rodríguez
7e1426e743 Fixing doc block 2010-08-02 19:25:04 -04:30
José Lorenzo Rodríguez
e7c7008781 Changing behavior of RequestHandlerComponent::responseType(), it will return the current content type set int the response object
It will not return null as default as it did prior 2.0
2010-08-02 19:21:52 -04:30
José Lorenzo Rodríguez
1acbf15c00 Removing RequestHandlerComponent::_header() method 2010-08-02 19:17:43 -04:30
José Lorenzo Rodríguez
cb63cd171c Fixing typo 2010-08-02 19:12:58 -04:30
José Lorenzo Rodríguez
bbbb81e10a Adding CakeResponse::download() method 2010-08-02 19:10:38 -04:30
José Lorenzo Rodríguez
5fb320f31d Refactoring RequestHandler methods to use the response object 2010-08-02 19:10:01 -04:30
José Lorenzo Rodríguez
4fd032bc10 Refactoring RequestHandlerComponent::mapType() and added response object property to the component 2010-08-02 19:07:26 -04:30
José Lorenzo Rodríguez
040740c05d Changing the order for comparisson checking on some types, when looking for a mime type 2010-08-02 19:04:53 -04:30
Juan Basso
ae2fa908c5 Dont use private attributes as tables in CakeSchema. Fixes #7 2010-08-02 00:22:46 -03:00
mark_story
3099a15f17 Removing old check for view == 'Theme'. This allows Scaffold to work well with Themed controllers. Test case added. Fixes #255 2010-08-01 22:25:29 -04:00
José Lorenzo Rodríguez
87eb1ec697 Adding the ability to add custom content types to CakeResponse 2010-08-01 14:22:02 -04:30
José Lorenzo Rodríguez
077f71aaa1 Refactoring controller rendering to use the CakeResponse object 2010-08-01 01:38:45 -04:30
Juan Basso
7e7a2c57e2 Fixing changes made in commit 522446e to works with PHP 5.2-. Refs #974 2010-08-01 02:55:30 -03:00
José Lorenzo Rodríguez
0824348db1 Removing Controller::output property and refactoring methods to not use it. CakeResponse::body() should be used instead 2010-08-01 01:13:41 -04:30
José Lorenzo Rodríguez
f9c97383e9 Refactored Controller::disableCache() to use the CakeResponse object, method was also deprecated 2010-08-01 00:16:50 -04:30
José Lorenzo Rodríguez
60f504a470 Refactored Controller::header() to use the CakeResponse object, deprecated Controller::header() and Controller::httpCodes() 2010-08-01 00:13:00 -04:30
José Lorenzo Rodríguez
9d104fee73 Refactoring Controller::redirect() to use the CakeResponse object 2010-08-01 00:10:46 -04:30
José Lorenzo Rodríguez
3ab4e09e11 Moving Controller::httpCodes() to CakeResponse 2010-08-01 00:09:09 -04:30
José Lorenzo Rodríguez
abafdb037b Implementing the CakeResponse::compress() method 2010-07-31 19:30:25 -04:30
José Lorenzo Rodríguez
8780f0b33d Implementing CakeResponse::cache() 2010-07-31 18:31:50 -04:30
José Lorenzo Rodríguez
5ba0e43aa3 Implementing CakeResponse::disableCache() 2010-07-31 17:40:49 -04:30
José Lorenzo Rodríguez
20d1e483cc Implementing and tesing CakeResponse::send() 2010-07-31 16:58:13 -04:30
José Lorenzo Rodríguez
d1808db0df Changing the encoding method for "charset" 2010-07-31 14:40:58 -04:30
José Lorenzo Rodríguez
2a4b30dba9 Implementing CakeResponse::header() method 2010-07-31 14:13:21 -04:30
mark_story
509a9e14e2 Fixing condition missing a model name in the TreeBehavior. Fixes #961 2010-07-31 14:29:00 -04:00
José Lorenzo Rodríguez
a2eac24ec0 Removing second parameter from CakeResponse, the response should not be magical 2010-07-31 13:10:37 -04:30
José Lorenzo Rodríguez
159ac2038e Testing remaining implemented methods 2010-07-31 13:04:53 -04:30
mark_story
9f718de0b6 Reverting changes made in [60ab9800e2]. Restoring use of isset() and $_SESSION = null. Fixes #971 2010-07-31 13:09:40 -04:00
mark_story
522446e0c2 Fixing issues where route elements could not have '-' in the parameter name because of limitations in pcre named capturing subpatterns. Tests added. Fixes #974 2010-07-31 13:03:45 -04:00
José Lorenzo Rodríguez
2c7b21b977 Completinng mime types array 2010-07-31 12:33:39 -04:30
José Lorenzo Rodríguez
f432de830c Implementing some function in the response object, adding test case 2010-07-31 12:33:02 -04:30
mark_story
2b1efafe65 Applying optimization from 'michaelc' to reduce number of strtolower() calls in AclBehavior. Fixes #972 2010-07-29 22:04:22 -04:00
José Lorenzo Rodríguez Urdaneta
ffd7066fa4 Adding the CakeREquest object with initial function signatures and parameters 2010-07-29 00:54:16 -04:30
Juan Basso
527446a3d1 Changing the RequestHandler to use new Xml class. 2010-07-28 21:29:12 -03:00
Juan Basso
53f8353f92 Updating Set to use new Xml class. 2010-07-28 19:53:52 -03:00
Juan Basso
b862d68016 Support to namespaces in Xml::toArray. 2010-07-28 19:46:35 -03:00
Juan Basso
f4d5230dfa Fixing the read for toArray of content when have child or attribute in xml. 2010-07-28 18:53:36 -03:00
Juan Basso
8f1bdd5378 Change to RssHelper use Xml class instead XmlHelper. 2010-07-28 17:47:02 -03:00
ADmad
6527e9269a Fixing detection and automatic appending of extension '.js' to urls in call to HtmlHelper::script(). Closes #965 2010-07-29 02:11:00 +05:30
José Lorenzo Rodríguez Urdaneta
69ee014a60 Merge branch '2.0' into 2.0-session 2010-07-27 22:27:17 -04:30
José Lorenzo Rodríguez Urdaneta
1c8ad1d1cc Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2010-07-27 22:26:06 -04:30
José Lorenzo Rodríguez Urdaneta
4c71dd845e Merge remote branch 'origin/2.0' into 2.0-request
Conflicts:
	cake/libs/controller/components/auth.php
	cake/tests/cases/libs/controller/components/auth.test.php
2010-07-27 22:02:08 -04:30
mark_story
272b327dc3 Fixing issue where $error would be set to an array. 2010-07-27 22:27:44 -04:00
mark_story
19d8c9e6bb Removing a call to __setError() that isn't an error. 2010-07-27 22:27:44 -04:00
mark_story
8db0a19585 Refactoring duplicated logic into a method. 2010-07-27 22:27:44 -04:00
mark_story
ef586d9917 Updating test case to use autoRegenerate. 2010-07-27 22:27:43 -04:00
mark_story
6ff7ad68c9 Fixing some infinite loop issues in the test cases for CakeSession. 2010-07-27 22:27:43 -04:00
mark_story
b3febb483e Fixing incorrect use of Cache::gc(). It has no parameters for now. 2010-07-27 22:27:43 -04:00
mark_story
81f6f43193 Moving a few things around to better replicate how CakeSession behaved in 1.3. Also fixes the countdown & session id regeneration feature. Still need to write a test case for it though. 2010-07-27 22:27:43 -04:00
mark_story
d2097c514f Fixing issue where infinite loops would occur when a session was first created. 2010-07-27 22:27:43 -04:00
mark_story
977ffa96be Removing dead properties and methods from SessionComponent.
Sessions should be started as soon as the component is constructed. So there is no reason to have an active()/activate() method.
2010-07-27 22:27:43 -04:00
mark_story
574bfe6b67 Changing clear of $_SESSION to null instead of array(), makes checks later easier. Removing _checkValid call from destroy and making it run in start(), as destroy() calls start(). 2010-07-27 22:27:43 -04:00
mark_story
db5c44e386 Adding support + test cases for plugin and app/libs session handlers. 2010-07-27 22:27:42 -04:00
mark_story
18b6668a34 Moving tests from SessionComponent to CakeSession, as that is where the features actually are. Removing Security.level/Security::inactiveMins() calculations. 2010-07-27 22:27:42 -04:00
mark_story
28b9ed7264 Adding test cases for DatabaseSession and fixing a test case in CacheSession. 2010-07-27 22:27:13 -04:00
mark_story
951eeae817 Extracting handler location into a method.
Moving DatabaseSession and CacheSession into separate files.  Tests to come soon.
2010-07-27 22:27:13 -04:00
mark_story
49397c74af Making cache config used for cache session storage configurable. 2010-07-27 22:27:13 -04:00
mark_story
f5d81e53fc Refactoring Cache and Database session handlers into a separate class, and adding an interface for custom session handlers. Tests updated. 2010-07-27 22:27:13 -04:00
mark_story
a8b05c2fbc Adding a check for '' and failure. When trying to Cache '', FileEngine will return false. This shouldn't trigger an error inside Cache. 2010-07-27 22:27:12 -04:00
mark_story
339fa29502 Updating CakeSession test case and fixing a few issues in the default settings. 2010-07-27 22:27:12 -04:00
mark_story
b247559e9e Starting to implement new session configuration setup. Test case updated. 2010-07-27 22:27:12 -04:00
predominant
7501fcf46d Add test for empty read() calls on CakeSession 2010-07-27 22:27:12 -04:00
predominant
ca65689dd9 Change _setHost() on CakeSession to accept parameter to ease testing, add test cases for host setting, and port stripping. 2010-07-27 22:27:12 -04:00
predominant
a63474a54d Add test for path containing question, and fix assignment of CakeSession::path 2010-07-27 22:27:12 -04:00
predominant
f5565895e9 Removing __regenerateId method, and moving code to renew(). 2010-07-27 22:27:11 -04:00
predominant
afede663c0 Reducing redundant code for CakeSession. 2010-07-27 22:27:11 -04:00
predominant
725bfc3e12 Create _setPath() and _setHost to simplify startup. 2010-07-27 22:27:11 -04:00
mark_story
4b65ebd64f Making SessionComponent mostly a wrapper for CakeSession.
Adding CakeSession::begin() to replace SessionComponent::__start().
Tests updated.  Tests related to autoStart were removed/skipped as that feature isn't really around right now.
2010-07-27 22:27:11 -04:00
mark_story
e660416545 Making CakeSession::write() able to write hashes of data. 2010-07-27 22:26:03 -04:00
predominant
4e9d76e806 Fixing session write use issue. 2010-07-27 22:26:03 -04:00
predominant
dd3e0facd2 Trim down CakeSession::started() 2010-07-27 22:26:03 -04:00
predominant
db97df31cd Adding static to regen 2010-07-27 22:26:03 -04:00
predominant
1dd02b77b2 Adding static to destroy() 2010-07-27 22:26:03 -04:00
mark_story
f47ee0d29a Making CakeSession destory() make started() not return true. Fixing tests that tried to modify session config while a session was active. 2010-07-27 22:26:03 -04:00
mark_story
daab018777 Removing code for PHP < 5.1 which is not supported by 2.0 2010-07-27 22:26:03 -04:00
mark_story
1938e57cbc Making userAgent check test pass.
Reformatting code inside valid().
2010-07-27 22:26:02 -04:00
predominant
b60b077056 Fix __startSession being called after method rename to _startSession. 2010-07-27 22:26:02 -04:00
predominant
34a6808d5d Move CakeSession database configuration to separate method, cutting down init(). 2010-07-27 22:26:02 -04:00
predominant
632d1f13ae Minor refactor for CakeSession. 2010-07-27 22:26:02 -04:00
predominant
9bddd9a861 Minor refactor of if()'s 2010-07-27 22:26:02 -04:00
predominant
06f9d748e2 Fix session path/base for init() 2010-07-27 22:25:37 -04:00
predominant
16f4899821 Fix destroy() calling old constructor on CakeSession 2010-07-27 22:25:37 -04:00
predominant
ea7d45cb11 Remove unset() 2010-07-27 22:25:37 -04:00
predominant
b0e4a09d38 Rename constructor to init() and add init() call at bottom of CakeSession. 2010-07-27 22:25:37 -04:00
predominant
86a7263ab5 Fix cookielifetime variable declaration for CakeSession. 2010-07-27 22:25:37 -04:00
predominant
913d54caa0 Remove __start from SessionHelper 2010-07-27 22:25:37 -04:00
predominant
04b67e59fc Fix tests to remove checking of session ID directly on Session Helper. 2010-07-27 22:25:37 -04:00
predominant
17688a6002 Chaned CakeSessn o use static approache. 2010-07-27 22:25:37 -04:00
predominant
0a72de6438 Removing @access doc block lines from CakeSession. 2010-07-27 22:25:05 -04:00
predominant
58c94b8578 Add access to started() on CakeSession. 2010-07-27 22:25:05 -04:00
predominant
c8c677ae9e Change SessionHelper to extend AppHelper instead of CakeSession. 2010-07-27 22:25:05 -04:00
predominant
390274f807 Remove function exists check on session_write_close() 2010-07-27 22:25:05 -04:00
mark_story
d81d33ffe6 Adding some additional documentation for Model::find(). Fixes #952 2010-07-27 21:25:31 -04:00
Juan Basso
df12e5b4ab Removing @static and @access from Xml class. 2010-07-26 23:44:31 -03:00
Juan Basso
5de7fa5930 Adding PHP Doc to XML class. 2010-07-26 23:42:05 -03:00
Juan Basso
43d49095ae Removing xml helper. Use SimpleXML instead. 2010-07-26 21:39:45 -03:00
Juan Basso
294bef6c46 Refactory of Xml class. Now uses SimpleXMLElement to manipulate XML data. 2010-07-26 21:31:39 -03:00
mark_story
d38857095a Merge branch '1.3' into 2.0
Conflicts:
	cake/libs/model/model.php
	cake/libs/validation.php
	cake/libs/view/helpers/ajax.php
	cake/tests/cases/libs/controller/components/session.test.php
2010-07-24 22:34:42 -04:00
José Lorenzo Rodríguez Urdaneta
e47a464d63 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2010-07-24 15:22:12 -04:30
José Lorenzo Rodríguez Urdaneta
1cfcec9a1a Removin use of File class in favor of SplFileObject 2010-07-24 15:21:14 -04:30
ADmad
91b0a4ba4f Changing Tree behavior's function names to be camel cased as per convention 2010-07-24 23:32:49 +05:30
mark_story
43127caad2 Making Cache::write() trigger warnings when a cache engine returns false from a write. Tests added. Fixes #877 2010-07-23 21:40:57 -04:00
José Lorenzo Rodríguez Urdaneta
88ea68af96 Using keyword self instead of Configure, removing use of File class in favor of SplFileObject 2010-07-23 18:42:30 -04:30
Juan Basso
5b7b2d074e Putting the port in header Host, following RFC 2616 item 14.23. Fixes #947. 2010-07-23 00:13:19 -03:00
mark_story
572f79be67 Fixing failing tests caused by strtolower() in AuthComponent. 2010-07-20 23:44:25 -04:00