Commit graph

4822 commits

Author SHA1 Message Date
mark_story
9c860d2ce8 Changing how CakeLog registers itself as the error handler, this fixes issues with e-accelerator on some platforms. Fixes #1597, fixes #1087 2011-03-19 08:54:07 -04:00
ADmad
0f341c7114 Fixed bug where default class name 'checkbox' was dropped in case of validation error for div wrapping checkbox for multiple checkboxes 2011-03-11 20:20:55 +05:30
mark_story
5bb173013e Adding doc block info for Cache::config. 2011-03-07 22:17:52 -05:00
Clément Hallet
e2b37d8ec9 Allow to disable cache gc. By using a falsey value for probability
you can disable cache gc calls.
2011-03-07 22:06:46 -05:00
mark_story
7853189328 Adding 'style' as a known html attribute. Fixes #1573 2011-03-07 21:58:11 -05:00
mark_story
2e76d32cf9 Fixing transposition of parameters to setLastError. Fixes #1570 2011-03-03 20:46:43 -05:00
mark_story
197c9bf912 Making empty string create empty submit buttons. This applies to both Form->submit() and Form->end(). Tests added. Fixes #1569 2011-03-02 20:27:57 -05:00
Ceeram
e9011badb5 Ensure both node() and afterSave() use ->name
Fixes #1564
2011-02-28 21:43:33 -05:00
mark_story
b80955c9fe Adding newlines to the builtin email template. Fixes issues with long lines. Refs #857 2011-02-25 18:50:50 -05:00
mark_story
e05c6cd83f Fixing issue where actions starting with a prefix but not followed by an _ would get mangled when going through router::url().
Fixes #1556
2011-02-24 16:43:13 -05:00
mark_story
139d6b3133 Changing the checks surrounding dataExpression to use empty() instead of isset() so unexpected things don't happen if you ever use dataExpression = false. Fixes #1521 2011-02-23 21:15:39 -05:00
mark_story
9367a10522 Merge branch '1.3' of github.com:cakephp/cakephp into 1.3 2011-02-23 21:07:10 -05:00
Juan Basso
52163b4b05 Allowing strings in cc and bcc. Fixes #1553. 2011-02-22 21:23:15 -03:00
Victor Widell
d0b7d3355d $this->data[$habtmKey] could be a string, meaning $this->data[$habtmKey][$habtmKey] would be the first character of that string. Probably not what you want.
Fixes #1549

Signed-off-by: mark_story <mark@mark-story.com>
2011-02-21 10:39:55 -05:00
0x20h
0e7f2efdb1 Fixing notice errors caused by accessing headers in po files that
don't exist. Fixes #1515

Signed-off-by: mark_story <mark@mark-story.com>
2011-02-16 22:13:51 -05:00
mark_story
42c2f3011b Applying fix from 'Mark Mitchell' to expose PeriodicalExecuter in the callback. Fixes #1529 2011-02-11 21:49:00 -05:00
mark_story
71f76080a2 Fixing issue where creating cookies in the beforeFilter would result in
cookies with the wrong expiry time. Thanks 'RabidFire' for the patch. Fixes #1523
2011-02-09 21:19:15 -05:00
mark_story
9a940709ab Removing unsupported options from PrototypeEngine. Fixes #1516 2011-02-07 20:59:01 -05:00
mark_story
584116524b Fixing range option for prototype engine. Fixes #1509 2011-02-07 19:19:50 -05:00
Juan Basso
f2a4b1e959 Supporting %e in windows. Fixes #1510. 2011-02-06 15:51:28 -02:00
mark_story
8d5e68d582 Fixing issue where habtm tables would not have the connection prefix removed when generating schema. Fixes #1180 2011-02-05 11:19:05 -05:00
mark_story
cf50cbdd9d Fixing issue in FormHelper where CURRENT_TIMESTAMP or other invalid data could cause a notice error. Fixes #1508 2011-02-05 06:43:00 -05:00
Phally
f3812342c2 Minor optimization for email linefeeds. 2011-01-31 00:15:56 +01:00
mark_story
6db8515e60 Fixing incorrectly nested sprintf + __ call. Refs #1305 2011-01-30 12:25:40 -05:00
Juan Basso
bbf6aedd9c Fixed wrong viewVars store when have objects in view caching. Fixes #1486. 2011-01-28 00:31:18 -02:00
mark_story
5464ed8455 Fixing blackholes caused by using custom name attributes with inputs. Fixes #1489 2011-01-27 21:05:30 -05:00
mark_story
71d8e744f1 Fixing case-sensitivity of AS in fields. Tests added. Fixes #1474 2011-01-26 20:58:16 -05:00
mark_story
d192ed32f0 Adding a socket key to DboMysqli::$baseConfig. Fixes notice errors when socket is undefined. Fixes #1482 2011-01-26 20:54:14 -05:00
mark_story
32f0b20a33 Removing wonky and most likely incorrect manipulation of socket and port
setting mangling in DboMysqli.  Fixes #1478
2011-01-24 22:05:16 -05:00
Joe Beeson
e58e3f3132 Fix to resolve 'assign by reference' errors when using a '__get' magic method.
Fixes #1476

Signed-off-by: mark_story <mark@mark-story.com>
2011-01-21 15:52:03 -05:00
mark_story
ed7f8d1906 Fixing issue where DboPostgres used the wrong type for boolean columns with a default of false or true.
Added a test case.
Changing Model::create() so it doesn't wipe out default values === false.
Fixes #1460
2011-01-21 13:31:33 -05:00
mark_story
9f583097f0 Updating version numbers for 1.3.7 2011-01-19 15:10:53 -05:00
Miah Gregory
6071788478 Updated documentation for Router::connect.
Fixed a few spelling issues as well.

Signed-off-by: mark_story <mark@mark-story.com>
2011-01-18 17:54:19 -05:00
mark_story
932533c5c8 Fixing incorrect content type headers from being set, when an action contains a requestAction to an action with a different Content-Type. Also populating RequestHandler->params as it was always empty.
Fixes #1445
2011-01-18 08:28:16 -05:00
mark_story
cfce0e45d3 Fixing issue where empty session id's would cause duplicate key errors. Empty session id sessions are no longer saved. Fixes #1450 2011-01-18 08:14:47 -05:00
mark_story
b0d4951184 Fixing TextHelper::autoLinkEmails() not linking email addresses that contain '.
Test added.
Fixes #1457
2011-01-17 11:11:30 -05:00
mark_story
ca299a097c Fixing issue where get forms created with model = false would create inputs with name = ''. Tests added. Fixes #1455 2011-01-15 14:39:24 -05:00
mark_story
b8780586ec Fixing issue where FormHelper::checkbox() would ignore an explicit checked = false, and use the post data instead. Test case added. Fixes #1437 2011-01-14 21:48:23 -05:00
mark_story
5f612b7833 Making memcache cache adapter, set the expiry time of any value greater than 30 days to never expire. This works around the 30 day limitation of the PHP extension. Test case added. Fixes #1451 2011-01-13 20:27:10 -05:00
mark_story
0f4c90588d Fixing issue where elements did not get .ctp as a fallback extension unlike view and layout files.
Adding a protected method to get extensions, as it would be in 3 places now.
Added tests.
Fixes #1438
2011-01-12 20:43:41 -05:00
mark_story
f893e3b63b Applying patch from 'ryandesign' fixing incorrect datetime formats. Fixes #1441 2011-01-11 20:16:42 -05:00
mark_story
4f94b715ec Revert "Fixing Set::filter() not predictably filtering in a recursive
fashion.  While a minor change in behavior, more predictable and uniform
behavior is worth it." Refs #1431

This reverts commit 6e2ffafe54.
2011-01-09 22:29:10 -05:00
mark_story
8754d11aed Adding EmailComponent::_getSocket() so EmailComponent + smtp is easier to test.
Fixing issue where hosts with portnames could cause smtp emails to fail.
Added tests, fixed an existing test to not depend on a local mailserver.
Fixes #1433
2011-01-06 23:10:01 -05:00
mark_story
f45f2e4096 Making niceShort() compare the original dateString and userOffset. This fixes issues where timezone differences would cause the incorrect short form to be displayed. Fixes #1331 2011-01-05 22:53:56 -05:00
mark_story
6e2ffafe54 Fixing Set::filter() not predictably filtering in a recursive fashion. While a minor change in behavior, more predictable and uniform behavior is worth it.
Fixes #1431
2011-01-05 22:48:09 -05:00
mark_story
5092013304 Making EmailComponent register and un-register its view object, when rendering email templates. This allows helpers to use the view to do additional processing. Fixes #442 2010-12-27 15:12:27 -05:00
mark_story
c5c638e8f5 Fixing option documentation. 2010-12-27 10:40:50 -05:00
mark_story
56415f20cb Fixing issue where CakeLog would log suppressed errors even when error reporting was disabled. Fixes #1403 2010-12-26 13:02:43 -05:00
mark_story
04929ae1df Applying patch from 'Thorsten Buss'.
Fixes issues in DboSource, where mismatching types on join columns could result in incorrect query generation.
Fixes #708
2010-12-21 20:40:19 -05:00
Juan Basso
5d2b4c758d Minor optimization in cache views. 2010-12-18 19:41:57 -02:00
Juan Basso
a7c7436d8e Passing viewVars to cache views, avoiding cake:nocache problems. 2010-12-18 19:31:10 -02:00
Jeremy Harris
7416e58759 Allowed comma-delimited list in smtp $to var to be consistent with standard mail delivery. Fixes #1353 2010-12-14 20:55:34 -08:00
mark_story
53a687049c Fixing encoding of address aliases. They are now mime-encoded like other headers. Tests added. Fixes #1360 2010-12-13 23:23:02 -05:00
mark_story
5ffc84d28a Calling parent constructors in helpers that have it omitted. Fixes #1359 2010-12-12 21:14:30 -05:00
mark_story
a830632071 Changing View::element() to not overwrite viewVars with helpers that
have the same name.
Test added.
Fixes #1354
2010-12-09 22:06:23 -05:00
jblotus
48f32a11e0 Fixed incorrect docblock. Fixes #1350
Signed-off-by: mark_story <mark@mark-story.com>
2010-12-08 22:08:43 -05:00
mark_story
7024d14c74 Removing private annotations for File::__construct() and File::__destruct() as its just not true. This also prevents them from being included in the API docs. 2010-12-05 18:41:26 -05:00
Graham Weldon
1dbed85979 Append Controller to error class name for isAuthorized() not implemented. 2010-12-04 22:14:33 +11:00
mark_story
44b09171ef Adding unicode letters and numbers to url path segment regex.
Test case added.
Fixes #1284
2010-12-01 23:47:30 -05:00
Marko Marković
c55a57927c Typos in documentation: reguired -> required 2010-12-01 08:12:25 +11:00
ADmad
1186bc56f1 Adding EmailCompnent::lineFeed property toallow overriding the default line feed string when using mail() function to send mail. Closes #1320 2010-11-27 02:11:43 +05:30
mark_story
15ca2400bc Fixing issue in DboSource::name() where special characters in column names would not be correctly quoted.
Tests added.
Fixes #1264
2010-11-25 06:52:23 -05:00
mark_story
7d158e8d1f Fixing Set::sort() for arrays with out of sequence, or missing keys.
Tests added.
Fixes #1312
2010-11-25 06:39:08 -05:00
mark_story
4214242efd Adding test for correct merge order for $uses.
Fixing incorrect merge ordering for $uses, so it matches historical behaviour.
Fixes #1309
2010-11-24 22:44:12 -05:00
mark_story
0e29567f8d Adding an array cast to fix issues where users could modify cookie
values causing iteration errors.  Fixes #1309
2010-11-24 22:09:08 -05:00
mark_story
d5fb0b25cb Fixing issue where Date header would be missing from Emails sent by
EmailComponent.
Adding user configurable field for date.
Test cases added.  Fixes #1304
2010-11-22 22:08:46 -05:00
mark_story
d9484c109f Merge branch '1.3' of github.com:cakephp/cakephp into 1.3 2010-11-22 21:29:33 -05:00
mark_story
d0d16a7eda Fixing i18n extraction errors in Scaffold. Fixes #1305 2010-11-22 21:29:11 -05:00
mark_story
bf10723f89 Applying patch from 'michealc' to fix duplicated comments. Fixes #1306 2010-11-22 21:21:55 -05:00
mark_story
f48811a2ff Moving include up so its not buried deep inside the class. 2010-11-22 21:15:02 -05:00
mark_story
244de1df85 Adding a comment about the messageId property and shells. Refs #1303 2010-11-22 13:01:14 -05:00
mark_story
79aafda698 Removing use of serialize() for locked fields. This removes any
possible exploit related to serialize()/unserialize().  Instead values
are passed as | delimited.
2010-11-21 00:09:45 -05:00
mark_story
ae7855692d Removing unserialize() as its dangerous. Instead using | delimited fields for locked fields. This totally avoids issues with serialize(). Removing str_rot13, as its only child proof.
Tests updated.
2010-11-20 23:42:54 -05:00
mark_story
6d9b000aee Changing how mergeVars are handled, so the difference of app/current is used as a base.
Also fixing issues where passing settings to helpers in AppController could result in them not being correctly merged.
Thanks to hashmich for the partial patch.
Fixes #1183
2010-11-20 22:34:24 -05:00
mark_story
e0a8ffe8a3 Applying patch from 'jmccaffrey' to fix issues on windows where virtual
machine paths would not be correctly handled.  Fixes #1254
2010-11-20 13:26:30 -05:00
PhpNut
82d46067ab Corrected doc comment. 2010-11-17 15:00:27 -06:00
PhpNut
bed7767258 Removing __cache property that can be altered outside of the class definition.
Adding __resetCache() as a replacement for checking if cache should be reset and written.
2010-11-17 14:02:35 -06:00
mark_story
5349257bbd Changing empty() to !isset() to avoid additional cache hits when po files are missing or empty. 2010-11-16 07:32:14 -05:00
mark_story
4c3337598e Updating version numbers for 1.3.6 2010-11-13 20:01:20 -05:00
mark_story
e8678b38ac Adding specific conditions to model->delete's call to dbo->delete. This
helps fix a race condition where dbo->defaultConditions could cause
additional data loss.  Fixes #250
2010-11-08 21:50:45 -05:00
Ceeram
bc7770aa83 removing useless calls to mapActions()
Signed-off-by: mark_story <mark@mark-story.com>
2010-11-07 23:16:41 -05:00
mark_story
e431e86aa4 Fixing issue found by Felix Wilhelm(flxm) where users could send potentially dangerous or corrupted serialized objects to SecurityComponent, potentially allowing manipulation of file map caches. Test case added. 2010-11-07 20:53:04 -05:00
ADmad
eb76ab95f2 Fixed issue where Model::saveAll() would incorrectly commit a transaction which was not started in that function call itself. 2010-11-06 09:33:50 +05:30
mark_story
d56b812181 Fixing issue where an array to string conversion error could occur if you had multiple values for a model's primary key and you created a matching form. Tests added.
Fixes #1257
2010-11-04 21:08:40 -04:00
mark_story
d1403b0da8 Changing NumberHelper::currency() to format < 1euro based on the suggestions from 'Joel Haasnoot'. Instead of 99c you will get €0,99.
Test cases updated.  Fixes #1253
2010-11-02 21:56:24 -04:00
Mark Story
e6aeae8935 Fixing issue where value in difference array was always the string value instead of the original value. 2010-10-31 22:44:45 -04:00
Mark Story
b86bec14b5 Removing dead code in EmailComponent.
Fixes #1248
2010-10-31 00:00:54 -04:00
Mark Story
d5f582beee Merge branch 'master' of http://github.com/kwiky/cakephp into kwicky 2010-10-30 00:29:21 -04:00
mark_story
f5fd069583 Applying patch from 'Justas Butkus' to fix CakeSchema::compare()
Fixes issues with comparing null == '' and adds a new protected method to handle null aware array difference generation.
Tests added.
Fixes #1206
2010-10-27 23:03:31 -04:00
Steve Grosbois
bc3a9e8a3a Removing a dot at the end of a message in mission_action.ctp because there is no dot in the same message in all other errors view, this can help for traductors 2010-10-25 11:43:03 +02:00
SKAhack
23f1c8e1c7 Fix regex match when regex included meta characters
Signed-off-by: mark_story <mark@mark-story.com>
2010-10-24 21:42:04 -04:00
Graham Weldon
d3e0ddbb0e Update copyright years. 2010-10-25 07:58:22 +11:00
mark_story
a16f4c5248 Updating version numbers for 1.3.5 2010-10-24 13:56:45 -04:00
mark_story
7c296211ef Making generating schema for connections with prefixes work correctly. The prefix needs to be removed so that when tables are created or updated they do not get the prefix added twice.
Moving tests around. Fixes #1180
2010-10-20 23:17:04 -04:00
mark_story
498417203b Making DboSource::fields() use cacheMethod() so it respects $cacheMethods.
Test added.
Fixes #1211
2010-10-20 22:28:31 -04:00
mark_story
077d1c5ad5 Applying patch from 'hashmich' to fix issues with slideUp and slideDown effects in prototype engine.
Tests updated.
Fixes #1213
2010-10-20 22:07:53 -04:00
ADmad
ffc77aa588 Adding "function_exists" check before using "ini_set" in Debugger::__construct(). Fixes #1209 2010-10-20 02:16:17 +05:30
mark_story
1c25e627ad Applying patch from 'Mark Mitchell' fixes issues with sending Email via smtp. Which were incorrect based on previous patches given for ticket #1100.
Fixes #1205, Fixes #1204
2010-10-18 22:06:12 -04:00
mark_story
61864a3b76 Adding some missing documentation and cleaning up code inside FormHelper::select(). 2010-10-16 13:40:27 -04:00
mark_story
c35ef7dbab Making class attribute bubble down into FormHelper::__selectOption().
Fixes issue where you couldn't change the classname of checkbox options.
Fixes #1202
2010-10-16 13:32:04 -04:00