Commit graph

294 commits

Author SHA1 Message Date
nate
badfb42c6a Fixing issue with file upload inputs not being factored into form security hash, closes #5489
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7678 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-29 16:23:39 +00:00
mark_story
bf3e254987 Removing secure() from FormHelper::submit(). Removes creation of multiple _Token inputs when multiple submit buttons are created. Fixes #5490.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7677 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-29 01:58:27 +00:00
nate
eb7fb6d7e3 Re-implementing form hashing security to using string-based keying. Fixes #5262, fixes #5300
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7658 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-24 23:02:14 +00:00
nate
80c1950530 Refactoring FormHelper security token generation, fixing code formatting
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7639 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-21 04:06:37 +00:00
phpnut
8ae5866a1c Additional optimization refactoring
Removed ability to use deprecated / with plugin, helper, etc combinations. The dot notation is only allowed from this point forward.
Corrected tests for the above changes.
Corrected formating in basics.php

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7623 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-18 03:09:19 +00:00
mark_story
c58e58a491 Adding tests for secured forms. Fixes the issues related to checkboxes in multi row forms.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7533 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-29 03:11:35 +00:00
mark_story
c4b4c25402 Removed BOM from form.php. Closes #5317
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7497 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-25 14:57:37 +00:00
mark_story
792863a3b4 Adding test to illustrate #5302. Corrected Error in doc block. Closes #5302
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7487 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-22 17:50:32 +00:00
nate
6f660812ca Adding FormHelper security token patch from renan.saddam, fixes #5061, adding test to disprove #2729 (FormHelper::input() and float fields)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7486 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-22 16:05:34 +00:00
mark_story
a180071f6c FormHelper::checkbox() now sets name of hidden field when name option is set. Closes #5224
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7449 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-09 22:08:17 +00:00
mark_story
9e51a64f87 Adding additional doc block explanations for method options.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7446 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-08 12:29:49 +00:00
nate
0119c0d46f Fixing HTML entity escaping in helpers, fixing broken XmlHelper test, all helper tests now passing
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7403 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-01 04:53:16 +00:00
TommyO
b6e9888753 Replaced all instances of ife() in /cake
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7387 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-30 20:34:01 +00:00
DarkAngelBGE
1052d21522 fixing broken tests in FormHelper, closes #5088
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7379 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-30 13:40:59 +00:00
phpnut
ed0a031ec4 Adding correct test cases for #5046 showing proper prefix usage, closes #5046 as invalid
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7323 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-05 14:48:09 +00:00
phpnut
30a49a39e4 Fixes #5016, Security->disabledFields not working properly. Empty value arrays needed to be unset
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7314 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-05 10:10:19 +00:00
mark_story
c25ed9016a Fixed attributes being set for select elements in formHelper::dateTime() when $options[id] is specified. Closes #5013.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7306 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-03 00:46:42 +00:00
gwoo
7ad1790ea2 removing and moving deprecated code
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7285 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-27 06:19:04 +00:00
gwoo
67f55ba53e fixes #3869, required css for validation fields
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7242 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-23 00:07:33 +00:00
gwoo
4759a4506b better fix for #3869
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7240 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-22 19:31:44 +00:00
gwoo
d29883993e fixes #3869, form 'required' CSS when not actually required
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7239 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-22 19:16:34 +00:00
nate
f7a4858503 Correcting coding standards violations
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7220 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-20 11:57:56 +00:00
gwoo
9d950c7698 closes #4726, test cases added to show special characters in select options
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7189 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-14 21:48:57 +00:00
gwoo
8707c6861a fixes #4912, correct label "for" in time input
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7188 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-14 21:40:01 +00:00
joelmoss
8b122d5480 OOps! Fixing typo from last commit.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7067 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-30 16:06:49 +00:00
joelmoss
d294e91d42 Fixing PHP error with $divOptions in FormHelper::input() when passing $option['div'] = false
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7066 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-30 16:05:53 +00:00
joelmoss
03322a31d7 FormHelper::submit() now accepts alternative wrapping tags, instead of a div.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7065 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-30 15:44:39 +00:00
joelmoss
4dfe7333b7 FormHelper::error() can now be passed the tag to wrap the error message in.
FormHelper::input() can now be passed the tag to wrap the input element in; same applies to the tag that wraps the error message.
Corrected date format in Form test testMonth().


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7064 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-30 15:07:32 +00:00
nate
42da5aba81 Moving Cake folder to correct location
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7063 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-30 11:40:08 +00:00
DarkAngelBGE
e6e0d852a2 deleting cake folder from svn
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7061 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-30 10:59:16 +00:00
mark_story
78e534b73b Refactored month() to take monthNames in the options array. Added options descriptions to several doc blocks. Tests updated.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7047 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-27 00:07:00 +00:00
gwoo
0bfa2f72bf fixes #4762, monthNames count
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7046 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-26 19:26:44 +00:00
mark_story
9da3e638df Applied Enhancement submitted by 'chjunior', month display can be set to numbers or translated text. Closes #4327. Tests also updated.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7039 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-24 04:00:26 +00:00
mark_story
0c164efb21 Added missing params to FormHelper doc blocks, marked private methods.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7038 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-24 02:57:48 +00:00
the_undefined
52bae8a7bf Made form helper pick up field definitions outside the current context
Made form helper handle maxlength for float fields properly, fixes #4724


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7021 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-23 05:14:57 +00:00
mark_story
f7438da72e Implemented patch from 'johnathansnook' closes #4496 Form::inputs now allows for fieldset classname to be set. Updated tests
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6991 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-21 03:57:35 +00:00
mark_story
f2eab6ef59 Implemented enhancements, closes #4059 and #4584
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6972 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-19 21:01:02 +00:00
DarkAngelBGE
45bccc5215 optimization refs #3415
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6970 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-19 20:36:39 +00:00
mariano.iglesias
5459b92f02 Ensuring that a valid maxlength value is used for inputs, fixes #4691
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6965 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-19 12:17:37 +00:00
DarkAngelBGE
5047963a77 small change to allow onSubmit pass strict validation, fixes #4311
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6961 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-19 08:06:58 +00:00
the_undefined
9e79d1768c Applied patch by 'mark_story' making form helper month names i18n ready, fixes #4409
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6950 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-19 06:29:40 +00:00
the_undefined
0a715f2afe Refactored CakeTestCase::assertTags to tokenize the validation process and give useful debug information on demand
Refactored all FormHelper test cases to work for the new approach and make use of new features
Fixed a FormHelper::hour dateTime bug causing the hour 0 to be selected at 12pm

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6769 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-08 11:32:31 +00:00
mariano.iglesias
e0a9f03572 Fixed issue where $selected = true sent to FormHelper date method was generating multiple OPTION tags with SELECTED attribute
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6746 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-01 21:26:11 +00:00
mariano.iglesias
893c218be6 Fixing issue where FormHelper::dateTime was generating non valid XHTML
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6745 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-01 21:22:08 +00:00
joelmoss
7f6e54ea3a Validation now supports error messages on multi record forms. Added tests to support this. Closes #4499. Thanks jose_zap
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6713 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-23 14:14:58 +00:00
mariano.iglesias
ab3b90503f Fixing issue in Security component with modeless field names, fixes #4454. Thanks vuego for the test and patch!
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6685 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-17 22:51:40 +00:00
phpnut
1250c6e0cc "Adding patches and test from #4447.
Closes #4447, Multiselects' hidden input should not have an id attribute.
Thanks sarimarton"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6640 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-09 01:39:10 +00:00
phpnut
a138ae3d63 "Fixing use of array('minuteInterval' => #);
Proper usage is array('interval' => #); but for backwards compatibility this fix has been added"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6633 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-04 12:48:13 +00:00
phpnut
d14b50fc92 "References #4394, additional fixes to multi record forms.
Added additional test cases"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6629 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-03 06:48:56 +00:00
phpnut
5374807164 "Fixes #3846, Security blackhole when no radio selected
Fixes #3920, Multiple select w/ checkboxes issues warning when all are unselected
Fixes #3962, validation POST never pass when select multiple is submit
"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6546 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-10 00:25:59 +00:00