adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2024-11-15 11:28:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
14027 commits 7 branches 0 tags 44 MiB
Commit graph

3571 commits

Author SHA1 Message Date
Ceeram
0b0d83f261 remove cookie reading in startup 2012-09-07 00:04:03 +02:00
Mark Story
93004fcf2f Merge pull request #818 from shama/patch-unused-vars 
Remove unused variables and code
 2012-09-05 17:50:06 -07:00
Mark Story
c8cb3ae75f Merge pull request #810 from schrolli/patch-2 
Update lib/Cake/Configure/IniReader.php
 2012-09-05 17:45:43 -07:00
Kyle Robinson Young
bc40ac7d3f Remove unused variables and code 2012-09-05 17:19:13 -07:00
Kyle Robinson Young
a214fcd992 Remove never reached code in Debugger::trimPath and test more results 2012-09-05 15:57:53 -07:00
Kyle Robinson Young
602240c08e Fix $readReceipt variable in EmailComponent::send 2012-09-05 12:49:09 -07:00
mark_story
c7647b775f Attempt to fix build error in travis. 2012-09-04 17:25:02 -04:00
Kyle Robinson Young
200dd2dc9b Code standards fixes, unneeded break statements 2012-09-04 11:30:52 -07:00
mark_story
5b641287e9 Make schema errors clearer. 
When a schema fails because of the name, the error should display
the name & file name that it attempted to load. This gives people
a slightly better chance of figuring things out.
 2012-09-03 21:06:48 -04:00
mark_story
0d826528e1 Supress fewer errors. 
PHPUnit raises exceptions on errors, there isn't much point in
supressing all these errors.
 2012-09-03 20:13:30 -04:00
mark_story
bacd8afde3 Remove duplicated header. 2012-09-03 19:55:29 -04:00
mark_story
3cb501f1c5 Fix issue created in [e8b5d81fd7] 
Query conditions with `-` and no surrounding spaces were quoted
incorrectly.

Fixes #3178
 2012-09-03 13:24:38 -04:00
mark_story
583bb37df0 Fix typo. 2012-09-03 13:10:27 -04:00
schrolli
83c05c24b3 Update lib/Cake/Configure/IniReader.php 
Updated docblock and set NULL as the default value of $path
 2012-09-02 14:23:26 +03:00
schrolli
a4c382b23a Update lib/Cake/Configure/IniReader.php 
Copied standard path from PhpReader
 2012-09-02 06:02:30 +03:00
mark_story
f155687cfa Update version number to 2.2.2 2012-09-01 18:28:03 +01:00
mark_story
474e42cc08 Switch File::info() tests to use a different file. 
text/php files are not detected reliably across platforms. Use a plain
text file instead.  This should fix builds on travis.ci
 2012-09-01 12:40:05 +01:00
mark_story
d3105332dc Fix coding standards errors. 2012-09-01 12:14:15 +01:00
mark_story
e8b5d81fd7 Fix quoting of field names containing -. 
Fixes #3165
 2012-08-31 14:25:02 +01:00
Maggion Emmanuel
03f6f041b2 Fix typo 2012-08-31 09:50:22 +03:00
mark_story
894fc1256a Add test cases for strings containing quotes. 
Show that both double and single quoted strings are
handled correctly by ExtractTask.

Closes #3155
 2012-08-30 23:48:32 +01:00
Kyle Robinson Young
ee9a545c7d Correct docblock see tags to ViewBlock 
Fixes http://cakephp.lighthouseapp.com/projects/43067/tickets/97-about-api-description-of-viewassign
 2012-08-29 21:53:29 -07:00
mark_story
4fdd5e5d45 Ignore non-scalar values for length. 
Fixes #3159
 2012-08-28 21:58:32 -04:00
Mark Story
f97d8f9bb7 Merge pull request #800 from bar/master-validator-decimal 
Refactor Validator::decimal() to be more flexible with decimal separators and PHP magic. Lots of testing added.
 2012-08-28 13:41:40 -07:00
Ber Clausen
63548267e9 Refactor Validator::decimal() to be more flexible with decimal 
separators and PHP magic.
Lots of testing added.
 2012-08-27 23:25:17 -03:00
mark_story
b27c8a05bd Make invalid short option error more helpful. 
Refs #3157
 2012-08-27 22:12:05 -04:00
mark_story
fba17cffe9 Move OptionParser initialization out of try block. 
This allows exceptions that result from creating the optionparser to
display to the developer, making debugging easier.

Fixes #3157
 2012-08-27 22:07:28 -04:00
Mark Story
7135ff29fb Merge pull request #773 from bar/master-fix-inireader 
Add plugin support to IniReader, and harden tests.
 2012-08-27 12:36:57 -07:00
mark_story
988a847f49 Fix unescaped entities. 2012-08-27 14:48:07 -04:00
Ber Clausen
bdac857293 Add plugin support to IniReader, and harden tests. 
The actual config file must always have .ini extension.
For backwards compatibility, acl.ini.php will be treated specially until 3.0.
 2012-08-27 10:04:26 -03:00
mark_story
cbb64bd082 Fix blackhole requests with empty select boxes. 
When a select box was entirely empty (no option element)
secured form submission should not fail.

Fixes #3153
 2012-08-26 22:53:48 -04:00
mark_story
b68a2ed84d Update API docs. 2012-08-26 22:15:18 -04:00
Mark Story
a553142a0a Merge pull request #796 from MrRio/ticket-3152 
Fix Email test fails when not running on port 80  

Fixes #3152
 2012-08-25 18:18:50 -07:00
James Hall
20baeb83db Change to match coding standards 2012-08-26 02:11:43 +01:00
James Hall
a3b5065f8a Make sure the environment variable is set 2012-08-26 00:33:32 +01:00
James Hall
6c4ba233ba Fix testSendRenderWithImage when non running on port 80 2012-08-26 00:23:32 +01:00
mark_story
7966c00700 Merge branch 'master' of github.com:cakephp/cakephp 2012-08-25 17:53:22 -04:00
James Hall
7484007fa7 Fix #3148 MediaView does not support Microsoft Office default formats 2012-08-25 17:51:48 -04:00
Jose Lorenzo Rodriguez
f6278488af Ensuring list of behavior methods are refreshed between calls of 
validates() in the model, fixes #3071
 2012-08-25 14:05:19 +02:00
Jose Lorenzo Rodriguez
60eb228ddf Fixing issues with validation rules not being reset after calling 
create() on the model or when calling validates() multiple times
This had interesting side effects when deep saving
 2012-08-25 13:29:16 +02:00
Paul Redmond
a993a7a50d Fixing typo in view property during unset() 2012-08-24 23:11:25 -07:00
mark_story
b2f62f46c5 Fix failing tests in postgres. 2012-08-24 22:37:23 -04:00
Ber Clausen
b75a6b440a Treat float numbers with trailing zeroes removed by PHP, accordingly. 
Revert #2800 (28bd6880df) regex changes. Also add more tests.

Signed-off-by: mark_story <mark@mark-story.com>
 2012-08-24 22:22:12 -04:00
Ceeram
f06ce1324d Merge branch '2.2-habtmmerge' 2012-08-24 10:45:45 +02:00
mark_story
dcc5a95482 Only split on ; for TABLE related statements. 
Fixes #3142
 2012-08-23 23:11:00 -04:00
Ceeram
cb80338c7d avoid duplication in return value when saving habtm 2012-08-24 00:50:46 +02:00
Ceeram
c5ebbc991c Revert "Merge pull request #784 from ceeram/habtmmerge" 
This reverts commit fa5aa6278f, reversing
changes made to 88604ac757.
 2012-08-23 16:00:41 +02:00
Ceeram
fb0053753e avoid duplication in returned results for habtm 2012-08-22 13:03:47 +02:00
mark_story
88604ac757 Replace is_a with instanceof. 2012-08-21 08:47:58 -04:00
Renan Gonçalves
172e4bed5d Fix STRICT warnings on PHP 5.4 2012-08-21 13:08:43 +02:00
mark_story
00f3e7e441 Fix silent failures. 
Fixes #3133
 2012-08-20 16:19:34 -04:00
mark_story
e75fdd21ee Add tests to show caseinsensitive nature of detectors. 
Closes #3132
 2012-08-20 11:43:10 -04:00
Stephen Cuppett
7e5f326300 Fix STRICT warnings on PHP 5.4 2012-08-19 17:00:26 -04:00
Mark Story
08e4362d40 Merge pull request #772 from bar/master-fix-phpreader 
The actual config file must always have .php extension.
 2012-08-16 11:00:27 -07:00
mark_story
8146cc4db4 Update mime types of various powerpoint extensions. 
Fixes #3121
 2012-08-15 23:14:57 -04:00
mark_story
73f29069de Fix issue where omitting a base class would break test generation. 
Fixes #3115
 2012-08-15 20:59:56 -04:00
ADmad
7ac01154f7 Merge branch '2.2-configure' 2012-08-15 20:09:25 +05:30
ADmad
18c5a4aee5 Make file extension optional for Configure reader adapter's dump function. 2012-08-15 19:38:58 +05:30
mark_story
cdc70fc427 Make RequestHandlerComponent better simulate GET requests. 
Modify the global state to simulate a GET request.  This avoids issues
where PUT data would be processed during simulated redirect.

Fixes #3113
 2012-08-14 12:46:47 -04:00
mark_story
e183e91b17 Make CakeRequest work with content-type headers that include a charset. 
Refs #3113
 2012-08-14 12:42:05 -04:00
ber clausen
0dec093f48 The actual config file must always have .php extension. 2012-08-13 23:50:58 -03:00
ADmad
65e63c51c8 More missing parent calls. 2012-08-12 02:28:12 +05:30
ADmad
802f00b6e3 Adding missing calls to parent. 2012-08-12 02:13:10 +05:30
ADmad
4a483b4897 If cache is disabled in app and js cache file is not written don't return script tag with file url. 
Instead return script block with inline js content.
 2012-08-12 01:08:05 +05:30
ceeram
ebb0ceb6a0 Merge pull request #764 from ceeram/2.2-2998 
2.2 2998
 2012-08-09 09:21:42 -07:00
mark_story
b29cc6a9b6 Try again at fixing errors in 5.2 2012-08-08 23:09:44 -04:00
mark_story
c94a684be8 Try to fix recursion issues in PHP5.2. 2012-08-08 22:42:44 -04:00
mark_story
dca050fbd6 Fix errors with recursion in debug() 
Fixes #3102
 2012-08-08 22:30:27 -04:00
Justin A. Barnes
476bd80644 Fix cake bake project always finding CakePHP libs in php include_path. 
Cake shell was adding the CakePHP libs to php include_path resulting in
producing baked projects without hardcoded CAKE_CORE_INCLUDE_PATH when
hardcoded CAKE_CORE_INCLUDE_PATH is needed.

Refs #GH-755

Signed-off-by: mark_story <mark@mark-story.com>
 2012-08-07 20:52:37 -04:00
Nicholas de Jong
d4fa5d000c Allow an App to define its own LOGS and CACHE paths outside TMP 2012-08-05 14:55:22 +10:00
mark_story
dbe3234b56 Refactor help to show up on console -h as well. 2012-08-04 13:57:14 -04:00
mark_story
d7f1bf52b1 Fix route commands in ConsoleShell. 
Apply patch from 'Ludovic Pouzenc' to fix route features in the console
shell.

Fixes #3096
 2012-08-04 13:44:35 -04:00
mark_story
73b1c0ac1c Fix off by one error. 
Fixes #3094
 2012-08-03 23:34:44 -04:00
mark_story
c96e364cbb Fix incorrect expiry of sessions. 
Fixes #3088
 2012-08-02 21:03:53 -04:00
mark_story
cffc36e4e0 Fix notice error when impossible conditions are created. 
Fixes #3084
 2012-08-01 23:05:56 -04:00
Mark Story
2728c6253e Merge pull request #728 from boast/patch-2 
TreeBehavior: Changed $Model->alias . '.' . $field to $Model->escapeField($field)
 2012-08-01 19:41:04 -07:00
Ceeram
2a0a5f2afa Use the returned response instance from the event 2012-07-31 18:39:05 +02:00
mark_story
9b94133f0d Fix uncaught exceptions when generating view cache files 
Fixes #3016
 2012-07-30 21:27:21 -04:00
Schlaefer
af8c5716fc Added test for RSS to allow namespace tags if namespace is specified 
If a namespace prefix is defined it's prefix should not be stripped
from the tag: `<dc:creator>` stays `<dc:creator>`.

Other prefixes are still stripped from the tag name.

This test is missing in 19f0e72d58
 2012-07-30 10:10:19 +02:00
mark_story
4541510e26 Fix notice error when a missing action error is hit. 2012-07-29 22:37:41 -04:00
mark_story
7b939186a1 Fix ( and ) not being correctly handled by autoLinkUrls 
Fixes #3077
 2012-07-29 21:18:33 -04:00
Schlaefer
19f0e72d58 fix #2858 RSS helper bug with namedspaced keys 
http://cakephp.lighthouseapp.com/projects/42648/tickets/2858-rss-helper-bug-with-namedspaced-keys
 2012-07-29 14:24:46 +02:00
Rachman Chavik
5413b672eb use is_subclass_of instead of comparing Acl.classname 2012-07-28 15:00:17 +07:00
mark_story
27e2132a13 Generated SQL should not contain multi-column primary keys 
While totally valid in databases, the Schema system is not designed to
handle multi-column primary keys in a sane way. In MySQL this results in
two auto_increment columns, and in postgres this results in two serial
columns.

Fixes #3069
 2012-07-27 22:31:49 -04:00
ADmad
99813e97b3 Implemented feature to allow individual "empty" values for date time select elements 2012-07-28 01:47:21 +05:30
Kyle Robinson Young
cbf5328b33 Fix failing test with controller task listAll 2012-07-25 22:12:55 -07:00
Mark Story
4dd532d3a9 Merge pull request #724 from SimonEast/h_encoding 
Prevent booleans from being encoded (converted to strings) by h() function
 2012-07-25 18:17:12 -07:00
Mark Story
a03166c5b6 Merge pull request #739 from tigrang/router-validate-route-fix 
Fixed issue where restoring the default route class would cause an exception.
 2012-07-25 18:16:21 -07:00
Mark Story
b99be9878a Merge pull request #738 from zpencerq/authcomponentproblem 
Auth Component can't return false from user($key)
 2012-07-25 16:05:29 -07:00
Tigran Gabrielyan
851aa8bef4 Fixed issue in _validateRouteClass where setting defaultRouteClass back to CakeRoute would throw an exception 2012-07-25 14:13:25 -07:00
Spencer Ellinor
8a41fb0c34 Fix issue and remove unneccesary code. The (fixed) conditional doesn't do anything, since if Hash::get returns null, the function still returns null. 2012-07-25 15:09:22 -04:00
Spencer Ellinor
6c1b05a5d4 Modify test case to show the issue. 2012-07-25 15:06:56 -04:00
mark_story
7d74f3e598 Increase context depth in error messages. 
Fixes #3063
 2012-07-24 23:39:48 -04:00
mark_story
70c714d600 Fix incorrect context being used for excerpt. 
Fixes #3064
 2012-07-24 23:37:37 -04:00
mark_story
162d3bcb29 Fix whitespace errors. 2012-07-23 22:44:05 -04:00
mark_story
66b296527f Add type check to prevent errors related to Hash::get() 
Fixes #3041
 2012-07-23 22:33:58 -04:00
David Thalmann
f926ae7637 Clean up string concatenations and refactored some reused strings into variables. 
Refs #GH-729

Signed-off-by: mark_story <mark@mark-story.com>
 2012-07-23 22:30:28 -04:00
mark_story
35bf3097cd Fixing missing imports in generated tests. 
Fixes #3059
 2012-07-23 21:25:55 -04:00
mark_story
e6ef218600 Fix associated translations being inserted. 
Due to changes introduced in [1c0b6c076a]
associated translations would incorrectly be saved with a value of ''.

Fixes #3057
 2012-07-22 20:59:24 -04:00
mark_story
6286b43329 Make tests pass on windows. 
Need to shuffle around log levels to work with the 4 levels on windows
instead of the 8 on *nix systems.

Refs #3055
 2012-07-21 20:59:05 -04:00
mark_story
a27e171f0f Invert default log configuration. 
Windows only has 4 log levels instead of 8.  This causes notice errors
when trying to use 'alert' and a few other levels.

Fixes #3055
 2012-07-21 20:42:46 -04:00
mark_story
ab6fab6675 Add missing import. 2012-07-21 20:42:46 -04:00
David Thalmann
78de6e276a Removed inline method calls in curly braced string concat's. 2012-07-22 03:40:49 +03:00
David Thalmann
d9b5ec1a3a Changed all string concatenations like $Model->alias . '.' . $field to the more consistent $Model->escapeField($field). 2012-07-21 22:07:51 +03:00
Simon East
1ea457e40e Prevent booleans from being encoded (converted to strings) by h() function, helps prevent accidental fatal errors in some PHP versions around 5.2.9 2012-07-20 12:48:57 +10:00
Mark Story
f65b52bf11 Merge pull request #722 from uzyn/bugfix/url-validation 
Fix URL validation to allow underscores in subdomain.
 2012-07-19 12:40:30 -07:00
U-Zyn Chua
e7c4064a69 Fix URL validation to allow underscores in subdomain. 2012-07-19 20:51:33 +08:00
mark_story
473d55f091 Allow 1 second of slip. 2012-07-18 22:22:57 -04:00
mark_story
3b46cd43f1 Add logging and error when fixture creation fails. 
This helps people find and solve issues faster/easier.

Fixes #3044
 2012-07-17 22:48:50 -04:00
mark_story
a63dd9ee9d Fix incorrect formatting in TreeBehavior. 
Fixes #3045
 2012-07-17 21:06:41 -04:00
mark_story
928de97338 Add additional tests for error triggering on missing validator. 
Closes #3039
 2012-07-15 19:47:28 -04:00
mark_story
cc44130fc0 Update version number to 2.2.1 2012-07-14 16:42:59 -04:00
mark_story
fb92bde0fe Loosen exception types. 2012-07-14 16:18:21 -04:00
mark_story
22d4cb3794 Allow warnings for Xml entities. 
For some installations libxml_use_internal_errors() does not work,
a warning is another way to measure the entities not being loaded.
 2012-07-14 16:08:54 -04:00
mark_story
a7c79e5da2 Fix warnings when deleting records that do not exist. 
Fixes #3037
 2012-07-14 15:54:07 -04:00
mark_story
6c905411ba Fix XML decoding attack via external entities. 2012-07-14 11:53:37 -04:00
mark_story
46f8de72a2 Fix web runner showing fails as passes when show_passes is on. 
Fixes #3035
 2012-07-13 22:58:07 -04:00
mark_story
8fc5726920 Remove trailing whitespace. 2012-07-11 21:39:32 -04:00
mark_story
3baaecc81c Type check before unset() 
Calling unset() on string indices fails fatally on 5.3.x and lower.

Fixes #3027
 2012-07-11 15:54:24 -04:00
mark_story
b7415525c8 Fix missing line breaks. 
Fixes #3028
 2012-07-11 15:51:07 -04:00
Jose Lorenzo Rodriguez
db247558b0 Correctly passing ellipsis options to all internal method calls insie 
PaginatorHelper::numbers(), under some combinations of modulus/limit
it would not get passed even though there are pages in between to show
 2012-07-10 20:46:56 -04:30
Jose Lorenzo Rodriguez
39715bcd89 Adding missing afterValidate callback to behaviors, Fixes #3024 2012-07-10 20:35:26 -04:30
Ilie Pandia
73d44c5f6b Fixed some typos in the comments in this file. This helps with type 
hinting in IDEs that support that.
 2012-07-08 07:33:14 +03:00
mark_story
5e680cb292 Add tests for translate + partial fields. 
Refs #3009
 2012-07-07 12:03:29 -04:00
Thomas von Hassel
1c0b6c076a Update afterSave to ensure created entires have all translated fields present 
Without all fields being present, find() will be unable to find the
translated records.

Fixes #3009
 2012-07-07 12:03:29 -04:00
Jose Lorenzo Rodriguez
ed4493da0c Automatic console logging streams were not respecting --quiet 2012-07-06 16:05:15 -04:30
mark_story
591022f182 Make test case use SERVER_NAME conditionally. 2012-07-05 22:56:45 -04:00
mark_story
f528bb29ba Fix lint error. 2012-07-05 22:50:54 -04:00
Mark Story
ae01d473c3 Merge pull request #707 from SimonEast/fix_CakeEmailTest 
Fix for CakeEmailTest.php that failed unless using 'localhost'
 2012-07-05 19:40:54 -07:00
Rodrigo Moyle
e10f6f57a3 Fix notice error when parsing input data. 
Prevent error in CakeRequest from parsing input data in
PUT and DELETE requests.

Fixes #3002

Signed-off-by: mark_story <mark@mark-story.com>
 2012-07-05 22:06:02 -04:00
Simon East
de703a2692 Fix for CakeEmailTest.php that failed unless using 'localhost' 2012-07-06 11:59:39 +10:00
mark_story
e61f636bc7 Fix double base dir in image() with fullBase. 
Fixes #2991
 2012-07-03 20:48:17 -04:00
Rachman Chavik
22373868bb if blackHoleCallback is set, requests _must_ get blackholed 2012-07-03 19:27:02 +07:00
Ceeram
18b860ed1a keeping methods BC, load() now returns false again when configname not default and not configured 2012-07-03 12:43:33 +02:00
Ceeram
19ba09286d Make load() and dump() more consistent with each other, create new PhpReader for default if not configured yet. 
Fixes #2998
 2012-07-03 12:20:00 +02:00
Rachman Chavik
86a74e3887 fix: windows console may not have ansi color support 2012-07-03 12:41:29 +07:00
mark_story
31033239bd Add missing urlencoding to nested named parameters. 
Fixes #2988
 2012-07-02 23:34:53 -04:00
Jose Lorenzo Rodriguez
4b3a8ea348 Update version number to 2.2.0 2012-07-01 18:25:14 -04:30
Jose Lorenzo Rodriguez
ec7ec73b66 Merge branch '2.1' into 2.2 2012-07-01 17:35:24 -04:30
mark_story
87677e4cdf Fix possible notice errors. 2012-06-26 23:31:22 -04:00
Alberto Leal
7d93c57bd3 Use the diff style provided by PHPUnit in the webrunner. 
Displaying actual vs expected messages when the result is an array or string.
Fixes #GH-699
 2012-06-26 19:53:49 -04:00
José Lorenzo Rodríguez
476209df03 Changing docs in CakeRequest:accepts() as they were misleading, you are required to pass a correct mimetype and not an alias 2012-06-26 14:38:07 -05:30
ADmad
76f93178a8 Tweaked Validation::extension() 2012-06-25 19:15:52 +05:30
mark_story
ad5345887a Refactor tests. 
Use generators to reduce some duplication.
 2012-06-24 21:57:00 -04:00
mark_story
3f78216e96 Revert changes in behavior made to timeAgoInWords() 
Changes made in [0729aca706] changed
the generated text to not match the behavior in 2.1.
 2012-06-24 20:54:47 -04:00
mark_story
eb7b66b37c Revert default value of allowEmpty. 
In 2.1, the default value was null, which does not impart any behavior.
In 2.2 this was changed to false, which makes it hard to validate ''
with validation methods.  Move some tests around and update tests that
probably should have been failing before.

Fixes #2983
 2012-06-24 20:06:14 -04:00
ADmad
b2ccdd46e5 Fixed test failing when server's timezone is not UTC 2012-06-24 23:11:52 +05:30
mark_story
503bc06c70 Mark fixtures as created if they exist. 
Fixes #2905
 2012-06-24 12:57:54 -04:00
Juan Basso
ecdf0e6c6c Optimization for Hash method 2012-06-24 12:47:30 -04:00
mark_story
3e28326d9c Fix Controller::beforeRedirect() and array return. 
Array return values from Controller::beforeRedirect() would be
incorrectly handled causing wrong URL's to be generated.

Fixes #2973
 2012-06-24 12:03:31 -04:00