Commit graph

9497 commits

Author SHA1 Message Date
mark_story
23bacfc0c7 Adding new checks, so missing favicons don't flood the error logs. 2011-02-20 13:29:19 -05:00
mark_story
8991095045 Removing references to GET['url'] & favicon, as there is no more GET[url]. 2011-02-20 13:12:04 -05:00
mark_story
24935afff4 Removing remaining references to $_GET['url']. 2011-02-19 22:27:38 -05:00
mark_story
ea52f880fd Removing useless property. 2011-02-19 22:26:44 -05:00
mark_story
630d0a9887 Removing redundant method. 2011-02-19 22:26:12 -05:00
mark_story
8cbd9fc361 Fixing viewClass name on Scaffold. 2011-02-19 22:21:58 -05:00
mark_story
633fcba4e8 Fixing viewClass name on Scaffold. 2011-02-19 22:21:38 -05:00
mark_story
24369cf04a Removing GET param, and making CakeRequest use PATH_INFO and SCRIPT_NAME to determine base paths and request urls.
Updated tests.  Removed test for base path injection, as PHP_SELF is no longer used to compute the base path, and users cannot influence SCRIPT_NAME.
2011-02-19 22:20:55 -05:00
mark_story
db00915dea Removing complicated logic that does a reasonable amount of unnecessary work. Favouring $_SERVER['PATH_INFO'] over more complicated, logic. This may cause issues with IIS 5.x, but its a very old release now.
Updating tests to match values that come out of IIS7.
2011-02-19 18:20:54 -05:00
mark_story
52467a7e18 Moving assignment of base into _base(). 2011-02-19 13:17:05 -05:00
mark_story
79ec16364a Refactoring tests to use a generator. 2011-02-19 12:36:27 -05:00
mark_story
1ee6c1ee45 Removing some no longer required method calls. 2011-02-19 11:30:09 -05:00
mark_story
c15d0132f3 Adding more environment detection tests. 2011-02-19 10:00:34 -05:00
mark_story
63f07d3f0f Making Authorize and Authenticate objects have constructors like other components.
Adding ComponentCollection as a argument for the constructor, this unifies the two types of objects and makes them consistent with other components.  It also allows authenticate/authorize objects to access other components, thanks to hiromichan for the idea. Tests updated.
2011-02-17 23:17:07 -05:00
mark_story
0cb5394d0b Adding static variable to allow changing which get param cake uses. Refs #1483 2011-02-17 22:15:16 -05:00
mark_story
5c4854b897 Adding omitted return that would prevent users from reaching the login page after being redirected to it. Tests added. Fixes #1542 2011-02-17 07:44:41 -05:00
0x20h
0e7f2efdb1 Fixing notice errors caused by accessing headers in po files that
don't exist. Fixes #1515

Signed-off-by: mark_story <mark@mark-story.com>
2011-02-16 22:13:51 -05:00
mark_story
ca3e606ec8 Fixing failing tests caused by me forgetting to run tests in [7032729651] 2011-02-16 22:08:20 -05:00
mark_story
a95d4acf09 Removing unused code, and adding a realpath() to document_root, so symlinks work a bit better. 2011-02-16 21:14:32 -05:00
mark_story
c638443b4d Merge branch '2.0-auth' into 2.0 2011-02-14 22:45:39 -05:00
mark_story
e60376bef9 Removing a bunch of code that can be reached through inheritance.
Adding a doc block.
2011-02-13 22:19:49 -05:00
mark_story
51dcb18742 Adding support for AppFixtureManager as well as option flag selection. 2011-02-13 19:01:53 -05:00
mark_story
d20f68c44e Making Model::setSource() eager again to fix issues where joined models
would not have the table prefixes correctly configured.  Fixes #1507
2011-02-13 18:42:04 -05:00
mark_story
7f8c98d9de Fixing typo and exposing fixture manager parameter to webrunner. 2011-02-13 15:15:01 -05:00
mark_story
844c6315c1 Fixing issue where a non CakeException would break things.
Test added.
2011-02-13 15:14:29 -05:00
mark_story
451b3fd18d Going back to using the old time and memory calculations/output. 2011-02-13 15:01:00 -05:00
mark_story
912927db18 Removing duplicate tag. 2011-02-13 14:56:35 -05:00
mark_story
f6e9b5b254 Removing TestManager from the group tests.
Fixing a failing case on the testsuite shell.
Fixing Debugger from stealing the error handler from PHPUnit.
2011-02-13 14:56:35 -05:00
mark_story
1c9808fdca Creating a factory method for the runner creation. 2011-02-13 14:56:35 -05:00
mark_story
78dd89027d Removing comments left in on previous commit. 2011-02-13 14:56:35 -05:00
mark_story
9f4597effd reformatting code. 2011-02-13 14:56:35 -05:00
mark_story
39e05bce4a Using PHPUnit internals for more things.
Removing code that is also present in PHPUnit.
Updating testsuite shell to use loader class.
2011-02-13 14:56:35 -05:00
mark_story
e5c898a4d2 Moving methods into the loader class.
Getting rid of lame functions and using Spl more effectively.
2011-02-13 14:56:35 -05:00
mark_story
0c09d08585 Removing duplicate methods. 2011-02-13 14:56:35 -05:00
mark_story
4f65d0dbed Fixing issue where document start would be sent multiple times. 2011-02-13 14:56:35 -05:00
mark_story
846a0587fc Getting rid of TestManager. 2011-02-13 14:56:34 -05:00
mark_story
00c56facdd Removing CakeWebTestCase it doesn't work anymore. 2011-02-13 14:56:34 -05:00
mark_story
f84046c802 Moving a require.
Adding some doc blocks, and making the loader not double append test case suffixes.
2011-02-13 14:56:34 -05:00
mark_story
08fba9b280 Making coverage reports work from the webrunner. 2011-02-13 14:56:34 -05:00
mark_story
16481d7b7e Running individual tests from the web runner now works.
Adding some more hooks, so webrunner can swap out result printers like it did before.
2011-02-13 14:56:34 -05:00
mark_story
8ebbccbd76 Fixing tab/spaces. 2011-02-13 14:56:34 -05:00
mark_story
8c2e0815ec Adding Fixture manager overriding.
Refs #1511
2011-02-13 14:56:34 -05:00
mark_story
0a2822335c Removing a bunch of code not needed any more. 2011-02-13 14:56:34 -05:00
mark_story
f586ed0394 Initial ugly re-factor of where fixtures are done. 2011-02-13 14:56:33 -05:00
mark_story
5a631a6c74 Renaming the runner.
Making the runner extend PHPUnit_TextUi_TestRunner so we can customize the TestSuite classes it uses.
Adding CakeTestSuiteCommand so we can customize the TextUI_Command output.
2011-02-13 14:56:33 -05:00
mark_story
60590de6bc Starting to banish TestManager, and replace it with a more normal PHPUnit test loader. 2011-02-13 14:56:33 -05:00
mark_story
63caf566fb Adding some tests around invalidFields() and fieldList options.
Closes #1534
2011-02-13 12:22:29 -05:00
ADmad
681b9997b0 Renamed Controller::view to Controller::viewClass and Controller::view, View::view can now be used to change the view rendered by default. Parameters of Controller::render() and View::render() changed to eliminate redundancy. Closes #1520 2011-02-13 02:24:39 +05:30
mark
e16d21eaa3 Add displayField and primaryKey to controller bake. Fixes #1192
Signed-off-by: mark_story <mark@mark-story.com>
2011-02-12 11:47:38 -05:00
mark_story
d0c2b9c9d1 Fixing failing test caused by boolean type changes. 2011-02-12 06:21:19 -05:00
mark_story
08509cc6d3 Fixing issue where static variable would be shared inconsistently across multiple instances. Fixes #1504 2011-02-11 22:39:09 -05:00
mark_story
26c5f78a14 Fixing notice error caused when looking for info on tables that don't exist. 2011-02-11 22:37:56 -05:00
mark_story
e0420937a7 Fixing notice error that could occur if csrfTokens ended up being null/not an array. 2011-02-11 22:30:51 -05:00
mark_story
42c2f3011b Applying fix from 'Mark Mitchell' to expose PeriodicalExecuter in the callback. Fixes #1529 2011-02-11 21:49:00 -05:00
mark_story
71f76080a2 Fixing issue where creating cookies in the beforeFilter would result in
cookies with the wrong expiry time. Thanks 'RabidFire' for the patch. Fixes #1523
2011-02-09 21:19:15 -05:00
mark_story
33390070d3 Removing HTTP authentication from SecurityComponent. There are new
Authentication objects to fill this hole now.
2011-02-08 22:09:57 -05:00
mark_story
a5fb2cf8a7 Fixing issue where fixtures without field definitions would drop tables,
even though they had no way to re-create them. Fixes #1519
2011-02-08 21:53:12 -05:00
mark_story
9a940709ab Removing unsupported options from PrototypeEngine. Fixes #1516 2011-02-07 20:59:01 -05:00
mark_story
584116524b Fixing range option for prototype engine. Fixes #1509 2011-02-07 19:19:50 -05:00
mark_story
fbd798da6c Reordering parameters to make it easier to remember the order. 2011-02-06 16:59:47 -05:00
mark_story
47cdaedc94 Fixing $this -> self. 2011-02-06 15:25:36 -05:00
Juan Basso
f2a4b1e959 Supporting %e in windows. Fixes #1510. 2011-02-06 15:51:28 -02:00
mark_story
e32f419d0a Fixing comments. 2011-02-06 00:01:52 -05:00
mark_story
3629925a40 Refactoring authentication objects so basic and digest authentication can work without cookies. This makes non browser clients able to use Basic and Digest auth.
Updating test cases.
2011-02-05 18:41:00 -05:00
mark_story
7388d900b4 Fixing IIS test cases to match what should actually happen. 2011-02-05 16:12:50 -05:00
mark_story
11d20f80d0 Fixing failing tests imported with the merge. 2011-02-05 15:24:53 -05:00
mark_story
e149c411fb Merge branch '1.3' into merger
Conflicts:
	cake/VERSION.txt
	cake/config/config.php
	cake/console/shells/tasks/template.php
	cake/dispatcher.php
	cake/libs/controller/component.php
	cake/libs/controller/components/email.php
	cake/libs/controller/scaffold.php
	cake/libs/model/datasources/dbo/dbo_mysqli.php
	cake/libs/view/helpers/cache.php
	cake/libs/view/pages/home.ctp
	cake/tests/cases/dispatcher.test.php
	cake/tests/cases/libs/model/datasources/dbo/dbo_postgres.test.php
	cake/tests/fixtures/datatype_fixture.php
2011-02-05 12:20:09 -05:00
mark_story
8d5e68d582 Fixing issue where habtm tables would not have the connection prefix removed when generating schema. Fixes #1180 2011-02-05 11:19:05 -05:00
mark_story
ca22624b2b Tiny tweak to remove a duplicated line. 2011-02-05 10:43:30 -05:00
mark_story
79bbd227e3 Cache::configured() and in_array() are faster than calling Cache::config() 6 times. 2011-02-05 10:30:28 -05:00
mark_story
cf50cbdd9d Fixing issue in FormHelper where CURRENT_TIMESTAMP or other invalid data could cause a notice error. Fixes #1508 2011-02-05 06:43:00 -05:00
mark_story
0a266fa1fc Fixing typo. 2011-02-05 05:54:38 -05:00
mark_story
f58f3763eb Updating tests to account for attribute whitespace change. 2011-02-05 05:52:18 -05:00
mark_story
8f66fe6ed4 Removing additional spaces in tags. 2011-02-05 01:48:52 -05:00
mark_story
f5383a2243 Fixing some failing tests. 2011-02-05 01:40:14 -05:00
mark_story
8d7df1721c Removing duplicate import. 2011-02-05 01:29:35 -05:00
mark_story
304f12d0ed Removing a pointless import in CakeRequest.
Moving inclusion of ObjectCollection to bootstrap.  This avoids repetitive calls to import()
2011-02-05 01:28:41 -05:00
mark_story
8e267f7be2 Fixing bake's unit test detection so it checks for PHPUnit properly.
Fixes #1505
2011-02-04 21:56:24 -05:00
Mark Story
7b34d879dc Making exception class names visible in the WebTest runner. Fixes #1506 2011-02-04 17:11:49 -05:00
mark_story
3875d0ef54 Removing a method that is duplicated in AuthComponent. 2011-02-03 23:00:41 -05:00
mark_story
9854947d0f Fixing reversed args. 2011-02-03 22:46:31 -05:00
mark_story
5834225cc3 Making AuthComponent::password() static, as it might be needed in places where an instance of AuthComponent is not handy. 2011-02-03 22:46:31 -05:00
mark_story
a5d9a64e1a Removing loginError, its not used anymore. 2011-02-03 22:46:31 -05:00
mark_story
59dac2255e Expanding test coverage. 2011-02-03 22:46:31 -05:00
mark_story
060360c787 Switching Controller->Session => Auth->Session. 2011-02-03 22:46:31 -05:00
mark_story
dc7565ad47 Removing crufty methods
Removing additiona ->Controller all over the place
2011-02-03 22:46:31 -05:00
mark_story
af934e3443 Removing more dead code in the Auth test. 2011-02-03 22:46:31 -05:00
mark_story
ffb6c29e79 Removing dead fixtures, dead properties and dead models. 2011-02-03 22:46:31 -05:00
mark_story
2f917674d1 Fixing docblock to reflect change from '*' to 'all'. Adding note about constant. 2011-02-03 22:46:31 -05:00
mark_story
82851895ef Shifting includes around. 2011-02-03 22:46:31 -05:00
mark_story
91a3fc4aee Fixing tests so they run in the webrunner. 2011-02-03 22:46:30 -05:00
mark_story
0e7f490489 Fixing failing test. 2011-02-03 22:46:30 -05:00
mark_story
669672a1a0 Adding doc blocks. 2011-02-03 22:46:30 -05:00
mark_story
d5f5ae3271 Fixing typo where realm would be wrong if not specified. 2011-02-03 22:46:30 -05:00
mark_story
705b3288e1 Basics of DigestAuth are working. 2011-02-03 22:46:30 -05:00
mark_story
945e49ad09 Starting Digest auth, using Basic auth as a starting base. 2011-02-03 22:46:30 -05:00
mark_story
bcd8dcd0f7 Extracting common logic into the base class. 2011-02-03 22:46:30 -05:00
mark_story
4610a0bf3c Adding some more tests for basic auth challenge headers. 2011-02-03 22:46:30 -05:00
mark_story
e8bf6ed176 Basic tests for BasicAuthenticate are passing. 2011-02-03 22:46:30 -05:00
mark_story
67c4c9a693 Fix failing test and removing tests for settings that no longer exist. 2011-02-03 22:46:30 -05:00
mark_story
ba02483ae8 Adding a response parameter to authenticate() both basic and digest auth need to set response headers. 2011-02-03 22:46:30 -05:00
mark_story
332b6cfc22 Adding basic authentication skeleton. 2011-02-03 22:46:29 -05:00
mark_story
041e0a65ac Extracting a base class. 2011-02-03 22:46:29 -05:00
mark_story
ee804c6f8c Removing properties from AuthComponent that have been moved to authentication and authorization objects.
Adding the '*' key to allow code to stay DRY, also adding a constant for ALL, so there aren't as many magic strings around.
Updating tests.
2011-02-03 22:46:29 -05:00
mark_story
41819975e8 Removing a dead property. 2011-02-03 22:46:29 -05:00
mark_story
b207ee8cbe Making AuthComponent::user static, so user data can be fetched from anywhere. 2011-02-03 22:46:29 -05:00
mark_story
35864c2a02 Removing AuthComponent::getModel(). Auth no longer directly interacts with models. 2011-02-03 22:46:29 -05:00
mark_story
66f5ae07ed Removing AuthComponent::validate() there are no tests and no documentation on this method. It also uses components that may or may not exist even in the old implementation. 2011-02-03 22:46:29 -05:00
mark_story
28ad51c92b Removing action() from AuthComponent, its in the authorization objects now.
Updating tests.
2011-02-03 22:46:29 -05:00
mark_story
dc03e4f26c Moving an import. 2011-02-03 22:46:29 -05:00
mark_story
fd8fb1225d Removing automatic password hashing from AuthComponent. Its a frustrating feature that often befuddles new users, and can be plain annoying sometimes.
Moving hashing into FormAuthenticate.
Updating tests.
2011-02-03 22:46:28 -05:00
mark_story
23db2f086e Adding more documentation. 2011-02-03 22:46:28 -05:00
mark_story
e155e6acba Adding doc block usage information. 2011-02-03 22:46:28 -05:00
mark_story
ed122c70f4 Removing custom request reversal code, and using Router::reverse()
Removing dead tests that are covered by Router tests.
Removing check for TestsController, it hasn't existed in forever.
2011-02-03 22:46:28 -05:00
mark_story
f2bba3d36e Adding tests for AuthComponent::redirect() previously there weren't any. 2011-02-03 22:46:28 -05:00
mark_story
6eb31dfc94 Removing test cases that were doing integration testing with router, and plugin models. Plugin model tests are in FormAuthenticate. And there is no more automatic login. 2011-02-03 22:46:28 -05:00
mark_story
dc8c99308e Starting to remove magical login process.
Updating tests to actually test the methods they are named after.
2011-02-03 22:46:28 -05:00
mark_story
d8f2cf9395 Starting to remove magic around userModel, and deprecating/removing userModel from AuthComponent. 2011-02-03 22:46:28 -05:00
mark_story
b59d0e8bb1 Replacing Authcomponent::$flashElement with Authcomponent::$flash, which gives access to all the flash parameters. Also adding a wrapper method for more terse code and ability to extend functionality. 2011-02-03 22:46:28 -05:00
mark_story
ff889c2c8e Renaming method names, no need to include Objects, its implied. 2011-02-03 22:46:28 -05:00
mark_story
1696df7201 Removing the last of actionMap from AuthComponent. Its been moved into the authorization objects.
Updating and adding tests for crud_authorize.
2011-02-03 22:46:27 -05:00
mark_story
e11917ae94 Removing public properties that aren't used anymore. 2011-02-03 22:46:27 -05:00
mark_story
0c7f9149ca Refactoring authorization objects to also use settings, it makes them consistent with authenticate objects.
Making actionPath automatically pass into authentication objects.
Adding tests.
2011-02-03 22:46:27 -05:00
mark_story
e34fdde918 Adding a test for logging users in using request data. 2011-02-03 22:46:27 -05:00
mark_story
7ea914938f Changing AuthComponent::login() so you can provide an array of user data to manually login a user. Leaving $user blank will attempt to identify the user using the request. 2011-02-03 22:46:27 -05:00
mark_story
f21970c533 Making AuthComponent::mapActions() delegate to the authorize objects. Adding tests. 2011-02-03 22:46:27 -05:00
mark_story
e96b20b93e Removing skipped tests that cover features in other classes and tests. 2011-02-03 22:46:27 -05:00
mark_story
3f9c83c43d Authentication and Authorization objects are integrated with AuthComponent. Minimal App changes are needed as legacy settings are forwarded. 2011-02-03 22:46:27 -05:00
mark_story
ced832ba62 Fixing issues with FormAuthenticate and plugin models. 2011-02-03 22:46:27 -05:00
mark_story
6860f7cc03 Starting to integrate Authorization objects into AuthComponent.
Tests updated and duplicate tests skipped, they will eventually be removed when duplication is confirmed.
2011-02-03 22:46:27 -05:00
mark_story
ca9aabdfec Adding file headers. 2011-02-03 22:46:26 -05:00
mark_story
5ae194ec90 Updating group test case, and fixing test case classname. 2011-02-03 22:46:26 -05:00
mark_story
2e9d9479a6 Moving another part of AuthComponent's authorize strategies into BaseAuthorize.
Implementing CrudAuthorize and adding tests for it.
2011-02-03 22:46:26 -05:00
mark_story
7207dccc7c Adding ActionsAuthorize. It implements using Acl as the authorization object. 2011-02-03 22:46:26 -05:00
mark_story
4058e7f48c Extracting a base class, as it will be needed.
Moving AuthComponent::action() into the authorize object base as that's where its used.
2011-02-03 22:46:26 -05:00
mark_story
67c9acbc94 Adding a doc block. 2011-02-03 22:46:26 -05:00
mark_story
16b3beec5e Starting ControllerAuthorize adding it and the test cases. 2011-02-03 22:46:26 -05:00
mark_story
693360bc9e Removing isAuthorized() as there is no need for it once AuthComponent is updated. 2011-02-03 22:46:26 -05:00
mark_story
1c827573ce Adding doc blocks for FormAuthenticate. 2011-02-03 22:46:26 -05:00
mark_story
68da3fab8f Starting to extract authentication objects out of AuthComponent. Started off with extracting FormAuthenticate as its what currently exists in AuthComponent. Test case added. 2011-02-03 22:46:25 -05:00
mark_story
63308fdbd8 Fixing issue where a false id would be appended to the route url. Test added. Fixes #1501 2011-02-02 21:52:41 -05:00
Phally
f3812342c2 Minor optimization for email linefeeds. 2011-01-31 00:15:56 +01:00
Phally
9402f0ab79 Added missing skipIf when no SMTP server is running. 2011-01-31 00:06:11 +01:00
mark_story
6db8515e60 Fixing incorrectly nested sprintf + __ call. Refs #1305 2011-01-30 12:25:40 -05:00
mark_story
5b8499c8c7 Adding $name back in as it causes numerous notice errors in fixtures when it is missing. 2011-01-29 20:54:15 -05:00
ADmad
88d5db76fd Removed overriding of recursive to 0 in Model::_findNeighbors() if 'recusive' option is not specified in find options. Closes #860 2011-01-30 04:13:01 +05:30
Maggion Emmanuel
01801a7777 Reducing code related to CakeSchema. Fixes #1477 2011-01-29 17:26:08 -05:00
mark_story
b30f40582e Making SchemaShell disable the cache when reading table information for schema generation. Fixes #1490 2011-01-29 09:24:28 -05:00
Jeremy Harris
3575053463 Merge remote branch 'upstream/2.0' into 2.0 2011-01-27 18:33:07 -08:00
Jeremy Harris
e99f090ee0 Fixed issue where ClassRegistry alias was incorrectly set 2011-01-27 18:32:51 -08:00