Commit graph

5954 commits

Author SHA1 Message Date
mark_story
b80955c9fe Adding newlines to the builtin email template. Fixes issues with long lines. Refs #857 2011-02-25 18:50:50 -05:00
Juan Basso
8c7b0f48d8 Checking if has item before fetch virtual fields, avoiding call a function with result (can be large). It save a good time. 2011-02-25 19:55:34 -03:00
Juan Basso
d095f5fe8d Optimizations in filterResults. 2011-02-25 19:15:40 -03:00
Juan Basso
fea2b5798c Minor optimizations in DboMysql. 2011-02-25 17:22:15 -03:00
Juan Basso
73b3b65a53 Changed to filterResults be protected instead of private. 2011-02-25 13:26:14 -03:00
Juan Basso
728d9b2a26 Removed the unused var. 2011-02-25 13:05:08 -03:00
Juan Basso
9baeaf8338 Some code optimizations. 2011-02-25 13:01:32 -03:00
Juan Basso
765c094cf1 Extra protection. 2011-02-25 12:54:58 -03:00
Juan Basso
a091302c92 Removed the isInterfaceSupported method. It not make sense in PHP5. 2011-02-25 12:54:57 -03:00
Juan Basso
05fc10e717 Removed the Datasource::sources method that is used to PHP4. Changed the isInterfaceSupported to be case sensitive (PHP4 restriction). 2011-02-25 12:54:55 -03:00
Juan Basso
6f5be8ff95 Minor changes. 2011-02-25 12:54:53 -03:00
Juan Basso
7f58d2628f Removing return from constructor. 2011-02-25 12:54:51 -03:00
Juan Basso
9e8fc96bf8 Trimming whitespaces. 2011-02-25 12:54:50 -03:00
Juan Basso
5ab5197090 Less one var. 2011-02-25 12:54:48 -03:00
Juan Basso
6e14fa8949 Moving attributes from Datasource to DboDataSource. 2011-02-25 12:54:46 -03:00
Juan Basso
f15544018f Minor optimizations in find. 2011-02-25 12:54:44 -03:00
Juan Basso
5bfa0867ef Removed the support to notation of 1.2. 2011-02-25 12:54:43 -03:00
Juan Basso
31679c3efa Changed the scope of methods in Model. 2011-02-25 12:54:41 -03:00
mark_story
e05c6cd83f Fixing issue where actions starting with a prefix but not followed by an _ would get mangled when going through router::url().
Fixes #1556
2011-02-24 16:43:13 -05:00
José Lorenzo Rodríguez
19bcec599b Merge branch '2.0' of github.com:cakephp/cakephp into 2.0
Conflicts:
	cake/tests/cases/libs/model/datasources/dbo/dbo_mysql.test.php
2011-02-24 01:38:11 -04:30
José Lorenzo Rodríguez
69b70249da Fixing more issues with database prefixes 2011-02-24 01:31:03 -04:30
mark_story
139d6b3133 Changing the checks surrounding dataExpression to use empty() instead of isset() so unexpected things don't happen if you ever use dataExpression = false. Fixes #1521 2011-02-23 21:15:39 -05:00
mark_story
9367a10522 Merge branch '1.3' of github.com:cakephp/cakephp into 1.3 2011-02-23 21:07:10 -05:00
mark_story
98df3e331f Fixing DboMysql not quoting database names in listSources.
Updated tests.
Fixes #1552
2011-02-23 11:36:41 -05:00
José Lorenzo Rodríguez
00f3aaf615 Fixing some issues in ACL related classes when using database prefixes 2011-02-23 01:22:23 -04:30
José Lorenzo Rodríguez
8f62d01701 Fixing lazy loading of database conenction when using prefixes and performing delete operations 2011-02-23 00:51:48 -04:30
José Lorenzo Rodríguez
fc060b5e9c Starting to lazy load database conenctions again, model read tests fixed 2011-02-23 00:43:56 -04:30
José Lorenzo Rodríguez
a79877d11a Revert "Making Model::setSource() eager again to fix issues where joined models"
This reverts commit d20f68c44e.
2011-02-22 23:49:02 -04:30
Juan Basso
52163b4b05 Allowing strings in cc and bcc. Fixes #1553. 2011-02-22 21:23:15 -03:00
mark_story
6426b7ec04 Fixing issues with / routes, as PATH_INFO doesn't exist.
Changing foreach loop for if elseif blocks, and removing use of env().  The values we want will never be anywhere else by _SERVER, so don't incur extra overhead looking places it won't be.
Added tests.
2011-02-21 22:30:01 -05:00
ADmad
1f2afd8d3f Removing deprecated function TimeHelper::relativeTime() which was simply an alias for TimeHelper::timeAgoInWords() 2011-02-22 01:27:46 +05:30
mark_story
0b75906649 Adding docs about the ability to set settings in the helper as well. 2011-02-21 14:08:29 -05:00
mark_story
c64dd9d352 Adding the ability to pass additional information into the rendering of flash messages. Allows you to keep keep code DRY by moving repeated settings into the view.
Added tests.
Fixes #792
2011-02-21 14:08:29 -05:00
mark_story
6338299e77 Merge branch 'clean-get' into 2.0 2011-02-21 12:47:41 -05:00
Victor Widell
d0b7d3355d $this->data[$habtmKey] could be a string, meaning $this->data[$habtmKey][$habtmKey] would be the first character of that string. Probably not what you want.
Fixes #1549

Signed-off-by: mark_story <mark@mark-story.com>
2011-02-21 10:39:55 -05:00
mark_story
d1821b3f9d Removing $request->query[url]. This simulated value is also available at $request->url, and having it in the query array confuses things, as GET[url] no longer exists.
Fixing failing tests elsewhere in the framework.
2011-02-20 21:52:20 -05:00
mark_story
ea52f880fd Removing useless property. 2011-02-19 22:26:44 -05:00
mark_story
630d0a9887 Removing redundant method. 2011-02-19 22:26:12 -05:00
mark_story
8cbd9fc361 Fixing viewClass name on Scaffold. 2011-02-19 22:21:58 -05:00
mark_story
633fcba4e8 Fixing viewClass name on Scaffold. 2011-02-19 22:21:38 -05:00
mark_story
24369cf04a Removing GET param, and making CakeRequest use PATH_INFO and SCRIPT_NAME to determine base paths and request urls.
Updated tests.  Removed test for base path injection, as PHP_SELF is no longer used to compute the base path, and users cannot influence SCRIPT_NAME.
2011-02-19 22:20:55 -05:00
mark_story
db00915dea Removing complicated logic that does a reasonable amount of unnecessary work. Favouring $_SERVER['PATH_INFO'] over more complicated, logic. This may cause issues with IIS 5.x, but its a very old release now.
Updating tests to match values that come out of IIS7.
2011-02-19 18:20:54 -05:00
mark_story
52467a7e18 Moving assignment of base into _base(). 2011-02-19 13:17:05 -05:00
mark_story
63f07d3f0f Making Authorize and Authenticate objects have constructors like other components.
Adding ComponentCollection as a argument for the constructor, this unifies the two types of objects and makes them consistent with other components.  It also allows authenticate/authorize objects to access other components, thanks to hiromichan for the idea. Tests updated.
2011-02-17 23:17:07 -05:00
mark_story
0cb5394d0b Adding static variable to allow changing which get param cake uses. Refs #1483 2011-02-17 22:15:16 -05:00
mark_story
5c4854b897 Adding omitted return that would prevent users from reaching the login page after being redirected to it. Tests added. Fixes #1542 2011-02-17 07:44:41 -05:00
0x20h
0e7f2efdb1 Fixing notice errors caused by accessing headers in po files that
don't exist. Fixes #1515

Signed-off-by: mark_story <mark@mark-story.com>
2011-02-16 22:13:51 -05:00
mark_story
c638443b4d Merge branch '2.0-auth' into 2.0 2011-02-14 22:45:39 -05:00
mark_story
d20f68c44e Making Model::setSource() eager again to fix issues where joined models
would not have the table prefixes correctly configured.  Fixes #1507
2011-02-13 18:42:04 -05:00
mark_story
844c6315c1 Fixing issue where a non CakeException would break things.
Test added.
2011-02-13 15:14:29 -05:00