Commit graph

19610 commits

Author SHA1 Message Date
Mark Sch
ed14b42274
php74 2019-12-02 17:56:38 +01:00
Mark Story
5eed56b6e4
Merge pull request #13947 from pascalwoerde/2.cannot-change-save-handler-when-session-is-active
Fix duplicate session_set_save_handler call from handler instantiation.
2019-11-28 16:56:04 -05:00
Pascal Woerde
2affcdfb00
Fix duplicate session_set_save_handler call from handler instantiation. 2019-11-26 13:39:22 +01:00
Mark Story
d2e1681eb8
Merge pull request #13683 from gersonfs/2.x
Solving headers already sent bug on sessions whit phpunit.phar
2019-09-26 15:10:03 -04:00
Gerson Felipe Schwinn
cf49efdf0e Solving headers already sent bug on sessions whit phpunit.phar 2019-09-26 09:00:11 -03:00
Mark Story
46068ac65b
Merge pull request #13606 from milan-corpoflow/patch-1
Fix loading ShellHelpers from plugins
2019-09-04 21:07:20 -04:00
Milan van As
64700e9a08
Fix loading ShellHelpers from plugins
Previously the Shell::helper() function would call a `class_exists` on a variable that contained the `Plugin.ClassName` notation which will always result be false, e.g. `class_exists('YourPlugin.TestShellHelper')` will always be false. Loading ShellHelpers from a plugin will never work because of this. (This notation is described in the ShellHelper 2.x documentation).
After the pluginSplit and the loading of the actual ShellHelper class file (through `App::uses`), the `class_exists` should be called on the real class name, not on `Plugin.ClassName`.

Through this fix, plugins with an ExampleShellHelper in placed in MyPlugin/Console/Helper/ExampleShellHelper.php can be called in Shells by `$this->helper('MyPlugin.ExampleShellHelper')` and plugins within your app can still be loaded through the regular `$this->helper('MyShellHelper')`.
2019-09-04 14:56:12 +02:00
Mark Story
ec8022baf5
Merge pull request #13539 from mvdriel/empty-post-body-for-json-will-put-null-value-in-request-data
Empty post body for json will put null value in request->data
2019-08-19 22:06:47 -04:00
Mark van Driel
142c19c557 Fix for: Empty post body for json will put null value in request->data 2019-08-19 15:00:19 +02:00
Mark van Driel
d4c351563e Test to prove issue with empty body for json 2019-08-19 14:52:46 +02:00
Mark Story
31dbda0a71
Merge pull request #13446 from garethellis36/ControllerTestCase/create-dispatcher
2.x - Moves creation of ControllerTestDispatcher to its own protected method
2019-07-29 21:58:27 -04:00
Gareth Ellis
dba84d65d7 Corrects style error from PHPCS by prefixing method name with an underscore 2019-07-29 15:27:45 +01:00
Gareth Ellis
f198ffdb9c Moves creation of ControllerTestDispatcher to its own protected method 2019-07-29 10:35:43 +01:00
mark_story
8f08a83474 Update version number to 2.10.19 2019-07-24 21:32:25 -04:00
mark_story
85eb25e8b5 Add missing App::uses()
Fixes #13083
2019-06-19 21:52:57 -04:00
Mark Story
396e342601
Merge pull request #13311 from tenkoma/2.x-exec-fixture-shutdown-phpunit5.2
[2.x]Fix When PHPUnit 5.2.0+, test ends before calling FixtureManager::shutdown()
2019-06-02 21:54:29 -04:00
Koji Tanaka
d09e827f6c Pass $exit arguments to the parent doRun() method and $exit is false 2019-06-01 22:59:30 +09:00
mark_story
00aec4b4f5 Update version number to 2.10.18 2019-05-13 22:28:47 -04:00
Mark Story
3522378925
Merge pull request #13198 from bancer/2.x-docs
Improve doc block
2019-05-06 11:12:38 -04:00
bancer
7e1fef4066 Improve doc block 2019-05-06 14:21:24 +02:00
Mark Sch
9270d4759b
Merge pull request #13171 from bancer/2.x-docs
Improved doc block
2019-04-29 14:30:49 +02:00
bancer
928f586599 Improved doc block 2019-04-29 10:40:10 +02:00
Mark Story
7d8da309ed
Merge pull request #13169 from tenkoma/2.x-test-pass-with-php73
[2.x]Skip tests that fail on PHP 7.3 built-in functions
2019-04-28 10:03:56 -04:00
Koji Tanaka
cf39119151 In PHP 7.3+, call the built-in function mb_strtoupper() to skip failed tests 2019-04-28 21:00:45 +09:00
Mark Story
c8a9c61f27
Merge pull request #13126 from cakephp/issue-13085
Fix shutdown warnings in PHP7.2+
2019-04-17 11:44:57 -04:00
mark_story
4d0a209033 Fix shutdown warnings in PHP7.2+
Check if the current file is valid before re-using it. This fixes
warnings emitted during process shutdown when DboSource is persisting
the method cache.

Fixes #13085
2019-04-16 21:23:58 -04:00
mark_story
d954e96671 Update version number to 2.10.17 2019-04-13 22:17:43 -04:00
Mark Story
3d216935c9
Merge pull request #13054 from savedario/2.x
FormHelper does not respect passed 'escape' option for errors
2019-03-30 21:38:41 -04:00
Mark Story
8ff719de66
Merge pull request #13058 from bancer/2.x-use-trans-session-id
Add extra unit tests
2019-03-30 21:36:13 -04:00
Mark Sch
b8cefad8c5
Merge pull request #13060 from hgsgtk/2.x-fix-phpdoc
fix phpdoc at HtmlHelper::link
2019-03-19 08:47:55 +01:00
Kazuki Higashiguchi
e472a85ab2 fix phpdoc at HtmlHelper::link 2019-03-19 12:03:33 +09:00
bancer
81c7c6700f Add --verbose to the test command in travis 2019-03-18 13:29:02 +01:00
bancer
e6ea25cbd2 Add --verbose to the test command 2019-03-18 13:04:09 +01:00
bancer
4db38f26ca Improve unit test 2019-03-18 12:43:26 +01:00
bancer
ec3abd9089 Add extra test to AllControllerTest 2019-03-18 11:58:42 +01:00
bancer
2fe0af9fa9 Improve docs 2019-03-18 11:52:35 +01:00
bancer
534d9362e4 Add extra unit tests 2019-03-18 11:50:13 +01:00
Dario Savella
cf5577234f PHPCS typos fixed 2019-03-15 18:50:26 +01:00
Dario Savella
08d11154a7 Changes reverted. Added 2 tests of error-related options 2019-03-15 17:41:29 +01:00
Dario Savella
5ba9e41df8 Form helper did not respect passed FormHelper::inputDefaults() 2019-03-15 10:39:52 +01:00
Mark Story
4fd57b86ca
Merge pull request #13048 from garethellis36/13046
Separates derivation of conditions for cascaded deletion of HABTM records to a protected method #13046
2019-03-14 09:19:46 -04:00
Gareth Ellis
c14782305b Separates derivation of conditions for cascaded deletion of HABTM records to a protected method #13046 2019-03-14 10:28:59 +00:00
mark_story
c4a51509c5 Update version number to 2.10.16 2019-02-28 21:45:41 -05:00
Mark Story
d054d536ab
Merge pull request #13010 from bancer/2.x-config
Use CONFIG constant
2019-02-23 16:50:54 -09:00
Mark Sch
307e11f507
Merge pull request #13002 from benjaminstout/issue-13001-redis-engine-undefined-index
Wrap index reference in empty() check - closes cakephp#13001
2019-02-21 22:54:25 +01:00
Benjamin Stout
71f5133a86 Use strict comparison instead of function call - #13001 2019-02-21 11:44:38 -08:00
bancer
3f909e9a00 Define CONFIG constant 2019-02-21 17:18:15 +01:00
bancer
8a724bb698 Use CONFIG constant 2019-02-21 16:54:07 +01:00
Benjamin Stout
0cc3509b74 Prevent attempting to close an uninitialized Redis instance (issue #13001) 2019-02-19 18:21:44 -08:00
Benjamin Stout
d486e1ca9e Wrap index reference in empty() check - closes cakephp#13001 2019-02-19 16:32:25 -08:00