Mark Story
0f23634382
Adding stack traces to error400 and error500 when debug > 0.
...
Adding the stack trace element.
2010-09-06 18:09:11 -04:00
Mark Story
09fd8ba463
Adding stack trace output to the framework errors.
2010-09-06 17:54:48 -04:00
Mark Story
45dab88180
Adding a cast to fix a failing test from the merge.
2010-09-06 16:54:32 -04:00
Mark Story
d88da3d579
Merge branch '1.3' into 2.0
...
Conflicts:
cake/libs/configure.php
cake/libs/model/connection_manager.php
cake/libs/model/model.php
cake/tests/cases/libs/model/datasources/dbo/dbo_postgres.test.php
cake/tests/cases/libs/view/helpers/text.test.php
2010-09-06 16:53:04 -04:00
Mark Story
c60edfae6d
Fixing issue where errors containing code = 500, were not actually converted to error500 when debug = 0. Making missingConnection, and missingTable into error500 errors.
2010-09-06 16:46:41 -04:00
Mark Story
464d2217e6
Renaming model_behavior test to behavior_collection test as that's the class that contains the tested methods.
2010-09-06 13:51:42 -04:00
Mark Story
73057b8853
Merge branch '2.0' of github.com:cakephp/cakephp into 2.0
2010-09-06 13:39:37 -04:00
Mark Story
5789aaf24d
Applying patch from 'tkykmw'. Behavior mapped methods are no longer run through strtolower(). Mapped methods are now case sensitive. Fixes #318
2010-09-06 13:38:01 -04:00
predominant
a6b08c94d0
Merge remote branch 'origin/2.0' into 2.0
...
Conflicts:
cake/libs/session/database_session.php
2010-09-06 23:57:36 +10:00
Mark Story
b491414a51
Changing gif to png, so baked apps have the correct icon. Fixes #1081
2010-09-06 01:39:39 -04:00
Mark Story
2e46d2f5ca
Changing gif to png, so baked apps have the correct icon. Fixes #1081
2010-09-06 01:38:31 -04:00
Mark Story
fd50c2ae2a
Adding some tests for the constructor.
2010-09-06 01:21:58 -04:00
Mark Story
d54c901f5d
Moving _setupDatabase() into the Database session class, as that's the only place its used.
2010-09-06 01:12:23 -04:00
Mark Story
c8ad4f11eb
Updating test session classes to not use static methods.
2010-09-06 01:11:54 -04:00
Mark Story
474ace09c1
Adding CakeResponse to the list of included files for Controller.
2010-09-06 01:11:26 -04:00
Mark Story
d62ae2900a
Fixing issue where ConnectionManager wasn't triggering session close, causing issues with database sessions.
2010-09-06 01:10:45 -04:00
Mark Story
27ae7f1f44
Making session storage classes not static, there was no real reason they were static before, and removing the static methods allows them to have constructors. This will allow moving database specific features from CakeSession to DatabaseSession.
2010-09-06 00:43:58 -04:00
ADmad
bfaaa6b8ba
Fixing unnecessary extra calls to 'afterFind' callback of 'hasMany' associated models. Closes #995
2010-09-05 23:53:24 +05:30
Mark Story
01eb0bf07d
Making messages optional for HTTP exceptions.
2010-09-05 11:32:35 -04:00
Mark Story
8bd0f18a53
Adding a new line to the ConsoleErrorHandler
...
Refactoring ConsoleErrorHandler test to use dynamic mocks.
2010-09-05 11:22:39 -04:00
Mark Story
9fee81cda0
Updating ConsoleErrorHandler to use new exception names and method renames.
2010-09-05 11:10:48 -04:00
Mark Story
e5b4dd94d7
Renaming exceptions to not use Error400, Error500. Instead HTTP status words are used.
...
Adding more common HTTP status errors.
Updating tests for ErrorHandler.
2010-09-05 02:05:31 -04:00
Mark Story
b7791dd94f
Removing variable that wasn't provided by the exception.
2010-09-05 02:04:08 -04:00
Mark Story
82fffe6914
Fixing issue where FormHelper::select() with multiple = checkbox and a custom name attribute would not work correctly. Fixes #1078
2010-09-05 01:28:13 -04:00
Mark Story
cc17e1a85a
Adding more doc blocks to error classes.
2010-09-04 19:18:14 -04:00
Mark Story
954676c9f6
Adding doc blocks to the new exception classes.
2010-09-04 19:16:06 -04:00
Mark Story
d198230e61
Fixing issue where errors that did not have a 500+ code would use the incorrect status code.
2010-09-04 19:06:10 -04:00
Mark Story
4d863618f5
Refactoring exception handling so codes are much more flexible and easy to change.
...
Made error404 and error500 more generic.
Removed error() as it didn't really make that much sense.
2010-09-04 15:38:10 -04:00
Mark Story
dbd34c75c7
Removing newlines and trailing space.
2010-09-04 15:36:57 -04:00
Mark Story
4980f42dc5
Renaming file.
2010-09-04 15:35:01 -04:00
Mark Story
42d998ca3b
Fixing up the include for the console error handler, and adding a test for stderr handle.
2010-09-04 10:46:04 -04:00
Mark Story
fa7549dc4c
Fixing comments and removing cakeError(). Instead you should be throwing exceptions.
2010-09-04 01:34:45 -04:00
Mark Story
af87e5d5bc
Adding a skip when AppError is present, as its behaviour is unknown.
2010-09-03 15:35:11 -04:00
Mark Story
8c428ff8a8
Moving where AppError is used, as infinite recursion is no fun.
2010-09-03 15:03:33 -04:00
Mark Story
5c0fe1b16e
Applying patch from 'majna'. Adding plugin to the list of template variables exposed in the controller task. Test added Fixes #1077
2010-09-03 12:33:59 -04:00
Mark Story
f2db19767d
Adding in support for AppError.
2010-09-03 10:30:35 -04:00
Mark Story
2c7ef67e97
Fixing stupid output buffering error.
2010-09-03 10:22:58 -04:00
Mark Story
29ade860b1
Adding cases for Error404 and Error500 exceptions.
2010-09-02 18:04:50 -04:00
Mark Story
a1e01e414b
Adding a tests for CakeExceptions and non CakeExceptions
2010-09-02 18:02:58 -04:00
Mark Story
a44b35311d
Integrating the ConsoleErrorHandler into the console environment.
2010-09-02 17:49:43 -04:00
Mark Story
60e44660c3
Moving ErrorHandler to ConsoleErrorHandler so it doesn't have classname conflicts.
...
Making the console use a subclass of ErrorHandler.
2010-09-02 17:49:00 -04:00
Mark Story
034aaa7462
Creating optional boot variable that informs Configure if it should bootstrap the app. Changing how ShellDispatcher checks for app existence it sets the $boot var now and reuses the framework bootstrap file instead of a second custom one.
2010-09-02 17:16:57 -04:00
Mark Story
81e6ca2249
Moving dispatcher include so that cake/bootstrap.php is only bootstrapping the framework. This should allow reusing the bootstrap file for console and web once console error handler is fixed.
2010-09-02 17:00:52 -04:00
Mark Story
d6b43c0e29
Removing TIME_START global, use $_SERVER['REQUEST_TIME'] instead.
2010-09-02 16:55:42 -04:00
Mark Story
ffa8b959e4
Changing classname and importing base class.
2010-09-02 16:47:06 -04:00
Mark Story
3940b059a3
Adding a big docblock to explain how to setup application exception handling.
2010-09-02 16:39:09 -04:00
Mark Story
2e8a60f932
Removing some mentions of cakeError as its been removed. Also adding information about exceptions that can be raised.
2010-09-02 16:38:19 -04:00
Mark Story
dbdd17f51a
Adding test cases from 'euromark' and updating how email addresses are parsed so they are slightly more conformant to RFC 5322. Fixes #1066
2010-09-02 11:16:10 -04:00
Mark Story
3e5e52d52e
Fixing doc block for Form::create(). Fixes #1058
2010-09-02 00:29:04 -04:00
Mark Story
063fcf557d
Moving error handler inclusion to before Configure::bootstrap() so app error handlers can be created.
...
Fixing issue where unknown exception types would not be handled spewing out errors. Unknown exception types are interpreted as 500 errors.
2010-09-01 20:29:55 -04:00
mark_story
08d6c19ab6
Adding test for themes in app/webroot dir. Closes #1061
2010-08-31 21:21:05 -04:00
mark_story
a8d4015f47
Updating bootstrap process in CLI to match the one in web.
...
Updating all_libs to use new file.
Updating error_handler test to run in cli.
Updating Controller so it imports required classes.
2010-08-30 22:59:10 -04:00
mark_story
1f30c06695
Fixing method coercion in error404 so it only coerces CakeExceptions.
...
Test Added.
2010-08-29 23:39:28 -04:00
mark_story
534f6006f8
Adding omitted parent call.
2010-08-29 23:38:46 -04:00
mark_story
612c52bb8b
Adding a beforeRender() that automatically escapes all the content sent to errors handled by CakeErrorController.
2010-08-29 23:31:20 -04:00
mark_story
78ac5bd20f
Removing sprintf() placeholders that don't work.
2010-08-29 23:28:54 -04:00
mark_story
efaa2e1177
Refactoring test case to use a dataprovider for the uniform/copy paste test cases.
2010-08-29 21:53:44 -04:00
mark_story
f1164c93d6
Updating the various CakeExceptions to take arrays in their constructors. This allows for the existing templates to continue working, as well as generalize the way in which errors are handled. This change also makes the messages coming out of exceptions more readable and removes string hackery.
2010-08-29 21:37:25 -04:00
mark_story
741f2972f9
Removing non required attribute from missing controller error page.
2010-08-29 15:12:50 -04:00
mark_story
99cde14432
No more skipped tests for ErrorHandler.
...
Removing missing_model as it was never called.
2010-08-29 13:49:10 -04:00
predominant
465b15c64e
Removing reference assignments.
2010-08-29 23:09:33 +10:00
mark_story
7fb62e9b7e
Updating more error messages to use exceptions.
2010-08-29 01:26:21 -04:00
mark_story
041aeecce4
Renaming test case file to match class file.
...
Updating tests and methods for missing_action, missing_view, private_action.
2010-08-29 01:01:36 -04:00
mark_story
88c66c057d
Renaming error.php to error_handler.php to better match its class name.
2010-08-29 01:00:36 -04:00
mark_story
756baeafdb
Making CakeErrorController get the most recent request, this will help when using requestAction.
...
Updating test cases for error404.
Updating ErrorHandler
2010-08-28 23:32:14 -04:00
mark_story
8712a90c8b
Adding some tests for construction.
2010-08-28 22:50:29 -04:00
mark_story
a30721b46b
Moving exception classes around and making all the core exceptions extend one class that overrides the code to 500. The code value will be used as the HTTP status code for the error page.
2010-08-28 22:49:52 -04:00
mark_story
5d942ee609
Extracting a few methods to make testing easier, and subclasses easier to create.
2010-08-28 19:53:21 -04:00
mark_story
5257a66fe5
Merge branch '2.0' of github.com:cakephp/cakephp into 2.0
2010-08-28 11:26:28 -04:00
mark_story
26f4ad4da1
Modifying bootstrap so it sets a default exception handler.
...
Making a ghetto implementation of exception handling.
Adding a crude test case, adding incomplete markers to all other tests.
2010-08-28 01:39:02 -04:00
predominant
04d3353ee4
Adding access specifiers to methods
2010-08-28 15:38:48 +10:00
mark_story
9b3e91089a
Adding omitted types of exceptions.
2010-08-28 01:38:03 -04:00
mark_story
5de88c0f02
Moving CakeErrorController to its own file.
2010-08-28 01:37:39 -04:00
predominant
f7addabcf2
Whitespace removal
2010-08-28 15:27:12 +10:00
predominant
c1209a1a7a
Added RequestObject output in place of Controller:$output whicch no longer exists.
2010-08-28 15:15:23 +10:00
predominant
93b80042f8
Fix failing scaffold tests.
2010-08-28 15:01:43 +10:00
mark_story
a2186c412a
Updating doc blocks for CakeRequest and CakeResponse.
2010-08-28 00:59:07 -04:00
mark_story
d8b2bcdf06
Making view + helpers groups pass.
2010-08-28 00:40:12 -04:00
mark_story
dcb7a167b4
Fixing controller test cases.
2010-08-28 00:29:50 -04:00
mark_story
9485f0a993
Merge branch 'request-response' into 2.0
...
Conflicts:
cake/tests/cases/libs/controller/controller.test.php
2010-08-28 00:24:07 -04:00
mark_story
e4545dbe5e
Fixing failing tests in Dispatcher.test.
2010-08-28 00:19:09 -04:00
mark_story
c76f205bcb
Adding exceptions file.
2010-08-28 00:18:46 -04:00
mark_story
2cdb10812d
Merge branch '2.0-exceptions' into 2.0
...
Conflicts:
cake/dispatcher.php
cake/libs/controller/scaffold.php
cake/tests/cases/dispatcher.test.php
2010-08-28 00:14:34 -04:00
mark_story
dc67b9cacc
Moving all the exceptions into one file for the short term.
2010-08-28 00:08:35 -04:00
José Lorenzo Rodríguez
f63b093d24
Merge branch '2.0-request' into 2.0
...
Still tons of tests failing
Conflicts:
cake/dispatcher.php
cake/libs/controller/components/auth.php
cake/libs/controller/components/request_handler.php
cake/libs/controller/components/security.php
cake/libs/controller/controller.php
cake/libs/router.php
cake/libs/view/helper.php
cake/libs/view/helpers/html.php
cake/libs/view/view.php
cake/tests/cases/dispatcher.test.php
cake/tests/cases/libs/controller/components/auth.test.php
cake/tests/cases/libs/controller/components/request_handler.test.php
cake/tests/cases/libs/controller/components/security.test.php
cake/tests/cases/libs/controller/controller.test.php
cake/tests/cases/libs/router.test.php
cake/tests/cases/libs/view/helper.test.php
cake/tests/cases/libs/view/helpers/cache.test.php
cake/tests/cases/libs/view/helpers/form.test.php
cake/tests/cases/libs/view/helpers/html.test.php
cake/tests/cases/libs/view/helpers/js.test.php
cake/tests/cases/libs/view/helpers/paginator.test.php
2010-08-27 23:31:41 -04:30
mark_story
f0d938c1cb
Fixing failing tests in scaffold.
2010-08-27 23:59:29 -04:00
mark_story
0683dc43ff
Replacing cakeError calls with exceptions in ConnectionManager and Model.
2010-08-27 23:54:22 -04:00
mark_story
c4cb629d80
Replacing cakeError with exceptions in Scaffold.
2010-08-27 23:54:00 -04:00
mark_story
e600f86abd
Updating Dispatcher test to test for exceptions instead of cake error returns.
...
Removing a test that is no longer valid.
2010-08-27 23:40:22 -04:00
mark_story
b301b0d86e
Adding MissingModelException.
2010-08-27 23:04:35 -04:00
mark_story
caf7668de5
Adding documentation for Dispatcher::dispatch throwing exceptions.
2010-08-27 23:04:09 -04:00
mark_story
a15c4f89b4
Moving calls of cakeError() to using exceptions.
2010-08-27 22:59:48 -04:00
mark_story
1980c924b9
Adding RuntimeException classes for Dispatcher.
2010-08-27 22:48:02 -04:00
mark_story
1e6064ceae
Removing the last exclusion from the AllHelper group.
2010-08-26 23:31:25 -04:00
mark_story
1a52442057
Removing class_exists() check as the class is now lazy loaded.
2010-08-26 23:26:18 -04:00
mark_story
6c87a026b6
Updating base class.
2010-08-26 23:24:32 -04:00
mark_story
4cc2229641
Updating CacheHelper to use correct View API.
...
Updating View to make CacheHelper tests pass.
2010-08-26 23:24:09 -04:00
mark_story
19e301c867
Updating test view to use correct helper syntax.
2010-08-26 23:19:20 -04:00
mark_story
b02e213958
Adding test case from '0x20h'. Fixing issue where atomic = false, validate = first and saveAll() saving many rows could return an incorrect value. Fixes #1050
2010-08-26 22:21:39 -04:00
mark_story
ea9e30890f
Adding a workaround to DboSource::showLog() to work around fix added in [ da9c0da626].
...
Also adding explanation message when logs are not generated.
2010-08-26 21:24:09 -04:00
mark_story
123873b4d8
Updating DboSource test to account for formatting of floats done in mysql/postgresql.
2010-08-26 21:20:13 -04:00
dogmatic69
95168cee6e
casting the find as an array to avoid errors with array_values() fixes #1041 and 4 failing tests (3 previous)
...
Signed-off-by: mark_story <mark@mark-story.com>
2010-08-26 20:32:48 -04:00
mark_story
465c24f903
Adding a test case for TextHelper::toList(). Closes #1043
2010-08-26 20:30:30 -04:00
mark_story
903b260638
Changing spaces to tabs.
2010-08-26 20:29:03 -04:00
mark_story
c48c0d6295
Fixing issue where ViewTask would make empty view files for actions that did not have templates. Test case added. Fixes #1040
2010-08-23 21:49:30 -04:00
mark_story
ece055eefe
Adding object type check to prevent fatal errors caused by view being used like a model object. Tests added. Fixes #1039
2010-08-23 21:39:23 -04:00
mark_story
b5b7595bc0
Fixing issue in scaffold where it accessed $output, which no longer exists.
2010-08-22 12:41:04 -04:00
mark_story
91c9c74274
Removing response injection into controller from dispatcher.
...
Modifying Dispatcher to use accessor method.
2010-08-22 12:40:06 -04:00
mark_story
7221f9c3b9
Moving response construction into Controller, this will let controller classes more easily modify the response subclass they want to use.
...
Test case updated.
2010-08-22 12:31:55 -04:00
mark_story
44f1687f5b
Adding another test.
2010-08-22 00:54:55 -04:00
mark_story
efc1a2033f
Adding spaces infront of comment blocks.
2010-08-22 00:48:24 -04:00
mark_story
ec22db597f
Adding methods to get host, domain and subdomains for a request.
...
Tests added.
2010-08-22 00:44:05 -04:00
mark_story
0ec0962932
Adding CakeRequest::method() to find the name of the HTTP method name used for the request. Test case added.
2010-08-22 00:15:13 -04:00
mark_story
5446a062ee
Fixing issue where whitelist would not be used for validation. Test case added. Fixes #1037
2010-08-21 22:48:59 -04:00
mark_story
12d4b52f10
Fixing failing tests in DboMysql and DboPostgres related to localized floats. Refs #1029
2010-08-21 00:49:40 -04:00
mark_story
eb96d8acfb
Adding tests to dbo_postgres for localized floats. Refs #1029
2010-08-21 00:39:45 -04:00
mark_story
afc05c1e05
Adding test cases for using localized floats with mysql. Also added a generic model test case. Refs #1029
2010-08-21 00:19:30 -04:00
mark_story
e23fe25787
Fixing code formatting.
2010-08-21 00:17:40 -04:00
zimakm
b22f2f746b
Configure fix problem 3-dimensional arrays to be handled as 4+ arrays.
...
This saves a lot of execution time when configure holds many values.
Fixes #1028
Signed-off-by: mark_story <mark@mark-story.com>
2010-08-18 22:29:23 -04:00
mark_story
6d8c761f2f
Adding a missing s.
2010-08-17 22:25:45 -04:00
mark_story
750fe3aa05
Removing text() and password() as the new __call method handles them.
...
Updating test cases and adding a test for allowing a magic method to override the type.
2010-08-17 00:13:22 -04:00
mark_story
4efc170ce4
Adding some documentation.
2010-08-17 00:08:41 -04:00
mark_story
e79df23491
Adding a magic __call method to handle html5 inputs and simplify input generation logic.
2010-08-17 00:06:23 -04:00
mark_story
e2fee17173
Adding an ob_end_flush() to clean up an unclosed buffer.
2010-08-16 23:34:43 -04:00
mark_story
4622ec44c2
Updating the skel and app test.php's to not make a global variable for the dispatcher. This dramatically improves the performance of the web test runner.
2010-08-16 23:33:07 -04:00
mark_story
f46241a6e7
Merge branch '2.0' into 2.0-helpers
2010-08-16 23:02:44 -04:00
mark_story
fc9340213e
Applying patch from 'thatcode', makes the 'us' rule case insensitive. Fixes #1020
2010-08-16 22:26:48 -04:00
mark_story
2abf34d93e
Fixing issue where an app that was in a directory that had the same name
...
as a controller would end up failing to find view cache files.
Adding test for app name in controller name failure to create cache
Fixes #1025
Conflicts:
cake/libs/view/helpers/cache.php
2010-08-16 22:11:25 -04:00
mark_story
c4a978d386
Adding changes missed in the merge.
2010-08-15 23:10:29 -04:00
mark_story
705e90bef7
Merge branch '1.3' into 2.0-merge
...
Conflicts:
cake/libs/cache/memcache.php
cake/libs/cake_session.php
cake/libs/model/behaviors/acl.php
cake/tests/cases/dispatcher.test.php
cake/tests/cases/libs/cake_test_fixture.test.php
cake/tests/cases/libs/model/behaviors/acl.test.php
cake/tests/cases/libs/model/datasources/dbo/dbo_postgres.test.php
2010-08-15 23:09:02 -04:00
mark_story
2a50c3a1fb
Removing time manipulation so its possible to create memcache entries that do not expire. Updating documentation about the peculiarities of memcache. Refs #871
2010-08-15 22:40:55 -04:00
mark_story
0865679684
Removing _expires keys made with Memcache cache engine. These did not add any value as Memcache already handles expiration of keys. Fixes #871
2010-08-15 22:32:52 -04:00
mark_story
686b9c2c8b
Fixing issues in alterSchema in DboMysql and DboPostgres, where fields would be appended to each table being altered.
...
Also fixed an issue in DboPostgres where the generated alter statements would contain too many ;.
Test cases added. Fixes #1023
2010-08-15 22:17:02 -04:00
mark_story
aba97d0ab2
Applying patch from 'Mark Mitchell' to fix auto exiting of cake.bat. Fixes #992
2010-08-14 18:54:12 -04:00
mark_story
1b41a987fa
Adding test cases and fixing inflection issues with bases. Tests added. Fixes #1012
2010-08-12 20:26:11 -04:00
mark_story
36e585bb23
Starting to update a test that was previously marked incomplete.
2010-08-11 23:08:46 -04:00
mark_story
238c734f70
Moving a test case that should be implemented in controller, as that is where the code that needs to be tested is located.
2010-08-11 22:47:54 -04:00
mark_story
45064315d4
Fixing a comment.
2010-08-11 22:47:20 -04:00
mark_story
bd89ef533b
Updating session helper constructor to fix failing tests in Controller::render() integration tests.
2010-08-11 00:01:24 -04:00
mark_story
62d646d168
Removing tests that have been implemented elsewhere.
2010-08-10 23:56:39 -04:00
mark_story
74a12940cb
Removing incorrect method implementation.
...
Adding documentation to Component::beforeRedirect()
Adding documentation to ObjectCollection::trigger().
2010-08-10 23:45:28 -04:00
mark_story
4463ff7476
Moving all components suite.
2010-08-10 23:34:20 -04:00
mark_story
2494156e9a
Removing reference operators that caused tests to fail.
...
Adding an alias as several tests relied on a User object being in the registry to autodetect fields.
2010-08-10 23:18:43 -04:00
mark_story
3d5d6f6ebc
Removing two helpers from the exclusions as they don't cause issues anymore.
2010-08-10 23:18:43 -04:00
mark_story
fdfe8060c6
Adding collection tests to test suites.
2010-08-10 23:18:42 -04:00
mark_story
6d9cee57ba
Fixing failing tests from merge with 1.3
2010-08-10 23:18:42 -04:00
mark_story
59c692dbae
Fixing incorrect/failing test in Security component.
2010-08-10 23:18:42 -04:00
mark_story
f5bebc9306
Adding an Acl property to AuthComponent and updating tests to use new API's
2010-08-10 23:18:42 -04:00
mark_story
c6a63bae82
Fixing incorrect method call from merge with 1.3
2010-08-10 23:18:42 -04:00
mark_story
db1acb461a
Making SessionComponent extend Component. Updating test case.
2010-08-10 23:18:42 -04:00
